Re: APACHE_CHECK_NGHTTP2

2015-08-27 Thread Stefan Eissing
Just tried it, cannot get it to work. Some volunteer for this? Am 27.08.2015 um 00:06 schrieb William A Rowe Jr wr...@rowe-clan.net: Just a quick observation before backport of mod_h2 is proposed... Moving the macro APACHE_CHECK_NGHTTP2 out of acinclude.m4 into modules/http2/config.m4

Re: APACHE_CHECK_NGHTTP2

2015-08-27 Thread Stefan Eissing
Ah, got it now. Patch incoming. Am 27.08.2015 um 11:31 schrieb Stefan Eissing stefan.eiss...@greenbytes.de: Just tried it, cannot get it to work. Some volunteer for this? Am 27.08.2015 um 00:06 schrieb William A Rowe Jr wr...@rowe-clan.net: Just a quick observation before backport

Re: modules\http2 - H2Engine directive?

2015-08-27 Thread Stefan Eissing
Am 27.08.2015 um 10:22 schrieb jean-frederic clere jfcl...@gmail.com: On 08/24/2015 10:06 AM, Stefan Eissing wrote: Ni Norm, yes, I removed it last week If I want on VirtualHost with h2 support and another one without how should I do that? (that is for demo purpose) Cheers Jean

Re: modules\http2 - H2Engine directive?

2015-08-27 Thread Stefan Eissing
, curl, python works right out of the box. //Stefan Am 27.08.2015 um 10:22 schrieb jean-frederic clere jfcl...@gmail.com: On 08/24/2015 10:06 AM, Stefan Eissing wrote: Ni Norm, yes, I removed it last week If I want on VirtualHost with h2 support and another one without how should I do

Re: proposed backport, mod_h2 github release

2015-08-27 Thread Stefan Eissing
Am 26.08.2015 um 23:21 schrieb Gregg Smith g...@gknw.net: On 8/26/2015 6:44 AM, Stefan Eissing wrote: I just submitted my first backport STATUS update. Hope I did everything ok, otherwise please let me know. For backporting mod_h2 to 2.4.x, I decided to make it in two parts: one

Re: svn commit: r1698117 - /httpd/httpd/branches/2.4.x/STATUS

2015-08-27 Thread Stefan Eissing
Am 27.08.2015 um 13:34 schrieb Yann Ylavic ylavic@gmail.com: On Thu, Aug 27, 2015 at 1:25 PM, ic...@apache.org wrote: Author: icing Date: Thu Aug 27 11:25:09 2015 New Revision: 1698117 URL: http://svn.apache.org/r1698117 Log: adding r1698116 to core-protocols.patch to clarify new

scoreboard full

2015-08-31 Thread Stefan Eissing
Hunting a bit on the "scoreboard is full, not at MaxRequestWorkers" issue, I found that setting c->cs->state = CONN_STATE_LINGER; explicitly on exiting connection processing (h2_conn.c) seems to help with this. As an experiment, I set c->cs->state = CONN_STATE_READ_REQUEST_LINE; and

Re: HTTP_MISDIRECTED_REQUEST

2015-08-31 Thread Stefan Eissing
> Am 28.08.2015 um 15:49 schrieb Eric Covener <cove...@gmail.com>: > > On Fri, Aug 28, 2015 at 9:26 AM, Stefan Eissing > <stefan.eiss...@greenbytes.de> wrote: >> If this works, one could think about introducing some kind of "equivalence >> number" t

Re: scoreboard full

2015-09-01 Thread Stefan Eissing
> Am 31.08.2015 um 22:19 schrieb Yann Ylavic <ylavic@gmail.com>: > > On Mon, Aug 31, 2015 at 6:11 PM, Stefan Eissing > <stefan.eiss...@greenbytes.de> wrote: >> Hunting a bit on the "scoreboard is full, not at MaxRequestWorkers" issue, >&g

Re: svn commit: r1695727 - in /httpd/httpd/trunk: docs/manual/mod/core.xml include/http_core.h server/core.c server/protocol.c

2015-09-02 Thread Stefan Eissing
We can choose any string we want, but for ALPN negotiation there is only http/1.1 defined. We could of course translate that but then we need to explain somewhere what we mean by it. For the Upgrade case, we could ap_get_protocol make return exactly what the client sent us. But accomodating

Re: svn commit: r1695727 - in /httpd/httpd/trunk: docs/manual/mod/core.xml include/http_core.h server/core.c server/protocol.c

2015-09-02 Thread Stefan Eissing
If we want to be more safe, we can change the Protocols default to just http/1.1. Also the default for ordering we can change, np. Other opinions? For ALPN, afaik the callback only gets triggered if the client actually sends ALPN in its hello. Since "http/1.1" is the only identifier defined

httpd/trunk -Werror and warning free

2015-09-04 Thread Stefan Eissing
Below you find a patch that would make httpd/trunk - set -std=c89 on gcc in maintainer mode - abort compilation on every warning (-Werror) in maintainer-mode - fix all warnings that are currently there Please consider over the weekend. I would very much like to have that applied so all my C89

Re: proposed backport of mod_h2 - v4

2015-09-05 Thread Stefan Eissing
yes, it should. where do you not see it? (i wish we'd use branches instead of this patch file madness) > Am 05.09.2015 um 06:12 schrieb Gregg Smith : > > Shouldn't this be ap_array_str_contains now in h2_switch.c? > > +while (*protos) { > +/* Add all protocols we

Re: proposed backport of mod_h2 - v4

2015-09-07 Thread Stefan Eissing
. I hope this works well for everyone. cheers, Stefan > Am 05.09.2015 um 16:21 schrieb Graham Leggett <minf...@sharp.fm>: > > On 05 Sep 2015, at 9:21 AM, Stefan Eissing <stefan.eiss...@greenbytes.de> > wrote: > >> yes, it should. where do you not see it?

Re: proposed backport of mod_h2 - v4

2015-09-08 Thread Stefan Eissing
> Am 08.09.2015 um 03:56 schrieb William A Rowe Jr <wr...@rowe-clan.net>: > > On Sep 7, 2015 1:14 PM, "Stefan Eissing" <stefan.eiss...@greenbytes.de> wrote: > > > > Thanks, new branch to bring in protocols and mod_h2 is at > > > > &g

Re: svn commit: r1692486 [1/2] - in /httpd/httpd/trunk: docs/log-message-tags/ include/ modules/http2/ modules/ssl/ server/

2015-09-02 Thread Stefan Eissing
om>: > > On Wed, Sep 2, 2015 at 10:01 AM, Stefan Eissing > <stefan.eiss...@greenbytes.de> wrote: >> Hmm. Is the >> ap_hook_handler(core_upgrade_handler,NULL,NULL,APR_HOOK_REALLY_FIRST); >> called for requests that mod_proxy_wstunnel makes against a backend? &

Re: svn commit: r1692486 [1/2] - in /httpd/httpd/trunk: docs/log-message-tags/ include/ modules/http2/ modules/ssl/ server/

2015-09-02 Thread Stefan Eissing
> Am 02.09.2015 um 15:16 schrieb Yann Ylavic : > > I wonder how these handlers interact with mod_proxy_wstunnel which > needs to handle the Upgrade by itself (after the HTTP header has been > forwarded to the backend). > > I'm not sure we can upgrade unconditionally really

Re: svn commit: r1695727 - in /httpd/httpd/trunk: docs/manual/mod/core.xml include/http_core.h server/core.c server/protocol.c

2015-09-03 Thread Stefan Eissing
Added in r1701005. > Am 03.09.2015 um 11:49 schrieb Yann Ylavic <ylavic@gmail.com>: > > On Wed, Sep 2, 2015 at 7:54 PM, Stefan Eissing > <stefan.eiss...@greenbytes.de> wrote: >> If we want to be more safe, we can change the Protocols default to just

proposed backport of mod_h2

2015-09-02 Thread Stefan Eissing
As in r1700829. Regression tests run (after small change on apache version check in h2.t) on OS X for me. Cheers, Stefan bytes GmbH Hafenweg 16, 48155 Münster, Germany Phone: +49 251 2807760. Amtsgericht Münster: HRB5782

Re: svn commit: r1692486 [1/2] - in /httpd/httpd/trunk: docs/log-message-tags/ include/ modules/http2/ modules/ssl/ server/

2015-09-02 Thread Stefan Eissing
> Am 02.09.2015 um 16:12 schrieb Eric Covener <cove...@gmail.com>: > > On Wed, Sep 2, 2015 at 10:09 AM, Stefan Eissing > <stefan.eiss...@greenbytes.de> wrote: >> But would it have an "Upgrade: + Connection:" header? I might be wrong, but >> I though

Re: svn commit: r1692486 [1/2] - in /httpd/httpd/trunk: docs/log-message-tags/ include/ modules/http2/ modules/ssl/ server/

2015-09-02 Thread Stefan Eissing
> Am 02.09.2015 um 16:19 schrieb Yann Ylavic <ylavic@gmail.com>: > > On Wed, Sep 2, 2015 at 4:04 PM, Eric Covener <cove...@gmail.com> wrote: >> On Wed, Sep 2, 2015 at 10:01 AM, Stefan Eissing >> <stefan.eiss...@greenbytes.de> wrote: >>> Hmm.

Re: r1701005 httpd-trunk\server\protocols.c

2015-09-04 Thread Stefan Eissing
I think we are all tired of fixing compiler warnings on committed code. I do not see those warnings in --maintainer-mode on OS X and yet, clang is able to generate warnings about very, very obscure things. So I assume we are not using the compiler to its fullest extend and are doings this "by

Re: svn commit: r1701005 - in /httpd/httpd/trunk: docs/manual/mod/core.xml include/http_protocol.h modules/ssl/ssl_engine_kernel.c server/core.c server/protocol.c

2015-09-04 Thread Stefan Eissing
Thanks for the patch, Yann! Applied in r1701178. > Am 03.09.2015 um 17:46 schrieb Yann Ylavic : > > On Thu, Sep 3, 2015 at 2:45 PM, wrote: >> Author: icing >> Date: Thu Sep 3 12:45:26 2015 >> New Revision: 1701005 >> >> URL:

Re: proposed backport of mod_h2 - v4

2015-09-08 Thread Stefan Eissing
d easier. > >> On Sep 8, 2015, at 6:10 AM, Stefan Eissing <stefan.eiss...@greenbytes.de> >> wrote: >> >> >>> Am 08.09.2015 um 03:56 schrieb William A Rowe Jr <wr...@rowe-clan.net>: >>> >>> On Sep 7, 2015 1:14 PM, "Stefan Eissing&

warning free, c89 enforced

2015-09-14 Thread Stefan Eissing
With r1702948, all sorts of warnings are enabled on compilation of httpd itself when using GCC, especially the C89 standard is being checked. All warning lead now to compiler errors. There have been only slight changes in code necessary. The static introduced via APLOG_USE_MODULE is being

Re: svn commit: r1702948 - in /httpd/httpd/trunk: acinclude.m4 configure.in include/http_config.h include/scoreboard.h modules/ssl/ssl_engine_kernel.c server/util_expr_eval.c

2015-09-14 Thread Stefan Eissing
> Am 14.09.2015 um 15:52 schrieb Yann Ylavic : > > On Mon, Sep 14, 2015 at 3:29 PM, wrote: >> --- httpd/httpd/trunk/server/util_expr_eval.c (original) >> +++ httpd/httpd/trunk/server/util_expr_eval.c Mon Sep 14 13:29:35 2015 >> @@ -98,7 +98,7 @@ static

Re: 2.4.17-protocols-http2/ - SNI issue

2015-09-16 Thread Stefan Eissing
Good point. Limited online today. If someone wants to give this a shot, please. > Am 16.09.2015 um 11:36 schrieb Yann Ylavic : > > On Wed, Sep 16, 2015 at 11:24 AM, Plüm, Rüdiger, Vodafone Group > wrote: >> >>> -Original Message- >>>

Re: nghttp2 warning - what is this?

2015-09-16 Thread Stefan Eissing
Hi, if you enable all modules, it will enable mod_h2 and that one needs libnghttp2. The warning could be better, if this is missing, admittedly I just copied and modified mod_ssl's test for openssl. //Stefan > Am 16.09.2015 um 17:51 schrieb Michael Felt : > > Hello all,

Re: httpd/trunk -Werror and warning free

2015-09-11 Thread Stefan Eissing
Tried the inline. clang is too smart for that one. Current attempt: #pragma GCC diagnostic ignored "-Wunused-const-variable" explicitly set for module declarations with warning. For including #pragma inside the #define. I did not find a portable way. Can with live with such a pragma in httpd?

Re: svn commit: r1695727 - in /httpd/httpd/trunk: docs/manual/mod/core.xml include/http_core.h server/core.c server/protocol.c

2015-09-15 Thread Stefan Eissing
Uhm, did I mess something up (again)? My core.xml says: ... Protocols Protocols available for a server/virtual host Protocols protocol ... Protocols http/1.1 server configvirtual host Only available from Apache 2.4.17 and later. This directive specifies

Re: svn commit: r1695727 - in /httpd/httpd/trunk: docs/manual/mod/core.xml include/http_core.h server/core.c server/protocol.c

2015-09-15 Thread Stefan Eissing
> Am 15.09.2015 um 13:08 schrieb Yann Ylavic <ylavic@gmail.com>: > > On Tue, Sep 15, 2015 at 10:00 AM, Stefan Eissing > <stefan.eiss...@greenbytes.de> wrote: >> Uhm, did I mess something up (again)? My core.xml says: > > I'm afraid :) Ah! > Both s ar

Re: nghttp2 warning - what is this?

2015-09-17 Thread Stefan Eissing
ot;util_expr_eval.c", line 1812.7: 1506-196 (W) Initialization between types > "const void* const" and "int(*)(struct {...}*,const void*,const char*,const > char*)" is not allowed. > "util_expr_eval.c", line 1813.7: 1506-196 (W) Initialization between types >

r->protocol == HTTP/2

2015-09-11 Thread Stefan Eissing
Looking for some opinions about mod_h2 and r->protocol. Currently, mod_h2 sets that at "HTTP/1.1", which gives of course the best backward compatibility. But it is also a lie. In reality it should be "HTTP/2", independent of the "h2" "h2c" stack names. So, I am considering a directive to

Re: r->protocol == HTTP/2

2015-09-11 Thread Stefan Eissing
I am talking about a h2/h2c connection, where requests do not carry the protocol any longer. > Am 11.09.2015 um 15:02 schrieb Yann Ylavic <ylavic@gmail.com>: > > On Fri, Sep 11, 2015 at 2:49 PM, Stefan Eissing > <stefan.eiss...@greenbytes.de> wrote: >> Looking

Re: svn commit: r1705571 - /httpd/httpd/branches/2.4.x/STATUS

2015-09-28 Thread Stefan Eissing
Adding comment "Added ap_parse_token_list_strict() to httpd.h" and applied patch to http/branches/2.4.17-protocols-http2 //Stefan > Am 27.09.2015 um 22:36 schrieb j...@apache.org: > > Author: jim > Date: Sun Sep 27 20:36:10 2015 > New Revision: 1705571 > > URL:

Re: http/2 in 2.4.x

2015-09-28 Thread Stefan Eissing
Jim, woot! Thx for backporting! > Am 28.09.2015 um 15:27 schrieb Jim Jagielski : > > I have folded the mod_h2-http/2 stuff into 2.4.x... Right now > we are in that middle state where we were trying to figure out > whether it's mod_h2 or http2, and hence _h2_module or

Re: 2.4.17-protocols-http2/ - SNI issue

2015-09-18 Thread Stefan Eissing
I think I found it. Just writing a test case to confirm... > Am 18.09.2015 um 11:35 schrieb Steffen <i...@apachelounge.com>: > > Debug log attached. > > > > On Wednesday 16/09/2015 at 12:06, Plüm wrote: >> >> >>> -----Original Message--

Re: connection reuse and ssl renegotiation

2015-09-23 Thread Stefan Eissing
> Am 23.09.2015 um 14:09 schrieb Eric Covener <cove...@gmail.com>: > > On Wed, Sep 23, 2015 at 7:40 AM, Stefan Eissing > <stefan.eiss...@greenbytes.de> wrote: >> The question then is how we best let other modules stop ssl_hook_Access() >> from performing >

Re: mod_h2 crash

2015-09-23 Thread Stefan Eissing
I think I found a possible race that could cause this. Please install the latest version in 2.4.17-protocols-http2, when you find the time, and let me know if you see any change. //Stefan > Am 23.09.2015 um 11:02 schrieb Steffen : > > In the other thread I wrote: > >

Re: connection reuse and ssl renegotiation

2015-09-23 Thread Stefan Eissing
c <ylavic@gmail.com>: > > On Tue, Sep 22, 2015 at 1:24 PM, Stefan Eissing > <stefan.eiss...@greenbytes.de> wrote: >> >> SSL renegotiation is forbidden in HTTP/2, exactly due to concurrency issues. > > Certainly a concurrency between each one's privacy and ever

Re: svn move modules/http2 modules/h2 ?

2015-09-23 Thread Stefan Eissing
2015 12:39, "Greg Stein" <gst...@gmail.com> wrote: > Yeah... if anything, rename to mod_http2. > > On Tue, Sep 22, 2015 at 12:01 PM, Gregg Smith <g...@gknw.net> wrote: > http2 is more descriptive for the module's purpose, even if the name is > mod_h2. I li

Re: Time for 2.4.17 soonish?

2015-09-22 Thread Stefan Eissing
+1 > Am 22.09.2015 um 21:49 schrieb Jim Jagielski : > > I'd like to propose that we think about a 2.4.17 release > within a coupla weeks and that we try to get http/2 > support in for that release. >

Re: svn move modules/http2 modules/h2 ?

2015-09-22 Thread Stefan Eissing
e module's purpose, even if the name is >> mod_h2. I like it where it is. >> - 0 >> >> >>> On 9/22/2015 5:08 AM, Stefan Eissing wrote: >>> +0.5 >>> >>> h2 ftw! (but there is also a mod_mime in the http dir, so I do not really >>

Re: mod_h2 CTR (Was: Re: svn commit: r1705257 - /httpd/httpd/trunk/modules/http2/config.m4)

2015-09-25 Thread Stefan Eissing
> Am 25.09.2015 um 17:09 schrieb Eric Covener : > > On Fri, Sep 25, 2015 at 11:06 AM, Yann Ylavic wrote: >> On Fri, Sep 25, 2015 at 4:31 PM, Jim Jagielski wrote: >>> I'd like to propose that we consider mod_h2 in 2.4.x as CTR and >>>

Re: 2.4.17-protocols-http2 :: Restarting

2015-09-21 Thread Stefan Eissing
writes) > > https://www.apachelounge.com/ running now with it. > > Steffen > > -----Original Message- From: Stefan Eissing > Sent: Monday, September 21, 2015 11:11 AM > To: dev@httpd.apache.org > Subject: Re: 2.4.17-protocols-http2 :: Restarting > > Yeah, I thin

Re: Thoughts on the new Protocols architecture

2015-09-21 Thread Stefan Eissing
Jacob, thanks a lot for reviewing/implementing it. Having another module use it helps seeing the current weaknesses. Detailed comments inline: > Am 21.09.2015 um 06:22 schrieb Jacob Champion : > > == Immediate Concerns == > > 1) WebSocket requires a handshake to be made

connection reuse and ssl renegotiation

2015-09-22 Thread Stefan Eissing
Just an update on this topic: We currently allow only connection reuse for the server/vhost that was selected by the SNI, thanks to the patch by Yann. However, the problem is deeper than I originally thought: SSL renegotiation is forbidden in HTTP/2, exactly due to concurrency issues. There is

Re: svn move modules/http2 modules/h2 ?

2015-09-22 Thread Stefan Eissing
+0.5 h2 ftw! (but there is also a mod_mime in the http dir, so I do not really feel strongly about this) > Am 22.09.2015 um 14:05 schrieb Yann Ylavic : > > I'm confused about the sources being in modules/http2 and the module > being mod_h2 (configured with --enable-h2,

Re: 2.4.17-protocols-http2/ - SNI issue

2015-09-18 Thread Stefan Eissing
: Re: 2.4.17-protocols-http2/ - SNI issue >> >> On Fri, Sep 18, 2015 at 12:56 PM, Stefan Eissing >> <stefan.eiss...@greenbytes.de> wrote: >>> Ok, what is happening for Steffen is not a bug, but a missing feature. >> The question is how we move forward. >>

Re: 2.4.17-protocols-http2/ - SNI issue

2015-09-18 Thread Stefan Eissing
hat? 3. We can allow 2 only for non-http/1.1 connection protocols 4. We can allow 2 only for h2 connection protocols 5. We can add a config directive to allow 2 (urgs) //Stefan > Am 18.09.2015 um 11:36 schrieb Stefan Eissing <stefan.eiss...@greenbytes.de>: > > I think I found it. Jus

Re: 2.4.17-protocols-http2/ - SNI issue

2015-09-18 Thread Stefan Eissing
t works fine http/1.1 with 2.4.16- >> .. >> .. >> ... >> DocumentRoot >> ServerName >> Listen 443 >> SSLStrictSNIVHostCheck off >> SSLEngine on >> SSLHonorCipherOrder On >> SSLUseStapling on >> SSLCipherSuite ... >&

Re: svn commit: r1703871 - /httpd/httpd/trunk/modules/ssl/ssl_engine_kernel.c

2015-09-19 Thread Stefan Eissing
Thx! done. > Am 18.09.2015 um 17:38 schrieb Yann Ylavic : > > On Fri, Sep 18, 2015 at 4:31 PM, wrote: >> Author: ylavic >> Date: Fri Sep 18 14:31:48 2015 >> New Revision: 1703871 >> >> URL: http://svn.apache.org/viewvc?rev=1703871=rev >> Log: >>

Re: 2.4.17-protocols-http2 :: Restarting

2015-09-21 Thread Stefan Eissing
Yeah, I think when I initially wrote this code, I wanted to err on the side of catching my mistakes. Time to level down the common conditions that happen, e.g. when client just disconnect. > Am 21.09.2015 um 11:05 schrieb Steffen : > > About the huge number of warnings >

Re: svn commit: r1688474 [4/21] - in /httpd/httpd/trunk/modules/http2: ./ m4/ mod-h2.xcodeproj/ mod-h2.xcodeproj/project.xcworkspace/ mod-h2.xcodeproj/project.xcworkspace/xcshareddata/ mod-h2.xcodepro

2015-09-21 Thread Stefan Eissing
Admittedly, my memory is hazy. I cannot really rationalize its existence. This looks wrong now. I will throw it out. > Am 21.09.2015 um 10:53 schrieb Yann Ylavic : > > Hi Stefan, > >> >> Added: httpd/httpd/trunk/modules/http2/mod_h2/h2_conn_io.c >> URL: >>

Re: 2.4.17-protocols-http2 :: Forcing termination of child process

2015-09-21 Thread Stefan Eissing
Thanks for the heads up. The shutdown behaviour is most likely influenced by how many connections are open at that time and http2 connection are kept open longer by clients. Probably we can improve the observed behaviour. There has not been much focus on that part of the protocol handling...

Re: svn commit: r1705257 - /httpd/httpd/trunk/modules/http2/config.m4

2015-09-25 Thread Stefan Eissing
Me not fully understand. Why at all and why only there? (curiousity) > Am 25.09.2015 um 10:54 schrieb rpl...@apache.org: > > Author: rpluem > Date: Fri Sep 25 08:54:38 2015 > New Revision: 1705257 > > URL: http://svn.apache.org/viewvc?rev=1705257=rev > Log: > * Disable the http2 modules if

Re: svn commit: r1705257 - /httpd/httpd/trunk/modules/http2/config.m4

2015-09-25 Thread Stefan Eissing
> Am 25.09.2015 um 12:32 schrieb Yann Ylavic <ylavic@gmail.com>: > > On Fri, Sep 25, 2015 at 11:58 AM, Stefan Eissing > <stefan.eiss...@greenbytes.de> wrote: >> >> I see. And rename the configuration options and documentation, while we are >>

Re: svn commit: r1705257 - /httpd/httpd/trunk/modules/http2/config.m4

2015-09-25 Thread Stefan Eissing
Ah, understood. Thanks! But would it then not make more sense to have both --enable-* do: > APACHE_MODULE(h2, since there is no modules named "http2"? > Am 25.09.2015 um 11:23 schrieb Ruediger Pluem <rpl...@apache.org>: > > > > On 09/25/2015 10:58 AM, Ste

Re: svn commit: r1705257 - /httpd/httpd/trunk/modules/http2/config.m4

2015-09-25 Thread Stefan Eissing
> Am 25.09.2015 um 11:40 schrieb Yann Ylavic <ylavic@gmail.com>: > > On Fri, Sep 25, 2015 at 11:31 AM, Stefan Eissing > <stefan.eiss...@greenbytes.de> wrote: >> >>> APACHE_MODULE(h2, >> >> since there is no modules named "http2&

Re: svn commit: r1706669 - in /httpd/httpd/trunk: ./ include/ modules/http/ modules/ssl/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

2015-10-06 Thread Stefan Eissing
FYI: /trunk no longer works with mod_http2. 2.4.x does. I see missing response data, it seems, so the most likely cause are the changes in filter handling. Did not find the time to investigate further. Please be aware the mod_h2 uses pool/brigade hierarchies in new and unexpected ways. The

Re: 2.4 pause - mod_http2 patchset Upgrade h2c vs mod_ssl Upgrade tls

2015-12-08 Thread Stefan Eissing
> Am 08.12.2015 um 01:58 schrieb William A Rowe Jr : > > On Mon, Dec 7, 2015 at 6:35 PM, Yann Ylavic wrote: > On Tue, Dec 8, 2015 at 1:27 AM, William A Rowe Jr wrote: > > On Mon, Dec 7, 2015 at 6:15 PM, Yann Ylavic

Re: 2.4 pause - mod_http2 patchset Upgrade h2c vs mod_ssl Upgrade tls

2015-12-08 Thread Stefan Eissing
> Am 08.12.2015 um 10:48 schrieb Yann Ylavic : > > On Tue, Dec 8, 2015 at 3:07 AM, William A Rowe Jr wrote: > [...] > That's why I'd rather go with *not* honoring the Upgrade until a > request comes with no body. ++1

Re: 2.4 pause - mod_http2 patchset Upgrade h2c vs mod_ssl Upgradetls

2015-12-08 Thread Stefan Eissing
> Am 07.12.2015 um 23:42 schrieb Jacob Champion : > > On 12/07/2015 02:30 PM, Bert Huijben wrote: >> Is this a h2 limitation or a mod_h2 limitation? >> >> If I would like h2c upgrade from Subversion without an additional >> request I would have to send the upgrade request

Re: 2.4 pause - mod_http2 patchset Upgrade h2c vs mod_ssl Upgrade tls

2015-12-07 Thread Stefan Eissing
015 um 03:50 schrieb William A Rowe Jr <wr...@rowe-clan.net>: > > Sorry it took so long to respond to this earlier post, some of this might > have already been covered... > >> On Mon, Dec 7, 2015 at 1:03 PM, Stefan Eissing >> <stefan.eiss...@greenbytes.de> wrote

Re: Upgrade Summary

2015-12-08 Thread Stefan Eissing
Bert, why can't you use h2c in direct mode? I assume you could store server support for this in the checkout meta data somewhere. //Stefan > Am 08.12.2015 um 11:30 schrieb Bert Huijben <b...@qqmail.nl>: > >> -Original Message----- >> From: Stefan Eis

Upgrade Summary

2015-12-08 Thread Stefan Eissing
sed scheme? Anything I missed? PS. Re 5: with change 1+4, a TLS upgrade switcher could install an output filter, return and have it being processed normally. The output filter would then send the 101 and do the TLS handshake. Would that work? > Am 08.12.2015 um 10:42 schrieb Stefan Eiss

Re: 2.4 pause - mod_http2 patchset Upgrade h2c vs mod_ssl Upgradetls

2015-12-08 Thread Stefan Eissing
<b...@qqmail.nl>: > > > >> -Original Message- >> From: Stefan Eissing [mailto:stefan.eiss...@greenbytes.de] >> Sent: dinsdag 8 december 2015 10:43 >> To: dev@httpd.apache.org >> Subject: Re: 2.4 pause - mod_http2 patchset Upgrade h2c vs mod_s

Re: Upgrade Summary

2015-12-08 Thread Stefan Eissing
> Am 08.12.2015 um 12:18 schrieb Yann Ylavic <ylavic@gmail.com>: > > On Tue, Dec 8, 2015 at 11:54 AM, Stefan Eissing > <stefan.eiss...@greenbytes.de> wrote: >> >> Am 08.12.2015 um 11:44 schrieb Yann Ylavic <ylavic@gmail.com>: >>>

Re: Upgrade Summary

2015-12-08 Thread Stefan Eissing
> Am 08.12.2015 um 14:08 schrieb Bert Huijben : > [...] > (I'm pretty sure we find new interesting proxy server scenarios :-( ) Not only that. Someone tested h2c against his server from various Tor exit nodes and got a failure rate > 10% because of network middle boxes... Fun

Re: Upgrade Summary

2015-12-08 Thread Stefan Eissing
> Am 08.12.2015 um 11:44 schrieb Yann Ylavic <ylavic@gmail.com>: > > On Tue, Dec 8, 2015 at 11:07 AM, Stefan Eissing > <stefan.eiss...@greenbytes.de> wrote: >> [...] >> Open: >> 1. Protocols like Websocket need to take over the 101 sending the

Re: Upgrade Summary

2015-12-08 Thread Stefan Eissing
> Am 08.12.2015 um 12:40 schrieb Bert Huijben <b...@qqmail.nl>: >> -Original Message- >> From: Stefan Eissing [mailto:stefan.eiss...@greenbytes.de] >> Sent: dinsdag 8 december 2015 11:55 >> To: dev@httpd.apache.org >> Subject: Re: Upgrade Summary &g

Re: Upgrade Summary

2015-12-08 Thread Stefan Eissing
in delaying 2.4.18 at this point and rather give us time to change it later, so it works for everyone. //Stefan > Am 08.12.2015 um 13:46 schrieb Bert Huijben <b...@qqmail.nl>: > > > >> -Original Message- >> From: Stefan Eissing [mailto:stefan.eiss...@gre

2.4.18 T

2015-12-07 Thread Stefan Eissing
Everything as it should be from mod_http2 for this. //Stefan PS. Had one changed to the mod_http2.xml and when I 'make docs'ed it, I got too many changes locally. If someone with more knowledge than me on this would be so kind...

Re: mod_http2 1.0.7+ and Drupal (Was: No H2 Window updates!)

2015-12-07 Thread Stefan Eissing
cess_status = ap_run_post_read_request(new))) { > 83750 fielding ap_die(access_status, new); > 83750 fielding return NULL; > 83750 fielding } > > That's some ancient mojo there :) > > > On Mon, Dec 7, 2015 at 6:46 AM, Stefan Eissing <stefa

Re: Upgrade when !ap_request_has_body(r) only for 2.4.18? (was: svn commit: r1718595 - /httpd/httpd/branches/2.4.x/STATUS)

2015-12-08 Thread Stefan Eissing
With the current implementation, that seems wise. This restriction can be removed once the change we discussed with output filter/hook is working. > Am 08.12.2015 um 14:37 schrieb Yann Ylavic : > > On Tue, Dec 8, 2015 at 2:30 PM, wrote: >> Author: ylavic

Re: Upgrade when !ap_request_has_body(r) only for 2.4.18? (was: svn commit: r1718595 - /httpd/httpd/branches/2.4.x/STATUS)

2015-12-08 Thread Stefan Eissing
> Am 08.12.2015 um 16:18 schrieb William A Rowe Jr <wr...@rowe-clan.net>: > > On Tue, Dec 8, 2015 at 8:34 AM, Stefan Eissing <stefan.eiss...@greenbytes.de> > wrote: > +1 for deferring any upgrade changes that do not fix real issues - like the > one proposed fo

Re: Upgrade when !ap_request_has_body(r) only for 2.4.18? (was: svn commit: r1718595 - /httpd/httpd/branches/2.4.x/STATUS)

2015-12-08 Thread Stefan Eissing
+1 for deferring any upgrade changes that do not fix real issues - like the one proposed for backport by Bill - to 2.4.19 > Am 08.12.2015 um 15:29 schrieb William A Rowe Jr : > > On Tue, Dec 8, 2015 at 7:37 AM, Yann Ylavic wrote: > On Tue, Dec 8, 2015 at

Re: Protocol API @bug warnings for 2.4.18?

2015-12-08 Thread Stefan Eissing
+1 Fine by me. > Am 08.12.2015 um 16:31 schrieb William A Rowe Jr <wr...@rowe-clan.net>: > > On Tue, Dec 8, 2015 at 9:21 AM, Stefan Eissing <stefan.eiss...@greenbytes.de> > wrote: > > > On Tue, Dec 8, 2015 at 8:34 AM, Stefan Eissing > > <s

Re: No H2 Window updates!

2015-12-02 Thread Stefan Eissing
Please find with r1717641 version 1.0.9-DEV of mod_http2 in trunk and branches/2.4.x that fixes the issue of streams with smallish inputs and lost WINDOW_UPDATEs. Please report back if this works for you. I have another time slot on Friday where I can follow up on it. Thanks. //Stefan

Re: No H2 Window updates!

2015-12-04 Thread Stefan Eissing
That is unfortunate. I added a test case which reproduced window exhaustion before I fixed it. What sort of requests do still miss window updates? content-length? response codes? thx. Am 04.12.2015 um 02:36 schrieb Bert Huijben <b...@qqmail.nl>: >> -Original Message----- >

Re: Broken 2.4 ./configure

2015-12-04 Thread Stefan Eissing
mod_http2 in /trunk now checks for a minimum nghttp2 version of 1.2.1 and #ifdefs code accordingly. Will backport to 2.4.x later together with other changes. > Am 04.12.2015 um 09:19 schrieb William A Rowe Jr <wr...@rowe-clan.net>: > > On Wed, Dec 2, 2015 at 5:24 PM,

Re: No H2 Window updates!

2015-12-04 Thread Stefan Eissing
the hanger. //Stefan > Am 04.12.2015 um 10:50 schrieb Bert Huijben <b...@qqmail.nl>: > >> -Original Message----- >> From: Stefan Eissing [mailto:stefan.eiss...@greenbytes.de] >> Sent: vrijdag 4 december 2015 10:18 >> To: dev@httpd.apache.org

Re: mod_http2 1.0.7+ and Drupal (Was: No H2 Window updates!)

2015-12-06 Thread Stefan Eissing
Jan, thanks for tracking this down to the duplicate headers. I will look into it. Just to be sure I got everything right: you tested against the mod_h2 github versions? > Am 06.12.2015 um 07:53 schrieb Jan Ehrhardt : > > Jan Ehrhardt in gmane.comp.apache.devel (Sun, 06 Dec

scoreboard and http2

2015-12-09 Thread Stefan Eissing
For the next 2.4 release, I would like to add scoreboard support to mod_http2. There are several options for doing so and I would like your feedback on which route we should take. I try to outline what options I see: A) Make mod_http2 workers general MPM workers. They would then become part

Re: svn commit: r1717970 - /httpd/test/mod_h2/trunk/test/test_window_update.sh

2015-12-04 Thread Stefan Eissing
I can certainly try more scenarios. The ones there in the tests reflect the problems I have seen and verify the fixes I did. If you have a h2load scenario that reproduces what you see, that could be very helpful. Alternatively, what would I have to do to run your test on my machine? > Am

Re: No H2 Window updates! (Probably a Serf issue!)

2015-12-04 Thread Stefan Eissing
pd.apache.org >> Subject: RE: No H2 Window updates! (Probably a Serf issue!) >> >> >> >>> -Original Message- >>> From: Bert Huijben [mailto:b...@qqmail.nl] >>> Sent: vrijdag 4 december 2015 21:45 >>> To: dev@httpd.apache.org >>&

Re: No H2 Window updates!

2015-12-04 Thread Stefan Eissing
you see? some data would be helpful here. > Am 04.12.2015 um 18:42 schrieb Bert Huijben <b...@qqmail.nl>: > > > >> -Original Message- >> From: Stefan Eissing [mailto:stefan.eiss...@greenbytes.de] >> Sent: vrijdag 4 december 2015 16:23 >> To:

Re: No H2 Window updates!

2015-12-04 Thread Stefan Eissing
> Am 04.12.2015 um 20:51 schrieb Jan Ehrhardt <php...@ehrhardt.nl>: > > Stefan Eissing in gmane.comp.apache.devel (Fri, 4 Dec 2015 16:23:19 > +0100): >> If you find the time, the lastest v1.0.10 mod_http2 in 2.4.x sets the >> connection window to max which addresse

Re: NOTICE: Intent to T 2.4.18

2015-12-05 Thread Stefan Eissing
Excellent! I have one proposed backport regarding ssl vars and slave connections. If someone finds the time to look at it, that'd be great. It makes http2 work better with var checks for HTTPS in .htaccess files. > Am 05.12.2015 um 22:42 schrieb Jim Jagielski : > > With the

Re: Broken 2.4 ./configure

2015-12-02 Thread Stefan Eissing
I put it on my TODO for friday, maybe I can conf/ifdef around it without too much pain. > Am 02.12.2015 um 23:16 schrieb William A Rowe Jr : > >> On Wed, Dec 2, 2015 at 3:06 PM, Reindl Harald wrote: >> >>> Am 02.12.2015 um 21:53 schrieb William A

Re: AW: 2.4 pause - mod_http2 patchset Upgrade h2c vs mod_ssl Upgrade tls

2015-12-07 Thread Stefan Eissing
h2 does not propose a switch if the request has a body. As clarified on the http wg lists by the gurus there, when i asked, the upgraded connection is in a mixed state after a 101. Any byte sent by the server MUST be from the switched protocol, while the client needs to send the body in

Re: mod_http2 1.0.7+ and Drupal (Was: No H2 Window updates!)

2015-12-07 Thread Stefan Eissing
5, at 6:33 AM, Jan Ehrhardt <php...@ehrhardt.nl> wrote: >> >> Stefan Eissing in gmane.comp.apache.devel (Sun, 6 Dec 2015 09:26:56 +0100): >>> Jan, thanks for tracking this down to the duplicate headers. I will look >>> into it. >>> >>> Just to b

Re: No H2 Window updates!

2015-12-07 Thread Stefan Eissing
Jan, if you could find the time to verify that the duplicate headers are gone in the current 2.4.x version, that'd be nice. Thanks! //Stefan > Am 06.12.2015 um 07:21 schrieb Jan Ehrhardt <php...@ehrhardt.nl>: > > Stefan Eissing in gmane.comp.apache.devel (Fri, 4 Dec 2015 2

Re: 2.4 pause - mod_http2 patchset Upgrade h2c vs mod_ssl Upgrade tls

2015-12-07 Thread Stefan Eissing
There can be no 100 after a 101. After a 101, the downstream speaks the new protocol, immediately. > Am 07.12.2015 um 21:29 schrieb William A Rowe Jr : > >> On Mon, Dec 7, 2015 at 2:15 PM, Jacob Champion wrote: >> On Dec 7, 2015 8:43 AM, "William A

Re: 2.4 pause - mod_http2 patchset Upgrade h2c vs mod_ssl Upgrade tls

2015-12-07 Thread Stefan Eissing
. When writing the current code, I wanted the common tasks in core. But if that needs to vary, we need to shift that. > Am 07.12.2015 um 21:39 schrieb Stefan Eissing <stefan.eiss...@greenbytes.de>: > > There can be no 100 after a 101. After a 101, the downstream speaks the

Re: 2.4 pause - mod_http2 patchset Upgrade h2c vs mod_ssl Upgrade tls

2015-12-07 Thread Stefan Eissing
Not at my machine to really check the runtime behaviour. Can do that tomorrow. My thoughts so far: - the return code was not checked intentionally. Once the 101 intermediate response is sent, there is nothing core can do on the connection. It has been switched to a protocol unknown to core.

Re: svn commit: r1719403 - in /httpd/httpd/trunk: CHANGES modules/http2/h2_conn.c modules/http2/h2_h2.c modules/http2/h2_io.c modules/http2/h2_io.h modules/http2/h2_mplx.c modules/http2/h2_stream.c mo

2015-12-11 Thread Stefan Eissing
> Am 11.12.2015 um 14:55 schrieb Yann Ylavic : > > Hi Stefan, > > On Fri, Dec 11, 2015 at 1:57 PM, wrote: >> Author: icing >> Date: Fri Dec 11 12:57:32 2015 >> New Revision: 1719403 >> >> URL: http://svn.apache.org/viewvc?rev=1719403=rev >> Log: >>

Re: mod_http2 and rejecting HTTP/1 requests...

2015-12-10 Thread Stefan Eissing
> Am 09.12.2015 um 19:06 schrieb William A Rowe Jr : > > I think I know where this author was misguided... > > On Dec 9, 2015 11:19, "William A Rowe Jr" wrote: > > > > And then I'm reading a really nonsensical comment in this FAQ... > > > >

Re: [RESULT] Was: [VOTE] Release Apache httpd 2.4.18 as GA

2015-12-14 Thread Stefan Eissing
Thanks for RMing, Jim! > Am 11.12.2015 um 23:23 schrieb Jim Jagielski : > > With more than the required 3 +1 (binding) votes, I call > the VOTE closed with the result that the VOTE PASSES. > > I will start moving the artifacts so the mirrors can collect > them over the

Re: Weird behaviour with mod_ssl and SSLCryptoDevice

2015-12-14 Thread Stefan Eissing
You're certain it's only loaded once? > Am 14.12.2015 um 14:12 schrieb jean-frederic clere : > >

<    1   2   3   4   5   6   7   8   9   10   >