Re: [DISCUSSION] Ignite.C++ and CMake

Hello! Ivan, you really really need to move these two dots as a first argument in your example, instead of a last one, or people will going to hit this issue every time they try CMake. Regards, -- Ilya Kasnacheev ср, 1 июл. 2020 г. в 06:18, Ivan Daschinsky : > Pavel, pay attention to two

Re: [DISCUSSION] Ignite.C++ and CMake

I think we could add a script or two, like cmake-build.sh and ctest.sh, which work right away and can be used as a reference. This is useful for Igniters like me who need to check some C++ related things quickly, but do that rarely enough to forget the build system quirks. On Wed, Jul 1, 2020 at

Re: [DISCUSSION] Ignite.C++ and CMake

No, I am really curious if this instruction complete or not. Actually, Ilya Kasnacheev asked me about the same thing as you. And may be instruction is not so obvious and should be reworked. You know, that developers are not usually great in writing documentation. ср, 1 июл. 2020 г., 10:37 Pavel

Re: [DISCUSSION] Ignite.C++ and CMake

Ivan, Thank you for such a detailed explanation! I am sorry if I upset you. I just wanted to make sure that instructions are correct, and I simply missed those 2 dots. Now it all works perfectly. Pavel On Wed, Jul 1, 2020 at 8:09 AM Ivan Daschinsky wrote: > Let me explain with details. > >

Re: [DISCUSSION] Ignite.C++ and CMake

Let me explain with details. CMake is unusual from other build systems, that it can separate build root and source root. Moreover, it is strongly discouraged to mix them. Benefits: 1. You can have many build with different options using same source. 2. You can build project with different

Re: [DISCUSSION] Ignite.C++ and CMake

Pavel, pay attention to two dots at the end. All build files should stay at current dir, and cmake-build-release is supposed to be a build root. And this directory is added to gitignore. Actually, build directory can be everywhere, but you should pass path to dir, that contains root

Re: [DISCUSSION] Ignite.C++ and CMake

This is awesome, thanks everyone! I've tried following the instructions, and the following two steps seem to be misleading: * mkdir cmake-build-[release|debug] * cd ./cmake-build-[release|debug] When I run cmake in the newly created cmake-build-debug dir, I get: CMake Error: The source directory

Re: [DISCUSSION] Ignite.C++ and CMake

Ok, CMake now is the only option to build C++ on non-windows platforms. Autotools is removed from master. Many thanks to Igor Sapego, Zhenya Stanilovsky, Nickolay Izhikov and Ilya Kasnacheev for review, testing and suggestions. вт, 23 июн. 2020 г. в 18:42, Ivan Daschinsky : > I suppose, that

Re: [DISCUSSION] Ignite.C++ and CMake

I suppose, that removal of autotools from source code is a question of a week. There is no need to support it. вт, 23 июн. 2020 г., 18:38 Ilya Kasnacheev : > Hello! > > Once you do that, I think it would make sense to remove autotools > invocation from artifact build process. In the future we

Re: [DISCUSSION] Ignite.C++ and CMake

Hello! Once you do that, I think it would make sense to remove autotools invocation from artifact build process. In the future we may choose to remove autotools support entirely. Regards, -- Ilya Kasnacheev вт, 23 июн. 2020 г. в 18:00, Petr Ivanov : > That host was down for some time and got

Re: [DISCUSSION] Ignite.C++ and CMake

That host was down for some time and got up only recently. Installed cmake there also. > On 23 Jun 2020, at 17:39, Ivan Daschinsky wrote: > > Petr, I see, that cmake is missing on aitc10_05 but it is in pool and > trying to run build. > > [1] -- >

Re: [DISCUSSION] Ignite.C++ and CMake

Petr, I see, that cmake is missing on aitc10_05 but it is in pool and trying to run build. [1] -- https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_PlatformCPPCMakeLinux/5412025 вт, 23 июн. 2020 г. в 17:33, Ivan Daschinsky : > >> For the sake of discretion, I'd purpose to

Re: [DISCUSSION] Ignite.C++ and CMake

>> For the sake of discretion, I'd purpose to remove old suites from Run All and archive or pause them for some time before removal. Agree, I was talking about removal from RunAll chain, complete removal is not necessary. But after private discussion with Igor Sapego, me and he decided to wait for

Re: [DISCUSSION] Ignite.C++ and CMake

For the sake of discretion, I'd purpose to remove old suites from Run All and archive or pause them for some time before removal. > On 23 Jun 2020, at 13:26, Nikolay Izhikov wrote: > >> So, folks, is it ok to remove old suites from build chain > > +1 from me. > > >> 23 июня 2020 г., в

Re: [DISCUSSION] Ignite.C++ and CMake

> So, folks, is it ok to remove old suites from build chain +1 from me. > 23 июня 2020 г., в 13:15, Ivan Daschinsky написал(а): > > Well, new suites added to RunAll and all seems to be ok. > > I think it is time to remove old suites. > WDYT? > > Also, I created patch with removal of

Re: [DISCUSSION] Ignite.C++ and CMake

Well, new suites added to RunAll and all seems to be ok. I think it is time to remove old suites. WDYT? Also, I created patch with removal of autotools, but old suites should be removed first. So, folks, is it ok to remove old suites from build chain? вт, 23 июн. 2020 г. в 10:36, Ivan

Re: [DISCUSSION] Ignite.C++ and CMake

Ok, I changed agents requirements to builds and add them to runAll пн, 22 июн. 2020 г. в 22:39, Petr Ivanov : > Cmake is installed on all agents (except 10 which is currently down and > will be updated later). > > > > On 22 Jun 2020, at 21:03, Ivan Daschinsky wrote: > > > > Well, patch is

Re: [DISCUSSION] Ignite.C++ and CMake

Cmake is installed on all agents (except 10 which is currently down and will be updated later). > On 22 Jun 2020, at 21:03, Ivan Daschinsky wrote: > > Well, patch is merged. Thank a lot to Igor Sapego for review. > > Peter, well, cmake now can be installed on all agent. > > I think it's

Re: [DISCUSSION] Ignite.C++ and CMake

Well, patch is merged. Thank a lot to Igor Sapego for review. Peter, well, cmake now can be installed on all agent. I think it's time to add cmake suites to runAll and exclude old suites from it. Patch with removing autotools I Will submit in few days. пн, 22 июн. 2020 г., 20:25 Ivan

Re: [DISCUSSION] Ignite.C++ and CMake

Hi folks! Good news -- I successfully created 2 CMake suites [1] [2] and they works as a charm. Many thanks to Ilya Kasnacheev for giving me permissions and to Peter Ivanov for installing cmake and giving a whole agent for testing. [1] --

Re: [DISCUSSION] Ignite.C++ and CMake

Hello! I think you should contact Peter Ivanov if you want anything to be installed on agents. Regards, -- Ilya Kasnacheev пн, 22 июн. 2020 г. в 12:00, Ivan Daschinsky : > Actually, I'm going to create 2 new suites based on existing ones: > 1. Platform C++ CMake (Linux) > 2. Platform C++

Re: [DISCUSSION] Ignite.C++ and CMake

Actually, I'm going to create 2 new suites based on existing ones: 1. Platform C++ CMake (Linux) 2. Platform C++ CMake (Linux Clang) Ilya, thank you very much. But, despite the fact, that I have permissions, it seems that it's impossible to install something (namely, CMake) on agents. How can I

Re: [DISCUSSION] Ignite.C++ and CMake

Hello! I have assigned roles on TC, you can now work on these builds. Please describe your changes on development list so that people understand what is going on. Regards, -- Ilya Kasnacheev вс, 21 июн. 2020 г. в 17:35, Ivan Daschinsky : > Hi folks. > > Patch is rigorously tested and with

Re: [DISCUSSION] Ignite.C++ and CMake

Hi folks. Patch is rigorously tested and with Igor Sapego help it is possible to build with cmake Ignite.C++ even on windows. But, it's required to make some TC suites and tune them, in order to patch be merged. Unfortunately, I am not a commiter and I doesn't have rights to create suites. Also,

Re: [DISCUSSION] Ignite.C++ and CMake

Hello. I will do review of this changes. > 1 июня 2020 г., в 13:21, Ivan Daschinsky написал(а): > > Igor, could you please check my PR? > > пт, 29 мая 2020 г. в 15:28, Ivan Daschinsky : > >> Thanks you all. Run patch (I've changed some code also) on TC -- all CPP >> suites are green (GCC,

Re: Re[2]: [DISCUSSION] Ignite.C++ and CMake

Thanks you all. Run patch (I've changed some code also) on TC -- all CPP suites are green (GCC, CLang, Win64) пт, 29 мая 2020 г. в 15:02, Zhenya Stanilovsky : > > > Ivan besides documentation [1] > -s no — no works > -- catch_system_errors =no — works properly well, tests are passed. > > boost

Re[2]: [DISCUSSION] Ignite.C++ and CMake

Ivan besides documentation [1] -s no —  no works -- catch_system_errors =no — works properly well, tests are passed.   boost 1.65   [1]  https://www.boost.org/doc/libs/1_65_0/libs/test/doc/html/boost_test/utf_reference/rt_param_reference/catch_system.html   >Hello! > >I didn't check tests since

Re: [DISCUSSION] Ignite.C++ and CMake

Hello! I didn't check tests since I don't develop AI C++, merely use it as user. That's where we should wait for Igor Sapego to check. Regards, -- Ilya Kasnacheev пт, 29 мая 2020 г. в 12:20, Ivan Daschinsky : > Ilya, thanks a lot! What about tests? I found one flag that must be > supplied to

Re: [DISCUSSION] Ignite.C++ and CMake

Also without with flag we can observe many failures of suites on TC https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_PlatformCLinux?branch=%3Cdefault%3E=builds#all-projects пт, 29 мая 2020 г. в 12:20, Ivan Daschinsky : > Ilya, thanks a lot! What about tests? I found one flag

Re: [DISCUSSION] Ignite.C++ and CMake

Ilya, thanks a lot! What about tests? I found one flag that must be supplied to boost.tests. This flag should fix JVM crash of C++ suites on Linux. Zhenya Stanilovsky and me have checked, that without this flag tests failed with SIGSEGV early (boost catch this signal from jvm, but it is ok for

Re: [DISCUSSION] Ignite.C++ and CMake

Hello! Looks good to me! But we probably also ask Igor to take a look. Compiled debug and release, without and with odbc, checked running thick node and ODBC connection on Linux. Regards, -- Ilya Kasnacheev чт, 28 мая 2020 г. в 17:31, Ivan Daschinsky : > Ok, PR is ready >

Re: [DISCUSSION] Ignite.C++ and CMake

Ok, PR is ready https://issues.apache.org/jira/browse/IGNITE-13078 Build tested on Mac OS X 10.15 and Ubuntu 20.04 with CMake 3.17.2 and 3.6.1 Unfortunately, I was not able to test on Windows, but principally it should works, but minor issues are probable. Instruction is attached in PR. Any use

Re: [DISCUSSION] Ignite.C++ and CMake

Stephen, looks great! I do mostly the same things in C++ code. Thank you! вт, 26 мая 2020 г. в 18:33, Stephen Darlington < stephen.darling...@gridgain.com>: > Not sure if it’ll help, but I made some changes to get it working on a Mac > with the current built system. There may be some code worth

Re: [DISCUSSION] Ignite.C++ and CMake

Not sure if it’ll help, but I made some changes to get it working on a Mac with the current built system. There may be some code worth taking. https://github.com/apache/ignite/pull/4872 Regards, Stephen > On 26 May 2020, at 16:02, Ivan Daschinsky

Re: [DISCUSSION] Ignite.C++ and CMake

I appreciate any help, thank you, Ilya. Currently I have a small PR without ticket (link in first post),but I decided not to file a jira issue before discussion. Now I see, that this feature are of great interest to community. So I file a ticket, test myself on my home laptop (ubuntu 20.04) and

Re: [DISCUSSION] Ignite.C++ and CMake

Hello! I will assist with checking on Linux if you would contribute a patch. Please start with a ticket (or even an IEP maybe?) Regards, -- Ilya Kasnacheev вт, 26 мая 2020 г. в 16:47, Ivan Daschinsky : > Guys, I will certainly thoroughly test my fix not only unices, but on > windows too. >

Re: [DISCUSSION] Ignite.C++ and CMake

Guys, I will certainly thoroughly test my fix not only unices, but on windows too. And I will describe it very thoroughly. When I was C++ developer (more than 10 years ago), I have not any trouble at all with CMake and Visual Studio 2005. Everything works and works good. Moreover, you can build

Re: [DISCUSSION] Ignite.C++ and CMake

Hello, Igor. > Nikolay, removing support for a certain build system is a breaking change. No, it’s not. Why do you think so? Development environment and build system is a subject to change in any project. We can drop or add support of any build system any time we want. > 26 мая 2020 г., в

Re: [DISCUSSION] Ignite.C++ and CMake

Hello! I don't see why we can't get rid of autotools in a minor release, provided that cmake actually works. Removing native VS support may be a different thing. Build system and precise set of dependencies is not a part of public API in my opinion. Regards, -- Ilya Kasnacheev вт, 26 мая

Re: [DISCUSSION] Ignite.C++ and CMake

Igor, I just said about native support from Visual Studio, not from cmake itself. Modern cmake can generate projects even for Visual Studio 2008 [1] [1] -- https://cmake.org/cmake/help/v3.16/generator/Visual%20Studio%209%202008.html вт, 26 мая 2020 г. в 16:16, Igor Sapego : > Nikolay, removing

Re: [DISCUSSION] Ignite.C++ and CMake

Nikolay, removing support for a certain build system is a breaking change. Ivan, in C++ world there are companies that still use VS 2012 or even 2010. Best Regards, Igor On Tue, May 26, 2020 at 4:08 PM Ivan Daschinskiy wrote: > Guys, thank you all for support > > >> The only concern I have

Re: [DISCUSSION] Ignite.C++ and CMake

Hello, Igor. I’m ++1 for this change. How build system relates to major version of product? I think we can change the way we build modules any time we want. > 26 мая 2020 г., в 16:02, Igor Sapego написал(а): > > Great! > > Let's start with creating a TC suite for it. > > The only concern I

Re: [DISCUSSION] Ignite.C++ and CMake

Great! Let's start with creating a TC suite for it. The only concern I have is that it is one more build system to support. Should we get rid of autotools in 3.0? Best Regards, Igor On Tue, May 26, 2020 at 2:44 PM Alexey Kukushkin wrote: > +1. I recently completed a cross-IDE (MS Visual

Re: [DISCUSSION] Ignite.C++ and CMake

+1. I recently completed a cross-IDE (MS Visual Studio & GCC/GDB) Ignite C++ project and CMake in Ignite C++ would save me a day of effort. вт, 26 мая 2020 г. в 12:09, Pavel Tupitsyn : > +1 > > On Tue, May 26, 2020 at 12:02 PM Zhenya Stanilovsky > wrote: > > > > > Ivan huge +1 with your

Re: [DISCUSSION] Ignite.C++ and CMake

+1 On Tue, May 26, 2020 at 12:02 PM Zhenya Stanilovsky wrote: > > Ivan huge +1 with your proposal. > I had some problems with odbc tests building too, looks like cmake will > make it more easy. > >Hello Igniters. > > > >I’d like to discuss porting build process of Ignite.C++. I think that >

Re: [DISCUSSION] Ignite.C++ and CMake

Ivan huge +1 with your proposal. I had some problems with odbc tests building too, looks like cmake will make it more easy. >Hello Igniters. > >I’d like to discuss porting build process of Ignite.C++. I think that there is >time to change it. > >*Motivation* >Currently, it is hard to build

[DISCUSSION] Ignite.C++ and CMake

Hello Igniters. I’d like to discuss porting build process of Ignite.C++. I think that there is time to change it. *Motivation* Currently, it is hard to build Ignite.C++. Different build process for windows and linux, lack of building support on Mac OS X (quite popular OS among developers),