Re: IGNITE-6879: Support Spring Data 2.0

Hi Roman, Igniters, I've merged these changes to master and it goes to 2.6. Roman, thank you for contribution and your reminders about review. Peter Ivanov, thank you for setting up tests. Alexey Kukushkin, Dmitriy Ryabov, thank you for review. Igniters, please note Spring Data suite may fail

[GitHub] ignite pull request #3704: IGNITE-6879 and migration to spring-data 2.0.5.RE...

Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3704 ---

Re: IGNITE-6879

Hi Roman, now TC passes for 1.0. In the same time new suite is not executed on TC. I've asked Peter Ivanov to assist in TC run set up for Spring Data 2.0. Sincerely, Dmitriy Pavlov пн, 7 мая 2018 г. в 18:23, Роман Меерсон : > Dmitry, I leave comment at issue. As i may

Re: IGNITE-6879

Dmitry, I leave comment at issue. As i may see localy problem with tests was fixed пн, 7 мая 2018 г. в 17:24, Dmitry Pavlov : > Hi, I've replied to ticket, seems old tests are now failing after applying > patch locally. > > I've also added 2 suites to TC > TEST_SUITE

Re: IGNITE-6879

Hi, I've replied to ticket, seems old tests are now failing after applying patch locally. I've also added 2 suites to TC TEST_SUITE =IgniteSpringDataTestSuite,IgniteSpringData2TestSuite to https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpringData so this suite will

Re: IGNITE-6879

Hi Roman, Currently I'm checking the changes. Because of applying idea to copy all changes and upsource problem with this branch it is quite complex to locate actual changes. It is now required to check all copied files before merge. Sincerely, Dmitriy Pavlov пн, 7 мая 2018 г. в 11:07, Роман

Re: IGNITE-6879

Hello Dmitry! was review successfull? Or there are any points to change? сб, 28 апр. 2018 г. в 19:32, Роман Меерсон : > Ok! I believe in community and that things would change! > Looking forward for news > сб, 28 апр. 2018 г. в 19:29, Dmitry Pavlov :

Re: IGNITE-6879

Ok! I believe in community and that things would change! Looking forward for news сб, 28 апр. 2018 г. в 19:29, Dmitry Pavlov : > I hope so! > > There was several posts related to review time, and AI community is now > trying to reduce it. Now it is about 70 tickets waiting

Re: IGNITE-6879

I hope so! There was several posts related to review time, and AI community is now trying to reduce it. Now it is about 70 tickets waiting to be merged more than 1month. This defenetely should be changed. And I hope all Ignite committers and maintainters would continue to assist in this. сб, 28

Re: IGNITE-6879

Hi all! Soon we'll celebrate 2 months of my PR :) Maybe it could be merged? пн, 23 апр. 2018 г. в 18:52, Dmitry Pavlov : > No, nothing yet. I'm going to look to new version. > > пн, 23 апр. 2018 г. в 17:43, Роман Меерсон : > >> Hi all! >> >> Are there

Re: IGNITE-6879

No, nothing yet. I'm going to look to new version. пн, 23 апр. 2018 г. в 17:43, Роман Меерсон : > Hi all! > > Are there any news about PR merging? > > пн, 16 апр. 2018 г. в 19:43, Роман Меерсон : > >> Denis, >> >> module naming fixed >> >> пн, 16 апр.

Re: IGNITE-6879

Hi all! Are there any news about PR merging? пн, 16 апр. 2018 г. в 19:43, Роман Меерсон : > Denis, > > module naming fixed > > пн, 16 апр. 2018 г. в 19:24, Denis Magda : > >> Roman, >> >> In my last reply, I voted for your approach - using

Re: IGNITE-6879

Denis, module naming fixed пн, 16 апр. 2018 г. в 19:24, Denis Magda : > Roman, > > In my last reply, I voted for your approach - using "spring-data*_*2.0" for > the new Spring version. However, please note that we use "_" symbol instead > of "-" to separate a version from the

Re: IGNITE-6879

Roman, In my last reply, I voted for your approach - using "spring-data*_*2.0" for the new Spring version. However, please note that we use "_" symbol instead of "-" to separate a version from the package name. -- Denis On Sun, Apr 15, 2018 at 8:17 AM, Роман Меерсон

Re: IGNITE-6879

Hi all! So guys let’s make a decision. We leave code in current state as I suggest or change module naming according Dmitry’s suggestion. ср, 11 апр. 2018 г. в 1:54, Denis Magda : > Roman, > > Your suggestion sounds reasonable to me. Backing it up. > > -- > Denis > > On Tue,

Re: IGNITE-6879

Roman, Your suggestion sounds reasonable to me. Backing it up. -- Denis On Tue, Apr 10, 2018 at 2:50 PM, Роман Меерсон wrote: > Hi all! > > IMHO if we do so we'll produce big pain for everybody while migrating on > new version, because ones should change method and

Re: IGNITE-6879

Hi all! IMHO if we do so we'll produce big pain for everybody while migrating on new version, because ones should change method and others should change their poms. This change would be backward incompatible so it probably should follow with major version upgrade, but I'm not sure about it.

Re: IGNITE-6879

In our Hibernate integration we define following two modules to distinguish incompatible versions: - ignite-hiberbate_4.2 - ignite-hibernate_5.1 In Spark we have: - ignite-spark - ignite-spark_2.10 After thinking this over, I would do the following with Spring Data: -

Re: IGNITE-6879

Thank you, Roman. Igniters, IMO we should consider one more alternative - renaming of old module and package names. Users, which prefer to stay on previous version will be requiered to update their pom's. In the same time users which are ready to migrate to spring data 2.0 will need to update

Re: IGNITE-6879

Hi Dmitry! I`ve just commited new fix. I renamed package of new module to springdata20, it helps us to separate old implementation from new and also should fix all compilation errors. пн, 9 апр. 2018 г. в 23:54, Роман Меерсон : > Ok, I'll check it, but I haven't face this

Re: IGNITE-6879

Ok, I'll check it, but I haven't face this problem. If I'll find same issue, what is the proper way? Renaming to something like Ignite2QueryGenerator or module removing? пн, 9 апр. 2018 г. в 23:40, Dmitry Pavlov : > There are 2 classes IgniteQueryGenerator with same package

Re: IGNITE-6879

There are 2 classes IgniteQueryGenerator with same package name. Ignite in Idea can't compile. пн, 9 апр. 2018 г., 21:38 Роман Меерсон : > Hi Dmitry! > Could you specify where you find conflict? Because I don’t have any. > пн, 9 апр. 2018 г. в 21:09, Dmitry Pavlov

Re: IGNITE-6879

Hi Dmitry! Could you specify where you find conflict? Because I don’t have any. пн, 9 апр. 2018 г. в 21:09, Dmitry Pavlov : > Hi Denis, > > could we support just one version instead of leaving compatible module? > > Sincerely, > Dmitriy Pavlov > > пн, 9 апр. 2018 г. в

Re: IGNITE-6879

Hi Denis, could we support just one version instead of leaving compatible module? Sincerely, Dmitriy Pavlov пн, 9 апр. 2018 г. в 20:08, Dmitry Pavlov : > > > пн, 9 апр. 2018 г. в 20:07, Dmitry Pavlov : > >> Hi Roman, >> >> I've applied PR locally

Re: IGNITE-6879

Hi Roman, I've applied PR locally and I have class name conflict at least for org.apache.ignite.springdata.repository.query.IgniteQueryGenerator How could we solve it? Is it better to rename class for new plugin version? Sincerely, Dmitriy Pavlov пт, 6 апр. 2018 г. в 17:38, Dmitry Pavlov

Re: IGNITE-6879

Excellend picture. I remember about this change. If Denis M. would be able to look througt the changes faster than me, I can merge without detailed review. пт, 6 апр. 2018 г. в 16:15, Роман Меерсон : > OK > > [image: 1486924635147168240.jpg] > > > пт, 6 апр. 2018 г. в

Re: IGNITE-6879

OK [image: 1486924635147168240.jpg] пт, 6 апр. 2018 г. в 17:08, Igor Sapego : > Hi, > Well, Dmitry has said he's going to merge it in 3-4 days 2 days ago, > so I guess, the merge is going to happen in 1-2 days or so. > > > Best Regards, > Igor > > On Fri, Apr 6, 2018 at

Re: IGNITE-6879

Hi, Well, Dmitry has said he's going to merge it in 3-4 days 2 days ago, so I guess, the merge is going to happen in 1-2 days or so. Best Regards, Igor On Fri, Apr 6, 2018 at 3:48 PM, Роман Меерсон wrote: > Hi all! > > As i see everything is awesome and there is no

Re: IGNITE-6879

Hi all! As i see everything is awesome and there is no objections, so when my PR would be merged? чт, 5 апр. 2018 г. в 18:58, Вячеслав Коптилин : > Thank you, Roman! > > 2018-04-05 17:49 GMT+03:00 Роман Меерсон : > > > Hi Slava, > > > > Fixed > >

Re: IGNITE-6879

Thank you, Roman! 2018-04-05 17:49 GMT+03:00 Роман Меерсон : > Hi Slava, > > Fixed > > чт, 5 апр. 2018 г. в 18:41, Вячеслав Коптилин : > > > Hi Roman, > > > > please take into account my comment IgniteQueryGenerator.java > > < > >

Re: IGNITE-6879

Hi Slava, Fixed чт, 5 апр. 2018 г. в 18:41, Вячеслав Коптилин : > Hi Roman, > > please take into account my comment IgniteQueryGenerator.java > < >

Re: IGNITE-6879

Hi Roman, please take into account my comment IgniteQueryGenerator.java Best

Re: IGNITE-6879

Ok, so waiting for accept and commit чт, 5 апр. 2018 г. в 15:29, Alexey Kukushkin : > Roman, > > Just pay commiter's (Dmitry Pavlov will most likely commit your code) > attention to include the new test suite to TeamCity configuration. >

Re: IGNITE-6879

Roman, Just pay commiter's (Dmitry Pavlov will most likely commit your code) attention to include the new test suite to TeamCity configuration.

Re: IGNITE-6879

Alexey, 1) Fixed 2) How could i be sure? What do i need to do? чт, 5 апр. 2018 г. в 14:24, Alexey Kukushkin : > Roman, > > Just two small comments from me: > >1. I suggest renaming IgniteSpringDataTestSuite to >IgniteSpringData2TestSuite: we must be able to

Re: IGNITE-6879

Roman, Just two small comments from me: 1. I suggest renaming IgniteSpringDataTestSuite to IgniteSpringData2TestSuite: we must be able to test both spring-data and spring-data-2 JARs with single "mvn test" 2. Make sure "Ignite Spring Data" test job in TeamCity is extended to run

Re: IGNITE-6879

I`ve finished with new module: https://github.com/apache/ignite/pull/3704 чт, 5 апр. 2018 г. в 12:06, Роман Меерсон : > Ok guys, I`ll made changes but what should we do with examples and with > Spring module version? > > Exemples couldn`t support both versions, so should i

Re: IGNITE-6879

Ok guys, I`ll made changes but what should we do with examples and with Spring module version? Exemples couldn`t support both versions, so should i leave upgraded to 2.0 version? Spring module was upgraded to newest version, so should i leave it on newest version? чт, 5 апр. 2018 г. в 0:17,

Re: IGNITE-6879

Hi guys, According to ASF stats our spring data integration is 2 times more popular than spark integraion - 900 maven downloads vs. 400. So I would suggest us creating ignite-spring-data-2.0 module to support new deployments and leave ignite-spring-data to not break existing ones. -- Denis

Re: IGNITE-6879

Hi Igniters, I am going to review these changes in 3-4 days. If everything is ok and if there is no objections, I will merge it. Hi Denis, are you agree with proposed change? Sincerely, Dmitriy Pavlov ср, 4 апр. 2018 г. в 14:26, Дмитрий Рябов : > I agree that

Re: IGNITE-6879

I agree that increasing complexity isn't good idea. Roman, can you document the migration guide? 2018-04-04 13:41 GMT+03:00 Alexey Kukushkin : > Roman, Dmitry, > > I also reviewed the fix and the code looks OK to me. But the fix has > significant implication - Ignite

Re: IGNITE-6879

Roman, Dmitry, I also reviewed the fix and the code looks OK to me. But the fix has significant implication - Ignite no longer can be used with spring-data 1.0 due to no backward compatibility between spring 2.0 and 1.0 APIs. With this approach we must remember to add corresponding spring-data

Re: IGNITE-6879

: > >> Dmitry, Alexey, code and tests looks good for me. >> >> JIRA: https://issues.apache.org/jira/browse/IGNITE-6879 >> PR: https://github.com/apache/ignite/pull/3704 >> Upsource: https://reviews.ignite.apache.org/ignite/review/IGNT-CR-541 >> TeamCity: https://ci.

Re: IGNITE-6879

Hi all! I suppose Dmity`s message wasn`t april 1st joke) So what about my PR? Would it be merged? вс, 1 апр. 2018 г. в 12:40, Дмитрий Рябов <somefire...@gmail.com>: > Dmitry, Alexey, code and tests looks good for me. > > JIRA: https://issues.apache.org/jira/browse/IGNITE-6

Re: IGNITE-6879

Dmitry, Alexey, code and tests looks good for me. JIRA: https://issues.apache.org/jira/browse/IGNITE-6879 PR: https://github.com/apache/ignite/pull/3704 Upsource: https://reviews.ignite.apache.org/ignite/review/IGNT-CR-541 TeamCity: https://ci.ignite.apache.org/viewLog.html?buildId=1170373

[GitHub] ignite pull request #3704: IGNITE-6879 and migration to spring-data 2.0.5.RE...

GitHub user homich1991 opened a pull request: https://github.com/apache/ignite/pull/3704 IGNITE-6879 and migration to spring-data 2.0.5.RELEASE Fixed IGNITE-6879 Migrated to spring-data 2.0.5.RELEASE Migrated to spring 5.0.4.RELEASE Fixed overrided methods naming

[GitHub] ignite pull request #3628: IGNITE-6879 and migration to spring-data 2.0.5.RE...

Github user homich1991 closed the pull request at: https://github.com/apache/ignite/pull/3628 ---

Re: IGNITE-6879

Hi all! Dmitriy thank you for review. I`ve just fixed all your comments. чт, 22 мар. 2018 г. в 20:36, Dmitry Pavlov : > HI Dmitriy, thank you! > > Roman, could you please address Dmitriy's comments? > > чт, 22 мар. 2018 г. в 19:18, Дмитрий Рябов :

Re: IGNITE-6879

HI Dmitriy, thank you! Roman, could you please address Dmitriy's comments? чт, 22 мар. 2018 г. в 19:18, Дмитрий Рябов : > Hi Dmitriy, > > I took a look for PR, it needs codestyle fixes. > > 2018-03-19 14:22 GMT+03:00 Dmitry Pavlov : > >> Hi Alexey,

Re: IGNITE-6879

Hi Dmitriy, I took a look for PR, it needs codestyle fixes. 2018-03-19 14:22 GMT+03:00 Dmitry Pavlov : > Hi Alexey, > > Did you find the patch is looking good and is ready to be merged? > > Sincerely, > Dmitriy Pavlov > > чт, 15 мар. 2018 г. в 11:19, Alexey Kukushkin

Re: IGNITE-6879

Hi Alexey, Did you find the patch is looking good and is ready to be merged? Sincerely, Dmitriy Pavlov чт, 15 мар. 2018 г. в 11:19, Alexey Kukushkin : > Just found the fix is ready - I will review it today or tomorrow. >

Re: IGNITE-6879

t in JIRA. Go >> ahead and assign the ticket to yourself. >> >> Folks, anyway, who can review Roman's contribution that brings Spring 2.0 >> support to Ignite? >> >> -- >> Denis >> >> >> >> On Tue, Mar 13, 2018 at 2:21 PM, Роман Меерсон

Re: IGNITE-6879

PM, Роман Меерсон <homich1...@gmail.com> > wrote: > > > Hello! > > > > I want to work on https://issues.apache.org/jira/browse/IGNITE-6879 > issue. > > Following the rules here > > https://ignite.apache.org/community/contribute.html#contribute my Jira >

Re: IGNITE-6879

ch1...@gmail.com> wrote: > Hello! > > I want to work on https://issues.apache.org/jira/browse/IGNITE-6879 issue. > Following the rules here > https://ignite.apache.org/community/contribute.html#contribute my Jira > username is "homich" so assign me to this ticket please

IGNITE-6879

Hello! I want to work on https://issues.apache.org/jira/browse/IGNITE-6879 issue. Following the rules here https://ignite.apache.org/community/contribute.html#contribute my Jira username is "homich" so assign me to this ticket please. P.S. I found this rules page after I made PR

[GitHub] ignite pull request #3628: IGNITE-6879 and migration to spring-data 2.0.5.RE...

GitHub user homich1991 opened a pull request: https://github.com/apache/ignite/pull/3628 IGNITE-6879 and migration to spring-data 2.0.5.RELEASE Fixed IGNITE-6879 Migrated to spring-data 2.0.5.RELEASE Migrated to spring 5.0.4.RELEASE Fixed overrided methods naming You

[jira] [Created] (IGNITE-6879) Support Spring 2.0

Alexey Kukushkin created IGNITE-6879: Summary: Support Spring 2.0 Key: IGNITE-6879 URL: https://issues.apache.org/jira/browse/IGNITE-6879 Project: Ignite Issue Type: Improvement