Github user ajs6f commented on the pull request:
https://github.com/apache/jena/commit/8601cd3028c0e57dbc805efc5d54d7b9ee272c3f#commitcomment-20399785
In
jena-arq/src/test/java/org/apache/jena/sparql/core/pergraph/MultithreadingTest.java:
In
jena-arq/src/test/java/org/apache
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/202#discussion_r95081789
--- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/SetUtils.java
---
@@ -44,13 +42,26 @@ private SetUtils() {}
return s1.stream().anyMatch
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/202
Autogen code is now back where it started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/202#discussion_r95081992
--- Diff:
jena-base/src/main/java/org/apache/jena/atlas/lib/CollectionUtils.java ---
@@ -22,12 +22,7 @@
public class CollectionUtils
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/commit/8601cd3028c0e57dbc805efc5d54d7b9ee272c3f#commitcomment-20400171
In
jena-arq/src/test/java/org/apache/jena/sparql/core/pergraph/MultithreadingTest.java:
In
jena-arq/src/test/java/org/apache
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/commit/8601cd3028c0e57dbc805efc5d54d7b9ee272c3f#commitcomment-20400578
In
jena-arq/src/test/java/org/apache/jena/sparql/core/pergraph/MultithreadingTest.java:
In
jena-arq/src/test/java/org/apache
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/203#discussion_r95094877
--- Diff: jena-arq/src/test/java/org/apache/jena/riot/TestJsonLDReader.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/203#discussion_r95094886
--- Diff: jena-arq/src/test/java/org/apache/jena/riot/TestJsonLDReader.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/203#discussion_r95094927
--- Diff: jena-arq/src/test/java/org/apache/jena/riot/TestJsonLDReader.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/203#discussion_r95094991
--- Diff: jena-arq/src/test/java/org/apache/jena/riot/TestJsonLDReader.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/203
This is good stuff-- thanks for taking a problem and turning it into an
improvement!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/203#discussion_r95095114
--- Diff: jena-arq/src/test/java/org/apache/jena/riot/TestJsonLDReader.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/203#discussion_r95095064
--- Diff: jena-arq/src/test/java/org/apache/jena/riot/TestJsonLDReader.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/203
@fpservant Oh my goodness, you are quite right. There is no appropriate
method in `RdfDataMgr`! @afs I think we could reasonably add such a method as
part of this PR-- it would clearly be useful. What
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/203
@fpservant @afs Yes, exactly. Having a method on `RdfDataMgr` that takes
`InputStream` _and_ `Context` seems very natural.
---
If your project is set up for it, you can reply to this email and have
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/203
You're saying use `org.apache.jena.riot.RDFDataMgr.parse(StreamRDF,
InputStream, String, Lang, Context)`? That does make sense. I guess I was
thinking of the general need to customize parsing beh
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/202
@afs Are you cool with this now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/203#discussion_r95210926
--- Diff:
jena-arq/src/main/java/org/apache/jena/riot/out/JenaRDF2JSONLD.java ---
@@ -0,0 +1,100 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/203#discussion_r95217067
--- Diff:
jena-arq/src/main/java/org/apache/jena/riot/out/JenaRDF2JSONLD.java ---
@@ -0,0 +1,100 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/203
This looks nice now. ð Please do either file a ticket for the new bug
you found or find a ticket that already describes it (if there is one) and
reference it in the comment you left in the test case
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/203
@fpservant Yep, that's what I meant. I would be looking that as solvable by
moving the location of the schema to a resource supported on the testing box,
so it's not being resolved from t
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/203
@afs I think the point that @stain and I are making is that there is no
need for an external resource linkage at all.
---
If your project is set up for it, you can reply to this email and have your
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/202#discussion_r95584988
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/algebra/OpVisitor.java ---
@@ -23,53 +23,53 @@
public interface OpVisitor
{
// Op0
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/202#discussion_r95585136
--- Diff:
jena-base/src/main/java/org/apache/jena/atlas/lib/CollectionUtils.java ---
@@ -22,12 +22,7 @@
public class CollectionUtils
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/202#discussion_r95613311
--- Diff:
jena-base/src/main/java/org/apache/jena/atlas/lib/CollectionUtils.java ---
@@ -22,12 +22,7 @@
public class CollectionUtils
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/204
One writable graph per thread/transaction dataset
A pass at:
https://issues.apache.org/jira/browse/JENA-1274
You can merge this pull request into a Git repository by running:
$ git pull
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/204
`pergraph`: Just thought that `core` was getting awfully crowded. I don't
care one way or the other-- happy to put them anywhere.
`jena-ldp`: One of the questions I'm trying to raise
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/202
Fixed (reverted) the additional autogen files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/204
That's a really fair point about providing some use cases. An example that
occurs to me is RDF-based persistence where Java entities are being saved into
a dataset. I think @claudenw has something
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/204
I will retarget this at jena-extras. It does make more sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/202
@afs my laptop is on the fritz, so I will try to find a way to merge this
later today, but you are welcome to! :)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/205
@osma In the case you mention, shouldn't the user be explicitly ordering
anyway?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/204
It looks like in order to put this in `jena-extras`, I will need to create
a new modules there. Any opinions about the name? Maybe
`jena-optional-datasets` or something like that?
---
If your project
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/205
@osma Yeah, that's what I meant tho'-- use a calculation (via `BIND`, I
guess?) of the distance (and we have [â available to
use](https://jena.apache.org/documentation/query/library-fun
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/205
Sure, so my claims are 1) this is a good PR :) and 2) if we want to offer
the kind of functionality that you are removing, that's cool, but we should do
it in some appropriate, public, maintainabl
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/204
Yeah, judging by the general silence in response to my question about "Does
anyone have other use cases for this kind of thing?" I'm not going to push on
that I'm happy for it to b
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/204
I'm starting to wonder whether I should back up here and just go for the
more general 2-phase-locking design as [@afs discusses in the Jira
ticket](https://issues.apache.org/jira/browse/JENA
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/209
I agree with @rvesse . One doesn't take control of the lifecycle of a
parameter like this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/210
Fixing JENA-1283 by using Maven properties to control versions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajs6f/jena JENA-1283
Alternatively
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/212#discussion_r98912881
--- Diff: jena-core/src/main/java/org/apache/jena/graph/GraphUtil.java ---
@@ -115,55 +117,44 @@ public static void add(Graph graph, Triple[] triples
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/212#discussion_r98912284
--- Diff: jena-core/src/main/java/org/apache/jena/graph/GraphUtil.java ---
@@ -115,55 +117,44 @@ public static void add(Graph graph, Triple[] triples
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/212
My 2¢ are inline, but I echo @rvesse's questions as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/213#discussion_r98915106
--- Diff:
jena-arq/src/main/java/org/apache/jena/riot/tokens/StringType.java ---
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/213
+1: this is clearer. But that's coming from someone w/o much familiarity
with this part of the code!
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/215
A big +1 to the `return this;` idiom. It's very convenient in this kind of
work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/214
Looks good-- I'll merge this after we finish with the current release
process. Thanks @retnor !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/114
@kinow is this still live?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/50
@stain @kinow Were we able to get testing of some kind done? I can see real
utility for a Docker image, because it would let a wider audience try out
Fuseki more easily, and for some people, would give
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/37
Given that #38 is merged, is this still live?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/209
Perhaps you could open an ordinary Jira issue with sample data and code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/50
@stain I'm not that familiar with Docker-- is `apache/` in Docker Hub an
official Apache account for some kind of central Docker repo?
---
If your project is set up for it, you can reply to this
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/50
Are commits showing up there a release, or a mirroring of the source code
repository like Github?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user ajs6f closed the pull request at:
https://github.com/apache/jena/pull/204
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/204
Closing in favor of further more general discussion about points raised on
this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/223
JENA-1309: HttpOp should respect system properties for default client
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajs6f/jena JENA-1309
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/223
Yeah, `HttpOp` is usually my first stop for this kind of thing because my
understanding is that in theory, all ARQ routes all HTTP traffic through
`HttpOp`.
---
If your project is set up for it, you
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/227
I'm just catching up with this PR, so apologies if I turn out to have
missed part of the conversation!
If there is difficulty getting tests integrated into the Maven lifecycle
within one m
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/227
@anujgandharv, the first place to look is at the actual
`jena-integration-tests` module. You will see there that the tests follow the
same form as in other Jena modules (explicitly linked together in
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/114
No prob-- good to see you back, @kinow !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/227
I don't know enough to have a useful opinion about how thorough the tests
need to be-- I am very happy to defer to @osma about that.
As for the test framework-- my (small) knowledge
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r107435245
--- Diff: jena-text/pom.xml ---
@@ -112,11 +141,77 @@
org.apache.maven.plugins
maven-surefire-plugin
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/227
I'm definitely cool with squashing a bit. I think that helps posterity a
lot. Two possible (plausible?) principles:
1. Each post-squash commit should move the codebase from a does-build
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/227
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/227
I think that if we are confident that we have solid test coverage and that
it runs correctly, we can merge and clean up as time permits. I will take a
look at the Maven setup and see if anything worries
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r108437539
--- Diff: jena-text/pom.xml ---
@@ -81,6 +81,32 @@
lucene-queryparser
+
+ org.elasticsearch
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r108437929
--- Diff: jena-text/pom.xml ---
@@ -112,11 +138,72 @@
org.apache.maven.plugins
maven-surefire-plugin
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r108438002
--- Diff: jena-text/pom.xml ---
@@ -112,11 +138,72 @@
org.apache.maven.plugins
maven-surefire-plugin
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r108438170
--- Diff: jena-text/pom.xml ---
@@ -112,11 +138,72 @@
org.apache.maven.plugins
maven-surefire-plugin
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r108439061
--- Diff:
jena-text/src/test/java/org/apache/jena/query/text/it/BaseESTest.java ---
@@ -0,0 +1,111 @@
+/**
+ * Licensed to the Apache Software
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/227
@osma I'm done mumbling over this PR. I think it looks okay. I did leave
some questions about the Maven stuff, but nothing in there makes me freak out.
The biggest question I have is why `log4
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/223
I was waiting to hear confirmation from the reporter that this is a fix,
but it's been quite a while. I have no prob with merging this as-is.
---
If your project is set up for it, you can reply to
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/232
fixing symlink behavior for Mac OS X
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajs6f/jena JENA-1297
Alternatively you can review and apply
Github user ajs6f closed the pull request at:
https://github.com/apache/jena/pull/223
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/223
Fixed with
https://git-wip-us.apache.org/repos/asf?p=jena.git;a=commit;h=711e9be838efdb056bfa4bccc253c58799affea0
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110013073
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/Topology.java ---
@@ -0,0 +1,45 @@
+package org.apache.jena.sparql.core.mosaic
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110179015
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/LockTry.java ---
@@ -0,0 +1,8 @@
+package org.apache.jena.sparql.core.mosaic
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110180316
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/ThreadProxy.java ---
@@ -0,0 +1,100 @@
+package org.apache.jena.sparql.core.mosaic
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110180946
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/ThreadProxy.java ---
@@ -0,0 +1,100 @@
+package org.apache.jena.sparql.core.mosaic
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110183160
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/thrift/IteratorCached.java
---
@@ -0,0 +1,21 @@
+package org.apache.jena.sparql.core.thrift
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110182274
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/TransactionalDistributed.java
---
@@ -0,0 +1,267 @@
+package
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110182062
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/TransactionalDistributed.java
---
@@ -0,0 +1,267 @@
+package
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/233
There is a lot of cool functionality here, but I don't see any tests at
all. Are they coming in a separate PR?
---
If your project is set up for it, you can reply to this email and have your
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/233
@dick-twocows , am I right in thinking that the assumption you are making
about the "mosaic pieces", the child-datasetgraphs, is that they are MR+SW? Or
are you somehow being agnostic to that
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/233
Ah, okay, cool. (Re: Javadocs)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110245723
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/ThreadProxy.java ---
@@ -0,0 +1,100 @@
+package org.apache.jena.sparql.core.mosaic
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/233
That seems reasonable to start with (blocking). That's what people would
get if they were addressing the mosaic pieces directly.
---
If your project is set up for it, you can reply to this emai
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110252024
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/DatasetGraphMosaic.java
---
@@ -0,0 +1,589 @@
+package
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110254074
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/DatasetGraphMosaic.java
---
@@ -0,0 +1,589 @@
+package
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110254192
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/DatasetGraphMosaic.java
---
@@ -0,0 +1,589 @@
+package
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110256243
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/DatasetGraphMosaic.java
---
@@ -0,0 +1,589 @@
+package
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110256573
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/DatasetGraphMosaic.java
---
@@ -0,0 +1,589 @@
+package
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/237#discussion_r111237018
--- Diff: jena-arq/src/main/java/org/apache/jena/sparql/expr/NodeValue.java
---
@@ -784,10 +786,15 @@ private static int compare(NodeValue nv1, NodeValue
nv2
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/240
If that understanding is correct (and I now share it) then I agree with
@afs's proposal, and I can make that change. @rmorrise ?
---
If your project is set up for it, you can reply to this emai
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/240
`org.apache.jena.atlas.web.HttpException` only has `getResponseCode()`,
`getStatusLine()`, and `getResponse()`. Wouldn't it work to just add those
three to `QueryExceptionHTTP`?
---
If your proje
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/241
JENA-1321: Exception rewrapping in HttpQuery masks error response from the
server
It's a bit odd-feeling to couple `HttpException` so tightly, but given that
it is an Atlas type, I don't fee
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/241
@rmorrise, will this suit you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/241
No, actually, I did not start with your code-- if you look at what I did, I
added fields and accessors and a constructor to `QueryExceptionHTTP` instead as
we discussed. You need do nothing further. I
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/241
The tests pass fine, because as @afs prescribed, we aren't changing the
wrapping of exceptions, just adding useful information to "outer" ones.
---
If your project is set up for it, y
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/243#discussion_r112275972
--- Diff:
jena-arq/src/main/java/org/apache/jena/riot/lang/ReaderRIOTRDFXML.java ---
@@ -172,10 +185,9 @@ private static Node convert(ALiteral lit
Github user ajs6f closed the pull request at:
https://github.com/apache/jena/pull/241
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
201 - 300 of 1081 matches
Mail list logo
