Re: [Discussion] Limitations on topic names

The problem with '.' seems only to be in case of metrics. Should kafka replace '.' with some special character, not in [a-zA-Z0-9\\._\\-] or some reserved seq of characters? On Fri, Jul 10, 2015 at 2:08 PM, Neha Narkhede wrote: > "." seems natural for grouping topic names. +1 for 2) going forwar

Re: Dropping support for Scala 2.9.x

+1 On Wed, Jul 8, 2015 at 9:52 AM, Guozhang Wang wrote: > +1. > > Scala 2.9 has been 4 years old and I think it is time to drop it. > > On Wed, Jul 8, 2015 at 7:22 AM, Grant Henke wrote: > > > +1 for dropping 2.9 > > > > On Wed, Jul 8, 2015 at 9:15 AM, Sriharsha Chintalapani > > wrote: > > > >

Re: Review Request 36030: Patch for KAFKA-972

/scala/unit/kafka/integration/TopicMetadataTest.scala a95ee5e0849d29a5f95fdabed4f1988a308e9872 Diff: https://reviews.apache.org/r/36030/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 36030: Patch for KAFKA-972

hish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36030/#review90843 --- On July 7, 2015, 5:42 p.m., Ashish Singh wrote: > > --

Review Request 36270: Patch for KAFKA-2317

/36270/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 35820: Patch for KAFKA-1367

ly, visit: https://reviews.apache.org/r/35820/#review90734 ------- On July 7, 2015, 5:04 a.m., Ashish Singh wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 35820: Patch for KAFKA-1367

view90717 --- On July 7, 2015, 5:04 a.m., Ashish Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 36030: Patch for KAFKA-972

view90721 --- On July 7, 2015, 5:42 p.m., Ashish Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 36030: Patch for KAFKA-972

/scala/unit/kafka/integration/TopicMetadataTest.scala a95ee5e0849d29a5f95fdabed4f1988a308e9872 Diff: https://reviews.apache.org/r/36030/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 36030: Patch for KAFKA-972

/scala/unit/kafka/integration/TopicMetadataTest.scala 995b05901491bb0dbf0df210d44bd1d7f66fdc82 Diff: https://reviews.apache.org/r/36030/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 36030: Patch for KAFKA-972

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36030/#review90579 ------- On July 7, 2015, 6:07 a.m., Ashish Singh wrote: > > --

Re: Review Request 35820: Patch for KAFKA-1367

42) <https://reviews.apache.org/r/35820/#comment143754> Moved to method that uses it. - Ashish Singh On July 7, 2015, 5:04 a.m., Ashish Singh wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 35820: Patch for KAFKA-1367

ly generated e-mail. To reply, visit: https://reviews.apache.org/r/35820/#review90605 ------- On July 7, 2015, 5:04 a.m., Ashish Singh wrote: > > --- > This is an auto

Re: Review Request 35820: Patch for KAFKA-1367

with 3 Kafka brokers Thanks, Ashish Singh

Re: [VOTE] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand

Thanks for your comments and vote guys. KIP-23 passed retroactively with 2 binding +1s and 2 non-binding +1s. On Mon, Jun 29, 2015 at 3:25 PM, Jun Rao wrote: > +1 > > Thanks, > > Jun > > On Tue, Jun 23, 2015 at 11:15 AM, Ashish Singh > wrote: > >> Hey Guys,

Re: [ANNOUNCE] New Committer

Congrats Gwen! On Monday, July 6, 2015, Joe Stein wrote: > I am pleased to announce that the Apache Kafka PMC has voted to invite Gwen > Shapira as a committer and Gwen has accepted. > > Please join me on welcoming and congratulating Gwen. > > Thanks for the contribution both in the project (cod

Re: Review Request 35850: Patch for KAFKA-2301

g warnings. Made the change. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35850/#review90199 ------- On July 2, 2015, 4:04 p.m., Ashish Singh wrote: > > ---

Re: Review Request 35850: Patch for KAFKA-2301

://reviews.apache.org/r/35850/diff/ Testing --- Thanks, Ashish Singh

Deprecation of ConsumerOffsetChecker

Hey Guys, In last KIP hangout, we decided on following path for deprecating ConsumerOffsetChecker. 1. Add deprecation warning to the tool for one release. In this case, the warning will be added in 0.9.0. 2. Drop it completely in next release, 0.9.1. I have updated the (KIP-23){ https://cwiki.ap

Re: Review Request 35850: Patch for KAFKA-2301

://reviews.apache.org/r/35850/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 35820: Patch for KAFKA-1367

with 3 Kafka brokers Thanks, Ashish Singh

Re: Review Request 35820: Patch for KAFKA-1367

s the fix. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35820/#review89911 --- On July 2, 2015, 12:23 a.m

Re: Review Request 36030: Patch for KAFKA-972

tps://reviews.apache.org/r/36030/#review90045 ------- On July 1, 2015, 3:06 p.m., Ashish Singh wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 36030: Patch for KAFKA-972

/scala/unit/kafka/integration/TopicMetadataTest.scala 995b05901491bb0dbf0df210d44bd1d7f66fdc82 Diff: https://reviews.apache.org/r/36030/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 36030: Patch for KAFKA-972

/scala/unit/kafka/integration/TopicMetadataTest.scala 995b05901491bb0dbf0df210d44bd1d7f66fdc82 Diff: https://reviews.apache.org/r/36030/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 36030: Patch for KAFKA-972

Done! - Ashish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36030/#review90005 ------- On July 1, 2015, 8:37 a.m., Ashish Singh wrote: &

Re: Review Request 36030: Patch for KAFKA-972

/scala/unit/kafka/integration/TopicMetadataTest.scala 995b05901491bb0dbf0df210d44bd1d7f66fdc82 Diff: https://reviews.apache.org/r/36030/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 36030: Patch for KAFKA-972

/scala/unit/kafka/integration/TopicMetadataTest.scala 995b05901491bb0dbf0df210d44bd1d7f66fdc82 Diff: https://reviews.apache.org/r/36030/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 36030: Patch for KAFKA-972

il. To reply, visit: https://reviews.apache.org/r/36030/#review89907 ------- On June 30, 2015, 12:46 a.m., Ashish Singh wrote: > > --- > This is an automati

Re: Review Request 33614: Patch for KAFKA-2132

: https://reviews.apache.org/r/33614/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 33614: Patch for KAFKA-2132

59line412> > > > > Do we need to publish a test jar for kafka-log4j-appender? Not necessarily. Removed. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.

Re: Review Request 35850: Patch for KAFKA-2301

automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35850/#review89301 ------- On June 24, 2015, 10:10 p.m., Ashish Singh wrote: > >

Review Request 36030: Patch for KAFKA-972

--- Thanks, Ashish Singh

Review Request 35850: Patch for KAFKA-2301

/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 3d52f62c88a509a655cf1df6232b738c25fa9b69 system_test/broker_failure/config/log4j.properties 23ece9bb5b3d521bb692870bc929865f68caabe0 Diff: https://reviews.apache.org/r/35850/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 28096: Patch for KAFKA-313

f23120ede5f9bf0cfaf795c65c9845f42d8784d0 Diff: https://reviews.apache.org/r/28096/diff/ Testing --- Ran ConsumerOffsetChecker with different combinations of --output.format and --loop options. Thanks, Ashish Singh

Re: Review Request 33614: Patch for KAFKA-2132

: https://reviews.apache.org/r/33614/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 33614: Patch for KAFKA-2132

27;t the subpackage be log4jappender? Yes, I am surprised that even log4j worked :) - Ashish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/#review88015 ------

Re: Review Request 33614: Patch for KAFKA-2132

: https://reviews.apache.org/r/33614/diff/ Testing --- Thanks, Ashish Singh

Review Request 35822: Patch for KAFKA-2299

, Ashish Singh

Re: Review Request 35820: Patch for KAFKA-1367

/unit/kafka/utils/ReplicationUtilsTest.scala c96c0ffd958d63c09880d436b2e5ae96f51ead36 Diff: https://reviews.apache.org/r/35820/diff/ Testing (updated) --- Tested on a test cluster with 3 Kafka brokers Thanks, Ashish Singh

Review Request 35820: Patch for KAFKA-1367

/ReplicationUtilsTest.scala c96c0ffd958d63c09880d436b2e5ae96f51ead36 Diff: https://reviews.apache.org/r/35820/diff/ Testing --- Tested Thanks, Ashish Singh

Re: [VOTE] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand

ut and looping options to > ConsumerGroupCommand > > +1 > > On Tue, Jun 23, 2015 at 11:15 AM, Ashish Singh > wrote: > > > Hey Guys, > > > > We had some discussion over mail and in KIP hangout. I will update the RB > > with proposed changes. > > > &

[VOTE] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand

Hey Guys, We had some discussion over mail and in KIP hangout. I will update the RB with proposed changes. On Sun, Jun 14, 2015 at 10:07 AM, Ashish Singh wrote: > Hi Neha, > > Answers inline. > > On Thu, Jun 11, 2015 at 7:20 PM, Neha Narkhede wrote: > >> Thanks for su

Re: Guozhang Wang elected to Kafka PMC

Congrats Guozhang! On Mon, Jun 15, 2015 at 10:20 PM, Sriharsha Chintalapani wrote: > Congrats Guozhang. > > -- > Harsha > > > On June 15, 2015 at 9:59:37 PM, Jun Rao (j...@confluent.io) wrote: > > Hi, Everyone, > > Guozhang Wang has been active in the Kafka community since he became a > Kafka co

Re: [DISCUSS] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand

hould we have a plan to phase out the > old format? > Probably not, but having it around will not hurt. Having three output formats is not that bad and I do not expect this list to grow in future. > > On Thu, Jun 11, 2015 at 6:05 PM, Ashish Singh wrote: > > > Jun, > >

Re: Review Request 33614: Patch for KAFKA-2132

ependency implies > > a testCompile dependency. Its not :). Removed. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/#review87670 ------

Re: Review Request 33614: Patch for KAFKA-2132

think it will be a blocker if this remains a debug level message. Let me know if you think otherwise. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/#review8

Re: Review Request 33614: Patch for KAFKA-2132

: https://reviews.apache.org/r/33614/diff/ Testing --- Thanks, Ashish Singh

Re: [DISCUSS] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand

Jun, Can we add this as part of next KIP's agenda? On Thu, Jun 11, 2015 at 3:00 PM, Gwen Shapira wrote: > Maybe bring it up at the next KIP call, to make sure everyone is aware? > > On Thu, Jun 11, 2015 at 2:17 PM, Ashish Singh wrote: > > Hi Guys, > > > > This

Pending review requests

Hey Guys, I have a few JIRAs in "patch available" state for some time. I will really appreciate if someone can review them. 1. https://issues.apache.org/jira/browse/KAFKA-2132 2. https://issues.apache.org/jira/browse/KAFKA-2005 3. https://issues.apache.org/jira/browse/KAFKA-1722 4. https://issues

Re: [DISCUSS] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand

Hi Guys, This has been lying around for quite some time. Should I start a voting thread on this? On Thu, May 7, 2015 at 12:20 PM, Ashish Singh wrote: > Had to change the title of the page and that surprisingly changed the link > as well. KIP-23 is now available at here &g

Re: notes from Kafka KIP hangout Jun. 2

Jun, Thanks for the notes! @Jun/ Joel, An inline question on ISR info in TMR. On Tuesday, June 2, 2015, Jun Rao wrote: > The following are my notes. > > 1. Security: Harsh will upload a new SSL patch in the next day or two. > > 2. KIP-21 (dynamic configuration): > How to serve DescribeConfigRe

Re: KIP Wiki

I like the idea! On Mon, Jun 1, 2015 at 9:51 AM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wrote: > Hey everyone, > > We have enough KIP's now (25) that it's a bit hard to tell which ones are > adopted or under discussion by glancing at the wiki. Any concerns if I > split it into 3 table

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

+1 on discussing this on next KIP hangout. I will update KIP-24 before that. On Fri, May 29, 2015 at 3:40 AM, Andrii Biletskyi < andrii.bilets...@stealth.ly> wrote: > Guys, > > I won't be able to attend next meeting. But in the latest patch for KIP-4 > Phase 1 > I didn't even evolve TopicMetadata

Re: Kafka KIP hangout May 26

Below are my notes. Feel free to add/ modify the content. Kafka KIP discussion (May 26, 2015) KIP-12 (sasl/ssl authentication): status check Not much discussion this time. KIP-21 (configuration management) - Aditya will make changes to KIP-4 based on last time’s discussion. - Andrei is OK w

Re: [DISCUSS] KIP-25 System test improvements

Geoffrey, This looks great! A few questions. 1. Will ducktape be maintained separately as a github repo? 2. How easy is viewing the test results and logs. The link in KIP, http://testing.confluent.io/confluent_platform/latest/, lists a bunch of files and dirs. Could you add to KIP how the result

Notes from KIP Hangout, May 19, 2015

Hey Guys, Below are my notes from today’s hangout. Feel free to add/modify the content. KIP Hangout (May 19, 2015) KIP-12 (sasl/ssl authentication): status check - Gwen has posted patch for KAFKA-1928, network refactoring. - Needed for sasl changes. - Pretty close to completion. - Har

Re: [DISCUSS] KIP-21 Configuration Management

I agree with the Joel's suggestion on keeping broker's configs in config file and clients/topics config in ZK. Few other projects, Apache Solr for one, also does something similar for its configurations. On Monday, May 11, 2015, Gwen Shapira wrote: > I like this approach (obviously). > I am also

Re: [DISCUSS] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand

Had to change the title of the page and that surprisingly changed the link as well. KIP-23 is now available at here <https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=56852556>. On Thu, May 7, 2015 at 11:34 AM, Ashish Singh wrote: > Hi Guys, > > I just added a KI

[DISCUSS] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand

Hi Guys, I just added a KIP, KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand , for KAFKA-313 . The changes made as part of the JIRA can be found here

Re: [DISCUSS] KIP-21 Configuration Management

e problem. You can't store > the location of the file in the file itself. The location of the file has > to be passed out of band into Kafka. > > Thanks, > > Jun > > On Wed, May 6, 2015 at 6:34 PM, Ashish Singh > wrote: > > > Hey Jun, > > > > Wh

Re: [DISCUSS] KIP-21 Configuration Management

, May 6, 2015, Ashish Singh wrote: > Hey Jun, > > Where does the broker get the info, which zk it needs to talk to? > > On Wednesday, May 6, 2015, Jun Rao > wrote: > >> Ashish, >> >> 3. Just want to clarify. Why can't you store ZK connection config in Z

Re: [DISCUSS] KIP-21 Configuration Management

t; > Jun > > On Wed, May 6, 2015 at 5:48 PM, Ashish Singh > wrote: > > > I too would like to share some concerns that we came up with while > > discussing the effect of moving configs to zookeeper will have. > > > > 1. Kafka will start to become a configurat

Re: [DISCUSS] KIP-21 Configuration Management

I too would like to share some concerns that we came up with while discussing the effect of moving configs to zookeeper will have. 1. Kafka will start to become a configuration management tool to some degree, and be subject to all the things such tools are commonly asked to do. Kafka'll likely nee

Re: Kafka KIP hangout May 5

Below are my notes from today’s KIP hangout. Please feel free to add/ correct the content. Kafka KIP Discussion (May 5) KIP-4 (admin commands): any remaining issues - Only issue left is how to handle multiple instructions for one topic. Suggestion here was to silently ignore duplicate instru

Re: Adding multi-tenancy capabilities to Kafka

what "topic paths" a client has access to rather > than needing a new client instance that connects to that separate namespace > (a la zookeeper). I think this will be a nice way to share config and acl > defaults too. > > -Jay > > On Tue, May 5, 2015 at 10:36 AM, Ashish Si

Re: Adding multi-tenancy capabilities to Kafka

Adrian, Trying to follow up the discussion here. Is my understanding correct that if we have topic hierarchies then we can do without namespaces. To me namespace is an abstraction, it can be implemented with topic hierarchies as well, would you agree? If so I guess topic hierarchies is the way to

Re: Request to add my confluent id to Apache Kafka

Thanks Jun! On Monday, May 4, 2015, Jun Rao wrote: > Added. > > Thanks, > > Jun > > On Mon, May 4, 2015 at 2:17 PM, Ashish Singh > wrote: > > > Thanks for extending help here. I do have a separate confluence wiki > > account, https://cwiki.apache.or

Re: Request to add my confluent id to Apache Kafka

Thanks for extending help here. I do have a separate confluence wiki account, https://cwiki.apache.org/confluence/display/~asingh. Below are the details. username: asingh email: asi...@cloudera.com full name: Ashish Singh Let me know if you are still not able to find me. On Mon, May 4, 2015 at

Re: Request to add my confluent id to Apache Kafka

Bummer... I meant *Confluence id* :) On Mon, May 4, 2015 at 1:48 PM, Ashish Singh wrote: > Hello, > > While trying to create a KIP, I realized that I probably need to get my > confluence id to be able to create a page under Apache Kafka. Either that > or I am doing somethi

Request to add my confluent id to Apache Kafka

Hello, While trying to create a KIP, I realized that I probably need to get my confluence id to be able to create a page under Apache Kafka. Either that or I am doing something wrong. Could someone with appropriate privileges/ knowledge help me out. My confluence account is registered with "asi..

Re: Review Request 33614: Patch for KAFKA-2132

Diff: https://reviews.apache.org/r/33614/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 33614: Patch for KAFKA-2132

o use StringSerializer, I can create a wrapper on top of current MockProducer to support String values. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/#review8

Re: Review Request 33614: Patch for KAFKA-2132

: https://reviews.apache.org/r/33614/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 33645: Patch for KAFKA-2153

--- On April 28, 2015, 11:04 p.m., Ashish Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33645/ > -

Review Request 33645: Patch for KAFKA-2153

://reviews.apache.org/r/33645/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 33614: Patch for KAFKA-2132

--- Thanks, Ashish Singh

Re: Review Request 33614: Patch for KAFKA-2132

--- Thanks, Ashish Singh

Re: Review Request 33614: Patch for KAFKA-2132

--- Thanks, Ashish Singh

Review Request 33614: Patch for KAFKA-2132

/log4j/KafkaLog4jAppenderTest.java PRE-CREATION log4j/src/test/java/org/apache/kafka/log4j/MockKafkaLog4jAppender.java PRE-CREATION settings.gradle 83f764e6a4a15a5fdba232dce74a369870f26b45 Diff: https://reviews.apache.org/r/33614/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 31369: Patch for KAFKA-1982

Jun, My apologies for not catching the checkstyle issues before. Should be fine now. Thanks for the prompt reviews. On Sun, Apr 19, 2015 at 1:14 AM, Ashish Singh wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31369/ > Review re

Re: Review Request 31369: Patch for KAFKA-1982

examples/src/main/java/kafka/examples/SimpleConsumerDemo.java 0d66fe5f8819194c8624aed4a21105733c20cc8e Diff: https://reviews.apache.org/r/31369/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 31369: Patch for KAFKA-1982

ly, visit: https://reviews.apache.org/r/31369/#review80555 --- On April 18, 2015, midnight, Ashish Singh wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 31369: Patch for KAFKA-1982

examples/src/main/java/kafka/examples/SimpleConsumerDemo.java 0d66fe5f8819194c8624aed4a21105733c20cc8e Diff: https://reviews.apache.org/r/31369/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 31369: Patch for KAFKA-1982

view77747 --- On April 17, 2015, 10:09 p.m., Ashish Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 31369: Patch for KAFKA-1982

view77523 --- On April 17, 2015, 10:09 p.m., Ashish Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 31369: Patch for KAFKA-1982

examples/src/main/java/kafka/examples/SimpleConsumerDemo.java 0d66fe5f8819194c8624aed4a21105733c20cc8e Diff: https://reviews.apache.org/r/31369/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 31369: Patch for KAFKA-1982

examples/src/main/java/kafka/examples/SimpleConsumerDemo.java 0d66fe5f8819194c8624aed4a21105733c20cc8e Diff: https://reviews.apache.org/r/31369/diff/ Testing --- Thanks, Ashish Singh

Re: Chicken and egg problem when initializing SocketServer

Hi Gwen, Can we buffer the requests that arrive before acceptors are up. Once we have the acceptors, the buffer can be cleared. However, this adds on to the complexity. On Sunday, April 5, 2015, Gwen Shapira wrote: > Hi, > > I'm trying to rebase KAFKA-1809 after KAFKA-1501 was committed, and I'

Re: Review Request 30809: Patch for KAFKA-1888

upgrade/bin/test-broker-upgrade.sh <https://reviews.apache.org/r/30809/#comment125925> Probably, extract out in a "upgrade" method for reusability and readability. - Ashish Singh On March 23, 2015, 6:54 p.m., Abhishek Nigam wrote: > > -

Review Request 31765: Patch for KAFKA-2005

/browse/KAFKA-2005 Repository: kafka Description --- KAFKA-2005: Generate html report for system tests Diffs - system_test/system_test_runner.py 5078d4479fab71722751a28c3c8f5c0f61baadec Diff: https://reviews.apache.org/r/31765/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 31711: Patch for KAFKA-1994

gt; > isNamespaceChecked is true, we will throw a ConfigException if the > > namespace doesn't exist. > > Ashish Singh wrote: > Not sure if that is a good idea. If we do that then there won't be an > easy way to fix the situation. Even if someone creates that

Re: Review Request 31711: Patch for KAFKA-1994

/test/scala/unit/kafka/zk/ZKPathTest.scala 9897b2fa8f8261fe8ab6b62b45b9052adb07043f Diff: https://reviews.apache.org/r/31711/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 31711: Patch for KAFKA-1994

visit: https://reviews.apache.org/r/31711/#review75132 ------- On March 4, 2015, 12:45 a.m., Ashish Singh wrote: > > --- > This is an automatically generat

Re: Review Request 31369: Patch for KAFKA-1982

view74895 --- On March 4, 2015, 1:51 a.m., Ashish Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 31369: Patch for KAFKA-1982

ded "sync" example. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/#review74553 --- On March 4, 201

Re: Review Request 31369: Patch for KAFKA-1982

examples/src/main/java/kafka/examples/SimpleConsumerDemo.java 0d66fe5f8819194c8624aed4a21105733c20cc8e Diff: https://reviews.apache.org/r/31369/diff/ Testing --- Thanks, Ashish Singh

Review Request 31711: Patch for KAFKA-1994

9897b2fa8f8261fe8ab6b62b45b9052adb07043f Diff: https://reviews.apache.org/r/31711/diff/ Testing --- Thanks, Ashish Singh

Re: ConsumerTest

+1 On Fri, Feb 27, 2015 at 1:42 PM, Gwen Shapira wrote: > Actually, we will greatly appreciate :) > > On Fri, Feb 27, 2015 at 1:37 PM, Neha Narkhede wrote: > > Would anyone object if I commented out the kafka.api.ConsumerTest out > until > > it is fixed? It hangs and is making accepting patches

Re: Review Request 31369: Patch for KAFKA-1982

7;s probably better to print each mesage in a single line and print > > out the key as well. Done - Ashish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/#revie

<    1   2   3   4   >