Re: [DISCUSS] KIP-507: Securing Internal Connect REST Endpoints

2019-08-28 Thread Greg Harris
Hey Chris, The KIP makes sense to me, and I think it's a very natural way to solve the issue at hand. I had two questions about the automatic rollout logic. Does this roll-out ratchet the protocol version irreversibly? What is the expected behavior when the feature has been enabled, and a worker

Request to be added as a contributor

2019-09-09 Thread Greg Harris
Hi, I'd like to contribute to Kafka, and would like permissions for the following accounts: ASF Jira: gharris1727 Confluence: gharris1727 Thanks! Greg Harris

Re: Unable to start the Kafka with Kraft in Windows 11

2023-09-05 Thread Greg Harris
Hey Sumanshu, Thanks for trying out Kraft! I hope that you can get it working :) I am not familiar with Kraft or Windows, but the error appears to mention that the file is already in use by another process so maybe we can start there. 1. Have you verified that no other Kafka processes are

Re: Disabling Test: org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated()

2023-08-28 Thread Greg Harris
Hey Sagar, The JIRA for this flaky test is here: https://issues.apache.org/jira/browse/KAFKA-8115 Rather than disabling the test, I think we should look into the cause of the flakiness. Thanks! Greg On Mon, Aug 28, 2023 at 2:49 AM Sagar wrote: > > Hi All, > > Should we disable this test: >

Re: [VOTE] KIP-965: Support disaster recovery between clusters by MirrorMaker

2023-08-29 Thread Greg Harris
Hi hudeqi, Thanks for the KIP! I think the original behavior (removing WRITE permissions during the sync) is a good default, but is not acceptable in every situation. I think providing a configuration for this behavior is the right idea. I had a few questions: 1. Is this configuration only

Re: [VOTE] KIP-970: Deprecate and remove Connect's redundant task configurations endpoint

2023-09-06 Thread Greg Harris
Hey Yash, +1(binding) Thanks for the KIP! Greg On Wed, Sep 6, 2023 at 6:59 AM Yash Mayya wrote: > > Hi all, > > I just wanted to bump up this vote thread. Thanks to everyone who's voted > so far - we have 1 binding +1 vote and 3 non-binding +1 votes so far. > > Thanks, > Yash > > On Wed, Aug

Re: Apache Kafka 3.6.0 release

2023-09-06 Thread Greg Harris
Hey all, A user just experienced this problem that has already been reported for several versions and has an open PR: https://issues.apache.org/jira/browse/KAFKA-14273 https://github.com/apache/kafka/pull/12763 Impact: In KRaft mode on Windows, Kafka crashes on startup with an IOException. Does

Re: Unable to start the Kafka with Kraft in Windows 11

2023-09-06 Thread Greg Harris
; > -- > Ziming > > > On Sep 6, 2023, at 07:25, Greg Harris wrote: > > > > Hey Sumanshu, > > > > Thanks for trying out Kraft! I hope that you can get it working :) > > > > I am not familiar with Kraft or Windows, but the error appears to > > mentio

Re: [ANNOUNCE] New Kafka PMC Member: Justine Olshan

2023-09-23 Thread Greg Harris
Congratulations Justine! On Sat, Sep 23, 2023 at 5:49 AM Boudjelda Mohamed Said wrote: > > Congrats Justin ! > > On Sat 23 Sep 2023 at 14:44, Randall Hauch wrote: > > > Congratulations, Justine! > > > > On Sat, Sep 23, 2023 at 4:25 AM Kamal Chandraprakash < > > kamal.chandraprak...@gmail.com>

Re: [ANNOUNCE] New committer: Yash Mayya

2023-09-21 Thread Greg Harris
Congratulations Yash! Glad to have you :) On Thu, Sep 21, 2023 at 8:44 AM Boudjelda Mohamed Said wrote: > > Congratulations Yash Mayya > > > On Thu 21 Sep 2023 at 17:28, Bruno Cadonna wrote: > > > Hi all, > > > > The PMC of Apache Kafka is pleased to announce a new Kafka committer > > Yash

Re: Apache Kafka 3.6.0 release

2023-09-18 Thread Greg Harris
Hi Satish, While validating 3.6.0-rc0, I noticed this regression as compared to 3.5.1: https://issues.apache.org/jira/browse/KAFKA-15473 Impact: The `connector-plugins` endpoint lists duplicates which may cause confusion for users, or poor behavior in clients. Using the other REST API endpoints

Re: [VOTE] 3.6.0 RC0

2023-09-18 Thread Greg Harris
Hey all, I noticed this regression in RC0: https://issues.apache.org/jira/browse/KAFKA-15473 I've mentioned it in the release thread, and I'm working on a fix. I'm -1 (non-binding) until we determine if this regression is a blocker. Thanks! On Mon, Sep 18, 2023 at 10:56 AM Josep Prat wrote: >

Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-20 Thread Greg Harris
Hi all, I verified the functionality of KIP-898 and the recent fix for KAFKA-15473 with the following steps: 1. I started a 3.5.1 broker, and a 3.5.1 worker with most (>400) publicly available plugins installed 2. I captured the output of /connector-plugins 3. I upgraded the worker to 3.6.0-rc1

[DISCUSS] KIP-986: Cross-Cluster Replication

2023-10-02 Thread Greg Harris
le, but I don't have an implementation in mind that meets these requirements. If you have additional requirements, an alternative UX in mind, or wish to propose some implementation details, please edit the KIP with your contributions. Thanks everyone! Greg Harris Aiven, Inc

Re: Re: [DISCUSS] Cluster Linking / Cross-Cluster Replication - Call for Interest & Co-Authors

2023-10-02 Thread Greg Harris
of this feature, and make edits to the KIP directly when you feel it is appropriate. Thanks! Greg Harris On Mon, May 22, 2023 at 4:59 AM Andrew Otto wrote: > > Hello! > > The Wikimedia Foundation would be very interested in this feature. It > would make deployment of multi DC/region stre

Re: [VOTE] 3.6.0 RC2

2023-10-02 Thread Greg Harris
Hey Satish, I verified KIP-898 functionality and the KAFKA-15473 patch. +1 (non-binding) Thanks! On Mon, Oct 2, 2023 at 1:28 PM Justine Olshan wrote: > > Hey all -- I noticed we still have the system tests as something that will > be updated. Did we get a run for this RC? > > On Mon, Oct 2,

Re: [DISCUSS] KIP-986: Cross-Cluster Replication

2023-10-02 Thread Greg Harris
topic ids? > D2. "The network path between Kafka clusters is assumed to be less reliable > than the intra-cluster network," we should be explicit about whether or not > we're assuming similar network latencies and bandwidth for the > inter-cluster network links as for the in-cluster

Re: [DISCUSS] KIP-986: Cross-Cluster Replication

2023-10-03 Thread Greg Harris
above Kafka or a proxy can solve > this by abstracting away the cluster itself. It could force out a metadata > refresh and from that point on clients can fetch from the other cluster. Is > this problem within the scope of this KIP or not? > > Thanks, > Viktor > > > On

Re: Permission to Create KIP

2023-10-03 Thread Greg Harris
Hey Colt, You should be all set. Looking forward to the KIP! Greg On Tue, Oct 3, 2023 at 11:37 AM Colt McNealy wrote: > > Hello there, > > Could I please have access to create a Wiki page? A team member and I would > like to jointly propose a small KIP. > > JIRA id: coltmcnealy-lh > > Thank

Re: [DISCUSS] KIP-986: Cross-Cluster Replication

2023-10-04 Thread Greg Harris
clusters than in > pre-TS Kafka. Do you think we should take this into consideration in the > design and in the UX? > > Thanks, > Viktor > > On Tue, Oct 3, 2023 at 6:30 PM Greg Harris > wrote: > > > Hi Viktor, > > > > Thanks for your questions! I agree

Re: Apache Kafka 3.6.0 release

2023-09-18 Thread Greg Harris
: https://github.com/apache/kafka/pull/14398 and I'll work to get it merged promptly. Thanks! On Mon, Sep 18, 2023 at 11:54 AM Greg Harris wrote: > > Hi Satish, > > While validating 3.6.0-rc0, I noticed this regression as compared to > 3.5.1: https://issues.apache.org/jira/bro

Re: Requesting to be added to Kafka project

2023-10-12 Thread Greg Harris
Hey Alyssa, Thanks for considering opening a KIP! I've given you the necessary permissions to create a KIP, let me know if you have any more issues. Thanks! Greg On Thu, Oct 12, 2023 at 3:22 PM Alyssa Huang wrote: > > Can I also have edit/write permission for Confluence to start a KIP? My >

Re: [VOTE] KIP-976: Cluster-wide dynamic log adjustment for Kafka Connect

2023-10-06 Thread Greg Harris
Hey Chris, Thanks for the KIP! I think that preserving the ephemeral nature of the logging change is the right choice here, and using the config topic for intra-cluster broadcast is better than REST forwarding. +1 (binding) Thanks, Greg On Fri, Oct 6, 2023 at 9:05 AM Chris Egerton wrote: > >

Re: [DISCUSS] KIP-986: Cross-Cluster Replication

2023-10-05 Thread Greg Harris
his information. It could also serve as an admin endpoint (swagger maybe?) > for managing flows and configuration. With this you could instruct clusters > to create/pause/delete replications. What do you think? > > Thanks, > Viktor > > > > On Wed, Oct 4, 2023 at

[DISCUSS] KIP-987: Connect Static Assignments

2023-10-05 Thread Greg Harris
Strimzi. Find the proposal here: https://github.com/strimzi/proposals/pull/96 Thanks! Greg Harris

Re: Re: [DISCUSS] KIP-986: Cross-Cluster Replication

2023-10-07 Thread Greg Harris
Hello hudeqi, I apologize if the KIP and discussion have diverged, as I've been trying to add detail rather than propose changes. > Why can't we use the follower fetch protocol? What you've described sounds like a very reasonable implementation of CCR. I purposely have not specified any

Re: [DISCUSS] KIP-987: Connect Static Assignments

2023-10-18 Thread Greg Harris
is restarted or is being > rolled? Would the assignment eventually be sticky when the worker comes > back? Does this new protocol also abide by the scheduled rebalance delays? > Maybe this has been explained in the KIP but it wasn't clear to me when I > read it. > > Thanks! > Sa

Re: [DISCUSS] KIP-987: Connect Static Assignments

2023-10-10 Thread Greg Harris
to the user/operator how to configure their static workers and > > static assignments. > > 5. Is there a lurking assumption that task indices are stable? E.g. that > > the task with index 3 will always be the resource-intensive one. I can see > > that that would often be a reliable as

Re: [DISCUSS] KIP-987: Connect Static Assignments

2023-10-10 Thread Greg Harris
this proposal, because the management layer is responsible for placing workers and placing tasks on those workers, it would also be responsible for implementing rack-awareness in isolated JVMs. Thanks a lot! Greg On Tue, Oct 10, 2023 at 10:08 AM Greg Harris wrote: > > Hey Tom, > >

Re: Re: [DISCUSS] Cluster Linking / Cross-Cluster Replication - Call for Interest & Co-Authors

2023-10-09 Thread Greg Harris
Hey all, I think it may be helpful to discuss the KIP draft more informally on the ASF slack #kafka channel. I've invited those of you who responded above, and for anyone else who wants an invite please just let me know on this thread. Thanks! Greg On Mon, Oct 2, 2023 at 1:39 PM Greg Harris

Re: [VOTE] KIP-980: Allow creating connectors in a stopped state

2023-10-09 Thread Greg Harris
Thanks Yash for the well written KIP! And thank you for finally adding JSON support to the standalone mode that isn't file extension sensitive. That will be very useful. +1 (binding) On Mon, Oct 9, 2023 at 10:45 AM Knowles Atchison Jr wrote: > > This is super useful for pipeline setup! > > +1

Re: [DISCUSS] KIP-987: Connect Static Assignments

2023-10-20 Thread Greg Harris
hen a connector is created, the runtime tries to place tasks on the > available brokers by matching the placement and tags. If no suitable > workers are found, the tasks stay in unassigned state and the runtime > waits for the management system to create the necessary workers. > > We

Re: [DISCUSS] KIP-987: Connect Static Assignments

2023-10-20 Thread Greg Harris
ld prevent a custom assignor from solving the resource utilization problem adequately. Thanks! Greg On Fri, Oct 20, 2023 at 9:58 AM Greg Harris wrote: > > Mickael, > > Thank you for discussing that rejected alternative, I was almost going > to propose it. > > > I still find the

Development with Git Worktree

2023-10-23 Thread Greg Harris
Hey Kafka Developers, This is a small announcement that the gradle build now supports the git-worktree subcommand [1] on the 3.4, 3.5, 3.6, and trunk branches [2]. If you've needed to check out multiple copies of Kafka concurrently, you previously needed to manage multiple full clones of the

Re: [VOTE] KIP-967: Support custom SSL configuration for Kafka Connect RestServer

2023-10-23 Thread Greg Harris
Hey Taras, Thanks for the KIP! The design you propose follows the conventions started in KIP-519, and should feel natural to operators familiar with the broker feature. I also like that we're able to clean up some connect-specific functionality and make the codebase more consistent. +1

Re: [VOTE] KIP-953: partition method to be overloaded to accept headers as well.

2023-08-23 Thread Greg Harris
Hey Jack, The design of this KIP is also consistent with the way header support was added to Connect: https://cwiki.apache.org/confluence/display/KAFKA/KIP-440%3A+Extend+Connect+Converter+to+support+headers I think making argument for precedent here is reasonable. Hi Ismael, Can you expand what

Re: [VOTE] KIP-953: partition method to be overloaded to accept headers as well.

2023-08-26 Thread Greg Harris
to `NewTopic` or `CreateTopicsOptions`. > > Ismael > > On Wed, Aug 23, 2023 at 11:48 AM Greg Harris > wrote: > > > Hey Jack, > > > > The design of this KIP is also consistent with the way header support > > was added to Connect: > > > &

Re: [VOTE] KIP-953: partition method to be overloaded to accept headers as well.

2023-08-26 Thread Greg Harris
/1d22b0d70686aef5689b775ea2ea7610a37f3e8c > > Ismael > > On Sat, Aug 26, 2023 at 8:29 AM Greg Harris > wrote: > > > Hey Ismael, > > > > Thank you for clarifying where the DTO pattern is used already, I did > > not have the admin methods in mind. &g

Re: Please provide permission to add reviewer in github PR

2023-08-25 Thread Greg Harris
, 2023 at 9:28 AM Arpit Goyal wrote: > > Sure I tagged in the jira , will also comment in GitHub. > Do we maintain a list of issues which beginner can start picking from? > > On Fri, Aug 25, 2023, 21:49 Greg Harris > wrote: > > > Hi Arpit, > > > > Contribu

Re: Please provide permission to add reviewer in github PR

2023-08-25 Thread Greg Harris
Hi Arpit, Contributors aren't typically given permissions to tag reviewers in the kafka repository. Instead, you should @-mention potential reviewers in a github comment. Hope this helps! Greg On Fri, Aug 25, 2023 at 9:15 AM Arpit Goyal wrote: > > Hi All, > I just generated a patch for one of

Re: KIP-993: Allow restricting files accessed by File and Directory ConfigProviders

2023-11-08 Thread Greg Harris
Hey Tina, Thanks for the KIP! Unrestricted file system access over a REST API is an unfortunate anti-pattern, so I'm glad that you're trying to change it. I had a few questions, mostly from the Connect perspective. 1. In the past Connect removed the FileStream connectors in order to prevent a

Re: [DISCUSS] Apache Kafka 3.5.2 release

2023-11-10 Thread Greg Harris
Hey Luke, I merged and backported KAFKA-15800 to 3.5 and 3.6, sorry for the delay. Thanks for running the release! Greg On Thu, Nov 9, 2023 at 6:54 PM Luke Chen wrote: > > Hi all, > > Greg found a regression issue in Kafka connect: > https://issues.apache.org/jira/browse/KAFKA-15800 > I'll

Faster connector config dev cycles - A vision and prototype

2022-10-24 Thread Greg Harris
and/or a RestExtension without any (significant) upstream changes. This proposal would not constitute any strictly new use-cases, but rather make the Standalone Mode more viable for the stated use-case, which is for "ad hoc, small, or experimental jobs." Thanks in advance for your comments, Greg Harris

RE: Re: [DISCUSS] KIP-875: First-class offsets support in Kafka Connect

2022-10-13 Thread Greg Harris
Hey Chris, Thanks for the KIP! I think this is an important feature for both development and operations use-cases, and it's an obvious gap in the REST feature set. I also appreciate the incremental nature of the KIP and the future extensions that will now be possible. I had a couple of

Re: Re: [DISCUSS] KIP-875: First-class offsets support in Kafka Connect

2022-10-14 Thread Greg Harris
have served > no benefit. It's also worth noting that publishing an empty set of task > configs is not the same as tombstoning existing task configs; putting a > connector into the STOPPED state should require no tombstones to be emitted > to the config topic. > > Cheers, > > Chris

Re: [ANNOUNCE] New committer: Justine Olshan

2022-12-29 Thread Greg Harris
Congratulations Justine! On Thu, Dec 29, 2022 at 1:37 PM Bill Bejeck wrote: > Congratulations Justine! > > > -Bill > > On Thu, Dec 29, 2022 at 4:36 PM Philip Nee wrote: > > > wow congrats! > > > > On Thu, Dec 29, 2022 at 1:05 PM Chris Egerton > > wrote: > > > > > Congrats, Justine! > > > > >

Re: [DISCUSS] Apache Kafka 3.4.0 release

2022-12-05 Thread Greg Harris
Hi All, Just notifying everyone of a regression introduced by KIP-787, currently only present on trunk, but which may qualify as a blocker for the release. It manifests as a moderate resource leak on MirrorMaker2 clusters. The fix should have a small scope and low risk. Here's the bug ticket:

Re: [ANNOUNCE] New committer: Josep Prat

2022-12-20 Thread Greg Harris
Congratulations Josep! On Tue, Dec 20, 2022 at 9:29 AM Chris Egerton wrote: > Congrats Josep! Well-earned. > > On Tue, Dec 20, 2022, 12:26 Jun Rao wrote: > > > Hi, Everyone, > > > > The PMC of Apache Kafka is pleased to announce a new Kafka committer > Josep > > Prat. > > > > Josep has been

[DISCUSS] KIP-898: Modernize Connect plugin discovery

2023-01-17 Thread Greg Harris
Hi all! I'd like to start a discussion about https://cwiki.apache.org/confluence/display/KAFKA/KIP-898%3A+Modernize+Connect+plugin+discovery . Thanks! Greg Harris

Re: [DISCUSS] KIP-898: Modernize Connect plugin discovery

2023-01-23 Thread Greg Harris
irely in 5.0. > > Cheers, > > Chris > > On Mon, Jan 23, 2023 at 3:21 AM Federico Valeri > wrote: > > > Hi Greg, this looks like a useful change to me. > > > > I was just wondering if we should use a better script name like > > "connect-convert-to-service-provider.sh" or something like this, and > > maybe add a --dry-run option. > > > > On Tue, Jan 17, 2023 at 8:45 PM Greg Harris > > wrote: > > > > > > Hi all! > > > > > > I'd like to start a discussion about > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-898%3A+Modernize+Connect+plugin+discovery > > > . > > > > > > Thanks! > > > Greg Harris > > >

Re: [DISCUSS] KIP-875: First-class offsets support in Kafka Connect

2023-01-18 Thread Greg Harris
Hi Chris, I had some clarifying questions about the alterOffsets hooks. The KIP includes these elements of the design: * The Javadoc for the methods mentions that the alterOffsets methods are only called on started and initialized connector objects. * The 'Altering' and 'Resetting' offsets

Re: [VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-01-23 Thread Greg Harris
Hi Chris, I'm +1 (non-binding) for KIP-875. Thanks for proposing this change! Greg Harris On Wed, Jan 18, 2023 at 10:41 AM Chris Egerton wrote: > Hi all, > > I'd like to call for a vote on KIP-875, which adds support for viewing and > manipulating the offsets of connectors

Re: [VOTE] KIP-710: Full support for distributed mode in dedicated MirrorMaker 2.0 clusters

2022-11-10 Thread Greg Harris
+1 (non-binding) Thanks for the KIP, this is an important improvement. Greg On Thu, Nov 10, 2022 at 7:21 AM John Roesler wrote: > Thanks for the KIP, Daniel! > > I'm no MM expert, but I've read over the KIP and discussion, and it seems > reasonable to me. > > I'm +1 (binding). > > Thanks, >

Re: [DISCUSS] KIP-883: Add delete callback method to Connector API

2022-11-09 Thread Greg Harris
Hi Hector, Thanks for the KIP! This is certainly missing functionality from the native Connect framework, and we should try to make it possible to inform connectors about this part of their lifecycle. However, as with most functionality that was left out of the initial implementation of the

Re: [VOTE] KIP-898: Modernize Connect plugin discovery

2023-03-06 Thread Greg Harris
non-binding votes. KIP-898 has PASSED voting. Thanks all for your support, and I'll get to work on the implementation. Greg Harris On Tue, Feb 28, 2023 at 7:44 AM Bill Bejeck wrote: > Thanks for the well-detailed KIP, Greg. It'll be a needed improvement. > > +1(binding) > >

Re: [ANNOUNCE] New Kafka PMC Member: Chris Egerton

2023-03-09 Thread Greg Harris
Congratulations Chris! Extremely well deserved! Greg On Thu, Mar 9, 2023 at 10:12 AM Jun Rao wrote: > Hi, Everyone, > > Chris Egerton has been a Kafka committer since July 2022. He has been very > instrumental to the community since becoming a committer. It's my pleasure > to announce that

Re: [DISCUSSION] MirrorMaker2 offset translation for compacted, filtered, and transactional source topics

2023-03-16 Thread Greg Harris
this point it's pretty much > > > like picking a random offset when consumers start on the target > > > cluster. > > > > > > Apart if we have to introduce new configurations, metrics, or public > > > APIs, making the offset translatio

Re: [DISCUSSION] MirrorMaker2 offset translation for compacted, filtered, and transactional source topics

2023-03-15 Thread Greg Harris
ithout a KIP? > --> Again, if it's a bug fix or an improvement without affecting public > API, I don't think a KIP is needed. > > > Q6. Do you have any suggestions on how to improve availability of offset > translation? > > > > Thank you. > Luke > > On Wed,

Re: [DISCUSSION] MirrorMaker2 offset translation for compacted, filtered, and transactional source topics

2023-03-14 Thread Greg Harris
suggestions on how to improve availability of offset translation? I'm interested in finding a tactical solution that we can backport, and a holistic solution for more future use-cases. I hope that the above is more clear. Thanks! Greg On Fri, Mar 10, 2023 at 12:16 PM Greg Harris wrote: > Hi

[DISCUSSION] MirrorMaker2 offset translation for compacted, filtered, and transactional source topics

2023-03-10 Thread Greg Harris
Hi all, Recently, we've been experimenting with using MM2 to mirror topics that were populated by transactional producers. We've noticed that MM2 replicates records but not transaction markers, causing certain offsets to appear in the source topic but not destination topic. These behaviors can

Re: [DISCUSSION] MirrorMaker2 offset translation for compacted, filtered, and transactional source topics

2023-03-21 Thread Greg Harris
is constructed with the included log message, but I feel it's still very opaque and want to try and explain it better. Thanks! On Thu, Mar 16, 2023 at 11:57 AM Greg Harris wrote: > Thanks all for the discussion! > > Mickael, > > I agree. I think that while someone may appreciate t

Re: [DISCUSS] KIP-793: Sink Connectors: Support topic-mutating SMTs for async connectors (preCommit users)

2023-03-07 Thread Greg Harris
Hi Yash, I always use this issue as an example of a bug being caused by design rather than by implementation error, and once it's fixed I'll need to find something else to talk about :) So glad to see this get fixed! I'll chime in to support some of the earlier discussions that seem to have been

Re: [DISCUSS] KIP-793: Sink Connectors: Support topic-mutating SMTs for async connectors (preCommit users)

2023-03-13 Thread Greg Harris
active approach of handling > everything purely in the framework and only exposing "virtual coordinates" > to the connectors. I think the biggest thorn here is maintaining backward > compatibility with the considerable ecosystem of existing connectors which > is something Connect

Re: [DISCUSS] KIP-882: Make Kafka Connect REST API request timeouts configurable

2023-03-13 Thread Greg Harris
take that into consideration - but > that isn't the case today. Furthermore, I'm not sure I understand why the > addition of request timeout configurability to the existing endpoints would > preclude the introduction of an asynchronous validation API in the future? > > Thanks, >

Re: [DISCUSS] KIP-882: Make Kafka Connect REST API request timeouts configurable

2023-03-02 Thread Greg Harris
Hey Yash, Thanks for the KIP, and sorry for the late review. 1. Have you considered a HTTP header to provide the client-configurable timeout? A header might more naturally extend to all of the other endpoints in the future, rather than duplicating the query parameter across endpoints. 2. I

Re: [DISCUSS] KIP-882: Make Kafka Connect REST API request timeouts configurable

2023-03-03 Thread Greg Harris
re which rely on the current > synchronous config validation behavior and breaking the existing contract > would definitely require a larger discussion. > > Thanks, > Yash > > On Fri, Mar 3, 2023 at 12:04 AM Greg Harris > wrote: > > > Hey Yash, > >

Re: [DISCUSS] KIP-898: Modernize Connect plugin discovery

2023-02-16 Thread Greg Harris
rate a new jar instead of mutating the source jar. Thanks! Greg Harris On Thu, Feb 16, 2023 at 3:53 AM Tom Bentley wrote: > Hi Greg, > > Thanks for the KIP. Overall I think using service loading would be a > worthwhile improvement. > > 1. "Both of these are well-established

[VOTE] KIP-898: Modernize Connect plugin discovery

2023-02-27 Thread Greg Harris
Hi, I'd like to call a vote for KIP-898 which aims to improve the performance of Connect startup by allowing discovery of plugins via the ServiceLoader. KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-898 %3A+Modernize+Connect+plugin+discovery Discussion thread:

Re: Test failures

2023-04-14 Thread Greg Harris
Hey Ismael, We're working to stabilize the Connect/MM2 tests with the following issues: * https://issues.apache.org/jira/browse/KAFKA-14905 to address MirrorConectorsWithCustomForwardingAdminIntegrationTest with tentative open PR * https://issues.apache.org/jira/browse/KAFKA-14901 to address

Re: Test failures

2023-04-21 Thread Greg Harris
occasionally. Thanks, Greg On Fri, Apr 14, 2023 at 12:18 PM Ismael Juma wrote: > Thanks Greg! I really appreciate the help. > > Ismael > > On Fri, Apr 14, 2023 at 12:08 PM Greg Harris > > wrote: > > > Hey Ismael, > > > > We're working to stabilize the Con

Re: [DISCUSS] Apache Kafka 3.5.0 release

2023-03-27 Thread Greg Harris
Mickael, Just wanted to let you know that I will not be including KIP-898 in the 3.5.0 release. I think the change needed is not reviewable before the feature freeze deadline, and would take resources away from other more necessary changes. Thanks! Greg On Thu, Mar 23, 2023 at 9:01 AM Chia-Ping

Re: [VOTE] KIP-875: First-class offsets support in Kafka Connect

2023-04-11 Thread Greg Harris
- https://github.com/apache/kafka/pull/13465/#discussion_r1159694956 > > Cheers, > > Chris > > On Fri, Mar 3, 2023 at 10:22 AM Chris Egerton wrote: > > > Hi all, > > > > Thanks for the votes! I'll cast a final +1 myself and close the vote out. > > > > Thi

Re: [DISCUSS] KIP-898: Modernize Connect plugin discovery

2023-02-07 Thread Greg Harris
com/en/java/javase/11/docs/api/java.base/java/util/ServiceLoader.html#iterator() > > Cheers, > > Chris > > On Tue, Jan 24, 2023 at 10:26 AM Federico Valeri > wrote: > > > Hi Greg, > > > > On Tue, Jan 24, 2023 at 2:48 AM Greg Harris > > wrote: > > > >

Re: [DISCUSS] Partial CI builds - Reducing flakiness with fewer tests

2023-06-13 Thread Greg Harris
On each trunk commit (i.e., PR > merge)? How would we handle commits that break the integration tests? Would > we revert commits on trunk, or fix-forward? > > -David > > > On Thu, Jun 8, 2023 at 2:02 PM Greg Harris > wrote: > > > Gaurav, > > >

Re: [VOTE] KIP-793: Allow sink connectors to be used with topic-mutating SMTs

2023-07-03 Thread Greg Harris
Hey Yash, Thanks so much for your effort in the design and discussion phase! +1 (non-binding) Greg On Mon, Jul 3, 2023 at 7:19 AM Chris Egerton wrote: > > Hi Yash, > > Thanks for the KIP! +1 (binding) > > Cheers, > > Chris > > On Mon, Jul 3, 2023 at 7:02 AM Yash Mayya wrote: > > > Hi all, >

Re: [DISCUSS] KIP-916: MM2 distributed mode flow log context

2023-07-11 Thread Greg Harris
Hey Daniel, Thanks for the KIP! The current logging behavior seems like a usability nightmare. I've only debugged single-worker JVM deployments, and I see now that I took the uniqueness of a connector name for granted. I had a few questions about the change: 1. The MDC context change and the

Re: [DISCUSS] KIP-943: Add independent "offset.storage.segment.bytes" for connect-distributed.properties

2023-07-13 Thread Greg Harris
Hey hudeqi, Thanks for the KIP! I did not know about the existing segment.bytes default value, and it does seem rather high in the context of the Connect internal topics. If I think about the segment.size as a "minimum per-partition data transfer on startup", 1GB is certainly not appropriate for

Re: [DISCUSS] Adding non-committers as Github collaborators

2023-05-30 Thread Greg Harris
> > > > > > > > > [1] https://tinkerpop.apache.org/ > > > > > > > > > > -- > > > > > Divij Vaidya > > > > > > > > > > > > > > > > > > > > On Mon, May 15, 2023 at 11:07 PM Joh

Re: [DISCUSS] Adding non-committers as Github collaborators

2023-06-02 Thread Greg Harris
t; > invite? I'm andymg3 on GitHub. > > Thanks, > > Andrew > > > > On Tue, May 30, 2023 at 12:12 PM Greg Harris > > > > wrote: > > > > > Hey all, > > > > > > I received an invitation to collaborate on apache/kafka, but let the

Re: [VOTE] 3.4.1 RC1

2023-05-22 Thread Greg Harris
Hi Luke, I performed a test upgrade of MM2 from 3.4.0 to 3.4.1-RC1, and verified that the new offset translation logic worked as intended. Steps I took to verify: - Downloaded 3.4.0_2.13 from the Kafka website - Formatted and started two 3.4.0 1-node clusters, and configured MM2 to mirror data

Re: [VOTE] 3.4.1 RC1

2023-05-22 Thread Greg Harris
or correctness of the connectors. If something else forces a new RC, perhaps consider rolling this into the next RC. Thanks, Greg On Mon, May 22, 2023 at 1:47 PM Greg Harris wrote: > > Hi Luke, > > I performed a test upgrade of MM2 from 3.4.0 to 3.4.1-RC1, and > verified that the new off

Re: [VOTE] 3.5.0 RC0

2023-05-25 Thread Greg Harris
and interested in having this fixed: https://github.com/apache/kafka/pull/13748 The overall fix should be a one-liner + some unit tests. While this is not a regression, it does make the feature largely useless, as the majority of use-cases will be for struct fields. Thanks! Greg Harris On Wed, May 24

Re: [DISCUSS] Partial CI builds - Reducing flakiness with fewer tests

2023-06-08 Thread Greg Harris
https://github.com/apache/brpc > > * https://github.com/apache/trafficserver > > * https://github.com/apache/ws-axiom > > > > I wonder how the Kafka community feels about experimenting with Bazel and > > exploring if it helps us offer faster build times without compromi

Re: [DISCUSS] Adding non-committers as Github collaborators

2023-06-06 Thread Greg Harris
t; > John > > > > On Fri, Jun 2, 2023, at 18:46, Hao Li wrote: > >> Hi Luke, > >> > >> Sorry for the late reply. Can you also add me to the whitelist? I believe > >> I'm supposed to be there as well. Matthias and John can vouch for me :)

Re: [DISCUSS] Partial CI builds - Reducing flakiness with fewer tests

2023-06-06 Thread Greg Harris
this first. If > we can stabilize them, I wonder if we should also enforce a green build to > merge. > > Best, > David > > > > On Mon, Jun 5, 2023 at 7:47 PM Greg Harris > wrote: > > > Hey all, > > > > I've been working on test flakiness

[DISCUSS] Partial CI builds - Reducing flakiness with fewer tests

2023-06-05 Thread Greg Harris
Hey all, I've been working on test flakiness recently, and I've been trying to come up with ways to tackle the issue top-down as well as bottom-up, and I'm interested to hear your thoughts on an idea. In addition to the current full-suite runs, can we in parallel trigger a smaller test run which

Re: [VOTE] KIP-949: Add flag to enable the usage of topic separator in MM2 DefaultReplicationPolicy

2023-07-25 Thread Greg Harris
Hey Omnia, Thanks for the KIP! I think that MM2 is responsible for providing an upgrade path for users, even if it isn't backwards-compatible by default due to a mistake. The non-configuration-based strategies I could think of aren't viable due to the danger of inferring the incorrect topic

Re: [VOTE] KIP-959 Add BooleanConverter to Kafka Connect

2023-07-26 Thread Greg Harris
Hey Hector, Thanks for the straightforward and clear KIP! +1 (binding) Thanks, Greg On Wed, Jul 26, 2023 at 5:16 AM Chris Egerton wrote: > > +1 (binding) > > Thanks Hector! > > On Wed, Jul 26, 2023 at 3:18 AM Kamal Chandraprakash < > kamal.chandraprak...@gmail.com> wrote: > > > +1

Re: Flaky tests need attention (clients, Connect, Mirror Maker, Streams, etc.)

2023-08-08 Thread Greg Harris
Hey all, MirrorConnectorsIntegration*Test#testOffsetTranslationBehindReplicationFlow() flakiness should be addressed by https://github.com/apache/kafka/pull/14156 which is currently in review. There is other flakiness in the suite which this PR does not address and needs further investigation.

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread Greg Harris
Congratulations! On Tue, Jun 13, 2023 at 9:15 AM Mickael Maison wrote: > > Congratulations! > > On Tue, Jun 13, 2023 at 6:05 PM Yash Mayya wrote: > > > > Congratulations Divij! > > > > On Tue, Jun 13, 2023 at 9:20 PM Bruno Cadonna wrote: > > > > > Hi all, > > > > > > The PMC of Apache Kafka is

[DISCUSS] Cluster Linking / Cross-Cluster Replication - Call for Interest & Co-Authors

2023-05-19 Thread Greg Harris
n help ensure that the feature is delivered with a more predictable timeline. Please save your technical expectations and details of this feature for a subsequent KIP and DISCUSS thread, where that discussion is more appropriate. Thanks Everyone! Greg Harris Aiven, Inc

Re: [DISCUSS] KIP-877: Mechanism for plugins and connectors to register metrics

2024-02-08 Thread Greg Harris
Hi Mickael, Thanks for the KIP, this looks like a great change! 1. I see that one of my concerns was already discussed, and appears to have been concluded with: > I considered Chris' idea of automatically removing metrics but decided to > leave that responsibility to the plugins. After

Re: DISCUSS KIP-984 Add pluggable compression interface to Kafka

2024-02-14 Thread Greg Harris
Hi Assane, Thanks for the KIP! Looking back, it appears that the project has only ever added compression types twice: lz4 in 2014 and zstd in 2018, and perhaps Kafka has fallen behind the state-of-the-art compression algorithms. Thanks for working to fix that! I do have some concerns: 1. I

Re: KRaft controller number of replicas

2024-02-06 Thread Greg Harris
Hi Dani, I believe the limitation that this documentation is hinting at is the motivation for KIP-996 [1], and the notice in the documentation would be removed once KIP-996 lands. You can read the KIP for a brief explanation and link to a more in-depth explanation of the failure scenario. While

Re: Github build queue

2024-02-09 Thread Greg Harris
Hi David, +1 on that strategy. I see several flaky tests that aren't marked with @Tag("integration") or @IntegrationTest, and I think those would make using the unitTest target ineffective here. We could also start a new tag @Tag("flaky") and exclude that. Thanks, Greg On Fri, Feb 9, 2024 at

Re: Github build queue

2024-02-09 Thread Greg Harris
ion") for all of those tests? Seems like > > that would not be too hard. > > > > Ismael > > > > On Fri, Feb 9, 2024 at 9:03 AM Greg Harris > > wrote: > > > > > Hi David, > > > > > > +1 on that strategy. > > > > > > I see

Re: Github build queue

2024-02-09 Thread Greg Harris
Juma wrote: > > > > > Why can't we add @Tag("integration") for all of those tests? Seems like > > > that would not be too hard. > > > > > > Ismael > > > > > > On Fri, Feb 9, 2024 at 9:03 AM Greg Harris > >

Re: Seeking Assistance with MM2 Rest API Configuration - Encountering 404 Error

2024-02-18 Thread Greg Harris
Hi Aaron, This is the expected behavior of KIP-710. The relevant section reproduced here: > Enabling a single Connect REST server in the MirrorMaker 2.0 node, only supporting the internal Connect endpoints. The endpoints that are typically exposed in a distributed Connect for creating

Re: Kafka trunk test & build stability

2023-12-19 Thread Greg Harris
Hey Stan, Thanks for opening the discussion. I haven't been looking at overall build duration recently, so it's good that you are calling it out. I worry about us over-indexing on this one build, which itself appears to be an outlier. I only see one other build [1] above 6h overall in the last

[DISCUSS] Connect Jira component name

2023-12-26 Thread Greg Harris
Hi Connect Developers, I noticed recently that we had two Jira components: "KafkaConnect" and "connect", one with >1000 issues and one with 20 issues. I merged the two tags, leaving the one labeled "KafkaConnect". "KafkaConnect" doesn't follow the standard naming convention set by all of the

  1   2   3   4   >