moresandeep commented on a change in pull request #514:
URL: https://github.com/apache/knox/pull/514#discussion_r740970651
##
File path:
gateway-util-common/src/main/java/org/apache/knox/gateway/util/Urls.java
##
@@ -71,6 +71,16 @@ public static int dotOccurrences(String
smolnar82 commented on a change in pull request #514:
URL: https://github.com/apache/knox/pull/514#discussion_r740717763
##
File path:
gateway-util-common/src/test/java/org/apache/knox/gateway/util/UrlsTest.java
##
@@ -94,4 +94,9 @@ public void testURLEncoding() throws
lmccay closed pull request #513:
URL: https://github.com/apache/knox/pull/513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
moresandeep commented on a change in pull request #514:
URL: https://github.com/apache/knox/pull/514#discussion_r740970651
##
File path:
gateway-util-common/src/main/java/org/apache/knox/gateway/util/Urls.java
##
@@ -71,6 +71,16 @@ public static int dotOccurrences(String
lmccay commented on a change in pull request #514:
URL: https://github.com/apache/knox/pull/514#discussion_r741028811
##
File path:
gateway-util-common/src/main/java/org/apache/knox/gateway/util/Urls.java
##
@@ -71,6 +71,16 @@ public static int dotOccurrences(String domain) {
lmccay merged pull request #514:
URL: https://github.com/apache/knox/pull/514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
smolnar82 commented on a change in pull request #514:
URL: https://github.com/apache/knox/pull/514#discussion_r740717763
##
File path:
gateway-util-common/src/test/java/org/apache/knox/gateway/util/UrlsTest.java
##
@@ -94,4 +94,9 @@ public void testURLEncoding() throws
lmccay opened a new pull request #515:
URL: https://github.com/apache/knox/pull/515
## What changes were proposed in this pull request?
Invalidate any originalUrl being used in the flow for KnoxSSO that contains
user information (username and password).
There is no reason for an
lmccay merged pull request #514:
URL: https://github.com/apache/knox/pull/514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
moresandeep commented on a change in pull request #514:
URL: https://github.com/apache/knox/pull/514#discussion_r741043708
##
File path:
gateway-util-common/src/main/java/org/apache/knox/gateway/util/Urls.java
##
@@ -71,6 +71,16 @@ public static int dotOccurrences(String
lmccay commented on a change in pull request #514:
URL: https://github.com/apache/knox/pull/514#discussion_r741028811
##
File path:
gateway-util-common/src/main/java/org/apache/knox/gateway/util/Urls.java
##
@@ -71,6 +71,16 @@ public static int dotOccurrences(String domain) {
moresandeep commented on a change in pull request #514:
URL: https://github.com/apache/knox/pull/514#discussion_r740970651
##
File path:
gateway-util-common/src/main/java/org/apache/knox/gateway/util/Urls.java
##
@@ -71,6 +71,16 @@ public static int dotOccurrences(String
smolnar82 commented on a change in pull request #514:
URL: https://github.com/apache/knox/pull/514#discussion_r740718985
##
File path:
gateway-util-common/src/test/java/org/apache/knox/gateway/util/UrlsTest.java
##
@@ -94,4 +94,9 @@ public void testURLEncoding() throws
smolnar82 commented on a change in pull request #514:
URL: https://github.com/apache/knox/pull/514#discussion_r740717763
##
File path:
gateway-util-common/src/test/java/org/apache/knox/gateway/util/UrlsTest.java
##
@@ -94,4 +94,9 @@ public void testURLEncoding() throws
lmccay opened a new pull request #514:
URL: https://github.com/apache/knox/pull/514
## What changes were proposed in this pull request?
Invalidate any originalUrl being used in the flow for KnoxSSO that contains
user information (username and password).
There is no reason for an SSO
lmccay closed pull request #513:
URL: https://github.com/apache/knox/pull/513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lmccay opened a new pull request #513:
URL: https://github.com/apache/knox/pull/513
## What changes were proposed in this pull request?
Invalidate any originalUrl being used in the flow for KnoxSSO that contains
user information (username and password).
There is no reason for an SSO
smolnar82 merged pull request #512:
URL: https://github.com/apache/knox/pull/512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lmccay commented on pull request #512:
URL: https://github.com/apache/knox/pull/512#issuecomment-955791412
LGTM!
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
smolnar82 opened a new pull request #512:
URL: https://github.com/apache/knox/pull/512
## What changes were proposed in this pull request?
The Token Integration link on the Home page must be hidden if the required
`knox.token.hash.key` Gateway-level alias is missing.
## How
smolnar82 merged pull request #511:
URL: https://github.com/apache/knox/pull/511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
smolnar82 commented on pull request #511:
URL: https://github.com/apache/knox/pull/511#issuecomment-950129527
Cc. @zeroflag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
smolnar82 opened a new pull request #511:
URL: https://github.com/apache/knox/pull/511
## What changes were proposed in this pull request?
There was a compilation error on Knox's logout page which resulted in the
error message displayed what's described in the JIRA.
## How
smolnar82 merged pull request #510:
URL: https://github.com/apache/knox/pull/510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
smolnar82 commented on pull request #510:
URL: https://github.com/apache/knox/pull/510#issuecomment-947077742
Cc. @zeroflag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
smolnar82 opened a new pull request #510:
URL: https://github.com/apache/knox/pull/510
## What changes were proposed in this pull request?
Changed the producer version to `2.0.0-SNAPSHOT` on the master branch.
## How was this patch tested?
Built the project:
```
moresandeep merged pull request #509:
URL: https://github.com/apache/knox/pull/509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
moresandeep merged pull request #509:
URL: https://github.com/apache/knox/pull/509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
moresandeep commented on a change in pull request #509:
URL: https://github.com/apache/knox/pull/509#discussion_r727137704
##
File path:
gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/session/KnoxSessionStore.java
##
@@ -222,6 +240,25 @@ private
pzampino commented on a change in pull request #509:
URL: https://github.com/apache/knox/pull/509#discussion_r727130966
##
File path:
gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/filter/Pac4jDispatcherFilter.java
##
@@ -187,6 +200,27 @@ public
moresandeep commented on a change in pull request #509:
URL: https://github.com/apache/knox/pull/509#discussion_r727135022
##
File path:
gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/filter/Pac4jDispatcherFilter.java
##
@@ -187,6 +200,27 @@
smolnar82 commented on a change in pull request #509:
URL: https://github.com/apache/knox/pull/509#discussion_r727068387
##
File path:
gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/filter/Pac4jDispatcherFilter.java
##
@@ -187,6 +200,27 @@ public
smolnar82 commented on a change in pull request #509:
URL: https://github.com/apache/knox/pull/509#discussion_r727068387
##
File path:
gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/filter/Pac4jDispatcherFilter.java
##
@@ -187,6 +200,27 @@ public
smolnar82 commented on a change in pull request #509:
URL: https://github.com/apache/knox/pull/509#discussion_r727072226
##
File path:
gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/session/KnoxSessionStore.java
##
@@ -222,6 +240,25 @@ private
smolnar82 commented on pull request #509:
URL: https://github.com/apache/knox/pull/509#issuecomment-940905791
Cc. @zeroflag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
moresandeep opened a new pull request #509:
URL: https://github.com/apache/knox/pull/509
## What changes were proposed in this pull request?
This PR tries to address the issue where Knox SSO goes in a redirect loop
when the authenticated user is part of too many groups. This happens
zeroflag commented on pull request #507:
URL: https://github.com/apache/knox/pull/507#issuecomment-939983358
cc: @moresandeep @smolnar82 @pzampino @lmccay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zeroflag closed pull request #507:
URL: https://github.com/apache/knox/pull/507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zeroflag closed pull request #507:
URL: https://github.com/apache/knox/pull/507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
smolnar82 merged pull request #508:
URL: https://github.com/apache/knox/pull/508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
smolnar82 merged pull request #505:
URL: https://github.com/apache/knox/pull/505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zeroflag commented on pull request #508:
URL: https://github.com/apache/knox/pull/508#issuecomment-938509934
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
zeroflag closed pull request #507:
URL: https://github.com/apache/knox/pull/507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
smolnar82 commented on pull request #508:
URL: https://github.com/apache/knox/pull/508#issuecomment-938441251
Cc. @zeroflag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
smolnar82 opened a new pull request #508:
URL: https://github.com/apache/knox/pull/508
## What changes were proposed in this pull request?
Instead of invoking the entire `evictExpiredTokens` in
`DefaultTokenStateService` we only need to call the `removeTokens` method since
at this
zeroflag opened a new pull request #507:
URL: https://github.com/apache/knox/pull/507
(It is very **important** that you created an Apache Knox JIRA for this
change and that the PR title/commit message includes the Apache Knox JIRA ID!)
## What changes were proposed in this pull
moresandeep merged pull request #506:
URL: https://github.com/apache/knox/pull/506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dionusos opened a new pull request #506:
URL: https://github.com/apache/knox/pull/506
(It is very **important** that you created an Apache Knox JIRA for this
change and that the PR title/commit message includes the Apache Knox JIRA ID!)
## What changes were proposed in this pull
zeroflag commented on pull request #505:
URL: https://github.com/apache/knox/pull/505#issuecomment-933399251
cc: @smolnar82 @pzampino @moresandeep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
zeroflag opened a new pull request #505:
URL: https://github.com/apache/knox/pull/505
## What changes were proposed in this pull request?
JUnit version was updated to 4.13.2.
## How was this patch tested?
```
$ mvn dependency:tree | grep junit
```
--
This is an
smolnar82 merged pull request #503:
URL: https://github.com/apache/knox/pull/503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
moresandeep merged pull request #504:
URL: https://github.com/apache/knox/pull/504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
moresandeep opened a new pull request #504:
URL: https://github.com/apache/knox/pull/504
## What changes were proposed in this pull request?
This PR cleans up pac4j cookies after logout
## How was this patch tested?
This patch was tested on a local cluster.
--
smolnar82 commented on pull request #503:
URL: https://github.com/apache/knox/pull/503#issuecomment-931240486
Cc. @zeroflag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
smolnar82 opened a new pull request #503:
URL: https://github.com/apache/knox/pull/503
## What changes were proposed in this pull request?
The `HadoopAuthFilter` is now able to lookup aliases in the `__gateway`
credential store too.
## How was this patch tested?
Added
moresandeep merged pull request #502:
URL: https://github.com/apache/knox/pull/502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
moresandeep merged pull request #502:
URL: https://github.com/apache/knox/pull/502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
moresandeep opened a new pull request #502:
URL: https://github.com/apache/knox/pull/502
## What changes were proposed in this pull request?
For global logout, the requests goes to the knoxauth app which is configured
to use identity-assertion provider which can throw "Subject not
smolnar82 merged pull request #501:
URL: https://github.com/apache/knox/pull/501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
smolnar82 commented on pull request #501:
URL: https://github.com/apache/knox/pull/501#issuecomment-926025997
> LGTM. The patch looks good to me, but the inheritance hierarchy is a bit
difficult to follow.
It's not that complicated IMO.
zeroflag commented on pull request #501:
URL: https://github.com/apache/knox/pull/501#issuecomment-925863289
LGTM. The patch looks good to me, but the inheritance hierarchy is a bit
difficult to follow.
--
This is an automated message from the Apache Git Service.
To respond to the
smolnar82 commented on pull request #501:
URL: https://github.com/apache/knox/pull/501#issuecomment-925830174
Cc. @zeroflag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
smolnar82 opened a new pull request #501:
URL: https://github.com/apache/knox/pull/501
## What changes were proposed in this pull request?
See the root cause analysis in
https://issues.apache.org/jira/browse/KNOX-2670.
Additional note: the newly implemented
moresandeep merged pull request #500:
URL: https://github.com/apache/knox/pull/500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
spolavarpau1 opened a new pull request #500:
URL: https://github.com/apache/knox/pull/500
What changes were proposed in this pull request?
Fixed an issue where the rewrite rule is not referenced in the filter
How was this patch tested?
This patch was tested by deploying updated
zeroflag commented on pull request #488:
URL: https://github.com/apache/knox/pull/488#issuecomment-924916377
@risdenk ,
I opened a followup issue for the documentation upgrade + migration guide:
https://issues.apache.org/jira/browse/KNOX-2668
--
This is an automated message from
moresandeep closed pull request #489:
URL: https://github.com/apache/knox/pull/489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
moresandeep merged pull request #499:
URL: https://github.com/apache/knox/pull/499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
moresandeep merged pull request #497:
URL: https://github.com/apache/knox/pull/497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
moresandeep merged pull request #498:
URL: https://github.com/apache/knox/pull/498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
spolavarpau1 opened a new pull request #499:
URL: https://github.com/apache/knox/pull/499
What changes were proposed in this pull request?
Updated Ranger Service definition for knox logout/timeout to support knox
logout page in Ranger timeout and logout flow.
How was this patch
moresandeep opened a new pull request #498:
URL: https://github.com/apache/knox/pull/498
## What changes were proposed in this pull request?
This PR exposes a variable `{$frontend[gateway.name]}` for gateway name.
## How was this patch tested?
Tested on a local cluster.
sarathsubramanian opened a new pull request #497:
URL: https://github.com/apache/knox/pull/497
## What changes were proposed in this pull request?
Updated Atlas Service definition for knox logout/timeout to support knox
logout page in Atlas timeout and logout flow.
## How was
smolnar82 merged pull request #496:
URL: https://github.com/apache/knox/pull/496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
smolnar82 commented on pull request #496:
URL: https://github.com/apache/knox/pull/496#issuecomment-920969781
GitHub succeeded, given that Travis is extremely slow nowadays I'm merging
this change.
--
This is an automated message from the Apache Git Service.
To respond to the message,
zeroflag commented on pull request #496:
URL: https://github.com/apache/knox/pull/496#issuecomment-920943521
cc: @lmccay @pzampino @smolnar82 @moresandeep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zeroflag opened a new pull request #496:
URL: https://github.com/apache/knox/pull/496
## What changes were proposed in this pull request?
There is a parse error in redirect.jsp
```
:8443/gateway/knoxss…/home/?refresh=1:49 Uncaught SyntaxError: Unexpected
token ':'
```
zeroflag closed pull request #488:
URL: https://github.com/apache/knox/pull/488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
smolnar82 merged pull request #495:
URL: https://github.com/apache/knox/pull/495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
moresandeep commented on a change in pull request #489:
URL: https://github.com/apache/knox/pull/489#discussion_r709495441
##
File path:
gateway-service-definitions/src/main/resources/services/atlas/2.1.0/rewrite.xml
##
@@ -32,14 +32,20 @@
-
-
-
smolnar82 commented on a change in pull request #495:
URL: https://github.com/apache/knox/pull/495#discussion_r709357669
##
File path:
gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java
##
@@ -527,6 +527,12 @@ public Response
zeroflag commented on a change in pull request #495:
URL: https://github.com/apache/knox/pull/495#discussion_r709352438
##
File path:
gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java
##
@@ -527,6 +527,12 @@ public Response
ashutoshm commented on a change in pull request #489:
URL: https://github.com/apache/knox/pull/489#discussion_r709316096
##
File path:
gateway-service-definitions/src/main/resources/services/atlas/2.1.0/rewrite.xml
##
@@ -32,14 +32,20 @@
-
-
-
smolnar82 commented on pull request #495:
URL: https://github.com/apache/knox/pull/495#issuecomment-919944496
Cc. @zeroflag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
smolnar82 opened a new pull request #495:
URL: https://github.com/apache/knox/pull/495
## What changes were proposed in this pull request?
Users can revoke tokens created for them even they are not listed in
`knox.token.renewer.whitelist`
## How was this patch tested?
zeroflag closed pull request #488:
URL: https://github.com/apache/knox/pull/488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zeroflag commented on pull request #488:
URL: https://github.com/apache/knox/pull/488#issuecomment-919832184
> * This looks like it completely removes slf4j - is that correct? would it
make sense to have the slf4j->log4j2 bridge added for any dependency that might
use slf4j for logging?
smolnar82 merged pull request #494:
URL: https://github.com/apache/knox/pull/494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
smolnar82 merged pull request #493:
URL: https://github.com/apache/knox/pull/493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zeroflag commented on pull request #494:
URL: https://github.com/apache/knox/pull/494#issuecomment-919150330
I see, then I'm ok with it. Although the revoke + delete (and put + enable)
feels a bit weird to me. There is a verb in both the HTTP method and in the
path. But if it's mainly
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r708239236
##
File path:
gateway-service-remoteconfig/src/test/java/org/apache/knox/gateway/service/config/remote/zk/RemoteConfigurationRegistryClientServiceTestBase.java
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r708239012
##
File path:
gateway-server/src/test/java/org/apache/knox/gateway/services/security/impl/ZookeeperRemoteAliasServiceTest.java
##
@@ -96,6 +96,8 @@ public
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r708238645
##
File path:
gateway-provider-ha/src/test/java/org/apache/knox/gateway/ha/provider/impl/KafkaZookeeperURLManagerTest.java
##
@@ -44,6 +44,7 @@
@Before
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r708238056
##
File path:
gateway-i18n-logging-log4j/src/main/java/org/apache/knox/gateway/i18n/messages/loggers/log4j/Log4jMessageLogger.java
##
@@ -37,42 +33,15 @@
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r707432233
##
File path:
gateway-provider-rewrite/src/test/java/org/apache/knox/gateway/filter/rewrite/api/UrlRewriteServletFilterTest.java
##
@@ -527,41 +523,35 @@
zeroflag commented on a change in pull request #488:
URL: https://github.com/apache/knox/pull/488#discussion_r708197274
##
File path:
gateway-provider-ha/src/test/java/org/apache/knox/gateway/ha/provider/impl/AtlasZookeeperURLManagerTest.java
##
@@ -47,6 +47,7 @@
smolnar82 edited a comment on pull request #494:
URL: https://github.com/apache/knox/pull/494#issuecomment-919047102
> Does this change effect existing users or is this not yet used by anyone?
We only use the `revoke` and `enable\disable` API on the token management
page where I
smolnar82 commented on pull request #494:
URL: https://github.com/apache/knox/pull/494#issuecomment-919047102
> Does this change effect existing users or is this not yet used by anyone?
We only use the `revoke` and `enable\disable` API on the token management
page. Whoever uses
zeroflag commented on pull request #494:
URL: https://github.com/apache/knox/pull/494#issuecomment-919024871
Does this change effect existing users or is this not yet used by anyone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
smolnar82 commented on pull request #494:
URL: https://github.com/apache/knox/pull/494#issuecomment-919014456
Cc. @zeroflag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
901 - 1000 of 3972 matches
Mail list logo
