Re: Review Request 57908: Xsd for virtual fact

> On March 30, 2017, 5:26 a.m., Amareshwari Sriramadasu wrote: > > lens-api/src/main/resources/cube-0.1.xsd > > Lines 179-180 (patched) > > > > > > Are we planning to add this functionality, right now? If not, can

Re: Review Request 57908: Xsd for virtual fact

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57908/#review170821 --- lens-examples/src/main/resources/virtualfact1.xml Lines 22

Re: Review Request 57908: Xsd for virtual fact

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57908/ --- (Updated March 31, 2017, 1:20 p.m.) Review request for lens and Rajat

Re: Review Request 57908: Xsd for virtual fact

> On March 30, 2017, 5:26 a.m., Amareshwari Sriramadasu wrote: > > lens-examples/src/main/resources/virtualfact1.xml > > Lines 25-26 (patched) > > > > > > Should these be fields on cube or fields on fact? If fields

Re: Review Request 57908: Xsd for virtual fact

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57908/#review170530 --- lens-api/src/main/resources/cube-0.1.xsd Lines 179-180 (patched)

Re: Review Request 57908: Xsd for virtual fact

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57908/#review170283 --- Ship it! Ship It! - Rajat Khandelwal On March 28, 2017,

Re: Review Request 57908: Xsd for virtual fact

> On March 27, 2017, 11:24 a.m., Rajat Khandelwal wrote: > > lens-examples/src/main/resources/virtualfact1.xml > > Lines 22 (patched) > > > > > > We need to make weight mandatory. > > Puneet Gupta wrote: >

Re: Review Request 57908: Xsd for virtual fact

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57908/ --- (Updated March 28, 2017, 7:22 a.m.) Review request for lens and Rajat

Re: Review Request 57908: Xsd for virtual fact

> On March 27, 2017, 4:54 p.m., Rajat Khandelwal wrote: > > lens-examples/src/main/resources/virtualfact1.xml > > Lines 25 (patched) > > > > > > I think filter will only be where clauses. conditions on measures are

Re: Review Request 57908: Xsd for virtual fact

> On March 27, 2017, 11:24 a.m., Rajat Khandelwal wrote: > > lens-examples/src/main/resources/virtualfact1.xml > > Lines 25 (patched) > > > > > > I think filter will only be where clauses. conditions on measures are

Re: Review Request 57908: Xsd for virtual fact

> On March 27, 2017, 11:24 a.m., Rajat Khandelwal wrote: > > lens-examples/src/main/resources/virtualfact1.xml > > Lines 25 (patched) > > > > > > I think filter will only be where clauses. conditions on measures are

Re: Review Request 57908: Xsd for virtual fact

> On March 27, 2017, 11:24 a.m., Rajat Khandelwal wrote: > > lens-examples/src/main/resources/virtualfact1.xml > > Lines 25 (patched) > > > > > > I think filter will only be where clauses. conditions on measures are

Re: Review Request 57908: Xsd for virtual fact

> On March 27, 2017, 11:24 a.m., Rajat Khandelwal wrote: > > lens-examples/src/main/resources/virtualfact1.xml > > Lines 22 (patched) > > > > > > We need to make weight mandatory. Shoudn't we keep this optional. It

Re: Review Request 57908: Xsd for virtual fact

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57908/#review170154 --- lens-examples/src/main/resources/virtualfact1.xml Lines 22

Re: Review Request 57908: Xsd for virtual fact

> On March 24, 2017, 3:59 p.m., Rajat Khandelwal wrote: > > lens-api/src/main/resources/cube-0.1.xsd > > Lines 184 (patched) > > > > > > By extending, we'll have to specify everything that we specify for fact > >

Re: Review Request 57908: Xsd for virtual fact

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57908/ --- (Updated March 27, 2017, 9:55 a.m.) Review request for lens and Rajat

Re: Review Request 57908: Xsd for virtual fact

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57908/ --- (Updated March 27, 2017, 9:51 a.m.) Review request for lens and Rajat

Re: Review Request 57908: Xsd for virtual fact

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57908/#review170019 --- Can you also add one example xml file for virtual fact in

Re: Review Request 57908: Xsd for virtual fact

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57908/ --- (Updated March 24, 2017, 12:15 p.m.) Review request for lens and Rajat

Review Request 57908: Xsd for virtual fact

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57908/ --- Review request for lens and Rajat Khandelwal. Repository: lens Description