/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java
a1ccec682330d48f116e06a085d07db179888327
Diff: https://reviews.apache.org/r/37760/diff/
Testing
---
Thanks,
Rajat Khandelwal
e94c2f35f998796dd6e40d440db75305c56b9f1d
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
31c7dadec795141769d12448c9381a6a73482f61
Diff: https://reviews.apache.org/r/39651/diff/
Testing
---
Thanks,
Rajat Khandelwal
://reviews.apache.org/r/39651/diff/
Testing
---
Thanks,
Rajat Khandelwal
]
[INFO] Total time: 23:47.270s
[INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015
[INFO] Final Memory: 179M/1101M
[INFO]
Thanks,
Rajat Khandelwal
/
Testing
---
Thanks,
Rajat Khandelwal
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39652/#review104163
---
Ship it!
Ship It!
- Rajat Khandelwal
On Oct. 27, 2015, 12:17
]
[INFO] Total time: 23:47.270s
[INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015
[INFO] Final Memory: 179M/1101M
[INFO]
jdbc driver test cases and checkstyle passed
Thanks,
Rajat
]
[INFO] Total time: 23:47.270s
[INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015
[INFO] Final Memory: 179M/1101M
[INFO]
jdbc driver test cases and checkstyle passed
Thanks,
Rajat Khandelwal
]
jdbc driver test cases and checkstyle passed
Thanks,
Rajat Khandelwal
]
jdbc driver test cases and checkstyle passed
Thanks,
Rajat Khandelwal
]
jdbc driver test cases and checkstyle passed
Thanks,
Rajat Khandelwal
]
jdbc driver test cases and checkstyle passed
Thanks,
Rajat Khandelwal
eviews.apache.org/r/39651/#review103996
---
On Oct. 26, 2015, 5:56 p.m., Rajat Khandelwal wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39651/
> ---
/TestColumnarSQLRewriter.java
31c7dadec795141769d12448c9381a6a73482f61
lens-driver-jdbc/src/test/resources/jdbcdriver-site.xml
1dc0a85b485232ebb3513f910899d34323042605
Diff: https://reviews.apache.org/r/39651/diff/
Testing
---
Thanks,
Rajat Khandelwal
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39685/#review104164
---
Ship it!
Ship It!
- Rajat Khandelwal
On Oct. 27, 2015, 7 p.m
: 23:47.270s
[INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015
[INFO] Final Memory: 179M/1101M
[INFO]
jdbc driver test cases and checkstyle passed
Thanks,
Rajat Khandelwal
/parse/TestQuery.java
8e35ea9bd9cd727cc25ff011a03d6a38a6f0229f
Diff: https://reviews.apache.org/r/39895/diff/
Testing
---
Tested for some queries in the test cases themselves. Need to add proper
asserts.
Thanks,
Rajat Khandelwal
/HiveDriver.java
(line 1260)
<https://reviews.apache.org/r/39911/#comment164275>
Add test cases for not closeable?
- Rajat Khandelwal
On Nov. 9, 2015, 12:28 a.m., Deepak Barr wrote:
>
> ---
> This is an automatically g
8e35ea9bd9cd727cc25ff011a03d6a38a6f0229f
Diff: https://reviews.apache.org/r/39895/diff/
Testing
---
Tested for some queries in the test cases themselves. Need to add proper
asserts.
Thanks,
Rajat Khandelwal
[INFO] Final Memory: 194M/2045M
[INFO]
Thanks,
Rajat Khandelwal
+1
] Total time: 23:16.273s
[INFO] Finished at: Fri Oct 30 11:23:40 UTC 2015
[INFO] Final Memory: 198M/2047M
[INFO]
Thanks,
Rajat Khandelwal
Welcome Raj
Feel free to ask any question, basic or advanced. Questions you ask will
help us understand the gaps in our documentation. :)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40333/#review106663
---
Ship it!
Ship It!
- Rajat Khandelwal
On Nov. 16, 2015, 1:11
tps://reviews.apache.org/r/40333/#comment165351>
Can you mention the changes as experienced on UI? And testing done for
those?
- Rajat Khandelwal
On Nov. 16, 2015, 1:11 a.m., Ankeet Maini wrote:
>
> ---
> This is an automatica
)
<https://reviews.apache.org/r/40333/#comment165314>
This is just for optimization, right?
- Rajat Khandelwal
On Nov. 16, 2015, 1:11 a.m., Ankeet Maini wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
Hi Raj
I don't see any issues, but jus to re iterate, here's what I did after
which I verified the server to be up.
rajat.khandelwal@lappy:~/apache-lens-2.3.0-beta-bin [0]
$ ls
LICENSE LICENSE-CDDLv1.1-GPLv2_withCPE LICENSE-GPLv3 README
LICENSE-CDDL-v1.0 LICENSE-EDL LICENSE-LGPL client
( testcube .
alias1 ) HAVING (count(( testcube . alias3 )) > 10 ) ORDER BY testcube .
alias1 desc LIMIT 5
```
- Rajat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3989
]
Thanks,
Rajat Khandelwal
8e35ea9bd9cd727cc25ff011a03d6a38a6f0229f
Diff: https://reviews.apache.org/r/39895/diff/
Testing
---
Tested for some queries in the test cases themselves. Need to add proper
asserts.
Thanks,
Rajat Khandelwal
> On Nov. 17, 2015, 7:25 p.m., Rajat Khandelwal wrote:
> > src/site/apt/releases/release-history.apt, line 53
> > <https://reviews.apache.org/r/40383/diff/1/?file=1128106#file1128106line53>
> >
> > No need to mention review request here. jira should be
]
[INFO] Total time: 23:04.131s
[INFO] Finished at: Tue Nov 17 17:24:12 UTC 2015
[INFO] Final Memory: 198M/2050M
[INFO]
Thanks,
Rajat Khandelwal
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39891/#review104890
---
Ship it!
Ship It!
- Rajat Khandelwal
On Nov. 3, 2015, 12:07
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
d7484d83dc0a3f7810ab2109ec882b19b940803b
Diff: https://reviews.apache.org/r/39893/diff/
Testing
---
Thanks,
Rajat Khandelwal
The PMC for Apache Lens has asked Sushil, Pranav, Deepak and Amruth to
become Lens Committers. We are pleased to announce that they have accepted.
Being a committer enables access to commit to the source repositories and
binding votes for code reviews.
Join me in Congratulating them.
[INFO] Final Memory: 198M/2047M
[INFO]
Thanks,
Rajat Khandelwal
] Total time: 23:16.273s
[INFO] Finished at: Fri Oct 30 11:23:40 UTC 2015
[INFO] Final Memory: 198M/2047M
[INFO]
Thanks,
Rajat Khandelwal
or?
Just simplifying the regular expression.
- Rajat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39809/#review104567
---
On Nov. 2, 2015,
Yes. We've encountered this issue earlier. I've even discussed it on stack
overflow:
http://stackoverflow.com/questions/32988172/java-creating-a-date-in-pst-returns-a-date-in-pdt/32988326?noredirect=1#comment53803610_32988326
Simple solution would be to run the test cases in any other time zone
/BaseLensService.java (line 281)
<https://reviews.apache.org/r/39576/#comment162941>
What if it's already 0?
- Rajat Khandelwal
On Oct. 31, 2015, 5:54 a.m., Raju Bairishetti wrote:
>
> ---
> This is an automatically generated e-mail.
] Total time: 23:16.273s
[INFO] Finished at: Fri Oct 30 11:23:40 UTC 2015
[INFO] Final Memory: 198M/2047M
[INFO]
Thanks,
Rajat Khandelwal
/lens/server/query/QueryExecutionServiceImpl.java
(line 423)
<https://reviews.apache.org/r/39842/#comment162944>
Should we throw an error here? It'll be better to fail fast.
- Rajat Khandelwal
On Nov. 2, 2015, 9:38
/
Testing (updated)
---
Tested for some queries in the test cases themselves. Need to add proper
asserts.
Thanks,
Rajat Khandelwal
/TestLensQueryCommands.java (line 416)
<https://reviews.apache.org/r/39191/#comment160328>
can you take care of the TODO?
- Rajat Khandelwal
On Oct. 14, 2015, 7 a.m., Gabor Liptak wrote:
>
> ---
> This is an automatically generated e-mail.
/MetastoreConstants.java
da47fa5cb1fb5fbf6065b45de8e6f413c01bf779
Diff: https://reviews.apache.org/r/39311/diff/
Testing
---
Thanks,
Rajat Khandelwal
da47fa5cb1fb5fbf6065b45de8e6f413c01bf779
Diff: https://reviews.apache.org/r/39311/diff/
Testing
---
Thanks,
Rajat Khandelwal
/MetastoreConstants.java
da47fa5cb1fb5fbf6065b45de8e6f413c01bf779
lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/39311/diff/
Testing
---
Thanks,
Rajat Khandelwal
/QueryExecutionServiceImpl.java
(line 2076)
<https://reviews.apache.org/r/39314/#comment160331>
Should we do a contains check instead of equality?
As a cli user I doubt I'd like to give whole class name to get queries of a
driver.
- Rajat Khandelwal
On Oct. 14, 2015, 4:33 p.m., Deepa
] Final Memory: 194M/2045M
[INFO]
Thanks,
Rajat Khandelwal
be93b8cfe982fcf60b13dbd3abaa15879537c3fd
Diff: https://reviews.apache.org/r/38920/diff/
Testing
---
Thanks,
Rajat Khandelwal
0c980a20953efc6c2d7cc17c97b1552c64a8eb5f
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
ac942077d78515404b83f4a02f841b73dd39e3df
Diff: https://reviews.apache.org/r/39127/diff/
Testing
---
Thanks,
Rajat Khandelwal
Oct 08 12:59:09 UTC 2015
[INFO] Final Memory: 194M/2044M
[INFO]
Thanks,
Rajat Khandelwal
/QueryExecutionServiceImpl.java
(lines 1139 - 1140)
<https://reviews.apache.org/r/39161/#comment160718>
Constructor can take conf instead of a separate method.
- Rajat Khandelwal
On Oct. 16, 2015, 3:14 p.m., Deepak Barr
---
Thanks,
Rajat Khandelwal
va/org/apache/lens/server/query/QueryExecutionServiceImpl.java
(line 1098)
<https://reviews.apache.org/r/39161/#comment160714>
add purger thread to health check of execution service.
- Rajat Khandelwal
On Oct. 16, 2015, 3:14 p.m., Deepa
/browse/LENS-830
Repository: lens
Description
---
Diffs
-
pom.xml 714003835bccc217eb32e7c4ee782e1e6aacc434
Diff: https://reviews.apache.org/r/39394/diff/
Testing
---
Thanks,
Rajat Khandelwal
]
[INFO] Total time: 24:32.375s
[INFO] Finished at: Fri Oct 16 11:15:05 UTC 2015
[INFO] Final Memory: 194M/2045M
[INFO]
Thanks,
Rajat Khandelwal
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39314/#review102910
---
Ship it!
Ship It!
- Rajat Khandelwal
On Oct. 16, 2015, 3:20
/QueryExecutionServiceImpl.java
(line 2331)
<https://reviews.apache.org/r/39434/#comment161207>
there's a wrapper `setSelectedDriverQuery` for it. Can we use that?
- Rajat Khandelwal
On Oct. 19, 2015, 3:56 p.m., Amareshwari Sriramadasu
add param here.
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java
(line 109)
<https://reviews.apache.org/r/39314/#comment160375>
param update
- Rajat Khandelwal
On Oct. 14
comparison in upper case and
then `enum.getName()` can be used which does no computation.
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java
(line 81)
<https://reviews.apache.org/r/38521/#comment159562>
use `assertEquals`
- Rajat Khandelwal
/TestLensCubeCommands.java (lines 126
- 130)
<https://reviews.apache.org/r/38521/#comment159567>
Can we do a set compare?
`new HashSet(joinChains.getJoinChain())`
- Rajat Khandelwal
On Oct. 9, 2015, 2:38 p.m., Raju Bairishetti
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39221/#review102216
---
Ship it!
Ship It!
- Rajat Khandelwal
On Oct. 12, 2015, 12:21
che.org/r/38521/#comment159789>
let's also implement `toString` function.
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
(lines 94 - 110)
<https://reviews.apache.org/r/38521/#comment159786>
Can we use `TestQuery` here?
- Rajat Khandelwal
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38521/#review102233
---
Ship it!
Ship It!
- Rajat Khandelwal
On Oct. 12, 2015, 1:53
/ThreadSafeEstimatedQueryCollection.java
5d243798ebfe221a83afdbfc2ac42b3064244476
lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/39233/diff/
Testing
---
Thanks,
Rajat
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39127/#review102408
---
On Oct. 12, 2015, 1:52 p.m., Rajat Khandelwal wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38521/#review102442
---
Ship it!
Ship It!
- Rajat Khandelwal
On Oct. 13, 2015, 6:16
Hi All
Vote for Lens Release 2.3.0-beta has passed with 7 +1's (all binding), no 0
or -1's.
+1 votes:
Rajat Khandelwal
Amareshwari Sriramadasu
Raju Bairishetti
Yash Sharma
Arshad Matin
Raghavendra Singh
Jean-Baptiste Onofré
0 votes
* No votes
-1 Votes
* No votes
Vote thread:
http://mail
Hi all
The Apache Lens team is proud to announce the release of Apache Lens
2.3.0-beta. This is the first release of Apache Lens as TLP.
Apache Lens provides an Unified Analytics interface. Lens aims to cut the
Data Analytics silos by providing a single view of data across multiple
tiered data
]
Thanks,
Rajat Khandelwal
3c78e436c245bed2644e97bd0b3269e332cc9240
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java
a1ccec682330d48f116e06a085d07db179888327
Diff: https://reviews.apache.org/r/37760/diff/
Testing
---
Thanks,
Rajat Khandelwal
/jdbc/ColumnarSQLRewriter.java
(line 1227)
<https://reviews.apache.org/r/37434/#comment154100>
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
(line 1240)
<https://reviews.apache.org/r/37434/#comment154101>
`replaceDBAndTableName
]
[INFO] Total time: 21:55.372s
[INFO] Finished at: Tue Aug 25 12:48:00 UTC 2015
[INFO] Final Memory: 192M/1764M
[INFO]
Thanks,
Rajat Khandelwal
-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
(line 63)
<https://reviews.apache.org/r/37934/#comment154819>
Instead of `long`, can we re-use `QueryHandle`?
lens-server-api/src/main/java/org/apache/lens/s
> On Sept. 10, 2015, 1:19 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java,
> > line 30
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066442#file1066442line30>
> >
> > This
g/r/37934/#comment154861>
Make default pagination configurable.
- Rajat Khandelwal
On Sept. 10, 2015, 12:53 a.m., Amruth Sampath wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
]
[INFO] Total time: 21:29.260s
[INFO] Finished at: Fri Sep 11 06:41:41 UTC 2015
[INFO] Final Memory: 193M/1888M
[INFO]
Thanks,
Rajat Khandelwal
[INFO] Final Memory: 193M/1888M
[INFO]
Thanks,
Rajat Khandelwal
530/#comment156281>
remove redundant space
- Rajat Khandelwal
On Sept. 17, 2015, 5:49 p.m., Ankeet Maini wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
egression/util/Util.java (line
174)
<https://reviews.apache.org/r/37526/#comment155847>
return type.
- Rajat Khandelwal
On Sept. 14, 2015, 6:40 p.m., Arshad Matin wrote:
>
> ---
> This is an automatical
/Util.java (line
401)
<https://reviews.apache.org/r/37526/#comment155849>
JaxbUtils has the same method.
- Rajat Khandelwal
On Sept. 14, 2015, 6:40 p.m., Arshad Matin wrote:
>
> ---
> This is an automatically generated e
- 580)
<https://reviews.apache.org/r/38402/#comment155839>
only null check needed.
- Rajat Khandelwal
On Sept. 15, 2015, 6:18 p.m., Amareshwari Sriramadasu wrote:
>
> ---
> This is an automaticall
a test case
Thanks,
Rajat Khandelwal
]
Thanks,
Rajat Khandelwal
: https://reviews.apache.org/r/38889/diff/
Testing
---
Thanks,
Rajat Khandelwal
hen run separately, the test
case passed. Running again though.
Thanks,
Rajat Khandelwal
hen run separately, the test
case passed. Running again though.
Thanks,
Rajat Khandelwal
> On Oct. 1, 2015, 2:37 p.m., Rajat Khandelwal wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java, line 84
> > <https://reviews.apache.org/r/38521/diff/5/?file=1088336#file1088336line84>
> >
> > Instead of String replace, can `extra
eIndex("blah blah join blah blah", 10) = 10
getNextJoinTypeIndex("blah blah join blah blah", 11) = 10 ?
getNextJoinTypeIndex("blah blah join blah blah", 12) = 10?
getNextJoinTypeIndex("blah blah join blah blah",
I
://reviews.apache.org/r/38920/diff/
Testing
---
Thanks,
Rajat Khandelwal
/TableReference.java (line
42)
<https://reviews.apache.org/r/38402/#comment157560>
We are serializing as `t1.f1->t2.f2[n]`. So `parseBoolean` might not work.
- Rajat Khandelwal
On Sept. 16, 2015, 2:33 p.m., Amareshwari Sriramad
]
Thanks,
Rajat Khandelwal
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38666/#review100156
---
Ship it!
Ship It!
- Rajat Khandelwal
On Sept. 23, 2015, 12:10
> On Sept. 22, 2015, 1:37 p.m., Rajat Khandelwal wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java,
> > line 90
> > <https://reviews.apache.org/r/38521/diff/4/?file=1079586#file1079586line90>
> >
> > is
530/#comment157010>
Can we change `localhost` everywhere to `0.0.0.0`?
I think Lens server also listens on all interfaces instead of just loopback.
- Rajat Khandelwal
On Sept. 22, 2015, 12:04 p.m., Ankeet Maini
2015
[INFO] Final Memory: 186M/1378M
[INFO]
Thanks,
Rajat Khandelwal
reply, visit:
https://reviews.apache.org/r/41039/#review109253
-------
On Dec. 7, 2015, 8:28 p.m., Rajat Khandelwal wrote:
>
> ---
> This is an automatically
/LensClient.java
5fd04c4591264ac2e5082f1a60281b15fac9
lens-client/src/main/java/org/apache/lens/client/LensStatement.java
40e6d76d20dbb1359d4d6dc64ff7c41f324c7662
Diff: https://reviews.apache.org/r/41033/diff/
Testing (updated)
---
http://showterm.io/ec9c4280efd6a72e03143
Thanks,
Rajat
rror code for parsing, can we use that here?
>
> Rajat Khandelwal wrote:
> We're using SYNTAX_ERROR in other places, used that here too :)
>
> Amareshwari Sriramadasu wrote:
> SYNTAX_ERROR is for query, and expression parsing is for metastore.
> Please confirm if my s
1 - 100 of 2611 matches
Mail list logo
