Re: Review Request 43649: Druid driver in Lens

2016-02-18 Thread Rajitha R
at: Wed Feb 17 11:13:45 UTC 2016 [INFO] Final Memory: 199M/1276M [INFO] Thanks, Rajitha R

Re: Review Request 43649: Druid driver in Lens

2016-03-22 Thread Rajitha R
] Finished at: Wed Feb 17 11:13:45 UTC 2016 [INFO] Final Memory: 199M/1276M [INFO] Thanks, Rajitha R

Re: Review Request 43649: Druid driver in Lens

2016-03-29 Thread Rajitha R
[28.467s] Thanks, Rajitha R

Re: Review Request 43649: Druid driver in Lens

2016-04-29 Thread Rajitha R
] Thanks, Rajitha R

Re: Review Request 43649: Druid driver in Lens

2016-04-29 Thread Rajitha R
] [INFO] Total time: 39:26.518s [INFO] Finished at: Fri Apr 29 19:40:08 IST 2016 [INFO] Final Memory: 144M/1496M [INFO] Thanks, Rajitha R

Re: Review Request 50740: Lens Druid sql rewriter changes

2016-08-25 Thread Rajitha R
PRE-CREATION lens-driver-jdbc/src/test/resources/drivers/jdbc/druid/jdbcdriver-site.xml PRE-CREATION Diff: https://reviews.apache.org/r/50740/diff/ Testing --- Thanks, Rajitha R

Re: Review Request 50740: Lens Druid sql rewriter changes

2016-08-25 Thread Rajitha R
---- On Aug. 3, 2016, 7:28 a.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50740/ > -

Re: Review Request 50740: Lens Druid sql rewriter changes

2016-09-08 Thread Rajitha R
/ Testing --- Thanks, Rajitha R

Re: Review Request 50740: Lens Druid sql rewriter changes

2016-09-08 Thread Rajitha R
://reviews.apache.org/r/50740/diff/ Testing --- Thanks, Rajitha R

Re: Review Request 53059: Druid sql rewriter changes

2016-10-27 Thread Rajitha R
cf9657a Diff: https://reviews.apache.org/r/53059/diff/ Testing --- Thanks, Rajitha R

Re: Review Request 53059: Druid sql rewriter changes

2016-11-06 Thread Rajitha R
Client SUCCESS [0.437s] Thanks, Rajitha R

Re: Review Request 53059: Druid sql rewriter changes

2016-11-06 Thread Rajitha R
d to test for the opposite scenario too, if skip warnings is set > > to false, is validate/prepare failing? > > Rajitha R wrote: > setting it to false wont be enough. we ll need to get stmt.getwarnings() > return non null for coming up with the negative test case > >

Review Request 53059: Druid sql rewriter changes

2016-10-20 Thread Rajitha R
/drivers/jdbc/druid/jdbcdriver-site.xml e4fad23 Diff: https://reviews.apache.org/r/53059/diff/ Testing --- Thanks, Rajitha R

Re: Review Request 53059: Druid sql rewriter changes

2016-10-26 Thread Rajitha R
eviews.apache.org/r/53059/#review153516 --- On Oct. 26, 2016, 10:38 a.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53059/ > ---

Re: Review Request 53059: Druid sql rewriter changes

2016-10-26 Thread Rajitha R
/apache/lens/driver/jdbc/JDBCDriverConfConstants.java f4e0451 lens-driver-jdbc/src/test/resources/drivers/jdbc/druid/jdbcdriver-site.xml e4fad23 Diff: https://reviews.apache.org/r/53059/diff/ Testing --- Thanks, Rajitha R

Re: Review Request 53059: Druid sql rewriter changes

2016-10-26 Thread Rajitha R
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDruidSQLRewriter.java c4cc91d lens-driver-jdbc/src/test/resources/drivers/jdbc/druid/jdbcdriver-site.xml e4fad23 Diff: https://reviews.apache.org/r/53059/diff/ Testing --- Thanks, Rajitha R

Re: Review Request 53059: Druid sql rewriter changes

2016-11-03 Thread Rajitha R
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53059/#review153996 ----------- On Oct. 27, 2016, 10:12 a.m., Rajitha R wrote: > >

Re: Review Request 53059: Druid sql rewriter changes

2016-10-26 Thread Rajitha R
://reviews.apache.org/r/53059/diff/ Testing --- Thanks, Rajitha R

Re: Review Request 53059: Druid sql rewriter changes

2016-10-26 Thread Rajitha R
-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDruidSQLRewriter.java c4cc91d lens-driver-jdbc/src/test/resources/drivers/jdbc/druid/jdbcdriver-site.xml e4fad23 Diff: https://reviews.apache.org/r/53059/diff/ Testing --- Thanks, Rajitha R

Review Request 57908: Xsd for virtual fact

2017-03-24 Thread Rajitha R
--- Xsd for virtual fact Diffs - lens-api/src/main/resources/cube-0.1.xsd 060eb43 Diff: https://reviews.apache.org/r/57908/diff/1/ Testing --- Thanks, Rajitha R

Re: Review Request 57908: Xsd for virtual fact

2017-03-24 Thread Rajitha R
Khandelwal. Repository: lens Description --- Xsd for virtual fact Diffs (updated) - lens-api/src/main/resources/cube-0.1.xsd 060eb43 Diff: https://reviews.apache.org/r/57908/diff/2/ Changes: https://reviews.apache.org/r/57908/diff/1-2/ Testing --- Thanks, Rajitha R

Re: Review Request 57908: Xsd for virtual fact

2017-03-28 Thread Rajitha R
/ Changes: https://reviews.apache.org/r/57908/diff/4-5/ Testing --- Thanks, Rajitha R

Re: Review Request 57908: Xsd for virtual fact

2017-03-28 Thread Rajitha R
omatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57908/#review170154 ------- On March 28, 2017, 7:22 a.m., Rajitha R wrote: > > --- > This is an automatically gener

Re: Review Request 57908: Xsd for virtual fact

2017-03-27 Thread Rajitha R
Khandelwal. Repository: lens Description --- Xsd for virtual fact Diffs (updated) - lens-api/src/main/resources/cube-0.1.xsd 060eb43 Diff: https://reviews.apache.org/r/57908/diff/3/ Changes: https://reviews.apache.org/r/57908/diff/2-3/ Testing --- Thanks, Rajitha R

Re: Review Request 57908: Xsd for virtual fact

2017-03-27 Thread Rajitha R
/57908/diff/4/ Changes: https://reviews.apache.org/r/57908/diff/3-4/ Testing --- Thanks, Rajitha R

Re: Review Request 57908: Xsd for virtual fact

2017-03-27 Thread Rajitha R
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57908/#review170154 ------- On March 27, 2017, 9:55 a.m., Rajitha R wrote: > > -

Re: Review Request 57908: Xsd for virtual fact

2017-03-31 Thread Rajitha R
/diff/6/ Changes: https://reviews.apache.org/r/57908/diff/5-6/ Testing --- Thanks, Rajitha R

Re: Review Request 57908: Xsd for virtual fact

2017-04-10 Thread Rajitha R
an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57908/#review170530 ----------- On March 31, 2017, 1:20 p.m., Rajitha R wrote: > > --- > T

Re: Review Request 57366: Fix in Union query writer

2017-03-14 Thread Rajitha R
LENS-1402 - Rajitha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57366/#review168113 --- On March 7, 2017, 10:01 a.m., Rajith

Re: Review Request 57366: Fix in Union query writer

2017-03-07 Thread Rajitha R
/UnionQueryWriter.java 4f1f808 Diff: https://reviews.apache.org/r/57366/diff/1/ Testing --- Thanks, Rajitha R

Review Request 57366: Fix in Union query writer

2017-03-07 Thread Rajitha R
) - Fix in Union query writer Repository: lens Description (updated) --- The Unionquerywriter has a bug where it defaults the measure values to zero if the definition of the measure has dimensions involved. This is a fix for the same. Testing --- Thanks, Rajitha R

Re: Review Request 60461: Virtual fact minor fixes [LENS-1440, LENS-1446, LENS-1447]

2017-06-27 Thread Rajitha R
, Rajitha R

Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test cases [Lens-1412]

2017-04-28 Thread Rajitha R
] Thanks, Rajitha R

Review Request 61450: Fix for filters getting repeated in jdbc query - LENS-1450

2017-08-07 Thread Rajitha R
--- Thanks, Rajitha R

Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test cases [Lens-1412]

2017-05-15 Thread Rajitha R
; We need to persist sourceFactName as well. done - Rajitha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/#review174282 ------- On M

Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test cases [Lens-1412]

2017-05-15 Thread Rajitha R
] Thanks, Rajitha R

Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]

2017-05-17 Thread Rajitha R
(patched) > > <https://reviews.apache.org/r/58796/diff/6/?file=1720878#file1720878line186> > > > > returning all facts? Instead should we say not implemented done - Rajitha --- This

Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]

2017-05-17 Thread Rajitha R
.. SUCCESS [0.360s] [INFO] Lens Python Client SUCCESS [0.366s] [INFO] Thanks, Rajitha R

Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test cases [Lens-1412]

2017-05-15 Thread Rajitha R
; <https://reviews.apache.org/r/58796/diff/3/?file=1709969#file1709969line725> > > > > Why are we doing this copy of properties? removed - Rajitha --- This is an automatically generated e-

Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test cases [Lens-1412]

2017-05-16 Thread Rajitha R
] Thanks, Rajitha R

Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test cases [Lens-1412]

2017-05-16 Thread Rajitha R
; > > > should we optimize this and reduce if checks ? done - Rajitha ----------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/#review175056 --

Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test cases [Lens-1412]

2017-05-16 Thread Rajitha R
] Thanks, Rajitha R

Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]

2017-05-22 Thread Rajitha R
] [INFO] Lens Contributed Clients .. SUCCESS [0.360s] [INFO] Lens Python Client SUCCESS [0.366s] [INFO] Thanks, Rajitha R

Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]

2017-06-02 Thread Rajitha R
] Lens Python Client SUCCESS [0.366s] [INFO] Thanks, Rajitha R

Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]

2017-06-02 Thread Rajitha R
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/#review175056 ----------- On June 2, 2017, 9:41 a.m., Rajitha R wrote: > >

Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]

2017-06-02 Thread Rajitha R
SUCCESS [0.366s] [INFO] Thanks, Rajitha R

Re: Review Request 58796: CRUD and Query rewrite changes for Virtual Fact and Unit test cases [Lens-1412]

2017-06-02 Thread Rajitha R
ps://reviews.apache.org/r/58796/#review176051 --- On June 2, 2017, 9:41 a.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https

Review Request 59915: Fix for Lens-1433

2017-06-08 Thread Rajitha R
--- Correcting the storage fact name for virtual fact Diffs - lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java c8ff3b8 Diff: https://reviews.apache.org/r/59915/diff/1/ Testing --- Thanks, Rajitha R

Review Request 60115: Unit test cases for Virtual fact

2017-06-15 Thread Rajitha R
/testfact8_base.xml PRE-CREATION lens-cube/src/test/resources/schema/facts/testfact9_base.xml PRE-CREATION lens-cube/src/test/resources/schema/facts/virtual/virtualfact.xml 860965f Diff: https://reviews.apache.org/r/60115/diff/1/ Testing --- Thanks, Rajitha R

Re: Review Request 60115: Unit test cases for Virtual fact [LENS-1437]

2017-06-15 Thread Rajitha R
860965f Diff: https://reviews.apache.org/r/60115/diff/1/ Testing --- Thanks, Rajitha R

Re: Review Request 60115: Unit test cases for Virtual fact [LENS-1437] and fix in virtual fact update command [LENS-1440]

2017-06-15 Thread Rajitha R
/60115/diff/1-2/ Testing --- Thanks, Rajitha R

Re: Review Request 60115: Unit test cases for Virtual fact [LENS-1437] and fix in virtual fact update command [LENS-1440]

2017-06-16 Thread Rajitha R
/facts/testfact8_base.xml PRE-CREATION lens-cube/src/test/resources/schema/facts/testfact9_base.xml PRE-CREATION lens-cube/src/test/resources/schema/facts/virtual/virtualfact.xml 860965f Diff: https://reviews.apache.org/r/60115/diff/2/ Testing --- Thanks, Rajitha R

Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test cases [Lens-1412]

2017-05-08 Thread Rajitha R
] Thanks, Rajitha R

Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test cases [Lens-1412]

2017-05-08 Thread Rajitha R
ps://reviews.apache.org/r/58796/#review173559 ------- On May 8, 2017, 6:08 a.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail.

Review Request 60461: Virtual fact minor fixes [LENS-1440, LENS-1446, LENS-1447]

2017-06-27 Thread Rajitha R
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java c6ef6d2 Diff: https://reviews.apache.org/r/60461/diff/1/ Testing --- Thanks, Rajitha R

Review Request 62773: Fix for column start times not working in Virtual facts [LENS-1480]

2017-10-04 Thread Rajitha R
--- Fix for column start times not working in Virtual facts Diffs - lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java fd07bf2 Diff: https://reviews.apache.org/r/62773/diff/1/ Testing --- Thanks, Rajitha R

Re: Review Request 62773: Fix for column start and end times not working in Virtual facts [LENS-1480]

2017-10-11 Thread Rajitha R
://reviews.apache.org/r/62773/diff/4/ Changes: https://reviews.apache.org/r/62773/diff/3-4/ Testing --- Thanks, Rajitha R

Review Request 62120: LENS-1473 : Cubevirtualfact table relative start time has incorrect config field name

2017-09-06 Thread Rajitha R
--- Cubevirtualfact table relative start time has incorrect config field name Diffs - lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java ce2a1a6 Diff: https://reviews.apache.org/r/62120/diff/1/ Testing --- Thanks, Rajitha R

Review Request 62201: LENS-1474 : Null pointer in Segmentation rewrite

2017-09-08 Thread Rajitha R
--- Null pointer in Segmentation rewrite Diffs - lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 1268ef7 Diff: https://reviews.apache.org/r/62201/diff/1/ Testing --- Thanks, Rajitha R

Review Request 61812: Valid columns addition in virtual fact [LENS-1463]

2017-08-22 Thread Rajitha R
/base/testcube2.xml 9740e00 lens-cube/src/test/resources/schema/facts/testfact9_base.xml 56e5746 lens-cube/src/test/resources/schema/facts/virtual/virtualfact.xml 13f6773 Diff: https://reviews.apache.org/r/61812/diff/1/ Testing --- Thanks, Rajitha R

Re: Review Request 61938: Fix for time_range_in clause not resolving in rewrite

2017-08-30 Thread Rajitha R
e of look ahead partitions being available - Rajitha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61938/#review184022 ---------

Re: Review Request 61938: Fix for time_range_in clause not resolving in rewrite

2017-08-30 Thread Rajitha R
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61938/#review184040 ----------- On Aug. 28, 2017, 11:38 a.m., Rajitha R wrote: > >

Re: Review Request 61938: Fix for time_range_in clause not resolving in rewrite

2017-08-30 Thread Rajitha R
/summary5.xml PRE-CREATION lens-cube/src/test/resources/schema/storages/c98.xml PRE-CREATION Diff: https://reviews.apache.org/r/61938/diff/2/ Changes: https://reviews.apache.org/r/61938/diff/1-2/ Testing --- Thanks, Rajitha R

Re: Review Request 61938: Fix for time_range_in clause not resolving in rewrite

2017-08-31 Thread Rajitha R
ld make sure participatingUpdatePeriods does not have any update > > period that has zero partitions. Should line 536 " > > this.participatingUpdatePeriods.add(maxInterval);" be deleted ? > > Rajitha R wrote: > I tried do to this but test cases started

Re: Review Request 61938: Fix for time_range_in clause not resolving in rewrite

2017-08-31 Thread Rajitha R
/summary5.xml PRE-CREATION lens-cube/src/test/resources/schema/storages/c98.xml PRE-CREATION Diff: https://reviews.apache.org/r/61938/diff/3/ Changes: https://reviews.apache.org/r/61938/diff/2-3/ Testing --- Thanks, Rajitha R

Re: Review Request 63665: Implementation for Jdbc driver cost

2017-11-14 Thread Rajitha R
eb56927 Diff: https://reviews.apache.org/r/63665/diff/11/ Changes: https://reviews.apache.org/r/63665/diff/10-11/ Testing --- Thanks, Rajitha R

Review Request 64744: Checkstyle error fix [LENS-1495]

2017-12-20 Thread Rajitha R
--- Thanks, Rajitha R

Re: Review Request 63665: Implementation for Jdbc driver cost

2017-11-14 Thread Rajitha R
-config.apt eb56927 Diff: https://reviews.apache.org/r/63665/diff/7/ Changes: https://reviews.apache.org/r/63665/diff/6-7/ Testing --- Thanks, Rajitha R

Re: Review Request 63665: Implementation for Jdbc driver cost

2017-11-13 Thread Rajitha R
/jdbcdriver-config.apt eb56927 Diff: https://reviews.apache.org/r/63665/diff/4/ Changes: https://reviews.apache.org/r/63665/diff/3-4/ Testing --- Thanks, Rajitha R

Re: Review Request 63665: Implementation for Jdbc driver cost

2017-11-13 Thread Rajitha R
/org/apache/lens/server/api/query/cost/TestFactPartitionBasedQueryCost.java e047c91 src/site/apt/admin/jdbcdriver-config.apt eb56927 Diff: https://reviews.apache.org/r/63665/diff/3/ Changes: https://reviews.apache.org/r/63665/diff/2-3/ Testing --- Thanks, Rajitha R

Re: Review Request 63665: Implementation for Jdbc driver cost

2017-11-15 Thread Rajitha R
/63665/diff/12/ Changes: https://reviews.apache.org/r/63665/diff/11-12/ Testing --- Thanks, Rajitha R

Re: Review Request 63665: Implementation for Jdbc driver cost

2017-11-15 Thread Rajitha R
/63665/diff/13/ Changes: https://reviews.apache.org/r/63665/diff/12-13/ Testing --- Thanks, Rajitha R

Review Request 63665: Implementation for Jdbc driver cost

2017-11-08 Thread Rajitha R
/StaticQueryCost.java PRE-CREATION lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/TestFactPartitionBasedQueryCost.java e047c91 src/site/apt/admin/jdbcdriver-config.apt eb56927 Diff: https://reviews.apache.org/r/63665/diff/1/ Testing --- Thanks, Rajitha R

Review Request 64443: Fix for TotalQueryCost [LENS-1493]

2017-12-08 Thread Rajitha R
--- Thanks, Rajitha R

Re: Review Request 62773: Fix for column start and end times not working in Virtual facts [LENS-1480]

2017-12-11 Thread Rajitha R
://reviews.apache.org/r/62773/diff/6/ Changes: https://reviews.apache.org/r/62773/diff/5-6/ Testing --- Thanks, Rajitha R

Re: Review Request 64443: Fix for TotalQueryCost [LENS-1493]

2017-12-12 Thread Rajitha R
://reviews.apache.org/r/64443/diff/2/ Changes: https://reviews.apache.org/r/64443/diff/1-2/ Testing --- Thanks, Rajitha R

Review Request 64767: Look ahead time partitions made configurable [LENS-1496]

2017-12-21 Thread Rajitha R
: https://reviews.apache.org/r/64767/diff/1/ Testing --- Thanks, Rajitha R

Re: Report for May,2018

2018-05-07 Thread rajitha r
+1 On Mon, May 7, 2018 at 10:52 AM, Raghavendra Singh < raghavendra.si...@inmobi.com> wrote: > +1 > > On Mon, May 7, 2018 at 10:46 AM, Raju Bairishetti wrote: > > > +1 > > > > On Mon, May 7, 2018 at 12:45 PM, amareshwarisr > > wrote: > > > > > Hi Lens

Re: Review Request 66549: Lens Server: SPNEGO authentication

2018-05-07 Thread Rajitha R
84366> Since this flow is only valid for Negotiate scheme, can we have the additional check if the scheme is only negotiate? - Rajitha R On May 4, 2018, 12:48 p.m., Barun Kumar wrote: > > --- > This is an automati

Re: Review Request 66549: Lens Server: SPNEGO authentication

2018-05-09 Thread Rajitha R
Lines 56 (patched) <https://reviews.apache.org/r/66549/#comment284737> Can this be made configurable ? - Rajitha R On May 4, 2018, 12:48 p.m., Barun Kumar wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 67316: For SSL enabled lens client must always use trust manager for root X509 cert

2018-05-25 Thread Rajitha R
/LensTrustManager.java Line 45 (original), 45 (patched) <https://reviews.apache.org/r/67316/#comment286193> please revert this here and everwhere else - Rajitha R On May 25, 2018, 9:59 a.m., Ankit Kailaswar wrote: > > --- > This is a

Re: Review Request 67316: For SSL enabled lens client must always use trust manager for root X509 cert

2018-05-25 Thread Rajitha R
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67316/#review203881 --- Ship it! Ship It! - Rajitha R On May 25, 2018, 10:56 a.m

Re: Review Request 67323: SSL changes to ignore cert for python module

2018-05-25 Thread Rajitha R
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67323/#review203880 --- Ship it! Ship It! - Rajitha R On May 25, 2018, 2:26 p.m

Re: Review Request 67323: SSL changes to ignore cert for python module

2018-05-25 Thread Rajitha R
ients/python/lens/client/log.py Lines 31 (patched) <https://reviews.apache.org/r/67323/#comment286230> Don't if and else have same implementation here? - Rajitha R On May 25, 2018, 1:55 p.m., Ank

Re: Review Request 67214: enable SSL/TLS for lens server and client communication

2018-05-24 Thread Rajitha R
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67214/#review203781 --- Ship it! Ship It! - Rajitha R On May 24, 2018, 2:59 p.m

Re: Review Request 67214: git diff origin/master master >> Lens-150

2018-05-18 Thread Rajitha R
server/src/test/resources/lens-site.xml Lines 230 (patched) <https://reviews.apache.org/r/67214/#comment285607> This might have to be set to something under /tmp like other configs - Rajitha R On May 18, 201

Re: Review Request 66549: Lens Server: SPNEGO authentication

2018-05-18 Thread Rajitha R
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66549/#review203419 --- Ship it! Ship It! - Rajitha R On May 18, 2018, 8:58 a.m

Re: Review Request 67214: git diff origin/master master >> Lens-150

2018-05-21 Thread Rajitha R
n/resources/lensserver-default.xml Lines 989 (patched) <https://reviews.apache.org/r/67214/#comment285734> this has to still be /tmp which is the default install dir. /usr/local is very specific to Inmobi. - Rajitha R On May 21, 2018, 4:46

Re: Review Request 67523: Result download url to be made configurable

2018-06-11 Thread Rajitha R
4d141e5 src/site/apt/user/cli.apt 12bc88c src/site/apt/user/client-config.apt 4f0b2b4 Diff: https://reviews.apache.org/r/67523/diff/6/ Changes: https://reviews.apache.org/r/67523/diff/5-6/ Testing --- Thanks, Rajitha R

Re: Review Request 64779: NPE fix in closing idle connections [LENS-1497]

2018-01-11 Thread Rajitha R
/server/session/HiveSessionService.java a9fd233 Diff: https://reviews.apache.org/r/64779/diff/4/ Changes: https://reviews.apache.org/r/64779/diff/3-4/ Testing --- Thanks, Rajitha R

Re: Review Request 64779: NPE fix in closing idle connections [LENS-1497]

2018-01-19 Thread Rajitha R
/server/session/HiveSessionService.java a9fd233 Diff: https://reviews.apache.org/r/64779/diff/5/ Changes: https://reviews.apache.org/r/64779/diff/4-5/ Testing --- Thanks, Rajitha R

Re: [VOTE] Release of Apache Lens 2.7.1

2018-01-25 Thread rajitha r
+1 On Wed, Jan 24, 2018 at 12:33 PM, Raju Bairishetti wrote: > Hi everyone, > > I propose the following RC to be released as official Apache Lens 2.7.1 > release. > > The commit id is 865d20267e8128134bb981f1db9dab9108661061: >

Review Request 65430: Virtual fact start and end time property fix

2018-01-30 Thread Rajitha R
PRE-CREATION Diff: https://reviews.apache.org/r/65430/diff/1/ Testing --- Thanks, Rajitha R

Re: [VOTE] Release of Apache Lens 2.7.1

2018-01-31 Thread rajitha r
+1 The code builds successfully and the test cases run as well. On Thu, Jan 25, 2018 at 4:04 PM, rajitha r <rajitha@gmail.com> wrote: > +1 > > On Wed, Jan 24, 2018 at 12:33 PM, Raju Bairishetti <r...@apache.org> > wrote: > >> Hi everyone, >> >>

Re: Report for Feb, 2018

2018-02-09 Thread rajitha r
+1 On 09-Feb-2018 7:30 PM, "Raju Bairishetti" wrote: > +1 > > On Fri, Feb 9, 2018 at 9:37 PM, Raghavendra Singh < > raghavendra.si...@inmobi.com> wrote: > > > +1 > > > > On Fri, Feb 9, 2018 at 6:55 PM, Puneet Gupta > > wrote: > > > > > +1 > > > > > > On

Re: Review Request 64779: NPE fix in closing idle connections [LENS-1497]

2017-12-28 Thread Rajitha R
94536 ----------- On Dec. 21, 2017, 3:40 p.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64779/ >

Review Request 64779: NPE fix in closing idle connections [LENS-1497]

2017-12-21 Thread Rajitha R
://issues.apache.org/jira/browse/LENS-1497 Repository: lens Description --- NPE fix in closing idle connections Diffs - lens-server/src/main/java/org/apache/lens/server/BaseLensService.java d7ce434 Diff: https://reviews.apache.org/r/64779/diff/1/ Testing --- Thanks, Rajitha R

Re: Review Request 68267: Lens api to display number of sessions created per user

2018-08-09 Thread Rajitha R
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68267/#review207013 --- Ship it! Ship It! - Rajitha R On Aug. 8, 2018, 3 p.m

Re: Report for August, 2018

2018-08-07 Thread rajitha r
+1 On Tue, Aug 7, 2018 at 10:46 AM Amareshwari Sriramdasu < amareshw...@apache.org> wrote: > Hi, > > Have put up draft for August,2018 report > https://cwiki.apache.org/confluence/display/LENS/August%2C+2018. > > Please review and let me know your comments. > > Thanks > Amareshwari > --

Re: Review Request 68315: Start and end time for Cubes

2018-08-13 Thread Rajitha R
] [INFO] Total time: 45:00 min [INFO] Finished at: 2018-08-13T13:12:18+05:30 [INFO] Final Memory: 261M/1420M [INFO] Thanks, Rajitha R

  1   2   3   4   5   >