Re: [VOTE] Move Apache Lens and to attic

+1 (binding) to move the project to attic On Sat, 18 Jul, 2020, 10:39 am Jean-Baptiste Onofre, wrote: > +1 to move to attic > > Regards > JB > > > Le 17 juil. 2020 à 10:41, Amareshwari Sriramdasu > a écrit : > > > > Hi Lens dev and PMC, > > > > As we are seeing no roadmap ahead and no

Re: Report for Feb, 2020

+1 . No comments On Wed, 12 Feb, 2020, 10:35 am Amareshwari Sriramdasu, < amareshw...@apache.org> wrote: > Hi Lens Dev, > > Have updated report for Feb month here - > https://cwiki.apache.org/confluence/display/LENS/February%2C+2020. Please > share your comments. > > Thanks >

[jira] [Commented] (LENS-1009) Queries with large sql are not getting purged

[ https://issues.apache.org/jira/browse/LENS-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017727#comment-17017727 ] Puneet Gupta commented on LENS-1009: Don't think this has been fixed. Use the workaround mentioned

Re: Report for November, 2019

+1 . No comments from my side. On Tue, Nov 12, 2019 at 11:21 AM Amareshwari Sriramdasu < amareshw...@apache.org> wrote: > Hi, > > Have put up draft for Nov,2019 report > https://cwiki.apache.org/confluence/display/LENS/November%2C+2019. Please > review and let me know your comments. Shall submit

Re: [VOTE] Break up lens code into two sub projects

+1 from me. On Wed, 28 Aug, 2019, 4:42 PM Amareshwari Sriramdasu, < amareshw...@apache.org> wrote: > +1 from my side. > > On Wed, Aug 28, 2019 at 4:41 PM Amareshwari Sriramdasu < > amareshw...@apache.org> wrote: > > > Hi, > > > > After the discussion on Lens roadmap thread, calling this vote to

Re: Lens RoadMap

Hi Rajsekhar, I have also added some concerns in the doc. The changes proposed seem big. It might be helpful we we can all meet over a call and discuss these. Thanks, Puneet On Wed, Aug 21, 2019 at 5:24 PM amareshwarisr . wrote: > Thanks Rajashekhar for sharing your views. > > I have added

Re: [VOTE] Lens - Code Commit using Pull Requests

+1. On Tue, 22 Jan, 2019, 9:08 AM Amareshwari Sriramdasu Rajitha, > > Can we make sure emails for the new pull requests and the comments on pull > requests come to dev@lens.apache.org as part of this change? > > Thanks > > On Sun, Jan 20, 2019 at 10:29 AM Amareshwari Sriramdasu < >

Re: [DISCUSS] Lens Migration from Git-wip to Gitbox

+1 On Tue, 8 Jan, 2019, 8:38 AM Amareshwari Sriramdasu +1 > > On Mon, Jan 7, 2019 at 10:59 AM Rajitha R wrote: > > > Hi All, > > > > ASF infra has decided to move all git repositories from > > git-wip-us.apache.org URL to gitbox.apache.org with the former service > > being decommisioned. > > >

Re: Report for November, 2018

+1. Looks good to me . On Wed, Nov 7, 2018 at 8:02 PM Amareshwari Sriramdasu < amareshw...@apache.org> wrote: > Hi, > > Have updated draft report for November,2018 at > https://cwiki.apache.org/confluence/display/LENS/November%2C2018. Please > review and let me know your comments. > > Thanks >

Re: Review Request 67523: Result download url to be made configurable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67523/#review204544 --- Ship it! Ship It! - Puneet Gupta On June 11, 2018, 3:43 p.m

Re: Review Request 67523: Result download url to be made configurable

nes 26 (patched) <https://reviews.apache.org/r/67523/#comment287096> Should we rename this to DownloadResultUrlProvider ? - Puneet Gupta On June 11, 2018, 9:41 a.m., Rajitha R wrote: > > --- > This is an automatically gener

Re: Review Request 67214: git diff origin/master master >> Lens-150

g/r/67214/#comment285737> Should this not come from trustManager.getAcceptedIssuers() ? lens-server/src/main/resources/lensserver-default.xml Lines 984 (patched) <https://reviews.apache.org/r/67214/#comment285738> incomplete description. Please update - Puneet Gupta On May

Re: Review Request 66549: Lens Server: SPNEGO authentication

nFilter.java Lines 226 (patched) <https://reviews.apache.org/r/66549/#comment284736> can be private ? - Puneet Gupta On May 4, 2018, 12:48 p.m., Barun Kumar wrote: > > --- > This is an automatically generated

Re: Report for May,2018

+1 On Mon, May 7, 2018 at 12:02 PM, rajitha r wrote: > +1 > > On Mon, May 7, 2018 at 10:52 AM, Raghavendra Singh < > raghavendra.si...@inmobi.com> wrote: > > > +1 > > > > On Mon, May 7, 2018 at 10:46 AM, Raju Bairishetti > wrote: > > > > > +1 > > > > > >

Re: Review Request 66505: Hadoop version upgrade

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66505/#review200986 --- Ship it! Ship It! - Puneet Gupta On April 9, 2018, 10:06

[jira] [Updated] (LENS-1506) Kerberos authentication in lens

[ https://issues.apache.org/jira/browse/LENS-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1506: --- Fix Version/s: 2.8 > Kerberos authentication in l

[jira] [Commented] (LENS-1506) Kerberos authentication in lens

[ https://issues.apache.org/jira/browse/LENS-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426805#comment-16426805 ] Puneet Gupta commented on LENS-1506: Committed. Thanks [~ankitkailaswar] > Kerberos authenticat

Re: Review Request 66081: Kerberos authentication in lens

apache/lens/server/LensServices.java Lines 304 (patched) <https://reviews.apache.org/r/66081/#comment281273> Should we catch Exception instead in this case ? - Puneet Gupta On April 5, 2018, 5:41 a.m., Ankit Kailaswar wrote: > >

Re: Review Request 66081: Kerberos authentication in lens

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66081/#review200353 --- Ship it! Ship It! - Puneet Gupta On April 3, 2018, 8:14 a.m

[jira] [Commented] (LENS-1506) Kerberos authentication in lens

[ https://issues.apache.org/jira/browse/LENS-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400337#comment-16400337 ] Puneet Gupta commented on LENS-1506: [~ankitkailaswar] This review request covers all the changes 1- 4

Re: Report for Feb, 2018

+1 On Fri, Feb 9, 2018 at 5:41 PM, Amareshwari Sriramdasu < amareshw...@apache.org> wrote: > Hi, > > Have put the report for Feb,2018 here - > https://cwiki.apache.org/confluence/display/LENS/Feb%2C2018 > > Please review and let me know your comments. > > Thanks >

[ANNOUNCE] New Apache Lens committer : Rajitha R

The PMC for Apache Lens has asked Rajitha to become Lens Committer. We are pleased to announce that she has accepted. Being a committer enables access to commit to the source repositories and binding votes for code reviews. Join me in Congratulating Rajitha! Congratulations Rajitha! Looking

Re: [ANNOUNCE] Apache Lens 2.7.1 released

Thanks Raju. Lot of hard work has gone in making this release possible. Really appreciate your contribution. On Tue, Feb 6, 2018 at 11:55 AM, Amareshwari Sriramdasu < amareshw...@apache.org> wrote: > Great work Raju! > > Your perseverance made this release possible. Thank you so much for >

Re: [VOTE] Release of Apache Lens 2.7.1

+1 from my side 1. Was able to download the source code and binary 2. Was able to open the nexus url and verify some jars 3. Was able to start the lens server and run examples 4. Was able to compile the source code On Wed, Jan 31, 2018 at 1:53 PM, rajitha r

[jira] [Commented] (LENS-1497) NPE while closing idle connections

[ https://issues.apache.org/jira/browse/LENS-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335458#comment-16335458 ] Puneet Gupta commented on LENS-1497: Committed. Thanks [~rajitha.r] > NPE while closing i

[jira] [Updated] (LENS-1497) NPE while closing idle connections

[ https://issues.apache.org/jira/browse/LENS-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1497: --- Fix Version/s: 2.8 > NPE while closing idle connecti

[jira] [Updated] (LENS-1497) NPE while closing idle connections

[ https://issues.apache.org/jira/browse/LENS-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1497: --- Resolution: Fixed Status: Resolved (was: Patch Available) > NPE while closing i

[jira] [Updated] (LENS-1500) Test cases failing in master

[ https://issues.apache.org/jira/browse/LENS-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1500: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Test cases failing in mas

[jira] [Updated] (LENS-1500) Test cases failing in master

[ https://issues.apache.org/jira/browse/LENS-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1500: --- Fix Version/s: 2.8 > Test cases failing in mas

[jira] [Commented] (LENS-1500) Test cases failing in master

[ https://issues.apache.org/jira/browse/LENS-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335453#comment-16335453 ] Puneet Gupta commented on LENS-1500: Committed. Thanks [~rajitha.r] > Test cases failing in mas

Re: Review Request 64779: NPE fix in closing idle connections [LENS-1497]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64779/#review195810 --- Ship it! Ship It! - Puneet Gupta On Jan. 19, 2018, 10:07

Re: Review Request 64779: NPE fix in closing idle connections [LENS-1497]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64779/#review195712 --- Ship it! Ship It! - Puneet Gupta On Jan. 11, 2018, 3:07 p.m

Re: Review Request 64779: NPE fix in closing idle connections [LENS-1497]

/BaseLensService.java Lines 355 (patched) <https://reviews.apache.org/r/64779/#comment274990> Can we also log the session Handle - Puneet Gupta On Jan. 11, 2018, 3:07 p.m., Rajitha R wrote: > > --- > This is an automatically g

Re: Review Request 64779: NPE fix in closing idle connections [LENS-1497]

ain/java/org/apache/lens/server/BaseLensService.java Lines 350 (patched) <https://reviews.apache.org/r/64779/#comment274120> This should not be required now since we are adding missing users to this map on restoreSession. - Puneet Gupta On Dec. 21, 2017, 3:40 p.m

Re: Review Request 64779: NPE fix in closing idle connections [LENS-1497]

g/r/64779/#comment273360> Is this inconsistnecy coming due to a restart ? Can we handle this on restart itself in that case when session service boots up - Puneet Gupta On Dec. 21, 2017, 3:40 p.m., Raj

[jira] [Commented] (LENS-1495) Lens commit build failure due to checkstyle error

[ https://issues.apache.org/jira/browse/LENS-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299889#comment-16299889 ] Puneet Gupta commented on LENS-1495: Committed. Thanks [~rajitha.r] > Lens commit build failure

[jira] [Updated] (LENS-1495) Lens commit build failure due to checkstyle error

[ https://issues.apache.org/jira/browse/LENS-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1495: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Lens commit build failure

[jira] [Updated] (LENS-1495) Lens commit build failure due to checkstyle error

[ https://issues.apache.org/jira/browse/LENS-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1495: --- Fix Version/s: 2.8 > Lens commit build failure due to checkstyle er

Re: Review Request 64744: Checkstyle error fix [LENS-1495]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64744/#review194233 --- Ship it! Ship It! - Puneet Gupta On Dec. 20, 2017, 9:01 a.m

[jira] [Commented] (LENS-1493) TotalQueryCost logic broken

[ https://issues.apache.org/jira/browse/LENS-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296652#comment-16296652 ] Puneet Gupta commented on LENS-1493: Committed. Thanks [~rajitha.r] > TotalQueryCost logic bro

[jira] [Updated] (LENS-1493) TotalQueryCost logic broken

[ https://issues.apache.org/jira/browse/LENS-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1493: --- Resolution: Fixed Status: Resolved (was: Patch Available) > TotalQueryCost logic bro

[jira] [Updated] (LENS-1493) TotalQueryCost logic broken

[ https://issues.apache.org/jira/browse/LENS-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1493: --- Fix Version/s: 2.8 > TotalQueryCost logic bro

[jira] [Updated] (LENS-1480) For virtual facts, column start and end times are not working

[ https://issues.apache.org/jira/browse/LENS-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1480: --- Resolution: Fixed Status: Resolved (was: Patch Available) > For virtual facts, column st

[jira] [Updated] (LENS-1480) For virtual facts, column start and end times are not working

[ https://issues.apache.org/jira/browse/LENS-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1480: --- Fix Version/s: 2.8 > For virtual facts, column start and end times are not work

[jira] [Commented] (LENS-1480) For virtual facts, column start and end times are not working

[ https://issues.apache.org/jira/browse/LENS-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296640#comment-16296640 ] Puneet Gupta commented on LENS-1480: Committed. Thanks [~rajitha.r] > For virtual facts, column st

Re: Review Request 64443: Fix for TotalQueryCost [LENS-1493]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64443/#review193651 --- Ship it! Ship It! - Puneet Gupta On Dec. 12, 2017, 12:45

Re: [VOTE] Release of Apache Lens 2.7.0

This should fix it. https://issues.apache.org/jira/browse/LENS-1472 On Tue, Dec 5, 2017 at 3:40 PM, Puneet Gupta <puneet.k.gu...@gmail.com> wrote: > Was able to > - download lens server binary > - validate the md5 hash > - run lens server and lens cli > > *Facing issu

Re: [VOTE] Release of Apache Lens 2.7.0

Was able to - download lens server binary - validate the md5 hash - run lens server and lens cli *Facing issue while running examples "Successful queries 89 out of 151queries"* Query:cube select measure2 from sample_cube where time_range_in(dt, '2014-06-24-23', '2014-06-25-00') 05 Dec 2017

[jira] [Commented] (LENS-1486) Disable test case testQueryAliveOnSessionClose

[ https://issues.apache.org/jira/browse/LENS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260496#comment-16260496 ] Puneet Gupta commented on LENS-1486: +1 > Disable test case testQueryAliveOnSessionCl

[jira] [Updated] (LENS-1484) Lens Server pre commit build failing due to enunciate plugin

[ https://issues.apache.org/jira/browse/LENS-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1484: --- Attachment: LENS-1484.patch Simple patch. Uploading directly > Lens Server pre commit build fail

[jira] [Updated] (LENS-1484) Lens Server pre commit build failing due to enunciate plugin

[ https://issues.apache.org/jira/browse/LENS-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1484: --- Status: Patch Available (was: Open) > Lens Server pre commit build failing due to enunciate plu

[jira] [Assigned] (LENS-1484) Lens Server pre commit build failing due to enunciate plugin

[ https://issues.apache.org/jira/browse/LENS-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta reassigned LENS-1484: -- Assignee: Puneet Gupta > Lens Server pre commit build failing due to enunciate plu

[jira] [Created] (LENS-1484) Lens Server pre commit build failing due to enunciate plugin

Puneet Gupta created LENS-1484: -- Summary: Lens Server pre commit build failing due to enunciate plugin Key: LENS-1484 URL: https://issues.apache.org/jira/browse/LENS-1484 Project: Apache Lens

Re: Review Request 63665: Implementation for Jdbc driver cost

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63665/#review191056 --- Ship it! Ship It! - Puneet Gupta On Nov. 15, 2017, 10:32

Re: Review Request 63665: Implementation for Jdbc driver cost

es 288 (patched) <https://reviews.apache.org/r/63665/#comment268638> update description lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml Lines 293 (patched) <https://reviews.apache.org/r/63665/#comment268636> can we have it same as default in code - Pu

Re: Review Request 63665: Implementation for Jdbc driver cost

y/cost/FactPartitionBasedQueryCostCalculator.java Lines 38 (patched) <https://reviews.apache.org/r/63665/#comment268631> Do we need to persist query cost at class level ? - Puneet Gupta On Nov. 15, 2017, 7:38 a.m., Raj

Re: Review Request 63665: Implementation for Jdbc driver cost

er.java Lines 29 (patched) <https://reviews.apache.org/r/63665/#comment268497> update comments - Puneet Gupta On Nov. 14, 2017, 6:25 a.m., Rajitha R wrote: > > --- > This is an automati

Re: Review Request 62773: Fix for column start and end times not working in Virtual facts [LENS-1480]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62773/#review190687 --- Ship it! Ship It! - Puneet Gupta On Nov. 10, 2017, 8:44 a.m

Re: Report for November,2017

+1 On Wed, Nov 8, 2017 at 5:27 PM, Amareshwari Sriramdasu < amareshw...@apache.org> wrote: > Hi, > > Have put November, 2017 report here - > https://cwiki.apache.org/confluence/display/LENS/November%2C2017. > > Please review and let me know your comments. > > Thanks > Amareshwari >

Re: Review Request 63665: Implementation for Jdbc driver cost

lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/StaticQueryCost.java Lines 60 (patched) <https://reviews.apache.org/r/63665/#comment268251> Can we have all common methods in a base abstract class AbstractQueryCost for StaticQueryCost and FactPartitionBasedQuery

[jira] [Commented] (LENS-1425) Update 2.7 release documentation

[ https://issues.apache.org/jira/browse/LENS-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235261#comment-16235261 ] Puneet Gupta commented on LENS-1425: Under the incompatibility section , we can remove these LENS-968

Re: Review Request 61881: Lens-1461:Lens services state are not persisted correctly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61881/#review189401 --- Ship it! Ship It! - Puneet Gupta On Oct. 26, 2017, 3:28 p.m

Re: Review Request 61881: Lens-1461:Lens services state are not persisted correctly

/HiveSessionService.java Lines 424 (patched) <https://reviews.apache.org/r/61881/#comment266306> This is not required. sessions List size should be enough . - Puneet Gupta On Oct. 26, 2017, 8:23 a.m., Ankit Kailaswar

Re: Review Request 61881: Lens-1461:Lens services state are not persisted correctly

- > > (Updated Oct. 17, 2017, 12:07 p.m.) > > > Review request for lens and Puneet Gupta. > > > Bugs: LENS-1461 > https://issues.apache.org/jira/browse/LENS-1461 > > > Repository: lens > > > Description > --- > > Persist pro

Re: Review Request 62773: Fix for column start and end times not working in Virtual facts [LENS-1480]

ent264789> Should we use org.apache.lens.cube.metadata.FactTable#isVirtualFact? - Puneet Gupta On Oct. 11, 2017, 10:50 a.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 62773: Fix for column start and end times not working in Virtual facts [LENS-1480]

/StorageCandidate.java Line 332 (original), 338 (patched) <https://reviews.apache.org/r/62773/#comment264531> Can we extraxt this code into a separate method getSourceFactTableProperties(fact) - Puneet Gupta On Oct. 4, 2017, 2:54 p.m., Rajitha R

[jira] [Commented] (LENS-1478) Queries with partial data set as false lookahead not working

[ https://issues.apache.org/jira/browse/LENS-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171303#comment-16171303 ] Puneet Gupta commented on LENS-1478: +1 > Queries with partial data set as false lookahead not work

Re: Review Request 62377: LENS-1477 : Change default measure value to "0" instead of "0.0" in union queries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62377/#review185541 --- Ship it! Ship It! - Puneet Gupta On Sept. 18, 2017, 9:19

[jira] [Commented] (LENS-1476) Order By clause is not rewritten correctly when column is wrapped with function

[ https://issues.apache.org/jira/browse/LENS-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164370#comment-16164370 ] Puneet Gupta commented on LENS-1476: +1 for patch > Order By clause is not rewritten correctly w

Re: Review Request 62218: LENS-1475 : Override equals(Object obj) and hashcode() methods of SegmentationCandidate

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62218/#review185266 --- Ship it! Ship It! - Puneet Gupta On Sept. 11, 2017, 11:50

Re: Review Request 62060: LENS-1471: JoinCandidate's children should not share same storage candidate

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62060/#review184519 --- Ship it! Ship It! - Puneet Gupta On Sept. 4, 2017, 12:50

Re: Review Request 61942: LENS-1467: CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61942/#review184254 --- Ship it! Ship It! - Puneet Gupta On Aug. 30, 2017, 9:41 a.m

Re: Review Request 61942: LENS-1467: CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61942/#review184253 --- Ship it! Ship It! - Puneet Gupta On Aug. 30, 2017, 9:41 a.m

Re: Review Request 61938: Fix for time_range_in clause not resolving in rewrite

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61938/#review184250 --- Ship it! Ship It! - Puneet Gupta On Aug. 31, 2017, 7:27 a.m

Re: Review Request 61938: Fix for time_range_in clause not resolving in rewrite

> On Aug. 29, 2017, 10:26 a.m., Puneet Gupta wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > > Lines 937 (patched) > > <https://reviews.apache.org/r/61938/diff/1/?file=1806054#file1806054line937> > > > > We shou

Re: Review Request 61938: Fix for time_range_in clause not resolving in rewrite

/StorageCandidate.java Lines 937 (patched) <https://reviews.apache.org/r/61938/#comment260041> We should make sure participatingUpdatePeriods does not have any update period that has zero partitions. Should line 536 " this.participatingUpdatePeriods.add(maxInterval);" be deleted ? - Punee

Re: Review Request 61881: Lens-1461:Lens services state are not persisted correctly

server/src/main/java/org/apache/lens/server/session/HiveSessionService.java Lines 430 (patched) <https://reviews.apache.org/r/61881/#comment260039> out.writeInt(SESSION_MAP.size()) would be wrong in this case . It should be SESSION_MAP.size()-1. How do we handle this ? - Puneet Gupta

Re: Review Request 61934: LENS-1464: One or two queued queries failing with ConcurrentModificationException on restart

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61934/#review184037 --- Ship it! Ship It! - Puneet Gupta On Aug. 28, 2017, 12:52

Re: Review Request 61934: LENS-1464: One or two queued queries failing with ConcurrentModificationException on restart

/QueryExecutionServiceImpl.java Line 3485 (original), 3485 (patched) <https://reviews.apache.org/r/61934/#comment259976> Should we do this at session level ? - Puneet Gupta On Aug. 28, 2017, 10:34 a.m., Rajat Khandelwal

Re: Review Request 61936: LENS-1465: Sync queries blocking threads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61936/#review183914 --- Ship it! Ship It! - Puneet Gupta On Aug. 28, 2017, 10:46

Re: Review Request 60155: LENS-1441: CandidateTableResolver should not add StorageCandidate if storage is not supported

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60155/#review178196 --- Ship it! Ship It! - Puneet Gupta On June 16, 2017, 3:42 p.m

[jira] [Created] (LENS-1436) Lens Server's previously persisted state should be backed up before creating a new persisted state

Puneet Gupta created LENS-1436: -- Summary: Lens Server's previously persisted state should be backed up before creating a new persisted state Key: LENS-1436 URL: https://issues.apache.org/jira/browse/LENS-1436

Re: Review Request 59836: LENS-1434: Segmentation Candidate should have dynamic cost depending on facts picked in segmented cubes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59836/#review177026 --- Ship it! Ship It! - Puneet Gupta On June 6, 2017, 12:31 p.m

[jira] [Commented] (LENS-1431) Data Availability Feature broken

[ https://issues.apache.org/jira/browse/LENS-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038641#comment-16038641 ] Puneet Gupta commented on LENS-1431: review Request : https://reviews.apache.org/r/59830 > D

Re: Review Request 59830: LENS-1431 Data-availability feature fixes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59830/#review177011 --- Ship it! Ship It! - Puneet Gupta On June 6, 2017, 7:51 a.m

Re: Review Request 59803: LENS-1432 : Map Join tuning broken for this query leading to Map timeouts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59803/#review176998 --- Ship it! Ship It! - Puneet Gupta On June 6, 2017, 6:59 a.m

Re: Review Request 59803: LENS-1432 : Map Join tuning broken for this query leading to Map timeouts

/RewriterPlan.java Line 50 (original), 49 (patched) <https://reviews.apache.org/r/59803/#comment250545> Should we check !ctx.getQueryWriterContext().getDimsToQuery().isEmpty() and ctx.getQueryWriterContext().getDimsToQuery()!=null - Puneet Gupta On June 5, 2017, 2:18 p.m., Sushil Mohanty

Re: Review Request 59714: LENS-1428 : Common measures are getting repeated in UnionQuery for JoinCandidate

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59714/#review176907 --- Ship it! Ship It! - Puneet Gupta On June 5, 2017, 8:51 a.m

[jira] [Commented] (LENS-1429) Queries failing intermittently with NO_REF_COL_AVAILABLE

[ https://issues.apache.org/jira/browse/LENS-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036867#comment-16036867 ] Puneet Gupta commented on LENS-1429: +1 > Queries failing intermittently with NO_REF_COL_AVAILA

Re: Review Request 59714: LENS-1428 : Common measures are getting repeated in UnionQuery for JoinCandidate

t.java Lines 833 (patched) <https://reviews.apache.org/r/59714/#comment250442> Can we leave a comment in code why this is needed. - Puneet Gupta On June 1, 2017, 12:51 p.m., Sushil Mohanty wrote: > > --- > This is an auto

[jira] [Created] (LENS-1426) Support max limit for "timeoutmillis" in EXECUTE_WITH_TIMEOUT option

Puneet Gupta created LENS-1426: -- Summary: Support max limit for "timeoutmillis" in EXECUTE_WITH_TIMEOUT option Key: LENS-1426 URL: https://issues.apache.org/jira/browse/LENS-1426 Project: A

[jira] [Assigned] (LENS-981) Add Memory gatekeepers for InMemoryResultSet to prevent any OOM on lens server

[ https://issues.apache.org/jira/browse/LENS-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta reassigned LENS-981: - Assignee: Lavkesh Lahngir (was: Puneet Gupta) > Add Memory gatekeepers for InMemoryResult

Re: Review Request 59048: Add Memory gatekeepers for InMemoryResultSet to prevent any OOM on lens server

/LensResultSet.java Line 58 (original), 59 (patched) <https://reviews.apache.org/r/59048/#comment248411> OK - Puneet Gupta On May 8, 2017, 12:44 p.m., Lavkesh Lahngir wrote: > > --- > This is an automatically generated e

Re: Report for May,2017

Should we mention Lens-981 (Add Memory gatekeepers for InMemoryResultSet to prevent any OOM on lens server) also ? Other than that +1 . Thanks, Puneet Gupta On Tue, May 16, 2017 at 10:16 AM, amareshwarisr . <amareshw...@gmail.com> wrote: > Hi all, > > Seems I'm left wi

Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test cases [Lens-1412]

he.org/r/58796/#comment248403> should we optimize this and reduce if checks ? - Puneet Gupta On May 15, 2017, 1:38 p.m., Rajitha R wrote: > > --- > This is an automatically gener

Re: Review Request 59048: Add Memory gatekeepers for InMemoryResultSet to prevent any OOM on lens server

s allowed for an InMemory result. This propertly helps in keeping a tab on memory foortprint of lens server. Persistent resultset is suggested for results with size greater than this value." - Puneet Gupta On May 8, 2017, 12:44 p.m., Lavkesh Lahngir wrote: > >

Re: Volunteers for 2.7 release

Thanks Raju :-). On Tue, May 9, 2017 at 1:51 PM, Raju Bairishetti wrote: > Hi, >I can volunteer for managing the release. > > On Mon, May 8, 2017 at 9:18 AM, Amareshwari Sriramdasu < > amareshw...@apache.org> wrote: > > > Hi, > > > > Now that we have major features like

Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test cases [Lens-1412]

/#comment247265> author name needs to be removed . - Puneet Gupta On May 8, 2017, 6:08 a.m., Rajitha R wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 58986: LENS-1418: LensClient is not thread safe

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58986/#review174017 --- Ship it! Ship It! - Puneet Gupta On May 5, 2017, 11:17 a.m

Re: Review Request 58986: LENS-1418: LensClient is not thread safe

this needed ? - Puneet Gupta On May 5, 2017, 8:22 a.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

  1   2   3   4   5   6   7   8   9   10   >