Re: [VOTE] Move Apache Lens and to attic

[Puneet Gupta]

+1 (binding)  to move the project to attic

On Sat, 18 Jul, 2020, 10:39 am Jean-Baptiste Onofre, 
wrote:

> +1 to move to attic
>
> Regards
> JB
>
> > Le 17 juil. 2020 à 10:41, Amareshwari Sriramdasu 
> a écrit :
> >
> > Hi Lens dev and PMC,
> >
> > As we are seeing no roadmap ahead and no interest to keep the project
> > active, as per the discussion on the email thread on dev and user list
> > <
> http://mail-archives.apache.org/mod_mbox/lens-dev/202005.mbox/%3CCANOygOJTAA%3DHxH22E1JOYoqqpUTC-hb9s2seMdHi2i0wR2nvoA%40mail.gmail.com%3E
> >,
> > seeking
> > your vote to terminate the project Apache Lens, dissolve the PMC and move
> > the project to attic. As per the process
> > , it requires a PMC vote on the
> > public dev list, for the same.
> >
> > The vote will remain open till 24th July (leaving it for 1 week to get
> > enough votes). Do vote with your option as one of the below.
> >
> > [+1] To move the project to attic
> > [0] No objection to move to attic.
> > [-1] To NOT move the project to attic.
> >
> > Thanks
> > Amareshwari
>
>

Re: Report for Feb, 2020

[Puneet Gupta]

+1 . No comments

On Wed, 12 Feb, 2020, 10:35 am Amareshwari Sriramdasu, <
amareshw...@apache.org> wrote:

> Hi Lens Dev,
>
> Have updated report for Feb month here -
> https://cwiki.apache.org/confluence/display/LENS/February%2C+2020. Please
> share your comments.
>
> Thanks
>

[jira] [Commented] (LENS-1009) Queries with large sql are not getting purged

[Puneet Gupta (Jira)]

[ 
https://issues.apache.org/jira/browse/LENS-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017727#comment-17017727
 ] 

Puneet Gupta commented on LENS-1009:


Don't think this has been fixed.  Use the workaround mentioned by 
[~amareshwari]  and alter the database table directly. 

> Queries with large sql are not getting purged
> -
>
> Key: LENS-1009
> URL: https://issues.apache.org/jira/browse/LENS-1009
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Priority: Major
>
> Lens creates finished_queries table with column userquery as varchar(1). 
> If a query is larger than that, while purging it throws an exception 
> regarding data truncation. After that, there are retries for purging and it 
> keeps on retrying.  After some time the logs get cluttered since purge 
> failure logs are everywhere. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Report for November, 2019

[Puneet Gupta]

+1 . No comments from my side.

On Tue, Nov 12, 2019 at 11:21 AM Amareshwari Sriramdasu <
amareshw...@apache.org> wrote:

> Hi,
>
> Have put up draft for Nov,2019 report
> https://cwiki.apache.org/confluence/display/LENS/November%2C+2019. Please
> review and let me know your comments. Shall submit to board@ tomorrow.
>
> Thanks
> Amareshwari
>

Re: [VOTE] Break up lens code into two sub projects

[Puneet Gupta]

+1 from me.

On Wed, 28 Aug, 2019, 4:42 PM Amareshwari Sriramdasu, <
amareshw...@apache.org> wrote:

> +1 from my side.
>
> On Wed, Aug 28, 2019 at 4:41 PM Amareshwari Sriramdasu <
> amareshw...@apache.org> wrote:
>
> > Hi,
> >
> > After the discussion on Lens roadmap thread, calling this vote to get
> > consensus from developers of Lens for the proposal.
> >
> > Lens codebase can be broken down into two sub projects : one for
> metastore
> > and other for query. Query service can have dependency on metastore
> > service. This shall help these subprojects evolve separately.
> >
> > To achieve the same we shall do 2.8 release from current master with all
> > changes for current stack. Move master to 3.0 with refactored code of
> > subprojects, which can be build separately.
> >
> > Lens developers, do cast your vote for the above
> >
> > [+1] if you approve
> > [0] if no opinion
> > [-] if you are not approving, with reasons.
> >
> > Do express your comments as well.
> >
> > Thanks
> > Amareshwari
> >
> >
> >
>

Re: Lens RoadMap

[Puneet Gupta]

Hi Rajsekhar,

I have also added some concerns in the doc. The changes proposed seem big.
It might be helpful we we can all meet over a call and discuss these.

Thanks,
Puneet

On Wed, Aug 21, 2019 at 5:24 PM amareshwarisr . 
wrote:

> Thanks Rajashekhar for sharing your views.
>
> I have added some comments on the doc to understand the requirements and
> features of interest better.
>
> Though google doc is good tool for writing documents and providing
> comments, team will not get emails for updates. Can you update this thread
> with a summary of changes done whenever you update it?
>
> Other dev and PMC, do review and provide your comments on the doc and
> update this thread with a summary.
>
> Thanks
>
> On Tue, Aug 20, 2019 at 11:07 AM Rajashekhar Choukimath (via Google Docs) <
> raju.n...@gmail.com> wrote:
>
> > I've shared an item with you:
> >
> > Lens RoadMap
> >
> >
> https://docs.google.com/document/d/1wbWPrB1VjwAa9kBCSxyfEkC5GjN5sq3nxQLIPaRz85s/edit?usp=sharing=5d5b8699
> >
> > It's not an attachment -- it's stored online. To open this item, just
> > click
> > the link above.
> >
> > I am sharing the Lens roadmap for next 2 quarters, Regarding the
> > maintenance of the code repo, I have added it the end.
> >
>

Re: [VOTE] Lens - Code Commit using Pull Requests

[Puneet Gupta]

+1.

On Tue, 22 Jan, 2019, 9:08 AM Amareshwari Sriramdasu  Rajitha,
>
> Can we make sure emails for the new pull requests and the comments on pull
> requests come to dev@lens.apache.org as part of this change?
>
> Thanks
>
> On Sun, Jan 20, 2019 at 10:29 AM Amareshwari Sriramdasu <
> amareshw...@apache.org> wrote:
>
> > +1
> >
> > On Sat, Jan 19, 2019 at 2:54 PM Rajat Khandelwal 
> > wrote:
> >
> >> +1
> >>
> >
>

Re: [DISCUSS] Lens Migration from Git-wip to Gitbox

[Puneet Gupta]

+1

On Tue, 8 Jan, 2019, 8:38 AM Amareshwari Sriramdasu  +1
>
> On Mon, Jan 7, 2019 at 10:59 AM Rajitha R  wrote:
>
> > Hi All,
> >
> > ASF infra has decided to move all git repositories from
> > git-wip-us.apache.org URL to gitbox.apache.org with the former service
> > being decommisioned.
> >
> > This mail is to get a consensus from all of you regarding the migration.
> >
> > Please vote within next 24 hours, which can help me in raising the Infra
> > jira before the published timeline.
> >
> > [ ] +1 approve
> > [ ] 0 no opinion
> > [ ] -1 disapprove (and reason why)
> >
> > +1 from my side for the activity.
> >
> > For folks looking for more details, please refer this link :
> >
> >
> https://blogs.apache.org/infra/entry/relocation-of-apache-git-repositories
> >
> > Regards,
> > Rajitha.R
> >
>

Re: Report for November, 2018

[Puneet Gupta]

+1. Looks good to me .

On Wed, Nov 7, 2018 at 8:02 PM Amareshwari Sriramdasu <
amareshw...@apache.org> wrote:

> Hi,
>
> Have updated draft report for November,2018 at
> https://cwiki.apache.org/confluence/display/LENS/November%2C2018. Please
> review and let me know your comments.
>
> Thanks
> Amareshwari
>

Re: Review Request 67523: Result download url to be made configurable

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67523/#review204544
---


Ship it!




Ship It!

- Puneet Gupta


On June 11, 2018, 3:43 p.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67523/
> ---
> 
> (Updated June 11, 2018, 3:43 p.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1519
> https://issues.apache.org/jira/browse/LENS-1519
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The current Lens set up uses a hardcoded lens result download url. This can 
> be made configurable to allow clients set their own download urls if needed. 
> If this configuration is set, the url should internally handle how to 
> download the result from lens.
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  5a4e3dd 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/DefaultDownloadResultUrlProvider.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/DownloadResultUrlProvider.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java
>  3f24343 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  4d141e5 
>   src/site/apt/user/cli.apt 12bc88c 
>   src/site/apt/user/client-config.apt 4f0b2b4 
> 
> 
> Diff: https://reviews.apache.org/r/67523/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

Re: Review Request 67523: Result download url to be made configurable

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67523/#review204541
---




lens-server-api/src/main/java/org/apache/lens/server/api/query/DownloadResultUrlSetter.java
Lines 24 (patched)
<https://reviews.apache.org/r/67523/#comment287097>

Can we also mention in the commnet that this URL is embedded in query 
competion email ?



lens-server-api/src/main/java/org/apache/lens/server/api/query/DownloadResultUrlSetter.java
Lines 26 (patched)
<https://reviews.apache.org/r/67523/#comment287096>

Should we rename this to DownloadResultUrlProvider ?


- Puneet Gupta


On June 11, 2018, 9:41 a.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67523/
> ---
> 
> (Updated June 11, 2018, 9:41 a.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1519
> https://issues.apache.org/jira/browse/LENS-1519
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The current Lens set up uses a hardcoded lens result download url. This can 
> be made configurable to allow clients set their own download urls if needed. 
> If this configuration is set, the url should internally handle how to 
> download the result from lens.
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  5a4e3dd 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/DefaultDownloadResultUrlSetter.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/DownloadResultUrlSetter.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java
>  3f24343 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  4d141e5 
>   src/site/apt/admin/config.apt 9a1572b 
>   src/site/apt/user/cli.apt 12bc88c 
>   src/site/apt/user/client-config.apt 4f0b2b4 
> 
> 
> Diff: https://reviews.apache.org/r/67523/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

Re: Review Request 67214: git diff origin/master master >> Lens-150

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67214/#review203483
---




lens-client/src/main/java/org/apache/lens/client/LensTrustManager.java
Lines 63 (patched)
<https://reviews.apache.org/r/67214/#comment285736>

Should we have separate config for client and server to ignore certificate 
check ?



lens-client/src/main/java/org/apache/lens/client/LensTrustManager.java
Lines 87 (patched)
<https://reviews.apache.org/r/67214/#comment285737>

Should this not come from trustManager.getAcceptedIssuers() ?



lens-server/src/main/resources/lensserver-default.xml
Lines 984 (patched)
<https://reviews.apache.org/r/67214/#comment285738>

incomplete description. Please update


- Puneet Gupta


On May 21, 2018, 4:46 a.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67214/
> ---
> 
> (Updated May 21, 2018, 4:46 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1511
> https://issues.apache.org/jira/browse/LENS-1511
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> enable SSL/TLS for lens server and client communication
> 
> 
> Diffs
> -
> 
>   lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java 
> eb12ee30 
>   lens-client/src/main/java/org/apache/lens/client/LensConnection.java 
> ab498314 
>   lens-client/src/main/java/org/apache/lens/client/LensHostnameVerifier.java 
> PRE-CREATION 
>   lens-client/src/main/java/org/apache/lens/client/LensTrustManager.java 
> PRE-CREATION 
>   lens-client/src/main/resources/lens-client-default.xml 132e1b14 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  bda995dd 
>   lens-server/src/main/java/org/apache/lens/server/LensServer.java 7f8b3363 
>   lens-server/src/main/resources/lensserver-default.xml bef82518 
>   lens-server/src/test/resources/lens-site.xml f5a02376 
>   src/site/apt/admin/config.apt 8720c822 
>   src/site/apt/admin/hivedriver-config.apt 221c1662 
>   src/site/apt/user/olap-query-conf.apt 90d635b8 
> 
> 
> Diff: https://reviews.apache.org/r/67214/diff/2/
> 
> 
> Testing
> ---
> 
> build logs : 
> 
> INFO] Installing 
> /Users/ankit.kailaswar/inmobi/apache/lens1/lens/contrib/clients/python/pom.xml
>  to 
> /Users/ankit.kailaswar/.m2/repository/org/apache/lens/lens-python-client/2.8.0-SNAPSHOT/lens-python-client-2.8.0-SNAPSHOT.pom
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules .. SUCCESS [  1.732 
> s]
> [INFO] Lens ... SUCCESS [  4.058 
> s]
> [INFO] Lens API ... SUCCESS [ 12.199 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 11.348 
> s]
> [INFO] Lens Cube .. SUCCESS [ 20.835 
> s]
> [INFO] Lens DB storage  SUCCESS [  4.510 
> s]
> [INFO] Lens Query Library . SUCCESS [  6.098 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [  8.414 
> s]
> [INFO] Lens Driver for JDBC ... SUCCESS [  9.297 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [  7.908 
> s]
> [INFO] Lens Server  SUCCESS [ 33.810 
> s]
> [INFO] Lens client  SUCCESS [ 10.876 
> s]
> [INFO] Lens CLI ... SUCCESS [  7.791 
> s]
> [INFO] Lens Examples .. SUCCESS [  4.987 
> s]
> [INFO] Lens Ship Jars to Distributed Cache  SUCCESS [  0.771 
> s]
> [INFO] Lens Distribution .. SUCCESS [ 12.208 
> s]
> [INFO] Lens ML Lib  SUCCESS [ 11.166 
> s]
> [INFO] Lens ML Ext Distribution ... SUCCESS [  2.854 
> s]
> [INFO] Lens Regression  SUCCESS [  7.349 
> s]
> [INFO] Lens UI  SUCCESS [  2.988 
> s]
> [INFO] Lens Contrib ... SUCCESS [  0.203 
> s]
> [INFO] Lens Contributed Clients ... SUCCESS [  0.191 
>

Re: Review Request 66549: Lens Server: SPNEGO authentication

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66549/#review202754
---




lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java
Lines 80 (patched)
<https://reviews.apache.org/r/66549/#comment284735>

can we also add details on usage or user and password ?



lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java
Lines 132 (patched)
<https://reviews.apache.org/r/66549/#comment284734>

can be private ?



lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
Line 1515 (original), 1515 (patched)
<https://reviews.apache.org/r/66549/#comment284739>

why is this renoved ?



lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
Lines 226 (patched)
<https://reviews.apache.org/r/66549/#comment284736>

    can be private ?


- Puneet Gupta


On May 4, 2018, 12:48 p.m., Barun Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66549/
> ---
> 
> (Updated May 4, 2018, 12:48 p.m.)
> 
> 
> Review request for lens, Ankit Kailaswar, Puneet Gupta, and Rajitha R.
> 
> 
> Bugs: LENS-1509
> https://issues.apache.org/jira/browse/LENS-1509
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Currently authentication in lens works by taking username/password while 
> opening a session and validating it.
> 
> This change will add support of SPNEGO support in lens server and clinet so 
> that it can negotiate the authentication scheme. Currently only 
> Negotiate(Kerberos) scheme is implemented but others like Basic/Digest etc 
> can be added as well later.
> 
> 
> Diffs
> -
> 
>   contrib/clients/python/lens/client/auth.py PRE-CREATION 
>   contrib/clients/python/lens/client/session.py a1ccc4ba3 
>   contrib/clients/python/setup.py de59d32a9 
>   lens-api/src/main/java/org/apache/lens/api/auth/AuthScheme.java 
> PRE-CREATION 
>   lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java 
> b703e132d 
>   lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java 
> 3a5dcdb82 
>   lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java 
> PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> e83eacb11 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  f14ae44af 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> b5248f3d5 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java 
> c3f99529a 
>   lens-server/src/main/java/org/apache/lens/server/auth/Authenticate.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/LensSecurityContext.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/error/NotAuthorizedExceptionMapper.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> 08a5cff4f 
>   
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 
> 63eea6313 
> 
> 
> Diff: https://reviews.apache.org/r/66549/diff/2/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1.458s]
> [INFO] Lens .. SUCCESS [3.567s]
> [INFO] Lens API .. SUCCESS [19.185s]
> [INFO] Lens API for server and extensions  SUCCESS [17.395s]
> [INFO] Lens Cube . SUCCESS [3:00.221s]
> [INFO] Lens DB storage ... SUCCESS [13.920s]
> [INFO] Lens Query Library  SUCCESS [11.039s]
> [INFO] Lens Hive Driver .. SUCCESS [1:06.122s]
> [INFO] Lens Driver for JDBC .. SUCCESS [42.723s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.640s]
> [INFO] Lens Server ... SUCCESS 
> [10:18.231s]
> [INFO] Lens client ... SUCCESS [1:27.686s]
> [INFO] Lens CLI .. SUCCESS [1:32.599s]
> [INFO] Lens Examples . SUCCESS [8.707s]
&

Re: Report for May,2018

[Puneet Gupta]

+1

On Mon, May 7, 2018 at 12:02 PM, rajitha r  wrote:

> +1
>
> On Mon, May 7, 2018 at 10:52 AM, Raghavendra Singh <
> raghavendra.si...@inmobi.com> wrote:
>
> > +1
> >
> > On Mon, May 7, 2018 at 10:46 AM, Raju Bairishetti 
> wrote:
> >
> > > +1
> > >
> > > On Mon, May 7, 2018 at 12:45 PM, amareshwarisr 
> > > wrote:
> > >
> > > > Hi Lens devs,
> > > >
> > > > Have updated report for May,2018 at
> > > > https://cwiki.apache.org/confluence/display/LENS/May%2C2018.
> > > >
> > > > Please review and let me know your comments.
> > > >
> > > > Thanks
> > > > Amareshwari
> > > >
> > >
> > >
> > >
> > > --
> > >
> > > --
> > > Thanks,
> > > Raju Bairishetti,
> > > www.lazada.com
> > >
> >
> > --
> > _
> > The
> > information contained in this communication is intended solely for the
> use
> > of the individual or entity to whom it is addressed and others authorized
> > to receive it. It may contain confidential or legally privileged
> > information. If you are not the intended recipient you are hereby
> notified
> > that any disclosure, copying, distribution or taking any action in
> > reliance
> > on the contents of this information is strictly prohibited and may be
> > unlawful. If you have received this communication in error, please notify
> > us immediately by responding to this email and then delete it from your
> > system. The firm is neither liable for the proper and complete
> > transmission
> > of the information contained in this communication nor for any delay in
> > its
> > receipt.
> >
>
>
>
> --
> Regards,
>
> Rajitha.R
>

Re: Review Request 66505: Hadoop version upgrade

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66505/#review200986
---


Ship it!




Ship It!

- Puneet Gupta


On April 9, 2018, 10:06 a.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66505/
> ---
> 
> (Updated April 9, 2018, 10:06 a.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Upgrade hadoop version and change in jar path under hadoop home
> 
> 
> Diffs
> -
> 
>   pom.xml b99bfa5 
>   tools/scripts/lens-ctl 073ecd8 
> 
> 
> Diff: https://reviews.apache.org/r/66505/diff/1/
> 
> 
> Testing
> ---
> 
> [INFO] 
> [INFO] Lens Checkstyle Rules .. SUCCESS [  8.526 
> s]
> [INFO] Lens ... SUCCESS [ 10.238 
> s]
> [INFO] Lens API ... SUCCESS [ 16.348 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 16.865 
> s]
> [INFO] Lens Cube .. SUCCESS [ 11.406 
> s]
> [INFO] Lens DB storage  SUCCESS [  1.330 
> s]
> [INFO] Lens Query Library . SUCCESS [  2.397 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [  4.016 
> s]
> [INFO] Lens Driver for JDBC ... SUCCESS [  5.220 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [  2.671 
> s]
> [INFO] Lens Server  SUCCESS [ 43.216 
> s]
> [INFO] Lens client  SUCCESS [  3.476 
> s]
> [INFO] Lens CLI ... SUCCESS [  3.677 
> s]
> [INFO] Lens Examples .. SUCCESS [  0.836 
> s]
> [INFO] Lens Ship Jars to Distributed Cache  SUCCESS [  1.175 
> s]
> [INFO] Lens Distribution .. SUCCESS [ 12.656 
> s]
> [INFO] Lens ML Lib  SUCCESS [ 12.741 
> s]
> [INFO] Lens ML Ext Distribution ... SUCCESS [  4.862 
> s]
> [INFO] Lens Regression  SUCCESS [  3.477 
> s]
> [INFO] Lens UI  SUCCESS [ 53.373 
> s]
> [INFO] Lens Contrib ... SUCCESS [  0.056 
> s]
> [INFO] Lens Contributed Clients ... SUCCESS [  0.063 
> s]
> [INFO] Lens Python Client . SUCCESS [  0.053 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 03:39 min
> [INFO] Finished at: 2018-04-09T15:35:58+05:30
> [INFO] Final Memory: 242M/1759M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

[jira] [Updated] (LENS-1506) Kerberos authentication in lens

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1506:
---
Fix Version/s: 2.8

> Kerberos authentication in lens
> ---
>
> Key: LENS-1506
> URL: https://issues.apache.org/jira/browse/LENS-1506
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: client, driver-hive, python-client, server
>Reporter: Ankit Kailaswar
>Assignee: Ankit Kailaswar
>Priority: Major
> Fix For: 2.8
>
> Attachments: Lens-1506.1.patch, Lens-1506.2.patch, Lens-1506.3.patch, 
> Lens-1506.4.patch, Lens-1506_patch, design3.png
>
>
> Current Lens implementation is broken when we try to enable kerberos 
> authentication in lens as mentioned at 
> [https://cwiki.apache.org/confluence/display/Hive/Setting+Up+HiveServer2] in 
> following ways,
> 1. openSession REST API fails to create new session for user. Currently it 
> supports only passwd types of authentication.
> 2. If the underlying hive driver is running with kerberos authentication then 
> driver initialization flow to obtain hive transport for hive driver in lens 
> errors out. Hive server accepts only sasl messages but lens continues using 
> PLAINSASL.
> 3. If hadoop cluster has kerberos authentication enabled then all hdfs calls 
> (persisting services, all hdfs path in conf etc) fail.
> 4. Lens as if now doesnt supports refreshing KDC token before it expires.
> Changes required in lens to fully support kerberose authentication are as 
> follows,
>  # lens's hive driver must use SASL for all communication in to kerberozied 
> hive. Current thrift client for hive doesn't support this functionality.
>  # Lens must refresh KDC ticket before it expires.
>  # All clients must be authenticated with kerberose authentication before 
> session creation.
>  # In kerberos mode all hive driver query should be executed with single 
> cluster user as "lens".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LENS-1506) Kerberos authentication in lens

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426805#comment-16426805
 ] 

Puneet Gupta commented on LENS-1506:


Committed. Thanks [~ankitkailaswar]

> Kerberos authentication in lens
> ---
>
> Key: LENS-1506
> URL: https://issues.apache.org/jira/browse/LENS-1506
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: client, driver-hive, python-client, server
>Reporter: Ankit Kailaswar
>Assignee: Ankit Kailaswar
>Priority: Major
> Fix For: 2.8
>
> Attachments: Lens-1506.1.patch, Lens-1506.2.patch, Lens-1506.3.patch, 
> Lens-1506.4.patch, Lens-1506_patch, design3.png
>
>
> Current Lens implementation is broken when we try to enable kerberos 
> authentication in lens as mentioned at 
> [https://cwiki.apache.org/confluence/display/Hive/Setting+Up+HiveServer2] in 
> following ways,
> 1. openSession REST API fails to create new session for user. Currently it 
> supports only passwd types of authentication.
> 2. If the underlying hive driver is running with kerberos authentication then 
> driver initialization flow to obtain hive transport for hive driver in lens 
> errors out. Hive server accepts only sasl messages but lens continues using 
> PLAINSASL.
> 3. If hadoop cluster has kerberos authentication enabled then all hdfs calls 
> (persisting services, all hdfs path in conf etc) fail.
> 4. Lens as if now doesnt supports refreshing KDC token before it expires.
> Changes required in lens to fully support kerberose authentication are as 
> follows,
>  # lens's hive driver must use SASL for all communication in to kerberozied 
> hive. Current thrift client for hive doesn't support this functionality.
>  # Lens must refresh KDC ticket before it expires.
>  # All clients must be authenticated with kerberose authentication before 
> session creation.
>  # In kerberos mode all hive driver query should be executed with single 
> cluster user as "lens".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 66081: Kerberos authentication in lens

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66081/#review200541
---




lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
Lines 130 (patched)
<https://reviews.apache.org/r/66081/#comment281277>

can you add a comment why this is required.



lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java
Lines 148 (patched)
<https://reviews.apache.org/r/66081/#comment281274>

Can you import SecurityUtil ?



lens-server/src/main/java/org/apache/lens/server/LensServices.java
Lines 299 (patched)
<https://reviews.apache.org/r/66081/#comment281276>

can you move the KDC code to a separate method ?



lens-server/src/main/java/org/apache/lens/server/LensServices.java
Lines 304 (patched)
<https://reviews.apache.org/r/66081/#comment281273>

Should we catch Exception instead in this case ?


- Puneet Gupta


On April 5, 2018, 5:41 a.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66081/
> ---
> 
> (Updated April 5, 2018, 5:41 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and 
> Puneet Gupta.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/LENS-1506
> 
> This patch contains code changes to enable kerberos authentication for 
> 1. lens to hive 
> 2. lens to metastore
> 3. lens to hdfs
> 
> code changes are as follows,
> 1. new http thrift client for hive driver to support sasl transport for 
> kerberozied hive server.
> 2. cron to update KDC ticket before it expires.
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 2eb94aa7 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java
>  54885f77 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  d5273be8 
>   lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java 
> 9d732c1c 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> c30a2d72 
>   lens-server/src/main/java/org/apache/lens/server/LensServices.java 903b19fe 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  31ac358d 
>   lens-server/src/main/resources/lensserver-default.xml 28b1db29 
>   lens-server/src/test/resources/lens-site.xml 7e5f522e 
>   tools/scripts/lens-ctl 304b4f5a 
> 
> 
> Diff: https://reviews.apache.org/r/66081/diff/7/
> 
> 
> Testing
> ---
> 
> unit testing
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

Re: Review Request 66081: Kerberos authentication in lens

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66081/#review200353
---


Ship it!




Ship It!

- Puneet Gupta


On April 3, 2018, 8:14 a.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66081/
> ---
> 
> (Updated April 3, 2018, 8:14 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and 
> Puneet Gupta.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> https://issues.apache.org/jira/browse/LENS-1506
> 
> This patch contains code changes to enable kerberos authentication for 
> 1. lens to hive 
> 2. lens to metastore
> 3. lens to hdfs
> 
> code changes are as follows,
> 1. new http thrift client for hive driver to support sasl transport for 
> kerberozied hive server.
> 2. cron to update KDC ticket before it expires.
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 2eb94aa7 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java
>  54885f77 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  d5273be8 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> c30a2d72 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  31ac358d 
>   lens-server/src/main/resources/lensserver-default.xml 28b1db29 
>   lens-server/src/test/resources/lens-site.xml 7e5f522e 
>   tools/scripts/lens-ctl 304b4f5a 
> 
> 
> Diff: https://reviews.apache.org/r/66081/diff/5/
> 
> 
> Testing
> ---
> 
> unit testing
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

[jira] [Commented] (LENS-1506) Kerberos authentication in lens

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400337#comment-16400337
 ] 

Puneet Gupta commented on LENS-1506:


[~ankitkailaswar] This review request covers all the changes 1- 4 ?

> Kerberos authentication in lens
> ---
>
> Key: LENS-1506
> URL: https://issues.apache.org/jira/browse/LENS-1506
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: client, driver-hive, python-client, server
>Reporter: Ankit Kailaswar
>Assignee: Ankit Kailaswar
>Priority: Major
> Attachments: design3.png
>
>
> Current Lens implementation is broken when we try to enable kerberos 
> authentication in lens as mentioned at 
> [https://cwiki.apache.org/confluence/display/Hive/Setting+Up+HiveServer2] in 
> following ways,
> 1. openSession REST API fails to create new session for user. Currently it 
> supports only passwd types of authentication.
> 2. If the underlying hive driver is running with kerberos authentication then 
> driver initialization flow to obtain hive transport for hive driver in lens 
> errors out. Hive server accepts only sasl messages but lens continues using 
> PLAINSASL.
> 3. If hadoop cluster has kerberos authentication enabled then all hdfs calls 
> (persisting services, all hdfs path in conf etc) fail.
> 4. Lens as if now doesnt supports refreshing KDC token before it expires.
> Changes required in lens to fully support kerberose authentication are as 
> follows,
>  # lens's hive driver must use SASL for all communication in to kerberozied 
> hive. Current thrift client for hive doesn't support this functionality.
>  # Lens must refresh KDC ticket before it expires.
>  # All clients must be authenticated with kerberose authentication before 
> session creation.
>  # In kerberos mode all hive driver query should be executed with single 
> cluster user as "lens".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Report for Feb, 2018

[Puneet Gupta]

+1

On Fri, Feb 9, 2018 at 5:41 PM, Amareshwari Sriramdasu <
amareshw...@apache.org> wrote:

> Hi,
>
> Have put the report for Feb,2018 here -
> https://cwiki.apache.org/confluence/display/LENS/Feb%2C2018
>
> Please review and let me know your comments.
>
> Thanks
>

[ANNOUNCE] New Apache Lens committer : Rajitha R

[Puneet Gupta]

The PMC for Apache Lens has asked Rajitha to become Lens Committer. We are
pleased to announce that she has accepted.

Being a committer enables access to commit to the source repositories
and binding
votes for code reviews.

Join me in Congratulating Rajitha!

Congratulations Rajitha! Looking forward for more of your contributions in
Apache Lens.

Thanks
Puneet

Re: [ANNOUNCE] Apache Lens 2.7.1 released

[Puneet Gupta]

Thanks Raju. Lot of hard work has gone in making this release possible.
Really appreciate your contribution.


On Tue, Feb 6, 2018 at 11:55 AM, Amareshwari Sriramdasu <
amareshw...@apache.org> wrote:

> Great work Raju!
>
> Your perseverance made this release possible. Thank you so much for
> volunteering and completing this release.
>
> Thanks
> Amareshwari
>
> On Tue, Feb 6, 2018 at 11:48 AM, Raju Bairishetti  wrote:
>
> > Hi All,
> >
> > The Apache Lens team is proud to announce the release of Apache Lens
> > 2.7.1.
> >
> > This release includes features like cube segmentation, unioning data
> across
> > facts, retry on transient errors, support for source data completion
> > checking and many more bug fixes and improvements.
> >
> > Apache Lens provides a Unified Analytics interface. Lens aims to cut the
> > Data Analytics silos by providing a single view of data across multiple
> > tiered data stores and optimal execution environment for the analytical
> > query. It seamlessly integrates Hadoop with traditional data warehouses
> to
> > appear like one.
> >
> >
> > More details on Apache Lens can be found at
> > http://lens.apache.org/
> >
> > Getting started available at
> > http://lens.apache.org/lenshome/quick-start.html
> >
> > For quick ramp-up, you can watch a video at
> > http://cwiki.apache.org/confluence/display/LENS/2015/
> > 07/13/20+Minute+video+demo+of+Apache+Lens+through+examples
> >
> > How to for Contributors available at
> > http://lens.apache.org/developer/contribute.html
> >
> > The release artifacts are downloadable from
> > http://lens.apache.org/releases/download.html
> >
> > Maven jar artifacts have also been made available on
> > https://repository.apache.org/content/repositories/releases/
> > org/apache/lens
> >
> > Release notes available at
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > projectId=12315923=12336851
> >
> > We would like to thank all the contributors who made this release
> possible.
> >
> >
> > Thanks,
> > Raju Bairishetti
> >
>

Re: [VOTE] Release of Apache Lens 2.7.1

[Puneet Gupta]

+1 from my side

   1. Was able to download the source code and binary
   2. Was able to open the nexus url and verify some jars
   3. Was able to start the lens server and run examples
   4. Was able to compile the source code


On Wed, Jan 31, 2018 at 1:53 PM, rajitha r  wrote:

> +1
> The code builds successfully and the test cases run as well.
>
> On Thu, Jan 25, 2018 at 4:04 PM, rajitha r  wrote:
>
> > +1
> >
> > On Wed, Jan 24, 2018 at 12:33 PM, Raju Bairishetti 
> > wrote:
> >
> >> Hi everyone,
> >>
> >> I propose the following RC to be released as official Apache Lens
> >> 2.7.1
> >> release.
> >>
> >> The commit id is 865d20267e8128134bb981f1db9dab9108661061:
> >> http://git-wip-us.apache.org/repos/asf/lens/commit/865d2026
> >>
> >> This corresponds to the tag: apache-lens-2.7.1:
> >> https://git-wip-us.apache.org/repos/asf?p=lens.git;a=tag;h=r
> >> efs/tags/apache-lens-2.7.1
> >>
> >> Release archives (tar.gz/zip) signature and checksums are here:
> >> https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.7.1-rc0/
> >>
> >> You can find the KEYS file here:
> >> https://dist.apache.org/repos/dist/dev/lens/KEYS
> >>
> >> The release candidate consists of the following source distribution
> >> archive
> >> apache-lens-2.7.1-source-release.zip:
> >> https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.7.
> >> 1-rc0/apache-lens-2.7.1-source-release.zip
> >>
> >> In addition, the following supplementary binary distributions are
> provided
> >> for user convenience at the same location: apache-lens-2.7.1-bin.tar.gz
> >> https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.7.
> >> 1-rc0/apache-lens-2.7.1-bin.tar.gz
> >>
> >> the licensing of bundled bits in the archives are documented at
> >> https://cwiki.apache.org/confluence/display/LENS/
> Licensing+in+Apache+Lens
> >>
> >> Nexus staging url:
> >> https://repository.apache.org/content/repositories/orgapachelens-1012
> >>
> >> Release notes available at
> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> >> projectId=12315923=12336851
> >>
> >> Vote will be open for at least 72 hours
> >>
> >> [ ] +1 approve
> >> [ ]  0  no opinion
> >> [ ]  -1 disapprove (and reason why)
> >>
> >> +1 from my side for the release.
> >>
> >> For folks not familiar with vetting a release, please refer to
> >>
> >> http://incubator.apache.org/guides/releasemanagement.html#check-list
> >>
> >> --
> >> Thanks,
> >> Raju Bairishetti,
> >> www.lazada.com
> >>
> >
> >
> >
> > --
> > Regards,
> >
> > Rajitha.R
> >
>
>
>
> --
> Regards,
>
> Rajitha.R
>

[jira] [Commented] (LENS-1497) NPE while closing idle connections

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335458#comment-16335458
 ] 

Puneet Gupta commented on LENS-1497:


Committed. Thanks [~rajitha.r]

> NPE while closing idle connections 
> ---
>
> Key: LENS-1497
> URL: https://issues.apache.org/jira/browse/LENS-1497
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajitha R
>Assignee: Rajitha R
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1497.patch
>
>
> {code}
> 21 Dec 2017 15:25:59 [e88aa05a-c454-44c1-8e52-e7bd741a5df6] 
> [pool-16-thread-1] WARN  org.apache.lens.server.session.HiveSessionService - 
> Unknown error while checking for inactive sessions -
> java.lang.NullPointerException: null
> at 
> org.apache.lens.server.BaseLensService.decrementSessionCountForUser(BaseLensService.java:343)
>  ~[classes/:na]
> at 
> org.apache.lens.server.BaseLensService.closeSession(BaseLensService.java:321) 
> ~[classes/:na]
> at 
> org.apache.lens.server.session.HiveSessionService.closeInternal(HiveSessionService.java:497)
>  ~[classes/:na]
> at 
> org.apache.lens.server.session.HiveSessionService.access$300(HiveSessionService.java:59)
>  ~[classes/:na]
> at 
> org.apache.lens.server.session.HiveSessionService$SessionExpiryRunnable.runInternal(HiveSessionService.java:547)
>  ~[classes/:na]
> at 
> org.apache.lens.server.session.HiveSessionService$SessionExpiryRunnable.run(HiveSessionService.java:569)
>  ~[classes/:na]
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
> [na:1.8.0_131]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> [na:1.8.0_131]
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
>  [na:1.8.0_131]
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Sche
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1497) NPE while closing idle connections

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1497:
---
Fix Version/s: 2.8

> NPE while closing idle connections 
> ---
>
> Key: LENS-1497
> URL: https://issues.apache.org/jira/browse/LENS-1497
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajitha R
>Assignee: Rajitha R
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1497.patch
>
>
> {code}
> 21 Dec 2017 15:25:59 [e88aa05a-c454-44c1-8e52-e7bd741a5df6] 
> [pool-16-thread-1] WARN  org.apache.lens.server.session.HiveSessionService - 
> Unknown error while checking for inactive sessions -
> java.lang.NullPointerException: null
> at 
> org.apache.lens.server.BaseLensService.decrementSessionCountForUser(BaseLensService.java:343)
>  ~[classes/:na]
> at 
> org.apache.lens.server.BaseLensService.closeSession(BaseLensService.java:321) 
> ~[classes/:na]
> at 
> org.apache.lens.server.session.HiveSessionService.closeInternal(HiveSessionService.java:497)
>  ~[classes/:na]
> at 
> org.apache.lens.server.session.HiveSessionService.access$300(HiveSessionService.java:59)
>  ~[classes/:na]
> at 
> org.apache.lens.server.session.HiveSessionService$SessionExpiryRunnable.runInternal(HiveSessionService.java:547)
>  ~[classes/:na]
> at 
> org.apache.lens.server.session.HiveSessionService$SessionExpiryRunnable.run(HiveSessionService.java:569)
>  ~[classes/:na]
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
> [na:1.8.0_131]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> [na:1.8.0_131]
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
>  [na:1.8.0_131]
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Sche
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1497) NPE while closing idle connections

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1497:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> NPE while closing idle connections 
> ---
>
> Key: LENS-1497
> URL: https://issues.apache.org/jira/browse/LENS-1497
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajitha R
>Assignee: Rajitha R
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1497.patch
>
>
> {code}
> 21 Dec 2017 15:25:59 [e88aa05a-c454-44c1-8e52-e7bd741a5df6] 
> [pool-16-thread-1] WARN  org.apache.lens.server.session.HiveSessionService - 
> Unknown error while checking for inactive sessions -
> java.lang.NullPointerException: null
> at 
> org.apache.lens.server.BaseLensService.decrementSessionCountForUser(BaseLensService.java:343)
>  ~[classes/:na]
> at 
> org.apache.lens.server.BaseLensService.closeSession(BaseLensService.java:321) 
> ~[classes/:na]
> at 
> org.apache.lens.server.session.HiveSessionService.closeInternal(HiveSessionService.java:497)
>  ~[classes/:na]
> at 
> org.apache.lens.server.session.HiveSessionService.access$300(HiveSessionService.java:59)
>  ~[classes/:na]
> at 
> org.apache.lens.server.session.HiveSessionService$SessionExpiryRunnable.runInternal(HiveSessionService.java:547)
>  ~[classes/:na]
> at 
> org.apache.lens.server.session.HiveSessionService$SessionExpiryRunnable.run(HiveSessionService.java:569)
>  ~[classes/:na]
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
> [na:1.8.0_131]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> [na:1.8.0_131]
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
>  [na:1.8.0_131]
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Sche
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1500) Test cases failing in master

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1500:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Test cases failing in master 
> -
>
> Key: LENS-1500
> URL: https://issues.apache.org/jira/browse/LENS-1500
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajitha R
>Assignee: Rajitha R
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1500.patch
>
>
> Latest master code has some of the test cases failing as follows. This seems 
> to happen as we entered new year and month. Needs to be investigated
> {code}
> Failed tests: 
>   
> TestUnionQueries.testDimAttrExpressionQuery:218->TestQueryRewrite.rewrite:89->TestQueryRewrite.rewriteCtx:98
>  » Lens
>   
> TestUnionQueries.testNonAggregateOverAggregateFunction:290->TestQueryRewrite.rewrite:89->TestQueryRewrite.rewriteCtx:98
>  » Lens
>   
> TestUnionQueries.testSingleFactMultiStorage:342->TestQueryRewrite.rewrite:89->TestQueryRewrite.rewriteCtx:98
>  » Lens
>   
> TestUnionQueries.testSingleFactSingleStorageWithMultipleTableDescriptions:390->TestQueryRewrite.rewrite:89->TestQueryRewrite.rewriteCtx:98
>  » Lens
>   
> TestUnionQueries.testUnionQueries:89->TestQueryRewrite.rewrite:89->TestQueryRewrite.rewriteCtx:98
>  » Lens
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1500) Test cases failing in master

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1500:
---
Fix Version/s: 2.8

> Test cases failing in master 
> -
>
> Key: LENS-1500
> URL: https://issues.apache.org/jira/browse/LENS-1500
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajitha R
>Assignee: Rajitha R
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1500.patch
>
>
> Latest master code has some of the test cases failing as follows. This seems 
> to happen as we entered new year and month. Needs to be investigated
> {code}
> Failed tests: 
>   
> TestUnionQueries.testDimAttrExpressionQuery:218->TestQueryRewrite.rewrite:89->TestQueryRewrite.rewriteCtx:98
>  » Lens
>   
> TestUnionQueries.testNonAggregateOverAggregateFunction:290->TestQueryRewrite.rewrite:89->TestQueryRewrite.rewriteCtx:98
>  » Lens
>   
> TestUnionQueries.testSingleFactMultiStorage:342->TestQueryRewrite.rewrite:89->TestQueryRewrite.rewriteCtx:98
>  » Lens
>   
> TestUnionQueries.testSingleFactSingleStorageWithMultipleTableDescriptions:390->TestQueryRewrite.rewrite:89->TestQueryRewrite.rewriteCtx:98
>  » Lens
>   
> TestUnionQueries.testUnionQueries:89->TestQueryRewrite.rewrite:89->TestQueryRewrite.rewriteCtx:98
>  » Lens
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LENS-1500) Test cases failing in master

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335453#comment-16335453
 ] 

Puneet Gupta commented on LENS-1500:


Committed. Thanks [~rajitha.r]

> Test cases failing in master 
> -
>
> Key: LENS-1500
> URL: https://issues.apache.org/jira/browse/LENS-1500
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajitha R
>Assignee: Rajitha R
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1500.patch
>
>
> Latest master code has some of the test cases failing as follows. This seems 
> to happen as we entered new year and month. Needs to be investigated
> {code}
> Failed tests: 
>   
> TestUnionQueries.testDimAttrExpressionQuery:218->TestQueryRewrite.rewrite:89->TestQueryRewrite.rewriteCtx:98
>  » Lens
>   
> TestUnionQueries.testNonAggregateOverAggregateFunction:290->TestQueryRewrite.rewrite:89->TestQueryRewrite.rewriteCtx:98
>  » Lens
>   
> TestUnionQueries.testSingleFactMultiStorage:342->TestQueryRewrite.rewrite:89->TestQueryRewrite.rewriteCtx:98
>  » Lens
>   
> TestUnionQueries.testSingleFactSingleStorageWithMultipleTableDescriptions:390->TestQueryRewrite.rewrite:89->TestQueryRewrite.rewriteCtx:98
>  » Lens
>   
> TestUnionQueries.testUnionQueries:89->TestQueryRewrite.rewrite:89->TestQueryRewrite.rewriteCtx:98
>  » Lens
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 64779: NPE fix in closing idle connections [LENS-1497]

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64779/#review195810
---


Ship it!




Ship It!

- Puneet Gupta


On Jan. 19, 2018, 10:07 a.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64779/
> ---
> 
> (Updated Jan. 19, 2018, 10:07 a.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1497
> https://issues.apache.org/jira/browse/LENS-1497
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> NPE fix in closing idle connections
> 
> 
> Diffs
> -
> 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> d7ce434 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  a9fd233 
> 
> 
> Diff: https://reviews.apache.org/r/64779/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

Re: Review Request 64779: NPE fix in closing idle connections [LENS-1497]

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64779/#review195712
---


Ship it!




Ship It!

- Puneet Gupta


On Jan. 11, 2018, 3:07 p.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64779/
> ---
> 
> (Updated Jan. 11, 2018, 3:07 p.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1497
> https://issues.apache.org/jira/browse/LENS-1497
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> NPE fix in closing idle connections
> 
> 
> Diffs
> -
> 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> d7ce434 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  a9fd233 
> 
> 
> Diff: https://reviews.apache.org/r/64779/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

Re: Review Request 64779: NPE fix in closing idle connections [LENS-1497]

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64779/#review195711
---




lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Lines 355 (patched)
<https://reviews.apache.org/r/64779/#comment274990>

Can we also log the session Handle


- Puneet Gupta


On Jan. 11, 2018, 3:07 p.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64779/
> ---
> 
> (Updated Jan. 11, 2018, 3:07 p.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1497
> https://issues.apache.org/jira/browse/LENS-1497
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> NPE fix in closing idle connections
> 
> 
> Diffs
> -
> 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> d7ce434 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  a9fd233 
> 
> 
> Diff: https://reviews.apache.org/r/64779/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

Re: Review Request 64779: NPE fix in closing idle connections [LENS-1497]

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64779/#review195018
---




lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Lines 231-235 (patched)
<https://reviews.apache.org/r/64779/#comment274119>

Is this required for restoreSession(...)flow only?  If yes can we move it 
there ?



lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Lines 236 (patched)
<https://reviews.apache.org/r/64779/#comment274118>

Why is this required ?
This method is called from openSession(..) and restoreSession(). The 
openSession call is already synchronized on sessionUser and the restoreSession 
happens in a single thread wand should not require synchronization.



lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Lines 350 (patched)
<https://reviews.apache.org/r/64779/#comment274120>

This should not be required now since we are adding missing users to this 
map on restoreSession.


- Puneet Gupta


On Dec. 21, 2017, 3:40 p.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64779/
> ---
> 
> (Updated Dec. 21, 2017, 3:40 p.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1497
> https://issues.apache.org/jira/browse/LENS-1497
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> NPE fix in closing idle connections
> 
> 
> Diffs
> -
> 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> d7ce434 
> 
> 
> Diff: https://reviews.apache.org/r/64779/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

Re: Review Request 64779: NPE fix in closing idle connections [LENS-1497]

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64779/#review194536
---




lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Lines 234 (patched)
<https://reviews.apache.org/r/64779/#comment273359>

should we return or add the missing user to SESSION_USER_INSTANCE_MAP ?



lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Line 342 (original), 349 (patched)
<https://reviews.apache.org/r/64779/#comment273360>

Is this inconsistnecy coming due to a restart ? Can we handle this on 
restart itself in that case when session service boots up


- Puneet Gupta


On Dec. 21, 2017, 3:40 p.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64779/
> ---
> 
> (Updated Dec. 21, 2017, 3:40 p.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1497
> https://issues.apache.org/jira/browse/LENS-1497
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> NPE fix in closing idle connections
> 
> 
> Diffs
> -
> 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> d7ce434 
> 
> 
> Diff: https://reviews.apache.org/r/64779/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

[jira] [Commented] (LENS-1495) Lens commit build failure due to checkstyle error

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299889#comment-16299889
 ] 

Puneet Gupta commented on LENS-1495:


Committed. Thanks [~rajitha.r]

> Lens commit build failure due to checkstyle error
> -
>
> Key: LENS-1495
> URL: https://issues.apache.org/jira/browse/LENS-1495
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajitha R
>Assignee: Rajitha R
> Fix For: 2.8
>
> Attachments: LENS-1495.patch
>
>
> Checkstyle error in Lensserver code needs to be fixed



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1495) Lens commit build failure due to checkstyle error

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1495:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Lens commit build failure due to checkstyle error
> -
>
> Key: LENS-1495
> URL: https://issues.apache.org/jira/browse/LENS-1495
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajitha R
>Assignee: Rajitha R
> Fix For: 2.8
>
> Attachments: LENS-1495.patch
>
>
> Checkstyle error in Lensserver code needs to be fixed



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1495) Lens commit build failure due to checkstyle error

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1495:
---
Fix Version/s: 2.8

> Lens commit build failure due to checkstyle error
> -
>
> Key: LENS-1495
> URL: https://issues.apache.org/jira/browse/LENS-1495
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajitha R
>Assignee: Rajitha R
> Fix For: 2.8
>
> Attachments: LENS-1495.patch
>
>
> Checkstyle error in Lensserver code needs to be fixed



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 64744: Checkstyle error fix [LENS-1495]

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64744/#review194233
---


Ship it!




Ship It!

- Puneet Gupta


On Dec. 20, 2017, 9:01 a.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64744/
> ---
> 
> (Updated Dec. 20, 2017, 9:01 a.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1495
> https://issues.apache.org/jira/browse/LENS-1495
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Checkstyle errors fixed
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java
>  aa1406e 
> 
> 
> Diff: https://reviews.apache.org/r/64744/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

[jira] [Commented] (LENS-1493) TotalQueryCost logic broken

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296652#comment-16296652
 ] 

Puneet Gupta commented on LENS-1493:


Committed. Thanks [~rajitha.r]

> TotalQueryCost logic broken 
> 
>
> Key: LENS-1493
> URL: https://issues.apache.org/jira/browse/LENS-1493
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajitha R
>Assignee: Rajitha R
> Fix For: 2.8
>
> Attachments: LENS-1493.patch
>
>
> The totalQueryCost method in DefaultEstimatedQueryCollection is throwing 
> following error : 
>  Error in query submitter
> java.lang.ClassCastException: 
> org.apache.lens.server.api.query.cost.FactPartitionBasedQueryCost cannot be 
> cast to org.apache.lens.server.api.query.cost.StaticQueryCost
>   at 
> org.apache.lens.server.api.query.cost.StaticQueryCost.add(StaticQueryCost.java:33)
>  
>   at 
> org.apache.lens.server.query.collect.DefaultEstimatedQueryCollection.getTotalQueryCost(DefaultEstimatedQueryCollection.java:171)
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1493) TotalQueryCost logic broken

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1493:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> TotalQueryCost logic broken 
> 
>
> Key: LENS-1493
> URL: https://issues.apache.org/jira/browse/LENS-1493
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajitha R
>Assignee: Rajitha R
> Fix For: 2.8
>
> Attachments: LENS-1493.patch
>
>
> The totalQueryCost method in DefaultEstimatedQueryCollection is throwing 
> following error : 
>  Error in query submitter
> java.lang.ClassCastException: 
> org.apache.lens.server.api.query.cost.FactPartitionBasedQueryCost cannot be 
> cast to org.apache.lens.server.api.query.cost.StaticQueryCost
>   at 
> org.apache.lens.server.api.query.cost.StaticQueryCost.add(StaticQueryCost.java:33)
>  
>   at 
> org.apache.lens.server.query.collect.DefaultEstimatedQueryCollection.getTotalQueryCost(DefaultEstimatedQueryCollection.java:171)
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1493) TotalQueryCost logic broken

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1493:
---
Fix Version/s: 2.8

> TotalQueryCost logic broken 
> 
>
> Key: LENS-1493
> URL: https://issues.apache.org/jira/browse/LENS-1493
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajitha R
>Assignee: Rajitha R
> Fix For: 2.8
>
> Attachments: LENS-1493.patch
>
>
> The totalQueryCost method in DefaultEstimatedQueryCollection is throwing 
> following error : 
>  Error in query submitter
> java.lang.ClassCastException: 
> org.apache.lens.server.api.query.cost.FactPartitionBasedQueryCost cannot be 
> cast to org.apache.lens.server.api.query.cost.StaticQueryCost
>   at 
> org.apache.lens.server.api.query.cost.StaticQueryCost.add(StaticQueryCost.java:33)
>  
>   at 
> org.apache.lens.server.query.collect.DefaultEstimatedQueryCollection.getTotalQueryCost(DefaultEstimatedQueryCollection.java:171)
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1480) For virtual facts, column start and end times are not working

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1480:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> For virtual facts, column start and end times are not working
> -
>
> Key: LENS-1480
> URL: https://issues.apache.org/jira/browse/LENS-1480
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajitha R
>Assignee: Rajitha R
> Fix For: 2.8
>
> Attachments: LENS-1480.1.patch, LENS-1480.patch
>
>
> For virtual facts, column start times are not working



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1480) For virtual facts, column start and end times are not working

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1480:
---
Fix Version/s: 2.8

> For virtual facts, column start and end times are not working
> -
>
> Key: LENS-1480
> URL: https://issues.apache.org/jira/browse/LENS-1480
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajitha R
>Assignee: Rajitha R
> Fix For: 2.8
>
> Attachments: LENS-1480.1.patch, LENS-1480.patch
>
>
> For virtual facts, column start times are not working



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1480) For virtual facts, column start and end times are not working

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296640#comment-16296640
 ] 

Puneet Gupta commented on LENS-1480:


Committed. Thanks [~rajitha.r]

> For virtual facts, column start and end times are not working
> -
>
> Key: LENS-1480
> URL: https://issues.apache.org/jira/browse/LENS-1480
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajitha R
>Assignee: Rajitha R
> Fix For: 2.8
>
> Attachments: LENS-1480.1.patch, LENS-1480.patch
>
>
> For virtual facts, column start times are not working



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 64443: Fix for TotalQueryCost [LENS-1493]

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64443/#review193651
---


Ship it!




Ship It!

- Puneet Gupta


On Dec. 12, 2017, 12:45 p.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64443/
> ---
> 
> (Updated Dec. 12, 2017, 12:45 p.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1493
> https://issues.apache.org/jira/browse/LENS-1493
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Changes include cost calculation being calculated by fetching each driver 
> cost query cost values and summing it up.
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/StaticQueryCost.java
>  8cdc254 
>   
> lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java
>  9a37afd 
>   
> lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollectionTest.java
>  4dde18a 
> 
> 
> Diff: https://reviews.apache.org/r/64443/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

Re: [VOTE] Release of Apache Lens 2.7.0

[Puneet Gupta]

This should fix it.
https://issues.apache.org/jira/browse/LENS-1472

On Tue, Dec 5, 2017 at 3:40 PM, Puneet Gupta <puneet.k.gu...@gmail.com>
wrote:

> Was able to
> - download lens server binary
> - validate the md5 hash
> - run lens server and lens cli
>
> *Facing issue while running examples  "Successful queries 89 out of
> 151queries"*
> Query:cube select measure2 from sample_cube where time_range_in(dt,
> '2014-06-24-23', '2014-06-25-00')
> 05 Dec 2017 10:03:15 [main] ERROR cliLogger - Exception for example query
> : "cube select measure2 from sample_cube where time_range_in(dt,
> '2014-06-24-23', '2014-06-25-00')"
> org.apache.lens.client.exceptions.LensAPIException: cube *cube11 Not
> found.*
>
>
>
> On Tue, Dec 5, 2017 at 12:29 PM, Raju Bairishetti <r...@apache.org> wrote:
>
>> Hi everyone,
>>
>> I propose the following RC to be released as official Apache Lens
>> 2.7.0
>> release.
>>
>> The commit id is d2b49929dd2af6a401a8ea6fa2d357c270a6890e:
>> https://git-wip-us.apache.org/repos/asf?p=lens.git;a=commit;h=d2b49929d
>>
>> This corresponds to the tag: apache-lens-2.7.0:
>> https://git-wip-us.apache.org/repos/asf?p=lens.git;a=tag;h=r
>> efs/tags/apache-lens-2.7.0
>>
>> Release archives (tar.gz/zip) signature and checksums are here:
>> https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.7.0-rc0/
>>
>> You can find the KEYS file here:
>> https://dist.apache.org/repos/dist/dev/lens/KEYS
>>
>> The release candidate consists of the following source distribution
>> archive
>> apache-lens-2.7.0-source-release.zip:
>> https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.7.
>> 0-rc0/apache-lens-2.7.0-source-release.zip
>>
>> In addition, the following supplementary binary distributions are provided
>> for user convenience at the same location: apache-lens-2.7.0-bin.tar.gz
>> https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.7.
>> 0-rc0/apache-lens-2.7.0-bin.tar.gz
>>
>> the licensing of bundled bits in the archives are documented at
>> https://cwiki.apache.org/confluence/display/LENS/Licensing+in+Apache+Lens
>>
>> Nexus staging url:
>> https://repository.apache.org/content/repositories/orgapachelens-1011/
>>
>> Release notes available at
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>> ctId=12315923=12336851
>>
>> Vote will be open for at least 72 hours
>>
>> [ ] +1 approve
>> [ ]  0  no opinion
>> [ ]  -1 disapprove (and reason why)
>>
>> +1 from my side for the release.
>>
>> For folks not familiar with vetting a release, please refer to
>>
>> http://incubator.apache.org/guides/releasemanagement.html#check-list
>>
>> --
>> Thanks,
>> Raju Bairishetti,
>> www.lazada.com
>>
>
>

Re: [VOTE] Release of Apache Lens 2.7.0

[Puneet Gupta]

Was able to
- download lens server binary
- validate the md5 hash
- run lens server and lens cli

*Facing issue while running examples  "Successful queries 89 out of
151queries"*
Query:cube select measure2 from sample_cube where time_range_in(dt,
'2014-06-24-23', '2014-06-25-00')
05 Dec 2017 10:03:15 [main] ERROR cliLogger - Exception for example query :
"cube select measure2 from sample_cube where time_range_in(dt,
'2014-06-24-23', '2014-06-25-00')"
org.apache.lens.client.exceptions.LensAPIException: cube *cube11 Not found.*



On Tue, Dec 5, 2017 at 12:29 PM, Raju Bairishetti  wrote:

> Hi everyone,
>
> I propose the following RC to be released as official Apache Lens 2.7.0
> release.
>
> The commit id is d2b49929dd2af6a401a8ea6fa2d357c270a6890e:
> https://git-wip-us.apache.org/repos/asf?p=lens.git;a=commit;h=d2b49929d
>
> This corresponds to the tag: apache-lens-2.7.0:
> https://git-wip-us.apache.org/repos/asf?p=lens.git;a=tag;h=
> refs/tags/apache-lens-2.7.0
>
> Release archives (tar.gz/zip) signature and checksums are here:
> https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.7.0-rc0/
>
> You can find the KEYS file here:
> https://dist.apache.org/repos/dist/dev/lens/KEYS
>
> The release candidate consists of the following source distribution archive
> apache-lens-2.7.0-source-release.zip:
> https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.7.
> 0-rc0/apache-lens-2.7.0-source-release.zip
>
> In addition, the following supplementary binary distributions are provided
> for user convenience at the same location: apache-lens-2.7.0-bin.tar.gz
> https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.7.
> 0-rc0/apache-lens-2.7.0-bin.tar.gz
>
> the licensing of bundled bits in the archives are documented at
> https://cwiki.apache.org/confluence/display/LENS/Licensing+in+Apache+Lens
>
> Nexus staging url:
> https://repository.apache.org/content/repositories/orgapachelens-1011/
>
> Release notes available at
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12315923=12336851
>
> Vote will be open for at least 72 hours
>
> [ ] +1 approve
> [ ]  0  no opinion
> [ ]  -1 disapprove (and reason why)
>
> +1 from my side for the release.
>
> For folks not familiar with vetting a release, please refer to
>
> http://incubator.apache.org/guides/releasemanagement.html#check-list
>
> --
> Thanks,
> Raju Bairishetti,
> www.lazada.com
>

[jira] [Commented] (LENS-1486) Disable test case testQueryAliveOnSessionClose

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260496#comment-16260496
 ] 

Puneet Gupta commented on LENS-1486:


+1

> Disable test case testQueryAliveOnSessionClose 
> ---
>
> Key: LENS-1486
> URL: https://issues.apache.org/jira/browse/LENS-1486
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Attachments: LENS-1486.patch
>
>
> TestQueryIndependenceFromSessionClose.testQueryAliveOnSessionClose is failing 
> in past few builds, commenting it temporarily to make the build pass. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1484) Lens Server pre commit build failing due to enunciate plugin

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1484:
---
Attachment: LENS-1484.patch

Simple patch. Uploading directly

> Lens Server pre commit build failing due to enunciate plugin
> 
>
> Key: LENS-1484
> URL: https://issues.apache.org/jira/browse/LENS-1484
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>    Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Attachments: LENS-1484.patch
>
>
> [ERROR] Failed to execute goal 
> com.webcohesion.enunciate:enunciate-maven-plugin:2.5.0:docs (default) on 
> project lens-server: freemarker.core._TemplateModelException: An error has 
> occurred when reading existing sub-variable "securityRoles"; see cause 
> exception! The type of the containing value was: extended_hash+string 
> (com.webcohesion.enunciate.modules.jaxrs.api.impl.MethodImpl wrapped into 
> f.e.b.StringModel)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1484) Lens Server pre commit build failing due to enunciate plugin

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1484:
---
Status: Patch Available  (was: Open)

> Lens Server pre commit build failing due to enunciate plugin
> 
>
> Key: LENS-1484
> URL: https://issues.apache.org/jira/browse/LENS-1484
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>    Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Attachments: LENS-1484.patch
>
>
> [ERROR] Failed to execute goal 
> com.webcohesion.enunciate:enunciate-maven-plugin:2.5.0:docs (default) on 
> project lens-server: freemarker.core._TemplateModelException: An error has 
> occurred when reading existing sub-variable "securityRoles"; see cause 
> exception! The type of the containing value was: extended_hash+string 
> (com.webcohesion.enunciate.modules.jaxrs.api.impl.MethodImpl wrapped into 
> f.e.b.StringModel)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (LENS-1484) Lens Server pre commit build failing due to enunciate plugin

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta reassigned LENS-1484:
--

Assignee: Puneet Gupta

> Lens Server pre commit build failing due to enunciate plugin
> 
>
> Key: LENS-1484
> URL: https://issues.apache.org/jira/browse/LENS-1484
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>    Reporter: Puneet Gupta
>Assignee: Puneet Gupta
>
> [ERROR] Failed to execute goal 
> com.webcohesion.enunciate:enunciate-maven-plugin:2.5.0:docs (default) on 
> project lens-server: freemarker.core._TemplateModelException: An error has 
> occurred when reading existing sub-variable "securityRoles"; see cause 
> exception! The type of the containing value was: extended_hash+string 
> (com.webcohesion.enunciate.modules.jaxrs.api.impl.MethodImpl wrapped into 
> f.e.b.StringModel)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (LENS-1484) Lens Server pre commit build failing due to enunciate plugin

[Puneet Gupta (JIRA)]

Puneet Gupta created LENS-1484:
--

 Summary: Lens Server pre commit build failing due to enunciate 
plugin
 Key: LENS-1484
 URL: https://issues.apache.org/jira/browse/LENS-1484
 Project: Apache Lens
  Issue Type: Bug
  Components: server
Reporter: Puneet Gupta


[ERROR] Failed to execute goal 
com.webcohesion.enunciate:enunciate-maven-plugin:2.5.0:docs (default) on 
project lens-server: freemarker.core._TemplateModelException: An error has 
occurred when reading existing sub-variable "securityRoles"; see cause 
exception! The type of the containing value was: extended_hash+string 
(com.webcohesion.enunciate.modules.jaxrs.api.impl.MethodImpl wrapped into 
f.e.b.StringModel)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 63665: Implementation for Jdbc driver cost

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63665/#review191056
---


Ship it!




Ship It!

- Puneet Gupta


On Nov. 15, 2017, 10:32 a.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63665/
> ---
> 
> (Updated Nov. 15, 2017, 10:32 a.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1483
> https://issues.apache.org/jira/browse/LENS-1483
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Jdbc driver cost has been hardcoded to zero currently in Lens code. This 
> makes it difficult to add more jdbc drivers which have different costs. Hence 
> there is a need for having a driver level implementation for calculating cost.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java 37eda42 
>   
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java
>  3c157ee 
>   
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/StaticCostCalculator.java
>  PRE-CREATION 
>   
> lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java
>  b5e73fd 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 0b4db9a 
>   lens-driver-hive/src/main/resources/hivedriver-default.xml a13d3b0 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
>  1261409 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
> 528f857 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
>  51abc96 
>   lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 5545fac 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
>  446e759 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  7fd487c 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java
>  eba8f0d 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java
>  9d7320a 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java
>  8c71c00 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTypeDecider.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTypeRangeConf.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/RangeBasedQueryCostTypeDecider.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/StaticQueryCost.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/RangeConf.java
>  43cc53c 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/MockQueryCostCalculator.java
>  fb4085e 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/TestFactPartitionBasedQueryCost.java
>  e047c91 
>   src/site/apt/admin/hivedriver-config.apt a9f020d 
>   src/site/apt/admin/jdbcdriver-config.apt eb56927 
> 
> 
> Diff: https://reviews.apache.org/r/63665/diff/15/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

Re: Review Request 63665: Implementation for Jdbc driver cost

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63665/#review191044
---




lens-cube/src/main/java/org/apache/lens/cube/query/cost/StaticCostCalculator.java
Lines 43 (patched)
<https://reviews.apache.org/r/63665/#comment268632>

Can we push this to constructor?



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java
Line 343 (original), 349 (patched)
<https://reviews.apache.org/r/63665/#comment268633>

Can we have a init() method that can do this and have a default constructor 
?



lens-driver-hive/src/main/resources/hivedriver-default.xml
Lines 171 (patched)
<https://reviews.apache.org/r/63665/#comment268639>

update description.



lens-driver-hive/src/main/resources/hivedriver-default.xml
Lines 176 (patched)
<https://reviews.apache.org/r/63665/#comment268634>

can we have it same as  default in code "LOW,0.0,HIGH"



lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java
Lines 395 (patched)
<https://reviews.apache.org/r/63665/#comment268635>

can we have common code in AbstractDriver ?



lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml
Lines 282 (patched)
<https://reviews.apache.org/r/63665/#comment268637>

update description.



lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml
Lines 288 (patched)
<https://reviews.apache.org/r/63665/#comment268638>

update description



lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml
Lines 293 (patched)
<https://reviews.apache.org/r/63665/#comment268636>

    can we have it same as default in code


- Puneet Gupta


On Nov. 15, 2017, 10:32 a.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63665/
> ---
> 
> (Updated Nov. 15, 2017, 10:32 a.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1483
> https://issues.apache.org/jira/browse/LENS-1483
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Jdbc driver cost has been hardcoded to zero currently in Lens code. This 
> makes it difficult to add more jdbc drivers which have different costs. Hence 
> there is a need for having a driver level implementation for calculating cost.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java 37eda42 
>   
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java
>  3c157ee 
>   
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/StaticCostCalculator.java
>  PRE-CREATION 
>   
> lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java
>  b5e73fd 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 0b4db9a 
>   lens-driver-hive/src/main/resources/hivedriver-default.xml a13d3b0 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
>  1261409 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
> 528f857 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
>  51abc96 
>   lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 5545fac 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
>  446e759 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  7fd487c 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java
>  2036dce 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java
>  eba8f0d 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java
>  9d7320a 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java
>  8c71c00 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTypeDecider.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTypeRangeConf.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/RangeBasedQueryCostTypeDecider.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/StaticQueryCost.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/RangeConf.java
>  4

Re: Review Request 63665: Implementation for Jdbc driver cost

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63665/#review191037
---




lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java
Lines 42 (patched)
<https://reviews.apache.org/r/63665/#comment268626>

can RangeBasedQueryCostTypeDecider class take string as argument in 
constructor instead of QueryCostTypeRangeConf



lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java
Lines 38 (patched)
<https://reviews.apache.org/r/63665/#comment268631>

Do we need to persist query cost at class level ?


- Puneet Gupta


On Nov. 15, 2017, 7:38 a.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63665/
> ---
> 
> (Updated Nov. 15, 2017, 7:38 a.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1483
> https://issues.apache.org/jira/browse/LENS-1483
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Jdbc driver cost has been hardcoded to zero currently in Lens code. This 
> makes it difficult to add more jdbc drivers which have different costs. Hence 
> there is a need for having a driver level implementation for calculating cost.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java 37eda42 
>   
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java
>  3c157ee 
>   
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/StaticCostCalculator.java
>  PRE-CREATION 
>   
> lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java
>  b5e73fd 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 0b4db9a 
>   lens-driver-hive/src/main/resources/hivedriver-default.xml a13d3b0 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
>  1261409 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
> 528f857 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
>  51abc96 
>   lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 5545fac 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
>  446e759 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  7fd487c 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java
>  2036dce 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java
>  eba8f0d 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java
>  9d7320a 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java
>  8c71c00 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTypeDecider.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTypeRangeConf.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/RangeBasedQueryCostTypeDecider.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/StaticQueryCost.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/RangeConf.java
>  43cc53c 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/TestFactPartitionBasedQueryCost.java
>  e047c91 
>   src/site/apt/admin/hivedriver-config.apt a9f020d 
>   src/site/apt/admin/jdbcdriver-config.apt eb56927 
> 
> 
> Diff: https://reviews.apache.org/r/63665/diff/11/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

Re: Review Request 63665: Implementation for Jdbc driver cost

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63665/#review190922
---




lens-cube/src/main/java/org/apache/lens/cube/query/cost/StaticCostCalculator.java
Lines 36 (patched)
<https://reviews.apache.org/r/63665/#comment268491>

Since this is a static cost and cost type per driver, We should try not to 
evaluate it each time from conf.



lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java
Lines 54 (patched)
<https://reviews.apache.org/r/63665/#comment268490>

Shoudl be call CostRangeQueryTypeDecider as 
RangeBasedQueryCostTypeDecider



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java
Lines 99 (patched)
<https://reviews.apache.org/r/63665/#comment268492>

Shoul we have default as  "LOW,0.0,HIGH" ?



lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java
Lines 143 (patched)
<https://reviews.apache.org/r/63665/#comment268493>

Who should create the instance of QueryCostTypeDecider . Driver or 
QueryCostCalculator ?



lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml
Lines 293 (patched)
<https://reviews.apache.org/r/63665/#comment268494>

Should we have default as LOW,0.0,HIGH ?



lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/CostRangeQueryTypeDecider.java
Lines 37 (patched)
<https://reviews.apache.org/r/63665/#comment268495>

The constructor can take the config string "LOW,0.0,HIGH" and 
costToQueryTypeRangeMap can be internal to the implementation of this class.



lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/CostToQueryTypeRangeConf.java
Lines 28 (patched)
<https://reviews.apache.org/r/63665/#comment268496>

Should we rename this class also? 
QueryCostTypeRangeConf



lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTypeDecider.java
Lines 29 (patched)
<https://reviews.apache.org/r/63665/#comment268497>

update comments


- Puneet Gupta


On Nov. 14, 2017, 6:25 a.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63665/
> ---
> 
> (Updated Nov. 14, 2017, 6:25 a.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1483
> https://issues.apache.org/jira/browse/LENS-1483
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Jdbc driver cost has been hardcoded to zero currently in Lens code. This 
> makes it difficult to add more jdbc drivers which have different costs. Hence 
> there is a need for having a driver level implementation for calculating cost.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java 37eda42 
>   
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java
>  3c157ee 
>   
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/StaticCostCalculator.java
>  PRE-CREATION 
>   
> lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java
>  b5e73fd 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 0b4db9a 
>   lens-driver-hive/src/main/resources/hivedriver-default.xml a13d3b0 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
> 528f857 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
>  51abc96 
>   lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 5545fac 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
>  446e759 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  7fd487c 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java
>  2036dce 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/CostRangeQueryTypeDecider.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/CostToQueryTypeRangeConf.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java
>  eba8f0d 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java
>  9d7320a 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java
>  8c71c00 
>   
> lens-server-api/src/main/java/org/apache

Re: Review Request 62773: Fix for column start and end times not working in Virtual facts [LENS-1480]

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62773/#review190687
---


Ship it!




Ship It!

- Puneet Gupta


On Nov. 10, 2017, 8:44 a.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62773/
> ---
> 
> (Updated Nov. 10, 2017, 8:44 a.m.)
> 
> 
> Review request for lens and Rajat Khandelwal.
> 
> 
> Bugs: LENS-1480
> https://issues.apache.org/jira/browse/LENS-1480
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Fix for column start times not working in Virtual facts
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> fd07bf2 
> 
> 
> Diff: https://reviews.apache.org/r/62773/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

Re: Report for November,2017

[Puneet Gupta]

+1

On Wed, Nov 8, 2017 at 5:27 PM, Amareshwari Sriramdasu <
amareshw...@apache.org> wrote:

> Hi,
>
> Have put November, 2017 report here -
> https://cwiki.apache.org/confluence/display/LENS/November%2C2017.
>
> Please review and let me know your comments.
>
> Thanks
> Amareshwari
>

Re: Review Request 63665: Implementation for Jdbc driver cost

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63665/#review190674
---




lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java
Lines 196 (patched)
<https://reviews.apache.org/r/63665/#comment268246>

This is unrelated to current JIRA .



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
Line 322 (original), 322 (patched)
<https://reviews.apache.org/r/63665/#comment268247>

Unrelated to JIRA LENS-1483. Please post in a separate request



lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java
Lines 389 (patched)
<https://reviews.apache.org/r/63665/#comment268249>

This code seems common for Hive and JDBC driver. Is it possible to move 
this to AbstarctDriver and use a common property ?



lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/StaticQueryCost.java
Lines 48 (patched)
<https://reviews.apache.org/r/63665/#comment268250>

is it possible to make  < 0.0, 0.0, >0.0 configureable   ?



lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/StaticQueryCost.java
Lines 60 (patched)
<https://reviews.apache.org/r/63665/#comment268251>

Can we have all common methods in a base abstract class AbstractQueryCost 
for StaticQueryCost and FactPartitionBasedQueryCost to extend it ?


- Puneet Gupta


On Nov. 8, 2017, 12:43 p.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63665/
> ---
> 
> (Updated Nov. 8, 2017, 12:43 p.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1483
> https://issues.apache.org/jira/browse/LENS-1483
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Jdbc driver cost has been hardcoded to zero currently in Lens code. This 
> makes it difficult to add more jdbc drivers which have different costs. Hence 
> there is a need for having a driver level implementation for calculating cost.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java 37eda42 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java
>  8b55985 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> fd07bf2 
>   
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/StaticCostCalculator.java
>  PRE-CREATION 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
> 528f857 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
>  51abc96 
>   lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 5545fac 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
>  446e759 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  7fd487c 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/StaticQueryCost.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/TestFactPartitionBasedQueryCost.java
>  e047c91 
>   src/site/apt/admin/jdbcdriver-config.apt eb56927 
> 
> 
> Diff: https://reviews.apache.org/r/63665/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

[jira] [Commented] (LENS-1425) Update 2.7 release documentation

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235261#comment-16235261
 ] 

Puneet Gupta commented on LENS-1425:


Under the incompatibility section , we can remove these 
LENS-968 (This is a new feature)  and 
LENS-1359 (LENS-1013 was actual incompatibility in driver hook which was 
released in lens 2.6)

> Update 2.7 release documentation
> 
>
> Key: LENS-1425
> URL: https://issues.apache.org/jira/browse/LENS-1425
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: build
>Reporter: Raju Bairishetti
>Assignee: Raju Bairishetti
>Priority: Major
> Fix For: 2.7
>
> Attachments: LENS-1425.patch
>
>
> Update the release documentation with 2.7 features



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 61881: Lens-1461:Lens services state are not persisted correctly

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/#review189401
---


Ship it!




Ship It!

- Puneet Gupta


On Oct. 26, 2017, 3:28 p.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61881/
> ---
> 
> (Updated Oct. 26, 2017, 3:28 p.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1461
> https://issues.apache.org/jira/browse/LENS-1461
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Persist process for Session service should not fail if any session in 
> invalid. Persist service should ignore these session and continue persisting 
> state of other session instead of failing.
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  b480d140 
> 
> 
> Diff: https://reviews.apache.org/r/61881/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

Re: Review Request 61881: Lens-1461:Lens services state are not persisted correctly

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/#review189292
---




lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
Lines 424 (patched)
<https://reviews.apache.org/r/61881/#comment266306>

This is not required. sessions List size should be enough .


- Puneet Gupta


On Oct. 26, 2017, 8:23 a.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61881/
> ---
> 
> (Updated Oct. 26, 2017, 8:23 a.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1461
> https://issues.apache.org/jira/browse/LENS-1461
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Persist process for Session service should not fail if any session in 
> invalid. Persist service should ignore these session and continue persisting 
> state of other session instead of failing.
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  b480d140 
> 
> 
> Diff: https://reviews.apache.org/r/61881/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

Re: Review Request 61881: Lens-1461:Lens services state are not persisted correctly

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/#review189274
---



Dont see the latest patch uploaded on review board .

- Puneet Gupta


On Oct. 17, 2017, 12:07 p.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61881/
> ---
> 
> (Updated Oct. 17, 2017, 12:07 p.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1461
> https://issues.apache.org/jira/browse/LENS-1461
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Persist process for Session service should not fail if any session in 
> invalid. Persist service should ignore these session and continue persisting 
> state of other session instead of failing.
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  b480d140 
> 
> 
> Diff: https://reviews.apache.org/r/61881/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

Re: Review Request 62773: Fix for column start and end times not working in Virtual facts [LENS-1480]

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62773/#review187742
---




lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
Lines 343 (patched)
<https://reviews.apache.org/r/62773/#comment264790>

Does it make sense to have this method in CubeVirtualFactTable ?



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
Lines 345 (patched)
<https://reviews.apache.org/r/62773/#comment264789>

Should we use org.apache.lens.cube.metadata.FactTable#isVirtualFact?


- Puneet Gupta


On Oct. 11, 2017, 10:50 a.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62773/
> ---
> 
> (Updated Oct. 11, 2017, 10:50 a.m.)
> 
> 
> Review request for lens and Rajat Khandelwal.
> 
> 
> Bugs: LENS-1480
> https://issues.apache.org/jira/browse/LENS-1480
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Fix for column start times not working in Virtual facts
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> fd07bf2 
> 
> 
> Diff: https://reviews.apache.org/r/62773/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

Re: Review Request 62773: Fix for column start and end times not working in Virtual facts [LENS-1480]

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62773/#review187521
---




lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
Line 332 (original), 338 (patched)
<https://reviews.apache.org/r/62773/#comment264531>

Can we extraxt this code into a separate method 
getSourceFactTableProperties(fact)


- Puneet Gupta


On Oct. 4, 2017, 2:54 p.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62773/
> ---
> 
> (Updated Oct. 4, 2017, 2:54 p.m.)
> 
> 
> Review request for lens and Rajat Khandelwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Fix for column start times not working in Virtual facts
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> fd07bf2 
> 
> 
> Diff: https://reviews.apache.org/r/62773/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

[jira] [Commented] (LENS-1478) Queries with partial data set as false lookahead not working

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171303#comment-16171303
 ] 

Puneet Gupta commented on LENS-1478:


+1

> Queries with partial data set as false lookahead not working
> 
>
> Key: LENS-1478
> URL: https://issues.apache.org/jira/browse/LENS-1478
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Attachments: LENS-1478.patch
>
>
> For queries with set lens.cube.query.fail.if.data.partial=false lookahead 
> queries partitions are not getting resolved and the being rewritten same as 
> input time_range_in function. This results query failure with syntax error.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 62377: LENS-1477 : Change default measure value to "0" instead of "0.0" in union queries

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62377/#review185541
---


Ship it!




Ship It!

- Puneet Gupta


On Sept. 18, 2017, 9:19 a.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62377/
> ---
> 
> (Updated Sept. 18, 2017, 9:19 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Change default measure value to "0" instead of "0.0" in union queries
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
> 553468f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 
> 0d512e4 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
> 35cb2b5 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java
>  9fbeb41 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeSegmentationRewriter.java
>  8a76f4a 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionAndJoinCandidates.java
>  ccc3bf4 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestVirtualFactQueries.java
>  94e836c 
> 
> 
> Diff: https://reviews.apache.org/r/62377/diff/1/
> 
> 
> Testing
> ---
> 
> All unit tests in lens-cube passed.
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

[jira] [Commented] (LENS-1476) Order By clause is not rewritten correctly when column is wrapped with function

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164370#comment-16164370
 ] 

Puneet Gupta commented on LENS-1476:


+1 for patch

> Order By clause is not rewritten correctly when column is wrapped with 
> function
> ---
>
> Key: LENS-1476
> URL: https://issues.apache.org/jira/browse/LENS-1476
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Attachments: LENS-1476.patch
>
>
> Order by clauses like to_date(datecol) is not not rewritten properly in the 
> final union query.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 62218: LENS-1475 : Override equals(Object obj) and hashcode() methods of SegmentationCandidate

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62218/#review185266
---


Ship it!




Ship It!

- Puneet Gupta


On Sept. 11, 2017, 11:50 a.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62218/
> ---
> 
> (Updated Sept. 11, 2017, 11:50 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1475
> https://issues.apache.org/jira/browse/LENS-1475
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Override equals(Object obj) and hashcode() methods of SegmentationCandidate
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/SegmentationCandidate.java 
> 055d6ef 
> 
> 
> Diff: https://reviews.apache.org/r/62218/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 62060: LENS-1471: JoinCandidate's children should not share same storage candidate

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62060/#review184519
---


Ship it!




Ship It!

- Puneet Gupta


On Sept. 4, 2017, 12:50 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62060/
> ---
> 
> (Updated Sept. 4, 2017, 12:50 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1471
> https://issues.apache.org/jira/browse/LENS-1471
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\]; 
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a 
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children 
> set exclusive measure phrase indices, and that is done via truncate method of 
> list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is 
> answering {{\[2,3\]}} measures, and since 
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering 
> no measures at all
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
>  1cff4a424fddb7e124531837ce29a5d8ed97d49c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> 27835b371c51579ae35d526fc6245f6cf5c7ffb4 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionCandidate.java 
> 510ea0c5b1edf1dd60b5380ba3b2a47844ed2219 
> 
> 
> Diff: https://reviews.apache.org/r/62060/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 61942: LENS-1467: CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61942/#review184254
---


Ship it!




Ship It!

- Puneet Gupta


On Aug. 30, 2017, 9:41 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61942/
> ---
> 
> (Updated Aug. 30, 2017, 9:41 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1467
> https://issues.apache.org/jira/browse/LENS-1467
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed 
> together, which is wrong.
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> 8b9583aa62ce3fc0ed94b2b849f12ee48fa16a9b 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java
>  494b08e3b04bcdfea3de449f3740589cc481ba38 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java 
> 866149641fbc2d00263fbe9679b1e89f5325e601 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeQueryContextTest.java 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61942/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 61942: LENS-1467: CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61942/#review184253
---


Ship it!




Ship It!

- Puneet Gupta


On Aug. 30, 2017, 9:41 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61942/
> ---
> 
> (Updated Aug. 30, 2017, 9:41 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1467
> https://issues.apache.org/jira/browse/LENS-1467
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed 
> together, which is wrong.
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> 8b9583aa62ce3fc0ed94b2b849f12ee48fa16a9b 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java
>  494b08e3b04bcdfea3de449f3740589cc481ba38 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java 
> 866149641fbc2d00263fbe9679b1e89f5325e601 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeQueryContextTest.java 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61942/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 61938: Fix for time_range_in clause not resolving in rewrite

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61938/#review184250
---


Ship it!




Ship It!

- Puneet Gupta


On Aug. 31, 2017, 7:27 a.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61938/
> ---
> 
> (Updated Aug. 31, 2017, 7:27 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Fix for time_range_in clause not resolving in rewrite
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> 2b1add3 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/DateFactory.java 
> 855f54a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> 0366e56 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> bc0fa2e 
>   lens-cube/src/test/resources/schema/cubes/base/testcube.xml 9d2bb02 
>   lens-cube/src/test/resources/schema/facts/summary5.xml PRE-CREATION 
>   lens-cube/src/test/resources/schema/storages/c98.xml PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61938/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

Re: Review Request 61938: Fix for time_range_in clause not resolving in rewrite

[Puneet Gupta]

> On Aug. 29, 2017, 10:26 a.m., Puneet Gupta wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
> > Lines 937 (patched)
> > <https://reviews.apache.org/r/61938/diff/1/?file=1806054#file1806054line937>
> >
> > We should make sure participatingUpdatePeriods does not have any update 
> > period that has zero partitions. Should line 536 " 
> > this.participatingUpdatePeriods.add(maxInterval);" be deleted ?
> 
> Rajitha R wrote:
> I tried do to this but test cases started failing.

Lets check this further.


- Puneet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61938/#review184040
---


On Aug. 30, 2017, 3:11 p.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61938/
> ---
> 
> (Updated Aug. 30, 2017, 3:11 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Fix for time_range_in clause not resolving in rewrite
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> 2b1add3 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/DateFactory.java 
> 855f54a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> 0366e56 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> bc0fa2e 
>   lens-cube/src/test/resources/schema/cubes/base/testcube.xml 9d2bb02 
>   lens-cube/src/test/resources/schema/facts/summary5.xml PRE-CREATION 
>   lens-cube/src/test/resources/schema/storages/c98.xml PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61938/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

Re: Review Request 61938: Fix for time_range_in clause not resolving in rewrite

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61938/#review184040
---




lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
Lines 937 (patched)
<https://reviews.apache.org/r/61938/#comment260041>

We should make sure participatingUpdatePeriods does not have any update 
period that has zero partitions. Should line 536 " 
this.participatingUpdatePeriods.add(maxInterval);" be deleted ?


- Puneet Gupta


On Aug. 28, 2017, 11:38 a.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61938/
> ---
> 
> (Updated Aug. 28, 2017, 11:38 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Fix for time_range_in clause not resolving in rewrite
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> 2b1add3 
> 
> 
> Diff: https://reviews.apache.org/r/61938/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

Re: Review Request 61881: Lens-1461:Lens services state are not persisted correctly

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/#review184038
---




lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
Lines 429 (patched)
<https://reviews.apache.org/r/61881/#comment260040>

Are we sure that ClientErrorException is the only execption we are seeing 
when this issue is hit? If we do not have logs to corroborate this, other run 
time execptions should be handled too



lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
Lines 430 (patched)
<https://reviews.apache.org/r/61881/#comment260039>

out.writeInt(SESSION_MAP.size()) would be wrong in this case . It should be 
SESSION_MAP.size()-1. How do we handle this ?


- Puneet Gupta


On Aug. 24, 2017, 8:11 a.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61881/
> ---
> 
> (Updated Aug. 24, 2017, 8:11 a.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1461
> https://issues.apache.org/jira/browse/LENS-1461
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Persist process for Session service should not fail if any session in 
> invalid. Persist service should ignore these session and continue persisting 
> state of other session instead of failing.
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  b480d14 
> 
> 
> Diff: https://reviews.apache.org/r/61881/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

Re: Review Request 61934: LENS-1464: One or two queued queries failing with ConcurrentModificationException on restart

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61934/#review184037
---


Ship it!




Ship It!

- Puneet Gupta


On Aug. 28, 2017, 12:52 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61934/
> ---
> 
> (Updated Aug. 28, 2017, 12:52 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1464
> https://issues.apache.org/jira/browse/LENS-1464
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Happens because of synchronizations issues. If two queries are simultaneously 
> launching, both try to add resources to hive driver. One of those queries can 
> fail then.
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  e70d2905a435f696f62239b1dc30eaa476dc229c 
> 
> 
> Diff: https://reviews.apache.org/r/61934/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 61934: LENS-1464: One or two queued queries failing with ConcurrentModificationException on restart

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61934/#review183920
---




lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
Line 3485 (original), 3485 (patched)
<https://reviews.apache.org/r/61934/#comment259976>

Should we do this at session level ?


- Puneet Gupta


On Aug. 28, 2017, 10:34 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61934/
> ---
> 
> (Updated Aug. 28, 2017, 10:34 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1464
> https://issues.apache.org/jira/browse/LENS-1464
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Happens because of synchronizations issues. If two queries are simultaneously 
> launching, both try to add resources to hive driver. One of those queries can 
> fail then.
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  e70d2905a435f696f62239b1dc30eaa476dc229c 
> 
> 
> Diff: https://reviews.apache.org/r/61934/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 61936: LENS-1465: Sync queries blocking threads

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61936/#review183914
---


Ship it!




Ship It!

- Puneet Gupta


On Aug. 28, 2017, 10:46 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61936/
> ---
> 
> (Updated Aug. 28, 2017, 10:46 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1465
> https://issues.apache.org/jira/browse/LENS-1465
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Sync queries taking more time than timeout are blocking threads due to a 
> deadlock. Each sync query is blocking one thread from jdbc execution pool and 
> one thread from query completion pool.
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  466fb25992dd3aa89813fe0bbd6aa65bead4d375 
> 
> 
> Diff: https://reviews.apache.org/r/61936/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 60155: LENS-1441: CandidateTableResolver should not add StorageCandidate if storage is not supported

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60155/#review178196
---


Ship it!




Ship It!

- Puneet Gupta


On June 16, 2017, 3:42 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60155/
> ---
> 
> (Updated June 16, 2017, 3:42 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1441
> https://issues.apache.org/jira/browse/LENS-1441
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> An optimization.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  f530650b212633651a6def772967e20638a78935 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> 0ef41f37a731bbaf58ba2c02eb67344ed2bad089 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
> b1654d149da8c034781f9841fed8fa56f87a659c 
> 
> 
> Diff: https://reviews.apache.org/r/60155/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Created] (LENS-1436) Lens Server's previously persisted state should be backed up before creating a new persisted state

[Puneet Gupta (JIRA)]

Puneet Gupta created LENS-1436:
--

 Summary: Lens Server's previously persisted state should be backed 
up before creating a new persisted state
 Key: LENS-1436
 URL: https://issues.apache.org/jira/browse/LENS-1436
 Project: Apache Lens
  Issue Type: Improvement
  Components: server
Reporter: Puneet Gupta


As of now lens server state is persisted up every 5 mins . The sate is also 
persisted when server is going down.

Consider a scenario where server is running out of memory or all its threads 
are blocked and writes a corrupt state while going down. In this case we lose 
all the queries and/or session info.

Proposal : before creating a server state snapshot, the previous snapshot 
(folder) should be backed up. Now we will have two persisted states, the 
current one and backed up state(5 mins old state). If the current state is 
corrupt, server can use the backed up state in which case we lose out only on 
last 5 mins of state.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59836: LENS-1434: Segmentation Candidate should have dynamic cost depending on facts picked in segmented cubes

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59836/#review177026
---


Ship it!




Ship It!

- Puneet Gupta


On June 6, 2017, 12:31 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59836/
> ---
> 
> (Updated June 6, 2017, 12:31 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1434
> https://issues.apache.org/jira/browse/LENS-1434
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Currently weight is fixed.
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 
> 0855ced92ebe0ab31056e4a9570f8b2edd0d6733 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> d064cdb31a56010c1541dfdfbb22dfe0afe0c1d1 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java 
> c4049cdcb29fb12a888ee65da2c4f9422348b110 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/LightestFactResolver.java 
> dd25f3e2bffa8c8a8dad84b068343c9b6575a384 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/SegmentationCandidate.java 
> a359d86d26d6377c2860e7f90ed05e33f4d76507 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> 79807977e9dbb52a04fb80dc1176874772b3cc2f 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java
>  c5351965a3e3966fad04e35ea84c119ac78de88d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionCandidate.java 
> 757a877034e4ab824c3c77c7045d5300dc2d19f6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 
> 9412f274d64de26b9f37619eb74ecee1ef9e94d4 
> 
> 
> Diff: https://reviews.apache.org/r/59836/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Commented] (LENS-1431) Data Availability Feature broken

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038641#comment-16038641
 ] 

Puneet Gupta commented on LENS-1431:


review Request : https://reviews.apache.org/r/59830

> Data Availability Feature broken 
> -
>
> Key: LENS-1431
> URL: https://issues.apache.org/jira/browse/LENS-1431
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Sushrut Meghshyam Ikhar
>Assignee: Sushrut Meghshyam Ikhar
> Attachments: LENS-1431.patch
>
>
> If data availability is enabled on a partition-coulmn-
> and availability for measure is > threshold still availability is shown as 
> FALSE



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59830: LENS-1431 Data-availability feature fixes

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59830/#review177011
---


Ship it!




Ship It!

- Puneet Gupta


On June 6, 2017, 7:51 a.m., Sushrut Ikhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59830/
> ---
> 
> (Updated June 6, 2017, 7:51 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1431
> https://issues.apache.org/jira/browse/LENS-1431
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Data Availability Feature broken after F2F Union code merge
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> 1e54f13 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/MockCompletenessChecker.java
>  76e81d5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> 7d1f80d 
>   lens-cube/src/test/resources/schema/cubes/base/basecube.xml 55099c8 
>   lens-cube/src/test/resources/schema/cubes/derived/der1.xml cf36cc7 
>   lens-cube/src/test/resources/schema/facts/testfact2_raw_base.xml 0bab461 
> 
> 
> Diff: https://reviews.apache.org/r/59830/diff/1/
> 
> 
> Testing
> ---
> 
> added test testQueryWithMeasureWithDataCompletenessTagWithDataAvailiability
> 
> 
> Thanks,
> 
> Sushrut Ikhar
> 
>

Re: Review Request 59803: LENS-1432 : Map Join tuning broken for this query leading to Map timeouts

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59803/#review176998
---


Ship it!




Ship It!

- Puneet Gupta


On June 6, 2017, 6:59 a.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59803/
> ---
> 
> (Updated June 6, 2017, 6:59 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1432
> https://issues.apache.org/jira/browse/LENS-1432
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> CubeQueryContext.getDimsToQuery() is empty, causing the problem.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/MultiCandidateQueryWriterContext.java
>  d57c027 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/QueryWriterContext.java 
> d55de1f 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 
> caf8770 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 
> 76ea77d 
> 
> 
> Diff: https://reviews.apache.org/r/59803/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 59803: LENS-1432 : Map Join tuning broken for this query leading to Map timeouts

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59803/#review176979
---




lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java
Line 50 (original), 49 (patched)
<https://reviews.apache.org/r/59803/#comment250545>

Should we check !ctx.getQueryWriterContext().getDimsToQuery().isEmpty() and 
ctx.getQueryWriterContext().getDimsToQuery()!=null


- Puneet Gupta


On June 5, 2017, 2:18 p.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59803/
> ---
> 
> (Updated June 5, 2017, 2:18 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1432
> https://issues.apache.org/jira/browse/LENS-1432
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> CubeQueryContext.getDimsToQuery() is empty, causing the problem.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/MultiCandidateQueryWriterContext.java
>  d57c027 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/QueryWriterContext.java 
> d55de1f 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java 
> caf8770 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 
> 76ea77d 
> 
> 
> Diff: https://reviews.apache.org/r/59803/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 59714: LENS-1428 : Common measures are getting repeated in UnionQuery for JoinCandidate

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59714/#review176907
---


Ship it!




Ship It!

- Puneet Gupta


On June 5, 2017, 8:51 a.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59714/
> ---
> 
> (Updated June 5, 2017, 8:51 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1428
> https://issues.apache.org/jira/browse/LENS-1428
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> For JoinCandidate if a measure is answerable by its children, getting 
> projected in both. Instead the measure should be projected in one of the 
> children and default measure i.e 0.0 for the other.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  b5c4c89 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> 47bce65 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java 
> 038d689 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> 1e54f13 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 
> 6c0d91a 
> 
> 
> Diff: https://reviews.apache.org/r/59714/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

[jira] [Commented] (LENS-1429) Queries failing intermittently with NO_REF_COL_AVAILABLE

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036867#comment-16036867
 ] 

Puneet Gupta commented on LENS-1429:


+1

> Queries failing intermittently with NO_REF_COL_AVAILABLE
> 
>
> Key: LENS-1429
> URL: https://issues.apache.org/jira/browse/LENS-1429
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Attachments: LENS-1429.patch
>
>
> Have seen queries failing intermittently with below error.
> {CODE}
> 16 May 2017 11:59:39 [5af8e7ad-b9d7-44db-abdf-d8a28bdb9f3c] 
> [f38a238e-abcb-4168-a052-7114cee1c3a6 estimate-128] WARN  
> org.apache.lens.server.rewrite.RewriteUtil - Driver : hive/prod  Skipped for 
> the query rewriting due to
> org.apache.lens.server.api.error.LensException: 
> NO_REF_COL_AVAILABLE[my_ref_col]
> at 
> org.apache.lens.cube.parse.DenormalizationResolver$DenormalizationContext.pickColumnsForTable(DenormalizationResolver.java:227)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at 
> org.apache.lens.cube.parse.DenormalizationResolver$DenormalizationContext.rewriteDenormctx(DenormalizationResolver.java:150)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at 
> org.apache.lens.cube.parse.DimHQLContext.addDenormDims(DimHQLContext.java:119)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at 
> org.apache.lens.cube.parse.MultiCandidateQueryWriterContext.addDenormDims(MultiCandidateQueryWriterContext.java:56)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at 
> org.apache.lens.cube.parse.CubeQueryContext.getQueryWriter(CubeQueryContext.java:927)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at 
> org.apache.lens.cube.parse.CubeQueryContext.toHQL(CubeQueryContext.java:947) 
> ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at 
> org.apache.lens.server.rewrite.RewriteUtil$DriverRewriterRunnable.run(RewriteUtil.java:396)
>  ~[classes/:na]
> at 
> org.apache.lens.server.query.QueryExecutionServiceImpl$RewriteEstimateRunnable.run(QueryExecutionServiceImpl.java:1855)
>  [classes/:na]
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
> [na:1.8.0_40]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> [na:1.8.0_40]
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [na:1.8.0_40]
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [na:1.8.0_40]
> at java.lang.Thread.run(Thread.java:745) [na:1.8.0_40]
> {CODE}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59714: LENS-1428 : Common measures are getting repeated in UnionQuery for JoinCandidate

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59714/#review176900
---




lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java
Lines 359 (patched)
<https://reviews.apache.org/r/59714/#comment250441>

Should we rename the method to decideMeasurePhraseToAnswer and  parameter 
to measurePhraseIndices ? 
Also please add method level comments



lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java
Lines 833 (patched)
<https://reviews.apache.org/r/59714/#comment250442>

Can we leave a comment in code why this is needed.


- Puneet Gupta


On June 1, 2017, 12:51 p.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59714/
> ---
> 
> (Updated June 1, 2017, 12:51 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1428
> https://issues.apache.org/jira/browse/LENS-1428
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> For JoinCandidate if a measure is answerable by its children, getting 
> projected in both. Instead the measure should be projected in one of the 
> children and default measure i.e 0.0 for the other.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  b5c4c89 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> 47bce65 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java 
> 038d689 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> 1e54f13 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 
> 6c0d91a 
> 
> 
> Diff: https://reviews.apache.org/r/59714/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

[jira] [Created] (LENS-1426) Support max limit for "timeoutmillis" in EXECUTE_WITH_TIMEOUT option

[Puneet Gupta (JIRA)]

Puneet Gupta created LENS-1426:
--

 Summary: Support max limit for "timeoutmillis" in 
EXECUTE_WITH_TIMEOUT option
 Key: LENS-1426
 URL: https://issues.apache.org/jira/browse/LENS-1426
 Project: Apache Lens
  Issue Type: Improvement
  Components: server
Reporter: Puneet Gupta


We can set the max to 5 mins and if a user sets the timeoutmillis > 5 mins , 
this api can throw an exception. 

Reason : this is a blocking call and blocks a request thread on server. Long 
timeoutmillis values can cause DOS by blocking all the request threads 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (LENS-981) Add Memory gatekeepers for InMemoryResultSet to prevent any OOM on lens server

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta reassigned LENS-981:
-

Assignee: Lavkesh Lahngir  (was: Puneet Gupta)

> Add Memory gatekeepers for InMemoryResultSet to prevent any OOM on lens server
> --
>
> Key: LENS-981
> URL: https://issues.apache.org/jira/browse/LENS-981
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>    Reporter: Puneet Gupta
>Assignee: Lavkesh Lahngir
> Fix For: 2.7
>
>
> In Some cases operations on InMemoryResultSet can result is high memory usage 
> on LensServer 
> 1. InMemoryResultSet.toQueryResult()  is done for a huge result
> 2. lens.query.prefetch.inmemory.resultset.rows = Huge Number . 
> In both cases we need to have some gate keeping as these features can be 
> accessed/configured by users 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59048: Add Memory gatekeepers for InMemoryResultSet to prevent any OOM on lens server

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59048/#review175066
---




lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java
Line 58 (original), 59 (patched)
<https://reviews.apache.org/r/59048/#comment248411>

OK


- Puneet Gupta


On May 8, 2017, 12:44 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59048/
> ---
> 
> (Updated May 8, 2017, 12:44 p.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: lens-981
> https://issues.apache.org/jira/browse/lens-981
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> See LENS-981
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/lens-errors.conf 43de1e9 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  7fd487c 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java
>  535065d 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java
>  805b0c1 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java
>  774f1ee 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensServerAPIErrorCode.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 
> 2a34c68 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  e70d290 
>   lens-server/src/main/resources/lensserver-default.xml 28b1db2 
> 
> 
> Diff: https://reviews.apache.org/r/59048/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Report for May,2017

[Puneet Gupta]

Should we mention Lens-981 (Add Memory gatekeepers for InMemoryResultSet to
prevent any OOM on lens server) also ?

Other than that +1 .


Thanks,
Puneet Gupta

On Tue, May 16, 2017 at 10:16 AM, amareshwarisr . <amareshw...@gmail.com>
wrote:

> Hi all,
>
> Seems I'm left with only one day to update report. Here is the draft -
> https://cwiki.apache.org/confluence/display/LENS/May%2C2017. Please review
> and let me know if there are any comments.
>
> If all is well, will update report by EOD.
>
> Thanks
> Amareshwari
>

-- 
_
The information contained in this communication is intended solely for the 
use of the individual or entity to whom it is addressed and others 
authorized to receive it. It may contain confidential or legally privileged 
information. If you are not the intended recipient you are hereby notified 
that any disclosure, copying, distribution or taking any action in reliance 
on the contents of this information is strictly prohibited and may be 
unlawful. If you have received this communication in error, please notify 
us immediately by responding to this email and then delete it from your 
system. The firm is neither liable for the proper and complete transmission 
of the information contained in this communication nor for any delay in its 
receipt.

Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test cases [Lens-1412]

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/#review175056
---



partial review


lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java
Lines 46 (patched)
<https://reviews.apache.org/r/58796/#comment248397>

Second param type can be FactTable



lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java
Lines 51 (patched)
<https://reviews.apache.org/r/58796/#comment248398>

This is redundant.



lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java
Lines 94 (patched)
<https://reviews.apache.org/r/58796/#comment248395>

Can this also return a Set ? It will be faster to do contains opeartion on 
a set.



lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java
Lines 133 (patched)
<https://reviews.apache.org/r/58796/#comment248399>

What happens if
1. VFT start time is < FT start time ?
2. VFT has no start time defined but FT has start time defined ?



lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java
Lines 167 (patched)
<https://reviews.apache.org/r/58796/#comment248400>

Should we call this getSourceFactName()? 
In case of CFT it will return getName(). In case of VFT it will return 
sourceCubeFactTable.getName()



lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java
Lines 73 (patched)
<https://reviews.apache.org/r/58796/#comment248396>





lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
Lines 200 (patched)
<https://reviews.apache.org/r/58796/#comment248401>

This method should not be needed since FactTable interface has a similar 
method.



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
Line 607 (original), 602 (patched)
<https://reviews.apache.org/r/58796/#comment248402>

Should we create an interface for AbstractCubeTable say CubeTable and 
FactTabe interface should extend CubeTable interface ? This will prevent all 
typecasting to CubeFactTable. [Optional]



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java
Lines 136-152 (patched)
<https://reviews.apache.org/r/58796/#comment248403>

should we optimize this and reduce if checks ?


- Puneet Gupta


On May 15, 2017, 1:38 p.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58796/
> ---
> 
> (Updated May 15, 2017, 1:38 p.m.)
> 
> 
> Review request for lens, Rajat Khandelwal and Puneet Gupta.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> CRUD changes and Unit test cases for Virtual Fact
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/cube-0.1.xsd 8158e6d 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 
> 67aaff8 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
> 88bc1fc 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  b5c4c89 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java
>  PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java 
> e1e3d16 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 
> 88500fd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> 40f766b 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 
> 1e3cef3 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  a8d6fbd 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 
> 6ba46d6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 
> 43510dd 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> 1e54f13 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java
>  730b802 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
> 291712b 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 
> 42e32cb 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
>  a76ef13 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> 2f300d3 
>   lens-cube/src/test/java/org/apache/lens/cube/

Re: Review Request 59048: Add Memory gatekeepers for InMemoryResultSet to prevent any OOM on lens server

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59048/#review174926
---




lens-api/src/main/resources/lens-errors.conf
Lines 457 (patched)
<https://reviews.apache.org/r/59048/#comment248210>

Can we change to 
"Rows in the result set exceeded the maximum allowed number of rows %d"



lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
Lines 1054 (patched)
<https://reviews.apache.org/r/59048/#comment248209>

Can we add test case to check the max limit ?



lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java
Line 58 (original), 59 (patched)
<https://reviews.apache.org/r/59048/#comment248211>

Should we have this in InMemory result Set construtor instead or get it 
from a static method (since this is a server level config and should not be 
overridable via query or session params) ? Open to discussion ...



lens-server/src/main/resources/lensserver-default.xml
Lines 311 (patched)
<https://reviews.apache.org/r/59048/#comment248206>

Can we add "Max" in the name of this property



lens-server/src/main/resources/lensserver-default.xml
Lines 313 (patched)
<https://reviews.apache.org/r/59048/#comment248208>

Can we update to 

"This property controls the maximum number of rows allowed for an InMemory 
result. This propertly helps in keeping a tab on memory foortprint of lens 
server. Persistent resultset is suggested for results with size greater than 
this value."


- Puneet Gupta


On May 8, 2017, 12:44 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59048/
> ---
> 
> (Updated May 8, 2017, 12:44 p.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: lens-981
> https://issues.apache.org/jira/browse/lens-981
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> See LENS-981
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/lens-errors.conf 43de1e9 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  7fd487c 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java
>  535065d 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java
>  805b0c1 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java
>  774f1ee 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensServerAPIErrorCode.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 
> 2a34c68 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  e70d290 
>   lens-server/src/main/resources/lensserver-default.xml 28b1db2 
> 
> 
> Diff: https://reviews.apache.org/r/59048/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Volunteers for 2.7 release

[Puneet Gupta]

Thanks Raju :-).


On Tue, May 9, 2017 at 1:51 PM, Raju Bairishetti  wrote:

> Hi,
>I can volunteer for managing the release.
>
> On Mon, May 8, 2017 at 9:18 AM, Amareshwari Sriramdasu <
> amareshw...@apache.org> wrote:
>
> > Hi,
> >
> > Now that we have major features like fact to fact union and cube
> > segmentation checked in, any volunteers for managing the release?
> >
> > Thanks
> >
>
>
>
> --
>
> --
> Thanks,
> Raju Bairishetti,
> www.lazada.com
>

-- 
_
The information contained in this communication is intended solely for the 
use of the individual or entity to whom it is addressed and others 
authorized to receive it. It may contain confidential or legally privileged 
information. If you are not the intended recipient you are hereby notified 
that any disclosure, copying, distribution or taking any action in reliance 
on the contents of this information is strictly prohibited and may be 
unlawful. If you have received this communication in error, please notify 
us immediately by responding to this email and then delete it from your 
system. The firm is neither liable for the proper and complete transmission 
of the information contained in this communication nor for any delay in its 
receipt.

Re: Review Request 58796: CRUD changes for Virtual Fact and Unit test cases [Lens-1412]

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58796/#review173575
---



Partial Review.


lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
Lines 382 (patched)
<https://reviews.apache.org/r/58796/#comment246568>





lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
Lines 386 (patched)
<https://reviews.apache.org/r/58796/#comment246571>





lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java
Lines 229-235 (patched)
<https://reviews.apache.org/r/58796/#comment247266>

Can we move these methods else where (may be deafult methods in FactTable 
interface) as they are specific to tables that have a cube and not common to 
all the tables (example Dimensions, Storage).



lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
Lines 94 (patched)
<https://reviews.apache.org/r/58796/#comment247268>

Should we call it factToVirtualFactsMapping ?



lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
Lines 98 (patched)
<https://reviews.apache.org/r/58796/#comment247269>

Should we call this virtualFactToFactMapping ?



lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java
Lines 29 (patched)
<https://reviews.apache.org/r/58796/#comment247265>

author name needs to be removed .


- Puneet Gupta


On May 8, 2017, 6:08 a.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58796/
> ---
> 
> (Updated May 8, 2017, 6:08 a.m.)
> 
> 
> Review request for lens, Rajat Khandelwal and Puneet Gupta.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> CRUD changes and Unit test cases for Virtual Fact
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/cube-0.1.xsd 68ccc13 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 
> 67aaff8 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
> e00122d 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  b5c4c89 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java 
> 6dd35b3 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java
>  PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java 
> e1e3d16 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 
> 88500fd 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> 599027f 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 
> 1e3cef3 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  6d61f1f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 
> b9ff0ef 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> c63c4c0 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/QueriedPhraseContext.java 
> 310a655 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> 95e3c95 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
> 10c3bbe 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
>  3a17499 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> 033264c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> bab1080 
>   lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION 
>   lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java
>  28b9d22 
>   
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
>  194b380 
>   
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java
>  7451aa9 
>   
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
>  6d32d23 
> 
> 
> Diff: https://reviews.apache.org/r/58796/diff/3/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> 

Re: Review Request 58986: LENS-1418: LensClient is not thread safe

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58986/#review174017
---


Ship it!




Ship It!

- Puneet Gupta


On May 5, 2017, 11:17 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58986/
> ---
> 
> (Updated May 5, 2017, 11:17 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1418
> https://issues.apache.org/jira/browse/LENS-1418
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Using one lens client to fire two queries in two threads results in 
> discrepencies. LensClient has a {{Map<QueryHandle, LensStatement>}} and also 
> has a cached instance of {{LensStatement}}. When two threads fire queries, 
> both use the same statement object. {{LensStatement}} object in turn caches 
> {{LensQuery}} Object. So whichever thread fired query last is the last one to 
> set lens query inside statement causing 
> {{LensClient.getStatement().getQuery()}} to return that query object for all 
> threads.
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> e1eaae5bde4718dc91982506a6b8619ff9872225 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java 
> e9367988fa780ed0ca3e2a2698226e43c011777f 
>   src/site/apt/user/cli.apt caffda7d60f3001883e4922096807fe07a939bab 
> 
> 
> Diff: https://reviews.apache.org/r/58986/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 58986: LENS-1418: LensClient is not thread safe

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58986/#review174011
---




lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java
Lines 67 (patched)
<https://reviews.apache.org/r/58986/#comment247108>

Is this required ?



lens-regression/src/main/java/org/apache/lens/regression/util/Util.java
Lines 107 (patched)
<https://reviews.apache.org/r/58986/#comment247105>

Is this needed ?


- Puneet Gupta


On May 5, 2017, 8:22 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58986/
> ---
> 
> (Updated May 5, 2017, 8:22 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1418
> https://issues.apache.org/jira/browse/LENS-1418
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Using one lens client to fire two queries in two threads results in 
> discrepencies. LensClient has a {{Map<QueryHandle, LensStatement>}} and also 
> has a cached instance of {{LensStatement}}. When two threads fire queries, 
> both use the same statement object. {{LensStatement}} object in turn caches 
> {{LensQuery}} Object. So whichever thread fired query last is the last one to 
> set lens query inside statement causing 
> {{LensClient.getStatement().getQuery()}} to return that query object for all 
> threads.
> 
> 
> Diffs
> -
> 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java 
> e9367988fa780ed0ca3e2a2698226e43c011777f 
>   
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java
>  2370f3e8e2ce1dc4fa95cbce716355a7cf75a2d8 
>   lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 
> 80ba912f43de4686f27732c54647a715f0514387 
>   src/site/apt/user/cli.apt caffda7d60f3001883e4922096807fe07a939bab 
> 
> 
> Diff: https://reviews.apache.org/r/58986/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>