[
https://issues.apache.org/jira/browse/SOLR-11934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591808#comment-16591808
]
David Smiley commented on SOLR-11934:
-
+1 to "change the configs to set the level of these classes to
[
https://issues.apache.org/jira/browse/LUCENE-8465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591142#comment-16591142
]
David Smiley commented on LUCENE-8465:
--
Nice. If you're in the mood, you might also want to strip
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590297#comment-16590297
]
David Smiley commented on SOLR-12519:
-
Next time I suggest pushing a new commit to the PR so that
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589179#comment-16589179
]
David Smiley commented on SOLR-12519:
-
To be clear, the current logic has the effect of index order
[
https://issues.apache.org/jira/browse/SOLR-12685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589082#comment-16589082
]
David Smiley commented on SOLR-12685:
-
bq. This ticket incorporates it, since it should return child
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588972#comment-16588972
]
David Smiley commented on SOLR-12519:
-
I presume you hit this error when running a test in IntelliJ.
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588354#comment-16588354
]
David Smiley commented on SOLR-12519:
-
Yetus thought the patch should be applied to the branch of the
[
https://issues.apache.org/jira/browse/SOLR-12673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587883#comment-16587883
]
David Smiley commented on SOLR-12673:
-
The problem with "frange" is that it doesn't leverage the
[
https://issues.apache.org/jira/browse/SOLR-12593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587858#comment-16587858
]
David Smiley commented on SOLR-12593:
-
Either completely remove
[
https://issues.apache.org/jira/browse/SOLR-12685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587640#comment-16587640
]
David Smiley commented on SOLR-12685:
-
Is this a duplicate of SOLR-9006? If so, it's not quite clear
[
https://issues.apache.org/jira/browse/SOLR-6700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley closed SOLR-6700.
--
> ChildDocTransformer doesn't return correct children after updating and
> optimising solr index
>
[
https://issues.apache.org/jira/browse/SOLR-6700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-6700.
Resolution: Not A Bug
Jan's right; this isn't a bug. I'm closing this issue. Solr's has
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-12519:
Attachment: SOLR-12519.patch
> Support Deeply Nested Docs In Child Documents Transformer
>
[
https://issues.apache.org/jira/browse/SOLR-12593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586340#comment-16586340
]
David Smiley commented on SOLR-12593:
-
Honestly I don't know about their usages in the wild (I could
[
https://issues.apache.org/jira/browse/SOLR-12593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586285#comment-16586285
]
David Smiley commented on SOLR-12593:
-
Instead of a new issue, I think you could add onto SOLR-12591
[
https://issues.apache.org/jira/browse/SOLR-12593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586245#comment-16586245
]
David Smiley commented on SOLR-12593:
-
Lets create a new issue to modify the \_default configSet's
[
https://issues.apache.org/jira/browse/SOLR-12652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585900#comment-16585900
]
David Smiley commented on SOLR-12652:
-
Thanks Peter! Patch looks fine. What do you think of
[
https://issues.apache.org/jira/browse/SOLR-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585880#comment-16585880
]
David Smiley commented on SOLR-12677:
-
I assume from the title you mean for labelled child documents
[
https://issues.apache.org/jira/browse/SOLR-12593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584974#comment-16584974
]
David Smiley commented on SOLR-12593:
-
I have not. I'm glad you're interested!
> Remove date
[
https://issues.apache.org/jira/browse/SOLR-12441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582577#comment-16582577
]
David Smiley commented on SOLR-12441:
-
I just noticed UpdateProcessorTestBase. If we have to work on
[
https://issues.apache.org/jira/browse/SOLR-7700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley closed SOLR-7700.
--
> NPE on spatial RPT field
>
>
> Key: SOLR-7700
>
[
https://issues.apache.org/jira/browse/SOLR-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-3977:
---
Issue Type: Bug (was: New Feature)
Changing to a bug; arguably *all* fields ought to support this
[
https://issues.apache.org/jira/browse/SOLR-7700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-7700.
Resolution: Duplicate
> NPE on spatial RPT field
>
>
>
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581158#comment-16581158
]
David Smiley commented on SOLR-12625:
-
Little review
* Overall I'm loving it
*
[
https://issues.apache.org/jira/browse/SOLR-12591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-12591:
Attachment: SOLR-12591.patch
> Ensure ParseDateFieldUpdateProcessorFactory can be used instead of
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579839#comment-16579839
]
David Smiley commented on SOLR-12519:
-
bq. Should the "limit" feature be addressed in this ticket?
[
https://issues.apache.org/jira/browse/LUCENE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578835#comment-16578835
]
David Smiley commented on LUCENE-8286:
--
Actually before continuing with any of that, I think the PR
[
https://issues.apache.org/jira/browse/LUCENE-8446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved LUCENE-8446.
--
Resolution: Fixed
Fix Version/s: 7.5
> UnifiedHighlighter DefaultPassageFormatter
[
https://issues.apache.org/jira/browse/LUCENE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578802#comment-16578802
]
David Smiley commented on LUCENE-8286:
--
Made substantial progress to the PR:
{noformat}
LUCENE-8286
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578554#comment-16578554
]
David Smiley commented on SOLR-12361:
-
Okay; there are really a set of issues that are all related
[
https://issues.apache.org/jira/browse/SOLR-12591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577197#comment-16577197
]
David Smiley commented on SOLR-12591:
-
[
https://issues.apache.org/jira/browse/SOLR-12591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576661#comment-16576661
]
David Smiley commented on SOLR-12591:
-
"lenient" boolean can be global to the URP (spanning formats).
[
https://issues.apache.org/jira/browse/LUCENE-8452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576393#comment-16576393
]
David Smiley commented on LUCENE-8452:
--
For WKT, there's already parsing in Spatial4J, a dependency
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575754#comment-16575754
]
David Smiley commented on SOLR-12625:
-
Sounds good. Looking forward to the next patch. This'll be a
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575751#comment-16575751
]
David Smiley commented on SOLR-12519:
-
[~moshebla] I pushed a feature branch, as you can see. I took
David Smiley created SOLR-12652:
---
Summary: SolrMetricManager.overridableRegistryName should be
removed; it doesn't work
Key: SOLR-12652
URL: https://issues.apache.org/jira/browse/SOLR-12652
Project:
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575213#comment-16575213
]
David Smiley edited comment on SOLR-12625 at 8/9/18 5:54 PM:
-
{quote}1>
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575213#comment-16575213
]
David Smiley commented on SOLR-12625:
-
{quote}1> making the code convert to native types and have a
[
https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574834#comment-16574834
]
David Smiley commented on SOLR-12638:
-
I could have been more clear. The update log is keyed by the
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574271#comment-16574271
]
David Smiley commented on SOLR-12625:
-
bq. docFetcher is in the SolrIndexSearcher and can interleave
[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573893#comment-16573893
]
David Smiley commented on SOLR-12625:
-
Thanks for filing this Erick. I like some of what you did but
[
https://issues.apache.org/jira/browse/SOLR-11078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-11078.
-
Resolution: Won't Fix
Closing as Won't Fix -- that's the effective reality. It can be re-opened
[
https://issues.apache.org/jira/browse/SOLR-12632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573806#comment-16573806
]
David Smiley commented on SOLR-12632:
-
bq. other than the workaround: use a string field for those
[
https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573481#comment-16573481
]
David Smiley commented on SOLR-12638:
-
Yeah something like that. This feature you propose bares a
[
https://issues.apache.org/jira/browse/SOLR-12630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573404#comment-16573404
]
David Smiley commented on SOLR-12630:
-
Although not a strict alternative, I've been interested in
[
https://issues.apache.org/jira/browse/SOLR-12630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573303#comment-16573303
]
David Smiley commented on SOLR-12630:
-
{quote}Perhaps using the nested update URP we could add the
[
https://issues.apache.org/jira/browse/SOLR-12591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572160#comment-16572160
]
David Smiley commented on SOLR-12591:
-
Oh awesome; I'm glad you're interested in it Bar. I have not
David Smiley created SOLR-12633:
---
Summary: JSON Loader: remove anonChildDoc option
Key: SOLR-12633
URL: https://issues.apache.org/jira/browse/SOLR-12633
Project: Solr
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/SOLR-12485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-12485.
-
Resolution: Fixed
Fix Version/s: 7.5
Thanks Moshe.
BTW while crafting the CHANGES.txt
[
https://issues.apache.org/jira/browse/SOLR-12630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571925#comment-16571925
]
David Smiley commented on SOLR-12630:
-
The internal {{_ROOT_}} field and other nested doc fields
[
https://issues.apache.org/jira/browse/SOLR-12243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571896#comment-16571896
]
David Smiley commented on SOLR-12243:
-
{quote}About the test in Solr: I am not happy with the test
[
https://issues.apache.org/jira/browse/SOLR-12586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-12586:
Description:
We're using Joda Time, a dependency in a couple places. Now that we are on
Java 8,
[
https://issues.apache.org/jira/browse/SOLR-12586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley reassigned SOLR-12586:
---
Resolution: Fixed
Assignee: David Smiley
Fix Version/s: master (8.0)
Thanks
[
https://issues.apache.org/jira/browse/LUCENE-8438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571744#comment-16571744
]
David Smiley commented on LUCENE-8438:
--
Nice job Dawid! It'll be nice to see RAMDirectory go away
[
https://issues.apache.org/jira/browse/LUCENE-8446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568754#comment-16568754
]
David Smiley commented on LUCENE-8446:
--
I pulled these two changes out of LUCENE-8286 so they don't
[
https://issues.apache.org/jira/browse/LUCENE-8446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated LUCENE-8446:
-
Attachment: LUCENE-8446.patch
> UnifiedHighlighter DefaultPassageFormatter should merge
David Smiley created LUCENE-8446:
Summary: UnifiedHighlighter DefaultPassageFormatter should merge
overlapping offsets
Key: LUCENE-8446
URL: https://issues.apache.org/jira/browse/LUCENE-8446
Project:
[
https://issues.apache.org/jira/browse/SOLR-12617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568723#comment-16568723
]
David Smiley commented on SOLR-12617:
-
Shouldn't the license & notice file be removed too?
> Remove
[
https://issues.apache.org/jira/browse/LUCENE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated LUCENE-8286:
-
Attachment: (was: LUCENE-8286.patch)
> UnifiedHighlighter should support the new
[
https://issues.apache.org/jira/browse/SOLR-12485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley reassigned SOLR-12485:
---
Assignee: David Smiley
> Xml loader should save the relationship of children
>
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565364#comment-16565364
]
David Smiley commented on SOLR-12519:
-
That sounds useful – definitely a separate issue. Feel free
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561432#comment-16561432
]
David Smiley commented on SOLR-12519:
-
I see what you're saying... though some apps/use-cases won't
[
https://issues.apache.org/jira/browse/SOLR-12586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561390#comment-16561390
]
David Smiley commented on SOLR-12586:
-
Thanks for volunteering in this maintenance task!
bq. Would I
[
https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558426#comment-16558426
]
David Smiley commented on LUCENE-8369:
--
Thanks for your support [~aw]!
> Remove the spatial module
David Smiley created SOLR-12593:
---
Summary: Remove date parsing functionality from extraction contrib
Key: SOLR-12593
URL: https://issues.apache.org/jira/browse/SOLR-12593
Project: Solr
Issue
David Smiley created SOLR-12591:
---
Summary: Ensure ParseDateFieldUpdateProcessorFactory can be used
instead of ExtractionDateUtil
Key: SOLR-12591
URL: https://issues.apache.org/jira/browse/SOLR-12591
[
https://issues.apache.org/jira/browse/SOLR-12593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-12593:
Fix Version/s: master (8.0)
> Remove date parsing functionality from extraction contrib
>
[
https://issues.apache.org/jira/browse/SOLR-12561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley closed SOLR-12561.
---
> Port ExtractionDateUtil to java.time API
>
>
>
[
https://issues.apache.org/jira/browse/LUCENE-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554564#comment-16554564
]
David Smiley commented on LUCENE-8426:
--
I'm not sure what the semantics of a protected class might
David Smiley created SOLR-12586:
---
Summary: Replace use of Joda Time with Java 8 java.time
Key: SOLR-12586
URL: https://issues.apache.org/jira/browse/SOLR-12586
Project: Solr
Issue Type:
[
https://issues.apache.org/jira/browse/SOLR-12561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-12561:
Attachment: SOLR-12561.patch
> Port ExtractionDateUtil to java.time API
>
[
https://issues.apache.org/jira/browse/SOLR-11299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552252#comment-16552252
]
David Smiley commented on SOLR-11299:
-
RE CDCR: sorry, no. I think it might be hard to add TRA
[
https://issues.apache.org/jira/browse/SOLR-12562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551898#comment-16551898
]
David Smiley commented on SOLR-12562:
-
Seems reasonable to have RTG use the one in DocStreamer.
[
https://issues.apache.org/jira/browse/LUCENE-8408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley reassigned LUCENE-8408:
Resolution: Fixed
Assignee: David Smiley
Fix Version/s: 7.5
> Code
[
https://issues.apache.org/jira/browse/SOLR-12561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-12561:
Attachment: SOLR-12561.patch
> Port ExtractionDateUtil to java.time API
>
[
https://issues.apache.org/jira/browse/SOLR-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548098#comment-16548098
]
David Smiley commented on SOLR-10243:
-
SOLR-12561 replaces the API, adds tests, and thus fixes the
[
https://issues.apache.org/jira/browse/SOLR-12561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548094#comment-16548094
]
David Smiley commented on SOLR-12561:
-
Patch:
* Use java.time thoroughly; no java.text remnants nor
[
https://issues.apache.org/jira/browse/SOLR-12561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-12561:
Attachment: SOLR-12561.patch
> Port ExtractionDateUtil to java.time API
>
David Smiley created SOLR-12561:
---
Summary: Port ExtractionDateUtil to java.time API
Key: SOLR-12561
URL: https://issues.apache.org/jira/browse/SOLR-12561
Project: Solr
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/SOLR-11770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548071#comment-16548071
]
David Smiley commented on SOLR-11770:
-
Just curious, what do people actually use TVRH for? Purely
[
https://issues.apache.org/jira/browse/LUCENE-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547916#comment-16547916
]
David Smiley commented on LUCENE-8401:
--
Yeah it's up to a pluggable passage formatter to either
[
https://issues.apache.org/jira/browse/LUCENE-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved LUCENE-8407.
--
Resolution: Fixed
Fix Version/s: 7.5
Note: in 7.x the method is getTermContext()
>
[
https://issues.apache.org/jira/browse/LUCENE-8408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547303#comment-16547303
]
David Smiley commented on LUCENE-8408:
--
Glad you noticed Uwe :) It was written before LUCENE-5640
[
https://issues.apache.org/jira/browse/LUCENE-8403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547298#comment-16547298
]
David Smiley commented on LUCENE-8403:
--
{quote}Doesn't the matches API remove the need for that
[
https://issues.apache.org/jira/browse/LUCENE-8408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated LUCENE-8408:
-
Attachment: LUCENE-8408.patch
> Code cleanup - TokenStreamFromTermVector - ATTRIBUTE_FACTORY
>
[
https://issues.apache.org/jira/browse/LUCENE-8408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547288#comment-16547288
]
David Smiley commented on LUCENE-8408:
--
Correct; I wrote that. While it used to be of use back in
[
https://issues.apache.org/jira/browse/LUCENE-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547286#comment-16547286
]
David Smiley commented on LUCENE-8405:
--
A comment is perfect; thanks.
> Remove TopHits.maxScore
>
[
https://issues.apache.org/jira/browse/SOLR-12394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547076#comment-16547076
]
David Smiley commented on SOLR-12394:
-
Lets just remove it on master (8x) and mark deprecated for 7x.
[
https://issues.apache.org/jira/browse/LUCENE-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547071#comment-16547071
]
David Smiley commented on LUCENE-8407:
--
This would go right below getTerm. I copy pasted this from
David Smiley created LUCENE-8407:
Summary: Add SpanTermQuery.getTermStates()
Key: LUCENE-8407
URL: https://issues.apache.org/jira/browse/LUCENE-8407
Project: Lucene - Core
Issue Type:
[
https://issues.apache.org/jira/browse/LUCENE-8405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547016#comment-16547016
]
David Smiley commented on LUCENE-8405:
--
+1 nice simplification. Solr changes looks good to me,
[
https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546660#comment-16546660
]
David Smiley commented on LUCENE-8306:
--
I did a little review:
* Shouldn't label() return the
[
https://issues.apache.org/jira/browse/LUCENE-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545682#comment-16545682
]
David Smiley commented on LUCENE-8401:
--
Along the idea of reusable components, adding a
[
https://issues.apache.org/jira/browse/LUCENE-8401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545661#comment-16545661
]
David Smiley commented on LUCENE-8401:
--
This is a fine idea Alan. I especially like the peeking
[
https://issues.apache.org/jira/browse/LUCENE-8403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545609#comment-16545609
]
David Smiley commented on LUCENE-8403:
--
Ah, I remember this. Here, the TVs are only in use for the
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545208#comment-16545208
]
David Smiley commented on SOLR-12519:
-
You're correct that we might _inadvertently_ have a situation
[
https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543985#comment-16543985
]
David Smiley commented on LUCENE-8306:
--
RE TermPostingsEnum -- haha; I see we discussed it above.
[
https://issues.apache.org/jira/browse/SOLR-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543976#comment-16543976
]
David Smiley commented on SOLR-12519:
-
Oh I understand now. My suggestion to use
[
https://issues.apache.org/jira/browse/SOLR-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543966#comment-16543966
]
David Smiley commented on SOLR-12412:
-
Yes, +1 to adding a withIndexWriter(lambda) method similar to
[
https://issues.apache.org/jira/browse/LUCENE-8396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543776#comment-16543776
]
David Smiley commented on LUCENE-8396:
--
I took a peek at the patch. One bit surprised me. There
601 - 700 of 5659 matches
Mail list logo