[jira] [Commented] (SOLR-13190) Fuzzy search treated as server error instead of client error when terms are too complex

2019-06-16 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865172#comment-16865172 ] Mike Drob commented on SOLR-13190: -- Looks like I failed to mention in this initial reporting that the

[jira] [Commented] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

2019-04-15 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818191#comment-16818191 ] Mike Drob commented on SOLR-13386: -- I imagine this is basically impossible to write a unit test for?

[jira] [Commented] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

2019-04-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814624#comment-16814624 ] Mike Drob commented on SOLR-13386: -- I see similar pattern in {{ClusterProperties}} and

[jira] [Commented] (SOLR-13190) Fuzzy search treated as server error instead of client error when terms are too complex

2019-02-19 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772074#comment-16772074 ] Mike Drob commented on SOLR-13190: -- bq. Does converting an already deterministic automaton necessarily

[jira] [Commented] (SOLR-13190) Fuzzy search treated as server error instead of client error when terms are too complex

2019-02-11 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765499#comment-16765499 ] Mike Drob commented on SOLR-13190: -- We'd have to modify AutomatonQuery to handle multiple Automata, so

[jira] [Commented] (SOLR-13190) Fuzzy search treated as server error instead of client error when terms are too complex

2019-02-06 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761956#comment-16761956 ] Mike Drob commented on SOLR-13190: -- Can you expand on that a little more? Tracing through the code path

[jira] [Commented] (SOLR-13190) Fuzzy search treated as server error instead of client error when terms are too complex

2019-02-01 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758713#comment-16758713 ] Mike Drob commented on SOLR-13190: -- [~mikemccand] - WDYT? You were the original person to add this

[jira] [Created] (SOLR-13190) Fuzzy search treated as server error instead of client error when terms are too complex

2019-01-29 Thread Mike Drob (JIRA)
Mike Drob created SOLR-13190: Summary: Fuzzy search treated as server error instead of client error when terms are too complex Key: SOLR-13190 URL: https://issues.apache.org/jira/browse/SOLR-13190

[jira] [Commented] (SOLR-11936) maven urls should use https

2018-02-01 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348843#comment-16348843 ] Mike Drob commented on SOLR-11936: -- [~thetaphi], [~steve_rowe] - I tried to look for where ivy does the

[jira] [Updated] (SOLR-11936) maven urls should use https

2018-02-01 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-11936: - Attachment: SOLR-11936.patch > maven urls should use https > --- > >

[jira] [Created] (SOLR-11936) maven urls should use https

2018-02-01 Thread Mike Drob (JIRA)
Mike Drob created SOLR-11936: Summary: maven urls should use https Key: SOLR-11936 URL: https://issues.apache.org/jira/browse/SOLR-11936 Project: Solr Issue Type: Task Security Level:

[jira] [Commented] (SOLR-10308) Solr fails to work with Guava 21.0

2018-01-15 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326664#comment-16326664 ] Mike Drob commented on SOLR-10308: -- Maybe worth thinking about if we can relocate the version of guava

[jira] [Commented] (SOLR-11702) Redesign current LIR implementation

2017-12-07 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282992#comment-16282992 ] Mike Drob commented on SOLR-11702: -- Ooooh, good approach. This is similar in concept to how RAFT works, I

[jira] [Commented] (LUCENE-8047) Comparison of String objects using == or !=

2017-11-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248089#comment-16248089 ] Mike Drob commented on LUCENE-8047: --- Thanks for the clarification, Uwe! > Comparison of String objects

[jira] [Commented] (LUCENE-8047) Comparison of String objects using == or !=

2017-11-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247788#comment-16247788 ] Mike Drob commented on LUCENE-8047: --- Should we replace the strings with enums? > Comparison of String

[jira] [Commented] (LUCENE-8047) Comparison of String objects using == or !=

2017-11-09 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246955#comment-16246955 ] Mike Drob commented on LUCENE-8047: --- Which tool? > Comparison of String objects using == or != >

[jira] [Commented] (SOLR-11473) Make HDFSDirectoryFactory support other prefixes (besides hdfs:/)

2017-10-12 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201846#comment-16201846 ] Mike Drob commented on SOLR-11473: -- bq. In general, I would prefer to use the URI class throughout

[jira] [Commented] (SOLR-11460) review values used in test-files

2017-10-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198979#comment-16198979 ] Mike Drob commented on SOLR-11460: -- We probably want some testing of backwards compatibility using a

[jira] [Commented] (SOLR-11453) Create separate logger for slow requests

2017-10-09 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197403#comment-16197403 ] Mike Drob commented on SOLR-11453: -- SlowRequest logger won't need the "slow: " log prefix, I think.

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-09-22 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176520#comment-16176520 ] Mike Drob commented on SOLR-10912: -- I agree with Cassandra, and would go even further in saying that

[jira] [Updated] (LUCENE-7973) Update dictionary version for Ukrainian analyzer

2017-09-20 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated LUCENE-7973: -- Summary: Update dictionary version for Ukrainian analyzer (was: Update dictionary version for

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-09-11 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162140#comment-16162140 ] Mike Drob commented on SOLR-10912: -- There's some dependency work here. A change in solr-core shouldn't

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-09-11 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161973#comment-16161973 ] Mike Drob commented on SOLR-10912: -- bq. solr in the patch failed would be good to see if we can say

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-09-11 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161707#comment-16161707 ] Mike Drob commented on SOLR-10912: -- [~manokovacs] - was there supposed to be a QA run for the patch you

[jira] [Commented] (LUCENE-5822) Create a markdown formatted README file for Lucene/Solr

2017-07-02 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071685#comment-16071685 ] Mike Drob commented on LUCENE-5822: --- Thanks for cleaning up my messes, Uwe. I never imagined so much

[jira] [Resolved] (LUCENE-5822) Create a markdown formatted README file for Lucene/Solr

2017-07-01 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved LUCENE-5822. --- Resolution: Fixed Updated smoke test script. Jenkins should be happy now! > Create a markdown

[jira] [Commented] (LUCENE-5822) Create a markdown formatted README file for Lucene/Solr

2017-07-01 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071433#comment-16071433 ] Mike Drob commented on LUCENE-5822: --- Yea, `test` and `precommit` are good to run. Ostensibly, I was

[jira] [Commented] (LUCENE-5822) Create a markdown formatted README file for Lucene/Solr

2017-06-30 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16070967#comment-16070967 ] Mike Drob commented on LUCENE-5822: --- Didn't know about the nightly smoke target. I'll get this fixed

[jira] [Updated] (LUCENE-5822) Create a markdown formatted README file for Lucene/Solr

2017-06-30 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated LUCENE-5822: -- Attachment: LUCENE-5822-addemdum.patch [~steve_rowe] I have a fix for this, but I'm not sure how to

[jira] [Reopened] (LUCENE-5822) Create a markdown formatted README file for Lucene/Solr

2017-06-30 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob reopened LUCENE-5822: --- > Create a markdown formatted README file for Lucene/Solr >

[jira] [Resolved] (LUCENE-5822) Create a markdown formatted README file for Lucene/Solr

2017-06-30 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved LUCENE-5822. --- Resolution: Fixed Assignee: Mike Drob Fix Version/s: master (7.0) Lucene Fields:

[jira] [Assigned] (SOLR-10004) javadoc test in smokeTestRelease.py wants to fail

2017-06-28 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob reassigned SOLR-10004: Assignee: Ishan Chattopadhyaya [~ichattopadhyaya] - can you set the fix version for this and

[jira] [Commented] (LUCENE-5822) Create a markdown formatted README file for Lucene/Solr

2017-06-27 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065622#comment-16065622 ] Mike Drob commented on LUCENE-5822: --- Pushed patch to github so that folks can take a look at a rendered

[jira] [Commented] (LUCENE-5822) Create a markdown formatted README file for Lucene/Solr

2017-06-26 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064137#comment-16064137 ] Mike Drob commented on LUCENE-5822: --- Markdown supports style comments, please include an apache

[jira] [Commented] (LUCENE-7884) StringHelper needs to catch NoClassDefFoundError

2017-06-26 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064111#comment-16064111 ] Mike Drob commented on LUCENE-7884: --- Catching throwable and then trucking on in the face of whatever

[jira] [Commented] (SOLR-10911) Fix inspection warnings reported by IntelliJ

2017-06-19 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16054377#comment-16054377 ] Mike Drob commented on SOLR-10911: -- Would love to have a shared profile (even better tie into {{ant

[jira] [Commented] (SOLR-10912) Adding automatic patch validation

2017-06-19 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16054147#comment-16054147 ] Mike Drob commented on SOLR-10912: -- [~manokovacs] - I'm on board with this. There was some discussion

[jira] [Commented] (SOLR-8392) SolrParam.get(String) returns String and shouldn't be used in other instanceof checks

2017-06-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048414#comment-16048414 ] Mike Drob commented on SOLR-8392: - It looks like we use raw types somewhere to shove a {{String[]}} value

[jira] [Commented] (SOLR-8392) SolrParam.get(String) returns String and shouldn't be used in other instanceof checks

2017-06-13 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048046#comment-16048046 ] Mike Drob commented on SOLR-8392: - Sigh. Sorry about that, guys. I'll take care of this today. >

[jira] [Resolved] (SOLR-8392) SolrParam.get(String) returns String and shouldn't be used in other instanceof checks

2017-06-12 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-8392. - Resolution: Fixed > SolrParam.get(String) returns String and shouldn't be used in other > instanceof

[jira] [Updated] (SOLR-8392) SolrParam.get(String) returns String and shouldn't be used in other instanceof checks

2017-06-12 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-8392: Fix Version/s: (was: 6.0) master (7.0) > SolrParam.get(String) returns String and

[jira] [Commented] (SOLR-10778) Ant precommit task WARNINGS about unclosed resources

2017-06-12 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047142#comment-16047142 ] Mike Drob commented on SOLR-10778: -- [~erickerickson] - I think taking care of the warnings is a hugely

[jira] [Commented] (SOLR-8392) SolrParam.get(String) returns String and shouldn't be used in other instanceof checks

2017-06-12 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047134#comment-16047134 ] Mike Drob commented on SOLR-8392: - Yea, I'll take care of it. > SolrParam.get(String) returns String and

[jira] [Assigned] (SOLR-8392) SolrParam.get(String) returns String and shouldn't be used in other instanceof checks

2017-06-12 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob reassigned SOLR-8392: --- Assignee: Mike Drob > SolrParam.get(String) returns String and shouldn't be used in other >

[jira] [Commented] (SOLR-10854) Make Ref Guide PDF have same logo it used to have

2017-06-08 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16043386#comment-16043386 ] Mike Drob commented on SOLR-10854: -- It's weird for me to see {{:email: https://lucene.apache.org/solr}}

[jira] [Commented] (SOLR-10852) NullPointerException at ExactSharedStatsCache.getPerShardTermStats

2017-06-08 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042819#comment-16042819 ] Mike Drob commented on SOLR-10852: -- Is this the same issue that you reported in SOLR-10824? >

[jira] [Updated] (SOLR-8437) Remove outdated RAMDirectory comment from example solrconfigs

2017-06-05 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-8437: Fix Version/s: (was: 7.0) master (7.0) > Remove outdated RAMDirectory comment from

[jira] [Updated] (SOLR-9321) Removed usage of deprecated clusterstate.getSlicesMap(), getSlices() and getActiveSlices()

2017-06-05 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-9321: Fix Version/s: (was: 7.0) master (7.0) > Removed usage of deprecated

[jira] [Updated] (SOLR-10574) Choose a default configset for Solr 7

2017-06-05 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-10574: - Fix Version/s: (was: 7.0) master (7.0) > Choose a default configset for Solr 7 >

[jira] [Resolved] (SOLR-10713) git should ignore common output files (*.pid, *.out)

2017-06-05 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-10713. -- Resolution: Fixed Fix Version/s: master (7.0) Thanks, [~gerlowskija]! > git should ignore

[jira] [Commented] (SOLR-10713) git should ignore common output files (*.pid, *.out)

2017-06-05 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037263#comment-16037263 ] Mike Drob commented on SOLR-10713: -- LGTM, will commit later today. > git should ignore common output

[jira] [Commented] (SOLR-10713) git should ignore common output files (*.pid, *.out)

2017-06-04 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036366#comment-16036366 ] Mike Drob commented on SOLR-10713: -- Did we want to move {{*.out}} and {{*.err}} into the

[jira] [Commented] (SOLR-10713) git should ignore common output files (*.pid, *.out)

2017-06-03 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035974#comment-16035974 ] Mike Drob commented on SOLR-10713: -- According to my reading to the {{.gitignore}} man page, {{**/lib}}

[jira] [Commented] (SOLR-10713) git should ignore common output files (*.pid, *.out)

2017-06-02 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035491#comment-16035491 ] Mike Drob commented on SOLR-10713: -- Let's get the easy parts committed and not worry about the hard parts

[jira] [Assigned] (SOLR-10713) git should ignore common output files (*.pid, *.out)

2017-05-19 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob reassigned SOLR-10713: Assignee: Mike Drob > git should ignore common output files (*.pid, *.out) >

[jira] [Commented] (SOLR-10713) git should ignore common output files (*.pid, *.out)

2017-05-19 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017954#comment-16017954 ] Mike Drob commented on SOLR-10713: -- I feel bad for quibbling like this over what should be a

[jira] [Commented] (SOLR-10506) Possible memory leak upon collection reload

2017-05-19 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017804#comment-16017804 ] Mike Drob commented on SOLR-10506: -- +1 LGTM. [~cpoerschke], I'll let you commit this when you are done

[jira] [Commented] (SOLR-10713) git should ignore common output files (*.pid, *.out)

2017-05-19 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017772#comment-16017772 ] Mike Drob commented on SOLR-10713: -- The biggest issue I can think of is if we wanted to have some

[jira] [Commented] (SOLR-10713) git should ignore common output files (*.pid, *.out)

2017-05-19 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017723#comment-16017723 ] Mike Drob commented on SOLR-10713: -- Not sure what the right answer here is, but would it make more sense

[jira] [Commented] (SOLR-10713) git should ignore common output files (*.pid, *.out)

2017-05-18 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016908#comment-16016908 ] Mike Drob commented on SOLR-10713: -- I would also ignore .err files > git should ignore common output

[jira] [Commented] (SOLR-10678) Clustering can be executed multiple times in distributed mode

2017-05-12 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008716#comment-16008716 ] Mike Drob commented on SOLR-10678: -- > is there any other way to determine whether it's a distributed

[jira] [Commented] (SOLR-7880) Update commons-cli to 1.3.1, fix usage of deprecated classes/methods

2017-05-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16005406#comment-16005406 ] Mike Drob commented on SOLR-7880: - [~elyograg] - Do you want to take a look at this again? Commons-cli is

[jira] [Resolved] (SOLR-2029) Support for Index Time Document Boost in SolrContentHandler

2017-05-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-2029. - Resolution: Won't Fix Can't do this anymore since Lucene no longer supports index time boosts. > Support

[jira] [Commented] (SOLR-10506) Possible memory leak upon collection reload

2017-05-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004822#comment-16004822 ] Mike Drob commented on SOLR-10506: -- Well, the stopWatching method is only called when a core is closed.

[jira] [Commented] (SOLR-10506) Possible memory leak upon collection reload

2017-05-10 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004456#comment-16004456 ] Mike Drob commented on SOLR-10506: -- Since it's a weak reference, couldn't the schema reader be collected

[jira] [Resolved] (SOLR-4833) All(most all) Logger instances should be made static

2017-05-09 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-4833. - Resolution: Duplicate > All(most all) Logger instances should be made static >

[jira] [Resolved] (SOLR-2716) QueryResultKey hashCode() and equals() is dependent on filter order

2017-05-09 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-2716. - Resolution: Duplicate > QueryResultKey hashCode() and equals() is dependent on filter order >

[jira] [Resolved] (SOLR-4514) Need tests for OpenExchangeRatesOrgProvider

2017-05-09 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-4514. - Resolution: Fixed Assignee: Hoss Man Fix Version/s: 4.2 > Need tests for

[jira] [Resolved] (SOLR-4517) make FieldType.properties protected

2017-05-09 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-4517. - Resolution: Fixed Assignee: Robert Muir Fix Version/s: 4.2 > make FieldType.properties

[jira] [Commented] (SOLR-3721) Multiple concurrent recoveries of same shard?

2017-05-09 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-3721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003494#comment-16003494 ] Mike Drob commented on SOLR-3721: - Lots of additional work has gone into this in other issues, I think it's

[jira] [Resolved] (SOLR-2547) highlighting breaks with WordDelimiterFilter and termOffsets=true and termPositions=true

2017-05-09 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-2547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-2547. - Resolution: Duplicate > highlighting breaks with WordDelimiterFilter and termOffsets=true and >

[jira] [Commented] (SOLR-8995) Use lambdas to simplify code

2017-05-03 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996110#comment-15996110 ] Mike Drob commented on SOLR-8995: - [~noble.paul] - there's been a lot of work on this issue. Can we close

[jira] [Commented] (SOLR-7864) timeAllowed causing ClassCastException

2017-05-03 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996104#comment-15996104 ] Mike Drob commented on SOLR-7864: - Possibly also related to SOLR-9882 > timeAllowed causing

[jira] [Commented] (SOLR-10483) Support for IntPointField field types

2017-05-03 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996100#comment-15996100 ] Mike Drob commented on SOLR-10483: -- Looking at this again, maybe I misunderstand what the goal is and

[jira] [Commented] (SOLR-10483) Support for IntPointField field types

2017-05-03 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996092#comment-15996092 ] Mike Drob commented on SOLR-10483: -- Done in SOLR-8396, I think. > Support for IntPointField field types

[jira] [Commented] (SOLR-10447) An endpoint to get the alias for a collection

2017-05-03 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996087#comment-15996087 ] Mike Drob commented on SOLR-10447: -- [~ichattopadhyaya] - is everything here done? can we tag the correct

[jira] [Commented] (SOLR-5277) Stamp core names on log entries for certain classes

2017-05-03 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995717#comment-15995717 ] Mike Drob commented on SOLR-5277: - MDC work was committed over several other issues, so I think this is

[jira] [Commented] (SOLR-2283) Expose QueryUtils methods

2017-05-02 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994226#comment-15994226 ] Mike Drob commented on SOLR-2283: - Done in SOLR-2066. > Expose QueryUtils methods >

[jira] [Commented] (SOLR-9867) The Solr examples can not always be started after being stopped due to race with loading core.

2017-04-30 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990142#comment-15990142 ] Mike Drob commented on SOLR-9867: - Great idea to add isLoading info. Is latch.await() on every request

[jira] [Commented] (SOLR-1550) statistics for request handlers should report std dev

2017-04-28 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989057#comment-15989057 ] Mike Drob commented on SOLR-1550: - Looks like this feature was added in SOLR-9854 via the codahale metrics.

[jira] [Updated] (SOLR-9555) Leader incorrectly publishes state for replica when it puts replica into LIR.

2017-04-26 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-9555: Attachment: SOLR-9555.patch Cleans up patch to pass {{ant precommit}} > Leader incorrectly publishes state

[jira] [Commented] (SOLR-9555) Leader incorrectly publishes state for replica when it puts replica into LIR.

2017-04-26 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985465#comment-15985465 ] Mike Drob commented on SOLR-9555: - Noticed that on that check if it hits the follower it gets 2 docs, and

[jira] [Commented] (SOLR-10537) Add SolrParams.toLocalParamsString and ClientUtils.encodeLocalParamVal

2017-04-26 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984963#comment-15984963 ] Mike Drob commented on SOLR-10537: -- Why did you choose to do explicit Iterator rather than a for-each

[jira] [Comment Edited] (SOLR-9555) Leader incorrectly publishes state for replica when it puts replica into LIR.

2017-04-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15983273#comment-15983273 ] Mike Drob edited comment on SOLR-9555 at 4/25/17 6:50 PM: -- Here's a patch that

[jira] [Updated] (SOLR-9555) Leader incorrectly publishes state for replica when it puts replica into LIR.

2017-04-25 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-9555: Attachment: SOLR-9555.patch Here's a patch that fixes the resource leak. I'm still getting a different kind

[jira] [Created] (SOLR-10560) MergeIndex could support SolrCloud operation

2017-04-24 Thread Mike Drob (JIRA)
Mike Drob created SOLR-10560: Summary: MergeIndex could support SolrCloud operation Key: SOLR-10560 URL: https://issues.apache.org/jira/browse/SOLR-10560 Project: Solr Issue Type: Improvement

[jira] [Commented] (SOLR-9555) Leader incorrectly publishes state for replica when it puts replica into LIR.

2017-04-24 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981460#comment-15981460 ] Mike Drob commented on SOLR-9555: - Looking at my patch again, I can't tell if there is a really subtle bug

[jira] [Commented] (SOLR-9555) Leader incorrectly publishes state for replica when it puts replica into LIR.

2017-04-24 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981298#comment-15981298 ] Mike Drob commented on SOLR-9555: - bq. I think we should take this opportunity to stop trying to do LIR per

[jira] [Commented] (SOLR-10415) Within solr-core, debug/trace level logging should use parameterized log messages

2017-04-21 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978915#comment-15978915 ] Mike Drob commented on SOLR-10415: -- Great catch, Michael! > Within solr-core, debug/trace level logging

[jira] [Updated] (SOLR-9555) Leader incorrectly publishes state for replica when it puts replica into LIR.

2017-04-20 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-9555: Attachment: SOLR-9555.patch This one is pretty close, give it a look and let me know what y'all think.

[jira] [Updated] (SOLR-10071) The Nightly test LeaderInitiatedRecoveryOnShardRestartTest appears to be too fragile.

2017-04-20 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-10071: - Attachment: SOLR-10071.patch This depends on my SOLR-9555 patch. I haven't run it through the beasting,

[jira] [Updated] (SOLR-10525) Stacked recovery requests can interfere with one another

2017-04-20 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-10525: - Attachment: SOLR-10525.patch New patch attached that keeps the recoveryWaiting counter. > Stacked

[jira] [Commented] (SOLR-10525) Stacked recovery requests can interfere with one another

2017-04-19 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975807#comment-15975807 ] Mike Drob commented on SOLR-10525: -- It occurs to me that with this change if there is a steady stream of

[jira] [Commented] (SOLR-10525) Stacked recovery requests can interfere with one another

2017-04-19 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975512#comment-15975512 ] Mike Drob commented on SOLR-10525: -- bq. The fact that multiple can still stack is as designed though why?

[jira] [Updated] (SOLR-10525) Stacked recovery requests can interfere with one another

2017-04-19 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-10525: - Attachment: SOLR-10525.patch Patch for 7.0 fixed, probably good for 6.x also (in which case whoever

[jira] [Created] (SOLR-10525) Stacked recovery requests can interfere with one another

2017-04-19 Thread Mike Drob (JIRA)
Mike Drob created SOLR-10525: Summary: Stacked recovery requests can interfere with one another Key: SOLR-10525 URL: https://issues.apache.org/jira/browse/SOLR-10525 Project: Solr Issue Type:

[jira] [Updated] (SOLR-9555) Leader incorrectly publishes state for replica when it puts replica into LIR.

2017-04-18 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-9555: Attachment: SOLR-9555-WIP-3.patch Looking at the {{ForceLeaderTest}} code snippet that you posted,

[jira] [Updated] (SOLR-9555) Leader incorrectly publishes state for replica when it puts replica into LIR.

2017-04-17 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-9555: Attachment: SOLR-9555-WIP-2.patch Continuing to work on this. I think I've actually made progress on the

[jira] [Commented] (SOLR-9555) Leader incorrectly publishes state for replica when it puts replica into LIR.

2017-04-14 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969172#comment-15969172 ] Mike Drob commented on SOLR-9555: - I guess I was unclear. I meant to rip the proxy stuff out _from this

[jira] [Commented] (SOLR-9555) Leader incorrectly publishes state for replica when it puts replica into LIR.

2017-04-14 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969118#comment-15969118 ] Mike Drob commented on SOLR-9555: - [~caomanhdat] - yea, ForceLeaderTest was one of the ones that was

  1   2   3   4   5   6   >