[jira] [Created] (SOLR-8793) Fix stale commit files' size computation in LukeRequestHandler

2016-03-06 Thread Shai Erera (JIRA)
Shai Erera created SOLR-8793: Summary: Fix stale commit files' size computation in LukeRequestHandler Key: SOLR-8793 URL: https://issues.apache.org/jira/browse/SOLR-8793 Project: Solr

[jira] [Commented] (SOLR-8587) Add segments file information to core admin status

2016-03-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15182197#comment-15182197 ] Shai Erera commented on SOLR-8587: -- How can a changing index affect the code here.

[jira] [Commented] (SOLR-8587) Add segments file information to core admin status

2016-03-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15182185#comment-15182185 ] Shai Erera commented on SOLR-8587: -- I've just tried that on 5.5.0 and it seem

[jira] [Commented] (SOLR-8734) fix deprecation warnings for absent (maxMergeDocs|mergeFactor)

2016-02-25 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167049#comment-15167049 ] Shai Erera commented on SOLR-8734: -- Patch looks good. Even while working on the prev

Re: Shard splitting and replica placement strategy

2016-02-24 Thread Shai Erera
Opened https://issues.apache.org/jira/browse/SOLR-8728 with a test which reproduces the exception. On Wed, Feb 24, 2016 at 3:49 PM Shai Erera wrote: > Thanks Noble, I'll try to reproduce in a test then. Does the rule I've set > sound right to you though? > > On Wed, Feb

[jira] [Updated] (SOLR-8728) Splitting a shard of a collection created with a rule fails with NPE

2016-02-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-8728: - Attachment: SOLR-8728.patch If you run this test it fails and you can see this exception in the console

[jira] [Created] (SOLR-8728) Splitting a shard of a collection created with a rule fails with NPE

2016-02-24 Thread Shai Erera (JIRA)
Shai Erera created SOLR-8728: Summary: Splitting a shard of a collection created with a rule fails with NPE Key: SOLR-8728 URL: https://issues.apache.org/jira/browse/SOLR-8728 Project: Solr

Re: Shard splitting and replica placement strategy

2016-02-24 Thread Shai Erera
Thanks Noble, I'll try to reproduce in a test then. Does the rule I've set sound right to you though? On Wed, Feb 24, 2016, 15:19 Noble Paul wrote: > Whatever it is , there should be no NPE. could be a bug > > On Wed, Feb 24, 2016 at 6:23 PM, Shai Erera wrote: > > H

Shard splitting and replica placement strategy

2016-02-24 Thread Shai Erera
Hi I wanted to try out the (relatively) new replica placement strategy and how it plays with shard splitting. So I set up a 4-node cluster, created a collection with 1 shard and 2 replicas (each created on a different) node. When I issue a SPLITSHARD command (without any rules set on the collecti

[jira] [Commented] (SOLR-7668) Port-base rule for shard placement causes NPE

2016-02-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15162918#comment-15162918 ] Shai Erera commented on SOLR-7668: -- Is this not resolved already? > Port-base r

Re: Rolling upgrades from 5.x to 6.0

2016-02-23 Thread Shai Erera
still in a 4.x format, right? That >> would be one point where it's not "fully back compatible." >> >> On Tue, Feb 23, 2016 at 12:27 PM, Shai Erera wrote: >> >>> Wait, what do you mean by Lucene not supporting back-compat? Lucene 6.0 >>> w

Re: Removing branch_5x shortly

2016-02-23 Thread Shai Erera
I agree. No one says anything about deliberately introducing new features in a 5.6. At least from my POV, I'd like to be able to not take down my Solr cluster when upgrading to 6.0, so if any work needs to happen on the 5x branch (and maybe also on the 6x branch) to make that happen, I'll gladly do

Re: Rolling upgrades from 5.x to 6.0

2016-02-23 Thread Shai Erera
e on crazy, "sophisticated" back compat layers. > > We don't even really support rolling updates between major versions. We > make a simple best effort. Until we have tests, it's going to be a shaky > affair. There is a JIRA open now working on some testing I believ

Rolling upgrades from 5.x to 6.0

2016-02-23 Thread Shai Erera
Hi I read in few emails/issue comments that rolling upgrades from 5.x to 6.0 isn't supported. Is it really the case? Does it mean that anyone who has a 5.x Solr cluster *must* incur down time when upgrading to 6.0? If this is really the case, can someone list the known issues/reasons for that?Can

Re: Removing branch_5x shortly

2016-02-23 Thread Shai Erera
We might want to have a 'deprecation' release, not sure what's our policy about that. I.e. is it OK to release 6.0, then deprecate some APIs that we "forgot to deprecate in 5.x" and remove them in 6.1? I say let's keep branch_5x for a little while. Removing is always possible. Shai On Tue, Feb 2

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155909#comment-15155909 ] Shai Erera commented on SOLR-8621: -- Looks good [~cpoerschke]! And yes, let&

[jira] [Commented] (SOLR-8674) transition from solr.tests.mergePolicy to solr.tests.mergePolicyFactory

2016-02-19 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154396#comment-15154396 ] Shai Erera commented on SOLR-8674: -- Patch looks good! > transiti

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-19 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154388#comment-15154388 ] Shai Erera commented on SOLR-8621: -- I am not sure how to comment on those pages, so

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

2016-02-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146678#comment-15146678 ] Shai Erera commented on SOLR-8677: -- I don't mind either way Jason. Either you

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

2016-02-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146459#comment-15146459 ] Shai Erera commented on SOLR-8677: -- Also, would u mind adding a CHANGES.txt entry

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

2016-02-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146458#comment-15146458 ] Shai Erera commented on SOLR-8677: -- Looks good to me. [~gerlowskija] I know it&#

[jira] [Commented] (SOLR-5730) make Lucene's SortingMergePolicy and EarlyTerminatingSortingCollector configurable in Solr

2016-02-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143646#comment-15143646 ] Shai Erera commented on SOLR-5730: -- Patch looks good! One minor comment -

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143618#comment-15143618 ] Shai Erera commented on SOLR-8621: -- [~cpoerschke] these look good, so +1 to merge t

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142613#comment-15142613 ] Shai Erera commented on SOLR-8621: -- Thanks I'll take a look. > solrconfig.xm

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142568#comment-15142568 ] Shai Erera commented on SOLR-8621: -- Can you point me to a test failure? > solrcon

[jira] [Commented] (SOLR-5730) make Lucene's SortingMergePolicy and EarlyTerminatingSortingCollector configurable in Solr

2016-02-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142109#comment-15142109 ] Shai Erera commented on SOLR-5730: -- Few comments about the patch: * In QueryCompo

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142095#comment-15142095 ] Shai Erera commented on SOLR-8621: -- [~cpoerschke] thx for fixing that typo! And

[jira] [Commented] (LUCENE-7020) TieredMergePolicy - cascade maxMergeAtOnce setting to maxMergeAtOnceExplicit

2016-02-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15141065#comment-15141065 ] Shai Erera commented on LUCENE-7020: Sure, that's expected behavior and is

[jira] [Commented] (LUCENE-7020) TieredMergePolicy - cascade maxMergeAtOnce setting to maxMergeAtOnceExplicit

2016-02-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140902#comment-15140902 ] Shai Erera commented on LUCENE-7020: bq. I think users who have very large ind

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140888#comment-15140888 ] Shai Erera commented on SOLR-8621: -- You're right Christine, I didn

[jira] [Commented] (LUCENE-7020) TieredMergePolicy - cascade maxMergeAtOnce setting to maxMergeAtOnceExplicit

2016-02-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140762#comment-15140762 ] Shai Erera commented on LUCENE-7020: I don't see how {{maxMergeAtO

[jira] [Updated] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-8621: - Attachment: SOLR-8621-example_contrib_configs.patch [~cpoerschke] if you're OK with this patch,

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140753#comment-15140753 ] Shai Erera commented on SOLR-8621: -- Good catch, I just blindly moved that 'me

[jira] [Updated] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-8621: - Attachment: SOLR-8621-example_contrib_configs.patch Patch changes solrconfig.xmls under solr/contrib and

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140147#comment-15140147 ] Shai Erera commented on SOLR-8621: -- bq. Could you take care of the solr/contrib and

[jira] [Created] (SOLR-8668) Remove support for

2016-02-09 Thread Shai Erera (JIRA)
Shai Erera created SOLR-8668: Summary: Remove support for Key: SOLR-8668 URL: https://issues.apache.org/jira/browse/SOLR-8668 Project: Solr Issue Type: Improvement Reporter: Shai

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138897#comment-15138897 ] Shai Erera commented on SOLR-8621: -- bq. Could I take on the Sure. You lead this,

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138848#comment-15138848 ] Shai Erera commented on SOLR-8621: -- [~cpoerschke]: OK so let's do the following

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137717#comment-15137717 ] Shai Erera commented on SOLR-8621: -- [~cpoerschke] I pushed the changes to both master

[jira] [Commented] (SOLR-8648) Support selective clearing up of stored async collection API responses

2016-02-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137666#comment-15137666 ] Shai Erera commented on SOLR-8648: -- Looks good [~anshumg]! +1 > Support se

[jira] [Comment Edited] (SOLR-8648) Support selective clearing up of stored async collection API responses

2016-02-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137622#comment-15137622 ] Shai Erera edited comment on SOLR-8648 at 2/8/16 8:23 PM: -- Th

[jira] [Commented] (SOLR-8648) Support selective clearing up of stored async collection API responses

2016-02-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137622#comment-15137622 ] Shai Erera commented on SOLR-8648: -- Thanks [~anshumg], I've got few min

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137424#comment-15137424 ] Shai Erera commented on SOLR-8621: -- Thanks [~cpoerschke], I'm running tests now

[jira] [Updated] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-8621: - Attachment: SOLR-8621.patch [~cpoerschke], patch includes the changes from *all* commits that we've p

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136996#comment-15136996 ] Shai Erera commented on SOLR-8621: -- We definitely should fix all the solrconfig.xmls,

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136936#comment-15136936 ] Shai Erera commented on SOLR-8621: -- bq. Shall I just revert the particular commit o

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136886#comment-15136886 ] Shai Erera commented on SOLR-8621: -- {quote} Unrelated to the above, just pushed cha

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135847#comment-15135847 ] Shai Erera commented on SOLR-8621: -- About {{WrapperMergePolicyFactory}}, for it t

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135830#comment-15135830 ] Shai Erera commented on SOLR-8621: -- [~cpoerschke] I reviewed the latest patch and he

[jira] [Commented] (SOLR-8648) Support selective clearing up of stored async collection API responses

2016-02-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135670#comment-15135670 ] Shai Erera commented on SOLR-8648: -- bq. {{if(req.getParams().getBool(&quo

[jira] [Resolved] (LUCENE-7012) Change Lucene/Solr IDE configs to place new Java files' license header before the package declaration

2016-02-05 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-7012. Resolution: Fixed Closing for now. We can address the precommit and netbeans in a separate issue

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-05 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134897#comment-15134897 ] Shai Erera commented on SOLR-8621: -- [~cpoerschke], IMO we should definitely ai

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-05 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134365#comment-15134365 ] Shai Erera commented on SOLR-8621: -- Thanks [~cpoerschke], I'll review the tw

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15133081#comment-15133081 ] Shai Erera commented on SOLR-8621: -- [~cpoerschke] have you had a chance to review

[jira] [Resolved] (LUCENE-7013) Move license header before package declaration in all *.java files

2016-02-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-7013. Resolution: Fixed Fix Version/s: trunk 5.5 Committed the last 5x changes

[jira] [Updated] (LUCENE-7013) Move license header before package declaration in all *.java files

2016-02-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-7013: --- Attachment: mvcopyright.py [~thetaphi] here's the updated script. I probably can be improved fu

[jira] [Commented] (LUCENE-7013) Move license header before package declaration in all *.java files

2016-02-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132470#comment-15132470 ] Shai Erera commented on LUCENE-7013: I've pushed this to master and 5

[jira] [Commented] (LUCENE-7013) Move license header before package declaration in all *.java files

2016-02-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132176#comment-15132176 ] Shai Erera commented on LUCENE-7013: Besides being a workaround, it'd b

[jira] [Commented] (LUCENE-7013) Move license header before package declaration in all *.java files

2016-02-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132067#comment-15132067 ] Shai Erera commented on LUCENE-7013: If there are no objections to making

[jira] [Resolved] (LUCENE-7008) TestSortingMergePolicy.testForceMergeNotNeeded fails

2016-02-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-7008. Resolution: Resolved Assignee: Shai Erera Fix Version/s: trunk

[jira] [Resolved] (LUCENE-7010) Create MergePolicyWrapper

2016-02-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-7010. Resolution: Fixed Fix Version/s: 5.5 trunk Thanks [~thetaphi], committed

[jira] [Commented] (LUCENE-7013) Move license header before package declaration in all *.java files

2016-02-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131860#comment-15131860 ] Shai Erera commented on LUCENE-7013: Thanks [~mikemccand] and [~gerlowskija]

Re: Naming branches so that life is easier

2016-02-03 Thread Shai Erera
I think that all remote branches should be JIRA related. I.e. I don't see myself pushing a remote branch like shaie/something. Since we do all development through JIRA, then if someone experiments with something and wants to push it to the Git repo, I think that should be done within the context of

[jira] [Updated] (LUCENE-7013) Move license header before package declaration in all *.java files

2016-02-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-7013: --- Attachment: LUCENE-7013.patch mvcopyright.py {{mvcopyright.py}} is the simple script

[jira] [Created] (LUCENE-7013) Move license header before package declaration in all *.java files

2016-02-03 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-7013: -- Summary: Move license header before package declaration in all *.java files Key: LUCENE-7013 URL: https://issues.apache.org/jira/browse/LUCENE-7013 Project: Lucene

[jira] [Commented] (LUCENE-7012) Change Lucene/Solr IDE configs to place new Java files' license header before the package declaration

2016-02-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131067#comment-15131067 ] Shai Erera commented on LUCENE-7012: Oh Wow Steve, thanks for the quick

[jira] [Resolved] (LUCENE-7012) Change eclipse's "New Java Files" template to place the license header before the package declaration

2016-02-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-7012. Resolution: Fixed Fix Version/s: Trunk 5.5 Committed the eclipse changes

[jira] [Commented] (LUCENE-7010) Create MergePolicyWrapper

2016-02-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130798#comment-15130798 ] Shai Erera commented on LUCENE-7010: [~thetaphi] do you still have concerns abou

[jira] [Commented] (LUCENE-7012) Change eclipse's "New Java Files" template to place the license header before the package declaration

2016-02-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130757#comment-15130757 ] Shai Erera commented on LUCENE-7012: Found this: http://stackoverflow.com/quest

[jira] [Commented] (LUCENE-7012) Change eclipse's "New Java Files" template to place the license header before the package declaration

2016-02-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130739#comment-15130739 ] Shai Erera commented on LUCENE-7012: I tried to find under {{dev-tools/idea}} a

[jira] [Commented] (LUCENE-7012) Change eclipse's "New Java Files" template to place the license header before the package declaration

2016-02-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130625#comment-15130625 ] Shai Erera commented on LUCENE-7012: If there are no objections, I'll

[jira] [Updated] (LUCENE-7012) Change eclipse's "New Java Files" template to place the license header before the package declaration

2016-02-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-7012: --- Attachment: LUCENE-7012.patch Patch moves the header before the package declaration. Unfortunately

[jira] [Created] (LUCENE-7012) Change eclipse's "New Java Files" template to place the license header before the package declaration

2016-02-03 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-7012: -- Summary: Change eclipse's "New Java Files" template to place the license header before the package declaration Key: LUCENE-7012 URL: https://issues.apache.org/jira/bro

[jira] [Commented] (LUCENE-7010) Create MergePolicyWrapper

2016-02-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130479#comment-15130479 ] Shai Erera commented on LUCENE-7010: How can you not find {{TestNoMergePo

[jira] [Commented] (LUCENE-7010) Create MergePolicyWrapper

2016-02-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130381#comment-15130381 ] Shai Erera commented on LUCENE-7010: bq. Why this in NoMergePolicy? Bec

[jira] [Updated] (LUCENE-7010) Create MergePolicyWrapper

2016-02-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-7010: --- Attachment: LUCENE-7010.patch Patch adds {{MergePolicyWrapper}} and modifies (quite a few) existing

[jira] [Created] (LUCENE-7010) Create MergePolicyWrapper

2016-02-03 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-7010: -- Summary: Create MergePolicyWrapper Key: LUCENE-7010 URL: https://issues.apache.org/jira/browse/LUCENE-7010 Project: Lucene - Core Issue Type: Improvement

[jira] [Commented] (SOLR-5730) make Lucene's SortingMergePolicy and EarlyTerminatingSortingCollector configurable in Solr

2016-02-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130096#comment-15130096 ] Shai Erera commented on SOLR-5730: -- Hi [~jkrupan], your understanding is correct.

[jira] [Updated] (LUCENE-7008) TestSortingMergePolicy.testForceMergeNotNeeded fails

2016-02-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-7008: --- Attachment: LUCENE-7008.patch Patch fixes the test

[jira] [Commented] (LUCENE-7008) TestSortingMergePolicy.testForceMergeNotNeeded fails

2016-02-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129009#comment-15129009 ] Shai Erera commented on LUCENE-7008: I believe I found the cause. The test

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128957#comment-15128957 ] Shai Erera commented on SOLR-8621: -- bq. my outlook currently is that all the master-

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128712#comment-15128712 ] Shai Erera commented on SOLR-8621: -- [~cpoerschke] I've one question about the b

[jira] [Comment Edited] (SOLR-5730) make Lucene's SortingMergePolicy and EarlyTerminatingSortingCollector configurable in Solr

2016-02-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128698#comment-15128698 ] Shai Erera edited comment on SOLR-5730 at 2/2/16 6:1

[jira] [Commented] (SOLR-5730) make Lucene's SortingMergePolicy and EarlyTerminatingSortingCollector configurable in Solr

2016-02-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128698#comment-15128698 ] Shai Erera commented on SOLR-5730: -- [~hossman], this issue is now on hold until we fi

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128650#comment-15128650 ] Shai Erera commented on SOLR-8621: -- [~cpoerschke] I've pushed my changes to t

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128154#comment-15128154 ] Shai Erera commented on SOLR-8621: -- Hmm .. interesting ideas :). In that case I thin

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128127#comment-15128127 ] Shai Erera commented on SOLR-8621: -- bq. Though both simple MPF and wrapped MPF sup

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128081#comment-15128081 ] Shai Erera commented on SOLR-8621: -- Thanks [~cpoerschke]. I've also started to

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15127916#comment-15127916 ] Shai Erera commented on SOLR-8621: -- [~cpoerschke] about the commit, I have few comm

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15127869#comment-15127869 ] Shai Erera commented on SOLR-8621: -- bq. Will both the and elements will be deprec

[jira] [Commented] (SOLR-8617) Add a wait for active option in to add replica

2016-01-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124768#comment-15124768 ] Shai Erera commented on SOLR-8617: -- I agree w/ [~anshumg], I feel like the ASYNC cal

[jira] [Commented] (SOLR-8619) A new replica should not become leader when all current replicas are down as it leads to data loss

2016-01-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124761#comment-15124761 ] Shai Erera commented on SOLR-8619: -- There are two separate issues here: * A new rep

[jira] [Commented] (SOLR-5730) make Lucene's SortingMergePolicy and EarlyTerminatingSortingCollector configurable in Solr

2016-01-27 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119350#comment-15119350 ] Shai Erera commented on SOLR-5730: -- OK so in that case it's better. We'll

[jira] [Commented] (SOLR-5730) make Lucene's SortingMergePolicy and EarlyTerminatingSortingCollector configurable in Solr

2016-01-27 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119287#comment-15119287 ] Shai Erera commented on SOLR-5730: -- OK I see, then in this issue you want to add ano

[jira] [Commented] (SOLR-5730) make Lucene's SortingMergePolicy and EarlyTerminatingSortingCollector configurable in Solr

2016-01-27 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119125#comment-15119125 ] Shai Erera commented on SOLR-5730: -- I don't think that we need to change all MP

[jira] [Commented] (SOLR-5730) make Lucene's SortingMergePolicy and EarlyTerminatingSortingCollector configurable in Solr

2016-01-26 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118799#comment-15118799 ] Shai Erera commented on SOLR-5730: -- Rethinking my proposal, I'm not sure chain

[jira] [Commented] (SOLR-5730) make Lucene's SortingMergePolicy and EarlyTerminatingSortingCollector configurable in Solr

2016-01-26 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117967#comment-15117967 ] Shai Erera commented on SOLR-5730: -- I'm OK with chaining, but then can we at l

[jira] [Comment Edited] (SOLR-5730) make Lucene's SortingMergePolicy and EarlyTerminatingSortingCollector configurable in Solr

2016-01-26 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117549#comment-15117549 ] Shai Erera edited comment on SOLR-5730 at 1/26/16 4:51 PM: --

[jira] [Commented] (SOLR-5730) make Lucene's SortingMergePolicy and EarlyTerminatingSortingCollector configurable in Solr

2016-01-26 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117549#comment-15117549 ] Shai Erera commented on SOLR-5730: -- I was hoping that we'd change solrconf

Re: Merge vs Rebase

2016-01-25 Thread Shai Erera
Thanks Dawid. I'll try for sport to not amend commits for a while, see how that works out for me :). I'll admit that I already ran into needing to revert a local change cause it didn't work, but I didn't have the "history" to revert to ... I don't mind typing 'git push origin HEAD:master'. I prefe

<    1   2   3   4   5   6   7   8   9   10   >