[
https://issues.apache.org/jira/browse/LUCENE-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5600:
---
Attachment: LUCENE-5600.patch
I applied the patch, cleaned up few things and added CHANGES. I
[
https://issues.apache.org/jira/browse/LUCENE-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5600.
Resolution: Fixed
Fix Version/s: 5.0
4.9
Assignee: Shai Erera
[
https://issues.apache.org/jira/browse/LUCENE-5599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5599.
Resolution: Fixed
Fix Version/s: 5.0
4.9
Assignee: Shai Erera
Shai Erera created LUCENE-5591:
--
Summary: ReaderAndUpdates should create a proper IOContext when
writing DV updates
Key: LUCENE-5591
URL: https://issues.apache.org/jira/browse/LUCENE-5591
Project
[
https://issues.apache.org/jira/browse/LUCENE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965405#comment-13965405
]
Shai Erera commented on LUCENE-5591:
I will. I think over estimating is better than
[
https://issues.apache.org/jira/browse/LUCENE-5585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964165#comment-13964165
]
Shai Erera commented on LUCENE-5585:
+1. How about moving it to IOUtils? There's
[
https://issues.apache.org/jira/browse/LUCENE-5585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964183#comment-13964183
]
Shai Erera commented on LUCENE-5585:
+1!
Expose fsync as a static method
[
https://issues.apache.org/jira/browse/LUCENE-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964211#comment-13964211
]
Shai Erera commented on LUCENE-5587:
bq. we could fix SimpleText to 0 or space pad
[
https://issues.apache.org/jira/browse/LUCENE-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964217#comment-13964217
]
Shai Erera commented on LUCENE-5587:
Also, and not sure it's worth fixing, perhaps
[
https://issues.apache.org/jira/browse/LUCENE-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964238#comment-13964238
]
Shai Erera commented on LUCENE-5587:
Looks good. In SimpleTextUtil you should change
Welcome Tim!
Shai
On Tue, Apr 8, 2014 at 8:58 AM, Shalin Shekhar Mangar
shalinman...@gmail.com wrote:
Welcome Tim!
On Tue, Apr 8, 2014 at 10:10 AM, Steve Rowe sar...@gmail.com wrote:
I'm pleased to announce that Tim Potter has accepted the PMC's
invitation to become a committer.
The only problem is how the Codec makes a dynamic decision on whether to
use the wrapped Codec for reading vs pre-load data into in-memory
structures, because Codecs are loaded through reflection by the SPI loading
mechanism.
There is also a TODO in DirectPF to allow wrapping arbitrary PFs, just
this on.
Cool! With that, I don't think there would be a need for
DirectPostingsFormat as a postings format, would there be?
~ David
On Mon, Apr 7, 2014 at 10:58 AM, Shai Erera ser...@gmail.com wrote:
The only problem is how the Codec makes a dynamic decision on whether to
use the wrapped Codec
[
https://issues.apache.org/jira/browse/LUCENE-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959875#comment-13959875
]
Shai Erera commented on LUCENE-5574:
I think this is a good change -- it makes
[
https://issues.apache.org/jira/browse/LUCENE-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959900#comment-13959900
]
Shai Erera commented on LUCENE-5574:
I looked at MDW.close() and looks like
[
https://issues.apache.org/jira/browse/LUCENE-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960195#comment-13960195
]
Shai Erera commented on LUCENE-5574:
+1, looks good. Maybe just clarify why it's OK
Welcome!
On Wed, Apr 2, 2014 at 5:03 PM, david.w.smi...@gmail.com
david.w.smi...@gmail.com wrote:
Welcome Alan!
~ David
On Wed, Apr 2, 2014 at 8:23 AM, Steve Rowe sar...@gmail.com wrote:
I'm pleased to announce that Alan Woodward has accepted the PMC's
invitation to join.
Welcome
[
https://issues.apache.org/jira/browse/LUCENE-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13957801#comment-13957801
]
Shai Erera commented on LUCENE-4246:
bq. I ran into the issue today that somebody
[
https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13956167#comment-13956167
]
Shai Erera commented on LUCENE-2446:
bq. You guys figure out the name for the method
[
https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13956170#comment-13956170
]
Shai Erera commented on LUCENE-2446:
+1
Add checksums to Lucene segment files
In general you should checkout 'trunk' and fix/add stuff there. The
community will then decide whether the feature/fix should also be
backported to 4.x (very likely) and whether a 3.x releases is also needed
(very unlikely).
Shai
On Tue, Apr 1, 2014 at 4:39 PM, Fermin Silva silvafe...@gmail.com
[
https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955022#comment-13955022
]
Shai Erera commented on LUCENE-2446:
This looks really great! +1
Add checksums
[
https://issues.apache.org/jira/browse/LUCENE-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955170#comment-13955170
]
Shai Erera commented on LUCENE-2446:
I think {{checkIntegrity}} is too generic (i.e
[
https://issues.apache.org/jira/browse/LUCENE-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949038#comment-13949038
]
Shai Erera commented on LUCENE-5554:
+1 to commit as well.
But Mike, your patch
[
https://issues.apache.org/jira/browse/LUCENE-5553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13946554#comment-13946554
]
Shai Erera commented on LUCENE-5553:
bq. if the last IndexReader#decRef() call runs
[
https://issues.apache.org/jira/browse/LUCENE-5553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13946578#comment-13946578
]
Shai Erera commented on LUCENE-5553:
bq. As a side-note I think we should never reset
[
https://issues.apache.org/jira/browse/LUCENE-5553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13946693#comment-13946693
]
Shai Erera commented on LUCENE-5553:
Looks good. I'd maybe rename reThrowSilent
[
https://issues.apache.org/jira/browse/LUCENE-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13946962#comment-13946962
]
Shai Erera commented on LUCENE-5554:
I think it's good to add this specialization. We
[
https://issues.apache.org/jira/browse/LUCENE-5370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13943938#comment-13943938
]
Shai Erera commented on LUCENE-5370:
bq. For my purpose, it's sufficient to sort
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5476.
Resolution: Fixed
Fix Version/s: 5.0
4.8
Assignee: Shai Erera
Shai Erera created LUCENE-5542:
--
Summary: Explore making DVConsumer sparse-aware
Key: LUCENE-5542
URL: https://issues.apache.org/jira/browse/LUCENE-5542
Project: Lucene - Core
Issue Type
[
https://issues.apache.org/jira/browse/LUCENE-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13942754#comment-13942754
]
Shai Erera commented on LUCENE-5542:
I don't think it makes the API more complicated
[
https://issues.apache.org/jira/browse/LUCENE-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13942789#comment-13942789
]
Shai Erera commented on LUCENE-5544:
Patch looks good. So basically with this patch
[
https://issues.apache.org/jira/browse/LUCENE-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13942802#comment-13942802
]
Shai Erera commented on LUCENE-5544:
bq. Just thinking about making the test more
[
https://issues.apache.org/jira/browse/LUCENE-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13942804#comment-13942804
]
Shai Erera commented on LUCENE-5544:
Apologies for the multiple comments -- what did
[
https://issues.apache.org/jira/browse/LUCENE-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5544:
---
Comment: was deleted
(was: Apologies for the multiple comments -- what did you mean by {{// don't
[
https://issues.apache.org/jira/browse/LUCENE-5539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5539.
Resolution: Fixed
Committed to trunk and 4x.
Simplify IndexWriter.commitMergedDeletesAndUpdates
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5476:
---
Attachment: LUCENE-5476.patch
I reviewed the patch more closely before I commit:
* Modified few
Hi
I ran precommit and got license check failures for all the *1.6.6.jar files
under solr/example/lib/ext. It looks like these are old jars as there's a
matching 1.7.6 version for each of those.
I can remove them, but anyone can tell me what should I run to make sure I
didn't screw up anything?
correctly if version
numbers change.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
*From:* Shai Erera [mailto:ser...@gmail.com]
*Sent:* Tuesday, March 18, 2014 9:55 AM
*To:* dev@lucene.apache.org
*Subject:* License check
[
https://issues.apache.org/jira/browse/LUCENE-5513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5513.
Resolution: Fixed
Fix Version/s: 5.0
4.8
Assignee: Shai Erera
Committed a fix. It was a bad svn merge.
Shai
2014-03-18 13:24 GMT+02:00 Policeman Jenkins Server jenk...@thetaphi.de:
Build: http://jenkins.thetaphi.de/job/Lucene-Solr-4.x-Linux/9728/
Java: 64bit/jdk1.7.0_51 -XX:-UseCompressedOops -XX:+UseParallelGC
-XX:-UseSuperWord
1 tests failed.
[
https://issues.apache.org/jira/browse/LUCENE-5536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5536:
---
Attachment: LUCENE-5536.patch
Patch removes the call to rollup(). I checked and the rest
[
https://issues.apache.org/jira/browse/LUCENE-5536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13939372#comment-13939372
]
Shai Erera commented on LUCENE-5536:
Don't know that we should because in practice
[
https://issues.apache.org/jira/browse/LUCENE-5536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5536.
Resolution: Fixed
Fix Version/s: 5.0
4.8
Assignee: Shai Erera
Shai Erera created LUCENE-5539:
--
Summary: Simplify IndexWriter.commitMergedDeletesAndUpdates
Key: LUCENE-5539
URL: https://issues.apache.org/jira/browse/LUCENE-5539
Project: Lucene - Core
Issue
[
https://issues.apache.org/jira/browse/LUCENE-5539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5539:
---
Attachment: LUCENE-5539.patch
Patch adds {{MergedDeletesAndUpdates}} holder class with {{.init
[
https://issues.apache.org/jira/browse/LUCENE-5513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5513:
---
Attachment: LUCENE-5513.patch
Patch makes the following refactoring changes (all internal API
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13937681#comment-13937681
]
Shai Erera commented on LUCENE-5476:
Rob, I reviewed the patch and I agree with Gilad
[
https://issues.apache.org/jira/browse/LUCENE-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13937690#comment-13937690
]
Shai Erera commented on LUCENE-5533:
bq. But maybe we should break out
[
https://issues.apache.org/jira/browse/LUCENE-5513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13937696#comment-13937696
]
Shai Erera edited comment on LUCENE-5513 at 3/17/14 11:26 AM
[
https://issues.apache.org/jira/browse/LUCENE-5513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5513:
---
Attachment: LUCENE-5513.patch
Fixed stupid bug in BinaryDocValuesFieldUpdates.merge().
Binary
[
https://issues.apache.org/jira/browse/LUCENE-5535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13937767#comment-13937767
]
Shai Erera commented on LUCENE-5535:
Have you looked at AssociationsFacetsExample
Shai Erera created LUCENE-5536:
--
Summary: TaxonomyFacetSumInt/FloatAssociations should not rollup()
Key: LUCENE-5536
URL: https://issues.apache.org/jira/browse/LUCENE-5536
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13937785#comment-13937785
]
Shai Erera commented on LUCENE-5533:
I see, it is a pretty extreme case indeed! We
[
https://issues.apache.org/jira/browse/LUCENE-5535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13937793#comment-13937793
]
Shai Erera commented on LUCENE-5535:
Phew :). I'll resolve the issue then. Feel free
[
https://issues.apache.org/jira/browse/LUCENE-5535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13937798#comment-13937798
]
Shai Erera commented on LUCENE-5535:
I think you may be tripping LUCENE-5522, which I
[
https://issues.apache.org/jira/browse/LUCENE-5535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5535.
Resolution: Duplicate
Assignee: Shai Erera
DrillDownQuery not working
[
https://issues.apache.org/jira/browse/LUCENE-5513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5513:
---
Attachment: LUCENE-5513.patch
Thanks Mike. In an edge case where there are field updates, but also
[
https://issues.apache.org/jira/browse/LUCENE-5513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13938808#comment-13938808
]
Shai Erera commented on LUCENE-5513:
Thanks Mike, will wrap up and commit.
One thing
[
https://issues.apache.org/jira/browse/LUCENE-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13937087#comment-13937087
]
Shai Erera commented on LUCENE-5525:
Looks good!
Implement MultiFacets.getAllDims
[
https://issues.apache.org/jira/browse/LUCENE-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13936049#comment-13936049
]
Shai Erera commented on LUCENE-5525:
Looks good, +1!
Implement
[
https://issues.apache.org/jira/browse/LUCENE-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13936050#comment-13936050
]
Shai Erera commented on LUCENE-5525:
I reviewed MultiCategoryListsFacetsExample.java
[
https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13936279#comment-13936279
]
Shai Erera commented on LUCENE-5189:
I checked the code and it looks the same
[
https://issues.apache.org/jira/browse/LUCENE-5527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13936430#comment-13936430
]
Shai Erera commented on LUCENE-5527:
Maybe we can get rid of setScorer, passing
[
https://issues.apache.org/jira/browse/LUCENE-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5438:
---
Fix Version/s: (was: 4.8)
(was: 5.0)
add near-real-time replication
[
https://issues.apache.org/jira/browse/LUCENE-5513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13932947#comment-13932947
]
Shai Erera commented on LUCENE-5513:
I'll upload a patch a bit later -- I've made
[
https://issues.apache.org/jira/browse/LUCENE-5513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5513:
---
Attachment: LUCENE-5513.patch
Patch:
* Add IW.updateBinaryDocValue
* Makes necessary changes to DW
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13931543#comment-13931543
]
Shai Erera commented on LUCENE-5476:
If it's not too much work for you, I think you
Shai Erera created LUCENE-5522:
--
Summary: FacetConfig doesn't add drill-down terms for facet
associations
Key: LUCENE-5522
URL: https://issues.apache.org/jira/browse/LUCENE-5522
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-5522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5522:
---
Attachment: LUCENE-5522.patch
Patch fixes FacetsConfig and adds tests to both demo and facet
[
https://issues.apache.org/jira/browse/LUCENE-5522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5522.
Resolution: Fixed
Committed to trunk and 4x.
FacetConfig doesn't add drill-down terms for facet
[
https://issues.apache.org/jira/browse/LUCENE-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13932255#comment-13932255
]
Shai Erera commented on LUCENE-4258:
Sunny, there are many issues w/ the current
[
https://issues.apache.org/jira/browse/LUCENE-5513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13932464#comment-13932464
]
Shai Erera commented on LUCENE-5513:
[~mkhludnev], I started working on this and made
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930111#comment-13930111
]
Shai Erera commented on LUCENE-5476:
* Javadocs:
** From the class javadocs: _Note
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13930121#comment-13930121
]
Shai Erera commented on LUCENE-5476:
bq. Thanks Shai, I really appreciate all
[
https://issues.apache.org/jira/browse/LUCENE-5513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925695#comment-13925695
]
Shai Erera commented on LUCENE-5513:
[~mkhludnev], great that you want to take
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925160#comment-13925160
]
Shai Erera commented on LUCENE-5476:
bq. Asserting seems redundant
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13922234#comment-13922234
]
Shai Erera commented on LUCENE-5476:
Thanks Rob. Few comments:
* I don't think
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13922884#comment-13922884
]
Shai Erera commented on LUCENE-5476:
bq. but any facet accumulation which would rely
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13922884#comment-13922884
]
Shai Erera edited comment on LUCENE-5476 at 3/6/14 6:56 PM
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13920771#comment-13920771
]
Shai Erera commented on LUCENE-5476:
bq. Actually, in my application, I always do
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13920897#comment-13920897
]
Shai Erera commented on LUCENE-5476:
bq. Well, I do a search of course, but collect
Hi Erick,
Lucene supports updating existing NumericDocValues fields in-place without
the need to re-index the documents since 4.6.0. But it currently only
supports changing existing fields' values, and does not allow adding new
fields to the index. If you want to make schema changes to the index
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919207#comment-13919207
]
Shai Erera commented on LUCENE-5476:
Thanks Rob. Few comments:
* Typo in jdoc
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919240#comment-13919240
]
Shai Erera edited comment on LUCENE-5476 at 3/4/14 10:57 AM
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919240#comment-13919240
]
Shai Erera commented on LUCENE-5476:
Looks good Rob. I apologize for not mentioning
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13919559#comment-13919559
]
Shai Erera commented on LUCENE-5476:
That's good point Gilad. I think once this gets
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13918164#comment-13918164
]
Shai Erera commented on LUCENE-5476:
+1 for removing SamplingParams.
I'm OK
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13917407#comment-13917407
]
Shai Erera edited comment on LUCENE-5476 at 3/2/14 1:24 PM:
I
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13917407#comment-13917407
]
Shai Erera commented on LUCENE-5476:
I reviewed createSample in the patch, and I
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13917407#comment-13917407
]
Shai Erera edited comment on LUCENE-5476 at 3/2/14 1:26 PM:
I
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13917165#comment-13917165
]
Shai Erera commented on LUCENE-5476:
About the patch:
* SampledDocs should be static
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13917304#comment-13917304
]
Shai Erera commented on LUCENE-5476:
I agree Mike. Rob wrote though in a previous
[
https://issues.apache.org/jira/browse/LUCENE-5370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13917309#comment-13917309
]
Shai Erera commented on LUCENE-5370:
What does sort by label mean? Do you ignore
[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13915762#comment-13915762
]
Shai Erera commented on LUCENE-5476:
This looks like a great start! I have few
[
https://issues.apache.org/jira/browse/LUCENE-5474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13914322#comment-13914322
]
Shai Erera commented on LUCENE-5474:
Looks good. Could you please:
* Create a .patch
[
https://issues.apache.org/jira/browse/LUCENE-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13914474#comment-13914474
]
Shai Erera commented on LUCENE-5479:
+1. Can you please document the method?
Make
+1, smoke tester says: SUCCESS!
Shai
On Thu, Feb 20, 2014 at 10:44 AM, Simon Willnauer simon.willna...@gmail.com
wrote:
Please vote for the first Release Candidate for Lucene/Solr 4.7.0
you can download it here:
Shai Erera created LUCENE-5460:
--
Summary: Allow driving a query by sparse filters
Key: LUCENE-5460
URL: https://issues.apache.org/jira/browse/LUCENE-5460
Project: Lucene - Core
Issue Type
701 - 800 of 4461 matches
Mail list logo
