[jira] [Resolved] (LUCENE-8588) Replace usage of deprecated RAMOutputStream

2018-12-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-8588. Resolution: Fixed Fix Version/s: 7.7 master (8.0) > Replace usage of

[jira] [Commented] (LUCENE-8588) Replace usage of deprecated RAMOutputStream

2018-12-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708780#comment-16708780 ] Shai Erera commented on LUCENE-8588: [~dweiss] thanks for pointing that out. I will not commit that

[jira] [Created] (LUCENE-8588) Replace usage of deprecated RAMOutputStream

2018-12-04 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-8588: -- Summary: Replace usage of deprecated RAMOutputStream Key: LUCENE-8588 URL: https://issues.apache.org/jira/browse/LUCENE-8588 Project: Lucene - Core Issue Type:

[jira] [Commented] (LUCENE-8397) Add DirectoryTaxonomyWriter.getCache

2018-07-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542887#comment-16542887 ] Shai Erera commented on LUCENE-8397: +1 > Add DirectoryTaxonomyWriter.getCache >

[jira] [Commented] (LUCENE-8272) Share internal DV update code between binary and numeric

2018-04-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449891#comment-16449891 ] Shai Erera commented on LUCENE-8272: I put some comments on the PR, but I don't see them mentioned

[jira] [Commented] (LUCENE-8060) Require users to tell us whether they need total hit counts

2017-11-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263175#comment-16263175 ] Shai Erera commented on LUCENE-8060: What if we conceptually remove {{TopDocs.totalHits}} and if

[jira] [Resolved] (SOLR-10505) Support terms' statistics for multiple fields in TermsComponent

2017-04-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved SOLR-10505. --- Resolution: Fixed Fix Version/s: master (7.0) 6.6 Pushed to master and

[jira] [Commented] (SOLR-10505) Support terms' statistics for multiple fields in TermsComponent

2017-04-18 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973296#comment-15973296 ] Shai Erera commented on SOLR-10505: --- All tests pass, if there are no objections, I'd like to commit

[jira] [Updated] (SOLR-10505) Support terms' statistics for multiple fields in TermsComponent

2017-04-17 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-10505: -- Attachment: SOLR-10505.patch Patch with tests. > Support terms' statistics for multiple fields in

[jira] [Created] (SOLR-10505) Support terms' statistics for multiple fields in TermsComponent

2017-04-17 Thread Shai Erera (JIRA)
Shai Erera created SOLR-10505: - Summary: Support terms' statistics for multiple fields in TermsComponent Key: SOLR-10505 URL: https://issues.apache.org/jira/browse/SOLR-10505 Project: Solr

[jira] [Resolved] (SOLR-10349) Add totalTermFreq support to TermsComponent

2017-03-28 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved SOLR-10349. --- Resolution: Fixed Pushed to master and branch_6x. > Add totalTermFreq support to TermsComponent >

[jira] [Updated] (SOLR-10349) Add totalTermFreq support to TermsComponent

2017-03-28 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-10349: -- Fix Version/s: 6.6 master (7.0) > Add totalTermFreq support to TermsComponent >

[jira] [Commented] (SOLR-10349) Add totalTermFreq support to TermsComponent

2017-03-25 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941838#comment-15941838 ] Shai Erera commented on SOLR-10349: --- If there are no objections, I'd like to commit that tomorrow. >

[jira] [Updated] (SOLR-10349) Add totalTermFreq support to TermsComponent

2017-03-23 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-10349: -- Attachment: SOLR-10349.patch That was a good comment [~joel.bernstein]!! I changed more code to adapt

[jira] [Commented] (SOLR-10349) Add totalTermFreq support to TermsComponent

2017-03-23 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15938277#comment-15938277 ] Shai Erera commented on SOLR-10349: --- Thanks [~joel.bernstein], the distributed test suggestion helped me

[jira] [Updated] (SOLR-10349) Add totalTermFreq support to TermsComponent

2017-03-23 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-10349: -- Attachment: SOLR-10349.patch Added CHANGES entry. > Add totalTermFreq support to TermsComponent >

[jira] [Updated] (SOLR-10349) Add totalTermFreq support to TermsComponent

2017-03-23 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-10349: -- Attachment: SOLR-10349.patch Patch implements the proposed addition. [~joel.bernstein], not sure if

[jira] [Created] (SOLR-10349) Add totalTermFreq support to TermsComponent

2017-03-23 Thread Shai Erera (JIRA)
Shai Erera created SOLR-10349: - Summary: Add totalTermFreq support to TermsComponent Key: SOLR-10349 URL: https://issues.apache.org/jira/browse/SOLR-10349 Project: Solr Issue Type: Improvement

[jira] [Commented] (LUCENE-7590) Add DocValues statistics helpers

2016-12-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15766325#comment-15766325 ] Shai Erera commented on LUCENE-7590: [~shia] where do you see that? I checked master and there's no

[jira] [Resolved] (LUCENE-7590) Add DocValues statistics helpers

2016-12-18 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-7590. Resolution: Fixed Fix Version/s: 6.4 master (7.0) Committed to master

[jira] [Updated] (LUCENE-7590) Add DocValues statistics helpers

2016-12-18 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-7590: --- Attachment: LUCENE-7590-sorted-set.patch Patch adds {{SortedDocValuesStats}} and

[jira] [Updated] (LUCENE-7590) Add DocValues statistics helpers

2016-12-17 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-7590: --- Attachment: LUCENE-7590-sorted-numeric.patch Patch adds DVStats for {{SortedNumericDocValuesField}}.

[jira] [Updated] (LUCENE-7590) Add DocValues statistics helpers

2016-12-15 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-7590: --- Attachment: LUCENE-7590-2.patch Patch adds {{sum}}, {{stdev}} and {{variance}} stats to

[jira] [Commented] (LUCENE-7590) Add DocValues statistics helpers

2016-12-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748192#comment-15748192 ] Shai Erera commented on LUCENE-7590: There are now few tasks left: * Add more statistics, such as

[jira] [Updated] (LUCENE-7590) Add DocValues statistics helpers

2016-12-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-7590: --- Attachment: LUCENE-7590.patch Patch changes {{DocValuesIterator}} package-private again and adds an

[jira] [Updated] (LUCENE-7590) Add DocValues statistics helpers

2016-12-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-7590: --- Attachment: LUCENE-7590.patch [~jpountz] I accept your proposal about missing, only in case a reader

[jira] [Commented] (LUCENE-7590) Add DocValues statistics helpers

2016-12-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745855#comment-15745855 ] Shai Erera commented on LUCENE-7590: bq. Instead of using a NOOP_COLLECTOR, you could throw a

[jira] [Updated] (LUCENE-7590) Add DocValues statistics helpers

2016-12-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-7590: --- Attachment: LUCENE-7590.patch Added tests for {{DoubleNumericDocValuesStats}}. Now that I review

[jira] [Updated] (LUCENE-7590) Add DocValues statistics helpers

2016-12-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-7590: --- Attachment: LUCENE-7590.patch Patch implements a {{DocValuesStatsCollector}}. Note some key design

[jira] [Commented] (LUCENE-7590) Add DocValues statistics helpers

2016-12-12 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743089#comment-15743089 ] Shai Erera commented on LUCENE-7590: bq. Let's implement the computation of these stats by writing a

[jira] [Updated] (LUCENE-7590) Add DocValues statistics helpers

2016-12-12 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-7590: --- Attachment: LUCENE-7590.patch > Add DocValues statistics helpers >

[jira] [Updated] (LUCENE-7590) Add DocValues statistics helpers

2016-12-12 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-7590: --- Attachment: LUCENE-7590.patch Thanks [~mikemccand] and [~thetaphi], I changed to a static class and

[jira] [Updated] (LUCENE-7590) Add DocValues statistics helpers

2016-12-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-7590: --- Attachment: LUCENE-7590.patch First patch adds numeric statistics. I'd appreciate comments about it

[jira] [Created] (LUCENE-7590) Add DocValues statistics helpers

2016-12-11 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-7590: -- Summary: Add DocValues statistics helpers Key: LUCENE-7590 URL: https://issues.apache.org/jira/browse/LUCENE-7590 Project: Lucene - Core Issue Type: New Feature

[jira] [Commented] (LUCENE-7344) Deletion by query of uncommitted docs not working with DV updates

2016-08-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414871#comment-15414871 ] Shai Erera commented on LUCENE-7344: bq. I don't understand most of what you're saying To clarify

[jira] [Commented] (SOLR-5944) Support updates of numeric DocValues

2016-08-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413974#comment-15413974 ] Shai Erera commented on SOLR-5944: -- [~ichattopadhyaya], I've continued the discussion in LUCENE-7344. I am

[jira] [Commented] (LUCENE-7344) Deletion by query of uncommitted docs not working with DV updates

2016-08-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413364#comment-15413364 ] Shai Erera commented on LUCENE-7344: After chatting with Mike about this, here's an example for an

[jira] [Updated] (LUCENE-7344) Deletion by query of uncommitted docs not working with DV updates

2016-08-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-7344: --- Attachment: LUCENE-7344.patch Patch applies the DBQ after resolving the DV updates. With this patch,

[jira] [Commented] (LUCENE-7344) Deletion by query of uncommitted docs not working with DV updates

2016-08-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413216#comment-15413216 ] Shai Erera commented on LUCENE-7344: Hmm ... I had to refresh my memory of the DV updates code and I

[jira] [Commented] (SOLR-9319) DELETEREPLICA should accept just count and remove replicas intelligenty

2016-07-19 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15384351#comment-15384351 ] Shai Erera commented on SOLR-9319: -- Thanks [~noble.paul]. The issue description is a bit misleading

[jira] [Commented] (SOLR-9319) DELETEREPLICA should accept just count and remove replicas intelligenty

2016-07-19 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15384301#comment-15384301 ] Shai Erera commented on SOLR-9319: -- What does "just count" mean? Will I not be able to delete a specific

[jira] [Commented] (SOLR-9290) TCP-connections in CLOSE_WAIT spikes during heavy indexing when SSL is enabled

2016-07-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376474#comment-15376474 ] Shai Erera commented on SOLR-9290: -- bq. Which begs the question: why are there 15 CLOSE_WAIT connections

[jira] [Commented] (SOLR-9290) TCP-connections in CLOSE_WAIT spikes during heavy indexing when SSL is enabled

2016-07-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375601#comment-15375601 ] Shai Erera commented on SOLR-9290: -- Oh I see. So we didn't experience the problem because we run w/ 2

[jira] [Commented] (SOLR-9290) TCP-connections in CLOSE_WAIT spikes during heavy indexing when SSL is enabled

2016-07-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375582#comment-15375582 ] Shai Erera commented on SOLR-9290: -- Regarding the patch, the monitor looks good. Few comments: * I prefer

[jira] [Commented] (SOLR-9290) TCP-connections in CLOSE_WAIT spikes during heavy indexing when SSL is enabled

2016-07-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375571#comment-15375571 ] Shai Erera commented on SOLR-9290: -- bq. Do you have only two replicas? Perhaps the maxConnectionsPerHost

[jira] [Commented] (SOLR-9290) TCP-connections in CLOSE_WAIT spikes during heavy indexing when SSL is enabled

2016-07-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375552#comment-15375552 ] Shai Erera commented on SOLR-9290: -- bq. I thought that hypothesis holds only after SOLR-8533. Are you

[jira] [Commented] (SOLR-9290) TCP-connections in CLOSE_WAIT spikes during heavy indexing when SSL is enabled

2016-07-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375548#comment-15375548 ] Shai Erera commented on SOLR-9290: -- Thanks [~shalinmangar]. Few questions: bq. Also, I think the reason

[jira] [Commented] (SOLR-9290) TCP-connections in CLOSE_WAIT spikes during heavy indexing when SSL is enabled

2016-07-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375500#comment-15375500 ] Shai Erera commented on SOLR-9290: -- Thanks [~yo...@apache.org], I'll read the issue. I agree with what

[jira] [Commented] (SOLR-9290) TCP-connections in CLOSE_WAIT spikes during heavy indexing when SSL is enabled

2016-07-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375184#comment-15375184 ] Shai Erera commented on SOLR-9290: -- Also [~markrmil...@gmail.com], for education purposes, if you have a

[jira] [Commented] (SOLR-9290) TCP-connections in CLOSE_WAIT spikes during heavy indexing when SSL is enabled

2016-07-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375151#comment-15375151 ] Shai Erera commented on SOLR-9290: -- Thanks [~markrmil...@gmail.com]. In that case, what's your take on the

[jira] [Commented] (SOLR-9290) TCP-connections in CLOSE_WAIT spikes during heavy indexing when SSL is enabled

2016-07-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375082#comment-15375082 ] Shai Erera commented on SOLR-9290: -- An update -- I've modified our solr.xml (which is basically the

[jira] [Commented] (SOLR-9290) TCP-connections in CLOSE_WAIT spikes during heavy indexing when SSL is enabled

2016-07-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374779#comment-15374779 ] Shai Erera commented on SOLR-9290: -- bq. Interestingly, the number of connections stuck in CLOSE_WAIT

[jira] [Commented] (LUCENE-7253) Sparse data in doc values and segments merging

2016-05-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268847#comment-15268847 ] Shai Erera commented on LUCENE-7253: I thought so, but that still needs to be benchmarked. Maybe

[jira] [Commented] (LUCENE-7253) Sparse data in doc values and segments merging

2016-05-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268770#comment-15268770 ] Shai Erera commented on LUCENE-7253: bq. Read some actual literature on column store databases, see

[jira] [Commented] (SOLR-9057) CloudSolrClient should be able to work w/o ZK url

2016-05-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268367#comment-15268367 ] Shai Erera commented on SOLR-9057: -- In CSC code I see that {{connect()}} is called from several places,

[jira] [Commented] (SOLR-9057) CloudSolrClient should be able to work w/o ZK url

2016-05-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268329#comment-15268329 ] Shai Erera commented on SOLR-9057: -- I thought that the whole idea of CSC is to use ZkStateReader so that

[jira] [Comment Edited] (SOLR-9057) CloudSolrClient should be able to work w/o ZK url

2016-05-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268315#comment-15268315 ] Shai Erera edited comment on SOLR-9057 at 5/3/16 7:49 AM: -- How will it initiate

[jira] [Commented] (SOLR-9057) CloudSolrClient should be able to work w/o ZK url

2016-05-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268315#comment-15268315 ] Shai Erera commented on SOLR-9057: -- How will it initiate {{ZkStateReader}} without getting the ZK host? Or

[jira] [Commented] (LUCENE-7253) Sparse data in doc values and segments merging

2016-05-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266764#comment-15266764 ] Shai Erera commented on LUCENE-7253: To add to the sparsity discussion, when I did the numeric DV

[jira] [Commented] (SOLR-9016) SolrIdentifierValidator accepts empty names

2016-04-27 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15259689#comment-15259689 ] Shai Erera commented on SOLR-9016: -- Thanks [~anshumg] for doing all the backports! >

[jira] [Commented] (SOLR-9016) SolrIdentifierValidator accepts empty names

2016-04-26 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258170#comment-15258170 ] Shai Erera commented on SOLR-9016: -- All tests pass, so if there are no objections, I'd like to push this

[jira] [Updated] (SOLR-9016) SolrIdentifierValidator accepts empty names

2016-04-26 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-9016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-9016: - Attachment: SOLR-9016.patch Patch fixes the regex to not accept empty identifiers, however it does not

[jira] [Created] (SOLR-9016) SolrIdentifierValidator accepts empty names

2016-04-20 Thread Shai Erera (JIRA)
Shai Erera created SOLR-9016: Summary: SolrIdentifierValidator accepts empty names Key: SOLR-9016 URL: https://issues.apache.org/jira/browse/SOLR-9016 Project: Solr Issue Type: Bug

[jira] [Resolved] (SOLR-8793) Fix stale commit files' size computation in LukeRequestHandler

2016-03-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved SOLR-8793. -- Resolution: Fixed Assignee: Shai Erera Fix Version/s: 5.5.1 master

[jira] [Commented] (SOLR-8728) Splitting a shard of a collection created with a rule fails with NPE

2016-03-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185223#comment-15185223 ] Shai Erera commented on SOLR-8728: -- We usually set the fix version to be e.g. "5.5" and "trunk/master".

[jira] [Updated] (SOLR-8793) Fix stale commit files' size computation in LukeRequestHandler

2016-03-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-8793: - Attachment: SOLR-8793.patch Patch fixes the bug by catching the {{IOException}} and returning -1. In that

[jira] [Commented] (SOLR-8728) Splitting a shard of a collection created with a rule fails with NPE

2016-03-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185200#comment-15185200 ] Shai Erera commented on SOLR-8728: -- This is marked as fixed in 6.0, but should it also be marked for

[jira] [Commented] (SOLR-8587) Add segments file information to core admin status

2016-03-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182640#comment-15182640 ] Shai Erera commented on SOLR-8587: -- OK yea you're right, I was confused. The file can be read by the open

[jira] [Created] (SOLR-8793) Fix stale commit files' size computation in LukeRequestHandler

2016-03-06 Thread Shai Erera (JIRA)
Shai Erera created SOLR-8793: Summary: Fix stale commit files' size computation in LukeRequestHandler Key: SOLR-8793 URL: https://issues.apache.org/jira/browse/SOLR-8793 Project: Solr Issue

[jira] [Commented] (SOLR-8587) Add segments file information to core admin status

2016-03-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182197#comment-15182197 ] Shai Erera commented on SOLR-8587: -- How can a changing index affect the code here. The code uses an

[jira] [Commented] (SOLR-8587) Add segments file information to core admin status

2016-03-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182185#comment-15182185 ] Shai Erera commented on SOLR-8587: -- I've just tried that on 5.5.0 and it seems to work without any

[jira] [Commented] (SOLR-8734) fix deprecation warnings for absent (maxMergeDocs|mergeFactor)

2016-02-25 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167049#comment-15167049 ] Shai Erera commented on SOLR-8734: -- Patch looks good. Even while working on the previous issue I thought

[jira] [Updated] (SOLR-8728) Splitting a shard of a collection created with a rule fails with NPE

2016-02-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-8728: - Attachment: SOLR-8728.patch If you run this test it fails and you can see this exception in the console:

[jira] [Created] (SOLR-8728) Splitting a shard of a collection created with a rule fails with NPE

2016-02-24 Thread Shai Erera (JIRA)
Shai Erera created SOLR-8728: Summary: Splitting a shard of a collection created with a rule fails with NPE Key: SOLR-8728 URL: https://issues.apache.org/jira/browse/SOLR-8728 Project: Solr

[jira] [Commented] (SOLR-7668) Port-base rule for shard placement causes NPE

2016-02-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15162918#comment-15162918 ] Shai Erera commented on SOLR-7668: -- Is this not resolved already? > Port-base rule for shard placement

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155909#comment-15155909 ] Shai Erera commented on SOLR-8621: -- Looks good [~cpoerschke]! And yes, let's be consistent and keep the

[jira] [Commented] (SOLR-8674) transition from solr.tests.mergePolicy to solr.tests.mergePolicyFactory

2016-02-19 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154396#comment-15154396 ] Shai Erera commented on SOLR-8674: -- Patch looks good! > transition from solr.tests.mergePolicy to

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-19 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154388#comment-15154388 ] Shai Erera commented on SOLR-8621: -- I am not sure how to comment on those pages, so I'll comment here:

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

2016-02-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146678#comment-15146678 ] Shai Erera commented on SOLR-8677: -- I don't mind either way Jason. Either you add it to this patch, and

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

2016-02-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146458#comment-15146458 ] Shai Erera commented on SOLR-8677: -- Looks good to me. [~gerlowskija] I know it's not strictly related to

[jira] [Commented] (SOLR-8677) SOLR allows creation of shards with invalid names.

2016-02-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146459#comment-15146459 ] Shai Erera commented on SOLR-8677: -- Also, would u mind adding a CHANGES.txt entry too? > SOLR allows

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142568#comment-15142568 ] Shai Erera commented on SOLR-8621: -- Can you point me to a test failure? > solrconfig.xml:

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142613#comment-15142613 ] Shai Erera commented on SOLR-8621: -- Thanks I'll take a look. > solrconfig.xml: deprecate/replace with >

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143618#comment-15143618 ] Shai Erera commented on SOLR-8621: -- [~cpoerschke] these look good, so +1 to merge to 5x. I agree that

[jira] [Commented] (SOLR-5730) make Lucene's SortingMergePolicy and EarlyTerminatingSortingCollector configurable in Solr

2016-02-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143646#comment-15143646 ] Shai Erera commented on SOLR-5730: -- Patch looks good! One minor comment -- in

[jira] [Commented] (LUCENE-7020) TieredMergePolicy - cascade maxMergeAtOnce setting to maxMergeAtOnceExplicit

2016-02-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140762#comment-15140762 ] Shai Erera commented on LUCENE-7020: I don't see how {{maxMergeAtOnce}} and

[jira] [Commented] (LUCENE-7020) TieredMergePolicy - cascade maxMergeAtOnce setting to maxMergeAtOnceExplicit

2016-02-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140902#comment-15140902 ] Shai Erera commented on LUCENE-7020: bq. I think users who have very large indexes are more likely

[jira] [Updated] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-8621: - Attachment: SOLR-8621-example_contrib_configs.patch [~cpoerschke] if you're OK with this patch, I'll

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140888#comment-15140888 ] Shai Erera commented on SOLR-8621: -- You're right Christine, I didn't notice the {{IndexSchema}} only

[jira] [Commented] (LUCENE-7020) TieredMergePolicy - cascade maxMergeAtOnce setting to maxMergeAtOnceExplicit

2016-02-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141065#comment-15141065 ] Shai Erera commented on LUCENE-7020: Sure, that's expected behavior and is noted as cascaded merges.

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140753#comment-15140753 ] Shai Erera commented on SOLR-8621: -- Good catch, I just blindly moved that 'mergeFactor' in :). I'll remove

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142095#comment-15142095 ] Shai Erera commented on SOLR-8621: -- [~cpoerschke] thx for fixing that typo! And your latest commit looks

[jira] [Commented] (SOLR-5730) make Lucene's SortingMergePolicy and EarlyTerminatingSortingCollector configurable in Solr

2016-02-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15142109#comment-15142109 ] Shai Erera commented on SOLR-5730: -- Few comments about the patch: * In QueryComponent:

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138848#comment-15138848 ] Shai Erera commented on SOLR-8621: -- [~cpoerschke]: OK so let's do the following: * Move all

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138897#comment-15138897 ] Shai Erera commented on SOLR-8621: -- bq. Could I take on the Sure. You lead this, I'm only here to help

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15140147#comment-15140147 ] Shai Erera commented on SOLR-8621: -- bq. Could you take care of the solr/contrib and solr/example

[jira] [Created] (SOLR-8668) Remove support for

2016-02-09 Thread Shai Erera (JIRA)
Shai Erera created SOLR-8668: Summary: Remove support for Key: SOLR-8668 URL: https://issues.apache.org/jira/browse/SOLR-8668 Project: Solr Issue Type: Improvement Reporter: Shai

[jira] [Updated] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-8621: - Attachment: SOLR-8621-example_contrib_configs.patch Patch changes solrconfig.xmls under solr/contrib and

[jira] [Updated] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-8621: - Attachment: SOLR-8621.patch [~cpoerschke], patch includes the changes from *all* commits that we've pushed

[jira] [Commented] (SOLR-8621) solrconfig.xml: deprecate/replace with

2016-02-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136886#comment-15136886 ] Shai Erera commented on SOLR-8621: -- {quote} Unrelated to the above, just pushed changes to

  1   2   3   4   5   6   7   8   9   10   >