[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282965#comment-16282965
]
Cao Manh Dat commented on SOLR-9555:
[~mdrob] [~markrmil...@gmail.com] please take a look at my recent
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187552#comment-16187552
]
Erick Erickson commented on SOLR-9555:
--
Must have hit the "assign to me" link by accident.
> Leader
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138255#comment-16138255
]
Cao Manh Dat commented on SOLR-9555:
Great work [~mdrob], but there are one thing that I concern about
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987167#comment-15987167
]
Mark Miller commented on SOLR-9555:
---
Okay, even with SOLR-10525, I did hit that same fail. I'll try and
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986889#comment-15986889
]
Mark Miller commented on SOLR-9555:
---
I've seen ChaosMonkeySafeLeaderTest hang once in a previous patch
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986849#comment-15986849
]
Mark Miller commented on SOLR-9555:
---
I didn't have the other patch in. Got one success after putting that
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986760#comment-15986760
]
Mark Miller commented on SOLR-9555:
---
one fail I've seen:
{noformat} [junit4] FAILURE 49.9s J1 |
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985465#comment-15985465
]
Mike Drob commented on SOLR-9555:
-
Noticed that on that check if it hits the follower it gets 2 docs, and
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981644#comment-15981644
]
Mark Miller commented on SOLR-9555:
---
bq. If it's still bad,
Ah, ok, if you throttle with the watch
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981615#comment-15981615
]
Mark Miller commented on SOLR-9555:
---
haven't caught up on your comments yet, but FYI, I've been seeing
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981460#comment-15981460
]
Mike Drob commented on SOLR-9555:
-
Looking at my patch again, I can't tell if there is a really subtle bug
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981298#comment-15981298
]
Mike Drob commented on SOLR-9555:
-
bq. I think we should take this opportunity to stop trying to do LIR per
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980742#comment-15980742
]
Mark Miller commented on SOLR-9555:
---
We can open a new issue on that realistically if we don't want to
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980740#comment-15980740
]
Mark Miller commented on SOLR-9555:
---
I commented a bit more about this in SOLR-10525, but the gist is, I
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979840#comment-15979840
]
Shalin Shekhar Mangar commented on SOLR-9555:
-
Thanks Mike, I'll review it on Monday.
> Leader
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974813#comment-15974813
]
Mark Miller commented on SOLR-9555:
---
If everything else is in order though, I can try and tackle that
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974808#comment-15974808
]
Mark Miller commented on SOLR-9555:
---
bq. So I get the impression that closing a proxy only prevents
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974803#comment-15974803
]
Mark Miller commented on SOLR-9555:
---
bq. We close the followers' connections, and then need to send a doc
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969819#comment-15969819
]
Mark Miller commented on SOLR-9555:
---
And I suppose to hit the leader we would have to hit the actual
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969818#comment-15969818
]
Mark Miller commented on SOLR-9555:
---
We would probably also have to be sure and index directly to the
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969337#comment-15969337
]
Mark Miller commented on SOLR-9555:
---
Instead we would do:
{code}
// ok, now introduce a network
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969334#comment-15969334
]
Mark Miller commented on SOLR-9555:
---
more precisely, if the issue is as stated, it would seem the problem
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969221#comment-15969221
]
Mark Miller commented on SOLR-9555:
---
Maybe we can just close the leader proxy before we index the docs.
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969203#comment-15969203
]
Mark Miller commented on SOLR-9555:
---
I suppose that depends on if it's the same as removing force leader
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969172#comment-15969172
]
Mike Drob commented on SOLR-9555:
-
I guess I was unclear. I meant to rip the proxy stuff out _from this
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969139#comment-15969139
]
Mark Miller commented on SOLR-9555:
---
My first thought would be to guess that ForceLeaderTest is just
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969127#comment-15969127
]
Mark Miller commented on SOLR-9555:
---
bq. I think this is big problem for our jetty proxy stuff, right?
I
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969118#comment-15969118
]
Mike Drob commented on SOLR-9555:
-
[~caomanhdat] - yea, ForceLeaderTest was one of the ones that was
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964649#comment-15964649
]
Cao Manh Dat commented on SOLR-9555:
I'm looking at the patch and It seems that {{ForceLeaderTest}} is
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888501#comment-15888501
]
Mark Miller commented on SOLR-9555:
---
This is a great start Mike, I'll take a look. One thing I have been
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836899#comment-15836899
]
Mark Miller commented on SOLR-9555:
---
bq. The potential downside here is that we end up keeping two copies
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836870#comment-15836870
]
Mike Drob commented on SOLR-9555:
-
I've been thinking about this a bunch and have some observations.
We
[
https://issues.apache.org/jira/browse/SOLR-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830288#comment-15830288
]
Mark Miller commented on SOLR-9555:
---
bq. A replica should only ever publish its own state.
To be more
33 matches
Mail list logo
