[
https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210899#comment-16210899
]
Robert Muir commented on SOLR-11490:
bq. What am I missing?
That these solr version n
[
https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209138#comment-16209138
]
Robert Muir commented on SOLR-11490:
Can you please back out the change to TokenFilter
[
https://issues.apache.org/jira/browse/LUCENE-7997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208515#comment-16208515
]
Robert Muir commented on LUCENE-7997:
-
Exactly we need a picky base sim test for this
[
https://issues.apache.org/jira/browse/LUCENE-7996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208509#comment-16208509
]
Robert Muir commented on LUCENE-7996:
-
+1 we try to fix similarities that produce neg
[
https://issues.apache.org/jira/browse/LUCENE-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206903#comment-16206903
]
Robert Muir commented on LUCENE-7994:
-
I am confused about the heuristic, can you exp
[
https://issues.apache.org/jira/browse/LUCENE-7993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204642#comment-16204642
]
Robert Muir commented on LUCENE-7993:
-
feel free to open separate issue for the sim t
[
https://issues.apache.org/jira/browse/LUCENE-7993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204641#comment-16204641
]
Robert Muir commented on LUCENE-7993:
-
ok, i get it, the optimization is ok since we
[
https://issues.apache.org/jira/browse/LUCENE-7993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204639#comment-16204639
]
Robert Muir commented on LUCENE-7993:
-
{quote}
if we can assume that the score increa
[
https://issues.apache.org/jira/browse/LUCENE-4100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204134#comment-16204134
]
Robert Muir commented on LUCENE-4100:
-
Thanks for the benchmarking! It is unfortunate
[
https://issues.apache.org/jira/browse/LUCENE-4100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16203693#comment-16203693
]
Robert Muir commented on LUCENE-4100:
-
yeah, I think i am looking at it from the top-
[
https://issues.apache.org/jira/browse/LUCENE-4100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16203603#comment-16203603
]
Robert Muir commented on LUCENE-4100:
-
{quote}
Sorry I wrote needsTotalHits because t
[
https://issues.apache.org/jira/browse/LUCENE-4100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16203384#comment-16203384
]
Robert Muir commented on LUCENE-4100:
-
{quote}
This is what I wanted to do first but
[
https://issues.apache.org/jira/browse/LUCENE-4100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16203051#comment-16203051
]
Robert Muir commented on LUCENE-4100:
-
Can we avoid the ScoreMode.merge? This seems r
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191428#comment-16191428
]
Robert Muir commented on LUCENE-7976:
-
{quote}
It's too bad people call forceMerge an
[
https://issues.apache.org/jira/browse/LUCENE-7980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183109#comment-16183109
]
Robert Muir commented on LUCENE-7980:
-
I don't think we should do this, thats more co
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170407#comment-16170407
]
Robert Muir commented on LUCENE-7966:
-
thanks for the clarification. yes, that's no c
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170382#comment-16170382
]
Robert Muir commented on LUCENE-7966:
-
{quote}
WARNING: We cannot support Maven build
[
https://issues.apache.org/jira/browse/LUCENE-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-7968.
-
Resolution: Fixed
Fix Version/s: 7.1
master (8.0)
> AnalyzingSuggester'
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169324#comment-16169324
]
Robert Muir commented on LUCENE-7966:
-
Mike, is it possible the benchmark didn't warm
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169305#comment-16169305
]
Robert Muir commented on LUCENE-7966:
-
{quote}
does the patch even change code relate
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168265#comment-16168265
]
Robert Muir commented on LUCENE-7966:
-
Adrien, thanks for benchmarking!
> build mr-j
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165331#comment-16165331
]
Robert Muir commented on LUCENE-7966:
-
Adrien also mentioned the change to BytesRef.c
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165323#comment-16165323
]
Robert Muir commented on LUCENE-7966:
-
[~jpountz] Maybe you can experiment with the L
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-7966:
Attachment: LUCENE-7966.patch
Updated patch implementing LZ4.commonBytes with mismatch.
> build mr
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-7966:
Attachment: LUCENE-7966.patch
I updated the patch with more cleanups: nuked the older ArrayUtil met
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-7966:
Attachment: LUCENE-7966.patch
Same patch, just folding in the suggester bugfix (LUCENE-7968) so tha
[
https://issues.apache.org/jira/browse/LUCENE-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164001#comment-16164001
]
Robert Muir commented on LUCENE-7968:
-
>From what I can tell, since the stuff going i
[
https://issues.apache.org/jira/browse/LUCENE-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-7968:
Attachment: LUCENE-7968.patch
Patch, including a test that fails even without the assert. It just a
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163942#comment-16163942
]
Robert Muir commented on LUCENE-7966:
-
I opened LUCENE-7968 for the suggester case fa
[
https://issues.apache.org/jira/browse/LUCENE-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163940#comment-16163940
]
Robert Muir commented on LUCENE-7968:
-
Here's an assert that can currently make tests
Robert Muir created LUCENE-7968:
---
Summary: AnalyzingSuggester's comparator compares incorrectly
Key: LUCENE-7968
URL: https://issues.apache.org/jira/browse/LUCENE-7968
Project: Lucene - Core
Is
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162905#comment-16162905
]
Robert Muir commented on LUCENE-7966:
-
{quote}
There's another dimension to your list
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162820#comment-16162820
]
Robert Muir commented on LUCENE-7966:
-
Dawid: i didn't really add new checks in the p
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-7966:
Attachment: LUCENE-7966.patch
Updated patch. I fixed the fallout better (don't encode wasteful byte
[
https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-7966:
Attachment: LUCENE-7966.patch
Here's my current patch. Need to look into the AnalyzingSuggester abu
Robert Muir created LUCENE-7966:
---
Summary: build mr-jar and use some java 9 methods if available
Key: LUCENE-7966
URL: https://issues.apache.org/jira/browse/LUCENE-7966
Project: Lucene - Core
I
[
https://issues.apache.org/jira/browse/LUCENE-7961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-7961:
Attachment: LUCENE-7961.patch
I fixed a bug in my comment and clarified that windows case.
> Simpl
[
https://issues.apache.org/jira/browse/LUCENE-7961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159786#comment-16159786
]
Robert Muir commented on LUCENE-7961:
-
We can of course add a test like LUCENE-7959,
[
https://issues.apache.org/jira/browse/LUCENE-7961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-7961:
Attachment: LUCENE-7961.patch
Here's a patch.
> SimpleFSLockFactory should catch+box IOException (
[
https://issues.apache.org/jira/browse/LUCENE-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-7959.
-
Resolution: Fixed
Fix Version/s: 7.1
master (8.0)
Thanks [~erickerickso
[
https://issues.apache.org/jira/browse/LUCENE-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158657#comment-16158657
]
Robert Muir commented on LUCENE-7963:
-
By the way, this is almost exactly the same si
[
https://issues.apache.org/jira/browse/LUCENE-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158598#comment-16158598
]
Robert Muir commented on LUCENE-7963:
-
Yeah, the method is not without side effects.
[
https://issues.apache.org/jira/browse/LUCENE-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158520#comment-16158520
]
Robert Muir commented on LUCENE-7963:
-
{quote}
Unfortunately, it is beyond me why wri
[
https://issues.apache.org/jira/browse/LUCENE-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-7959:
Attachment: LUCENE-7959.patch
updated patch with a test like [~thetaphi] suggests.
> Throw more he
[
https://issues.apache.org/jira/browse/LUCENE-7961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156116#comment-16156116
]
Robert Muir commented on LUCENE-7961:
-
And to prevent confusion I think the exception
Robert Muir created LUCENE-7961:
---
Summary: SimpleFSLockFactory should catch+box IOException (not
FileAlreadyExistsException | AccessDeniedException)
Key: LUCENE-7961
URL: https://issues.apache.org/jira/browse/LUCENE
[
https://issues.apache.org/jira/browse/LUCENE-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156080#comment-16156080
]
Robert Muir commented on LUCENE-7959:
-
{quote}
bq: If you get lockobtainfailedexc, it
[
https://issues.apache.org/jira/browse/LUCENE-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-7959:
Description:
This is one of those small changes that would save a lot of pain for end users.
Let'
[
https://issues.apache.org/jira/browse/LUCENE-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156052#comment-16156052
]
Robert Muir commented on LUCENE-7959:
-
{quote}
The errors currently returned are misl
[
https://issues.apache.org/jira/browse/LUCENE-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155762#comment-16155762
]
Robert Muir commented on LUCENE-7959:
-
Erick well i still think there is confusion in
[
https://issues.apache.org/jira/browse/LUCENE-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-7959:
Attachment: LUCENE-7959_untested.patch
Here is just demonstrating my idea, i think its pretty conse
[
https://issues.apache.org/jira/browse/LUCENE-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155674#comment-16155674
]
Robert Muir commented on LUCENE-7959:
-
{quote}
An exception is thrown later, but it'
[
https://issues.apache.org/jira/browse/LUCENE-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155660#comment-16155660
]
Robert Muir commented on LUCENE-7959:
-
We can't do sneaky stuff like what you propose
[
https://issues.apache.org/jira/browse/LUCENE-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155640#comment-16155640
]
Robert Muir commented on LUCENE-7959:
-
by the way, if you have a permissions issue wh
[
https://issues.apache.org/jira/browse/LUCENE-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155620#comment-16155620
]
Robert Muir commented on LUCENE-7959:
-
The code is correct: its not possible to catch
[
https://issues.apache.org/jira/browse/LUCENE-7953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154661#comment-16154661
]
Robert Muir commented on LUCENE-7953:
-
{quote}
but ... it's not so easy to identify w
[
https://issues.apache.org/jira/browse/LUCENE-7940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154653#comment-16154653
]
Robert Muir commented on LUCENE-7940:
-
Go for it! FYI I backported this to lucene 7.x
[
https://issues.apache.org/jira/browse/LUCENE-7940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-7940.
-
Resolution: Fixed
Thank you [~sunkuet02] for this contribution!
> Bengali Analyzer for Lucene
>
[
https://issues.apache.org/jira/browse/LUCENE-7940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-7940:
Fix Version/s: 7.1
master (8.0)
> Bengali Analyzer for Lucene
>
[
https://issues.apache.org/jira/browse/LUCENE-7953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154463#comment-16154463
]
Robert Muir commented on LUCENE-7953:
-
Mike, can't you do some magic in your bindings
[
https://issues.apache.org/jira/browse/LUCENE-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153440#comment-16153440
]
Robert Muir commented on LUCENE-7956:
-
Looks good.
nit/style: the test was difficult
[
https://issues.apache.org/jira/browse/LUCENE-7954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153435#comment-16153435
]
Robert Muir commented on LUCENE-7954:
-
I don't think we should do this, this filter i
[
https://issues.apache.org/jira/browse/LUCENE-7940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150062#comment-16150062
]
Robert Muir commented on LUCENE-7940:
-
I took a deeper look, I like it. I'm able to r
[
https://issues.apache.org/jira/browse/LUCENE-7946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-7946.
-
Resolution: Fixed
Fix Version/s: 7.1
master (8.0)
> CharTermAttributeIm
[
https://issues.apache.org/jira/browse/LUCENE-7940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148706#comment-16148706
]
Robert Muir commented on LUCENE-7940:
-
Thanks for the update, I will check it out ton
[
https://issues.apache.org/jira/browse/LUCENE-7940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148458#comment-16148458
]
Robert Muir commented on LUCENE-7940:
-
I created LUCENE-7946 to improve the debugging
[
https://issues.apache.org/jira/browse/LUCENE-7946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-7946:
Attachment: LUCENE-7946.patch
> CharTermAttributeImpl.setLength missing bounds check
>
Robert Muir created LUCENE-7946:
---
Summary: CharTermAttributeImpl.setLength missing bounds check
Key: LUCENE-7946
URL: https://issues.apache.org/jira/browse/LUCENE-7946
Project: Lucene - Core
Is
[
https://issues.apache.org/jira/browse/LUCENE-7940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148355#comment-16148355
]
Robert Muir commented on LUCENE-7940:
-
I ran some basic tests, but encountered some i
[
https://issues.apache.org/jira/browse/LUCENE-7490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140032#comment-16140032
]
Robert Muir commented on LUCENE-7490:
-
I think this was just a typo in the pull reque
[
https://issues.apache.org/jira/browse/LUCENE-7940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140020#comment-16140020
]
Robert Muir commented on LUCENE-7940:
-
Thanks for your work here [~sunkuet02]! At a g
[
https://issues.apache.org/jira/browse/LUCENE-7928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123311#comment-16123311
]
Robert Muir commented on LUCENE-7928:
-
But this unnecessarily raises the surface area
[
https://issues.apache.org/jira/browse/LUCENE-7928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123293#comment-16123293
]
Robert Muir commented on LUCENE-7928:
-
I don't think these classes shoudl be public,
[
https://issues.apache.org/jira/browse/LUCENE-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118507#comment-16118507
]
Robert Muir commented on LUCENE-7920:
-
True, but I think it only does recognition, co
[
https://issues.apache.org/jira/browse/LUCENE-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118486#comment-16118486
]
Robert Muir commented on LUCENE-7920:
-
And again, i think this is all a lot of comple
[
https://issues.apache.org/jira/browse/LUCENE-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118483#comment-16118483
]
Robert Muir commented on LUCENE-7920:
-
I agree its an interesting idea, but i am worr
[
https://issues.apache.org/jira/browse/LUCENE-7916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-7916.
-
Resolution: Fixed
Thanks [~ckoenig42] !
> CompositeBreakIterator is brittle under ICU4J upgrade.
[
https://issues.apache.org/jira/browse/LUCENE-7916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-7916:
Fix Version/s: 7.1
master (8.0)
> CompositeBreakIterator is brittle under ICU4J
[
https://issues.apache.org/jira/browse/LUCENE-7916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117625#comment-16117625
]
Robert Muir commented on LUCENE-7916:
-
My patch needs a minor correction when committ
[
https://issues.apache.org/jira/browse/LUCENE-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117588#comment-16117588
]
Robert Muir commented on LUCENE-7920:
-
And i would duplicate the null checks so that
[
https://issues.apache.org/jira/browse/LUCENE-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117586#comment-16117586
]
Robert Muir commented on LUCENE-7920:
-
If we decide to do this we should think about
[
https://issues.apache.org/jira/browse/LUCENE-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117325#comment-16117325
]
Robert Muir commented on LUCENE-7920:
-
I'm concerned this is really the right thing t
[
https://issues.apache.org/jira/browse/LUCENE-7916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111977#comment-16111977
]
Robert Muir commented on LUCENE-7916:
-
{quote}
In our case, we are using ICUTokenizer
[
https://issues.apache.org/jira/browse/LUCENE-7916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-7916:
Attachment: LUCENE-7916.patch
Attached is my patch. We need to remove the deprecated constant anywa
[
https://issues.apache.org/jira/browse/LUCENE-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110223#comment-16110223
]
Robert Muir commented on LUCENE-7914:
-
Patch looks good to me. I think there are some
[
https://issues.apache.org/jira/browse/LUCENE-7902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110215#comment-16110215
]
Robert Muir commented on LUCENE-7902:
-
Personally I think the IndexWriterConfig thing
[
https://issues.apache.org/jira/browse/LUCENE-7916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110213#comment-16110213
]
Robert Muir commented on LUCENE-7916:
-
We should not change datastructures when all t
[
https://issues.apache.org/jira/browse/LUCENE-7916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109384#comment-16109384
]
Robert Muir commented on LUCENE-7916:
-
We use lots of version-dependent stuff (such a
[
https://issues.apache.org/jira/browse/LUCENE-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108895#comment-16108895
]
Robert Muir commented on LUCENE-7914:
-
And these comments above are just for discussi
[
https://issues.apache.org/jira/browse/LUCENE-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108892#comment-16108892
]
Robert Muir commented on LUCENE-7914:
-
ok, thanks.
As far as finite stuff, we might
[
https://issues.apache.org/jira/browse/LUCENE-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108799#comment-16108799
]
Robert Muir commented on LUCENE-7914:
-
I don't understand the serialization/deseriali
[
https://issues.apache.org/jira/browse/LUCENE-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108729#comment-16108729
]
Robert Muir commented on LUCENE-7914:
-
Sorry, but prefixquery is definitely infinite.
[
https://issues.apache.org/jira/browse/LUCENE-7905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085535#comment-16085535
]
Robert Muir commented on LUCENE-7905:
-
thanks Mike!
> Optimizations for OrdinalMap
>
[
https://issues.apache.org/jira/browse/LUCENE-7905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085139#comment-16085139
]
Robert Muir commented on LUCENE-7905:
-
I think its good to pull out OrdinalMap into i
[
https://issues.apache.org/jira/browse/LUCENE-7905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084349#comment-16084349
]
Robert Muir commented on LUCENE-7905:
-
{quote}
That's it, except I also changed:
[
https://issues.apache.org/jira/browse/LUCENE-7905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084128#comment-16084128
]
Robert Muir commented on LUCENE-7905:
-
Its a bit tricky to see the diffs since the fi
[
https://issues.apache.org/jira/browse/LUCENE-7905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084136#comment-16084136
]
Robert Muir commented on LUCENE-7905:
-
>From your explain that MTE must do more work
[
https://issues.apache.org/jira/browse/LUCENE-7895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073514#comment-16073514
]
Robert Muir commented on LUCENE-7895:
-
Should we really add hooks for such inefficien
Robert Muir created LUCENE-7892:
---
Summary: LatLonDocValuesField methods should be clearly marked as
slow
Key: LUCENE-7892
URL: https://issues.apache.org/jira/browse/LUCENE-7892
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059220#comment-16059220
]
Robert Muir commented on LUCENE-7867:
-
This clones Token into solr sources without it
601 - 700 of 11142 matches
Mail list logo
