[jira] [Commented] (LUCENE-8978) "Max Bottom" Based Early Termination For Concurrent Search

2019-09-13 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929280#comment-16929280 ] Atri Sharma commented on LUCENE-8978: - Both the runs are for wikimedium2m with concurrent searches

[jira] [Commented] (LUCENE-8978) "Max Bottom" Based Early Termination For Concurrent Search

2019-09-13 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929277#comment-16929277 ] Atri Sharma commented on LUCENE-8978: - Run with propagating global minimum scores ||Task

[jira] [Commented] (LUCENE-8978) "Max Bottom" Based Early Termination For Concurrent Search

2019-09-13 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929030#comment-16929030 ] Atri Sharma commented on LUCENE-8978: - ||Task ('HighSpanNear', None)||P50 Base 11.060489||P50 Cmp

[jira] [Created] (LUCENE-8978) "Max Bottom" Based Early Termination For Concurrent Search

2019-09-12 Thread Atri Sharma (Jira)
Atri Sharma created LUCENE-8978: --- Summary: "Max Bottom" Based Early Termination For Concurrent Search Key: LUCENE-8978 URL: https://issues.apache.org/jira/browse/LUCENE-8978 Project: Lucene - Core

[jira] [Commented] (LUCENE-7282) search APIs should take advantage of index sort by default

2019-09-10 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926845#comment-16926845 ] Atri Sharma commented on LUCENE-7282: - I think LUCENE-7714 does a similar thing for range queries.

[jira] [Created] (LUCENE-8974) Shared Bottom Score Based Early Termination For Concurrent Search

2019-09-10 Thread Atri Sharma (Jira)
Atri Sharma created LUCENE-8974: --- Summary: Shared Bottom Score Based Early Termination For Concurrent Search Key: LUCENE-8974 URL: https://issues.apache.org/jira/browse/LUCENE-8974 Project: Lucene -

[jira] [Commented] (LUCENE-8970) TopFieldCollector(s) Should Prepopulate Sentinel Objects

2019-09-10 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926480#comment-16926480 ] Atri Sharma commented on LUCENE-8970: - I did a prototype of this –- it is a bit hairy since, unlike

[jira] [Created] (LUCENE-8970) TopFieldCollector(s) Should Prepopulate Sentinel Objects

2019-09-06 Thread Atri Sharma (Jira)
Atri Sharma created LUCENE-8970: --- Summary: TopFieldCollector(s) Should Prepopulate Sentinel Objects Key: LUCENE-8970 URL: https://issues.apache.org/jira/browse/LUCENE-8970 Project: Lucene - Core

[jira] [Commented] (LUCENE-8963) Allow Collectors To "Publish" If They Can Be Used In Concurrent Search

2019-09-04 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16922322#comment-16922322 ] Atri Sharma commented on LUCENE-8963: - Yeah, I agree.   My only gripe is that in case a collector

[jira] [Created] (LUCENE-8963) Allow Collectors To "Publish" If They Can Be Used In Concurrent Search

2019-09-04 Thread Atri Sharma (Jira)
Atri Sharma created LUCENE-8963: --- Summary: Allow Collectors To "Publish" If They Can Be Used In Concurrent Search Key: LUCENE-8963 URL: https://issues.apache.org/jira/browse/LUCENE-8963 Project: Lucene

[jira] [Commented] (LUCENE-8403) Support 'filtered' term vectors - don't require all terms to be present

2019-08-29 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918358#comment-16918358 ] Atri Sharma commented on LUCENE-8403: - David, sorry for the delay in response – this somehow was

[jira] [Created] (LUCENE-8958) Add Shared Count Based Concurrent Early Termination For TopScoreDocCollector

2019-08-28 Thread Atri Sharma (Jira)
Atri Sharma created LUCENE-8958: --- Summary: Add Shared Count Based Concurrent Early Termination For TopScoreDocCollector Key: LUCENE-8958 URL: https://issues.apache.org/jira/browse/LUCENE-8958 Project:

[jira] [Commented] (LUCENE-8403) Support 'filtered' term vectors - don't require all terms to be present

2019-08-27 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916404#comment-16916404 ] Atri Sharma commented on LUCENE-8403: - Thanks for reviewing, David.   I did notice a CheckHits

[jira] [Commented] (LUCENE-8403) Support 'filtered' term vectors - don't require all terms to be present

2019-08-25 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915472#comment-16915472 ] Atri Sharma commented on LUCENE-8403: - Any thoughts on this one? > Support 'filtered' term vectors

[jira] [Commented] (LUCENE-8950) FieldComparators Should Not Maintain Implicit PQs

2019-08-14 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907093#comment-16907093 ] Atri Sharma commented on LUCENE-8950: - {quote}you would like to introduce a sub class of

[jira] [Commented] (LUCENE-8950) FieldComparators Should Not Maintain Implicit PQs

2019-08-14 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907075#comment-16907075 ] Atri Sharma commented on LUCENE-8950: - {quote}This looks like a duplicate of LUCENE-8878? {quote}

[jira] [Commented] (LUCENE-8950) FieldComparators Should Not Maintain Implicit PQs

2019-08-14 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906978#comment-16906978 ] Atri Sharma commented on LUCENE-8950: - I confess I do not have a very clean idea as to how this can

[jira] [Created] (LUCENE-8950) FieldComparators Should Not Maintain Implicit PQs

2019-08-14 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8950: --- Summary: FieldComparators Should Not Maintain Implicit PQs Key: LUCENE-8950 URL: https://issues.apache.org/jira/browse/LUCENE-8950 Project: Lucene - Core

[jira] [Created] (LUCENE-8949) Allow LeafFieldComparators to publish feature values

2019-08-12 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8949: --- Summary: Allow LeafFieldComparators to publish feature values Key: LUCENE-8949 URL: https://issues.apache.org/jira/browse/LUCENE-8949 Project: Lucene - Core

[jira] [Commented] (LUCENE-8213) Cache costly subqueries asynchronously

2019-08-05 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900160#comment-16900160 ] Atri Sharma commented on LUCENE-8213: - I raised a PR for the same. The performance number from newly

[jira] [Created] (LUCENE-8946) LRUQueryCache#doCache Should Be More Verbose

2019-08-05 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8946: --- Summary: LRUQueryCache#doCache Should Be More Verbose Key: LUCENE-8946 URL: https://issues.apache.org/jira/browse/LUCENE-8946 Project: Lucene - Core Issue

[jira] [Created] (LUCENE-8942) Tighten Up LRUQueryCache's Methods

2019-08-01 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8942: --- Summary: Tighten Up LRUQueryCache's Methods Key: LUCENE-8942 URL: https://issues.apache.org/jira/browse/LUCENE-8942 Project: Lucene - Core Issue Type:

[jira] [Updated] (LUCENE-8929) Early Terminating CollectorManager

2019-07-29 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8929: Issue Type: Sub-task (was: Improvement) Parent: LUCENE-8940 > Early Terminating

[jira] [Updated] (LUCENE-8939) Shared Hit Count Early Termination

2019-07-29 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8939: Summary: Shared Hit Count Early Termination (was: Global Early Termination For Sorted

[jira] [Created] (LUCENE-8940) Early Termination Across Slices

2019-07-29 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8940: --- Summary: Early Termination Across Slices Key: LUCENE-8940 URL: https://issues.apache.org/jira/browse/LUCENE-8940 Project: Lucene - Core Issue Type:

[jira] [Updated] (LUCENE-8939) Global Early Termination For Sorted Collections

2019-07-29 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8939: Issue Type: Sub-task (was: Improvement) Parent: LUCENE-8940 > Global Early Termination

[jira] [Created] (LUCENE-8939) Global Early Termination For Sorted Collections

2019-07-29 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8939: --- Summary: Global Early Termination For Sorted Collections Key: LUCENE-8939 URL: https://issues.apache.org/jira/browse/LUCENE-8939 Project: Lucene - Core Issue

[jira] [Commented] (LUCENE-8936) Add SpanishMinimalStemFilter

2019-07-27 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894336#comment-16894336 ] Atri Sharma commented on LUCENE-8936: - Hello Vinod! Welcome to the community. Thank you for your

[jira] [Created] (SOLR-13655) Cut Over Collections.unmodifiedSet usages to Set.*

2019-07-26 Thread Atri Sharma (JIRA)
Atri Sharma created SOLR-13655: -- Summary: Cut Over Collections.unmodifiedSet usages to Set.* Key: SOLR-13655 URL: https://issues.apache.org/jira/browse/SOLR-13655 Project: Solr Issue Type:

[jira] [Commented] (LUCENE-8929) Early Terminating CollectorManager

2019-07-25 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892643#comment-16892643 ] Atri Sharma commented on LUCENE-8929: - Ok, so I have been working on this and am wondering what the

[jira] [Created] (LUCENE-8931) TestTopFieldCollectorEarlyTermination Should Use CheckHits

2019-07-23 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8931: --- Summary: TestTopFieldCollectorEarlyTermination Should Use CheckHits Key: LUCENE-8931 URL: https://issues.apache.org/jira/browse/LUCENE-8931 Project: Lucene - Core

[jira] [Commented] (LUCENE-8929) Early Terminating CollectorManager

2019-07-23 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890760#comment-16890760 ] Atri Sharma commented on LUCENE-8929: - bq. So you need to collect each segment at least until

[jira] [Commented] (LUCENE-8929) Early Terminating CollectorManager

2019-07-23 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890749#comment-16890749 ] Atri Sharma commented on LUCENE-8929: - bq. OK, so if I understand correctly you are still collecting

[jira] [Commented] (LUCENE-8929) Early Terminating CollectorManager

2019-07-23 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890734#comment-16890734 ] Atri Sharma commented on LUCENE-8929: - {quote}What collector do you have in mind? Is it

[jira] [Created] (LUCENE-8929) Early Terminating CollectorManager

2019-07-22 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8929: --- Summary: Early Terminating CollectorManager Key: LUCENE-8929 URL: https://issues.apache.org/jira/browse/LUCENE-8929 Project: Lucene - Core Issue Type:

[jira] [Commented] (LUCENE-8727) IndexSearcher#search(Query,int) should operate on a shared priority queue when configured with an executor

2019-07-22 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889970#comment-16889970 ] Atri Sharma commented on LUCENE-8727: - bq. we will have to skip all these docs with smaller doc Ids

[jira] [Commented] (LUCENE-8727) IndexSearcher#search(Query,int) should operate on a shared priority queue when configured with an executor

2019-07-19 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888766#comment-16888766 ] Atri Sharma commented on LUCENE-8727: - [~jpountz] Here are two thoughts for the implementation of

[jira] [Created] (LUCENE-8927) Cut Over To Set.copyOf and Set.Of From Collections.unmodifiableSet

2019-07-18 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8927: --- Summary: Cut Over To Set.copyOf and Set.Of From Collections.unmodifiableSet Key: LUCENE-8927 URL: https://issues.apache.org/jira/browse/LUCENE-8927 Project: Lucene -

[jira] [Commented] (LUCENE-8924) Remove Fields Order Checks from CheckIndex?

2019-07-17 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887340#comment-16887340 ] Atri Sharma commented on LUCENE-8924: - I see. Should we make this more explicit and robust then? For

[jira] [Created] (LUCENE-8924) Remove Fields Order Checks from CheckIndex?

2019-07-17 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8924: --- Summary: Remove Fields Order Checks from CheckIndex? Key: LUCENE-8924 URL: https://issues.apache.org/jira/browse/LUCENE-8924 Project: Lucene - Core Issue

[jira] [Commented] (LUCENE-8915) Allow RateLimiter To Have Dynamic Limits

2019-07-16 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885941#comment-16885941 ] Atri Sharma commented on LUCENE-8915: - [~ab] Thanks, raised a PR doing the same.  

[jira] [Commented] (LUCENE-8915) Allow RateLimiter To Have Dynamic Limits

2019-07-16 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885887#comment-16885887 ] Atri Sharma commented on LUCENE-8915: - Hmm, I do not see a reason why SimpleRateLimiter cannot

[jira] [Created] (LUCENE-8919) Query Metadata Aggregator

2019-07-15 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8919: --- Summary: Query Metadata Aggregator Key: LUCENE-8919 URL: https://issues.apache.org/jira/browse/LUCENE-8919 Project: Lucene - Core Issue Type: Improvement

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-07-15 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884939#comment-16884939 ] Atri Sharma commented on LUCENE-8811: - [~jpountz] Yeah, that is what I was thinking of, but I see

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-07-15 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884930#comment-16884930 ] Atri Sharma commented on LUCENE-8811: - [~jpountz] I had originally raised a patch which implemented

[jira] [Updated] (LUCENE-8915) Allow RateLimiter To Have Dynamic Limits

2019-07-15 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8915: Description: RateLimiter does not allow dynamic configuration of the rate limit today. This

[jira] [Created] (LUCENE-8915) Allow RateLimiter To Have Dynamic Limits

2019-07-15 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8915: --- Summary: Allow RateLimiter To Have Dynamic Limits Key: LUCENE-8915 URL: https://issues.apache.org/jira/browse/LUCENE-8915 Project: Lucene - Core Issue Type:

[jira] [Created] (LUCENE-8905) TopDocsCollector Should Have Better Error Handling For Illegal Arguments

2019-07-08 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8905: --- Summary: TopDocsCollector Should Have Better Error Handling For Illegal Arguments Key: LUCENE-8905 URL: https://issues.apache.org/jira/browse/LUCENE-8905 Project:

[jira] [Resolved] (LUCENE-8829) TopDocs#Merge is Tightly Coupled To Number Of Collectors Involved

2019-07-03 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma resolved LUCENE-8829. - Resolution: Fixed Merged to master > TopDocs#Merge is Tightly Coupled To Number Of Collectors

[jira] [Resolved] (LUCENE-8794) Cost Based Slice Allocation Algorithm

2019-07-03 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma resolved LUCENE-8794. - Resolution: Fixed Merged to master > Cost Based Slice Allocation Algorithm >

[jira] [Commented] (LUCENE-8762) Lucene50PostingsReader should specialize reading docs+freqs with impacts

2019-07-03 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877864#comment-16877864 ] Atri Sharma commented on LUCENE-8762: - I will take a crack at this and post a patch soon. >

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-02 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877232#comment-16877232 ] Atri Sharma commented on LUCENE-8857: - [~jpountz] Yes, I ran the Solr suite twice. The first time,

[jira] [Resolved] (LUCENE-8899) Implementation of MultiTermQuery for ORed Queries

2019-07-02 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma resolved LUCENE-8899. - Resolution: Not A Problem > Implementation of MultiTermQuery for ORed Queries >

[jira] [Commented] (LUCENE-8899) Implementation of MultiTermQuery for ORed Queries

2019-07-02 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877219#comment-16877219 ] Atri Sharma commented on LUCENE-8899: - Hmm, true. I was thinking of a query type just for the

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-02 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877156#comment-16877156 ] Atri Sharma commented on LUCENE-8857: - [~jpountz] Thanks for confirming. I wanted to ensure that no

[jira] [Commented] (LUCENE-8899) Implementation of MultiTermQuery for ORed Queries

2019-07-02 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877154#comment-16877154 ] Atri Sharma commented on LUCENE-8899: - The way I am thinking of this is by using the fact that

[jira] [Resolved] (SOLR-13597) TopGroups Should Respect the API in Lucene's TopDocs.merge

2019-07-02 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma resolved SOLR-13597. Resolution: Not A Problem This can be done at Lucene level itself, given the usage pattern of Solr

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-02 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876965#comment-16876965 ] Atri Sharma commented on LUCENE-8857: - Since this is a breaking API change, is there a way we can

[jira] [Created] (LUCENE-8899) Implementation of MultiTermQuery for ORed Queries

2019-07-02 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8899: --- Summary: Implementation of MultiTermQuery for ORed Queries Key: LUCENE-8899 URL: https://issues.apache.org/jira/browse/LUCENE-8899 Project: Lucene - Core

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-02 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876773#comment-16876773 ] Atri Sharma commented on LUCENE-8857: - JFYI The latest iteration on PR also fixes the compilation

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-02 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876759#comment-16876759 ] Atri Sharma commented on LUCENE-8857: - [~jpountz] I have pushed the latest iteration to the new PR.

[jira] [Commented] (LUCENE-8882) Add State To QueryVisitor

2019-07-02 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876754#comment-16876754 ] Atri Sharma commented on LUCENE-8882: - My idea was not to replace IndexOrDocValues, but to allow it

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-02 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876711#comment-16876711 ] Atri Sharma commented on LUCENE-8857: - [~munendrasn] Thanks for the compilation fix. Yes, the test

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-02 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876708#comment-16876708 ] Atri Sharma commented on LUCENE-8857: - Ok, updating the PR now. > Refactor TopDocs#Merge To Take In

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-02 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876699#comment-16876699 ] Atri Sharma commented on LUCENE-8857: - [~jpountz] Yes, we will. I did not want to add the fix for

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-02 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876692#comment-16876692 ] Atri Sharma commented on LUCENE-8857: - I have opened

[jira] [Created] (SOLR-13597) TopGroups Should Respect the API in Lucene's TopDocs.merge

2019-07-02 Thread Atri Sharma (JIRA)
Atri Sharma created SOLR-13597: -- Summary: TopGroups Should Respect the API in Lucene's TopDocs.merge Key: SOLR-13597 URL: https://issues.apache.org/jira/browse/SOLR-13597 Project: Solr Issue

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-01 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876378#comment-16876378 ] Atri Sharma commented on LUCENE-8857: - [~jpountz] Ran ant test 5 times again: all came in clean:  

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-01 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876335#comment-16876335 ] Atri Sharma commented on LUCENE-8857: - [~jpountz] I investigated this and it turned out to be a test

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-01 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876253#comment-16876253 ] Atri Sharma commented on LUCENE-8857: - I did – I was not able to see any failures (probably due to

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-01 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876218#comment-16876218 ] Atri Sharma commented on LUCENE-8857: - [~jpountz] Thanks for committing and reviewing, [~simonw]

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

2019-07-01 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876130#comment-16876130 ] Atri Sharma commented on LUCENE-8862: - [~jpountz] Thanks for pushing and reviewing! > Collector

[jira] [Created] (LUCENE-8897) Allow Callbacks For Events In Collectors/ CollectorManagers

2019-07-01 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8897: --- Summary: Allow Callbacks For Events In Collectors/ CollectorManagers Key: LUCENE-8897 URL: https://issues.apache.org/jira/browse/LUCENE-8897 Project: Lucene - Core

[jira] [Commented] (LUCENE-8896) Override default implementation of IntersectVisitor#visit(DocIDSetBuilder, byte[]) for several queries

2019-07-01 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876037#comment-16876037 ] Atri Sharma commented on LUCENE-8896: - Does PointRangeQuery not already have its custom intersects

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-07-01 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876026#comment-16876026 ] Atri Sharma commented on LUCENE-8857: - Should we push the latest iteration on the PR, if it looks

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-06-27 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874125#comment-16874125 ] Atri Sharma commented on LUCENE-8857: - Updated the PR with latest comments, removing merge

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

2019-06-27 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874013#comment-16874013 ] Atri Sharma commented on LUCENE-8862: - Updated the PR with latest comments and moved to misc module.

[jira] [Commented] (LUCENE-8889) Remove Dead Code From PointRangeQuery

2019-06-27 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874002#comment-16874002 ] Atri Sharma commented on LUCENE-8889: - [~jim.ferenczi] Call me old school, but I believe that APIs

[jira] [Created] (LUCENE-8889) Remove Dead Code From PointRangeQuery

2019-06-27 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8889: --- Summary: Remove Dead Code From PointRangeQuery Key: LUCENE-8889 URL: https://issues.apache.org/jira/browse/LUCENE-8889 Project: Lucene - Core Issue Type:

[jira] [Commented] (LUCENE-8881) Query.rewrite Should Move To QueryVisitor

2019-06-27 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873984#comment-16873984 ] Atri Sharma commented on LUCENE-8881: - [~romseygeek] Agreed, however, we could use QueryVisitor's

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-06-26 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873207#comment-16873207 ] Atri Sharma commented on LUCENE-8811: - Thanks [~romseygeek] for pushing!   A small nit: I think

[jira] [Commented] (LUCENE-8882) Add State To QueryVisitor

2019-06-26 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873002#comment-16873002 ] Atri Sharma commented on LUCENE-8882: - I think this is useful even outside LUCENE-8881 – This allows

[jira] [Created] (LUCENE-8882) Add State To QueryVisitor

2019-06-25 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8882: --- Summary: Add State To QueryVisitor Key: LUCENE-8882 URL: https://issues.apache.org/jira/browse/LUCENE-8882 Project: Lucene - Core Issue Type: Improvement

[jira] [Created] (LUCENE-8881) Query.rewrite Should Move To QueryVisitor

2019-06-25 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8881: --- Summary: Query.rewrite Should Move To QueryVisitor Key: LUCENE-8881 URL: https://issues.apache.org/jira/browse/LUCENE-8881 Project: Lucene - Core Issue Type:

[jira] [Commented] (LUCENE-8811) Add maximum clause count check to IndexSearcher rather than BooleanQuery

2019-06-25 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872550#comment-16872550 ] Atri Sharma commented on LUCENE-8811: - Any chance we could push this one? Happy to make any changes

[jira] [Created] (LUCENE-8880) Add a TopDocsCollector which does not sort by score

2019-06-25 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8880: --- Summary: Add a TopDocsCollector which does not sort by score Key: LUCENE-8880 URL: https://issues.apache.org/jira/browse/LUCENE-8880 Project: Lucene - Core

[jira] [Commented] (LUCENE-8877) TopDocsCollector Should Not Depend on Priority Queue

2019-06-25 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872544#comment-16872544 ] Atri Sharma commented on LUCENE-8877: - Any thoughts on this? I am envisioning eventually getting to

[jira] [Commented] (LUCENE-8875) Should TopScoreDocCollector Always Populate Sentinel Values?

2019-06-24 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871620#comment-16871620 ] Atri Sharma commented on LUCENE-8875: - I meant Elasticsearch aggregates (although I am not sure if

[jira] [Commented] (LUCENE-8875) Should TopScoreDocCollector Always Populate Sentinel Values?

2019-06-24 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871543#comment-16871543 ] Atri Sharma commented on LUCENE-8875: - While I do agree that too many hits are not what top N hits

[jira] [Created] (LUCENE-8877) TopDocsCollector Should Not Depend on Priority Queue

2019-06-24 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8877: --- Summary: TopDocsCollector Should Not Depend on Priority Queue Key: LUCENE-8877 URL: https://issues.apache.org/jira/browse/LUCENE-8877 Project: Lucene - Core

[jira] [Commented] (LUCENE-8875) Should TopScoreDocCollector Always Populate Sentinel Values?

2019-06-23 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870679#comment-16870679 ] Atri Sharma commented on LUCENE-8875: - Another thing to explore is to have a sleek set of arrays

[jira] [Created] (LUCENE-8875) Should TopScoreDocCollector Always Populate Sentinel Values?

2019-06-23 Thread Atri Sharma (JIRA)
Atri Sharma created LUCENE-8875: --- Summary: Should TopScoreDocCollector Always Populate Sentinel Values? Key: LUCENE-8875 URL: https://issues.apache.org/jira/browse/LUCENE-8875 Project: Lucene - Core

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-06-20 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868909#comment-16868909 ] Atri Sharma commented on LUCENE-8857: - [~simonw] I have added the default tie breaker which tie

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-06-20 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868717#comment-16868717 ] Atri Sharma commented on LUCENE-8857: - {quote}Any chance we can select the tie-breaker based on if

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-06-20 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868479#comment-16868479 ] Atri Sharma commented on LUCENE-8857: - Does this iteration look fine? Happy to iterate further if

[jira] [Commented] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-06-19 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867411#comment-16867411 ] Atri Sharma commented on LUCENE-8857: - Updated patch with improved javadocs and removal of now

[jira] [Updated] (LUCENE-8857) Refactor TopDocs#Merge To Take In Custom Tie Breakers

2019-06-19 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma updated LUCENE-8857: Attachment: LUCENE-8857.patch > Refactor TopDocs#Merge To Take In Custom Tie Breakers >

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

2019-06-19 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867325#comment-16867325 ] Atri Sharma commented on LUCENE-8862: - I have opened a PR for the same. Please let me know if this

[jira] [Commented] (LUCENE-8864) Add Query Memory Estimation Ability in QueryVisitor

2019-06-18 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866933#comment-16866933 ] Atri Sharma commented on LUCENE-8864: - Right, the purpose of this Jira was twofold:   1) To throw

[jira] [Commented] (LUCENE-8769) Range Query Type With Logically Connected Ranges

2019-06-18 Thread Atri Sharma (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866884#comment-16866884 ] Atri Sharma commented on LUCENE-8769: - Thinking more about this, I think what can be done is:   1)

  1   2   3   4   >