[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-23 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r250101885 ## File path: lucene/core/src/java/org/apache/lucene/geo/EdgeTree.java ## @@ -158,6 +212,61 @@ private Relation

[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-23 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r250136513 ## File path: lucene/sandbox/src/java/org/apache/lucene/geo/Tessellator.java ## @@ -723,13 +735,23 @@ private

[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-23 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r250104177 ## File path: lucene/core/src/java/org/apache/lucene/geo/EdgeTree.java ## @@ -101,6 +101,60 @@ public Relation

[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-23 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r250130909 ## File path: lucene/sandbox/src/java/org/apache/lucene/geo/Rectangle2D.java ## @@ -148,6 +148,90 @@ public

[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-23 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r250126904 ## File path: lucene/sandbox/src/java/org/apache/lucene/geo/Rectangle2D.java ## @@ -148,6 +148,90 @@ public

[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-23 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r250142208 ## File path: lucene/sandbox/src/java/org/apache/lucene/document/LatLonShapeQuery.java ## @@ -163,17 +186,24 @@

[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-23 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r250132342 ## File path: lucene/sandbox/src/java/org/apache/lucene/geo/Rectangle2D.java ## @@ -148,6 +148,90 @@ public

[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-23 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r250140096 ## File path: lucene/sandbox/src/java/org/apache/lucene/document/LatLonShapeQuery.java ## @@ -43,7 +44,7 @@ *

[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-23 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r250132578 ## File path: lucene/sandbox/src/java/org/apache/lucene/geo/Rectangle2D.java ## @@ -148,6 +148,90 @@ public

[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-23 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r250108261 ## File path: lucene/core/src/java/org/apache/lucene/geo/EdgeTree.java ## @@ -101,6 +101,60 @@ public Relation

[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-23 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r250101242 ## File path: lucene/core/src/java/org/apache/lucene/geo/EdgeTree.java ## @@ -101,6 +101,60 @@ public Relation

[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-23 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r250129373 ## File path: lucene/sandbox/src/java/org/apache/lucene/geo/Rectangle2D.java ## @@ -216,6 +300,11 @@ private

[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-22 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r249791047 ## File path: lucene/core/src/java/org/apache/lucene/geo/EdgeTree.java ## @@ -101,6 +101,60 @@ public Relation

[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-22 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r249810176 ## File path: lucene/sandbox/src/java/org/apache/lucene/geo/Rectangle2D.java ## @@ -191,7 +275,7 @@ private

[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-22 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r249812595 ## File path: lucene/sandbox/src/test/org/apache/lucene/document/TestLatLonLineShapeQueries.java ## @@ -81,35

[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-22 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r249795317 ## File path: lucene/core/src/java/org/apache/lucene/geo/EdgeTree.java ## @@ -101,6 +101,60 @@ public Relation

[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-22 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r249821415 ## File path: lucene/sandbox/src/test/org/apache/lucene/document/TestLatLonMultiPolygonShapeQueries.java ## @@

[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-22 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r249810439 ## File path: lucene/sandbox/src/java/org/apache/lucene/geo/Rectangle2D.java ## @@ -224,7 +313,7 @@ private

[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-22 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r249809786 ## File path: lucene/sandbox/src/java/org/apache/lucene/geo/Rectangle2D.java ## @@ -107,7 +107,7 @@ public

[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-22 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r249810206 ## File path: lucene/sandbox/src/java/org/apache/lucene/geo/Rectangle2D.java ## @@ -202,7 +286,7 @@ private

[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-22 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r249809936 ## File path: lucene/sandbox/src/java/org/apache/lucene/geo/Rectangle2D.java ## @@ -148,6 +148,90 @@ public

[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-22 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r249797707 ## File path: lucene/core/src/java/org/apache/lucene/geo/EdgeTree.java ## @@ -150,9 +204,88 @@ private Relation

[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-22 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r249807883 ## File path: lucene/sandbox/src/java/org/apache/lucene/document/LatLonShapeBoundingBoxQuery.java ## @@ -45,23

[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-22 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r249799963 ## File path: lucene/sandbox/src/java/org/apache/lucene/document/LatLonShape.java ## @@ -118,19 +118,21 @@

[GitHub] jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains

2019-01-22 Thread GitBox
jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape contains URL: https://github.com/apache/lucene-solr/pull/546#discussion_r249811008 ## File path: lucene/sandbox/src/test/org/apache/lucene/document/TestLatLonLineShapeQueries.java ## @@ -81,35