Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/208#discussion_r121596530
--- Diff: src/Lucene.Net/Document/Document.cs ---
@@ -278,9 +279,17 @@ public string Get(string name)
return null
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/206
This looks great, thanks for the initiative!
@NightOwl888 I assume many files' code comments are still broken so we will
gradually get them fixed so it looks better then
@wwb
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/205
This is a great test - and as it happens many bugs in Apache Lucene (Java),
even very severe ones, were caught using a randomized testing framework, which
by definition is not deterministic
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/205
Good catch, thanks!
@NightOwl888 can we get this to the beta version before it's released?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/194
Cool thanks - that's why I asked before merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/194
Ok, cool, merging now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/196
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/194
Looks good to me, but seems like it's blocked by #191?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/195
ð
WDYT @NightOwl888 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/191
Thanks for the clarifications. Probably make sense to have it documented in
code itself then :)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/191
> AFAIK, the Support namespace is for pieces that need to be sourced from
the JDK and/or close approximations to what is in the JDK that don't exist in
the .NET framew
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/174
@NightOwl888 go ahead. Spatial4n will be a bit challenging due to strong
naming and possibly dependencies not being up-to-date. Let's take it there.
---
If your project is set up for it, you
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/193#discussion_r87320660
--- Diff: src/Lucene.Net.Core/Support/HashMap.cs ---
@@ -125,9 +140,87 @@ public TValue AddIfAbsent(TKey key, TValue value)
return
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/187#discussion_r81840724
--- Diff: src/Lucene.Net.QueryParser/Surround/Parser/QueryParser.cs ---
@@ -883,7 +883,7 @@ private void Jj_rescan_token
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/190#discussion_r81838986
--- Diff: Lucene.Net.sln ---
@@ -59,14 +60,14 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") =
"Lucene.Net.Suggest", &q
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/174
The spatial lib needs to be brought up to date with the Java 4.8.0 branch
(which I believe this is what this PR does, but this needs verification). The
latest spatial bits will not work before
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/190#discussion_r81839278
--- Diff: src/Lucene.Net.Core/Support/DataInputStream.cs ---
@@ -0,0 +1,323 @@
+using System;
+using System.IO;
+
+namespace
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/189
Ok, email us at private@ and let's figure this out. Ready to merge now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/188
> A plain old generic Dictionary works fine, but may use more RAM than the
designers intended.
I am totally okay with that. We should aim to get something out the door
a
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/189
The github interface doesn't reflect on your permissions - please try and
let us know if it doesn't work.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/187
Great job, merging this now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/185
At some point I looked at WeakDictionary as a replacement but didn't go
forward with it because of some behavior mismatch. Can't really remember now
exactly what it was. If you are certain
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/185#discussion_r78303386
--- Diff: src/Lucene.Net.TestFramework/Util/fst/FSTTester.cs ---
@@ -395,6 +407,24 @@ internal virtual FST DoTest(int prune1, int prune2,
bool
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/185#discussion_r78302998
--- Diff: src/Lucene.Net.Core/AssemblyInfo.cs ---
@@ -84,6 +90,6 @@
// (*) Delay Signing is an advanced option - see the Microsoft .NET
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/185
Very good refactoring, thanks! left a few minor comments, can merge now but
will give you a chance to fix them here and not on separate PRs before doing so
---
If your project is set up
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/185#discussion_r78302897
--- Diff: src/Lucene.Net.Tests/core/Util/TestWeakIdentityMap.cs ---
@@ -174,12 +188,15 @@ public virtual void TestSimpleHashMap
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/185#discussion_r78302836
--- Diff: src/Lucene.Net.TestFramework/Util/fst/FSTTester.cs ---
@@ -913,6 +945,73 @@ private void VerifyPruned(int inputMode, FST fst,
int prune1, int
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/185#discussion_r78302397
--- Diff: src/Lucene.Net.Core/AssemblyInfo.cs ---
@@ -84,6 +90,6 @@
// (*) Delay Signing is an advanced option - see the Microsoft .NET
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/185
A `Nightly` attribute would be nice, but our current infrastructure doesn't
support it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/183
Looks good. Pending @NightOwl888 approval before merging this in. Thanks
@conniey !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/173
Opening back as this is going to be the branch we work on to get this great
work merged into master. cc @hristopherHaws @NightOwl888
---
If your project is set up for it, you can reply
GitHub user synhershko reopened a pull request:
https://github.com/apache/lucenenet/pull/173
Analysis work
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/lucenenet analysis-work
Alternatively you can review and apply
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/181
Awesome, thanks! Can you please check
https://github.com/apache/lucenenet/pull/179 to see you and @NightOwl888 aren't
working on the same stuff?
---
If your project is set up for it, you can
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/180
Awesome, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/173
Closing in favor of #179
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/179
What is the difference / overlap between this PR and
https://github.com/apache/lucenenet/pull/173 ? also I can see
https://github.com/NightOwl888/lucenenet/tree/analysis-work-2 - can you
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/176
Hi, sorry it took me so long to review. I wanted to review properly and
give proper feedback to complement your hard (and very professional!) work here.
So,
1. This makes
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/175
Looks good, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/174
It's already ported, just not up to date :
https://github.com/synhershko/spatial4n
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/177
Awesome work, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/178
Merged, if that dependency will cause issues we will handle it then
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/176
This is usually where we put all .NET specific stuff that is required by
Core / subprojects:
https://github.com/apache/lucenenet/tree/master/src/Lucene.Net.Core/Support/Compatibility
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/commit/c6f1a19af68a405b428f935118665f65fefad491#commitcomment-18551289
Please mark as LUCENENET specific if that's the case
---
If your project is set up for it, you can reply to this email
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/176
Left one minor comments, looks good to merge otherwise. Thanks for your
help!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/176#discussion_r73792790
--- Diff: src/Lucene.Net.Core/Util/ToStringUtils.cs ---
@@ -36,12 +37,13 @@ public static string Boost(float boost
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/174
Is this a full and complete port (e.g. no classes or functionality left
behind)? if so, how did you manage to avoid updating spatial4n to bring it up
to date with the latest spatial4j
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/175
Looks good, let's work on getting this in. This PR currently breaks
sub-projects, as the API change hasn't been propogated there and to their
tests. Can you run the entire solution and make
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/177
Looks great! Added a few comments
(1) might have found a bug - you didn't change local vars in some occasions
so I had commented in some of them, (2) please document all test API
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/177#discussion_r73790017
--- Diff: src/Lucene.Net.Tests/core/Search/TestPhraseQuery.cs ---
@@ -255,7 +255,7 @@ public virtual void TestPhraseQueryWithStopAnalyzer
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/177#discussion_r73789830
--- Diff:
src/Lucene.Net.Tests/core/Codecs/Lucene3x/TestLucene3xStoredFieldsFormat.cs ---
@@ -35,7 +35,8 @@ protected override Codec Codec
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/177#discussion_r73789759
--- Diff: src/Lucene.Net.TestFramework/Index/RandomIndexWriter.cs ---
@@ -85,22 +86,22 @@ public static IndexWriter MockIndexWriter(Directory
dir
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/177
ð
lots of files to review :) will be on it asap. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/173
Yes, this is my WIP branch. CharArrayMap and CharArraySet are a bit buggy
still (tests are failing) and need to wipe those bugs out. I think this branch
has all my changes (no local
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/174
Looks good! will review shortly, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user synhershko opened a pull request:
https://github.com/apache/lucenenet/pull/173
Analysis work
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/lucenenet analysis-work
Alternatively you can review and apply
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/172
Thanks @conniey , looks good! I left a few comments - the main idea is to
minimize the amount of non-Java compatible changes we make and to document well
the ones we have to make
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/172#discussion_r71072173
--- Diff: src/Lucene.Net.TestFramework/Index/RandomIndexWriter.cs ---
@@ -85,24 +85,24 @@ public static IndexWriter MockIndexWriter(Directory
dir
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/172#discussion_r71072078
--- Diff: src/Lucene.Net.Tests/core/Index/TestBinaryDocValuesUpdates.cs ---
@@ -1109,25 +1109,55 @@ public virtual void
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/172#discussion_r71072042
--- Diff: src/Lucene.Net.Tests.Queries/TestCustomScoreQuery.cs ---
@@ -334,11 +334,11 @@ private void VerifyResults(float boost, IndexSearcher
s
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/172#discussion_r71072025
--- Diff: src/Lucene.Net.Tests.Join/Lucene.Net.Tests.Join.csproj ---
@@ -31,7 +31,7 @@
- ..\packages\NUnit.2.6.3\lib
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/172#discussion_r71071991
--- Diff: src/Lucene.Net.TestFramework/Search/QueryUtils.cs ---
@@ -442,15 +445,17 @@ private class CollectorAnonymousInnerClassHelper2 :
Collector
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/171#issuecomment-220534914
Looks great, thanks for amazing work here.
I left a few more minor comments, other than that LGTM and I'll merge soon
---
If your project is set up
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r63530865
--- Diff: src/Lucene.Net.Tests/core/Index/TestIndexWriterConfig.cs ---
@@ -307,7 +315,11 @@ public virtual void TestInvalidValues
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r63530524
--- Diff: src/Lucene.Net.Core/Index/LiveIndexWriterConfig.cs ---
@@ -149,7 +149,11 @@ internal LiveIndexWriterConfig(Analyzer analyzer,
LuceneVersion
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r63530104
--- Diff: src/Lucene.Net.Core/Index/TaskMergeScheduler.cs ---
@@ -0,0 +1,667 @@
+using System;
+using System.Collections.Generic;
+using
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62451412
--- Diff: src/Lucene.Net.Tests/core/TestMergeSchedulerExternal.cs ---
@@ -76,7 +76,9 @@ protected override MergeThread GetMergeThread(IndexWriter
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62451390
--- Diff: src/Lucene.Net.Tests/core/Index/TestTransactions.cs ---
@@ -128,13 +134,21 @@ public IndexerThread(TestTransactions outerInstance,
object
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62451346
--- Diff: src/Lucene.Net.Core/Index/TaskMergeScheduler.cs ---
@@ -0,0 +1,665 @@
+using System;
+using System.Collections.Generic;
+using
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62451281
--- Diff: src/Lucene.Net.Core/Index/IConcurrentMergeScheduler.cs ---
@@ -0,0 +1,15 @@
+namespace Lucene.Net.Index
+{
+public
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62450979
--- Diff: src/Lucene.Net.Core/Index/LiveIndexWriterConfig.cs ---
@@ -149,7 +149,11 @@ internal LiveIndexWriterConfig(Analyzer analyzer,
LuceneVersion
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62423674
--- Diff: src/Lucene.Net.Core/Index/TaskMergeScheduler.cs ---
@@ -0,0 +1,665 @@
+using System;
+using System.Collections.Generic;
+using
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62423632
--- Diff: src/Lucene.Net.Core/Index/IConcurrentMergeScheduler.cs ---
@@ -0,0 +1,15 @@
+namespace Lucene.Net.Index
+{
+public
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62423611
--- Diff: src/Lucene.Net.Tests/core/TestMergeSchedulerExternal.cs ---
@@ -76,7 +76,9 @@ protected override MergeThread GetMergeThread(IndexWriter
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62423483
--- Diff: src/Lucene.Net.Core/Index/TaskMergeScheduler.cs ---
@@ -0,0 +1,665 @@
+using System;
+using System.Collections.Generic;
+using
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62423417
--- Diff: src/Lucene.Net.Core/Index/LiveIndexWriterConfig.cs ---
@@ -149,7 +149,11 @@ internal LiveIndexWriterConfig(Analyzer analyzer,
LuceneVersion
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/171#issuecomment-216681382
Thanks! give me a day or two to review this properly :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/170#issuecomment-215986990
Merged, thanks!
(please submit future PRs from branches to avoid history conflicts..)
---
If your project is set up for it, you can reply to this email
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/169#issuecomment-214746674
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/167#issuecomment-213849508
Thanks, merged. On your next PR, please work on a branch, it is an ill
practice in git to merge from someone else's master.
---
If your project is set up
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/168#issuecomment-213845719
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/168#discussion_r60711453
--- Diff: src/Lucene.Net.Tests/core/Index/TestIndexWriterWithThreads.cs ---
@@ -726,15 +724,15 @@ public override void Run
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/168#discussion_r60711321
--- Diff: src/Lucene.Net.Tests/core/Index/TestIndexWriterWithThreads.cs ---
@@ -657,7 +655,7 @@ public virtual void TestRollbackAndCommitWithThreads
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/167#issuecomment-213343394
Thanks! I've made a comment on the Exception type used
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/167#discussion_r60710792
--- Diff: src/Lucene.Net.Facet/Taxonomy/WriterCache/CollisionMap.cs ---
@@ -261,7 +261,7 @@ public Entry Next()
Entry e
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/161#issuecomment-207031535
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/162#issuecomment-207031319
Looks good, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/163#issuecomment-201195415
Looks good, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/160#issuecomment-176117158
Looks good, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/159#discussion_r49704493
--- Diff: src/Lucene.Net.Analysis.Common/Analysis/Core/LetterTokenizer.cs
---
@@ -75,10 +75,10 @@ public LetterTokenizer(LuceneVersion matchVersion
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/158#issuecomment-167158881
Hi, thanks for submitting this.
The code in question isn't being maintained any more - it is part of a
previous release and will be replaced soon
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/157#discussion_r47976547
--- Diff: src/Lucene.Net.Analysis.Common/Analysis/Util/CharArrayIterator.cs
---
@@ -1,276 +1,268 @@
using System;
+using ICU4NET
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/155#issuecomment-163713206
Looks good - let's do this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/145#issuecomment-102659785
Can you rebase please? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/145#discussion_r30463210
--- Diff: src/Lucene.Net.Core/Util/OfflineSorter.cs ---
@@ -34,486 +34,6 @@ namespace Lucene.Net.Util
/// /summary
public sealed class
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/145#issuecomment-102662514
Good catch, I'll merge now.
For the record, `DateTime.UtcNow.Ticks` is a closer equivalent to
`System.currentTimeMillis` but for the purpose
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/142#issuecomment-100528838
All looks good, I don't see anything to discuss here really. Will merge now.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/138#issuecomment-98593927
Good catch
2 things come to mind:
1. `OffsetGap_Renamed` and such other `_Renamed` instances need to be,
well, renamed and have that suffix
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/135#issuecomment-98381886
Awesome work, thanks. Pushing this now and let's see if TC confirms.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/132#issuecomment-96372011
Good catch, will merge now
Can you evaluate if we still need that non-generic class?
---
If your project is set up for it, you can reply to this email
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/130#issuecomment-95234992
Is there a reason to have that marker interface public and not kept private?
While I'd assume there are more places like this, I wonder if we can assume
1 - 100 of 156 matches
Mail list logo
