Re: Maven 3.4.0 Release

+1 also Regards, Hervé Le lundi 19 décembre 2016, 20:36:48 CET Robert Scholte a écrit : > +100 > > On Mon, 19 Dec 2016 20:12:33 +0100, Stephen Connolly > > wrote: > > We need to get the project back in the habit of releasing. > > > > My vote is the we

Re: Maven 3.4.0 Release

Sure... but as close to be ready to release as possible. At a minimum passing ITs... Gary Gregory wrote on 2016-12-19 11:39: > On Mon, Dec 19, 2016 at 11:24 AM, Manfred Moser > wrote: > >> Totally agree. Master should be ready to release all the time imho. >>

Re: Maven 3.4.0 Release

On Mon, Dec 19, 2016 at 11:24 AM, Manfred Moser wrote: > Totally agree. Master should be ready to release all the time imho. > Nothing that isnt tested well and proven to at least pass all IT's should > be merged into master. Experimentation should happen in feature

Re: Maven 3.4.0 Release

+100 On Mon, 19 Dec 2016 20:12:33 +0100, Stephen Connolly wrote: We need to get the project back in the habit of releasing. My vote is the we rebuild master with a clean history. keep current master as a reference branch, and cherry-pick as we go. The

Re: Maven 3.4.0 Release

Totally agree. Master should be ready to release all the time imho. Nothing that isnt tested well and proven to at least pass all IT's should be merged into master. Experimentation should happen in feature branches.. Just my 2c. Manfred Stephen Connolly wrote on 2016-12-19 11:12: > We need

Re: Maven 3.4.0 Release

On Mon, Dec 19, 2016 at 11:12 AM, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > We need to get the project back in the habit of releasing. > +1! Gary > > My vote is the we rebuild master with a clean history. keep current master > as a reference branch, and cherry-pick as we

Re: Maven 3.4.0 Release

We need to get the project back in the habit of releasing. My vote is the we rebuild master with a clean history. keep current master as a reference branch, and cherry-pick as we go. The aim should be kept tight in scope and focus on the aether replacement only. Minimum change for aether

Re: Maven 3.4.0 Release

We're already trying to push a new release for quite some time. And it seems the discussion is not over yet. There are a lot of improvements which deserve a release, so personally I'd like to push the discussion to 3.5.0 Robert On Mon, 19 Dec 2016 14:12:25 +0100, Stephane Nicoll

Re: Maven 3.4.0 Release

Isn't that postponing the discussion we're having here on those controversial changes? I'd rather give it an extra effort rather than pushing it back and loosing all the context once we have to tackle 3.5. On Sun, Dec 18, 2016 at 10:02 PM, Stephen Connolly < stephen.alan.conno...@gmail.com>

Re: Maven 3.4.0 Release

I like that plan, but let's call that 3.4.0 and let these other changes go for either 3.5.0 Does someone want to take a stab at forking master from an earlier point (perhaps get infra to let us rewrite master back to the fork point and push the current state to a branch?) On Sun 18 Dec 2016 at

Re: Maven 3.4.0 Release

No, I meant just eclipse->apache move, not all changes that went into maven-resolver. The idea is to have a release branch we can maintain while things stabilize in master. -- Regards, Igor On Sun, Dec 18, 2016, at 12:46 PM, Michael Osipov wrote: > Am 2016-12-18 um 18:44 schrieb Igor Fedorenko:

Re: Maven 3.4.0 Release

Am 2016-12-18 um 18:44 schrieb Igor Fedorenko: I wonder if it makes sense to release 3.3.10 with just the new aether and give 3.4 more time to bake on master. Changing a dependency with so many changes recently in a fix version? Doesn't sound right to me. M

Re: Maven 3.4.0 Release

I wonder if it makes sense to release 3.3.10 with just the new aether and give 3.4 more time to bake on master. -- Regards, Igor On Sun, Dec 18, 2016, at 07:33 AM, Robert Scholte wrote: > I did investigate some time in this request. The conclusion is that the > discussion should be in the

Re: Maven 3.4.0 Release

I did investigate some time in this request. The conclusion is that the discussion should be in the open and not in the private list of the Maven PMC. What I see are good intended changes, but the results are a chain of commits where every change fixes one thing but at the same time breaks

Re: Maven 3.4.0 Release

Am 12/17/16 um 05:17 schrieb Christian Schulte: > Am 12/12/16 um 00:51 schrieb Igor Fedorenko: >> I'm traveling until next weekend and won't be able to review your changes >> properly until I'm back. I do want to stress that maven plugins are not >> dependencies, they are resolved the same way

Re: Maven 3.4.0 Release

Am 12/12/16 um 00:51 schrieb Igor Fedorenko: > I'm traveling until next weekend and won't be able to review your changes > properly until I'm back. I do want to stress that maven plugins are not > dependencies, they are resolved the same way as projects. Master does it that way now. I may need

Re: Maven 3.4.0 Release

Am 12/14/16 um 01:05 schrieb Christian Schulte: > That a direct optional dependency That should read: That a transitive optional dependency... - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands,

Re: Maven 3.4.0 Release

Am 12/12/16 um 00:51 schrieb Igor Fedorenko: > I'm traveling until next weekend and won't be able to review your changes > properly until I'm back. I do want to stress that maven plugins are not > dependencies, they are resolved the same way as projects. Coming back to this. Currently plugins

Re: Maven 3.4.0 Release

Am 12/12/16 um 22:55 schrieb Michael Osipov: > Am 2016-12-12 um 02:48 schrieb Christian Schulte: >> Am 12/11/16 um 22:56 schrieb Michael Osipov: >>> I just ran ITs with current master, only one IT fails: >> >> Should be fixed now. > > Are you certain about this? I cannot confirm. >

Re: Maven 3.4.0 Release

Am 12/12/16 um 22:55 schrieb Michael Osipov: > Am 2016-12-12 um 02:48 schrieb Christian Schulte: >> Am 12/11/16 um 22:56 schrieb Michael Osipov: >>> I just ran ITs with current master, only one IT fails: >> >> Should be fixed now. > > Are you certain about this? I cannot confirm. >

Re: Maven 3.4.0 Release

Am 2016-12-12 um 02:48 schrieb Christian Schulte: Am 12/11/16 um 22:56 schrieb Michael Osipov: I just ran ITs with current master, only one IT fails: Should be fixed now. Are you certain about this? I cannot confirm. 723b942ad10ab471dfbc5d81ed1071891573dc01 fixes MNG-5227 IT but the IT

Re: Maven 3.4.0 Release

Am 12/11/16 um 22:56 schrieb Michael Osipov: > I just ran ITs with current master, only one IT fails: Should be fixed now. Regards, -- Christian - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional

Re: Maven 3.4.0 Release

Am 12/12/16 um 00:51 schrieb Igor Fedorenko: > I'm traveling until next weekend and won't be able to review your changes > properly until I'm back. I do want to stress that maven plugins are not > dependencies, they are resolved the same way as projects. Yes. I agree to that. It's not

Re: Maven 3.4.0 Release

I'm traveling until next weekend and won't be able to review your changes properly until I'm back. I do want to stress that maven plugins are not dependencies, they are resolved the same way as projects. -- Regards, Igor On December 11, 2016 1:59:39 PM Christian Schulte

Re: Maven 3.4.0 Release

Thanks. Noticed this myself yesterday. Wanted to wait for Jenkins to finish all pending jobs. Haven't expected any IT to fail. Will have a look. Am 12/11/16 um 22:56 schrieb Michael Osipov: > Am 2016-12-10 um 16:06 schrieb Christian Schulte: >> If it's happening just due to the upgrade of the

Re: Maven 3.4.0 Release

Am 2016-12-10 um 16:06 schrieb Christian Schulte: If it's happening just due to the upgrade of the resolver, then it's a resolver bugfix the IT hasn't been updated to reflect. I discussed this issue with Jason in december last year when upgrading the resolver to 1.1 needed to be reverted.

Re: Maven 3.4.0 Release

Am 12/11/16 um 03:29 schrieb Igor Fedorenko: > Why do you say Dependency A is transitive? Maven plugin directly depends > on Dependency A, so I expect it to be present on the plugin classpath. > This is consistent with how project direct optional dependencies are > always present on classpath.

Re: Maven 3.4.0 Release

Why do you say Dependency A is transitive? Maven plugin directly depends on Dependency A, so I expect it to be present on the plugin classpath. This is consistent with how project direct optional dependencies are always present on classpath. Note that the project does not *depend* on the plugin.

Re: Maven 3.4.0 Release

Corrected IT in this commit. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For

Re: Maven 3.4.0 Release

Am 12/10/16 um 13:39 schrieb Hervé BOUTEMY: > I just tested the patch associated to MNG-6110 - Upgrade Aether to Maven > Resolver 1.2, and it caused one failure in ITs > testit(org.apache.maven.it.MavenITmng4721OptionalPluginDependencyTest) Time > elapsed: 0.185 sec <<< FAILURE! >

Re: Maven 3.4.0 Release

Am 12/10/16 um 17:48 schrieb Michael Osipov: > Can you create a proper branch with fixed ITs? I'd like to run those. > From my point of view, we can release Resolver 1.2 and roll an RC for > Maven 3.4. Let's just switch maven master to the resolver snapshot and continue from there on. That

Re: Maven 3.4.0 Release

Am 2016-12-10 um 16:06 schrieb Christian Schulte: If it's happening just due to the upgrade of the resolver, then it's a resolver bugfix the IT hasn't been updated to reflect. I discussed this issue with Jason in december last year when upgrading the resolver to 1.1 needed to be reverted.

Re: Maven 3.4.0 Release

Am 2016-12-10 um 16:18 schrieb Christian Schulte: It would be cool if someone could answer the questions I raised in this thread. I would still need to remove those system properties from the 'DefaultModelBuilder', for example.

Re: Maven 3.4.0 Release

Wait. That maybe a different story. MRESOLVER-8. The changes to 'OptionalDependencySelector' made it behave the same way the 'ScopeDependencySelector' and other selectors are

Re: Maven 3.4.0 Release

It would be cool if someone could answer the questions I raised in this thread. I would still need to remove those system properties from the 'DefaultModelBuilder', for example.

Re: Maven 3.4.0 Release

If it's happening just due to the upgrade of the resolver, then it's a resolver bugfix the IT hasn't been updated to reflect. I discussed this issue with Jason in december last year when upgrading the resolver to 1.1 needed to be reverted.

Re: Maven 3.4.0 Release

Am 2016-12-10 um 13:39 schrieb Hervé BOUTEMY: I just tested the patch associated to MNG-6110 - Upgrade Aether to Maven Resolver 1.2, and it caused one failure in ITs testit(org.apache.maven.it.MavenITmng4721OptionalPluginDependencyTest) Time elapsed: 0.185 sec <<< FAILURE!

Re: Maven 3.4.0 Release

I just tested the patch associated to MNG-6110 - Upgrade Aether to Maven Resolver 1.2, and it caused one failure in ITs testit(org.apache.maven.it.MavenITmng4721OptionalPluginDependencyTest) Time elapsed: 0.185 sec <<< FAILURE! junit.framework.AssertionFailedError: expected:<1> but was:<0> Is

Re: Maven 3.4.0 Release

Am 2016-12-06 um 22:46 schrieb Robert Scholte: Hi, what is the status on this? Can we expect a release this year? I think the open issues are: is maven-resolver ready to replace aether? AFAIK some dependency management changes have been reverted, are all others indeed bugfixes and safe to keep

Re: Maven 3.4.0 Release

Hi, what is the status on this? Can we expect a release this year? I think the open issues are: is maven-resolver ready to replace aether? AFAIK some dependency management changes have been reverted, are all others indeed bugfixes and safe to keep in this release? Here are the current

Re: Maven 3.4.0 Release

On Mon, 10 Oct 2016 11:08:52 +0200, Stephen Connolly wrote: On 10 October 2016 at 09:40, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: https://issues.apache.org/jira/browse/MNG-5971 I would argue that the behaviour change in MNG-5971 should

Re: Maven 3.4.0 Release

On 10 October 2016 at 09:40, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > > https://issues.apache.org/jira/browse/MNG-5971 > > I would argue that the behaviour change in MNG-5971 should not be > introduced at the same time as a refactoring to move to the new "code > formerly known

Re: Maven 3.4.0 Release

The following issues IMHO all affect build time behaviour and do not affect dependency consumption. As such they do not require a modelVersion bump https://issues.apache.org/jira/browse/MNG-6054 https://issues.apache.org/jira/browse/MNG-5992 https://issues.apache.org/jira/browse/MNG-5968

Re: Maven 3.4.0 Release

On 10 October 2016 at 01:38, Christian Schulte wrote: > Am 10/09/16 um 21:44 schrieb Stephen Connolly: > > Open issues bound to 3.4.0 > > > > * Introduction of model version 4.1.0. > > https://issues.apache.org/jira/browse/MNG-6082 > >

Re: Maven 3.4.0 Release

Le lundi 10 octobre 2016 02:47:36 Christian Schulte a écrit : > Am 10/09/16 um 14:10 schrieb Jason van Zyl: > > The preparation of detailed released notes to be reviewed. The last > > release was almost a year ago, and an enormous number of behavioral > > changes have been made in that time-frame.

Re: Maven 3.4.0 Release

Le lundi 10 octobre 2016 00:25:26 Michael Osipov a écrit : > Am 2016-10-09 um 23:51 schrieb Hervé BOUTEMY: > > Le dimanche 9 octobre 2016 21:11:03 Michael Osipov a écrit : > >> Am 2016-10-09 um 20:41 schrieb Robert Scholte: > >>> Open issues bound to 3.4.0 > >>> > >>> * Document how to configure

Re: Maven 3.4.0 Release

I would add MNG-5889 to 3.4 after proper testing. On Sun, Oct 9, 2016 at 8:41 PM, Robert Scholte wrote: > Open issues bound to 3.4.0 > > * Introduction of model version 4.1.0. > https://issues.apache.org/jira/browse/MNG-6082 > assignee: Christian Schulte (reporter:

Re: Maven 3.4.0 Release

Am 10/09/16 um 14:10 schrieb Jason van Zyl: > The preparation of detailed released notes to be reviewed. The last release > was almost a year ago, and an enormous number of behavioral changes have been > made in that time-frame. There’s zero documentation outlining these changes > thus far in

Re: Maven 3.4.0 Release

Am 10/09/16 um 21:44 schrieb Stephen Connolly: > Open issues bound to 3.4.0 > > * Introduction of model version 4.1.0. > https://issues.apache.org/jira/browse/MNG-6082 > > assignee: Christian Schulte (reporter: Christian

Re: Maven 3.4.0 Release

Am 2016-10-09 um 23:51 schrieb Hervé BOUTEMY: Le dimanche 9 octobre 2016 21:11:03 Michael Osipov a écrit : Am 2016-10-09 um 20:41 schrieb Robert Scholte: Open issues bound to 3.4.0 * Document how to configure Gossip https://issues.apache.org/jira/browse/MNG-6044 assignee: - (reporter:

Re: Maven 3.4.0 Release

Le dimanche 9 octobre 2016 21:11:03 Michael Osipov a écrit : > Am 2016-10-09 um 20:41 schrieb Robert Scholte: > > Open issues bound to 3.4.0 > > > > * Document how to configure Gossip > > > > https://issues.apache.org/jira/browse/MNG-6044 > > assignee: - (reporter: Michael Osipov) > > I am

Re: Maven 3.4.0 Release

Le dimanche 9 octobre 2016 21:11:03 Michael Osipov a écrit : > > * Document Jansi's native support limitation > > > > https://issues.apache.org/jira/browse/MNG-6045 > > assignee: - (reporter: Michael Osipov) > > Funny thing is that I have reached out to the devs of Jansi to fix some > issues

Re: Maven 3.4.0 Release

Le dimanche 9 octobre 2016 20:41:13 Robert Scholte a écrit : > Open issues bound to 3.4.0 > > * after forked execution success, add an empty line >https://issues.apache.org/jira/browse/MNG-6088 >assignee: Hervé Boutemy (reporter: Hervé Boutemy) I just closed this issue, which I had

Re: Maven 3.4.0 Release

I believe we definitely need RCs in this case. > On Oct 9, 2016, at 1:17 PM, Michael Osipov wrote: > > Am 2016-10-09 um 14:10 schrieb Jason van Zyl: >> The preparation of detailed released notes to be reviewed. The last >> release was almost a year ago, and an enormous

Re: Maven 3.4.0 Release

On Sunday 9 October 2016, Robert Scholte wrote: > Open issues bound to 3.4.0 > > * Introduction of model version 4.1.0. > https://issues.apache.org/jira/browse/MNG-6082 > assignee: Christian Schulte (reporter: Christian Schulte) I am -1 on this change as I understand

Re: Maven 3.4.0 Release

Am 2016-10-09 um 20:41 schrieb Robert Scholte: Open issues bound to 3.4.0 * Document how to configure Gossip https://issues.apache.org/jira/browse/MNG-6044 assignee: - (reporter: Michael Osipov) I am not able to properly solve this issue because I have no idea about Gossip. This should

Re: Maven 3.4.0 Release

Open issues bound to 3.4.0 * Introduction of model version 4.1.0. https://issues.apache.org/jira/browse/MNG-6082 assignee: Christian Schulte (reporter: Christian Schulte) * Document how to configure Gossip https://issues.apache.org/jira/browse/MNG-6044 assignee: - (reporter: Michael

Re: Maven 3.4.0 Release

Am 2016-10-09 um 14:10 schrieb Jason van Zyl: The preparation of detailed released notes to be reviewed. The last release was almost a year ago, and an enormous number of behavioral changes have been made in that time-frame. There’s zero documentation outlining these changes thus far in the site

Re: Maven 3.4.0 Release

Did we revert the modelVersion bump? On Sunday 9 October 2016, Karl Heinz Marbaise wrote: > Hi Jason, > > > On 09/10/16 14:10, Jason van Zyl wrote: > >> The preparation of detailed released notes to be reviewed. >> > > The last release was almost a year ago, and an enormous

Re: Maven 3.4.0 Release

Hi Jason, On 09/10/16 14:10, Jason van Zyl wrote: The preparation of detailed released notes to be reviewed. > The last release was almost a year ago, and an enormous number > of behavioral changes have been made in that time-frame. > There’s zero documentation outlining these changes thus

Re: Maven 3.4.0 Release

The preparation of detailed released notes to be reviewed. The last release was almost a year ago, and an enormous number of behavioral changes have been made in that time-frame. There’s zero documentation outlining these changes thus far in the site as far as I can tell. That’s the only