Re: Processing Pull Request

2014-05-26 Thread Daniel Kulp
On May 24, 2014, at 9:18 AM, Michael Osipov mosi...@gmx.de wrote: Hi, does it take special permissions on Github to process pull requests? Neither am I allowed to perform the merge from the website directly, nor does it display the command line steps as described in the GH help. Close

Re: Processing Pull Request

2014-05-26 Thread Michael Osipov
Am 2014-05-26 14:54, schrieb Daniel Kulp: On May 24, 2014, at 9:18 AM, Michael Osipov mosi...@gmx.de wrote: Hi, does it take special permissions on Github to process pull requests? Neither am I allowed to perform the merge from the website directly, nor does it display the command line

Processing Pull Request

2014-05-25 Thread Michael Osipov
Hi, does it take special permissions on Github to process pull requests? Neither am I allowed to perform the merge from the website directly, nor does it display the command line steps as described in the GH help. Close is not available to me too. I simply pulled (PL 14) into my local repo

Re: Processing Pull Request

2014-05-25 Thread Benson Margulies
You add special comments to a commit to close a PR. I only have my phone I can't supply details. On May 25, 2014 6:04 PM, Michael Osipov mosi...@gmx.de wrote: Hi, does it take special permissions on Github to process pull requests? Neither am I allowed to perform the merge from the website

Processing Pull Request

2014-05-24 Thread Michael Osipov
Hi, does it take special permissions on Github to process pull requests? Neither am I allowed to perform the merge from the website directly, nor does it display the command line steps as described in the GH help. Close is not available to me too. I simply pulled (PL 14) into my local repo

Re: Processing Pull Request

2014-05-24 Thread Jason van Zyl
Yes, I'm interested as well. On May 24, 2014, at 9:33 AM, Michael Osipov micha...@apache.org wrote: Hi, does it take special permissions on Github to process pull requests? Neither am I allowed to perform the merge from the website directly, nor does it display the command line steps

Re: Processing Pull Request

2014-05-24 Thread Alexander Kriegisch
Does this help? https://help.github.com/articles/using-pull-requests -- Alexander Kriegisch Am 24.05.2014 um 16:07 schrieb Jason van Zyl ja...@takari.io: Yes, I'm interested as well. On May 24, 2014, at 9:33 AM, Michael Osipov micha...@apache.org wrote: Hi, does it take special

Re: Processing Pull Request

2014-05-24 Thread Alexander Kriegisch
As for necessary permissions: https://help.github.com/articles/what-are-the-different-access-permissions -- Alexander Kriegisch Am 24.05.2014 um 17:09 schrieb Alexander Kriegisch alexan...@kriegisch.name: Does this help? https://help.github.com/articles/using-pull-requests -- Alexander

Re: Processing Pull Request

2014-05-24 Thread Jason van Zyl
The mechanics of processing PRs from repos we have access to is all good. But the Apache repos on Github I'm not sure who actually owns them, I assume ASF infra. For any moderately sized PR I add the PR as a remote and process it locally. But for simple patches I really would just like to hit

Re: Processing Pull Request

2014-05-24 Thread Michael-O
Am 2014-05-24 17:09, schrieb Alexander Kriegisch: Does this help? https://help.github.com/articles/using-pull-requests This can't help becuase the repos aren't located at github but at apache. - To unsubscribe, e-mail:

Re: Processing Pull Request

2014-05-24 Thread Michael Osipov
Am 2014-05-24 17:38, schrieb Alexander Kriegisch: As for necessary permissions: https://help.github.com/articles/what-are-the-different-access-permissions That's good but how does one know whether he as Write Access Teams Repository Access' or not. Especially for mirrored repos.

Re: Processing Pull Request

2014-05-24 Thread Michael-O
Am 2014-05-24 18:39, schrieb Jason van Zyl: The mechanics of processing PRs from repos we have access to is all good. But the Apache repos on Github I'm not sure who actually owns them, I assume ASF infra. For any moderately sized PR I add the PR as a remote and process it locally. But for

Re: Processing Pull Request

2014-05-24 Thread Alexander Kriegisch
I am not a Maven or other Apache committer. I just wanted to help and saw the initial question about GitHub PRs which I have answered. I really cannot say anything intelligent about the follow-up questions though, only one general thing: Now you know what type of access right you need for

Re: Processing Pull Request

2014-05-24 Thread Igor Fedorenko
Please don't use Github PL merge functionality. This will create merge commits... and I seriously dislike merge commits, hate them, actually. -- Regards, Igor On 2014-05-24, 12:39, Jason van Zyl wrote: The mechanics of processing PRs from repos we have access to is all good. But the Apache

Re: Processing Pull Request

2014-05-24 Thread Michael Osipov
Am 2014-05-24 18:57, schrieb Igor Fedorenko: Please don't use Github PL merge functionality. This will create merge commits... and I seriously dislike merge commits, hate them, actually. Are you able to share your experience by improving the Git Convention on the Maven website? Me and others

Re: Processing Pull Request

2014-05-24 Thread Igor Fedorenko
I don't know what git issues you mean, but I can explain why I dislike github pull requests. My problem with pull-requests is two-fold. First, they create merge commits, which pollute commit history and make it much harder to comprehend. I've seen projects with tens of parallel commit lanes

Re: Processing Pull Request

2014-05-24 Thread Bernd Eckenfels
Am Sat, 24 May 2014 19:06:24 +0200 schrieb Michael Osipov micha...@apache.org: Am 2014-05-24 18:57, schrieb Igor Fedorenko: Please don't use Github PL merge functionality. This will create merge commits... and I seriously dislike merge commits, hate them, actually. Are you able to share

Re: Processing Pull Request

2014-05-24 Thread Bernd Eckenfels
Am Sat, 24 May 2014 13:46:42 -0400 schrieb Igor Fedorenko i...@ifedorenko.com: Second, pull-requests encourage multiple commits, when in most cases each pull-request corresponds to single logic change. This, too, makes commit history harder to comprehend for no good reason. That is actually