Review Request 20363: date_utils.hpp: fix comment for date used in Mesos IDs

2014-04-15 Thread Chengwei Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20363/ --- Review request for mesos, Adam B, Ben Mahler, Jie Yu, and Vinod Kone.

Review Request 20364: post-reviews.py: handle working on master branch

2014-04-15 Thread Chengwei Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20364/ --- Review request for mesos, Adam B, Ben Mahler, Jie Yu, and Vinod Kone.

Re: Review Request 20362: Attribute operator doesn't support type Value::SET

2014-04-15 Thread Chengwei Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20362/#review40364 --- I'll upload a new version to fix all the places which use

[jira] [Commented] (MESOS-1045) Unrecognized file extension in CommandInfo.URI causes executor to exit

2014-04-15 Thread Sebastien Coutu (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969567#comment-13969567 ] Sebastien Coutu commented on MESOS-1045: Hi, In our deploy of Mesos, we use

Re: Mesos Wire Protocol Documentation

2014-04-15 Thread Vladimir Vivien
@benh thanks for the info. On Mon, Apr 14, 2014 at 12:50 PM, Benjamin Hindman b...@eecs.berkeley.eduwrote: Not the Event/Call stuff but the 'libprocess-from' and '202 Accepted' reviews. On Mon, Apr 14, 2014 at 10:40 AM, Kevin Sweeney kevin.t.swee...@gmail.comwrote: Didn't see the

Re: Review Request 19762: Improved Registrar performance by using a hashset on SlaveIDs.

2014-04-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19762/#review40395 --- Patch looks great! Reviews applied: [19762] All tests passed. -

[jira] [Created] (MESOS-1209) Latest build fails

2014-04-15 Thread james michael dupont (JIRA)
james michael dupont created MESOS-1209: --- Summary: Latest build fails Key: MESOS-1209 URL: https://issues.apache.org/jira/browse/MESOS-1209 Project: Mesos Issue Type: Bug

[jira] [Commented] (MESOS-1209) Latest build fails

2014-04-15 Thread james michael dupont (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969679#comment-13969679 ] james michael dupont commented on MESOS-1209: - Working on a patch for

Re: Review Request 20364: post-reviews.py: handle working on master branch

2014-04-15 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20364/#review40401 --- Ship it! support/post-reviews.py

Re: Review Request 20277: Introduced 'libprocess-from' to identify a libprocess message.

2014-04-15 Thread Benjamin Hindman
On April 15, 2014, 4:37 a.m., Kevin Sweeney wrote: 3rdparty/libprocess/src/process.cpp, line 829 https://reviews.apache.org/r/20277/diff/2/?file=555478#file555478line829 What happens if this is malformed? Kevin Sweeney wrote: Ah I see your TODO above so I assume the process

Re: Review Request 20221: Changed executor state recovery to allow run recovery in absence of executor info.

2014-04-15 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20221/ --- (Updated April 15, 2014, 9:51 a.m.) Review request for mesos, Ian Downes and

[jira] [Assigned] (MESOS-1209) Latest build fails

2014-04-15 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone reassigned MESOS-1209: - Assignee: james michael dupont Thanks James for taking the initiative to fix. Assigning the

[jira] [Updated] (MESOS-1209) Latest build fails

2014-04-15 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone updated MESOS-1209: -- Fix Version/s: 0.19.0 Latest build fails -- Key: MESOS-1209

[jira] [Created] (MESOS-1210) OsTest.children test is flaky

2014-04-15 Thread Jie Yu (JIRA)
Jie Yu created MESOS-1210: - Summary: OsTest.children test is flaky Key: MESOS-1210 URL: https://issues.apache.org/jira/browse/MESOS-1210 Project: Mesos Issue Type: Bug Affects Versions: 0.19.0

[jira] [Commented] (MESOS-809) External control of the ip that Mesos components publish to zookeeper

2014-04-15 Thread Mike Babineau (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969728#comment-13969728 ] Mike Babineau commented on MESOS-809: - This seems similar to MESOS-672, the solution

[jira] [Reopened] (MESOS-1152) ProcTest.MultipleThreads is flaky

2014-04-15 Thread Jie Yu (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jie Yu reopened MESOS-1152: --- Reopen this as it is still flaky on my machine: [ RUN ] ProcTest.MultipleThreads

[jira] [Commented] (MESOS-1209) Latest build fails

2014-04-15 Thread james michael dupont (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969744#comment-13969744 ] james michael dupont commented on MESOS-1209: - Here is a patch

[jira] [Commented] (MESOS-1210) OsTest.children test is flaky

2014-04-15 Thread Jie Yu (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969743#comment-13969743 ] Jie Yu commented on MESOS-1210: --- Maybe related to MESOS-1152 as all tests are run in

[jira] [Commented] (MESOS-1209) Latest build fails

2014-04-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969747#comment-13969747 ] ASF GitHub Bot commented on MESOS-1209: --- GitHub user h4ck3rm1k3 opened a pull

[jira] [Commented] (MESOS-1209) Latest build fails

2014-04-15 Thread james michael dupont (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969748#comment-13969748 ] james michael dupont commented on MESOS-1209: - Here is the pull request

Re: Review Request 20364: post-reviews.py: handle working on master branch

2014-04-15 Thread Chengwei Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20364/ --- (Updated April 15, 2014, 5:18 p.m.) Review request for mesos and Benjamin

Re: Review Request 20097: Added a configurable limit on the percentage of slaves that can be removed after the re-registration timeout.

2014-04-15 Thread Vinod Kone
On April 9, 2014, 11:04 p.m., Vinod Kone wrote: src/master/flags.hpp, lines 81-90 https://reviews.apache.org/r/20097/diff/1/?file=552174#file552174line81 This is pretty verbose for a flag description. How about making the example a comment rather than include it in the

Re: Review Request 20347: Added API for getting the default gateway.

2014-04-15 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20347/#review40412 --- src/linux/routing/route.cpp

Re: Review Request 20292: Added API for managing links.

2014-04-15 Thread Jie Yu
On April 15, 2014, 12:17 a.m., Ian Downes wrote: src/linux/routing/link/link.cpp, line 114 https://reviews.apache.org/r/20292/diff/1/?file=555694#file555694line114 What does it mean to create a virtual pair of interfaces if pid is None - both are in the same namespace? I thought

Re: Review Request 20097: Added a configurable limit on the percentage of slaves that can be removed after the re-registration timeout.

2014-04-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20097/#review40415 --- src/master/master.cpp

Re: Review Request 20097: Added a configurable limit on the percentage of slaves that can be removed after the re-registration timeout.

2014-04-15 Thread Vinod Kone
On April 15, 2014, 5:44 p.m., Vinod Kone wrote: src/master/master.cpp, lines 790-805 https://reviews.apache.org/r/20097/diff/2/?file=557771#file557771line790 Actually, doesn't the failed over master remove additional slaves? IIUC, the way the code is written, a master removes X

Re: Review Request 20292: Added API for managing links.

2014-04-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20292/ --- (Updated April 15, 2014, 5:46 p.m.) Review request for mesos, Benjamin

Re: Review Request 20347: Added API for getting the default gateway.

2014-04-15 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20347/#review40419 --- src/linux/routing/route.cpp

Re: Review Request 20347: Added API for getting the default gateway.

2014-04-15 Thread Jie Yu
On April 15, 2014, 5:49 p.m., Cong Wang wrote: src/linux/routing/route.cpp, line 103 https://reviews.apache.org/r/20347/diff/2/?file=557780#file557780line103 I don't quite understand the logic of your code. How do you check if this gateway is the default one? In libnl, it uses

Review Request 20373: Added libprocess metrics to master/slave '/stats.json'.

2014-04-15 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20373/ --- Review request for mesos and Ben Mahler. Repository: mesos-git Description

Review Request 20374: Added timeouts to registrar.

2014-04-15 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20374/ --- Review request for mesos and Ben Mahler. Repository: mesos-git Description

[GitHub] mesos pull request: #MESOS-1209 bug fix for debian

2014-04-15 Thread h4ck3rm1k3
GitHub user h4ck3rm1k3 opened a pull request: https://github.com/apache/mesos/pull/14 #MESOS-1209 bug fix for debian simple patch You can merge this pull request into a Git repository by running: $ git pull https://github.com/h4ck3rm1k3/mesos master Alternatively you can

Re: Review Request 20295: Added API for managing ICMP packet filters.

2014-04-15 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20295/#review40335 --- Looks good but there's a lot going on here! Could you add

Re: Review Request 20347: Added API for getting the default gateway.

2014-04-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20347/ --- (Updated April 15, 2014, 6:10 p.m.) Review request for mesos, Benjamin

Re: Review Request 20296: Added API for managing ARP packet filters.

2014-04-15 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20296/#review40426 --- src/linux/routing/filter/arp.cpp

Re: Review Request 20295: Added API for managing ICMP packet filters.

2014-04-15 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20295/#review40428 --- src/linux/routing/filter/internal.hpp

Re: 0.18.1

2014-04-15 Thread Vinod Kone
On Mon, Apr 14, 2014 at 10:10 PM, Vinod Kone vi...@twitter.com wrote: Looks like I missed cherry-picking the fix for https://issues.apache.org/jira/browse/MESOS-1045 into 0.18.0. So I would like to cut 0.18.1 with the cherry-pick. If there is any other important fix that belongs to 0.18.*

Re: Review Request 20297: Added API for managing IP packet filters.

2014-04-15 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20297/#review40427 --- src/linux/routing/filter/ip.cpp

[jira] [Created] (MESOS-1211) MesosContainerizer should recover isolators after the launcher recovers

2014-04-15 Thread Ian Downes (JIRA)
Ian Downes created MESOS-1211: - Summary: MesosContainerizer should recover isolators after the launcher recovers Key: MESOS-1211 URL: https://issues.apache.org/jira/browse/MESOS-1211 Project: Mesos

Re: Review Request 20292: Added API for managing links.

2014-04-15 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20292/#review40434 --- src/tests/routing_tests.cpp

Re: Review Request 20297: Added API for managing IP packet filters.

2014-04-15 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20297/#review40435 --- src/linux/routing/filter/ip.cpp

Re: Review Request 20307: Added process::async overloads for void functions.

2014-04-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20307/#review40436 --- Ship it! 3rdparty/libprocess/include/process/async.hpp

Re: Review Request 20306: Added 'cref' and 'ref' to lambda:: namespace.

2014-04-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20306/#review40439 --- Ship it! Ship It! - Vinod Kone On April 14, 2014, 5:47 a.m.,

Re: Review Request 20373: Added libprocess metrics to master/slave '/stats.json'.

2014-04-15 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20373/#review40441 --- Do we want to add this to masters and slaves? Given it's a

Re: Review Request 19545: Ported libprocess system/stats.json endpoint to new metrics library.

2014-04-15 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19545/ --- (Updated April 15, 2014, 12:27 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 20047: Reused statistics for calculating statistics from TimeSeries.

2014-04-15 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20047/ --- (Updated April 15, 2014, 12:31 p.m.) Review request for mesos, Benjamin

Re: Review Request 20104: Added task reconciliation for unknown slaves and tasks.

2014-04-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20104/#review40442 --- Ship it! src/master/master.cpp

Re: Review Request 20097: Added a configurable limit on the percentage of slaves that can be removed after the re-registration timeout.

2014-04-15 Thread Ben Mahler
On April 15, 2014, 5:44 p.m., Vinod Kone wrote: src/master/master.cpp, lines 790-805 https://reviews.apache.org/r/20097/diff/2/?file=557771#file557771line790 Actually, doesn't the failed over master remove additional slaves? IIUC, the way the code is written, a master removes X

Re: Review Request 20097: Added a configurable limit on the percentage of slaves that can be removed after the re-registration timeout.

2014-04-15 Thread Vinod Kone
On April 15, 2014, 5:44 p.m., Vinod Kone wrote: src/master/master.cpp, lines 790-805 https://reviews.apache.org/r/20097/diff/2/?file=557771#file557771line790 Actually, doesn't the failed over master remove additional slaves? IIUC, the way the code is written, a master removes X

Re: Mesos Wire Protocol Documentation

2014-04-15 Thread Vladimir Vivien
@Benh Thanks for the informative/well-documented email regarding wire protocol. Just got through reading and understanding your explanation. I think the proposed patches are a good starting point. I will give them a try. @Kevints Great example on the JVM. It provides perfect way to start with

Re: 0.18.1

2014-04-15 Thread Adam Bordelon
Perhaps commit db3b5ed86b7f5a8d10fd8fc3fd59eb6faec2fe20 for MESOS-979? On Tue, Apr 15, 2014 at 11:19 AM, Vinod Kone vinodk...@gmail.com wrote: On Mon, Apr 14, 2014 at 10:10 PM, Vinod Kone vi...@twitter.com wrote: Looks like I missed cherry-picking the fix for

[jira] [Created] (MESOS-1212) Use maven to compile and package Mesos' Java files.

2014-04-15 Thread Benjamin Hindman (JIRA)
Benjamin Hindman created MESOS-1212: --- Summary: Use maven to compile and package Mesos' Java files. Key: MESOS-1212 URL: https://issues.apache.org/jira/browse/MESOS-1212 Project: Mesos

Re: 0.18.1

2014-04-15 Thread Vinod Kone
Niklas has kindly agreed to be the release manager for 0.18.1. I will let him make the call, but this patch lgtm. On Tue, Apr 15, 2014 at 1:15 PM, Adam Bordelon a...@mesosphere.io wrote: Perhaps commit db3b5ed86b7f5a8d10fd8fc3fd59eb6faec2fe20 for MESOS-979? On Tue, Apr 15, 2014 at 11:19 AM,

Re: Review Request 20140: Updated killTask to only send TASK_LOST when a strict registry is in use.

2014-04-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20140/#review40461 --- Ship it! Ship It! - Vinod Kone On April 9, 2014, 12:06 a.m.,

[jira] [Updated] (MESOS-1045) Unrecognized file extension in CommandInfo.URI causes executor to exit

2014-04-15 Thread Niklas Quarfot Nielsen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niklas Quarfot Nielsen updated MESOS-1045: -- Fix Version/s: (was: 0.19.0) 0.18.1 Unrecognized file

Re: Review Request 20297: Added API for managing IP packet filters.

2014-04-15 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20297/#review40440 --- Ship it! src/linux/routing/filter/ip.cpp

Re: Review Request 18600: Allowed replicated log to do auto initialization.

2014-04-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18600/#review40464 --- src/log/log.hpp https://reviews.apache.org/r/18600/#comment73487

[jira] [Closed] (MESOS-1045) Unrecognized file extension in CommandInfo.URI causes executor to exit

2014-04-15 Thread Niklas Quarfot Nielsen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niklas Quarfot Nielsen closed MESOS-1045. - Resolution: Fixed Unrecognized file extension in CommandInfo.URI causes

[jira] [Updated] (MESOS-1078) JNI calls hasNext on ArrayList instead of iterator.

2014-04-15 Thread Niklas Quarfot Nielsen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niklas Quarfot Nielsen updated MESOS-1078: -- Fix Version/s: 0.18.1 JNI calls hasNext on ArrayList instead of iterator.

[jira] [Updated] (MESOS-979) Master segfault when tasks.json endpoint is hit

2014-04-15 Thread Niklas Quarfot Nielsen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niklas Quarfot Nielsen updated MESOS-979: - Fix Version/s: (was: 0.19.0) 0.18.1 Master segfault when

Re: Review Request 20097: Added a configurable limit on the percentage of slaves that can be removed after the re-registration timeout.

2014-04-15 Thread Ben Mahler
On April 9, 2014, 11:04 p.m., Vinod Kone wrote: src/master/main.cpp, lines 164-187 https://reviews.apache.org/r/20097/diff/1/?file=552175#file552175line164 Is there a reason this is in main.cpp and not in master.cpp? The latter will make it easy to write tests for this

Re: Review Request 20097: Added a configurable limit on the percentage of slaves that can be removed after the re-registration timeout.

2014-04-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20097/ --- (Updated April 15, 2014, 9:47 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 20104: Added task reconciliation for unknown slaves and tasks.

2014-04-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20104/ --- (Updated April 15, 2014, 9:57 p.m.) Review request for mesos, Benjamin Hindman

[jira] [Commented] (MESOS-336) Mesos slave should cache executors

2014-04-15 Thread Davis Wamola (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970116#comment-13970116 ] Davis Wamola commented on MESOS-336: The 'Last-modified' date in the HTTP headers is

[jira] [Assigned] (MESOS-1212) Use maven to compile and package Mesos' Java files.

2014-04-15 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobi Knaup reassigned MESOS-1212: - Assignee: Tobi Knaup Use maven to compile and package Mesos' Java files.

Re: Review Request 20097: Added a configurable limit on the percentage of slaves that can be removed after the re-registration timeout.

2014-04-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20097/#review40467 --- src/master/master.cpp

[jira] [Commented] (MESOS-336) Mesos slave should cache executors

2014-04-15 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970157#comment-13970157 ] Vinod Kone commented on MESOS-336: -- But it is safe to re-download right? Anyway, I agree

Re: Review Request 20329: Shade protobuf dependency.

2014-04-15 Thread Tobi Knaup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20329/#review40471 --- Ship it! lgtm! For testing, jar tf should show the shaded

[jira] [Commented] (MESOS-1036) Implement a library for exposing statistical metrics.

2014-04-15 Thread Dominic Hamon (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970182#comment-13970182 ] Dominic Hamon commented on MESOS-1036: -- Base library has landed, design doc is at

[jira] [Resolved] (MESOS-1202) Make it easy to apply GitHub pull requests

2014-04-15 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone resolved MESOS-1202. --- Resolution: Fixed commit 74b042ac2cfdd118c971478f55ecf215c20d85f2 Author: Jake Farrell

[jira] [Commented] (MESOS-336) Mesos slave should cache executors

2014-04-15 Thread Bernd Mathiske (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970207#comment-13970207 ] Bernd Mathiske commented on MESOS-336: -- Agreed that we should split the task like

Re: Review Request 20097: Added a configurable limit on the percentage of slaves that can be removed after the re-registration timeout.

2014-04-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20097/ --- (Updated April 16, 2014, 12:27 a.m.) Review request for mesos, Benjamin

Review Request 20383: If a non-strict registry is in use, do not inform frameworks that slaves are lost if they do not re-register after a failover.

2014-04-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20383/ --- Review request for mesos, Benjamin Hindman and Vinod Kone. Repository:

[jira] [Commented] (MESOS-336) Mesos slave should cache executors

2014-04-15 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970274#comment-13970274 ] Tobi Knaup commented on MESOS-336: -- You could leverage the ETag HTTP header. It's usually

Re: Review Request 18730: Implemented a basic Authorizer interface.

2014-04-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18730/ --- (Updated April 16, 2014, 12:41 a.m.) Review request for mesos, Adam B,

Re: Review Request 20097: Added a configurable limit on the percentage of slaves that can be removed after the re-registration timeout.

2014-04-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20097/#review40486 --- Patch looks great! Reviews applied: [19857, 20097] All tests

[jira] [Commented] (MESOS-1212) Use maven to compile and package Mesos' Java files.

2014-04-15 Thread John Sirois (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970317#comment-13970317 ] John Sirois commented on MESOS-1212: I'm happy to non-binding review this if you ping

Re: Review Request 20364: post-reviews.py: handle working on master branch

2014-04-15 Thread Chengwei Yang
On April 16, 2014, 12:46 a.m., Benjamin Hindman wrote: support/post-reviews.py, lines 101-103 https://reviews.apache.org/r/20364/diff/1/?file=557924#file557924line101 I think this is fine, but what about also checking if you're on the master branch and giving a nice error message

Re: Review Request 20301: Moved reading of credentials file into sasl/common.hpp for reuse.

2014-04-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20301/#review40487 --- src/master/master.cpp

Re: Review Request 20302: Add a message string to the slave ShutdownMessage.

2014-04-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20302/#review40492 --- src/slave/slave.cpp

Review Request 20402: Use maven to compile and package Mesos' Java files

2014-04-15 Thread Tobi Knaup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20402/ --- Review request for mesos. Bugs: MESOS-1212

[jira] [Commented] (MESOS-1212) Use maven to compile and package Mesos' Java files.

2014-04-15 Thread Tobi Knaup (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970406#comment-13970406 ] Tobi Knaup commented on MESOS-1212: --- Review: https://reviews.apache.org/r/20402/

Re: Review Request 20403: Add all model() declaration into src/common/http.hpp

2014-04-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20403/#review40502 --- Patch looks great! Reviews applied: [20403] All tests passed. -

Review Request 20404: Fix lock issue in src/common/lock.cpp

2014-04-15 Thread Chengwei Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20404/ --- Review request for mesos, Benjamin Hindman and Vinod Kone. Repository:

Re: Review Request 20402: Use maven to compile and package Mesos' Java files

2014-04-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20402/#review40501 --- Ship it! src/Makefile.am