---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20363/
---
Review request for mesos, Adam B, Ben Mahler, Jie Yu, and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20364/
---
Review request for mesos, Adam B, Ben Mahler, Jie Yu, and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20362/#review40364
---
I'll upload a new version to fix all the places which use
[
https://issues.apache.org/jira/browse/MESOS-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969567#comment-13969567
]
Sebastien Coutu commented on MESOS-1045:
Hi,
In our deploy of Mesos, we use
@benh thanks for the info.
On Mon, Apr 14, 2014 at 12:50 PM, Benjamin Hindman
b...@eecs.berkeley.eduwrote:
Not the Event/Call stuff but the 'libprocess-from' and '202 Accepted'
reviews.
On Mon, Apr 14, 2014 at 10:40 AM, Kevin Sweeney
kevin.t.swee...@gmail.comwrote:
Didn't see the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19762/#review40395
---
Patch looks great!
Reviews applied: [19762]
All tests passed.
-
james michael dupont created MESOS-1209:
---
Summary: Latest build fails
Key: MESOS-1209
URL: https://issues.apache.org/jira/browse/MESOS-1209
Project: Mesos
Issue Type: Bug
[
https://issues.apache.org/jira/browse/MESOS-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969679#comment-13969679
]
james michael dupont commented on MESOS-1209:
-
Working on a patch for
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20364/#review40401
---
Ship it!
support/post-reviews.py
On April 15, 2014, 4:37 a.m., Kevin Sweeney wrote:
3rdparty/libprocess/src/process.cpp, line 829
https://reviews.apache.org/r/20277/diff/2/?file=555478#file555478line829
What happens if this is malformed?
Kevin Sweeney wrote:
Ah I see your TODO above so I assume the process
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20221/
---
(Updated April 15, 2014, 9:51 a.m.)
Review request for mesos, Ian Downes and
[
https://issues.apache.org/jira/browse/MESOS-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vinod Kone reassigned MESOS-1209:
-
Assignee: james michael dupont
Thanks James for taking the initiative to fix. Assigning the
[
https://issues.apache.org/jira/browse/MESOS-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vinod Kone updated MESOS-1209:
--
Fix Version/s: 0.19.0
Latest build fails
--
Key: MESOS-1209
Jie Yu created MESOS-1210:
-
Summary: OsTest.children test is flaky
Key: MESOS-1210
URL: https://issues.apache.org/jira/browse/MESOS-1210
Project: Mesos
Issue Type: Bug
Affects Versions: 0.19.0
[
https://issues.apache.org/jira/browse/MESOS-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969728#comment-13969728
]
Mike Babineau commented on MESOS-809:
-
This seems similar to MESOS-672, the solution
[
https://issues.apache.org/jira/browse/MESOS-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jie Yu reopened MESOS-1152:
---
Reopen this as it is still flaky on my machine:
[ RUN ] ProcTest.MultipleThreads
[
https://issues.apache.org/jira/browse/MESOS-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969744#comment-13969744
]
james michael dupont commented on MESOS-1209:
-
Here is a patch
[
https://issues.apache.org/jira/browse/MESOS-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969743#comment-13969743
]
Jie Yu commented on MESOS-1210:
---
Maybe related to MESOS-1152 as all tests are run in
[
https://issues.apache.org/jira/browse/MESOS-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969747#comment-13969747
]
ASF GitHub Bot commented on MESOS-1209:
---
GitHub user h4ck3rm1k3 opened a pull
[
https://issues.apache.org/jira/browse/MESOS-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969748#comment-13969748
]
james michael dupont commented on MESOS-1209:
-
Here is the pull request
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20364/
---
(Updated April 15, 2014, 5:18 p.m.)
Review request for mesos and Benjamin
On April 9, 2014, 11:04 p.m., Vinod Kone wrote:
src/master/flags.hpp, lines 81-90
https://reviews.apache.org/r/20097/diff/1/?file=552174#file552174line81
This is pretty verbose for a flag description. How about making the
example a comment rather than include it in the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20347/#review40412
---
src/linux/routing/route.cpp
On April 15, 2014, 12:17 a.m., Ian Downes wrote:
src/linux/routing/link/link.cpp, line 114
https://reviews.apache.org/r/20292/diff/1/?file=555694#file555694line114
What does it mean to create a virtual pair of interfaces if pid is None
- both are in the same namespace? I thought
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20097/#review40415
---
src/master/master.cpp
On April 15, 2014, 5:44 p.m., Vinod Kone wrote:
src/master/master.cpp, lines 790-805
https://reviews.apache.org/r/20097/diff/2/?file=557771#file557771line790
Actually, doesn't the failed over master remove additional slaves?
IIUC, the way the code is written, a master removes X
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20292/
---
(Updated April 15, 2014, 5:46 p.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20347/#review40419
---
src/linux/routing/route.cpp
On April 15, 2014, 5:49 p.m., Cong Wang wrote:
src/linux/routing/route.cpp, line 103
https://reviews.apache.org/r/20347/diff/2/?file=557780#file557780line103
I don't quite understand the logic of your code. How do you check if
this gateway is the default one? In libnl, it uses
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20373/
---
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20374/
---
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
GitHub user h4ck3rm1k3 opened a pull request:
https://github.com/apache/mesos/pull/14
#MESOS-1209 bug fix for debian
simple patch
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/h4ck3rm1k3/mesos master
Alternatively you can
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20295/#review40335
---
Looks good but there's a lot going on here! Could you add
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20347/
---
(Updated April 15, 2014, 6:10 p.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20296/#review40426
---
src/linux/routing/filter/arp.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20295/#review40428
---
src/linux/routing/filter/internal.hpp
On Mon, Apr 14, 2014 at 10:10 PM, Vinod Kone vi...@twitter.com wrote:
Looks like I missed cherry-picking the fix for
https://issues.apache.org/jira/browse/MESOS-1045 into 0.18.0.
So I would like to cut 0.18.1 with the cherry-pick. If there is any other
important fix that belongs to 0.18.*
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20297/#review40427
---
src/linux/routing/filter/ip.cpp
Ian Downes created MESOS-1211:
-
Summary: MesosContainerizer should recover isolators after the
launcher recovers
Key: MESOS-1211
URL: https://issues.apache.org/jira/browse/MESOS-1211
Project: Mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20292/#review40434
---
src/tests/routing_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20297/#review40435
---
src/linux/routing/filter/ip.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20307/#review40436
---
Ship it!
3rdparty/libprocess/include/process/async.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20306/#review40439
---
Ship it!
Ship It!
- Vinod Kone
On April 14, 2014, 5:47 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20373/#review40441
---
Do we want to add this to masters and slaves? Given it's a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19545/
---
(Updated April 15, 2014, 12:27 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20047/
---
(Updated April 15, 2014, 12:31 p.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20104/#review40442
---
Ship it!
src/master/master.cpp
On April 15, 2014, 5:44 p.m., Vinod Kone wrote:
src/master/master.cpp, lines 790-805
https://reviews.apache.org/r/20097/diff/2/?file=557771#file557771line790
Actually, doesn't the failed over master remove additional slaves?
IIUC, the way the code is written, a master removes X
On April 15, 2014, 5:44 p.m., Vinod Kone wrote:
src/master/master.cpp, lines 790-805
https://reviews.apache.org/r/20097/diff/2/?file=557771#file557771line790
Actually, doesn't the failed over master remove additional slaves?
IIUC, the way the code is written, a master removes X
@Benh
Thanks for the informative/well-documented email regarding wire protocol.
Just got through reading and understanding your explanation.
I think the proposed patches are a good starting point. I will give them a
try.
@Kevints
Great example on the JVM. It provides perfect way to start with
Perhaps commit db3b5ed86b7f5a8d10fd8fc3fd59eb6faec2fe20 for MESOS-979?
On Tue, Apr 15, 2014 at 11:19 AM, Vinod Kone vinodk...@gmail.com wrote:
On Mon, Apr 14, 2014 at 10:10 PM, Vinod Kone vi...@twitter.com wrote:
Looks like I missed cherry-picking the fix for
Benjamin Hindman created MESOS-1212:
---
Summary: Use maven to compile and package Mesos' Java files.
Key: MESOS-1212
URL: https://issues.apache.org/jira/browse/MESOS-1212
Project: Mesos
Niklas has kindly agreed to be the release manager for 0.18.1. I will let
him make the call, but this patch lgtm.
On Tue, Apr 15, 2014 at 1:15 PM, Adam Bordelon a...@mesosphere.io wrote:
Perhaps commit db3b5ed86b7f5a8d10fd8fc3fd59eb6faec2fe20 for MESOS-979?
On Tue, Apr 15, 2014 at 11:19 AM,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20140/#review40461
---
Ship it!
Ship It!
- Vinod Kone
On April 9, 2014, 12:06 a.m.,
[
https://issues.apache.org/jira/browse/MESOS-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Niklas Quarfot Nielsen updated MESOS-1045:
--
Fix Version/s: (was: 0.19.0)
0.18.1
Unrecognized file
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20297/#review40440
---
Ship it!
src/linux/routing/filter/ip.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18600/#review40464
---
src/log/log.hpp
https://reviews.apache.org/r/18600/#comment73487
[
https://issues.apache.org/jira/browse/MESOS-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Niklas Quarfot Nielsen closed MESOS-1045.
-
Resolution: Fixed
Unrecognized file extension in CommandInfo.URI causes
[
https://issues.apache.org/jira/browse/MESOS-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Niklas Quarfot Nielsen updated MESOS-1078:
--
Fix Version/s: 0.18.1
JNI calls hasNext on ArrayList instead of iterator.
[
https://issues.apache.org/jira/browse/MESOS-979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Niklas Quarfot Nielsen updated MESOS-979:
-
Fix Version/s: (was: 0.19.0)
0.18.1
Master segfault when
On April 9, 2014, 11:04 p.m., Vinod Kone wrote:
src/master/main.cpp, lines 164-187
https://reviews.apache.org/r/20097/diff/1/?file=552175#file552175line164
Is there a reason this is in main.cpp and not in master.cpp?
The latter will make it easy to write tests for this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20097/
---
(Updated April 15, 2014, 9:47 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20104/
---
(Updated April 15, 2014, 9:57 p.m.)
Review request for mesos, Benjamin Hindman
[
https://issues.apache.org/jira/browse/MESOS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970116#comment-13970116
]
Davis Wamola commented on MESOS-336:
The 'Last-modified' date in the HTTP headers is
[
https://issues.apache.org/jira/browse/MESOS-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tobi Knaup reassigned MESOS-1212:
-
Assignee: Tobi Knaup
Use maven to compile and package Mesos' Java files.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20097/#review40467
---
src/master/master.cpp
[
https://issues.apache.org/jira/browse/MESOS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970157#comment-13970157
]
Vinod Kone commented on MESOS-336:
--
But it is safe to re-download right? Anyway, I agree
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20329/#review40471
---
Ship it!
lgtm! For testing, jar tf should show the shaded
[
https://issues.apache.org/jira/browse/MESOS-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970182#comment-13970182
]
Dominic Hamon commented on MESOS-1036:
--
Base library has landed, design doc is at
[
https://issues.apache.org/jira/browse/MESOS-1202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vinod Kone resolved MESOS-1202.
---
Resolution: Fixed
commit 74b042ac2cfdd118c971478f55ecf215c20d85f2
Author: Jake Farrell
[
https://issues.apache.org/jira/browse/MESOS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970207#comment-13970207
]
Bernd Mathiske commented on MESOS-336:
--
Agreed that we should split the task like
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20097/
---
(Updated April 16, 2014, 12:27 a.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20383/
---
Review request for mesos, Benjamin Hindman and Vinod Kone.
Repository:
[
https://issues.apache.org/jira/browse/MESOS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970274#comment-13970274
]
Tobi Knaup commented on MESOS-336:
--
You could leverage the ETag HTTP header. It's usually
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18730/
---
(Updated April 16, 2014, 12:41 a.m.)
Review request for mesos, Adam B,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20097/#review40486
---
Patch looks great!
Reviews applied: [19857, 20097]
All tests
[
https://issues.apache.org/jira/browse/MESOS-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970317#comment-13970317
]
John Sirois commented on MESOS-1212:
I'm happy to non-binding review this if you ping
On April 16, 2014, 12:46 a.m., Benjamin Hindman wrote:
support/post-reviews.py, lines 101-103
https://reviews.apache.org/r/20364/diff/1/?file=557924#file557924line101
I think this is fine, but what about also checking if you're on the
master branch and giving a nice error message
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20301/#review40487
---
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20302/#review40492
---
src/slave/slave.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20402/
---
Review request for mesos.
Bugs: MESOS-1212
[
https://issues.apache.org/jira/browse/MESOS-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970406#comment-13970406
]
Tobi Knaup commented on MESOS-1212:
---
Review: https://reviews.apache.org/r/20402/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20403/#review40502
---
Patch looks great!
Reviews applied: [20403]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20404/
---
Review request for mesos, Benjamin Hindman and Vinod Kone.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20402/#review40501
---
Ship it!
src/Makefile.am
85 matches
Mail list logo