---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27760/#review61413
---
src/authentication/cram_md5/authenticator.hpp
On Nov. 13, 2014, 9:16 a.m., Timothy Chen wrote:
src/slave/containerizer/fetcher.cpp, line 177
https://reviews.apache.org/r/27995/diff/1/?file=762351#file762351line177
I'm also refactoring the mesos containerizer, and I started down the
path where I kept the same signature of
(1) When the ShutdownProcess is gone, we'll adjust the timeout calculation
logic.
(2) In the proposal, we tie the grace period to the executor, but use it
for task finalization. Effectively we assume that each executor launches
similar tasks. This may seem a bit weird, but having timeouts per
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27995/#review61421
---
src/slave/containerizer/fetcher.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27995/
---
(Updated Nov. 14, 2014, 5:41 a.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27995/
---
(Updated Nov. 14, 2014, 5:57 a.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27995/#review61439
---
Patch looks great!
Reviews applied: [27995]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27958/#review61449
---
3rdparty/libprocess/src/process.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27960/#review61453
---
3rdparty/libprocess/include/process/socket.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27961/#review61463
---
Comments from previous reviews apply here too.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27962/#review61464
---
3rdparty/libprocess/src/encoder.hpp
On Nov. 11, 2014, 3:17 p.m., Niklas Nielsen wrote:
Can you expand a little bit on why you needed a new async watcher? Maybe
add it to the review request description :-)
Joris Van Remoortere wrote:
The point of this new async watcher is to start to separate out the 3
concepts that
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27962/#review61404
---
A general comment: could you have used the typeid to determine if
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27961/#review61402
---
3rdparty/libprocess/include/process/socket.hpp
On Nov. 14, 2014, 8:10 a.m., Adam B wrote:
src/master/master.cpp, line 379
https://reviews.apache.org/r/27760/diff/5/?file=762954#file762954line379
Should we even bother reading this flag or reading in the credentials
file if neither --authenticate flag is set?
the reason we
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27924/
---
(Updated Nov. 14, 2014, 11:02 a.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27923/#review61480
---
src/tests/mesos.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27923/#review61481
---
Ship it!
Ship It!
- Ben Mahler
On Nov. 12, 2014, 8:57 p.m., Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27924/#review61484
---
This will need some more thought, as this breaks the resource
On Nov. 14, 2014, 7:33 p.m., Ben Mahler wrote:
This will need some more thought, as this breaks the resource accounting in
the master.
The slave re-registers with tasks and regular executors, which excludes the
command executors.
It looks like the command executor is
For (2), sorry, I get a bit confused when executor and CommandExecutor
are used interchangeably.
So let me confirm we're on the same page: Task finalization is only
relevant for the CommandExecutor, that's where the CommandExecutor assumes
that all tasks need a similar grace period. For regular
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27957/
---
(Updated Nov. 14, 2014, 8:06 p.m.)
Review request for mesos, Benjamin Hindman
On Nov. 13, 2014, 3:25 a.m., Niklas Nielsen wrote:
3rdparty/libprocess/include/process/socket.hpp, line 113
https://reviews.apache.org/r/27957/diff/1/?file=760926#file760926line113
So this becomes integer comparison? Does it make sense to call out the
comparison more explicitally
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28052/
---
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-2112
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27958/
---
(Updated Nov. 14, 2014, 8:31 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27960/
---
(Updated Nov. 14, 2014, 9:19 p.m.)
Review request for mesos, Benjamin Hindman
On Nov. 14, 2014, 5:42 p.m., Benjamin Hindman wrote:
3rdparty/libprocess/src/process.cpp, lines 1585-1587
https://reviews.apache.org/r/27960/diff/1/?file=760931#file760931line1585
Why not have 'get()' return the int file descriptor? Then you can just
do:
return
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27504/
---
(Updated Nov. 14, 2014, 9:39 p.m.)
Review request for mesos, Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27505/
---
(Updated Nov. 14, 2014, 9:39 p.m.)
Review request for mesos, Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27496/
---
(Updated Nov. 14, 2014, 9:40 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27995/#review61508
---
src/slave/containerizer/mesos/containerizer.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27504/#review61511
---
3rdparty/libprocess/src/libev.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27960/
---
(Updated Nov. 14, 2014, 9:48 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27505/#review61512
---
3rdparty/libprocess/src/poll.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27961/
---
(Updated Nov. 14, 2014, 9:51 p.m.)
Review request for mesos, Benjamin Hindman
On Nov. 14, 2014, 6:06 p.m., Niklas Nielsen wrote:
3rdparty/libprocess/include/process/socket.hpp, line 116
https://reviews.apache.org/r/27961/diff/1/?file=760932#file760932line116
Why couldn't this be const before?
I made this const in the previous review.
- Joris
On Nov. 14, 2014, 5:59 p.m., Niklas Nielsen wrote:
A general comment: could you have used the typeid to determine if an
encoder was one or the other?
Yes, but the virtual dispatch is a more efficient path.
- Joris
---
This is an
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27962/#review61519
---
3rdparty/libprocess/src/encoder.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27744/#review61520
---
Ship it!
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27744/#review61521
---
Can you follow up with same for slave for consistency?
- Vinod
On Nov. 14, 2014, 2:13 p.m., Vinod Kone wrote:
Can you follow up with same for slave for consistency?
will do. linked bug references both.
- Dominic
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27964/
---
(Updated Nov. 14, 2014, 10:23 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27960/
---
(Updated Nov. 14, 2014, 10:27 p.m.)
Review request for mesos, Benjamin Hindman
+1
Deployed to our test clusters.
On Fri, Nov 14, 2014 at 2:29 PM, Vinod Kone vinodk...@gmail.com wrote:
+1
Deployed to our test clusters.
On Thu, Nov 13, 2014 at 2:56 PM, Ian Downes idow...@twitter.com.invalid
wrote:
Cosmin,
No, to my knowledge rpms are not available for release
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27960/
---
(Updated Nov. 14, 2014, 10:41 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27502/
---
(Updated Nov. 14, 2014, 10:51 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27966/
---
(Updated Nov. 14, 2014, 10:52 p.m.)
Review request for mesos, Benjamin Hindman
On Nov. 11, 2014, 11:18 p.m., Niklas Nielsen wrote:
3rdparty/libprocess/src/clock.cpp, line 424
https://reviews.apache.org/r/27503/diff/1/?file=747113#file747113line424
How about a Clock::time(seconds) factory instead? Like the refactor you
did for Timer?
Great idea! I
On Nov. 14, 2014, 5:42 p.m., Niklas Nielsen wrote:
3rdparty/libprocess/Makefile.am, line 45
https://reviews.apache.org/r/27505/diff/1/?file=747119#file747119line45
As this poll.cpp is libev specific (and we are going to have multiple
we can switch between), would it make sense to
On Nov. 14, 2014, 9:49 p.m., Dominic Hamon wrote:
3rdparty/libprocess/src/poll.cpp, line 31
https://reviews.apache.org/r/27505/diff/1/?file=747120#file747120line31
as per
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Integer_Types
please avoid 'short' which
On Nov. 12, 2014, 7:22 p.m., Niklas Nielsen wrote:
3rdparty/libprocess/src/process.cpp, line 873
https://reviews.apache.org/r/27508/diff/1/?file=747126#file747126line873
Do you need both socket and s?
Yes, but Joris upcoming reviews replace this, so I'm not going to cause him any
On Nov. 14, 2014, 1:44 p.m., Dominic Hamon wrote:
3rdparty/libprocess/src/libev.cpp, line 14
https://reviews.apache.org/r/27504/diff/1/?file=747117#file747117line14
there's no guarantee when this static construction will happen. this
should almost certainly be a function that
On Nov. 12, 2014, 7:07 p.m., Niklas Nielsen wrote:
3rdparty/libprocess/src/process.cpp, line 845
https://reviews.apache.org/r/27509/diff/1/?file=747127#file747127line845
Why do you also need to pass 's' along? couldn't you get that from
socket?
Yes, but since this code gets
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27496/
---
(Updated Nov. 14, 2014, 11:15 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27497/
---
(Updated Nov. 14, 2014, 11:15 p.m.)
Review request for mesos, Ben Mahler, Jie
On Nov. 12, 2014, 7:13 p.m., Niklas Nielsen wrote:
Can you expand a bit on why/how the race occured?
Joris Van Remoortere wrote:
During high contention, the io::poll code can block after setting up the
watcher and before we attach the onAny callback. This allows the event to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27498/
---
(Updated Nov. 14, 2014, 11:15 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27499/
---
(Updated Nov. 14, 2014, 11:16 p.m.)
Review request for mesos, Ben Mahler, Jie
On Nov. 11, 2014, 10:58 p.m., Niklas Nielsen wrote:
3rdparty/libprocess/src/process.cpp, line 533
https://reviews.apache.org/r/27499/diff/1/?file=747107#file747107line533
How about generalizing as callbacks (a list of callbacks, listeners,
observers)? Not religious about it, but
On Nov. 11, 2014, 10:49 p.m., Niklas Nielsen wrote:
3rdparty/libprocess/include/process/clock.hpp, line 8
https://reviews.apache.org/r/27498/diff/1/?file=747103#file747103line8
Where are you using Nothing()?
Oops, thanks!
On Nov. 11, 2014, 10:49 p.m., Niklas Nielsen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27500/
---
(Updated Nov. 14, 2014, 11:16 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27502/
---
(Updated Nov. 14, 2014, 11:17 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27504/
---
(Updated Nov. 14, 2014, 11:17 p.m.)
Review request for mesos, Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27503/
---
(Updated Nov. 14, 2014, 11:17 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27508/
---
(Updated Nov. 14, 2014, 11:18 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27506/
---
(Updated Nov. 14, 2014, 11:18 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27507/
---
(Updated Nov. 14, 2014, 11:18 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27510/
---
(Updated Nov. 14, 2014, 11:18 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27509/
---
(Updated Nov. 14, 2014, 11:18 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27958/
---
(Updated Nov. 14, 2014, 11:19 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27496/#review61550
---
Ship it!
Ship It!
- Niklas Nielsen
On Nov. 14, 2014, 3:15 p.m.,
On Nov. 11, 2014, 2:49 p.m., Niklas Nielsen wrote:
3rdparty/libprocess/include/process/future.hpp, line 1139
https://reviews.apache.org/r/27498/diff/1/?file=747104#file747104line1139
Do you have an example of how that could happen?
Benjamin Hindman wrote:
I updated the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27498/#review61553
---
Ship it!
Ship It!
- Niklas Nielsen
On Nov. 14, 2014, 3:15 p.m.,
On Nov. 11, 2014, 2:49 p.m., Niklas Nielsen wrote:
It would be really helpful if we could put together a sequence chart of
what can be going on during settle and what needs to get synchronized
I'll go ahead and add a JIRA ticket for the documentation piece.
- Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27499/#review61554
---
Ship it!
Ship It!
- Niklas Nielsen
On Nov. 14, 2014, 3:16 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28061/
---
Review request for mesos and Niklas Nielsen.
Repository: mesos-git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28061/#review61559
---
Ship it!
Ship It!
- Niklas Nielsen
On Nov. 14, 2014, 3:58 p.m.,
On Nov. 13, 2014, 3:13 a.m., Niklas Nielsen wrote:
Can you expand a bit on why/how the race occured?
Joris Van Remoortere wrote:
During high contention, the io::poll code can block after setting up the
watcher and before we attach the onAny callback. This allows the event to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27921/#review61567
---
Ship it!
Ship It!
- Niklas Nielsen
On Nov. 12, 2014, 11:59
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27958/#review61569
---
Ship it!
This chain of reviews needs some tests specifically for
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27920/#review61571
---
Ship it!
Ship It!
- Niklas Nielsen
On Nov. 12, 2014, 11:54
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27960/#review61570
---
Ship it!
3rdparty/libprocess/src/process.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27920/#review61572
---
Can you rebase?
- Niklas Nielsen
On Nov. 12, 2014, 11:54 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28063/
---
Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27351/#review61575
---
Can I get you to rebase this one as well?
- Niklas Nielsen
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27961/#review61574
---
Ship it!
3rdparty/libprocess/src/process.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27962/#review61576
---
Ship it!
Ship It!
- Benjamin Hindman
On Nov. 14, 2014, 10:03
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27963/#review61577
---
Ship it!
Ship It!
- Benjamin Hindman
On Nov. 13, 2014, 2:52
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28065/
---
Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27964/#review61579
---
3rdparty/libprocess/src/process.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28061/#review61584
---
Patch looks great!
Reviews applied: [27496, 27497, 27498, 27499,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27966/#review61583
---
3rdparty/libprocess/src/poll.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27967/#review61585
---
3rdparty/libprocess/src/process.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27501/#review61589
---
Ship it!
Ship It!
- Niklas Nielsen
On Nov. 14, 2014, 4:01 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27508/#review61592
---
Ship it!
Ship It!
- Niklas Nielsen
On Nov. 14, 2014, 3:18 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27510/#review61590
---
Ship it!
Ship It!
- Niklas Nielsen
On Nov. 14, 2014, 3:18 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27509/#review61591
---
Ship it!
Ship It!
- Niklas Nielsen
On Nov. 14, 2014, 3:18 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27503/#review61594
---
Ship it!
Ship It!
- Niklas Nielsen
On Nov. 14, 2014, 3:17 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27504/#review61593
---
Ship it!
Ship It!
- Niklas Nielsen
On Nov. 14, 2014, 3:17 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28069/
---
Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
1 - 100 of 147 matches
Mail list logo
