check for principal match though.
src/tests/master_validation_tests.cpp
https://reviews.apache.org/r/32150/#comment131414
Don't you get an unused variable warning?
- Alexander Rukletsov
On April 15, 2015, 3:55 p.m., Michael Park wrote
On March 18, 2015, 12:27 a.m., Alexander Rukletsov wrote:
src/common/resources.cpp, lines 69-74
https://reviews.apache.org/r/32140/diff/1/?file=897349#file897349line69
Not yours, but resently, Vinod did a cleanup in equivalence operators
for our proto messages in `type_utils.{hpp
the following:
StatusUpdateStream is not a template, hence we can reduce compilation time by
moving method definitions into a `.cpp` file. As a drive-by change headers are
cleaned up.
Thank you for putting effort into reducing compilation time!
- Alexander Rukletsov
On April 22, 2015, 9:09 a.m
/#comment131406
Won't this be equivalent to the auto-generated version?
- Alexander Rukletsov
On April 15, 2015, 4:12 p.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
/32139/#comment131402
Let's mention this principal should match `FrameworkInfo.princpal`.
Actually all other as well: `Credential.principal` and
`RateLimit.principal`, but I don't think we should reference them here.
- Alexander Rukletsov
On April 21, 2015, 8:35 p.m., Michael Park
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32149/#review81148
---
Ship it!
Modulo Tim's and Jie's comments.
- Alexander Rukletsov
On April 8, 2015, 5:52 p.m., Alexander Rukletsov wrote:
Looks good to me, mind update the design doc?
Vinod Kone wrote:
isabel has kindly agreed to update the doc by EOD.
Great!
- Alexander
---
This is an automatically
://reviews.apache.org/r/31265/diff/
Testing
---
make check (Mac OS 10.9.5, Ubuntu 14.04)
Thanks,
Alexander Rukletsov
://reviews.apache.org/r/31265/diff/
Testing
---
make check (Mac OS 10.9.5, Ubuntu 14.04)
Thanks,
Alexander Rukletsov
On April 8, 2015, 5:52 p.m., Alexander Rukletsov wrote:
src/master/master.cpp, lines 1626-1628
https://reviews.apache.org/r/32845/diff/1/?file=915074#file915074line1626
Shall we check `framework-pid == from` as we do in
`Master::unregisterFramework()`?
Also metrcis
April 21, 2015, 12:38 p.m.)
Review request for mesos, Alexander Rukletsov, Joerg Schad, and Till
Toenshoff.
Bugs: MESOS-2609
https://issues.apache.org/jira/browse/MESOS-2609
Repository: mesos
Description
---
Moves the implementation of StatusUpdateStream
On April 21, 2015, 12:51 a.m., Marco Massenzio wrote:
src/master/http.cpp, line 300
https://reviews.apache.org/r/30612/diff/12/?file=935462#file935462line300
can we have all routes patters as CONSTANTS defined in the class
header? definitely easier to debug etc.
Marco, we tend
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32843/#review80990
---
Ship it!
Modulo Ben's comments.
- Alexander Rukletsov
On April
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32506/#review80992
---
Ship it!
Ship It!
- Alexander Rukletsov
On April 20, 2015, 8:02
,
Alexander Rukletsov
d15a37365bcdd5c3906160b46b389635b38b1673
src/module/manager.cpp 82a38f06e57d034650a6ac32fd73527b38cc97b8
Diff: https://reviews.apache.org/r/31266/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
it compiles now since TestAllocator is a template.
Diffs (updated)
-
src/tests/mesos.hpp 7744df55a2a31446327da7bd2b16457e90711d22
Diff: https://reviews.apache.org/r/31262/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
7744df55a2a31446327da7bd2b16457e90711d22
src/tests/slave_recovery_tests.cpp 87f4a6aab27d142fa8eb7a6571f684a6ce59687e
Diff: https://reviews.apache.org/r/31263/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
: https://reviews.apache.org/r/31776/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
b81144f56e94034feecf3a6a4992af078cf60a81
Diff: https://reviews.apache.org/r/31267/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
/tests/hierarchical_allocator_tests.cpp
0b564a74d3f04df46fe52fcbe1bf8d4d1e41c53c
src/tests/mesos.hpp 7744df55a2a31446327da7bd2b16457e90711d22
Diff: https://reviews.apache.org/r/33356/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31776/#review78690
---
On April 15, 2015, 2:16 p.m., Alexander Rukletsov wrote
Diff: https://reviews.apache.org/r/31265/diff/
Testing
---
make check (Mac OS 10.9.5, Ubuntu 14.04)
Thanks,
Alexander Rukletsov
/master_allocator_tests.cpp 03a1bb8c92b44bc1ad1b5f5cff8d1fb971df2302
Diff: https://reviews.apache.org/r/31268/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31265/
---
(Updated April 15, 2015, 2:19 p.m
;
}
virtual void TearDown()
{
destroy();
MeosTest::TearDown();
}
private:
TestAllocator* allocator;
};
```
Alexander Rukletsov wrote:
We used to have a lifecycle method but decided to remove
://reviews.apache.org/r/31265/#review80445
---
On April 15, 2015, 2:19 p.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33263/#review80447
---
Ship it!
Ship It!
- Alexander Rukletsov
On April 16, 2015, 2:31
On April 2, 2015, 7:59 p.m., Vinod Kone wrote:
src/master/allocator/mesos/allocator.hpp, line 47
https://reviews.apache.org/r/31265/diff/6/?file=912110#file912110line47
Do you still want the constructor public?
Alexander Rukletsov wrote:
I think there is no reason to hide
d15a37365bcdd5c3906160b46b389635b38b1673
src/module/manager.cpp 82a38f06e57d034650a6ac32fd73527b38cc97b8
Diff: https://reviews.apache.org/r/31266/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
b81144f56e94034feecf3a6a4992af078cf60a81
Diff: https://reviews.apache.org/r/31267/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
/tests/mesos.hpp 42e42ac425a448fcc5e93db1cef1112cbf5e67c4
Diff: https://reviews.apache.org/r/31265/diff/
Testing
---
make check (Mac OS 10.9.5, Ubuntu 14.04)
Thanks,
Alexander Rukletsov
882a9ff4d09aace486182828bf43b643b0d0c519
src/tests/slave_recovery_tests.cpp 87f4a6aab27d142fa8eb7a6571f684a6ce59687e
Diff: https://reviews.apache.org/r/31263/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
(updated)
-
src/tests/mesos.hpp 42e42ac425a448fcc5e93db1cef1112cbf5e67c4
Diff: https://reviews.apache.org/r/31262/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
://reviews.apache.org/r/31776/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
/master_allocator_tests.cpp 03a1bb8c92b44bc1ad1b5f5cff8d1fb971df2302
Diff: https://reviews.apache.org/r/31268/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
reservation set,
`isReserved(resource, *)` is going to return `true`? Given that
'resource' is invalid, we should return a `false` in that case?
Alexander Rukletsov wrote:
Can we have a resource with `role == *` and reservations set?
Excuse my premature comment earlier, I'm slowly starting
e-mail. To reply, visit:
https://reviews.apache.org/r/32140/
---
(Updated April 7, 2015, 9:56 p.m.)
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
Bugs: MESOS-2476
https://issues.apache.org/jira
currently make.
src/tests/mesos.hpp
https://reviews.apache.org/r/32140/#comment129998
Why not putting the definition into `tests/mesos.cpp`? Here and below.
- Alexander Rukletsov
On April 15, 2015, 4:12 p.m., Michael Park wrote
/#comment129976
While `required` here, `principal` is `optional` in `FrameworkInfo`. Let's
update the comment there to hint folks they should provide `principal` of they
want their framework to reserve resources.
- Alexander Rukletsov
On April 15, 2015, 4:13 p.m., Michael Park wrote
/#comment129774
`#include logging/logging.hpp`?
src/authentication/cram_md5/authenticatee.cpp
https://reviews.apache.org/r/32850/#comment129775
`#include process/dispatch.hpp?
- Alexander Rukletsov
On April 10, 2015, 2:58 a.m., Till Toenshoff wrote
On April 14, 2015, 6:17 p.m., Joerg Schad wrote:
src/authentication/cram_md5/authenticatee.cpp, line 33
https://reviews.apache.org/r/32850/diff/4/?file=927033#file927033line33
Actually according to Google's styleguide this should be the first
include, shouldn't it?
On April 14, 2015, 2:16 p.m., Alexander Rukletsov wrote:
src/authentication/cram_md5/authenticatee.cpp, lines 46-47
https://reviews.apache.org/r/32850/diff/3/?file=922370#file922370line46
Let's move to newline to avoid jaggeddness. Btw, what does clang-format
suggest?
Kapil
: https://reviews.apache.org/r/32536/diff/
Testing
---
None (not a functional change).
Thanks,
Alexander Rukletsov
On April 8, 2015, 1:20 p.m., Alexander Rukletsov wrote:
Please check my comment to https://reviews.apache.org/r/32608/. Also,
please add Kapil Arya karya, myself alex-mesos and a committer to the
list of reviewers.
Aditi Dixit wrote:
Would adding any committer be ok? Or should I
On April 8, 2015, 1:20 p.m., Alexander Rukletsov wrote:
Please check my comment to https://reviews.apache.org/r/32608/. Also,
please add Kapil Arya karya, myself alex-mesos and a committer to the
list of reviewers.
Aditi Dixit wrote:
Would adding any committer be ok? Or should I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32997/#review79534
---
Ship it!
Ship It!
- Alexander Rukletsov
On April 9, 2015, 12:30
/#comment128948
Minor nit: I believe we use trailing underscores in this case. Think prime
symbols.
- Alexander Rukletsov
On April 8, 2015, 9:11 p.m., Isabel Jimenez wrote:
---
This is an automatically generated e-mail. To reply, visit
name as
discussed in MESOS-2565. Same for other entries.
- Alexander Rukletsov
On April 8, 2015, 8:05 p.m., Aditi Dixit wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32967
On March 6, 2015, 10:57 p.m., Alexander Rukletsov wrote:
src/master/allocator/allocator.hpp, line 67
https://reviews.apache.org/r/31666/diff/2/?file=883424#file883424line67
In `updateAllocation()` and `recoverResources()` we pass both `SlaveID`
and `FrameworkID` as function
/. Also, please
add Kapil Arya karya, myself alex-mesos and a committer to the list of
reviewers.
- Alexander Rukletsov
On April 8, 2015, 12:44 p.m., Aditi Dixit wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
`_allocations` is per-client allocation, let's reflect this in the name and
get rid of leading underscore. How about `clientAllocations`?
- Alexander Rukletsov
On March 7, 2015, 10:03 a.m., Michael Park wrote
, not the intermediate
variable.
src/master/http.cpp
https://reviews.apache.org/r/31665/#comment128604
Not sure what you mean here. Is it worth creating a JIRA ticket?
- Alexander Rukletsov
On March 7, 2015, 10:02 a.m., Michael Park wrote
` in the kill
request. But I'd better comment on MESOS-1127 instead.
src/tests/scheduler_tests.cpp
https://reviews.apache.org/r/32843/#comment128649
s/ / here and below.
- Alexander Rukletsov
On April 3, 2015, 11:40 p.m., Vinod Kone wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32501/#review79354
---
Ship it!
- Alexander Rukletsov
On March 31, 2015, 12:06 a.m
you want to update metrics here?
`++metrics-messages_reconcile_tasks;`
- Alexander Rukletsov
On April 3, 2015, 11:36 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org
/scheduler/scheduler.proto
https://reviews.apache.org/r/32509/#comment128674
Not yours, but could you fix the length please?
- Alexander Rukletsov
On April 3, 2015, 11:55 p.m., Vinod Kone wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32504/#review79368
---
Ship it!
- Alexander Rukletsov
On March 31, 2015, 12:08 a.m
s/ / here and below.
- Alexander Rukletsov
On April 3, 2015, 11:50 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32845
failure here? Maybe it makes sense to
write a short comment to the test as well.
- Alexander Rukletsov
On April 3, 2015, 11:38 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
we do want to break it.
src/master/master.cpp
https://reviews.apache.org/r/32844/#comment128659
Could you please re-format this comment?
src/scheduler/scheduler.cpp
https://reviews.apache.org/r/32844/#comment128663
s/should not/may not/
- Alexander Rukletsov
On April 3, 2015, 11
::Event_Type_Name()` for clarity?
- Alexander Rukletsov
On April 3, 2015, 11:42 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32506
`Master::accept()` and not via `Master::launchTasks()`. If this is the
case, then it looks like we do not update some metrics, namely:
`++metrics-messages_launch_tasks;`
`++metrics-messages_decline_offers;`
Do you plan to adress this later on or am I missing something?
- Alexander
, visit:
https://reviews.apache.org/r/31776/#review78690
---
On April 1, 2015, 2:25 p.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit
---
On April 1, 2015, 2:27 p.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31263/
---
(Updated April 1
/31265/#review78711
---
On April 1, 2015, 2:28 p.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31265
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31776/#review78690
---
On April 1, 2015, 2:25 p.m., Alexander Rukletsov wrote
:
https://reviews.apache.org/r/31267/#review78694
---
On April 1, 2015, 2:26 p.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
://reviews.apache.org/r/31776/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
,
Alexander Rukletsov
9c01f5d6c692f835100e7cade928748cc4763cc8
src/module/manager.cpp 82a38f06e57d034650a6ac32fd73527b38cc97b8
Diff: https://reviews.apache.org/r/31266/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
/module.cpp b81144f56e94034feecf3a6a4992af078cf60a81
Diff: https://reviews.apache.org/r/31267/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
(updated)
-
src/tests/mesos.hpp 0e98572a62ae05437bd2bc800c370ad1a0c43751
Diff: https://reviews.apache.org/r/31262/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
/
Testing
---
make check (Mac OS 10.9.5, Ubuntu 14.04)
Thanks,
Alexander Rukletsov
/master_allocator_tests.cpp 03a1bb8c92b44bc1ad1b5f5cff8d1fb971df2302
Diff: https://reviews.apache.org/r/31268/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
On March 26, 2015, 4:32 p.m., Alexander Rukletsov wrote:
3rdparty/libprocess/src/process.cpp, line 6
https://reviews.apache.org/r/30032/diff/4/?file=834184#file834184line6
One thing captures my attention is how we include C headers. AFAIK, the
standard requires to include them
question: If an executor is killed, does this systemd mode
affect whether its tasks would get killed?
Alexander Rukletsov wrote:
Adam, could you please explain what use case do you have in mind and how
it is related to slave recovery?
Adam B wrote:
It's not related to slave recovery
question: If an executor is killed, does this systemd mode
affect whether its tasks would get killed?
Alexander Rukletsov wrote:
Adam, could you please explain what use case do you have in mind and how
it is related to slave recovery?
Adam B wrote:
It's not related to slave recovery
/31267/#review78070
---
On March 27, 2015, 4:26 p.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31267
, TestDRFAllocator AllocatorTypes;
```
Alexander Rukletsov wrote:
I don't know what is consistent here,
`src/tests/cram_md5_authentication_tests.cpp` use the indentation I use.
Also, clang-format gives something that is more similar to the way I propose.
Michael Park wrote:
Yeah I did see
, CentOS 7.0)
Thanks,
Alexander Rukletsov
9c01f5d6c692f835100e7cade928748cc4763cc8
src/module/manager.cpp 82a38f06e57d034650a6ac32fd73527b38cc97b8
Diff: https://reviews.apache.org/r/31266/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
://reviews.apache.org/r/31776/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
/module.cpp b81144f56e94034feecf3a6a4992af078cf60a81
Diff: https://reviews.apache.org/r/31267/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
/
Testing
---
make check (Mac OS 10.9.5, Ubuntu 14.04)
Thanks,
Alexander Rukletsov
882a9ff4d09aace486182828bf43b643b0d0c519
src/tests/slave_recovery_tests.cpp 87f4a6aab27d142fa8eb7a6571f684a6ce59687e
Diff: https://reviews.apache.org/r/31263/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
/master_allocator_tests.cpp 03a1bb8c92b44bc1ad1b5f5cff8d1fb971df2302
Diff: https://reviews.apache.org/r/31268/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31776/#review77477
---
On March 23, 2015, 2:02 p.m., Alexander Rukletsov wrote
://reviews.apache.org/r/31266/#review77528
---
On March 23, 2015, 2:03 p.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
b81144f56e94034feecf3a6a4992af078cf60a81
Diff: https://reviews.apache.org/r/31267/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31265/#review77570
---
On March 23, 2015, 2:11 p.m., Alexander Rukletsov wrote
e-mail. To reply, visit:
https://reviews.apache.org/r/31267/#review77531
---
On March 27, 2015, 3:08 p.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail
://reviews.apache.org/r/31776/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
7a06c7028eca8164b1f5fdea6a7ecd37ee6826bb
src/module/manager.cpp 82a38f06e57d034650a6ac32fd73527b38cc97b8
Diff: https://reviews.apache.org/r/31266/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
,
Alexander Rukletsov
(updated)
-
src/tests/mesos.hpp 0e98572a62ae05437bd2bc800c370ad1a0c43751
Diff: https://reviews.apache.org/r/31262/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
/module.cpp b81144f56e94034feecf3a6a4992af078cf60a81
Diff: https://reviews.apache.org/r/31267/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31268/#review77572
---
On March 23, 2015, 2:27 p.m., Alexander Rukletsov wrote
/master_allocator_tests.cpp 03a1bb8c92b44bc1ad1b5f5cff8d1fb971df2302
Diff: https://reviews.apache.org/r/31268/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
882a9ff4d09aace486182828bf43b643b0d0c519
src/tests/slave_recovery_tests.cpp 87f4a6aab27d142fa8eb7a6571f684a6ce59687e
Diff: https://reviews.apache.org/r/31263/diff/
Testing
---
make check (Mac OS 10.9.5, CentOS 7.0)
Thanks,
Alexander Rukletsov
1 - 100 of 484 matches
Mail list logo
