a framework with an /unsubscribe
endpoint?
Hm.. it seems like SHUTDOWN would have been the best names for this? Should
we re-use KILL for executors, but use SHUTDOWN for frameworks?
- Ben Mahler
On April 20, 2015, 8:04 p.m., Vinod Kone wrote
://reviews.apache.org/r/32502/#comment130938
Maybe we should test without this set?
- Ben Mahler
On April 20, 2015, 7:59 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32502
yours, but is this right? We're looking at SUBSCRIBED events
when the master is `None`?
- Ben Mahler
On April 20, 2015, 8:03 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31665/#review80528
---
Ship it!
- Ben Mahler
On April 17, 2015, 5:31 a.m., Michael Park
throughput based on that.
Also, why not use cout like we did elsewhere?
- Ben Mahler
On April 17, 2015, 5:28 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
On April 14, 2015, 1:46 a.m., Ben Mahler wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33154
()? can we have
metrics for them too while we are at it?
Ben Mahler wrote:
I can add one for when the a new slave registers and replaces the old
slave.
For exited(), I didn't add a metric since we are removing checkpointing.
It doesn't look like the flag is even available
On April 15, 2015, 7:20 p.m., Ben Mahler wrote:
src/master/master.hpp, lines 1138-1143
https://reviews.apache.org/r/31665/diff/5/?file=927382#file927382line1138
Thanks for this NOTE! We might want to take this opportunity to
articulate why we can safely keep the totals
since there's nothing to remove, so this is safe for
now.
- Ben Mahler
On April 15, 2015, 10:45 p.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31665
://reviews.apache.org/r/31666/#comment130059
Should there be a TODO here related to what needs to be done?
- Ben Mahler
On April 15, 2015, 3:54 p.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit
https://reviews.apache.org/r/31665/#comment130056
How about s/usedResources/totalUsedResources/ and
s/usedResourcesBySlaveId/usedResources/ ?
This might also make the total referred to in your note a bit clearer.
Ditto for offered.
- Ben Mahler
On April 14, 2015, 7:40 p.m., Michael
the vectors of pipes are used for, why they're needed. Etc.
In the process of being able to articulate what this does, we might figure
out how we can make it more easily understandable :)
- Ben Mahler
On April 14, 2015, 7:46 p.m., Joris Van Remoortere wrote
missing? Just seems like
unnecessary churn in the code to me.
Note that this change means the `Slave` and `Framework` structs now store
their ID's differently as well, which is unfortunate.
- Ben Mahler
On April 7, 2015, 4:59 p.m., Kapil Arya wrote
---
See summary.
Diffs
-
src/tests/fault_tolerance_tests.cpp a637c32f004638a110390b22cf5b626e904097cf
src/tests/partition_tests.cpp 1018e479a77a6b533f2dd392fedbdccb80e3ac1f
Diff: https://reviews.apache.org/r/33153/diff/
Testing
---
make check
Thanks,
Ben Mahler
32b1e9bb58d8046e5363fafe2ab8f662b6c9a666
src/tests/partition_tests.cpp 1018e479a77a6b533f2dd392fedbdccb80e3ac1f
src/tests/slave_tests.cpp b826000e0a4221690f956ea51f49ad4c99d5e188
Diff: https://reviews.apache.org/r/33155/diff/
Testing
---
make check
Thanks,
Ben Mahler
/master/master.cpp 44b0a0147f5354824d86332a67b30018634c9a36
src/master/metrics.hpp 52a83289cfe7e6b6fd8d5bff0774ebe5ce51d0ed
src/master/metrics.cpp 14486bf7130250f561c9fb7a43c95f3fc1e76a4b
Diff: https://reviews.apache.org/r/33154/diff/
Testing
---
make check
Thanks,
Ben Mahler
---
See summary.
Diffs
-
src/tests/fault_tolerance_tests.cpp a637c32f004638a110390b22cf5b626e904097cf
src/tests/slave_tests.cpp b826000e0a4221690f956ea51f49ad4c99d5e188
Diff: https://reviews.apache.org/r/33152/diff/
Testing
---
make check
Thanks,
Ben Mahler
:
https://reviews.apache.org/r/32463/#review77738
---
On March 24, 2015, 11:42 p.m., Ben Mahler wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/reporting-a-bug.md PRE-CREATION
Diff: https://reviews.apache.org/r/32995/diff/
Testing
---
N/A
Thanks,
Ben Mahler
://reviews.apache.org/r/32997/diff/
Testing
---
N/A
Thanks,
Ben Mahler
---
Epic tickets provide a good view of upcoming and ongoing projects.
Diffs
-
docs/home.md 6ab61f85aa7d62e0f19267b886dffb4e0aa826ea
docs/mesos-roadmap.md 150fad84d5ad264929775365fd1b941aefb89ec4
Diff: https://reviews.apache.org/r/32996/diff/
Testing
---
N/A
Thanks,
Ben
/
Testing
---
N/A
Thanks,
Ben Mahler
/A
Thanks,
Ben Mahler
On April 8, 2015, 1:13 a.m., Ben Mahler wrote:
3rdparty/libprocess/src/process.cpp, line 2048
https://reviews.apache.org/r/32939/diff/1/?file=920067#file920067line2048
While you're here, how about:
```
VLOG(2) Dropping event for process
, 2015, 9:48 p.m.)
Review request for mesos, Ben Mahler and Cody Maloney.
Repository: mesos
Description
---
Currently these log messages are fired whenever we have delayed messages to a
process that is exited (e.g., log appends). I've also seen this a bunch in
our tests
/metrics.cpp 14486bf7130250f561c9fb7a43c95f3fc1e76a4b
Diff: https://reviews.apache.org/r/32954/diff/
Testing
---
make check
Thanks,
Ben Mahler
On March 12, 2015, 9:20 p.m., Ben Mahler wrote:
docs/mesos-c++-style-guide.md, line 30
https://reviews.apache.org/r/32001/diff/1/?file=892420#file892420line30
Hm, isn't this captured by ending each sentence with a period above?
Alexander Rukletsov wrote:
Yes and no. Trailing
https://reviews.apache.org/r/32833/#comment128143
Why not use TryNothing?
- Ben Mahler
On April 3, 2015, 9:28 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32833
/linux/perf.cpp
https://reviews.apache.org/r/32820/#comment127885
char[]
Also noticed many of our other constants are not static, we may want to
do a sweep?
- Ben Mahler
On April 3, 2015, 5:01 p.m., Jie Yu wrote
needed for?
- Ben Mahler
On March 31, 2015, 2:16 a.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32558
the existing 'sleep'
commend, since we don't want to run a long-running 'perf' if we can't set the
death signal.
- Ben Mahler
On April 1, 2015, 7:40 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/#comment127484
ostringstream?
Have you considered just building a setstring and using
strings::join(\n, commands) below? Then you don't have to deal with the
delimiters in the stringstream and the fact that we're left with an extra
newline at the end as a result.
- Ben Mahler
On April 1
/#comment127528
Do you need the named 'argv' or can you return the initializer list
directly?
- Ben Mahler
On April 1, 2015, 7:40 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
::process(pid);
if (process.isSome()) {
infos.push_back(stringify(pid) + ' + process.get().command +
');
} else {
infos.push_back(stringify(pid));
}
}
```
- Ben Mahler
On April 1, 2015, 10:39 p.m
(
du,
argv,
Subprocess::PATH(/dev/null),
Subprocess::PIPE(),
Subprocess::PIPE(),
None(),
None(),
setup);
```
- Ben Mahler
On March 31, 2015, 7:32 p.m., Jie Yu wrote
/32502/#comment127032
newline here?
src/tests/scheduler_tests.cpp
https://reviews.apache.org/r/32502/#comment127030
newline here?
src/tests/scheduler_tests.cpp
https://reviews.apache.org/r/32502/#comment127029
Do you want to check the reason?
- Ben Mahler
On March 31, 2015, 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32504/#review78414
---
Ship it!
Ship It!
- Ben Mahler
On March 31, 2015, 12:08 a.m
endpoint
to try to make the connection management more obvious? People already have to
think about connection management regardless of having /scheduler/events as a
different path.
Are there any major reasons I'm missing for not consolidating on one endpoint?
- Ben Mahler
On March 31, 2015, 12
, 2015, 12:09 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Bugs: MESOS-1127 and MESOS-330
https://issues.apache.org/jira/browse/MESOS-1127
https://issues.apache.org/jira/browse/MESOS-330
Repository: mesos
Description
---
This is a new call
On Feb. 18, 2015, 7:38 p.m., Niklas Nielsen wrote:
Let's get tests wired up before committing this :)
Adam B wrote:
Sure thing. Adding tests in my subsequent patch where we will pass the
master's timeout values on to the slave. Will post that very soon.
Ben Mahler wrote:
Can
component.
- Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32346/#review77802
---
On March 20, 2015, 11:51 p.m., Ben Mahler wrote
---
On March 20, 2015, 11:51 p.m., Ben Mahler wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32347/
---
(Updated March 20, 2015, 11
?
- Ben Mahler
On March 27, 2015, 1:21 a.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32558/
---
(Updated
.
- Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32351/#review78111
---
On March 23, 2015, 11 p.m., Ben Mahler wrote
out,
because we figured comparisons would be used rather than explicit checks
against numbers.
- Ben Mahler
On March 27, 2015, 12:01 a.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit
tokens.
Diffs
-
src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1
Diff: https://reviews.apache.org/r/32555/diff/
Testing
---
make check
Thanks,
Ben Mahler
, 9:02 p.m.)
Review request for mesos, Ben Mahler and Ian Downes.
Bugs: MESOS-2548
https://issues.apache.org/jira/browse/MESOS-2548
Repository: mesos
Description
---
Fixed a regression caused by multiple cgroups base hierarchy detection.
Diffs
-
src
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32495/#review77797
---
Ship it!
Thanks!
- Ben Mahler
On March 25, 2015, 9:12 p.m., Jie
cleaning up the code, as you no longer need to keep an
iterator around for erasing.
src/slave/containerizer/isolators/cgroups/mem.cpp
https://reviews.apache.org/r/30546/#comment126127
Do you need to print this? Seems unnecessary?
- Ben Mahler
On March 25, 2015, 12:03 a.m., Chi Zhang wrote
that provides its value.
I think that will make this a little more intuitive, thoughts?
- Ben Mahler
On March 11, 2015, 10:30 p.m., Chi Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
it when the old driver goes
away? Or is there a reason to leave it indefinitely?
- Ben Mahler
On March 25, 2015, 11:07 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32501
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32506/#review77847
---
Ship it!
Ship It!
- Ben Mahler
On March 25, 2015, 11:13 p.m
/scheduler_tests.cpp
https://reviews.apache.org/r/32500/#comment126158
newline here?
src/tests/scheduler_tests.cpp
https://reviews.apache.org/r/32500/#comment126159
newline here?
- Ben Mahler
On March 25, 2015, 11:06 p.m., Vinod Kone wrote
/32420/#comment125832
If `prctl` fails, can you exit?
- Ben Mahler
On March 24, 2015, 7:06 p.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32420
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32419/#review77657
---
On March 24, 2015, 12:27 a.m., Ben Mahler wrote
e1a87d646e9690e39a9e84ae383622018ce80401
Diff: https://reviews.apache.org/r/32419/diff/
Testing
---
make check
No benchmarking performed given the analysis from Michael in
[r/31700](https://reviews.apache.org/r/31700/). I will also be trying this out
on our large production clusters.
Thanks,
Ben Mahler
that this compiles on 4.4.
src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/32466/#comment125877
You don't need the 'true' here.
- Ben Mahler
On March 25, 2015, 12:04 a.m., Jie Yu wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32467/#review77685
---
Ship it!
Ship It!
- Ben Mahler
On March 25, 2015, 12:04 a.m
-mail. To reply, visit:
https://reviews.apache.org/r/32419/#review77585
---
On March 24, 2015, 12:27 a.m., Ben Mahler wrote:
---
This is an automatically generated e-mail. To reply
collision and therefore
confusion.
Ben Mahler wrote:
Yikes, good eye alex, this looks like a bug. I'll leave it as it was, or
I'll update the names to be flags, slaves, etc instead of object,
array, etc.
I'll also add a test for the miscellaneous items always present in state.json
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32452/#review77627
---
Ship it!
Ship It!
- Ben Mahler
On March 24, 2015, 7:47 p.m
see a
filter for this currently:
https://github.com/apache/mesos/blob/master/src/tests/environment.cpp
Also keep in mind perf is only relevant for Linux.
- Ben Mahler
On March 23, 2015, 3:42 a.m., Isabel Jimenez wrote
---
Added a test.
Thanks,
Ben Mahler
this loop for a limited duration of time.
Just something to prevent this from leaking if the test fails, crashes, or
is killed before we get a change to SIGKILL the child.
- Ben Mahler
On March 24, 2015, 12:17 a.m., Ian Downes wrote
be trying this out
on our large production clusters.
Thanks,
Ben Mahler
On March 18, 2015, 11:49 p.m., Jie Yu wrote:
3rdparty/libprocess/src/process.cpp, lines 1149-1151
https://reviews.apache.org/r/31930/diff/2/?file=896916#file896916line1149
Does this comment still apply? Looks like we cannot write empty string.
Maybe a CHECK?
Ben Mahler wrote
/libprocess/src/tests/http_tests.cpp
800752a57230d7768d3d741fef87f6283757e424
Diff: https://reviews.apache.org/r/31930/diff/
Testing
---
* added tests
* make check
Thanks,
Ben Mahler
/libprocess/src/http.cpp 276cecd17364989093e6eed8e97ff3a02fb0d0ef
Diff: https://reviews.apache.org/r/32338/diff/
Testing
---
make check
Thanks,
Ben Mahler
/src/http.cpp 276cecd17364989093e6eed8e97ff3a02fb0d0ef
3rdparty/libprocess/src/tests/http_tests.cpp
17fb092a851e128c137152fdce57e9fb10a08bf7
Diff: https://reviews.apache.org/r/32351/diff/
Testing
---
Added a test.
Thanks,
Ben Mahler
---
http-parser is now hosted under joyent here:
https://github.com/joyent/http-parser
Diffs
-
3rdparty/libprocess/src/decoder.hpp 45f3d7fff2c33ce9c37a8ecbdcbf2c0f02ee76e8
Diff: https://reviews.apache.org/r/32342/diff/
Testing
---
make check
Thanks,
Ben Mahler
---
Used `CHECK_` family of assertions instead of `assert()`.
Diffs
-
3rdparty/libprocess/src/decoder.hpp 45f3d7fff2c33ce9c37a8ecbdcbf2c0f02ee76e8
Diff: https://reviews.apache.org/r/32345/diff/
Testing
---
make check
Thanks,
Ben Mahler
/libprocess/src/http.cpp 276cecd17364989093e6eed8e97ff3a02fb0d0ef
Diff: https://reviews.apache.org/r/32337/diff/
Testing
---
make check
Thanks,
Ben Mahler
276cecd17364989093e6eed8e97ff3a02fb0d0ef
Diff: https://reviews.apache.org/r/32348/diff/
Testing
---
make check
Thanks,
Ben Mahler
Thanks,
Ben Mahler
---
This mistake came when this test was copied from the request tests.
Diffs
-
3rdparty/libprocess/src/tests/decoder_tests.cpp
d65f5cf25eaecd5994404ccdf07f32d703a5955b
Diff: https://reviews.apache.org/r/32341/diff/
Testing
---
make check
Thanks,
Ben Mahler
---
If a test fails, the HttpProcess will be destructed but libprocess still has a
handle to it!
Diffs
-
3rdparty/libprocess/src/tests/http_tests.cpp
17fb092a851e128c137152fdce57e9fb10a08bf7
Diff: https://reviews.apache.org/r/32350/diff/
Testing
---
make check
Thanks,
Ben Mahler
/32347/diff/
Testing
---
Added a test.
Thanks,
Ben Mahler
/libprocess/src/http.cpp 276cecd17364989093e6eed8e97ff3a02fb0d0ef
Diff: https://reviews.apache.org/r/32340/diff/
Testing
---
make check
Thanks,
Ben Mahler
/http.hpp
2b366986b1f617e95bda94e07f2a0e532f5626f6
3rdparty/libprocess/src/http.cpp 276cecd17364989093e6eed8e97ff3a02fb0d0ef
Diff: https://reviews.apache.org/r/32349/diff/
Testing
---
make check
Thanks,
Ben Mahler
/libprocess/src/http.cpp 276cecd17364989093e6eed8e97ff3a02fb0d0ef
Diff: https://reviews.apache.org/r/32339/diff/
Testing
---
make check
Thanks,
Ben Mahler
/libprocess/src/tests/http_tests.cpp
17fb092a851e128c137152fdce57e9fb10a08bf7
Diff: https://reviews.apache.org/r/32346/diff/
Testing
---
Added a test.
Thanks,
Ben Mahler
/libprocess/src/http.cpp 276cecd17364989093e6eed8e97ff3a02fb0d0ef
Diff: https://reviews.apache.org/r/32336/diff/
Testing
---
make check
Thanks,
Ben Mahler
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32233/#review77259
---
Ship it!
Ship It!
- Ben Mahler
On March 20, 2015, 8:11 a.m
hoping we can clean up the current design of http::get and http::post,
where the function arguments have essentially grown to be subsets of things
inside the 'Request' object. This seems like a first step towards that, what
was your plan for http::get and http::post?
- Ben Mahler
On Nov. 20
, 2015, 11:49 p.m., Ben Mahler wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31930/
---
(Updated March 16, 2015, 11:49 p.m
e7b029ba97e640c2102548c190ba62b30602f43d
3rdparty/libprocess/src/tests/http_tests.cpp
800752a57230d7768d3d741fef87f6283757e424
Diff: https://reviews.apache.org/r/31930/diff/
Testing
---
* added tests
* make check
Thanks,
Ben Mahler
11, 2015, 7:41 a.m., Ben Mahler wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31930/
---
(Updated March 11, 2015, 7:41 a.m
/process.cpp e7b029ba97e640c2102548c190ba62b30602f43d
3rdparty/libprocess/src/tests/http_tests.cpp
800752a57230d7768d3d741fef87f6283757e424
Diff: https://reviews.apache.org/r/31930/diff/
Testing
---
* added tests
* make check
Thanks,
Ben Mahler
generated e-mail. To reply, visit:
https://reviews.apache.org/r/31930/#review76268
---
On March 11, 2015, 7:41 a.m., Ben Mahler wrote:
---
This is an automatically generated e-mail
On March 11, 2015, 7 p.m., Ben Mahler wrote:
I'm curious, what prompted this change?
Dominic Hamon wrote:
a comment on the original version in a review that it wasn't the best way
of counting bits. it seems like a generally useful thing to do.
Evelina Dumitrescu wrote
/#comment123806
Hm, isn't this captured by ending each sentence with a period above?
- Ben Mahler
On March 12, 2015, 8:59 p.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
(rather than NULL, -1,
etc).
* Use Future failure to capture asychronous failures.
* Do not block inside the execution context of a libprocess Process.
- Ben Mahler
On March 12, 2015, 3:59 p.m., Benjamin Hindman wrote
this fixes the issue, how you tested this, and
include screenshots if possible? Thank you!
- Ben Mahler
On March 12, 2015, 2:18 p.m., Joe Lee wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
if that works on gcc 4.4
(since that's still inside configure.ac).
src/common/http.cpp
https://reviews.apache.org/r/31700/#comment123796
Let's end all of these comments with a period. I'll take care of this
before committing.
- Ben Mahler
On March 11, 2015, 10:40 p.m., Alexander Rukletsov
this?
```
object.values[slaves] = std::move(array);
```
Don't do it in this change, we need to measure and I'm just curious :)
- Ben Mahler
On March 7, 2015, 1:43 a.m., Alexander Rukletsov wrote:
---
This is an automatically
/#comment123519
Want to collapse these lines to just `push_back(construct...(...));`
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp
https://reviews.apache.org/r/31873/#comment123520
Want to collapse these lines to just `push_back(construct...(...))`?
- Ben Mahler
On March 10, 2015
/mesos_scheduler_driver_impl.cpp
https://reviews.apache.org/r/31903/#comment123532
newline here?
- Ben Mahler
On March 10, 2015, 6:09 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/3rdparty/stout/include/stout/bits.hpp
https://reviews.apache.org/r/31677/#comment123510
Can we return a size_t to capture that this is a count and that negatives
are not possible?
Is `bits::count` not a sufficient name?
- Ben Mahler
On March 10, 2015, 7:59 p.m., Evelina Dumitrescu
7c0cee404645e1dd1a9253f85883aefa29a5f999
3rdparty/libprocess/src/process.cpp e7b029ba97e640c2102548c190ba62b30602f43d
3rdparty/libprocess/src/tests/http_tests.cpp
800752a57230d7768d3d741fef87f6283757e424
Diff: https://reviews.apache.org/r/31930/diff/
Testing
---
* added tests
* make check
Thanks,
Ben Mahler
/#comment122759
This looks inconsistent with all of the other + operator implementations in
this file, no?
- Ben Mahler
On March 6, 2015, 6:46 p.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit
1 - 100 of 2086 matches
Mail list logo
