----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32694/#review78457 -----------------------------------------------------------
Seems like a decent approach for now, just a few minor notes that are applicable to the other reviews as well. src/slave/containerizer/isolators/posix/disk.cpp <https://reviews.apache.org/r/32694/#comment127204> Can you just use an initializer list directly in the callsite here? src/slave/containerizer/isolators/posix/disk.cpp <https://reviews.apache.org/r/32694/#comment127208> Can't you just bind directly into `prctl`? E.g. ``` Option<lambda::function<int()>> setup = None(); #ifdef __linux__ setup = lambda::bind(::prctl(PR_SET_PDEATHSIG, SIGKILL)); #endif Try<Subprocess> s = subprocess( "du", argv, Subprocess::PATH("/dev/null"), Subprocess::PIPE(), Subprocess::PIPE(), None(), None(), setup); ``` - Ben Mahler On March 31, 2015, 7:32 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32694/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 7:32 p.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. > > > Bugs: MESOS-2462 > https://issues.apache.org/jira/browse/MESOS-2462 > > > Repository: mesos > > > Description > ------- > > Set death signal for forked du processes for posix/disk isolator. > > > Diffs > ----- > > src/slave/containerizer/isolators/posix/disk.cpp > 6e41e2a72cdcf914f2c922fdcb3d267b938e456e > > Diff: https://reviews.apache.org/r/32694/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
