prevent a
number of Alexs comments (and be consistent with the styleguide)...
- Joerg Schad
On April 14, 2015, 2:20 p.m., Till Toenshoff wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
On April 14, 2015, 6:17 p.m., Joerg Schad wrote:
src/authentication/cram_md5/authenticatee.cpp, line 33
https://reviews.apache.org/r/32850/diff/4/?file=927033#file927033line33
Actually according to Google's styleguide this should be the first
include, shouldn't it?
http
On March 27, 2015, 11:43 a.m., Joerg Schad wrote:
LGTM
Great effort!
On my machine (Apple LLVM version 6.0 (clang-600.0.56)) on the current
master this reduced 'make -j8' from
real5m8.217s, user 25m56.168s, sys 2m47.850s
to
real4m28.660s, user 23m0.723s, sys
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28763/#review78385
---
lgtm, test configure with and without (same as joris)
- Joerg
-600.0.56)) on the current master
this reduced 'make -j8' from
real5m8.217s, user 25m56.168s, sys 2m47.850s
to
real4m28.660s, user 23m0.723s, sys 2m36.788s
- Joerg Schad
On March 27, 2015, 1:21 a.m., Cody Maloney wrote
On March 27, 2015, 11:43 a.m., Joerg Schad wrote:
LGTM
Great effort!
On my machine (Apple LLVM version 6.0 (clang-600.0.56)) on the current
master this reduced 'make -j8' from
real5m8.217s, user 25m56.168s, sys 2m47.850s
to
real4m28.660s, user 23m0.723s, sys
check
Thanks,
Joerg Schad
/#review78025
---
On March 27, 2015, 2:09 p.m., Joerg Schad wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32543
aedb6ab30d929b81f55270612e76009bd7850daa
Diff: https://reviews.apache.org/r/32105/diff/
Testing
---
make check
Thanks,
Joerg Schad
On March 27, 2015, 5:20 p.m., Joerg Schad wrote:
lgtm
P.S. checked with Markdown Preview
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32579/#review78076
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32579/#review78076
---
lgtm
- Joerg Schad
On March 27, 2015, 4:54 p.m., Michael Park
. To reply, visit:
https://reviews.apache.org/r/32105/#review77859
---
On March 25, 2015, 11:20 p.m., Joerg Schad wrote:
---
This is an automatically generated e-mail. To reply, visit
://reviews.apache.org/r/32105/diff/
Testing
---
make check
Thanks,
Joerg Schad
://reviews.apache.org/r/32543/diff/
Testing
---
markdown check
Thanks,
Joerg Schad
2a15694607c079ad95ef6cf7f1490872ab9a5976
Diff: https://reviews.apache.org/r/32543/diff/
Testing
---
markdown check
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/#review77739
---
On March 25, 2015, 11:20 p.m., Joerg Schad wrote
aedb6ab30d929b81f55270612e76009bd7850daa
Diff: https://reviews.apache.org/r/32105/diff/
Testing
---
make check
Thanks,
Joerg Schad
src/slave/slave.cpp 31ca72463abb4ef6629983391527745bbb8df2df
Diff: https://reviews.apache.org/r/30931/diff/
Testing
---
make check
Thanks,
Joerg Schad
---
On March 17, 2015, 12:25 a.m., Joerg Schad wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/
---
(Updated March 17, 2015, 12
-mail. To reply, visit:
https://reviews.apache.org/r/31539/#review77608
---
On March 19, 2015, 3:52 p.m., Joerg Schad wrote:
---
This is an automatically generated e-mail. To reply
/Dealloc mismatch in OsSendfileTest.sendfile.
Diffs
-
3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp
2af4dca1559e9edd1e0a4acee9844adacc724a49
Diff: https://reviews.apache.org/r/32403/diff/
Testing
---
Thanks,
Joerg Schad
)
---
make check
Thanks,
Joerg Schad
2af4dca1559e9edd1e0a4acee9844adacc724a49
Diff: https://reviews.apache.org/r/32403/diff/
Testing
---
make check
Thanks,
Joerg Schad
On March 19, 2015, 4:33 p.m., Adam B wrote:
src/tests/fault_tolerance_tests.cpp, line 123
https://reviews.apache.org/r/31539/diff/7-8/?file=899402#file899402line123
No need to call it a checkpointing slave, since all slaves are
checkpointing now.
Joerg Schad wrote:
Till
under OSX)
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31539/#review77022
---
On March 18, 2015, 9:43 p.m., Joerg Schad wrote
---
On March 19, 2015, 3:52 p.m., Joerg Schad wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31539
using the 'slaveFlags'
variable, it can be removed, since StartSlave() is the same as
StartSlave(CreateSlaveFlags()).
Joerg Schad wrote:
CreateSlaveFlags also generates a new work_dir assignment, as I restart
the slave I woud like to keep the same work_dir.
Adam B wrote:
Sure
=1 GTEST_REPEAT=50 on OSX (had
to exclude some known flaky tests under OSX)
Thanks,
Joerg Schad
, 2015, 5:08 p.m.)
Review request for mesos, Benjamin Hindman, Bernd Mathiske, Joerg Schad,
Niklas Nielsen, and Till Toenshoff.
Bugs: MESOS-2510
https://issues.apache.org/jira/browse/MESOS-2510
Repository: mesos
Description
---
Adds a function which allows
On March 17, 2015, 6:24 p.m., Joerg Schad wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp, line 349
https://reviews.apache.org/r/32163/diff/2/?file=897835#file897835line349
Could you mention this as well in the description?
As it is another operator. Don't have
: https://reviews.apache.org/r/32105/diff/
Testing
---
make check
Thanks,
Joerg Schad
/zookeeper_tests.cpp 7d1c0665f06e067637861424aa647d6e4d3f9c85
Diff: https://reviews.apache.org/r/32098/diff/
Testing
---
make check
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31539/#review76502
---
On March 16, 2015, 10:07 a.m., Joerg Schad wrote
08cab86d148edf0cae3aaebfda30c21a75bca2b2
src/tests/zookeeper_tests.cpp 7d1c0665f06e067637861424aa647d6e4d3f9c85
Diff: https://reviews.apache.org/r/32098/diff/
Testing
---
make check
Thanks,
Joerg Schad
dccd7c635da4b7031cd109bd84e7f17b31777ef1
src/slave/slave.cpp 0f99e4efb8fa2b96f120a3e49191158ca0364c06
Diff: https://reviews.apache.org/r/30931/diff/
Testing
---
make check
Thanks,
Joerg Schad
://reviews.apache.org/r/32105/diff/
Testing
---
make check
Thanks,
Joerg Schad
://reviews.apache.org/r/32105/diff/
Testing (updated)
---
make check
Thanks,
Joerg Schad
Diffs
-
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp
aedb6ab30d929b81f55270612e76009bd7850daa
Diff: https://reviews.apache.org/r/32105/diff/
Testing
---
Thanks,
Joerg Schad
---
Thanks,
Joerg Schad
://reviews.apache.org/r/32105/diff/
Testing
---
make check
Thanks,
Joerg Schad
08cab86d148edf0cae3aaebfda30c21a75bca2b2
src/tests/zookeeper_tests.cpp 7d1c0665f06e067637861424aa647d6e4d3f9c85
Diff: https://reviews.apache.org/r/32098/diff/
Testing
---
make check
Thanks,
Joerg Schad
under OSX)
Thanks,
Joerg Schad
are now
considering more fields in the comparison)?
- Joerg Schad
On March 10, 2015, 6:27 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31905
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31183/#review75868
---
lgtm!
- Joerg Schad
On March 7, 2015, 10:08 a.m., Michael Park
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31664/#review75869
---
lgtm, maybe a small test would be good.
- Joerg Schad
On March 7
.
http://mesos.apache.org/documentation/latest/configuration/)?
src/tests/fetcher_cache_tests.cpp
https://reviews.apache.org/r/30774/#comment122924
Can't we simulate SERIALIZED_TASK externally (as discussed)? In this we
would not have several modes...
- Joerg Schad
On March 7, 2015, 3
/#comment123080
From my understanding this will cause errors as environment does not have a
default value and hence we should check before whether it is present (see
https://code.google.com/p/protobuf-c/wiki/Default_Values).
- Joerg Schad
On March 6, 2015, 6:04 p.m., Chi Zhang wrote
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31784/
---
(Updated March 6, 2015, 6:04 p.m.)
Review request for mesos, Alexander Rukletsov, Joerg Schad, Till Toenshoff,
Vinod Kone, and Zameer Manji
On March 9, 2015, 9:51 p.m., Joerg Schad wrote:
src/common/type_utils.cpp, line 59
https://reviews.apache.org/r/31784/diff/2/?file=887439#file887439line59
From my understanding this will cause errors as environment does not
have a default value and hence we should check before
this problematic behavior?
- Joerg Schad
On March 9, 2015, 12:54 a.m., Till Toenshoff wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31838
53adae0118a26e6d25a9ff20c6374cc8e73275b1
src/tests/status_update_manager_tests.cpp
216a22e9f292b4141c8b966dad0f25dbd791c025
Diff: https://reviews.apache.org/r/31539/diff/
Testing
---
make check
Thanks,
Joerg Schad
/tests/status_update_manager_tests.cpp
216a22e9f292b4141c8b966dad0f25dbd791c025
Diff: https://reviews.apache.org/r/31539/diff/
Testing (updated)
---
make check GTEST_BREAK_ON_FAILURE=1 GTEST_SHUFFLE=1 GTEST_REPEAT=50 on OSX (had
to exclude some known flaky tests under OSX)
Thanks,
Joerg
53adae0118a26e6d25a9ff20c6374cc8e73275b1
src/tests/status_update_manager_tests.cpp
216a22e9f292b4141c8b966dad0f25dbd791c025
Diff: https://reviews.apache.org/r/31539/diff/
Testing
---
make check
Thanks,
Joerg Schad
53adae0118a26e6d25a9ff20c6374cc8e73275b1
src/tests/status_update_manager_tests.cpp
216a22e9f292b4141c8b966dad0f25dbd791c025
Diff: https://reviews.apache.org/r/31539/diff/
Testing
---
make check
Thanks,
Joerg Schad
here?
- Joerg Schad
On March 3, 2015, 8:26 p.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31183
216a22e9f292b4141c8b966dad0f25dbd791c025
Diff: https://reviews.apache.org/r/31539/diff/
Testing
---
make check
Thanks,
Joerg Schad
/#comment122562
Shouldn't this also be added to the documentation (i.e.
http://mesos.apache.org/documentation/latest/configuration/)?
- Joerg Schad
On Feb. 19, 2015, 8:10 a.m., Adam B wrote:
---
This is an automatically generated e-mail
.
What's the plan?
Joerg Schad wrote:
Comparing the serialization of two messages will not work as optional
default values are serialized (see
https://code.google.com/p/protobuf-c/wiki/Default_Values) only if the
has_flag is set.
I will have a look at the reflection API
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31263/#review75403
---
Ship it!
Ship It!
- Joerg Schad
On March 5, 2015, 9:11 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31262/#review75412
---
Ship it!
Ship It!
- Joerg Schad
On March 5, 2015, 9:05 p.m
/#comment121815
Could we make the parameter name more specific? Such as _disabledEndpoints
or someting similar?
- Joerg Schad
On March 3, 2015, 11:06 a.m., Alexander Rojas wrote:
---
This is an automatically generated e-mail. To reply
On Feb. 27, 2015, 2:13 p.m., Joerg Schad wrote:
Lgtm
I found one other occurence of ;; in
3rdparty/libprocess/include/process/gmock.hpp but I guess this should be
seperate patch anyhow.
Joerg Schad wrote:
https://reviews.apache.org/r/31543/
Alexander Rukletsov wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31415/#review74505
---
Ship it!
- Joerg Schad
On Feb. 25, 2015, 5:07 p.m., Alexander
/libprocess/include/process/gmock.hpp but I guess this should be
seperate patch anyhow.
- Joerg Schad
On Feb. 25, 2015, 5:08 p.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
Thanks,
Joerg Schad
On Feb. 27, 2015, 2:13 p.m., Joerg Schad wrote:
Lgtm
I found one other occurence of ;; in
3rdparty/libprocess/include/process/gmock.hpp but I guess this should be
seperate patch anyhow.
https://reviews.apache.org/r/31543/
- Joerg
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31489/
---
(Updated Feb. 26, 2015, 6:14 p.m.)
Review request for mesos, Joerg Schad and Till Toenshoff.
Bugs: MESOS-2412
https
://reviews.apache.org/r/31494/diff/
Testing
---
make check
Thanks,
Joerg Schad
://reviews.apache.org/r/31227/#comment120190
Header comment for Testcase.
3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp
https://reviews.apache.org/r/31227/#comment120182
same
- Joerg Schad
On Feb. 23, 2015, 4:56 p.m., Alexander Rojas wrote
Thanks,
Joerg Schad
Rukletsov and Till Toenshoff.
Repository: mesos
Description
---
see summary.
Diffs
-
docs/slave-recovery.md 57eb786f94b2b1dee7bb35017618af90b4dc4a31
Diff: https://reviews.apache.org/r/31358/diff/
Testing
---
checked with Markdown Preview.
Thanks,
Joerg Schad
---
checked with Markdown Preview.
Thanks,
Joerg Schad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31325/#review73860
---
Ship it!
Ship It!
- Joerg Schad
On Feb. 24, 2015, 6:55 p.m
bc0e748fed081af85a882f98ec2957e552b77152
Diff: https://reviews.apache.org/r/31300/diff/
Testing
---
Thanks,
Joerg Schad
://reviews.apache.org/r/31300/diff/
Testing
---
Thanks,
Joerg Schad
bc0e748fed081af85a882f98ec2957e552b77152
Diff: https://reviews.apache.org/r/31300/diff/
Testing
---
Thanks,
Joerg Schad
/31300/diff/
Testing
---
Thanks,
Joerg Schad
---
On Feb. 13, 2015, 4:10 p.m., Joerg Schad wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30931/
---
(Updated Feb. 13, 2015, 4:10 p.m
Thanks,
Joerg Schad
Thanks,
Joerg Schad
://reviews.apache.org/r/31300/diff/
Testing
---
Thanks,
Joerg Schad
://reviews.apache.org/r/31227/#comment119932
The placement of is inconsitent to other lines in this file (string str
vs string str). The Google Style Guide seems to prefere your solution but what
is our take on this?
Would it make sense to add some tests?
- Joerg Schad
On Feb. 20, 2015
Thanks,
Joerg Schad
/type_utils.cpp 12a36bbd7d7773b25dedf2d0d951c79e0b5141d6
Diff: https://reviews.apache.org/r/31011/diff/
Testing
---
make check
Thanks,
Joerg Schad
, visit:
https://reviews.apache.org/r/31011/#review72753
---
On Feb. 17, 2015, 12:58 p.m., Joerg Schad wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
,hostname:172.18.6.137,id:,killed_tasks:0,log_dir:\/tmp\/mesos2\/,lost_tasks:0,pid:slave(1)@172.18.6.137:5052,resources:{cpus:8,disk:470848,mem:15360,ports:[31000-32000],res1:10,res2:20},staged_tasks:0,start_time:1424093902.65546,started_tasks:0,version:0.22.0}
Thanks,
Joerg Schad
12a36bbd7d7773b25dedf2d0d951c79e0b5141d6
Diff: https://reviews.apache.org/r/31011/diff/
Testing
---
make check
Thanks,
Joerg Schad
---
Included all resources in state endpoint.
Diffs
-
src/common/http.cpp 576e2e436d4211f3b76c6a0bf124de6689d5f95b
Diff: https://reviews.apache.org/r/31082/diff/
Testing
---
make check
Thanks,
Joerg Schad
12a36bbd7d7773b25dedf2d0d951c79e0b5141d6
src/master/master.cpp f10a3cffdb0b9831b2b8af0dfd30f73d1d8ed937
src/slave/slave.cpp 1e60454cecfe387c4906a74f176bef00c2e0dbb7
Diff: https://reviews.apache.org/r/30931/diff/
Testing
---
make check
Thanks,
Joerg Schad
32dc6ed489f43ba3695507f59c4c2d94028c8df1
src/common/type_utils.cpp 12a36bbd7d7773b25dedf2d0d951c79e0b5141d6
src/master/master.cpp f10a3cffdb0b9831b2b8af0dfd30f73d1d8ed937
src/slave/slave.cpp 1e60454cecfe387c4906a74f176bef00c2e0dbb7
Diff: https://reviews.apache.org/r/30931/diff/
Testing
---
make check
Thanks,
Joerg
,
Joerg Schad
src/slave/slave.cpp f39a876cdd6b580a7a75fd053e6923761bee7635
Diff: https://reviews.apache.org/r/30827/diff/
Testing
---
make check
Thanks,
Joerg Schad
/
Testing
---
make check
Thanks,
Joerg Schad
94 matches
Mail list logo
