Re: Review Request 32653: Replace busy look on ready file with a more relaxed loop

2015-04-01 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32653/ --- (Updated April 1, 2015, 3:43 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 32653: Replace busy look on ready file with a more relaxed loop

2015-04-01 Thread Paul Brett
On March 31, 2015, 10:42 p.m., Chi Zhang wrote: src/tests/port_mapping_tests.cpp, line 396 https://reviews.apache.org/r/32653/diff/2/?file=910398#file910398line396 how about at least have this function return a future and change call sites to use AWAIT_READY? When

Re: Review Request 32653: Replace busy look on ready file with a more relaxed loop

2015-04-01 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32653/ --- (Updated April 1, 2015, 8:54 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 32653: Replace busy look on ready file with a more relaxed loop

2015-04-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32653/#review78605 --- src/tests/port_mapping_tests.cpp

Re: Review Request 32653: Replace busy look on ready file with a more relaxed loop

2015-04-01 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32653/ --- (Updated April 1, 2015, 11 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 32653: Replace busy look on ready file with a more relaxed loop

2015-04-01 Thread Paul Brett
On April 1, 2015, 10:22 p.m., Jie Yu wrote: src/tests/port_mapping_tests.cpp, line 403 https://reviews.apache.org/r/32653/diff/3/?file=911841#file911841line403 60seconds might be too long. Probably change it to 15 seconds so that it's consistent with AWAIT_READY default. 60

Re: Review Request 32653: Replace busy look on ready file with a more relaxed loop

2015-03-31 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32653/#review78421 --- src/tests/port_mapping_tests.cpp

Re: Review Request 32653: Replace busy look on ready file with a more relaxed loop

2015-03-31 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32653/ --- (Updated April 1, 2015, 12:40 a.m.) Review request for mesos, Chi Zhang, Ian

Review Request 32653: Replace busy look on ready file with a more relaxed loop

2015-03-30 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32653/ --- Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. Bugs:

Re: Review Request 32653: Replace busy look on ready file with a more relaxed loop

2015-03-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32653/#review78287 --- Patch looks great! Reviews applied: [32653] All tests passed. -

Re: Review Request 32653: Replace busy look on ready file with a more relaxed loop

2015-03-30 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32653/ --- (Updated March 31, 2015, 3:33 a.m.) Review request for mesos, Chi Zhang, Ian