On Feb. 4, 2015, 1:36 a.m., switched to 'mcypark' wrote:
src/tests/master_tests.cpp, line 2880
https://reviews.apache.org/r/29727/diff/3/?file=846895#file846895line2880
style nit: should be indented 4 spaces here
Sorry for the mess regarding switched to 'mcypark' above, I messed up
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30579/
---
Review request for mesos, Alexander Rukletsov and Niklas Nielsen.
Summary
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27760/#review70863
---
src/authentication/cram_md5/authenticator.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30580/
---
Review request for mesos, Alexander Rukletsov, Niklas Nielsen, and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30596/
---
Review request for mesos, Alexander Rukletsov, Niklas Nielsen, and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30583/
---
Review request for mesos, Alexander Rukletsov, Niklas Nielsen, and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30597/
---
Review request for mesos, Alexander Rukletsov, Niklas Nielsen, and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30595/
---
Review request for mesos, Alexander Rukletsov, Niklas Nielsen, and Vinod Kone.
Also note that any unused resources from an offer passed to LaunchTasks
will be automatically declined (and potentially reoffered with a new
offerId).
Thus, you cannot do LaunchTasks(task1, offer1); LaunchTasks(task2,
offer1); since the remainder of offer1 will have been declined and any
future
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/#review70901
---
Ship it!
Ship It!
- Adam B
On Feb. 3, 2015, 5:30 p.m., Christos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/#review70908
---
Patch looks great!
Reviews applied: [30513]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30579/#review70917
---
Ship it!
src/launcher/executor.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/#review70920
---
Bad patch!
Reviews applied: [29727]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30601/#review70922
---
Patch looks great!
Reviews applied: [30579, 30580, 30583, 30595,
On Tue, Feb 03, 2015 at 05:52:48PM -0800, Adam Bordelon wrote:
Also note that any unused resources from an offer passed to LaunchTasks will
be
automatically declined (and potentially reoffered with a new offerId).
Thus, you cannot do LaunchTasks(task1, offer1); LaunchTasks(task2, offer1);
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30584/#review70919
---
Patch looks great!
Reviews applied: [30511, 30514, 30584]
All
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30606/
---
Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30584/
---
(Updated Feb. 4, 2015, 1:57 a.m.)
Review request for mesos, Ben Mahler and Jie
On Tue, Feb 03, 2015 at 05:21:55PM -0800, Vinod Kone wrote:
On Tue, Feb 3, 2015 at 5:46 AM, Chengwei Yang chengwei.yang...@gmail.com
wrote:
As we can see, mesos-master send offer to chronos at 18:32:33, but
received
all
4 decline message (LaunchTasksMessage) at 18:33.03, we
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30606/#review70931
---
Patch looks great!
Reviews applied: [30606]
All tests passed.
-
master.cpp:2939] Sending 3 offers to framework
20150203-174243-2487817994-5050-10996-
I0203 18:32:39.523227 7670 http.cpp:452] HTTP request for '/master/state.json'
I0203 18:32:49.601284 7674 http.cpp:452] HTTP request for '/master/state.json'
I0203 18:32:59.677875 7677 http.cpp:452] HTTP request
.
---8---
I0203 18:32:33.169342 7680 master.cpp:2939] Sending 3 offers to framework
20150203-174243-2487817994-5050-10996-
I0203 18:32:39.523227 7670 http.cpp:452] HTTP request for
'/master/state.json'
I0203 18:32:49.601284 7674 http.cpp:452] HTTP request
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27760/#review70733
---
Patch looks great!
Reviews applied: [27760]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30546/#review70779
---
Another high level review because I think there are important
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30514/#review70768
---
src/master/flags.hpp
On Jan. 30, 2015, 10:32 p.m., Dominic Hamon wrote:
src/master/master.hpp, line 518
https://reviews.apache.org/r/30459/diff/2/?file=842079#file842079line518
const Offer* ?
I'll add a TODO. Right now, I need to change a bunch of funcitons to make it
const.
- Jie
On Feb. 3, 2015, 6:09 p.m., David Robinson wrote:
src/master/flags.hpp, line 152
https://reviews.apache.org/r/30514/diff/2/?file=844914#file844914line152
Should this be slaves pre minute? I imagine most clusters in the wild
would be relatively small, and the smaller the cluster
On Feb. 3, 2015, 6:25 p.m., Jie Yu wrote:
src/tests/slave_tests.cpp, line 1232
https://reviews.apache.org/r/30514/diff/2/?file=844918#file844918line1232
Kill process:: prefix by using namespace process?
done
- Vinod
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30514/
---
(Updated Feb. 3, 2015, 6:42 p.m.)
Review request for mesos, Ben Mahler, David
On Feb. 3, 2015, 6:16 p.m., Jie Yu wrote:
src/master/flags.hpp, line 152
https://reviews.apache.org/r/30514/diff/2/?file=844914#file844914line152
Good point. I am wondering should we introduce a Rate abstraction in
stout:
```
Rate rate1(3, Minites(3));
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30545/#review70786
---
This is high level review about the interface and architecture
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30545/#review70772
---
src/linux/cgroups.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30514/#review70776
---
Ship it!
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30546/#review70774
---
include/mesos/mesos.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30514/#review70775
---
src/master/flags.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30511/
---
(Updated Feb. 3, 2015, 6:28 p.m.)
Review request for mesos, Ben Mahler and
On Feb. 2, 2015, 6:10 p.m., Ben Mahler wrote:
I recall Yan and I discussed improving the BoundedRateLimiter abstraction
to provide a interface that returns failed futures when the bound is
reached, but I don't think we documented it or the implications of such a
change.
Mind
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30514/#review70804
---
Patch looks great!
Reviews applied: [30511, 30514]
All tests
On Oct. 29, 2014, 3:57 p.m., Michael Park wrote:
We can't make these `const-ref` unfortunately because the second argument
of `va_start` cannot be a reference type.
N3797: 18.10 Other runtime support [support.runtime]
The restrictions that ISO C places on the second parameter to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25551/#review70843
---
Ping - tstclair: did you resolve the last of Vinod's issue
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29329/#review70849
---
Is there a shortcoming in the executor API that prevents this from
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30584/
---
Review request for mesos, Ben Mahler and Jie Yu.
Bugs: MESOS-1148
On Feb. 3, 2015, 8:19 p.m., Vinod Kone wrote:
include/mesos/resources.hpp, line 92
https://reviews.apache.org/r/29742/diff/4/?file=839661#file839661line92
We didn't do isempty above, so how about getting rid of is as
prefix? I think returning a bool signals a is.
Hm, that's a
On Feb. 2, 2015, 6:43 p.m., Dominic Hamon wrote:
src/master/validation.cpp, line 126
https://reviews.apache.org/r/30513/diff/1/?file=843897#file843897line126
s/resource/volumes/ .. the current code reads as if you're checking
that all resources are persistent volumes, which
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/
---
(Updated Feb. 3, 2015, 11:15 p.m.)
Review request for mesos, Ben Mahler,
On Feb. 3, 2015, 11:23 p.m., Bill Farner wrote:
Is there a shortcoming in the executor API that prevents this from being an
independent binary?
Hi Bill, this is going to be a binary on itself just like command exexutor. Do
you have something else in mind?
- Timothy
On Jan. 23, 2015, 10:42 p.m., Timothy St. Clair wrote:
configure.ac, line 260
https://reviews.apache.org/r/29595/diff/3/?file=819045#file819045line260
Do you have system details?
Could you provide ldd and version of the system in question.
Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30584/#review70842
---
Bad patch!
Reviews applied: [30511]
Failed command:
On Feb. 3, 2015, 8:15 p.m., Vinod Kone wrote:
src/master/validation.cpp, line 132
https://reviews.apache.org/r/30513/diff/1/?file=843897#file843897line132
ditto.
It's clear that resource.name() is 'disk' in this case.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/
---
(Updated Feb. 3, 2015, 11:19 p.m.)
Review request for mesos, Ben Mahler,
On Feb. 3, 2015, 8:15 p.m., Vinod Kone wrote:
Test?
Added/refactored tests.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/#review70815
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30584/#review70855
---
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/#review70815
---
Test?
src/master/validation.cpp
On Feb. 2, 2015, 6:43 p.m., Dominic Hamon wrote:
src/master/validation.cpp, line 544
https://reviews.apache.org/r/30513/diff/1/?file=843897#file843897line544
if this is all you need, can you pass in the persisted resources
instead of a slave? might make future testing easier.
+1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29742/#review70817
---
Ship it!
include/mesos/resources.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27760/#review70822
---
src/authentication/authenticator.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27760/
---
(Updated Feb. 3, 2015, 11:05 a.m.)
Review request for mesos, Adam B, Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30195/
---
(Updated Feb. 4, 2015, midnight)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30589/
---
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1806
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30591/
---
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1806
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30592/
---
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1806
On Jan. 22, 2015, 10:20 p.m., Mesos ReviewBot wrote:
Patch looks great!
Reviews applied: [30015, 30014]
All tests passed.
I was wondering if this review request was discarded? If yes, what would be a
good alternate solution to the problem at hand?
- Ritwik
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30584/
---
(Updated Feb. 4, 2015, 12:24 a.m.)
Review request for mesos, Ben Mahler and
On Feb. 3, 2015, 11:37 p.m., Jie Yu wrote:
src/master/master.cpp, line 3908
https://reviews.apache.org/r/30584/diff/1/?file=846680#file846680line3908
This doesn't seem to necessary since we have master/slave_removals
already (which will be incremented in removeSlave(slave)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30511/
---
(Updated Feb. 4, 2015, 12:30 a.m.)
Review request for mesos, Ben Mahler and
On Feb. 3, 2015, 11:37 p.m., Jie Yu wrote:
src/master/master.cpp, line 3908
https://reviews.apache.org/r/30584/diff/1/?file=846680#file846680line3908
This doesn't seem to necessary since we have master/slave_removals
already (which will be incremented in removeSlave(slave)
/master/master.cpp to print some log whenever received a
LaunchTasksMessage, see below log.
---8---
I0203 18:32:33.169342 7680 master.cpp:2939] Sending 3 offers to framework
20150203-174243-2487817994-5050-10996-
I0203 18:32:39.523227 7670
On Jan. 29, 2015, 6:49 p.m., Ben Mahler wrote:
src/master/master.cpp, lines 1342-1353
https://reviews.apache.org/r/30386/diff/1/?file=839423#file839423line1342
Nice :)
Do you need to pass the slave here? Can you remove it for now?
Killed.
- Jie
On Jan. 17, 2015, 1:39 a.m., Ben Mahler wrote:
How are we going to manage the duplication across the command executor and
the docker executor?
Timothy Chen wrote:
I think I'm going to leave them seperate as they most likely will grow
independent in tangent.
The docker
On Jan. 20, 2015, 11:05 a.m., Niklas Nielsen wrote:
Is this good to go? If so - let's get it in :) I can commit if you don't
have time
Committed.
- Adam
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/#review70867
---
Patch looks great!
Reviews applied: [30513]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30587/
---
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1806
On Jan. 29, 2015, 3:40 p.m., Alexander Rukletsov wrote:
src/etcd/url.hpp, line 23
https://reviews.apache.org/r/30394/diff/1/?file=839637#file839637line23
`#include iostream`
or, what I would prefer
`#include iosfwd`
and move `operator` definitions into `url.cpp`
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30588/
---
Review request for mesos.
Bugs: MESOS-1806
On Jan. 29, 2015, 4:08 p.m., Alexander Rukletsov wrote:
src/etcd/etcd.cpp, line 43
https://reviews.apache.org/r/30394/diff/1/?file=839636#file839636line43
What is `::URL`?
It was stout/url which lives in the global namespace and conflicts in
resolution with etcd::URL which is why
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30590/
---
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1806
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30584/
---
(Updated Feb. 4, 2015, 12:31 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30514/
---
(Updated Feb. 4, 2015, 12:31 a.m.)
Review request for mesos, Ben Mahler, David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30592/#review70876
---
Bad patch!
Reviews applied: [30194, 30195]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/
---
(Updated Feb. 3, 2015, 4:39 p.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/#review70878
---
src/tests/master_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30386/
---
(Updated Feb. 4, 2015, 1:09 a.m.)
Review request for mesos, Ben Mahler,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30545/#review70719
---
src/linux/cgroups.hpp
On Feb. 3, 2015, 9:06 a.m., Nikita Vetoshkin wrote:
src/linux/cgroups.cpp, line 2345
https://reviews.apache.org/r/30545/diff/1/?file=845002#file845002line2345
Wouldn't `new` throw instead of returning null?
I believe it will throw bad_alloc, the check is unnecessary.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30513/
---
(Updated Feb. 4, 2015, 1:10 a.m.)
Review request for mesos, Ben Mahler,
On Tue, Feb 3, 2015 at 5:46 AM, Chengwei Yang chengwei.yang...@gmail.com
wrote:
As we can see, mesos-master send offer to chronos at 18:32:33, but
received all
4 decline message (LaunchTasksMessage) at 18:33.03, we are very curious
why the
first decline doesn't sent before sleep 30 seconds?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/
---
(Updated Feb. 3, 2015, 5:30 p.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30531/#review70885
---
Can we seperate the tests changes in this patch? It is a good
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30584/#review70888
---
Patch looks great!
Reviews applied: [30511, 30514, 30584]
All
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29727/#review70890
---
src/tests/master_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30514/
---
(Updated Feb. 4, 2015, 1:51 a.m.)
Review request for mesos, Ben Mahler, David
91 matches
Mail list logo
