---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30827/
---
(Updated Feb. 10, 2015, 3:04 p.m.)
Review request for mesos, Adam B, Ben
+1
Thanks for the write up Ben!
On Tuesday, February 10, 2015, Dominic Hamon dha...@twitter.com.invalid
wrote:
Well, we should probably do that anyway :)
On Feb 10, 2015 2:25 AM, Adam Bordelon a...@mesosphere.io
javascript:; wrote:
+1 on MAINTAINERS over OWNERS, and the rest of the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29883/#review71796
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 10, 2015, 11:33 a.m.,
Well, we should probably do that anyway :)
On Feb 10, 2015 2:25 AM, Adam Bordelon a...@mesosphere.io wrote:
+1 on MAINTAINERS over OWNERS, and the rest of the proposal thus far.
Also +1 on Merit is not about quantity of work, it means doing things the
community values in a way that the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30827/#review71791
---
Ship it!
Ship It!
- Till Toenshoff
On Feb. 10, 2015, 3:04 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29883/#review71794
---
Patch looks great!
Reviews applied: [29883]
All tests passed.
-
On Feb. 5, 2015, 7:13 p.m., Vinod Kone wrote:
src/Makefile.am, lines 466-469
https://reviews.apache.org/r/29925/diff/6/?file=848172#file848172line466
How about this structure for consistency:
master/allocator/allocator.hpp
master/allocator/mesos/hierarchical.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30861/
---
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30736/#review71897
---
So after looking at this review, I'm not sure we really need to add
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30792/#review71923
---
Ship it!
I think this is a great use of auto!
- Benjamin Hindman
On Feb. 11, 2015, 1:23 a.m., Timothy Chen wrote:
So after looking at this review, I'm not sure we really need to add
anything to Mesos, as getting graphic compute units and memory could be a
seperate process/script that just injects the resources via the slave
flags. On the framework
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30850/#review71895
---
src/slave/slave.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30850/#review71914
---
Patch looks great!
Reviews applied: [30812, 30850]
All tests
On Feb. 11, 2015, 1:23 a.m., Timothy Chen wrote:
So after looking at this review, I'm not sure we really need to add
anything to Mesos, as getting graphic compute units and memory could be a
seperate process/script that just injects the resources via the slave
flags. On the framework
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2735/changes
+1 Tom/Adam
--sent from my phone
On Feb 10, 2015 10:52 AM, Niklas Nielsen nik...@mesosphere.io wrote:
+1
Thanks for the write up Ben!
On Tuesday, February 10, 2015, Dominic Hamon dha...@twitter.com.invalid
wrote:
Well, we should probably do that anyway :)
On Feb 10, 2015 2:25 AM, Adam
On Feb. 9, 2015, 12:07 p.m., Ian Downes wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 405
https://reviews.apache.org/r/30609/diff/2/?file=853657#file853657line405
this is leaking the implementation, both that it's using stat and that
it's using lstat in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30792/#review71798
---
Patch looks great!
Reviews applied: [30792]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30827/#review71801
---
Bad patch!
Reviews applied: [30827]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30338/#review71813
---
Ship it!
Ship It!
- Niklas Nielsen
On Feb. 9, 2015, 6:53 p.m.,
On Feb. 8, 2015, 2:06 p.m., Benjamin Hindman wrote:
src/launcher/fetcher.cpp, line 388
https://reviews.apache.org/r/30774/diff/1/?file=857926#file857926line388
Kill '} else {'.
That would be wrong. Then the CHECK would fire every time.
On Feb. 8, 2015, 2:06 p.m., Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/
---
(Updated Feb. 10, 2015, 1:14 a.m.)
Review request for mesos, Adam B, Benjamin
Hi all,
I am trying to submit my patch for review, but the
support/post-reviews.py
script keeps getting stuck at 'Press enter to continue or 'Ctrl-C' to
skip.' and doesn't respond to the input('Enter') except for Ctrl-C
Sorry if I am missing something obvious.
I am new here and this is the first
Somebody recently pointed to the riak-debug [1] tool as another example.
[1] https://github.com/basho/riak/blob/develop/rel/files/riak-debug
On Mon, Feb 9, 2015 at 12:04 PM, Cody Maloney c...@mesosphere.io wrote:
It would be nice if we auto-packaged up backtraces so they could be easily
On Feb. 9, 2015, 12:07 p.m., Ian Downes wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 405
https://reviews.apache.org/r/30609/diff/2/?file=853657#file853657line405
this is leaking the implementation, both that it's using stat and that
it's using lstat in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30609/
---
(Updated Feb. 10, 2015, 3:19 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29883/
---
(Updated Feb. 10, 2015, 12:33 p.m.)
Review request for mesos, Ben Mahler,
It may due to not login yet, try to run rbt status to see any info.
Chester
2015/2/10 下午6:31 於 Siddharth Choudhary siddharthchoudhary...@gmail.com
寫道：
Hi all,
I am trying to submit my patch for review, but the
support/post-reviews.py
script keeps getting stuck at 'Press enter to continue or
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30792/
---
(Updated Feb. 10, 2015, 3:37 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30808/#review71782
---
Patch looks great!
Reviews applied: [30808]
All tests passed.
-
See https://builds.apache.org/job/mesos-reviewbot/4025/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30840/#review71823
---
Patch looks great!
Reviews applied: [30840]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29607/
---
(Updated Feb. 10, 2015, 2:03 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30509/#review71825
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 9, 2015, 6 p.m., Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30510/#review71826
---
src/slave/containerizer/mesos/containerizer.cpp
On Feb. 10, 2015, 2:01 p.m., Niklas Nielsen wrote:
src/Makefile.am, line 1293
https://reviews.apache.org/r/29607/diff/10/?file=859559#file859559line1293
Copy past :) Do we want this comment for every module? I think just
having it on the first one would suffice
I think it's
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30508/#review71822
---
Ship it!
src/tests/persistent_volume_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29607/#review71832
---
Ship it!
src/Makefile.am
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29932/
---
(Updated Feb. 10, 2015, 7:12 p.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29607/
---
(Updated Feb. 10, 2015, 2:22 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29607/
---
(Updated Feb. 10, 2015, 2:30 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30580/#review71855
---
Ship it!
Ship It!
- Niklas Nielsen
On Feb. 3, 2015, 6:14 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30583/#review71856
---
Ship it!
Modulo Vinod's comments
- Niklas Nielsen
On Feb. 4,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29890/
---
(Updated Feb. 10, 2015, 7:59 p.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29925/
---
(Updated Feb. 10, 2015, 7:59 p.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29932/#review71851
---
Patch looks great!
Reviews applied: [29932]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29931/
---
(Updated Feb. 10, 2015, 8 p.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29927/
---
(Updated Feb. 10, 2015, 8 p.m.)
Review request for mesos, Bernd Mathiske, Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30841/
---
Review request for mesos and Jie Yu.
Bugs: MESOS-1023
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29607/#review71843
---
Ship it!
Ship It!
- Till Toenshoff
On Feb. 10, 2015, 7:30 p.m.,
+1
It would be nice if there was way to specify things like build system
changes which are different than just adding/removing a single file. But
probably that level of enforcement isn't worth the effort it would take to
add.
On Tue, Feb 10, 2015 at 8:56 AM, James DeFelice
On Feb. 11, 2015, 7:16 a.m., Benjamin Hindman wrote:
Took care of the minor issue and committed.
- Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30194/#review71938
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30195/#review71939
---
Ship it!
Minor issues, I'll take care of them and get this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30194/#review71938
---
Ship it!
On May 16, 2014, 7:32 a.m., Niklas Nielsen wrote:
Hey Chengwei - sorry for the tardy turnaround time on this review request.
To me, it still seems like we are treating the symptoms of the real issue:
PATH is appended multiple times and the subsequent globbing adds the
available
Hi dev,
Just checking with current Mesos and i didn't see it utilize NUMA
system of memory/CPU allocation on slave.
Are there anyone planning on this or correct me if this is supported.
There is a feature called cpuset implemented in the linux kernel,
which is very useful for HPC application on
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30587/#review71941
---
Ship it!
Ship It!
- Benjamin Hindman
On Feb. 4, 2015, 12:06
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29742/
---
(Updated Feb. 11, 2015, 7:57 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29742/
---
(Updated Feb. 11, 2015, 7:57 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/#review71861
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 10, 2015, 10:22 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30601/#review71864
---
Ship it!
Ship It!
- Niklas Nielsen
On Feb. 5, 2015, 1:02 p.m.,
)@67.195.81.187:53677 (pomona.apache.org) with id
20150210-230045-3142697795-53677-14658-S0
I0210 23:00:45.531380 14680 master.cpp:1573] Received registration request for
framework 'default' at
scheduler-3140ea46-2690-411a-b1ea-afe4b326585f@67.195.81.187:53677
I0210 23:00:45.531468 14680 master.cpp:1434
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/
---
(Updated Feb. 10, 2015, 2:22 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30850/
---
(Updated Feb. 10, 2015, 11:10 p.m.)
Review request for mesos, Ben Mahler,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30850/
---
Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30812/#review71886
---
Ship it!
Before you commit this, mind adding a test to ensure that
See https://builds.apache.org/job/mesos-reviewbot/4024/
--
[...truncated 5646 lines...]
rm -f tests/.dirstamp
rm -rf examples/.libs examples/_libs
rm -f slave/containerizer/mesos/*.o
rm -f tests/common/.deps/.dirstamp
rm -f tests/common/.dirstamp
rm -f
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30609/#review71880
---
It might be time to introduce os::stat and os::lstat wrappers to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30808/#review71881
---
3rdparty/libprocess/src/clock.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30841/#review71875
---
Patch looks great!
Reviews applied: [30841]
All tests passed.
-
On Feb. 10, 2015, 5:01 p.m., Mesos ReviewBot wrote:
Bad patch!
Reviews applied: [30827]
Failed command: ./support/apply-review.sh -n -r 30827
Error:
2015-02-10 17:01:08 URL:https://reviews.apache.org/r/30827/diff/raw/
[1031/1031] - 30827.patch [1]
error: patch failed:
71 matches
Mail list logo
