---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29288/#review75572
---
Bad patch!
Reviews applied: [29288]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31664/#review75571
---
src/common/resources.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31818/#review75587
---
Ship it!
Good job getting to the bottom of this!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/#review75556
---
LGTM!
- Isabel Jimenez
On March 6, 2015, 10:42 a.m., Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
---
(Updated March 6, 2015, 10:56 p.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
---
(Updated March 6, 2015, 10:56 p.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
---
(Updated March 6, 2015, 11:02 p.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31667/#review75561
---
src/master/allocator/mesos/hierarchical.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31700/#review75611
---
Patch looks great!
Reviews applied: [31700]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31818/#review75606
---
Patch looks great!
Reviews applied: [31818]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31470/
---
(Updated March 6, 2015, 10:57 p.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31666/#review75558
---
src/master/allocator/allocator.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31539/
---
(Updated March 6, 2015, 10:39 p.m.)
Review request for mesos, Adam B, Cody
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31472/#review75560
---
Bad patch!
Reviews applied: [31472]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review75595
---
Patch looks great!
Reviews applied: [31470, 31471, 29289, 29290]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31700/
---
(Updated March 7, 2015, 1:43 a.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31818/
---
Review request for mesos, Ben Mahler, Dario Rexin, and switched to 'mcypark'.
On March 6, 2015, 11:28 p.m., Ben Mahler wrote:
src/common/resources.cpp, lines 992-997
https://reviews.apache.org/r/31664/diff/4/?file=887502#file887502line992
This looks inconsistent with all of the other + operator
implementations in this file, no?
Reverted for consistency.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31539/#review75580
---
Patch looks great!
Reviews applied: [31539]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31664/
---
(Updated March 7, 2015, 12:21 a.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31818/#review75581
---
src/java/jni/convert.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31539/
---
(Updated March 7, 2015, 12:32 a.m.)
Review request for mesos, Adam B, Cody
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25549/#review75584
---
src/slave/slave.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30952/#review75585
---
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31818/
---
(Updated March 6, 2015, 5:08 p.m.)
Review request for mesos, Ben Mahler, Dario
It's not clear if we still want to ensure GC events are ordered globally.
We might want to break that order if we have per-item constraints to deal
with (e.g. link count).
Can you elaborate on the delay approach you're mentioning?
On Wed, Mar 4, 2015 at 9:30 AM, Ritwik ritwik.ya...@gmail.com
this just seems to be a connection issue?
On Fri, Mar 6, 2015 at 9:51 AM, Niklas Nielsen nik...@mesosphere.io wrote:
Still the python clean up issue (
https://issues.apache.org/jira/browse/MESOS-2362)
Niklas
On 6 March 2015 at 09:24, Apache Jenkins Server jenk...@builds.apache.org
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31539/
---
(Updated March 6, 2015, 11:38 a.m.)
Review request for mesos, Adam B, Cody
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31539/
---
(Updated March 6, 2015, 2:22 p.m.)
Review request for mesos, Adam B, Cody
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31539/#review75488
---
Patch looks great!
Reviews applied: [31539]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/#review75485
---
Patch looks great!
Reviews applied: [31538]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31183/#review75486
---
The semantics of sum is still the old semantics (i.e. not
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31539/
---
(Updated March 6, 2015, 12:48 p.m.)
Review request for mesos, Adam B, Cody
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/#review75484
---
src/master/flags.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/
---
(Updated March 6, 2015, 5:46 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31250/#review73835
---
src/tests/isolator_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
---
(Updated March 6, 2015, 5:16 p.m.)
Review request for mesos, Benjamin Hindman,
See https://builds.apache.org/job/mesos-reviewbot/4464/
--
[...truncated 5644 lines...]
Removing .reviewboardrc
Removing 3rdparty/Makefile
Removing 3rdparty/Makefile.in
Removing 3rdparty/libprocess/.deps/
Removing 3rdparty/libprocess/3rdparty/.deps/
On Feb. 23, 2015, 9:43 a.m., Ian Downes wrote:
src/slave/containerizer/isolators/cgroups/cpushare.cpp, line 421
https://reviews.apache.org/r/31250/diff/1/?file=871370#file871370line421
It's hitting the kernel: I'm not sure how it internally keeps track of
the processes/threads in
On Feb. 23, 2015, 8:49 p.m., Ben Mahler wrote:
src/common/type_utils.cpp, lines 63-65
https://reviews.apache.org/r/31011/diff/4/?file=867675#file867675line63
Does the reflection API support getting default values? (possibly
workable w/o direct default support)
Does
On Feb. 23, 2015, 8:49 p.m., Ben Mahler wrote:
src/common/type_utils.cpp, lines 63-65
https://reviews.apache.org/r/31011/diff/4/?file=867675#file867675line63
Does the reflection API support getting default values? (possibly
workable w/o direct default support)
Does
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/
---
(Updated March 6, 2015, 11:42 a.m.)
Review request for mesos, Isabel Jimenez,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31790/#review75483
---
Patch looks great!
Reviews applied: [31790]
All tests passed.
-
On Feb. 20, 2015, 10:19 p.m., Vinod Kone wrote:
src/authentication/cram_md5/authenticator.cpp, line 449
https://reviews.apache.org/r/27760/diff/17/?file=869278#file869278line449
Shouldn't this be protected by once() to avoid 2 different threads
loading secrets at the same time?
See https://builds.apache.org/job/mesos-reviewbot/4465/
On March 6, 2015, 1:50 p.m., Joerg Schad wrote:
The semantics of sum is still the old semantics (i.e. not considering
non-scalar ressources). If yes could you add a small note about this in the
description?
That's correct. I'll add a comment saying that this function does not yield
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31664/
---
(Updated March 6, 2015, 6:46 p.m.)
Review request for mesos, Alexander
Hi folks,
We are planning to do monthly Mesos community meetings. Tentatively these
are scheduled to occur on 1st Thursday of every month at 3 PM PST. See
below for details to join the meeting remotely.
This is a forum to ask questions/discuss about upcoming features, process
etc. Everyone is
Still the python clean up issue (
https://issues.apache.org/jira/browse/MESOS-2362)
Niklas
On 6 March 2015 at 09:24, Apache Jenkins Server jenk...@builds.apache.org
wrote:
See https://builds.apache.org/job/mesos-reviewbot/4464/
--
[...truncated 5644
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31471/#review75500
---
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review74860
---
3rdparty/libprocess/include/process/address.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31790/#review75517
---
Ship it!
Ship It!
- Vinod Kone
On March 6, 2015, 4:17 a.m.,
On March 6, 2015, 10:18 a.m., Vinod Kone wrote:
src/common/type_utils.cpp, line 59
https://reviews.apache.org/r/31784/diff/2/?file=887439#file887439line59
I don't think doing this change piece-wise for one variable (e.g.,
'environment') at a time is intuitive to readers of this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review75499
---
Bad patch!
Reviews applied: [31677]
Failed command:
On March 6, 2015, 6:18 p.m., Vinod Kone wrote:
src/common/type_utils.cpp, line 59
https://reviews.apache.org/r/31784/diff/2/?file=887439#file887439line59
I don't think doing this change piece-wise for one variable (e.g.,
'environment') at a time is intuitive to readers of this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31183/
---
(Updated March 6, 2015, 6:31 p.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31784/#review75502
---
src/common/type_utils.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31664/
---
(Updated March 6, 2015, 6:34 p.m.)
Review request for mesos, Alexander
On March 6, 2015, 6:23 p.m., Jie Yu wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, lines 268-270
https://reviews.apache.org/r/31471/diff/7/?file=886045#file886045line268
As we discussed offline, please change the name of this function to:
```
static
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31784/
---
(Updated March 6, 2015, 6:04 p.m.)
Review request for mesos, Alexander
On March 6, 2015, 2:37 a.m., Alexander Rukletsov wrote:
include/mesos/resources.hpp, lines 107-108
https://reviews.apache.org/r/31183/diff/6/?file=883408#file883408line107
We can't really sum non-scalar resources, right? Does it make sense to
rename the function to something like
On March 6, 2015, 10:23 a.m., Jie Yu wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, lines 268-270
https://reviews.apache.org/r/31471/diff/7/?file=886045#file886045line268
As we discussed offline, please change the name of this function to:
```
static
On March 6, 2015, 3 a.m., Alexander Rukletsov wrote:
src/common/resources.cpp, line 993
https://reviews.apache.org/r/31664/diff/2/?file=883420#file883420line993
We can let the compiler do the copy for us. There is an opinion, that
this is the preferred way:
On March 6, 2015, 5:03 p.m., Dominic Hamon wrote:
src/tests/isolator_tests.cpp, line 577
https://reviews.apache.org/r/31250/diff/2/?file=873351#file873351line577
0U .. processes() and threads() are unsigned.
fixed.
On March 6, 2015, 5:03 p.m., Dominic Hamon wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31250/
---
(Updated March 6, 2015, 6:36 p.m.)
Review request for mesos and Ian Downes.
On March 6, 2015, 5:03 p.m., Dominic Hamon wrote:
src/slave/flags.hpp, line 229
https://reviews.apache.org/r/31250/diff/5/?file=886975#file886975line229
having this in slave makes me uncomfortable. it really should be
somewhere like the isolator given that it's accessed only
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31720/#review75531
---
This is too vague, what does a pull request entail? We also don't
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
---
(Updated March 6, 2015, 8:02 p.m.)
Review request for mesos, Benjamin Hindman,
On March 6, 2015, 6:38 p.m., Jie Yu wrote:
3rdparty/libprocess/src/process.cpp, line 837
https://reviews.apache.org/r/29289/diff/24/?file=887418#file887418line837
Please do not remove any logging.
```
LOG(FATAL) Parsing LIBPROCESS_IP= value failed:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31784/#review75533
---
Patch looks great!
Reviews applied: [31784]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29288/
---
(Updated March 6, 2015, 8 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
---
(Updated March 6, 2015, 8:07 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31471/
---
(Updated March 6, 2015, 8:05 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31472/
---
(Updated March 6, 2015, 7:59 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31473/
---
(Updated March 6, 2015, 7:58 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31471/
---
(Updated March 6, 2015, 8:01 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31471/
---
(Updated March 6, 2015, 7:58 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31470/
---
(Updated March 6, 2015, 8:06 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31539/#review75540
---
LGTM!
Need some mesos committers to review now.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review75530
---
Looking great! The code is much more cleaner now!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31183/#review75550
---
Sorry for commenting after giving a Ship It. I was checking
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31769/#review75541
---
Ship it!
Ship It!
- Ben Mahler
On March 5, 2015, 6:46 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31664/#review75544
---
Ship it!
Ship It!
- Alexander Rukletsov
On March 6, 2015, 6:46
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31183/#review75543
---
Ship it!
Ship It!
- Alexander Rukletsov
On March 6, 2015, 6:31
On March 6, 2015, 2:15 p.m., Timothy Chen wrote:
include/mesos/fetcher/fetcher.proto, line 58
https://reviews.apache.org/r/30774/diff/32/?file=887350#file887350line58
It's harder to make a optional field required, but it's much easier the
other way around.
If we
On March 6, 2015, 11:09 p.m., Alexander Rukletsov wrote:
src/master/allocator/mesos/hierarchical.hpp, lines 313-317
https://reviews.apache.org/r/31667/diff/3/?file=883430#file883430line313
See my comment to https://reviews.apache.org/r/31666/.
See my comment in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31664/
---
(Updated March 7, 2015, 6:56 a.m.)
Review request for mesos, Alexander
On March 6, 2015, 11:09 p.m., Alexander Rukletsov wrote:
src/master/allocator/sorter/drf/sorter.hpp, line 89
https://reviews.apache.org/r/31667/diff/3/?file=883431#file883431line89
`SlaveID` as a function parameter?
Are you suggesting adding `SlaveID` to this function? or are you
On March 6, 2015, 10:57 p.m., Alexander Rukletsov wrote:
src/master/allocator/allocator.hpp, line 67
https://reviews.apache.org/r/31666/diff/2/?file=883424#file883424line67
In `updateAllocation()` and `recoverResources()` we pass both `SlaveID`
and `FrameworkID` as function
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review75622
---
Ship it!
Ship It!
- Jie Yu
On March 6, 2015, 10:56 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review75623
---
Ship it!
Ship It!
- Jie Yu
On March 6, 2015, 11:02 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31676/#review75554
---
docs/configuration.md
92 matches
Mail list logo
