Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/530
Thanks for the feedback @mattf-horton, I will go through it all. About
tracking changes... I will check and see what there is to pick up. Obviously
this was much more current when the PR was
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r129736147
--- Diff:
bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java ---
@@ -0,0 +1,742 @@
+/*
+ * Licensed to the Apache Software
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r129737358
--- Diff:
bundles-maven-plugin/src/main/java/org/apache/metron/BundleProvidedDependenciesMojo.java
---
@@ -0,0 +1,326 @@
+/*
+ * Licensed to
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r129737404
--- Diff:
bundles-maven-plugin/src/main/java/org/apache/metron/BundleProvidedDependenciesMojo.java
---
@@ -0,0 +1,326 @@
+/*
+ * Licensed to
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r129737037
--- Diff:
bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java ---
@@ -0,0 +1,742 @@
+/*
+ * Licensed to the Apache Software
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r129735629
--- Diff:
bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java ---
@@ -0,0 +1,742 @@
+/*
+ * Licensed to the Apache Software
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r129735313
--- Diff:
bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java ---
@@ -0,0 +1,742 @@
+/*
+ * Licensed to the Apache Software
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r129737464
--- Diff:
bundles-maven-plugin/src/main/java/org/apache/metron/BundleProvidedDependenciesMojo.java
---
@@ -0,0 +1,326 @@
+/*
+ * Licensed to
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r129737287
--- Diff:
bundles-maven-plugin/src/main/java/org/apache/metron/BundleProvidedDependenciesMojo.java
---
@@ -0,0 +1,326 @@
+/*
+ * Licensed to
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r129737424
--- Diff:
bundles-maven-plugin/src/main/java/org/apache/metron/BundleProvidedDependenciesMojo.java
---
@@ -0,0 +1,326 @@
+/*
+ * Licensed to
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r129734358
--- Diff:
bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java ---
@@ -0,0 +1,742 @@
+/*
+ * Licensed to the Apache Software
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r129737262
--- Diff:
bundles-maven-plugin/src/main/java/org/apache/metron/BundleProvidedDependenciesMojo.java
---
@@ -0,0 +1,326 @@
+/*
+ * Licensed to
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r129735514
--- Diff:
bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java ---
@@ -0,0 +1,742 @@
+/*
+ * Licensed to the Apache Software
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r129735790
--- Diff:
bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java ---
@@ -0,0 +1,742 @@
+/*
+ * Licensed to the Apache Software
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r129736065
--- Diff:
bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java ---
@@ -0,0 +1,742 @@
+/*
+ * Licensed to the Apache Software
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r129735819
--- Diff:
bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java ---
@@ -0,0 +1,742 @@
+/*
+ * Licensed to the Apache Software
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r129734993
--- Diff:
bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java ---
@@ -0,0 +1,742 @@
+/*
+ * Licensed to the Apache Software
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/671
Thanks @spencer-hanson ! +1 by inspection
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/530
Please remove instances of "incubator" or "incubating" in bundles-lib/,
bundles-maven-plugin/, and metron-platform/metron-extensions :
```
bundles-maven-plugin/pom.xml:
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/530
I'm trying to compare bundle-lib with nifi-nar-utils, and blocked because
the code trees under
* bundles-lib/src/main/java/org/apache/metron/bundles and
*
There’s a couple other places you could put config info (but maybe not saved
searches):
- Zookeeper
- metron-alerts-ui/config.xml or config.json file
- the Ambari database, whichever it happens to be
Questions that influence the decision include:
1. Should there be one configuration shared
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/607#discussion_r129718460
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/StormStatusServiceImpl.java
---
@@ -17,10 +17,7 @@
*/
Github user lvets commented on the issue:
https://github.com/apache/metron/pull/671
I think this looks good ð :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user spencer-hanson opened a pull request:
https://github.com/apache/metron/pull/671
METRON-1067: Minor Typo Fix
## Contributor Comments
Minor Typo
JIRA https://issues.apache.org/jira/browse/METRON-1067
## Pull Request Checklist
Thank you for
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/607#discussion_r129692618
--- Diff:
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/StormControllerIntegrationTest.java
---
@@ -182,6 +185,16 @@
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/607#discussion_r129691439
--- Diff:
metron-interface/metron-rest-client/src/main/java/org/apache/metron/rest/model/SupervisorStatus.java
---
@@ -0,0 +1,127 @@
+/**
+ *
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/607#discussion_r129690884
--- Diff:
metron-interface/metron-rest-client/src/main/java/org/apache/metron/rest/model/SupervisorStatus.java
---
@@ -0,0 +1,127 @@
+/**
+ *
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/530
Hi @ottobackwards , the PR description list of files changed and reasons is
_extremely_ helpful, indeed necessary. But the github PR GUI isn't really
tuned for handling 400 files even when --
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/530
@mattf-horton I believe
https://github.com/apache/nifi/commit/d90cf846b9dcd49acdeac7bb5fcd13ee80dcdba6#diff-83e1afb34470ca47809f82aa1caf2138
is the commit from nifi-nar-utils
---
If your
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/530
@mattf-horton branch is up to date as of this morning
https://github.com/apache/metron/commit/badc6cf9739a31800abee1cfccbcf9930b130fa7
---
If your project is set up for it, you can reply
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/530
https://github.com/apache/metron/pull/530/commits/0d9a43a9393a20309845c668a206005f45ea4617
for our master as of this moment @mattf-horton
---
If your project is set up for it, you
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/530
@mattf-horton In the PR description there is a list of files changed and
the reason for them, does that help?
I am going to merge master and resolve conflicts this morning. I have
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/635
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/643#discussion_r129532376
--- Diff:
metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/nonbulk/taxii/TaxiiLoader.java
---
@@ -165,6 +167,19 @@ public
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/530
@ottobackwards , could you please state the latest SHA1 on master to which
you've merged?
I ask because I'm going to need to bring up a full dev image, and do `git
diff`s against the
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/530
I'm working on this review. It's gonna take a couple days.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
36 matches
Mail list logo
