[GitHub] metron pull request #828: METRON-1295 Unable to Configure Logging for REST A...

Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/828 ---

[GitHub] metron issue #774: METRON-1212 The bundle system and maven plugin

Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/774 @mattf-horton I have added some more documentation, and I think the bundles-testing project provides a simple, integrated example. @nickwallen and I talked it over, and he is going to try

[GitHub] metron pull request #822: METRON-1288 Update so it installs java8

Github user CUGCR closed the pull request at: https://github.com/apache/metron/pull/822 ---

[GitHub] metron issue #822: METRON-1288 Update so it installs java8

Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/822 Since this has been landed in the other PR, can you close this one please? ---

[GitHub] metron issue #338: METRON-295: Script parsing bolt

Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/338 What is the status of this effort? ---

[GitHub] metron pull request #835: METRON-1307 Force install of java8 since java9 doe...

Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/835 ---

[GitHub] metron issue #835: METRON-1307 Force install of java8 since java9 does not a...

Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/835 thank you @brianhurley. +1, I will commit ---

[GitHub] metron issue #834: METRON-1306: When index template install fails, we should...

Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/834 My comment is more 'big picture'. I don't think it nec. applies to how this PR is resolved. ---

[GitHub] metron issue #835: METRON-1307 Force install of java8 since java9 does not a...

Github user CUGCR commented on the issue: https://github.com/apache/metron/pull/835 @ottobackwards back to you! ---

[GitHub] metron pull request #835: METRON-1307 Force install of java8 since java9 doe...

GitHub user brianhurley opened a pull request: https://github.com/apache/metron/pull/835 METRON-1307 Force install of java8 since java9 does not appear to work Force install of java8 since java9 does not appear to work with the current scripts in the README.md file ##

[GitHub] metron issue #834: METRON-1306: When index template install fails, we should...

Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/834 @ottobackwards I need to think through the use cases and implications more (e.g. what about a non-ES situation?), but I think your points are valid. ---

[GitHub] metron issue #834: METRON-1306: When index template install fails, we should...

Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/834 my comment was re: "It appears to me that we cannot add new templates via the current Ambari mechanism without modifying a release/MPack" ---

[GitHub] metron issue #829: METRON-1296 Full Dev Fails to Deploy Index Templates

Github user anandsubbu commented on the issue: https://github.com/apache/metron/pull/829 @nickwallen , for the record full dev spun up fine with the fix. Thank you! ---

[GitHub] metron issue #834: METRON-1306: When index template install fails, we should...

Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/834 @nickwallen and @cestella you both make some good points here. The upshot is that this part of our architecture is inextricably tied to ES and in reality we should have another abstraction here. It

[GitHub] metron issue #833: METRON-1275: Fix Metron Documentation

Github user cestella commented on the issue: https://github.com/apache/metron/pull/833 Piling on with a +1, great job @JonZeolla ---

[GitHub] metron issue #834: METRON-1306: When index template install fails, we should...

Github user cestella commented on the issue: https://github.com/apache/metron/pull/834 I ran this up in full-dev and index start functions fine and data is written to the indices. ---

[GitHub] metron pull request #832: METRON-1301 Sorting on Triage Score Unexpectedly F...

Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/832#discussion_r149429061 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java --- @@ -234,26 +366,43 @@ public

[GitHub] metron pull request #832: METRON-1301 Sorting on Triage Score Unexpectedly F...

Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/832#discussion_r149428796 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java --- @@ -234,26 +366,43 @@ public

[GitHub] metron pull request #832: METRON-1301 Sorting on Triage Score Unexpectedly F...

Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/832#discussion_r149428276 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java --- @@ -234,26 +366,43 @@ public

[GitHub] metron pull request #832: METRON-1301 Sorting on Triage Score Unexpectedly F...

Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/832#discussion_r149426981 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java --- @@ -234,26 +366,43 @@ public

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r149423305 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/IndexDao.java --- @@ -65,6 +65,8 @@ */ Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r149422318 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/Constants.java --- @@ -29,6 +29,7 @@ public static final String

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r149423194 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -121,13 +121,16 @@ public synchronized

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r149423571 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/IndexDao.java --- @@ -65,6 +65,8 @@ */ Document

[GitHub] metron pull request #825: METRON-1290: Only first 10 alerts are update when ...

Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/825#discussion_r149421326 --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDaoTest.java --- @@ -489,4 +505,54

[GitHub] metron issue #833: METRON-1275: Fix Metron Documentation

Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/833 @JonZeolla I am assuming you just added additional options that are now available. That being the case, +1 from me. ---

[GitHub] metron pull request #826: METRON-1291: Kafka produce REST endpoint does not ...

Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/826#discussion_r149420627 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/config/KafkaConfig.java --- @@ -108,6 +108,9 @@ public ZkUtils zkUtils() {

[GitHub] metron pull request #833: METRON-1275: Fix Metron Documentation

Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/833#discussion_r149420478 --- Diff: metron-platform/Performance-tuning-guide.md --- @@ -219,38 +219,49 @@ And we ran our bro parser topology with the following options. We did not

[GitHub] metron pull request #833: METRON-1275: Fix Metron Documentation

Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/833#discussion_r149420193 --- Diff: metron-platform/Performance-tuning-guide.md --- @@ -219,38 +219,49 @@ And we ran our bro parser topology with the following options. We did not

[GitHub] metron issue #833: METRON-1275: Fix Metron Documentation

Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/833 Yes @lvets your +1 is definitely relevant. I wish more community members would review PRs. ---

[GitHub] metron issue #822: METRON-1288 Update so it installs java8

Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/822 Thank you again for the contribution. We would like for you to re-submit this pr as an individual so that we can maintain the correct author and attribution. Feel free to tag me in

[GitHub] metron issue #833: METRON-1275: Fix Metron Documentation

Github user lvets commented on the issue: https://github.com/apache/metron/pull/833 I don't know whether my +1 is actually relevant, but here it goes: +1. Looks good to me :) ---

[GitHub] metron pull request #827: METRON-1294: IP addresses are not formatted correc...

Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/827#discussion_r149418025 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/SearchControllerIntegrationTest.java --- @@ -236,17 +236,14 @@

[GitHub] metron issue #828: METRON-1295 Unable to Configure Logging for REST API

Github user cestella commented on the issue: https://github.com/apache/metron/pull/828 Dig. +1 by inspection ---

[GitHub] metron pull request #832: METRON-1301 Sorting on Triage Score Unexpectedly F...

Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/832#discussion_r149411916 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java --- @@ -234,26 +366,43 @@ public

[GitHub] metron pull request #832: METRON-1301 Sorting on Triage Score Unexpectedly F...

Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/832#discussion_r149409051 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/files/bro_index.template --- @@ -98,7

[GitHub] metron pull request #832: METRON-1301 Sorting on Triage Score Unexpectedly F...

Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/832#discussion_r149410922 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchColumnMetadataDao.java --- @@ -0,0 +1,192 @@

[GitHub] metron pull request #832: METRON-1301 Sorting on Triage Score Unexpectedly F...

Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/832#discussion_r149413486 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/utils/ElasticsearchUtils.java --- @@ -179,4 +186,46 @@ else

[GitHub] metron issue #834: METRON-1306: When index template install fails, we should...

Github user cestella commented on the issue: https://github.com/apache/metron/pull/834 Nick's points are spot-on, I think. I think the core abstraction issue is that we're doing ES-specific things in the indexing section. We probably want to decouple indexing from ES a bit and have

[GitHub] metron issue #834: METRON-1306: When index template install fails, we should...

Github user cestella commented on the issue: https://github.com/apache/metron/pull/834 Ok, so a couple of things here. I wanted to have a vigorous discussion, because this change has some pros and cons. At the moment, as Nick alluded, we do template install upon index

[GitHub] metron issue #834: METRON-1306: When index template install fails, we should...

Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/834 And for the record @anandsubbu did implement this as "fail fast" in his original PR. So I think he is all for this. I was the one who talked him out of failing fast here. I was wary of

[GitHub] metron issue #834: METRON-1306: When index template install fails, we should...

Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/834 I clearly see the advantages of failing fast here, but I do have a hesitation. I haven't even totally convinced myself of this. Maybe you guys can help me think down this line of thought and

Re: [APACHE COMMITER QUESTION] PR’s from organization’s as opposed to ‘people’

Ok On November 7, 2017 at 09:32:54, Nick Allen (n...@nickallen.org) wrote: > I share your concern there and think it would be reasonable to ask for it to be re-contributed by an individual. I agree with Larry's suggestion. On Tue, Nov 7, 2017 at 9:16 AM, Otto Fowler

[GitHub] metron issue #834: METRON-1306: When index template install fails, we should...

Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/834 This is good. +1 by inspection. ---

[GitHub] metron issue #829: METRON-1296 Full Dev Fails to Deploy Index Templates

Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/829 @anandsubbu agreed with your comments on the exception ---

[GitHub] metron issue #834: METRON-1306: When index template install fails, we should...

Github user cestella commented on the issue: https://github.com/apache/metron/pull/834 Ah, yes, sorry, I should be more clear here. Starting the indexing topology should fail if the indexing templates are not installed. ---

[GitHub] metron issue #834: METRON-1306: When index template install fails, we should...

Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/834 Just a comment on the description of the JIRA, not the code change itself. Index templates can only be installed when starting the Indexing topology, not during install. During install,

[GitHub] metron pull request #834: METRON-1306: When index template install fails, we...

GitHub user cestella opened a pull request: https://github.com/apache/metron/pull/834 METRON-1306: When index template install fails, we should fail the install ## Contributor Comments Right now we warn when an index template install fails. In my opinion, this should be an

[GitHub] metron issue #829: METRON-1296 Full Dev Fails to Deploy Index Templates

Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/829 +1. I agree with Casey that this should fail instead of WARN. If templates are not installed it puts us in a bad state and requires manual intervention that may not be obvious. ---

[GitHub] metron pull request #829: METRON-1296 Full Dev Fails to Deploy Index Templat...

Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/829 ---

[GitHub] metron issue #829: METRON-1296 Full Dev Fails to Deploy Index Templates

Github user cestella commented on the issue: https://github.com/apache/metron/pull/829 I'm +1 on the PR, but I strongly agree with Anand, this should not be a warn. We should throw an exception here and fail the build. That being said, despite it being in the vicinity of this PR,

[GitHub] metron issue #829: METRON-1296 Full Dev Fails to Deploy Index Templates

Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/829 > However, given that the indexing templates are a must have for the alerts UI to work properly, should we remove the try/expect block and allow the install to fail in the event it was not

Re: [APACHE COMMITER QUESTION] PR’s from organization’s as opposed to ‘people’

> I share your concern there and think it would be reasonable to ask for it to be re-contributed by an individual. I agree with Larry's suggestion. On Tue, Nov 7, 2017 at 9:16 AM, Otto Fowler wrote: > BUMP > > > On November 2, 2017 at 11:37:26, larry mccay

[GitHub] metron issue #829: METRON-1296 Full Dev Fails to Deploy Index Templates

Github user anandsubbu commented on the issue: https://github.com/apache/metron/pull/829 Hi @nickwallen , thank you for the fix. It is my bad, I should have added the line `commands = IndexingCommands(params)` before the `try` block in my previous fix :(. I am under way

Re: Committing to the metron-bro-plugin-kafka repo

So here's an update on this, and I'm looking for any suggestions regarding the roadmap. If anybody isn't clear about the implementation specifics or history here, I'm happy to reiterate, but it has also been discussed on the mailing list in the past. Right now, we have a direct migration of

Re: [APACHE COMMITER QUESTION] PR’s from organization’s as opposed to ‘people’

BUMP On November 2, 2017 at 11:37:26, larry mccay (lmc...@apache.org) wrote: Interesting question. I share your concern there and think it would be reasonable to ask for it to be re-contributed by an individual. Preferably, such that an Apache account can have it assigned to them. However, I

[GitHub] metron-bro-plugin-kafka issue #2: DO NOT MERGE METRON-1304: Allow metron-bro...

Github user nickwallen commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/2 My bad, you did. You're totally on top of it. Ignore me. :) ---

Re: Committing to the metron-bro-plugin-kafka repo

> As of bro-pkg 1.1, I need to redo my `bro-pkg.meta` work to support the > newly-added `external_depends`, and also upgrade to bro 2.5.2 Isn't upgrading to 2.5.2 an enhancement that we need to wait on before we finish some clean-up tasks? What all do you think we need to do before we start

[GitHub] metron-bro-plugin-kafka issue #2: DO NOT MERGE METRON-1304: Allow metron-bro...

Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/2 Yeah, I did send an initial email out [last night](https://lists.apache.org/thread.html/621cbeca432fef0170836e07036e309d943068c5d6a544c1ef2136f9@%3Cdev.metron.apache.org%3E), and in

[GitHub] metron-bro-plugin-kafka issue #2: DO NOT MERGE METRON-1304: Allow metron-bro...

Github user nickwallen commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/2 @JonZeolla Can you send an update to the Dev list on where we are at in migrating the Bro plugin? I had not even realized that you had added the code to this repo. We

[GitHub] metron-bro-plugin-kafka issue #1: METRON-1303: Reorganize the metron-bro-plu...

Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/1 I'm willing to bet we could get this tested using travis. There is a built-in btest which will be automatically run on install when this is turned into a package (although it is

[GitHub] metron-bro-plugin-kafka issue #2: DO NOT MERGE METRON-1304: Allow metron-bro...

Github user JonZeolla commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/2 Yup, I'm typing that up as we speak. ---

[GitHub] metron-bro-plugin-kafka issue #2: DO NOT MERGE METRON-1304: Allow metron-bro...

Github user ottobackwards commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/2 logs_to_exclude should be in the readme, and not just the bro file ---

[GitHub] metron-bro-plugin-kafka pull request #2: DO NOT MERGE METRON-1304: Allow met...

GitHub user JonZeolla opened a pull request: https://github.com/apache/metron-bro-plugin-kafka/pull/2 DO NOT MERGE METRON-1304: Allow metron-bro-plugin-kafka to include or exclude logs This PR assumes [METRON-1303](https://issues.apache.org/jira/browse/METRON-1303). This

[GitHub] metron-bro-plugin-kafka issue #1: METRON-1303: Reorganize the metron-bro-plu...

Github user ottobackwards commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/1 or if it is building can we link that to github? ---

[GitHub] metron-bro-plugin-kafka issue #1: METRON-1303: Reorganize the metron-bro-plu...

Github user ottobackwards commented on the issue: https://github.com/apache/metron-bro-plugin-kafka/pull/1 +1 by inspection Is there any CI build for this? Can we get it into travis? ---

[GitHub] metron issue #832: METRON-1301 Sorting on Triage Score Unexpectedly Filters ...

Github user iraghumitra commented on the issue: https://github.com/apache/metron/pull/832 @nickwallen really liked the way you annotated the PR with your comments. You made it really easy to understand and saved a lot of time for me. As you rightly pointed out I will wait till all

[GitHub] metron issue #825: METRON-1290: Only first 10 alerts are update when a MetaA...

Github user iraghumitra commented on the issue: https://github.com/apache/metron/pull/825 +1 for functionality, tested on full dev when status is changed on a meta-alert all the alerts in the meta-alert are updated with the correct status ---