Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/902
I have a mild preference for dev-utilities, since "support" has many
meanings.
---
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/902
@nickwallen , excellent to get this into the main repo, and totally agree
with the reorganization.
My only suggestion is that the main directory, currently named
"metron-dev-su
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/687
@ottobackwards And yet this discussion primarily relates to whether the
assignment operation as defined in Enrichment should be unified with the
assignment operation being added to core stellar
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/687
@ottobackwards , that's inarguably true. We can define the language to be
just the Stellar Core. We could also define it to include at least some of
those very useful other things, which
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/687
> I think we need to keep everything in it's separate pile. We have people
asking to host in not metron as recently as today.
My interpretation is that, in order to enable host
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/687
If one insists that ':=' in Enrichments is a Metron add-on not Stellar,
that is equivalent to stating that Enrichment doesn't use Stellar but rather a
custom DSL derived from Stellar. The xml
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/687
So a bunch more comments came in while I was writing the above. Nick's
comment about enrichments using assignment already of course modifies my
comment about Profilers, etc. Just making
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/687
As a professed language nut, when you mention the word "variable", I think
"scope". And it seems to me that by placing the responsibility for variable
assignment/update in
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/865
@ottobackwards , I'll try to refresh my review this weekend.
---
GitHub user mattf-horton opened a pull request:
https://github.com/apache/metron/pull/887
METRON-1388 update public web site to point at 0.4.2 new release
## Contributor Comments
Update the public web site to point at new release 0.4.2 (to be pushed
simultaneously
GitHub user mattf-horton opened a pull request:
https://github.com/apache/metron/pull/885
METRON-1384 Increment master version number to 0.4.3 for on-going
development
## Contributor Comments
per [METRON-1384](https://issues.apache.org/jira/browse/METRON-1384).
Followed
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/875
Thanks, @ottobackwards . @cestella , I'm concerned that, when this happens
we should actually recheck the licensing, since this is a 3rd-party package we
have no assurances about. Still I
GitHub user mattf-horton opened a pull request:
https://github.com/apache/metron/pull/875
METRON-1373 RAT failure for metron-interface/metron-alerts
## Contributor Comments
Please see https://issues.apache.org/jira/browse/METRON-1373 and
https://issues.apache.org/jira/browse
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/774
@ottobackwards says:
> would it be possible for you to help us with a comment as to your
approach when you reviewed this functionality? It might help if you could
summarize your feeli
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/816
Agree with @mmiklavc comment.
---
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/816
@mmiklavc and @cestella regarding "0.4.1" references in README.md files,
please see https://github.com/apache/metron/pull/767 , specifically Otto's
comment https://github.com/apache/m
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/816
+1 by inspection, pending Travis
---
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/767
Needed to re-kick Travis to be sure.
---
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/767
Sorry about that, folks. In future I won't trust github when it says it
will still merge "without conflict".
---
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/767
Thanks, @ottobackwards and @kylerichardson . Committing...
---
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/815
Thanks, everyone. Committing...
---
GitHub user mattf-horton opened a pull request:
https://github.com/apache/metron/pull/815
METRON-1278 Strip "Build Status" widget from root README.md in site-book
build
## Contributor Comments
See https://issues.apache.org/jira/browse/METRON-1278
## Pu
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/767
@ottobackwards , yup. So is that a +1 regarding commit? :-)
---
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/767
@ottobackwards , regarding the version references in
metron-analytics/metron-profiler/README.md:
This is a little difficult. Although these are installation instructions,
the lines you
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/767#discussion_r146143079
--- Diff: metron-platform/README.md ---
@@ -17,7 +17,7 @@ limitations under the License.
# Current Build
-The latest build
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/781
Altho I suppose the "Locality-Sensitive" part of TLSH means it operates at
word level instead of byte or character level?
---
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/781
FUZZY_SCORE and BLOOM_*. Is it worth trying to unify these
similarity-recognizers with similarity hash, or are they too far apart in terms
of expected use patterns?
---
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/767
Sure, but can we do that as a separate Jira? We should advance the present
version number promptly, since release 0.4.1 is published.
---
GitHub user mattf-horton opened a pull request:
https://github.com/apache/metron/pull/767
METRON-1196 Increment master version number to 0.4.2 for on-going
development
## Contributor Comments
Standard update of the Metron version number.
There are just a couple files where
GitHub user mattf-horton opened a pull request:
https://github.com/apache/metron/pull/764
METRON-1191 update public web site to point at 0.4.1 new release
## Contributor Comments
This is the pro-forma PR to update the Website for our 0.4.1 release.
All but one of the files
GitHub user mattf-horton opened a pull request:
https://github.com/apache/metron/pull/743
METRON-1163 RAT failures for metron-interface/metron-alerts
## Contributor Comments
Please see https://issues.apache.org/jira/browse/METRON-1163 for the
problem.
I'm not entirely
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/735
+1 by inspection, trusting your manual test. Please commit asap. Thanks!
---
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/706
+1, lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r133623540
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java ---
@@ -119,8 +120,10 @@ public static void init(final
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/530
@ottobackwards , looking very good. Couple more comments above
(unfortunately the system decided they are on "outdated" code, so you'll have
to press the "Show outdated"
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r133530431
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java ---
@@ -103,61 +104,52 @@ private ExtensionManager
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r133533234
--- Diff:
bundles-lib/src/test/java/org/apache/metron/bundles/BundleThreadContextClassLoaderTest.java
---
@@ -27,11 +27,21 @@
import
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r133527688
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java ---
@@ -121,33 +109,18 @@ private void unInit
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r133532210
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java ---
@@ -95,19 +91,11 @@ public static BundleClassLoaders
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/681
@ottobackwards , the validator for IS_NAN(x) in Java would be
Double.isNaN(double x).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/681
BTW, +/- Infinity **are** considered "real" values (essentially as tho via
rounding) and can be compared with equality and inequality. NaN is considered
a nonsensical or
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r133081975
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleSystem.java ---
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the Apache Software
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r133081623
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/util/ImmutableCollectionUtils.java
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/690#discussion_r133076804
--- Diff: metron-deployment/packaging/archive/metron-stellar-shell/pom.xml
---
@@ -0,0 +1,94 @@
+
+
+
+http://maven.apache.org/POM
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r133051603
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java ---
@@ -0,0 +1,540 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r133033964
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java ---
@@ -0,0 +1,376 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r133049444
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java ---
@@ -0,0 +1,540 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r133037865
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java ---
@@ -0,0 +1,376 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r133043905
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleThreadContextClassLoader.java
---
@@ -0,0 +1,213 @@
+/*
+ * Licensed
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r133046812
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleThreadContextClassLoader.java
---
@@ -0,0 +1,213 @@
+/*
+ * Licensed
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r133052945
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java ---
@@ -0,0 +1,540 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r133049087
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java ---
@@ -0,0 +1,540 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r133062854
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionMapping.java ---
@@ -0,0 +1,152 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r133049372
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java ---
@@ -0,0 +1,540 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r133060635
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleSystem.java ---
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the Apache Software
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r133035166
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java ---
@@ -0,0 +1,376 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r133048319
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleThreadContextClassLoader.java
---
@@ -0,0 +1,213 @@
+/*
+ * Licensed
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r133050317
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java ---
@@ -0,0 +1,540 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r133047499
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleThreadContextClassLoader.java
---
@@ -0,0 +1,213 @@
+/*
+ * Licensed
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/530
@ottobackwards , many good improvements here. A few comments on the
singleton idiom, and a couple other details.
---
If your project is set up for it, you can reply to this email and have
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r132801000
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleThreadContextClassLoader.java
---
@@ -0,0 +1,221 @@
+/*
+ * Licensed
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r132799099
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionMapping.java ---
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r132797485
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java ---
@@ -0,0 +1,436 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r132801955
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/VFSBundleClassLoader.java
---
@@ -0,0 +1,515 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r132795983
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java ---
@@ -0,0 +1,436 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r132801851
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/VFSBundleClassLoader.java
---
@@ -0,0 +1,515 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r132796537
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java ---
@@ -0,0 +1,436 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/530
Okay, @ottobackwards , after all this I really wanted to just say "it's
good" :-) but I did have a few more concerns, especially with
ExtensionManager.java.
I want to
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/481
Updated and re-ran unit and integration tests. @ottobackwards ,
metron-solr integration tests ran fine. I did see a problem with metron-rest
integration test
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/481
@dlyle65535 yes, I'll clean this up.
I'll run integration tests one more time to make sure I don't see
@ottobackwards 's problem, then commit on the strength of his and your +1. Let
me
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/530
Sure, no worries. And I didn't intend to imply that testing was
inadequate, just suggesting another for completeness. Can't have too many
tests :-)
---
If your project is set up for it, you
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/530
@ottobackwards , re `metron-parser-bundle-tests`, very good to have that
test. But it only loads one test bundle, right? so still would be good to
implement METRON-1099. Emphasizing
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/530
@ottobackwards , the \@VisibleForTesting annotation comes from:
> import com.google.common.annotations.VisibleForTesting;
which I believe comes from
```xml
1
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r132280796
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/bundle/BundleCoordinates.java
---
@@ -0,0 +1,93 @@
+/*
+ * Licensed
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r132279911
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/bundle/BundleDetails.java
---
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/530
I've opened METRON-1099 for integration tests regarding the two items I'm
not sure from code inspection will work right. But I'm not making this review
dependent on them because
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r132263102
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java ---
@@ -0,0 +1,353 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r132261444
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java ---
@@ -0,0 +1,353 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r132258789
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/bundle/BundleDetails.java
---
@@ -0,0 +1,189 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r132255328
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/bundle/Bundle.java ---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r132254112
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/util/FileSystemManagerFactory.java
---
@@ -0,0 +1,99 @@
+/**
+ * Licensed
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r131974209
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java ---
@@ -0,0 +1,353 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r131966882
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java ---
@@ -0,0 +1,353 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r131964579
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java ---
@@ -0,0 +1,353 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/530
@ottobackwards , this is great work! Sorry the review's so long, and it
still isn't quite done. But some good news: I've fully reviewed
- bundles-maven-plugin
- metron-maven
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r131831288
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java ---
@@ -0,0 +1,353 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r131784556
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/util/BundleProperties.java
---
@@ -0,0 +1,248 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r131796392
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/bundle/BundleDetails.java
---
@@ -0,0 +1,189 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r131828675
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java ---
@@ -0,0 +1,353 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r131765763
--- Diff: bundles-lib/README.md ---
@@ -0,0 +1,79 @@
+# Apache Metron Bundles
+
+Apache Metron Bundles and this documentation
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r131787199
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/util/FileSystemManagerFactory.java
---
@@ -0,0 +1,99 @@
+/**
+ * Licensed
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r131786965
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/util/FileSystemManagerFactory.java
---
@@ -0,0 +1,99 @@
+/**
+ * Licensed
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r131831881
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java ---
@@ -0,0 +1,353 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r131826097
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java ---
@@ -0,0 +1,353 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r131815714
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java ---
@@ -0,0 +1,353 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r131771806
--- Diff:
metron-maven-archetypes/metron-maven-parser-extension-archetype/pom.xml ---
@@ -0,0 +1,46 @@
+
+
+http://maven.apache.org/POM
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r131820740
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java ---
@@ -0,0 +1,353 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r131832154
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java ---
@@ -0,0 +1,353 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r131822044
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java ---
@@ -0,0 +1,353 @@
+/*
+ * Licensed to the Apache
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r131793643
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/bundle/Bundle.java ---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software
1 - 100 of 252 matches
Mail list logo
