Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r145811869
--- Diff:
metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.module.ts
---
@@ -0,0 +1,14 @@
+import { NgModule } from '@angular
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r145810773
--- Diff:
metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.component.ts
---
@@ -0,0 +1,101 @@
+/**
+ * Licensed
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r145809924
--- Diff: metron-interface/metron-alerts/src/app/utils/constants.ts ---
@@ -27,5 +30,5 @@ export const ALERTS_COLUMN_NAMES =
'metron-alerts-column-names
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r145809831
--- Diff: metron-interface/metron-alerts/src/app/utils/constants.ts ---
@@ -18,6 +18,9 @@
import {environment} from '../../environments
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r145809660
--- Diff:
metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.component.ts
---
@@ -0,0 +1,101 @@
+/**
+ * Licensed
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r145809162
--- Diff:
metron-interface/metron-alerts/e2e/alerts-list/tree-view/tree-view.e2e-spec.ts
---
@@ -175,7 +175,7 @@ describe('metron-alerts tree view
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/796
I tested this as well. First a couple things I'm curious about:
- when I open the date/time range picker why does it say "now/d"? I would
expect just "now" or &quo
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/806
METRON-1262: Unable to add comment for a alert in a meta-alert
## Contributor Comments
This PR fixes a bug in the ElasticsearchMetaalertDao class (description is
in the Jira). I verified
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/802
Feedback has been addressed. Take another look when you get a chance.
---
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/802#discussion_r145532292
--- Diff:
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchMetaAlertIntegrationTest.java
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/802#discussion_r145427376
--- Diff:
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchMetaAlertIntegrationTest.java
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/802#discussion_r145423988
--- Diff:
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchMetaAlertIntegrationTest.java
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/802#discussion_r145424237
--- Diff:
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchMetaAlertIntegrationTest.java
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/802
METRON-1255: MetaAlert search is not filtering on status
## Contributor Comments
This PR primarily fixes filtering on metaalert status but also includes a
couple other minor fixes as well
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/768#discussion_r144639257
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alerts-list/tree-view/tree-view.component.ts
---
@@ -0,0 +1,319 @@
+/**
+ * Licensed
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/787
+1
---
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/787#discussion_r144306688
--- Diff: metron-interface/metron-alerts/src/app/service/update.service.ts
---
@@ -32,13 +33,31 @@ export class UpdateService
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/787#discussion_r143735130
--- Diff: metron-interface/metron-alerts/src/app/service/update.service.ts
---
@@ -32,13 +33,31 @@ export class UpdateService
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/768
Thanks @iraghumitra the bulk actions are working now. Just need to address
the e2e test suggestions and I think this will be good to go.
---
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/786
METRON-1231: Separate Sensor name and topic in the Management UI
## Contributor Comments
This PR separates sensor name and sensor Kafka topic in both the REST app
as well as the Management UI
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/784
METRON-1229: Management UI type is part of the declarations of 2 modules
## Contributor Comments
The PR fixes an intermittent bug that was recently introduced. This can be
verified
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/768
With respect to displaying field names, I think it's going to be tough
coming up with a strategy that solves every case. This will likely depend on a
user's preference and is subjective anyways
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/768
I spun this up in full dev and it's working pretty well. The only
functional issue I could find was that the bulk actions are disabled when
alerts are selected in group/tree view. This is likely
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/768#discussion_r142454390
--- Diff:
metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/metaalert/MetaAlertCreateResponse.java
---
@@ -28,4 +28,4
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/768#discussion_r142454353
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/MetaAlertStatus.java
---
@@ -31,4 +31,4 @@
public
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/737
Ok I reverted the SensorParserConfig class so that defaults are not
provided for numWorkers and numAckers. I also added help text to make it clear
to the user what happens when these are not set
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r142419159
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -35,7 +36,7
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/737
I moved the default values to the storm config and changed getNumWorkers
and getNumAckers to return the values in the storm config if
numWorkers/numAckers is null. Is this what you were thinking
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r142237205
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -35,7 +36,7
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r142235450
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -35,7 +36,7
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/779
The latest commit replaces the getFullMessage call with
ExceptionUtils.getStackTrace. Hopefully that addresses the recursion issue.
As for security @ottobackwards, I'm not sure what
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r141974727
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -45,4 +45,14 @@ private
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r141968868
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -45,4 +45,14 @@ private
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r141861097
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -45,4 +45,14 @@ private
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r141860594
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -45,4 +45,14 @@ private
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/779
METRON-1218: Metron REST should return better error messages
## Contributor Comments
This PR improves the error handling in the REST app and adds logging to
failed searches
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/778
No problem. Just added a commit that mentions the MPack in the README.
Let me know if that works.
---
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/778
METRON-1208: MPack for Alerts UI
## Contributor Comments
The PR completes the MPack for Alerts UI. This can be verified in full dev
by spinning up full dev and navigating to the Alerts UI
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/773
The latest commit should address all the PR comments.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/771
The latest commit adds a "Session Expired" message on the login page and
also applies the fix to the Management UI. You will notice the 2 files look
identical between metron-alerts
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/773
METRON-1206: Make alerts UI conform to ops UI for install
## Contributor Comments
This PR is a precursor to
[METRON-1207](https://issues.apache.org/jira/browse/METRON-1207) and
[METRON-1208
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/771
That's not a bad idea. It occurs to me that this issue may also exist with
the Management UI and should be fixed there as well. Stay tuned.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/762
This PR is already fairly large and I don't see the "Hide
Dismissed/Resolved Alerts" feature as being a trivial addition. Can we do that
as a follow-on?
---
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/771
METRON-1204: UI does not time out after being idle, but stops functioning
## Contributor Comments
This fix was verified running the Alerts UI against full dev. To test this
fix, spin up full
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/762
The latest commit merges in master and addresses your feedback
@iraghumitra. I solved the issue in my previous comment by pausing anytime a
checkbox is checked and resuming when all checkboxes
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/762
I researched the saveRefreshState() and restoreRefreshState() addition and
it uncovered a bug which then uncovered a problem with how our UI works.
The bug was that the selectedAlerts
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/756
Lots of improvements in this PR, I like it. Spun this up in full dev and
everything continues to work. Nice job. +1
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/757
Spun it up again in full dev, setup MySQL and everything works as it
should. Thanks so much @justinleet for fixing this! Turned out great. +1
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/737
Changing numWorkers and numAckers default values from null to 1 had the
unintended consequences of breaking the ParserTopologyCliTest. This is because
they can no longer be overriden by setting
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/737
Just pushed out a commit that addresses @ottobackwards comments and fixes
the NUM_WORKERS and NUM_ACKERS issue. I also added a warning that appears when
a storm setting changes, telling the user
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/694
The latest commit merges in master and also refactors this endpoint into
the AlertService and AlertController classes that were recently accepted into
master. I think this will make it cleaner
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/737#discussion_r139815871
--- Diff:
metron-interface/metron-config/src/app/sensors/sensor-parser-config/sensor-parser-config.component.ts
---
@@ -409,12 +403,17 @@ export class
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/737#discussion_r139815513
--- Diff:
metron-interface/metron-config/src/app/sensors/sensor-parser-config-readonly/sensor-parser-config-readonly.component.spec.ts
---
@@ -301,7
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/737
Thank you for the feedback @nickwallen.
On points 1-3 and 5, these could be applied to any panel in the management
UI. They all work the same. My opinion is that correct design
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/757#discussion_r139249622
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/rest_commands.py
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/757#discussion_r139245252
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/params_linux.py
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/749
I spun this up in full dev and it worked as expected. Thanks for the
contribution. +1
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/734
Tested this again in full dev and now the default sort is working as
expected (due to timestamp being added). +1 from me. Nice job.
---
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/734#discussion_r138064525
--- Diff:
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchMetaAlertIntegrationTest.java
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/700
Thanks @iraghumitra. I tested this in full dev and everything worked as
expected. +1
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/702
The latest commit should address the feedback so far. I don't feel like
the top hits aggregation is necessary at this point but it could be in the
future. I would prefer to wait and keep
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/702#discussion_r137893211
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/config/IndexConfig.java
---
@@ -56,8 +52,10 @@ public IndexDao indexDao
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/702#discussion_r137893133
--- Diff:
metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/search/GroupOrderType.java
---
@@ -0,0 +1,39
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/702#discussion_r137893095
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java
---
@@ -330,43 +334,112 @@ public
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/734
Great job on this. I spent a lot of time testing and had trouble finding
anything wrong. The one thing I did notice was that the "timestamp" field was
missing from documents in the
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/734#discussion_r137889738
--- Diff:
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchMetaAlertIntegrationTest.java
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/734#discussion_r137874476
--- Diff: metron-interface/metron-rest/README.md ---
@@ -361,6 +363,21 @@ Request and Response objects are JSON formatted. The
JSON schemas are available
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/737
METRON-1161: Add ability to edit parser command line options in the
management UI
## Contributor Comments
This PR is a follow up to https://github.com/apache/metron/pull/717 and
exposes
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/729
Just pushed out a small change to support parameter substitution in the
metron_temp_grok_path parameter. I verified this in full dev as well. I also
verified the temporary files are being
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/729#discussion_r137362276
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-rest-env.xml
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/729#discussion_r137354784
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-rest-env.xml
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/729
Please see https://issues.apache.org/jira/browse/METRON-1150 for a
description of why this is needed. Let me know if that isn't clear enough or
you need more info.
---
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/729#discussion_r137353301
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-rest-env.xml
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/729#discussion_r137284827
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-rest-env.xml
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/700#discussion_r137118513
--- Diff:
metron-interface/metron-alerts/src/app/utils/metron-rest-api-utils.ts ---
@@ -0,0 +1,40 @@
+/**
+ * Licensed to the Apache Software
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/700#discussion_r137118292
--- Diff:
metron-interface/metron-alerts/src/app/service/cluster-metadata.service.ts ---
@@ -16,14 +16,20 @@
* limitations under the License
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/700#discussion_r137118074
--- Diff: metron-interface/metron-alerts/src/app/service/alert.service.ts
---
@@ -39,21 +41,31 @@ export class AlertService {
private
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/724
I spun this up in full dev and it worked as advertised. I was able to
easily get the "geo_hash_parser" and "geo_hash_enrichment" fields correctly
populated in ES. I als
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/711
The latest commit addresses the escalateMany request.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/712
I'm fine with these errors being addressed in a future PR. +1
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/729
Is it possible to submit smaller PRs for fixes like these that you've
already done? I'm sure there are several like this in your feature branch that
are valuable. It would also make it easier
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/729
Is `/apps/metron/patterns/tmp` a reasonable place to keep temporary grok
files? Is there another location that would be better?
---
If your project is set up for it, you can reply to this email
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/730
METRON-1151: Grok patterns in HDFS should be owned by metron
## Contributor Comments
This one should be pretty self-explanatory. To verify in full-dev, run
`hdfs dfs -ls /apps/metron
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/729
METRON-1150: REST parseMessage endpoint fails with Unable to load from either classpath or HDFS
## Contributor Comments
This PR fixes a regression in the REST app related to parsing sample
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/711
I don't think it matters that much but I'm leaning towards keeping the REST
layer simple. The Alerts UI will be responsible for adding other annotations
so it's not a stretch to add these too
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/711
I create a Jira for this:
https://issues.apache.org/jira/browse/METRON-1147. It's could probably use
some more description but this is a start.
---
If your project is set up for it, you can
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/694#discussion_r136439615
--- Diff:
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/AlertsProfileControllerIntegrationTest.java
---
@@ -0,0 +1,226
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/717
Looks good +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/726
Tested this in full dev with Kerberos enabled. The profiler topology
starts up without issue and data appears in HBase after creating a profile. +1
---
If your project is set up for it, you can
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/717#discussion_r136208967
--- Diff: metron-platform/metron-parsers/README.md ---
@@ -103,6 +103,15 @@ then it is assumed to be a regex and will match any
topic matching the pattern
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/717#discussion_r136208891
--- Diff:
metron-platform/metron-management/src/test/java/org/apache/metron/management/ConfigurationFunctionsTest.java
---
@@ -81,7 +81,15 @@ private
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/694#discussion_r135909951
--- Diff:
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/AlertsProfileControllerIntegrationTest.java
---
@@ -0,0 +1,226
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/717
I tested this in full dev and everything worked as advertised. The only
major issue I see is that the num workers property is missing from
SensorParserConfig. I feel like this is one of the most
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/709
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/712
I tested this in full dev and everything works. The only issue I'm seeing
is during the rpm build. There are several instances of this error being
reported by rpmlint:
"This text
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/709
I ran this up in full dev and it worked. However when I was looking at the
Profiler tab in Ambari I noticed "Number of Acker Executors" was set to 0.
Shouldn't this be set to
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/711#discussion_r135828943
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/AlertServiceImpl.java
---
@@ -0,0 +1,57
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/711#discussion_r135806560
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/AlertServiceImpl.java
---
@@ -0,0 +1,57
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/711#discussion_r135791883
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/AlertServiceImpl.java
---
@@ -0,0 +1,57
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/709
I tested this in full dev again and it looks good after the recent changes.
@nickwallen brings up a good point and I would prefer we fix it now because
it's an easy one line change. I added
201 - 300 of 453 matches
Mail list logo
