Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/817
If the indexing start doesn't install the templates because ES is down or
something, will they be installed if restarted and ES is available, or is it
one shot, pass or fail.
---
Github user anandsubbu commented on the issue:
https://github.com/apache/metron/pull/817
You're right @nickwallen , it wouldn't work. I reworked on the patch and
here are the latest changes:
- moved the ES template installation back to the Indexing "start" method
- use a flag
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/814#discussion_r147568002
--- Diff:
metron-stellar/stellar-common/src/main/antlr4/org/apache/metron/stellar/common/generated/Stellar.g4
---
@@ -67,6 +67,10 @@ ELSE : 'ELSE' |
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/814#discussion_r147568099
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/MatchTest.java
---
@@ -0,0 +1,202 @@
+/*
+ *
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/814#discussion_r147568117
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/MatchTest.java
---
@@ -0,0 +1,202 @@
+/*
+ *
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/814#discussion_r147568088
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/MatchTest.java
---
@@ -0,0 +1,202 @@
+/*
+ *
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/814#discussion_r147567984
--- Diff: metron-stellar/stellar-common/README.md ---
@@ -100,6 +102,28 @@ In the core language functions, we support basic
functional programming
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/814#discussion_r147568062
--- Diff:
metron-stellar/stellar-common/src/main/antlr4/org/apache/metron/stellar/common/generated/Stellar.g4
---
@@ -272,4 +278,30 @@
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/814#discussion_r147568147
--- Diff: metron-stellar/stellar-common/README.md ---
@@ -100,6 +102,28 @@ In the core language functions, we support basic
functional programming
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/814
@jjmeyer0 thanks for the tests. The issue is that we call validate and
then parse. When we call validate, we resolve all vars to NULL. This means
that the clauses in these failures are
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/814
Thanks, I added those tests to the test class, and these fail:
```java
@Test
@SuppressWarnings("unchecked")
public void testVariableOnlyNoDefault() {
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/814#discussion_r147567887
--- Diff: metron-stellar/stellar-common/README.md ---
@@ -100,6 +102,28 @@ In the core language functions, we support basic
functional programming
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/814
So for example:
```java
/*
curr is the current value on the stack. This is the non-deferred
actual evaluation for this expression
and with the current
Github user jjmeyer0 commented on a diff in the pull request:
https://github.com/apache/metron/pull/814#discussion_r147556465
--- Diff: metron-stellar/stellar-common/README.md ---
@@ -100,6 +102,28 @@ In the core language functions, we support basic
functional programming primitiv
Github user jjmeyer0 commented on a diff in the pull request:
https://github.com/apache/metron/pull/814#discussion_r147544977
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/MatchTest.java
---
@@ -0,0 +1,202 @@
+/*
+ *
Github user jjmeyer0 commented on a diff in the pull request:
https://github.com/apache/metron/pull/814#discussion_r147543792
--- Diff:
metron-stellar/stellar-common/src/main/antlr4/org/apache/metron/stellar/common/generated/Stellar.g4
---
@@ -67,6 +67,10 @@ ELSE : 'ELSE' |
Github user jjmeyer0 commented on a diff in the pull request:
https://github.com/apache/metron/pull/814#discussion_r147555077
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/MatchTest.java
---
@@ -0,0 +1,202 @@
+/*
+ *
Github user jjmeyer0 commented on a diff in the pull request:
https://github.com/apache/metron/pull/814#discussion_r147544129
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/MatchTest.java
---
@@ -0,0 +1,202 @@
+/*
+ *
Github user jjmeyer0 commented on a diff in the pull request:
https://github.com/apache/metron/pull/814#discussion_r147556583
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/StellarCompiler.java
---
@@ -105,59 +107,77 @@ public Object
Github user jjmeyer0 commented on a diff in the pull request:
https://github.com/apache/metron/pull/814#discussion_r147556836
--- Diff:
metron-stellar/stellar-common/src/main/antlr4/org/apache/metron/stellar/common/generated/Stellar.g4
---
@@ -272,4 +278,30 @@ lambda_variable:
Github user jjmeyer0 commented on a diff in the pull request:
https://github.com/apache/metron/pull/814#discussion_r147543426
--- Diff: metron-stellar/stellar-common/README.md ---
@@ -100,6 +102,28 @@ In the core language functions, we support basic
functional programming primitiv
Github user jjmeyer0 commented on a diff in the pull request:
https://github.com/apache/metron/pull/814#discussion_r147557283
--- Diff: metron-stellar/stellar-common/README.md ---
@@ -100,6 +102,28 @@ In the core language functions, we support basic
functional programming primitiv
Github user jjmeyer0 commented on the issue:
https://github.com/apache/metron/pull/814
Also, I don't think there is an issue with the map function directly. It's
actually an issue with the logical_expression `var1` and using/not using a
`default` branch. It seems like the stack isn't
23 matches
Mail list logo
