[GitHub] metron issue #620: Metron-988: UI for viewing alerts generated by Metron

2017-07-26 Thread mraliagha
Github user mraliagha commented on the issue: https://github.com/apache/metron/pull/620 @iraghumitra Have you found any way to manage multiple Elasticsearch endpoints for load-balancing? --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-07-26 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 Thanks for the feedback @mattf-horton, I will go through it all. About tracking changes... I will check and see what there is to pick up. Obviously this was much more current when the PR was

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129736147 --- Diff: bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java --- @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129736002 --- Diff: bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java --- @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129737358 --- Diff: bundles-maven-plugin/src/main/java/org/apache/metron/BundleProvidedDependenciesMojo.java --- @@ -0,0 +1,326 @@ +/* + * Licensed to th

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129737404 --- Diff: bundles-maven-plugin/src/main/java/org/apache/metron/BundleProvidedDependenciesMojo.java --- @@ -0,0 +1,326 @@ +/* + * Licensed to th

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129737037 --- Diff: bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java --- @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129735629 --- Diff: bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java --- @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129735313 --- Diff: bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java --- @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129734935 --- Diff: bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java --- @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129737464 --- Diff: bundles-maven-plugin/src/main/java/org/apache/metron/BundleProvidedDependenciesMojo.java --- @@ -0,0 +1,326 @@ +/* + * Licensed to th

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129737287 --- Diff: bundles-maven-plugin/src/main/java/org/apache/metron/BundleProvidedDependenciesMojo.java --- @@ -0,0 +1,326 @@ +/* + * Licensed to th

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129737424 --- Diff: bundles-maven-plugin/src/main/java/org/apache/metron/BundleProvidedDependenciesMojo.java --- @@ -0,0 +1,326 @@ +/* + * Licensed to th

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129737441 --- Diff: bundles-maven-plugin/src/main/java/org/apache/metron/BundleProvidedDependenciesMojo.java --- @@ -0,0 +1,326 @@ +/* + * Licensed to th

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129736544 --- Diff: bundles-maven-plugin/src/main/java/org/apache/metron/BundleProvidedDependenciesMojo.java --- @@ -0,0 +1,326 @@ +/* + * Licensed to th

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129734358 --- Diff: bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java --- @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129737262 --- Diff: bundles-maven-plugin/src/main/java/org/apache/metron/BundleProvidedDependenciesMojo.java --- @@ -0,0 +1,326 @@ +/* + * Licensed to th

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129735514 --- Diff: bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java --- @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129735790 --- Diff: bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java --- @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129736065 --- Diff: bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java --- @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129734433 --- Diff: bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java --- @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129734214 --- Diff: bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java --- @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129735819 --- Diff: bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java --- @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129736130 --- Diff: bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java --- @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129734993 --- Diff: bundles-maven-plugin/src/main/java/org/apache/metron/BundleMojo.java --- @@ -0,0 +1,742 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] metron issue #671: METRON-1067: Minor Typo Fix

2017-07-26 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/671 Thanks @spencer-hanson ! +1 by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/metron/pull/530 Please remove instances of "incubator" or "incubating" in bundles-lib/, bundles-maven-plugin/, and metron-platform/metron-extensions : ``` bundles-maven-plugin/pom.xml: http://metron

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/metron/pull/530 I'm trying to compare bundle-lib with nifi-nar-utils, and blocked because the code trees under * bundles-lib/src/main/java/org/apache/metron/bundles and * nifi-nar-utils/src/main/java/or

Re: [DISCUSS] Persisting user data

2017-07-26 Thread Matt Foley
There’s a couple other places you could put config info (but maybe not saved searches): - Zookeeper - metron-alerts-ui/config.xml or config.json file - the Ambari database, whichever it happens to be Questions that influence the decision include: 1. Should there be one configuration shared am

[GitHub] metron pull request #672: METRON-1047: REST should use core-site.xml for Had...

2017-07-26 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/672 METRON-1047: REST should use core-site.xml for Hadoop configuration ## Contributor Comments This PR removes the explicit HDFS url property from the REST application and instead relies on core-

[GitHub] metron pull request #607: METRON-982 add new rest api for storm supervisor s...

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/607#discussion_r129718460 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/StormStatusServiceImpl.java --- @@ -17,10 +17,7 @@ */

[GitHub] metron issue #671: METRON-1067: Minor Typo Fix

2017-07-26 Thread lvets
Github user lvets commented on the issue: https://github.com/apache/metron/pull/671 I think this looks good 👍 :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] metron pull request #671: METRON-1067: Minor Typo Fix

2017-07-26 Thread spencer-hanson
GitHub user spencer-hanson opened a pull request: https://github.com/apache/metron/pull/671 METRON-1067: Minor Typo Fix ## Contributor Comments Minor Typo JIRA https://issues.apache.org/jira/browse/METRON-1067 ## Pull Request Checklist Thank you for sub

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/metron/pull/530 @ottobackwards , I am strongly in favor of your decision to keep the bundles-lib and bundles-maven-plugin at the top level. Since they are clones of external functionality, they should be kept

[DISCUSS] Persisting user data

2017-07-26 Thread Ryan Merriman
In anticipation of METRON-988 being merged into master, there will be a need to persist user preferences such as UI layout, saved searches, search history, etc. I think where and how we persist this data should be discussed in order to facilitate a design. This data won't be large in scale and ma

[GitHub] metron issue #607: METRON-982 add new rest api for storm supervisor status

2017-07-26 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/607 I spun this up in full dev and it worked other than "upTime" being null. Pending a few minor suggestions and the upTime fix I'm +1. Nice job. --- If your project is set up for it, you can reply

[GitHub] metron pull request #607: METRON-982 add new rest api for storm supervisor s...

2017-07-26 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/607#discussion_r129692618 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/StormControllerIntegrationTest.java --- @@ -182,6 +185,16 @@ public

[GitHub] metron pull request #607: METRON-982 add new rest api for storm supervisor s...

2017-07-26 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/607#discussion_r129692080 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/StormStatusServiceImpl.java --- @@ -17,10 +17,7 @@ */

[GitHub] metron pull request #607: METRON-982 add new rest api for storm supervisor s...

2017-07-26 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/607#discussion_r129691439 --- Diff: metron-interface/metron-rest-client/src/main/java/org/apache/metron/rest/model/SupervisorStatus.java --- @@ -0,0 +1,127 @@ +/** + * Lice

[GitHub] metron pull request #607: METRON-982 add new rest api for storm supervisor s...

2017-07-26 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/607#discussion_r129690884 --- Diff: metron-interface/metron-rest-client/src/main/java/org/apache/metron/rest/model/SupervisorStatus.java --- @@ -0,0 +1,127 @@ +/** + * Lice

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-07-26 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/metron/pull/530 Hi @ottobackwards , the PR description list of files changed and reasons is _extremely_ helpful, indeed necessary. But the github PR GUI isn't really tuned for handling 400 files even when -- o

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-07-26 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 @mattf-horton I believe https://github.com/apache/nifi/commit/d90cf846b9dcd49acdeac7bb5fcd13ee80dcdba6#diff-83e1afb34470ca47809f82aa1caf2138 is the commit from nifi-nar-utils --- If your proj

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-07-26 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 @mattf-horton I believe the nifi nar maven plugin commit version is fc124e5913019d219b1b7dbf3201713fe3290455 --- If your project is set up for it, you can reply to this email and have you

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-07-26 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r129606801 --- Diff: metron-maven-archetypes/metron-maven-parser-extension-archetype/src/main/resources/archetype-resources/metron-parser-__parserName__/README.md --

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-07-26 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 @mattf-horton branch is up to date as of this morning https://github.com/apache/metron/commit/badc6cf9739a31800abee1cfccbcf9930b130fa7 --- If your project is set up for it, you can reply t

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-07-26 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 https://github.com/apache/metron/pull/530/commits/0d9a43a9393a20309845c668a206005f45ea4617 for our master as of this moment @mattf-horton --- If your project is set up for it, you ca

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-07-26 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/530 @mattf-horton In the PR description there is a list of files changed and the reason for them, does that help? I am going to merge master and resolve conflicts this morning. I have been

[GitHub] metron pull request #670: METRON-1065 grok pattern for cisco asa parser expe...

2017-07-26 Thread basvdl
GitHub user basvdl opened a pull request: https://github.com/apache/metron/pull/670 METRON-1065 grok pattern for cisco asa parser expects syslog pri ## Contributor Comments Cisco ASA logs does not always contain a priority code at the beginnen of the event. Therefore I've change

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-07-26 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r129578981 --- Diff: metron-interface/metron-alerts/src/app/service/elasticsearch-localstorage-impl.ts --- @@ -0,0 +1,294 @@ +/** + * Licensed to the Apache

[GitHub] metron pull request #635: METRON-1018: Integration tests should reference fl...

2017-07-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/635 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...

2017-07-26 Thread iraghumitra
Github user iraghumitra commented on a diff in the pull request: https://github.com/apache/metron/pull/620#discussion_r129569381 --- Diff: metron-interface/metron-alerts/src/app/service/elasticsearch-localstorage-impl.ts --- @@ -0,0 +1,294 @@ +/** + * Licensed to the Apach

[GitHub] metron pull request #643: METRON-1026: threatintel_taxii_load.sh throws exce...

2017-07-26 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/643#discussion_r129532376 --- Diff: metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/nonbulk/taxii/TaxiiLoader.java --- @@ -165,6 +167,19 @@ public s