Github user cestella commented on the issue:
https://github.com/apache/metron/pull/760
Why would those .j2 files be in gitignore?
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/760
Found a possible problem. I was wondering why my changes aren't making it
into my commits for the enrichment properties. There's this
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/764
+1. The release bits seem correct, the site book is correct. Please keep
this +1 in your pocket for 24 hours while the mirrors sync before committing,
@mattf-horton Great job!
---
GitHub user mattf-horton opened a pull request:
https://github.com/apache/metron/pull/764
METRON-1191 update public web site to point at 0.4.1 new release
## Contributor Comments
This is the pro-forma PR to update the Website for our 0.4.1 release.
All but one of the files
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/760
Merge conflicts, of course. Unfortunately, I have an appointment and will
be back in a couple hours to fix.
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/760
Just pushed out a commit to address comments. I added documentation around
the config management lifecycle to the Ambari README. I'm continuing with
testing and will verify Kerberos works as
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/757#discussion_r139249622
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/rest_commands.py
---
@@
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/757#discussion_r139246527
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/params_linux.py
---
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/757#discussion_r139245252
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/params_linux.py
---
@@
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/760
You're never going to believe this, but I found our Ambari docs under, wait
for it, the ambari project in packaging.
https://github.com/apache/metron/tree/master/metron-deployment/packaging/ambari.
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/763
@nickwallen Some of that is provided in metron-indexing/README.md, but I'm
definitely not opposed to fleshing that stuff out more.
---
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/763
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/763
It was hard for me to grok how `ElasticsearchDAO` and
`ElasticsearchMetaAlertDAO` differ and how the `ElasticsearchMetaAlertDAO` uses
another `IndexDAO` under-the-hood. I think more cow bell (I
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/763
Outside of this PR, we might need to better doc the expected behavior for
meta-alerts (or maybe I just need to find the existing docs for that.)
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/763
Correction to what I said earlier: the update side isn't directly actually
controlled by the `ElasticsearchMetaAlertDao` itself, it's controlled by the
`IndexDao`'s building of the document that
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/763#discussion_r139225592
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java
---
@@ -275,13 +275,13
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/763#discussion_r139225095
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java
---
@@ -275,13 +275,13
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/763#discussion_r139223469
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java
---
@@ -275,13 +275,13
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/760
So, it is not uncommon for a PR that has a discussion thread backing up
it's approach to reference that thread to point out the public discussion when
it has occurred. Since this thread
Good point, I can take that task re migrating the revision history of the
folder.
Jon
On Fri, Sep 15, 2017, 12:14 Nick Allen wrote:
> Hi Jon -
>
> I agree with you on the approach. We should first copy everything as it is
> to the new repo. We should maintain the revision
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/760
Just pushed a unit test fix to get the build working again. The other code
changes and doc requests from @ottobackwards and @justinleet soon to follow.
Thanks for the feedback guys! @ottobackwards
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/760#discussion_r139194942
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -226,6 +276,44 @@ public
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/760#discussion_r139194807
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -226,6 +276,44 @@ public
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/760#discussion_r139194237
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -226,6 +276,44 @@ public
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/760#discussion_r139194190
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/enrichment_commands.py
---
@@
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/760
> Can you reference :
http://mail-archives.apache.org/mod_mbox/metron-dev/201701.mbox/%3cCAPpQHK1svDAx7R-s7x2Q0kJR6=5d+KDmR6a+ZmSo-5=wcmo...@mail.gmail.com%3e
> Which I think is the discuss
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/760#discussion_r139190738
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -76,7 +80,7 @@ public static
Hi Jon -
I agree with you on the approach. We should first copy everything as it is
to the new repo. We should maintain the revision history too. I'm sure
there is a way to do it, but would have to research a bit. Then we apply
your changes on top of that.
Thanks
On Thu, Sep 14, 2017 at
GitHub user justinleet opened a pull request:
https://github.com/apache/metron/pull/763
METRON-1190: Fix Meta Alert Type handling in calculation of scores
## Contributor Comments
Migrating the create method to not pass anything as an object array and
instead to use a list. At
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/759
---
Github user anandsubbu commented on the issue:
https://github.com/apache/metron/pull/759
+1 (non-binding)
Indeed, this was a tricky one. Thank you @nickwallen for your root cause
and fix!! I spun up a 12 node cluster with this patch, kerberized the cluster
and confirmed that
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/759
Thanks to @anandsubbu and @justinleet for the assistance on this one. This
was tough to track down.
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/759
+1 by inspection. This is a good catch to have made, thanks!
---
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/760#discussion_r139172028
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -346,19 +434,56 @@ public
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/760#discussion_r139171388
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -226,6 +276,44 @@ public
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/760#discussion_r139171727
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -346,19 +434,56 @@ public
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/760#discussion_r139160248
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/enrichment_commands.py
---
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/760#discussion_r139170122
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -226,6 +276,44 @@ public
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/760#discussion_r139172458
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -401,7 +530,16 @@ else if
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/760#discussion_r139170907
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -226,6 +276,44 @@ public
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/668
I am +1 on this, thanks for the contribution. Looks good to me. @cestella
do you need to look?
---
True, I was just throwing this out there.
We DO have implicit owners for certain things however.
contrib/** ( the docker stuff ) is an example where this would make sense.
Also, I don’t think any committer would commit a pr against Profiler
without your input,
or against Stellar without
Github user dbist commented on the issue:
https://github.com/apache/metron/pull/668
@ottobackwards please review
---
-1 IMHO
I do not want to see hard dependencies on anyone. Life happens sometimes,
but the project has to keep moving.
Also, I don't want to see certain parts of the project that are only known
by a few individuals. While I don't think this Github feature directly
leads to that, it makes it
https://github.com/blog/2392-introducing-code-owners
Has anyone looked at this? Do we have any interest?
GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron/pull/761
METRON-1143 [FEATURE BRANCH] [NO-MERGE until PR#747] Management UI Support
for Parser Extensions
## Contributor Comments
This PR introduces Management UI support for parser extensions.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/760
Thanks for the contribution! A couple of questions before I try to review:
- Can you reference :
47 matches
Mail list logo