GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/960
METRON-1424: Kerberos: Solr
## Contributor Comments
This PR adds Kerberos support for Solr in Metron. This has been verified
in full dev using the following steps:
1. Spin up full
Github user merrimanr closed the pull request at:
https://github.com/apache/metron/pull/957
---
Github user merrimanr closed the pull request at:
https://github.com/apache/metron/pull/945
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/949
+1 thanks!
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/957
I've been maintaining this branch for a while and have been merging in
other branches before they were committed to master. I think that's why you
see all these commits. I merged in feature
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/957
METRON-1482: Update REST to work with Solr
## Contributor Comments
This PR updates the REST start script to properly include the correct
indexing jar on the classpath depending
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/949
I still see a SHUFFLE grouping (spout -> enrichmentSplit) in the legacy
enrichment topology flux file. Maybe we end up switching to the new enrichment
topology so not important in that case.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/949
There are also shuffle groupings in the enrichment and profiler topologies.
Do we want to update those too?
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/952
I think we are on board with switching to yarn so no concerns there. There
was a discussion on it but if anyone now feels differently, speak up.
Sounds like we still have a lot of work
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/952#discussion_r172937150
--- Diff: metron-interface/metron-config/package.json ---
@@ -33,6 +28,11 @@
"@angular/platform-browser": "2.0.0",
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/952#discussion_r172934046
--- Diff: metron-interface/metron-config/package.json ---
@@ -33,6 +28,11 @@
"@angular/platform-browser": "2.0.0",
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/952
I'm having trouble understanding what this PR actually does. I see that
package-lock.json was removed and yarn.lock was added. Is that all that's
needed to switch to yarn? Do we need to also
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/952#discussion_r172927751
--- Diff: metron-interface/metron-alerts/package.json ---
@@ -27,8 +27,8 @@
"core-js": "^2.4.1",
&qu
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/952#discussion_r172927486
--- Diff: metron-interface/metron-config/package.json ---
@@ -33,6 +28,11 @@
"@angular/platform-browser": "2.0.0",
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/950
I ran this up in full dev and tested several different features. I could
not find any regressions. Thanks @xyztdanid4! +1
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/943
I spun this up in full dev and everything worked as expected. The
organization looks good to me and I can't find anything wrong with it. +1
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/941
Sorry I should have documented this better in the PR description. The
docker-machine ip address needs to be substituted in ElasticsearchTestUtils
temporarily if you want to run this on your local
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/853
Any other feedback @ottobackwards or is this ready to go?
---
Github user merrimanr closed the pull request at:
https://github.com/apache/metron/pull/934
---
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/945
METRON-1464: Convert schemas to be compatible with Solr 5.5.2
## Contributor Comments
This PR makes the Solr schema compatible with Solr 5.5.2. The client code
worked as is (compiled
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/940
I tested this in full dev and worked as expected. +1
---
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/934#discussion_r170365518
--- Diff: metron-platform/metron-solr/src/main/scripts/create_collection.sh
---
@@ -0,0 +1,27 @@
+#!/bin/bash
+#
+# Licensed to the Apache
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/934#discussion_r170272344
--- Diff: metron-platform/metron-solr/src/main/scripts/create_collection.sh
---
@@ -0,0 +1,27 @@
+#!/bin/bash
+#
+# Licensed to the Apache
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/853#discussion_r170120909
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/AlertServiceImpl.java
---
@@ -37,15 +47,21 @@
@Service
Github user merrimanr closed the pull request at:
https://github.com/apache/metron/pull/858
---
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/941
METRON-1355: Convert metron-elasticsearch to new infrastructure
## Contributor Comments
This PR switches metron-elasticsearch integration tests from using
in-memory components to the e2e
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/924
+1 pending @cestella's approval. Thanks @ottobackwards.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/895
+1 by inspection. Thanks @MohanDV!
---
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/853#discussion_r169455383
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/AlertServiceImpl.java
---
@@ -37,15 +47,21 @@
@Service
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/853
I took @ottobackwards's suggestion and added a "type" parameter that can be
used to independently manage user settings for different types of clients. I
moved the users settings for the
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/853#discussion_r168817020
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/config/HBaseConfig.java
---
@@ -0,0 +1,61 @@
+/**
+ * Licensed
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/853#discussion_r168816712
--- Diff:
metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/search/SearchRequest.java
---
@@ -101,16 +99,16 @@ public void
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/853#discussion_r168816212
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/rest_commands.py
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/853
I think it's a fair question @ottobackwards. Anything that might affect
how the HBase table is laid out should be worked out now or we're back to
altering tables during upgrades. Currently
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/853
The latest commit switches the persistence for storing user settings to
HBase rather than a RDBMS as discussed on the dev list. Instead of fields
being stored in RDBMS columns, the user settings
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/937
I verified this works in full dev. Thanks for fixing this! +1
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/934
I agree with @justinleet. I would prefer we use Solr 6+. At some point
HDP Search will move to 6+ and we can easily switch to the Mpack since
installing Solr is a manual step now. Happy
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/934
METRON-1423: Ambari work to handle Solr configuration
## Contributor Comments
This PR allows support for Metron-related Solr configuration and management
through Ambari. That does
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/929
Yes I pushed the change to zookeeper with Swagger. Probably just a minor
detail he missed in his instructions.
You can use either "localhost:9983" or "node1:9983&
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/929
+1 from me pending approval from others. Tested this in full dev and
worked fine.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/932
I spun this up and I know longer see the Indexing component as red. +1 as
soon as @nickwallen's build finishes and it's working there too.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/922
Looks good to me. +1
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/922
I would say collection for each parser and an error collection. It's
similar to ES templates where we define fields, types, etc.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/922
The errors I found happened when I tried to create collections with each
schema. The error related to the `guid` field happens because it is defined as
the unique key but not included in the list
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/922
I tested this in full dev using the install script in
https://github.com/apache/metron/pull/918. I was able to create collections
for each schema except for "error". For that to work p
Github user merrimanr closed the pull request at:
https://github.com/apache/metron/pull/911
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/918
I tested it out and worked fine. I think it's a good start. +1 as long as
other commenters are satisfied.
---
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/911#discussion_r165142091
--- Diff:
metron-platform/metron-solr/src/test/java/org/apache/metron/solr/integration/components/SolrComponent.java
---
@@ -158,4 +162,16 @@ public
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/911#discussion_r165141979
--- Diff:
metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrSearchDao.java
---
@@ -0,0 +1,315 @@
+/**
+ * Licensed
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/911#discussion_r165142049
--- Diff:
metron-platform/metron-solr/src/test/java/org/apache/metron/solr/integration/SolrSearchIntegrationTest.java
---
@@ -0,0 +1,152
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/911#discussion_r165141915
--- Diff:
metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrSearchDao.java
---
@@ -0,0 +1,315 @@
+/**
+ * Licensed
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/911#discussion_r165141548
--- Diff:
metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrSearchDao.java
---
@@ -0,0 +1,315 @@
+/**
+ * Licensed
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/911#discussion_r165141296
--- Diff:
metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/SearchIntegrationTest.java
---
@@ -655,83 +699,54 @@ public void
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/911#discussion_r165141322
--- Diff:
metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrDao.java
---
@@ -0,0 +1,118 @@
+/**
+ * Licensed to the Apache
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/917
METRON-1435: Management UI cannot save json objects in advanced config
## Contributor Comments
This PR fixes a bug in the Management UI that limits a user to only
entering strings
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/911#discussion_r164881484
--- Diff:
metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/SearchIntegrationTest.java
---
@@ -443,11 +495,11 @@ public void
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/911#discussion_r164881237
--- Diff:
metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/search/SearchDao.java
---
@@ -0,0 +1,34
Github user merrimanr closed the pull request at:
https://github.com/apache/metron/pull/911
---
GitHub user merrimanr reopened a pull request:
https://github.com/apache/metron/pull/911
METRON-1419: Create a SolrDao
## Contributor Comments
This PR is an initial attempt at creating a SolrDao that implements the
IndexDao interface, is functionally equivalent
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/911
METRON-1419: Create a SolrDao
## Contributor Comments
This PR is an initial attempt at creating a SolrDao that implements the
IndexDao interface, is functionally equivalent
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/892
+1 by inspection. Thanks for fixing this @MohanDV. The original test
didn't even make sense.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/898
+1 by inspection. Thanks @MohanDV!
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/909
I think this is useful outside of any Solr work and I intended for it to go
into master.
---
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/909#discussion_r163859481
--- Diff:
metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/SearchIntegrationTest.java
---
@@ -724,6 +503,52 @@ public void
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/909#discussion_r163859462
--- Diff:
metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/SearchIntegrationTest.java
---
@@ -724,6 +503,52 @@ public void
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/909
METRON-1429: SearchIntegrationTest refactor
## Contributor Comments
This PR cleans up SearchIntegrationTest which will make it easier to create
a Solr implementation. Changes include
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/853
I will address 6 shortly. For 5, should we explore a more flexible store
in this PR? Or at least validate that an RDBMS is the right choice? I think
this is something we should tackle now
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/891
I think a separate PR is fine. Can you at least move it to a separate
method?
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/853
Here are my thoughts on your responses.
1. I think we're in agreement. This is how this PR currently works.
2. No, saved searches are currently stored client-side. I think the plan
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/891
@MohanDV this is a good start and will be a nice feature to have. I have a
couple suggestions.
First, can we move this to it's own function/endpoint? I think this would
be useful
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/853
Done
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/840
I ran this up in full dev again and verified the e2e tests now work similar
to how they do in master. I also manually tested several other areas including
the Alerts UI, Kibana and Swagger
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/786
We don't have e2e tests for the management UI. We do have unit tests and I
added tests for these fixes there.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/786
@justinleet 1, 2, and 3 have been addressed with the latest commit. I also
added a couple unit tests for good measure.
I wasn't able to easily reproduce 4 so I didn't fix that one
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/884
I spun this up again and all the issues I found have been resolved. Great
work. +1
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/786
I believe 2 and 4 are preexisting but I'm happy to fix them here. Will
update when I have resolved these issues.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/840
I spun this up in full dev and spent all day testing it. From a functional
perspective, I can not find anything wrong with it. I ran through the test
plan in this PR and everything worked
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/884
I also noticed that functions returning a list only display the first item
in both the shell and Zeppelin output.
For example, the expression `MAP([ 'foo', 'bar'], (x) -> TO_UPPE
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/884
I think this is an excellent start. So far I have only reviewed it from a
user perspective and it's working well so far.
I've spun it up in full dev (not sure that's even necessary
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/831
I ran this up in full dev and everything worked as advertised. I only
noticed a couple minor issues and left comments for those.
I also am a little confused by the ra/batch vs es/hdfs
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/831#discussion_r159322924
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/templates/hdfs.properties.j2
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/831#discussion_r159321881
--- Diff:
metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/integration/IndexingIntegrationTest.java
---
@@ -197,9 +140,7
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/886
METRON-1385: Missing "properties" in index template causes
ElasticsearchColumnMetadataDao.getColumnMetadata to fail
## Contributor Comments
A bug was recently discovered that ca
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/857
@justinleet I believe @iraghumitra is still working on the
SELENIUM_PROMISE_MANAGER change proposed above but I will defer to him.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/858
@cestella are you good with merging this in to the feature branch? I
believe I addressed your comments.
---
Github user merrimanr closed the pull request at:
https://github.com/apache/metron/pull/858
---
GitHub user merrimanr reopened a pull request:
https://github.com/apache/metron/pull/858
METRON-1344: Externalize the infrastructural components using integration
tests
## Contributor Comments
This PR will add infrastructure to our Travis build that will allow the
Alerts UI
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/859#discussion_r156744095
--- Diff: metron-deployment/amazon-ec2/README.md ---
@@ -126,6 +126,10 @@ To provision only subsets of the entire Metron
deployment, Ansible tags can be s
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/863
I would like to hear feedback from @ottobackwards on other required fields
but this looks good to me otherwise.
---
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/863#discussion_r156674159
--- Diff:
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/bolt/BulkMessageWriterBolt.java
---
@@ -229,17 +239,30 @@ public void
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/834
After reading this whole thread I agree with @ottobackwards. If we
installed and started all services and THEN installed our parsers separately
this whole issue goes away. If a parser's template
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/853
Ambari does not manage this config. It is only included in the base
application.yml as a default setting. I don't feel like this setting should be
in Ambari for a couple reasons: changing
GitHub user merrimanr reopened a pull request:
https://github.com/apache/metron/pull/858
METRON-1344: Externalize the infrastructural components using integration
tests
## Contributor Comments
This PR will add infrastructure to our Travis build that will allow the
Alerts UI
Github user merrimanr closed the pull request at:
https://github.com/apache/metron/pull/858
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/853
Each environment will have it's own application.yaml. Full dev has one,
our testing environment has one, Ambari ships one etc. There is also a base
application.yaml that has the defaults
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/858#discussion_r156215449
--- Diff: metron-interface/metron-alerts/protractor.conf.js ---
@@ -25,27 +25,28 @@ var SpecReporter =
require('jasmine-spec-reporter').SpecReporter
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/858#discussion_r156215392
--- Diff:
metron-interface/metron-alerts/e2e/alerts-list/configure-table/configure-table.e2e-spec.ts
---
@@ -58,26 +58,26 @@ describe('metron-alerts
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/858#discussion_r156215355
--- Diff:
metron-interface/metron-alerts/e2e/alerts-list/configure-table/configure-table.e2e-spec.ts
---
@@ -47,7 +47,7 @@ describe('metron-alerts
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/858
I agree with everything that has been said. I will address the minor
changes @cestella suggested and start the discussion thread. Will METRON-1344
work as the base Jira for the feature branch?
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/858
I created a feature branch called "feature/METRON-1344-test-infrastructure"
and switched the base of this PR to that instead of master. What is the next
step?
---
1 - 100 of 453 matches
Mail list logo
