Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/858
As long as breakpoints are limited to code we maintain in Metron, I think
it's just a matter of documenting how to set it up. For example, I run REST
locally in Intellij and debugging works fine
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/858
Point taken on maintaining 2 different solutions. Which services would
people want to enable remote debugging on? I've only ever debugged Metron code
so I don't know which services are important
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/858
@ottobackwards I don't see anything obviously wrong. Maybe you could try
pulling the latest commits or copying the one here:
https://github.com/merrimanr/incubator-metron/blob/e2e-in-travis
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/858
Docker Compose provides a CLI just like vagrant does:
https://docs.docker.com/compose/reference/overview/. I would be happy to wrap
those commands in easy to understand scripts.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/858
I would love to have a Debugging readme that is even more comprehensive
than just integration tests. Being able to easily debug is important to me and
I do it all the time.
I had to do
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/858
Doesn't necessarily have to be Docker but yes you would have to start
something up. That step is now outside of the integration tests.
We could keep the current in memory code and offer
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/858
@ottobackwards I also added a way to run the e2e tests locally. Once your
Docker app is up and running locally, get the $DOCKER_HOST ip address and
replace "localhost" with that
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/858
@justinleet latest commit includes the changes I had to make to switch a
preexisting integration test to the new infrastructure. I verified it works
locally, we'll see how it goes with Travis
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/858
Sure a discussion on that topic is fine with me. I'm referring to the
existing integration tests.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/858
@justinleet I think that is a great idea. I didn't do it initially to keep
the size of this PR modest but I can add it in (we can always roll it back and
move it to another PR if we want). I'll
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/858
Sorry @ottobackwards, you're right the instructions are a little vague.
First, `metron-contrib/metron-docker-e2e/compose` is the directory you should
be in. I should have added
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/858#discussion_r155339646
--- Diff: metron-interface/metron-alerts/pom.xml ---
@@ -130,4 +146,44 @@
+
+
+
+ e2e
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/858#discussion_r155339627
--- Diff: metron-interface/metron-alerts/e2e/utils/e2e_util.ts ---
@@ -46,25 +48,53 @@ export function waitForStalenessOf (_element
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/857#discussion_r155261159
--- Diff: metron-interface/metron-alerts/src/app/utils/constants.ts ---
@@ -38,5 +38,6 @@ export let TREE_SUB_GROUP_SIZE = 5;
export let
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/858
METRON-1344: Externalize the infrastructural components using integration
tests
## Contributor Comments
This PR will add infrastructure to our Travis build that will allow the
Alerts UI e2e
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/857
Took a first pass at this and I feel like the e2e tests are much improved.
Great progress and good job so far. I was able to get several successful runs
whereas before it was difficult to get
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/857#discussion_r155067123
--- Diff: metron-interface/metron-alerts/src/app/utils/constants.ts ---
@@ -38,5 +38,6 @@ export let TREE_SUB_GROUP_SIZE = 5;
export let
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/853
METRON-1337: List of facets should not be hardcoded
## Contributor Comments
This PR makes the list of facet fields in the Alerts UI configurable.
There is now a "search.facet.fields&quo
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/803
I agree with @nickwallen. I think we're good to merge this as long as e2e
tests are being addressed in a separate PR. +1
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/803
Most of the functional tests worked for me as well. I was able to get the
e2e tests to pass after several runs with the exception of a time picker test
that I believe is due to a timezone issue
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/843
Sorry I understand now. Yes I did end up running this in full dev. I
don't mind doing it again to make sure.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/843
The latest commit only includes comments and an additional LOG statement.
I didn't think rebuilding full dev was necessary.
---
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/843#discussion_r152347240
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/SearchServiceImpl.java
---
@@ -96,6 +96,11 @@ public
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/843#discussion_r152347150
--- Diff:
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/SearchControllerIntegrationTest.java
---
@@ -132,6 +132,30
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/843#discussion_r152347116
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/SearchServiceImpl.java
---
@@ -96,6 +96,11 @@ public
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r152311299
--- Diff:
metron-interface/metron-alerts/e2e/alerts-list/meta-alerts/meta-alert.po.ts ---
@@ -0,0 +1,43 @@
+/**
+ * Licensed to the Apache
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/803
I've verified the bug reported by Justin happens when you create a meta
alert from a group that is nested by more than 1 level. Creating a meta alert
from a top level group works.
---
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/843
METRON-1319: Column Metadata REST service should use default indices on
empty input
## Contributor Comments
This PR adjusts the Column Metadata REST service to use a list of default
indices
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/832
+1 worked as advertised. Thanks @nickwallen!
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/827
The latest commit fixes the bug @justinleet found and adds some test cases
to cover it.
I also removed an "ignoredIndices" variable from the ElasticsearchDao
class. This was
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/827
@JonZeolla I think we should just remove it for now and I've done that in
the latest commit. I'm not entirely clear on what we should expect in this
case and we don't need it right now anyways
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/827
Was commenting while your comment posted. I think your latest suggestion
is the right answer :)
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/827
Actually the more I think about it, I would not consider a field to be
common between indices when the types mismatch. Hard to say what the right
answer is because there is no real requirement
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/827
I don't think that method is even used anymore but I will add the mismatch
handling just in case.
---
Github user merrimanr closed the pull request at:
https://github.com/apache/metron/pull/825
---
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/826#discussion_r151450858
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/config/KafkaConfig.java
---
@@ -108,6 +108,9 @@ public ZkUtils zkUtils
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/824#discussion_r150995571
--- Diff:
metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java
---
@@ -138,9 +142,17 @@ private Document
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/824
The latest commit fixes the group by bug found by @iraghumitra and
addresses the feedback
[above](https://github.com/apache/metron/pull/824#pullrequestreview-76466048).
The group by fix
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/824
@justinleet looking at your results I would expect the count to go down by
2 instead of 1: 1 for the alert that was added to the meta alert and another
for the meta alert itself since
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/824#discussion_r150889867
--- Diff:
metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java
---
@@ -135,8 +138,9 @@ private Document
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/824#discussion_r150874132
--- Diff:
metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java
---
@@ -135,8 +138,9 @@ private Document
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/824#discussion_r150866003
--- Diff:
metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java
---
@@ -135,8 +138,9 @@ private Document
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/824
I also found what I believe are 2 fairly significant architectural issues
with our DAO abstraction:
- https://issues.apache.org/jira/browse/METRON-1314
- https://issues.apache.org/jira
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/824
The latest commit fixes the bug in the previous comment. The root cause
was that HBaseDao.getAllLatest was not properly returning the sensor type and
causing subsequent updates in Elasticsearch
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/824#discussion_r150644110
--- Diff:
metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/InMemoryMetaAlertDao.java
---
@@ -200,4 +207,23 @@ public
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/826#discussion_r150560129
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/config/KafkaConfig.java
---
@@ -108,6 +108,9 @@ public ZkUtils zkUtils
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/826#discussion_r150549974
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/config/KafkaConfig.java
---
@@ -108,6 +108,9 @@ public ZkUtils zkUtils
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/824
The latest commits address some outstanding tasks and address a couple
other issues:
- disabling updates to meta alert objects means we can't update a meta
alert name or comments (or other
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/824#discussion_r150239332
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java
---
@@ -256,59 +256,91 @@ public
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/824
The 2nd most recent commits updates the MetaAlertDao interface by adding
additional methods for interacting with metaalerts. This should make it
easier to use and make the underlying
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/824
No problem. I am still actively working on this PR and will add the
HBaseDao.findAllLatest implementation task to my list.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/829
+1. I agree with Casey that this should fail instead of WARN. If
templates are not installed it puts us in a bad state and requires manual
intervention that may not be obvious.
---
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/827#discussion_r149177390
--- Diff:
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/SearchControllerIntegrationTest.java
---
@@ -236,17 +236,14
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/827#discussion_r149176509
--- Diff:
metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/InMemoryDao.java
---
@@ -221,12 +222,24 @@ public void batchUpdate
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/827#discussion_r149156555
--- Diff:
metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/InMemoryDao.java
---
@@ -221,12 +222,24 @@ public void batchUpdate
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/827
METRON-1294: IP addresses are not formatted correctly in facet and group
results
## Contributor Comments
By default, values in facet and group by results are not formatted
correctly in some
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/826
METRON-1291: Kafka produce REST endpoint does not work in a Kerberized
cluster
## Contributor Comments
This PR adds Kerberos support to the
http://node1:8082/swagger-ui.html#!/kafka
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/825
Looks like there is a
[bug](https://stackoverflow.com/questions/40984882/mockito-and-powermock-methodnotfoundexception-being-thrown)
in the powermock version inherited by this module. Latest
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/825
METRON-1290: Only first 10 alerts are update when a MetaAlert status is
changed to inactive
## Contributor Comments
This PR fixes a small bug in the ElasticsearchMetaAlertDao that only
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/824
METRON-1289: Alert fields are lost when a MetaAlert is created
## Contributor Comments
This PR fixes a bug in the ElasticsearchMetaAlertDao that incorrectly
updates the included alerts
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/803
Yes HBase is running. The first set of status tests are working (they
would not if HBase were down).
---
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r147853082
--- Diff:
metron-interface/metron-alerts/e2e/alerts-list/tree-view/tree-view.po.ts ---
@@ -159,4 +159,34 @@ export class TreeViewPage {
return
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r147853051
--- Diff:
metron-interface/metron-alerts/e2e/alerts-list/tree-view/tree-view.po.ts ---
@@ -159,4 +159,34 @@ export class TreeViewPage {
return
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r147853067
--- Diff:
metron-interface/metron-alerts/e2e/alerts-list/tree-view/tree-view.po.ts ---
@@ -159,4 +159,34 @@ export class TreeViewPage {
return
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/803
I am consistently getting these e2e test failures:
```
1) meta-alerts workflow should have all the steps for meta alerts workflow
- Error: Timeout - Async callback was not invoked
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/820
I was able to successfully build full dev with this change. +1
---
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/821
METRON-1281: Remove hard-coded indices from the Alerts UI
## Contributor Comments
This PR adjusts the Alerts UI and REST app to remove the need to hard-code
the indices in the Alerts UI
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/796
I think the test coverage looks pretty good. I'm +1 conditional on the e2e
tests passing.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/797
Just tested this and worked as expected. The only question I have is
whether the "error" index should be included since it is used to store errors
and not alerts. I can't think of a
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/796
This issue is still not fixed:
- The first is related to time-range selections that include 'Now' as part
of the range (Last 7 days, Last 5 minutes, Today so far, etc). This should
Github user merrimanr closed the pull request at:
https://github.com/apache/metron/pull/813
---
GitHub user merrimanr reopened a pull request:
https://github.com/apache/metron/pull/813
METRON-1274: Master has failure in StormControllerIntegrationTest
## Contributor Comments
This PR fixes an intermittently failing integration test. I believe the
root cause is the test
GitHub user merrimanr reopened a pull request:
https://github.com/apache/metron/pull/813
METRON-1274: Master has failure in StormControllerIntegrationTest
## Contributor Comments
This PR fixes an intermittently failing integration test. I believe the
root cause is the test
Github user merrimanr closed the pull request at:
https://github.com/apache/metron/pull/813
---
GitHub user merrimanr reopened a pull request:
https://github.com/apache/metron/pull/813
METRON-1274: Master has failure in StormControllerIntegrationTest
## Contributor Comments
This PR fixes an intermittently failing integration test. I believe the
root cause is the test
Github user merrimanr closed the pull request at:
https://github.com/apache/metron/pull/813
---
Github user merrimanr closed the pull request at:
https://github.com/apache/metron/pull/813
---
GitHub user merrimanr reopened a pull request:
https://github.com/apache/metron/pull/813
METRON-1274: Master has failure in StormControllerIntegrationTest
## Contributor Comments
This PR fixes an intermittently failing integration test. I believe the
root cause is the test
Github user merrimanr closed the pull request at:
https://github.com/apache/metron/pull/813
---
GitHub user merrimanr reopened a pull request:
https://github.com/apache/metron/pull/813
METRON-1274: Master has failure in StormControllerIntegrationTest
## Contributor Comments
This PR fixes an intermittently failing integration test. I believe the
root cause is the test
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/813
Fixed the other failure at
`SensorParserConfigControllerIntegrationTest.test:294`.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/811
@nickwallen suppose you have a metaalert that contains 2 alerts. Then
suppose each alert has a different value for the host field. If you grouped on
host, which group would you expect
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/811
I believe excluding metaalerts from the group by view is the desired
behavior.
---
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/813
METRON-1274: Master has failure in StormControllerIntegrationTest
## Contributor Comments
This PR fixes an intermittently failing integration test. I believe the
root cause is the test
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r146267005
--- Diff: metron-interface/metron-alerts/src/app/service/update.service.ts
---
@@ -38,22 +41,27 @@ export class UpdateService {
constructor
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r146265870
--- Diff:
metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.component.ts
---
@@ -0,0 +1,101 @@
+/**
+ * Licensed
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r146265654
--- Diff:
metron-interface/metron-alerts/e2e/alerts-list/tree-view/tree-view.e2e-spec.ts
---
@@ -175,7 +175,7 @@ describe('metron-alerts tree view
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/803
I just submitted a
[PR](https://github.com/iraghumitra/incubator-metron/pull/3) against this PR
that addresses all of the bugs reported above except 1:
- when metaalerts and alerts
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/795#discussion_r145992573
--- Diff:
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/StormControllerIntegrationTest.java
---
@@ -179,6 +181,8 @@ public
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/795
I tested this thoroughly and everything works as expected. I made one
small comment that I feel is optional. This is an awesome PR. +1
---
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/808
METRON-1267: Alerts UI returns a 404 when refreshing the alerts-list page
## Contributor Comments
This PR fixes a small bug that causes a 404 when refreshing the front
Alerts UI list page
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/803
I did an initial review of this and I see several things we need to work
through. It's a pretty significant feature so that's not surprising. I know
there are some other PRs being worked
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r145816832
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alerts-list/table-view/table-view.component.scss
---
@@ -24,4 +24,12 @@
.configure-table
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r145816633
--- Diff:
metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.component.html
---
@@ -0,0 +1,48
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r145816548
--- Diff: metron-interface/metron-alerts/src/styles.scss ---
@@ -259,4 +259,61 @@ hr {
padding: 0;
}
-
+/** Custom Radio box
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r145816388
--- Diff: metron-interface/metron-alerts/src/app/service/update.service.ts
---
@@ -38,22 +41,27 @@ export class UpdateService {
constructor
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r145816267
--- Diff: metron-interface/metron-alerts/src/app/service/update.service.ts
---
@@ -38,22 +41,27 @@ export class UpdateService {
constructor
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r145814896
--- Diff:
metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.component.ts
---
@@ -0,0 +1,101 @@
+/**
+ * Licensed
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r145814193
--- Diff:
metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.component.ts
---
@@ -0,0 +1,101 @@
+/**
+ * Licensed
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r145813076
--- Diff:
metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.component.ts
---
@@ -0,0 +1,101 @@
+/**
+ * Licensed
101 - 200 of 453 matches
Mail list logo
