[GitHub] metron issue #795: METRON-1241: Enable the REST API to use a cache for the z...

2017-10-20 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/795 I tested this thoroughly and everything works as expected. I made one small comment that I feel is optional. This is an awesome PR. +1 ---

[GitHub] metron pull request #808: METRON-1267: Alerts UI returns a 404 when refreshi...

2017-10-19 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/808 METRON-1267: Alerts UI returns a 404 when refreshing the alerts-list page ## Contributor Comments This PR fixes a small bug that causes a 404 when refreshing the front Alerts UI list page

[GitHub] metron issue #803: Metron-1252: Build ui for grouping alerts into meta alert...

2017-10-19 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/803 I did an initial review of this and I see several things we need to work through. It's a pretty significant feature so that's not surprising. I know there are some other PRs being work

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

2017-10-19 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145816904 --- Diff: metron-interface/metron-alerts/src/app/alerts/alert-details/alert-details.component.scss --- @@ -143,3 +167,12 @@ textarea { .comment

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

2017-10-19 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145816832 --- Diff: metron-interface/metron-alerts/src/app/alerts/alerts-list/table-view/table-view.component.scss --- @@ -24,4 +24,12 @@ .configure-table

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

2017-10-19 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145816633 --- Diff: metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.component.html --- @@ -0,0 +1,48

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

2017-10-19 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145816548 --- Diff: metron-interface/metron-alerts/src/styles.scss --- @@ -259,4 +259,61 @@ hr { padding: 0; } - +/** Custom Radio box

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

2017-10-19 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145816388 --- Diff: metron-interface/metron-alerts/src/app/service/update.service.ts --- @@ -38,22 +41,27 @@ export class UpdateService { constructor

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

2017-10-19 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145816267 --- Diff: metron-interface/metron-alerts/src/app/service/update.service.ts --- @@ -38,22 +41,27 @@ export class UpdateService { constructor

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

2017-10-19 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145814896 --- Diff: metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.component.ts --- @@ -0,0 +1,101 @@ +/** + * Licensed to the

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

2017-10-19 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145814193 --- Diff: metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.component.ts --- @@ -0,0 +1,101 @@ +/** + * Licensed to the

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

2017-10-19 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145813076 --- Diff: metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.component.ts --- @@ -0,0 +1,101 @@ +/** + * Licensed to the

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

2017-10-19 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145811869 --- Diff: metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.module.ts --- @@ -0,0 +1,14 @@ +import { NgModule } from '@an

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

2017-10-19 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145810773 --- Diff: metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.component.ts --- @@ -0,0 +1,101 @@ +/** + * Licensed to the

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

2017-10-19 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145810720 --- Diff: metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.component.ts --- @@ -0,0 +1,101 @@ +/** + * Licensed to the

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

2017-10-19 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145809924 --- Diff: metron-interface/metron-alerts/src/app/utils/constants.ts --- @@ -27,5 +30,5 @@ export const ALERTS_COLUMN_NAMES = 'metron-alerts-column-

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

2017-10-19 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145809831 --- Diff: metron-interface/metron-alerts/src/app/utils/constants.ts --- @@ -18,6 +18,9 @@ import {environment} from '../../environ

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

2017-10-19 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145809660 --- Diff: metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.component.ts --- @@ -0,0 +1,101 @@ +/** + * Licensed to the

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

2017-10-19 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145809162 --- Diff: metron-interface/metron-alerts/e2e/alerts-list/tree-view/tree-view.e2e-spec.ts --- @@ -175,7 +175,7 @@ describe('metron-alerts tree

[GitHub] metron issue #796: METRON-1224: Add time range selection to search control

2017-10-19 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/796 I tested this as well. First a couple things I'm curious about: - when I open the date/time range picker why does it say "now/d"? I would expect just "now" or

[GitHub] metron pull request #806: METRON-1262: Unable to add comment for a alert in ...

2017-10-18 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/806 METRON-1262: Unable to add comment for a alert in a meta-alert ## Contributor Comments This PR fixes a bug in the ElasticsearchMetaalertDao class (description is in the Jira). I verified it

[GitHub] metron issue #802: METRON-1255: MetaAlert search is not filtering on status

2017-10-18 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/802 Feedback has been addressed. Take another look when you get a chance. ---

[GitHub] metron pull request #802: METRON-1255: MetaAlert search is not filtering on ...

2017-10-18 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/802#discussion_r145532341 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java --- @@ -177,15 +178,18

[GitHub] metron pull request #802: METRON-1255: MetaAlert search is not filtering on ...

2017-10-18 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/802#discussion_r145532292 --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchMetaAlertIntegrationTest.java

[GitHub] metron pull request #802: METRON-1255: MetaAlert search is not filtering on ...

2017-10-18 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/802#discussion_r145427376 --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchMetaAlertIntegrationTest.java

[GitHub] metron pull request #802: METRON-1255: MetaAlert search is not filtering on ...

2017-10-18 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/802#discussion_r145423988 --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchMetaAlertIntegrationTest.java

[GitHub] metron pull request #802: METRON-1255: MetaAlert search is not filtering on ...

2017-10-18 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/802#discussion_r145424237 --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchMetaAlertIntegrationTest.java

[GitHub] metron pull request #802: METRON-1255: MetaAlert search is not filtering on ...

2017-10-17 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/802 METRON-1255: MetaAlert search is not filtering on status ## Contributor Comments This PR primarily fixes filtering on metaalert status but also includes a couple other minor fixes as well

[GitHub] metron pull request #768: Metron 1123: Add group by option using faceted sea...

2017-10-13 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/768#discussion_r144639257 --- Diff: metron-interface/metron-alerts/src/app/alerts/alerts-list/tree-view/tree-view.component.ts --- @@ -0,0 +1,319 @@ +/** + * Licensed to

[GitHub] metron issue #787: METRON-1232: Alert status changes are not reflected in li...

2017-10-12 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/787 +1 ---

[GitHub] metron pull request #787: METRON-1232: Alert status changes are not reflecte...

2017-10-12 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/787#discussion_r144306688 --- Diff: metron-interface/metron-alerts/src/app/service/update.service.ts --- @@ -32,13 +33,31 @@ export class UpdateService

[GitHub] metron pull request #787: METRON-1232: Alert status changes are not reflecte...

2017-10-10 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/787#discussion_r143735130 --- Diff: metron-interface/metron-alerts/src/app/service/update.service.ts --- @@ -32,13 +33,31 @@ export class UpdateService

[GitHub] metron pull request #768: Metron 1123: Add group by option using faceted sea...

2017-10-10 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/768#discussion_r143729308 --- Diff: metron-interface/metron-alerts/src/app/alerts/alerts-list/tree-view/tree-view.component.ts --- @@ -0,0 +1,319 @@ +/** + * Licensed to

[GitHub] metron issue #768: Metron 1123: Add group by option using faceted search cap...

2017-10-05 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/768 Thanks @iraghumitra the bulk actions are working now. Just need to address the e2e test suggestions and I think this will be good to go. ---

[GitHub] metron pull request #786: METRON-1231: Separate Sensor name and topic in the...

2017-10-04 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/786 METRON-1231: Separate Sensor name and topic in the Management UI ## Contributor Comments This PR separates sensor name and sensor Kafka topic in both the REST app as well as the Management UI

[GitHub] metron pull request #784: METRON-1229: Management UI type is part of the dec...

2017-10-04 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/784 METRON-1229: Management UI type is part of the declarations of 2 modules ## Contributor Comments The PR fixes an intermittent bug that was recently introduced. This can be verified by

[GitHub] metron issue #768: Metron 1123: Add group by option using faceted search cap...

2017-10-04 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/768 With respect to displaying field names, I think it's going to be tough coming up with a strategy that solves every case. This will likely depend on a user's preference and is subjecti

[GitHub] metron issue #779: METRON-1218: Metron REST should return better error messa...

2017-10-03 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/779 The most recent commit changes fullMessage to use ExceptionUtils.getRootCauseMessage. ---

[GitHub] metron issue #768: Metron 1123: Add group by option using faceted search cap...

2017-10-03 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/768 I spun this up in full dev and it's working pretty well. The only functional issue I could find was that the bulk actions are disabled when alerts are selected in group/tree view. This is l

[GitHub] metron pull request #768: Metron 1123: Add group by option using faceted sea...

2017-10-03 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/768#discussion_r142459136 --- Diff: metron-interface/metron-alerts/e2e/alerts-list/tree-view/tree-view.e2e-spec.ts --- @@ -0,0 +1,183 @@ +/// +/** + * Licensed to the

[GitHub] metron pull request #768: Metron 1123: Add group by option using faceted sea...

2017-10-03 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/768#discussion_r142454390 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/metaalert/MetaAlertCreateResponse.java --- @@ -28,4 +28,4

[GitHub] metron pull request #768: Metron 1123: Add group by option using faceted sea...

2017-10-03 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/768#discussion_r142454353 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/MetaAlertStatus.java --- @@ -31,4 +31,4 @@ public

[GitHub] metron issue #737: METRON-1161: Add ability to edit parser command line opti...

2017-10-03 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/737 Ok I reverted the SensorParserConfig class so that defaults are not provided for numWorkers and numAckers. I also added help text to make it clear to the user what happens when these are not set

[GitHub] metron pull request #779: METRON-1218: Metron REST should return better erro...

2017-10-03 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/779#discussion_r142419159 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java --- @@ -35,7 +36,7

[GitHub] metron pull request #779: METRON-1218: Metron REST should return better erro...

2017-10-03 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/779#discussion_r142411323 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java --- @@ -35,7 +36,7

[GitHub] metron issue #737: METRON-1161: Add ability to edit parser command line opti...

2017-10-02 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/737 I moved the default values to the storm config and changed getNumWorkers and getNumAckers to return the values in the storm config if numWorkers/numAckers is null. Is this what you were thinking

[GitHub] metron pull request #779: METRON-1218: Metron REST should return better erro...

2017-10-02 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/779#discussion_r142237205 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java --- @@ -35,7 +36,7

[GitHub] metron pull request #779: METRON-1218: Metron REST should return better erro...

2017-10-02 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/779#discussion_r142235450 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java --- @@ -35,7 +36,7

[GitHub] metron issue #779: METRON-1218: Metron REST should return better error messa...

2017-10-02 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/779 The latest commit replaces the getFullMessage call with ExceptionUtils.getStackTrace. Hopefully that addresses the recursion issue. As for security @ottobackwards, I'm not sure wha

[GitHub] metron pull request #779: METRON-1218: Metron REST should return better erro...

2017-09-29 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/779#discussion_r141974727 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java --- @@ -45,4 +45,14 @@ private

[GitHub] metron pull request #779: METRON-1218: Metron REST should return better erro...

2017-09-29 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/779#discussion_r141968868 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java --- @@ -45,4 +45,14 @@ private

[GitHub] metron pull request #779: METRON-1218: Metron REST should return better erro...

2017-09-29 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/779#discussion_r141861097 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java --- @@ -45,4 +45,14 @@ private

[GitHub] metron pull request #779: METRON-1218: Metron REST should return better erro...

2017-09-29 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/779#discussion_r141860594 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java --- @@ -45,4 +45,14 @@ private

[GitHub] metron pull request #779: METRON-1218: Metron REST should return better erro...

2017-09-28 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/779 METRON-1218: Metron REST should return better error messages ## Contributor Comments This PR improves the error handling in the REST app and adds logging to failed searches in the

[GitHub] metron issue #778: METRON-1208: MPack for Alerts UI

2017-09-28 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/778 No problem. Just added a commit that mentions the MPack in the README. Let me know if that works. ---

[GitHub] metron pull request #778: METRON-1208: MPack for Alerts UI

2017-09-28 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/778 METRON-1208: MPack for Alerts UI ## Contributor Comments The PR completes the MPack for Alerts UI. This can be verified in full dev by spinning up full dev and navigating to the Alerts UI

[GitHub] metron pull request #777: METRON-1207: Make RPMs for Alerts UI

2017-09-28 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/777 METRON-1207: Make RPMs for Alerts UI ## Contributor Comments This PR creates an RPM for the Alerts UI. To test, cd to metron-deployment and run `mvn clean package -Pbuild-rpms`. This should

[GitHub] metron issue #773: METRON-1206: Make alerts UI conform to ops UI for install

2017-09-27 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/773 The latest commit should address all the PR comments. ---

[GitHub] metron issue #766: METRON-1195: Meta alerts improperly handle updates to non...

2017-09-27 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/766 Tested this in full dev and it behaved as expected. Nice work +1 ---

[GitHub] metron issue #771: METRON-1204: UI does not time out after being idle, but s...

2017-09-26 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/771 The latest commit adds a "Session Expired" message on the login page and also applies the fix to the Management UI. You will notice the 2 files look identical between metron-alerts

[GitHub] metron pull request #773: METRON-1206: Make alerts UI conform to ops UI for ...

2017-09-26 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/773 METRON-1206: Make alerts UI conform to ops UI for install ## Contributor Comments This PR is a precursor to [METRON-1207](https://issues.apache.org/jira/browse/METRON-1207) and [METRON-1208

[GitHub] metron issue #771: METRON-1204: UI does not time out after being idle, but s...

2017-09-25 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/771 That's not a bad idea. It occurs to me that this issue may also exist with the Management UI and should be fixed there as well. Stay tuned. ---

[GitHub] metron issue #762: METRON-1189: Add alert escalation to the Alerts UI

2017-09-25 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/762 This PR is already fairly large and I don't see the "Hide Dismissed/Resolved Alerts" feature as being a trivial addition. Can we do that as a follow-on? ---

[GitHub] metron pull request #771: METRON-1204: UI does not time out after being idle...

2017-09-22 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/771 METRON-1204: UI does not time out after being idle, but stops functioning ## Contributor Comments This fix was verified running the Alerts UI against full dev. To test this fix, spin up full

[GitHub] metron issue #762: METRON-1189: Add alert escalation to the Alerts UI

2017-09-22 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/762 The latest commit merges in master and addresses your feedback @iraghumitra. I solved the issue in my previous comment by pausing anytime a checkbox is checked and resuming when all checkboxes

[GitHub] metron issue #762: METRON-1189: Add alert escalation to the Alerts UI

2017-09-21 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/762 I researched the saveRefreshState() and restoreRefreshState() addition and it uncovered a bug which then uncovered a problem with how our UI works. The bug was that the selectedAlerts

[GitHub] metron issue #756: METRON-1182: Refactored AlertList View to abstract displa...

2017-09-21 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/756 Lots of improvements in this PR, I like it. Spun this up in full dev and everything continues to work. Nice job. +1 ---

[GitHub] metron issue #757: METRON-938: "service metron-rest start " does n...

2017-09-21 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/757 Spun it up again in full dev, setup MySQL and everything works as it should. Thanks so much @justinleet for fixing this! Turned out great. +1 ---

[GitHub] metron issue #737: METRON-1161: Add ability to edit parser command line opti...

2017-09-21 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/737 Changing numWorkers and numAckers default values from null to 1 had the unintended consequences of breaking the ParserTopologyCliTest. This is because they can no longer be overriden by setting

[GitHub] metron issue #737: METRON-1161: Add ability to edit parser command line opti...

2017-09-20 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/737 Just pushed out a commit that addresses @ottobackwards comments and fixes the NUM_WORKERS and NUM_ACKERS issue. I also added a warning that appears when a storm setting changes, telling the user

[GitHub] metron issue #694: METRON-1085: Add REST endpoint to save a user profile for...

2017-09-19 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/694 The latest commit merges in master and also refactors this endpoint into the AlertService and AlertController classes that were recently accepted into master. I think this will make it cleaner by

[GitHub] metron pull request #737: METRON-1161: Add ability to edit parser command li...

2017-09-19 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/737#discussion_r139815871 --- Diff: metron-interface/metron-config/src/app/sensors/sensor-parser-config/sensor-parser-config.component.ts --- @@ -409,12 +403,17 @@ export class

[GitHub] metron pull request #737: METRON-1161: Add ability to edit parser command li...

2017-09-19 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/737#discussion_r139815513 --- Diff: metron-interface/metron-config/src/app/sensors/sensor-parser-config-readonly/sensor-parser-config-readonly.component.spec.ts --- @@ -301,7

[GitHub] metron issue #737: METRON-1161: Add ability to edit parser command line opti...

2017-09-19 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/737 Thank you for the feedback @nickwallen. On points 1-3 and 5, these could be applied to any panel in the management UI. They all work the same. My opinion is that correct design in this

[GitHub] metron issue #757: METRON-938: "service metron-rest start " does n...

2017-09-15 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/757 Spun this up in full dev and tested several different cases including setting up a MySQL database for authentication. Worked great. I made a couple minor suggestions but I think this is pretty

[GitHub] metron pull request #757: METRON-938: "service metron-rest start "...

2017-09-15 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/757#discussion_r139250975 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/service_advisor.py --- @@ -69,6 +69,10 @@ def

[GitHub] metron pull request #757: METRON-938: "service metron-rest start "...

2017-09-15 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/757#discussion_r139249622 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/rest_commands.py

[GitHub] metron pull request #757: METRON-938: "service metron-rest start "...

2017-09-15 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/757#discussion_r139245252 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/params_linux.py

[GitHub] metron pull request #762: METRON-1189: Add alert escalation to the Alerts UI

2017-09-15 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/762 METRON-1189: Add alert escalation to the Alerts UI ## Contributor Comments This PR adds the ability to escalate alerts from the Alerts UI. This is a follow on to https://github.com/apache

[GitHub] metron issue #734: METRON-1158: Build backend for grouping alerts into meta ...

2017-09-13 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/734 I'm still +1 ---

[GitHub] metron issue #749: METRON-1176 Rest support for setting permissions on files...

2017-09-12 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/749 I spun this up in full dev and it worked as expected. Thanks for the contribution. +1 ---

[GitHub] metron issue #734: METRON-1158: Build backend for grouping alerts into meta ...

2017-09-11 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/734 Tested this again in full dev and now the default sort is working as expected (due to timestamp being added). +1 from me. Nice job. ---

[GitHub] metron pull request #734: METRON-1158: Build backend for grouping alerts int...

2017-09-11 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/734#discussion_r138064525 --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchMetaAlertIntegrationTest.java

[GitHub] metron issue #700: METRON-1077: Use column meta data end point in alerts ui

2017-09-08 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/700 Thanks @iraghumitra. I tested this in full dev and everything worked as expected. +1 ---

[GitHub] metron issue #702: METRON-1114: Add group by capabilities to search REST end...

2017-09-08 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/702 The latest commit should address the feedback so far. I don't feel like the top hits aggregation is necessary at this point but it could be in the future. I would prefer to wait and ke

[GitHub] metron pull request #702: METRON-1114: Add group by capabilities to search R...

2017-09-08 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/702#discussion_r137893211 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/config/IndexConfig.java --- @@ -56,8 +52,10 @@ public IndexDao indexDao

[GitHub] metron pull request #702: METRON-1114: Add group by capabilities to search R...

2017-09-08 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/702#discussion_r137893133 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/search/GroupOrderType.java --- @@ -0,0 +1,39

[GitHub] metron pull request #702: METRON-1114: Add group by capabilities to search R...

2017-09-08 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/702#discussion_r137893095 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java --- @@ -330,43 +334,112 @@ public

[GitHub] metron issue #734: METRON-1158: Build backend for grouping alerts into meta ...

2017-09-08 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/734 Great job on this. I spent a lot of time testing and had trouble finding anything wrong. The one thing I did notice was that the "timestamp" field was missing from documents in the

[GitHub] metron pull request #734: METRON-1158: Build backend for grouping alerts int...

2017-09-08 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/734#discussion_r137889738 --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchMetaAlertIntegrationTest.java

[GitHub] metron pull request #734: METRON-1158: Build backend for grouping alerts int...

2017-09-08 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/734#discussion_r137874476 --- Diff: metron-interface/metron-rest/README.md --- @@ -361,6 +363,21 @@ Request and Response objects are JSON formatted. The JSON schemas are available

[GitHub] metron pull request #737: METRON-1161: Add ability to edit parser command li...

2017-09-08 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/737 METRON-1161: Add ability to edit parser command line options in the management UI ## Contributor Comments This PR is a follow up to https://github.com/apache/metron/pull/717 and exposes the

[GitHub] metron issue #729: METRON-1150: REST parseMessage endpoint fails with Unable...

2017-09-07 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/729 Just pushed out a small change to support parameter substitution in the metron_temp_grok_path parameter. I verified this in full dev as well. I also verified the temporary files are being

[GitHub] metron pull request #729: METRON-1150: REST parseMessage endpoint fails with...

2017-09-06 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/729#discussion_r137362276 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-rest-env.xml

[GitHub] metron pull request #729: METRON-1150: REST parseMessage endpoint fails with...

2017-09-06 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/729#discussion_r137354784 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-rest-env.xml

[GitHub] metron issue #729: METRON-1150: REST parseMessage endpoint fails with Unable...

2017-09-06 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/729 Please see https://issues.apache.org/jira/browse/METRON-1150 for a description of why this is needed. Let me know if that isn't clear enough or you need more info. ---

[GitHub] metron pull request #729: METRON-1150: REST parseMessage endpoint fails with...

2017-09-06 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/729#discussion_r137353301 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-rest-env.xml

[GitHub] metron pull request #729: METRON-1150: REST parseMessage endpoint fails with...

2017-09-06 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/729#discussion_r137284827 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-rest-env.xml

[GitHub] metron pull request #700: METRON-1077: Use column meta data end point in ale...

2017-09-05 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/700#discussion_r137118513 --- Diff: metron-interface/metron-alerts/src/app/utils/metron-rest-api-utils.ts --- @@ -0,0 +1,40 @@ +/** + * Licensed to the Apache Software

[GitHub] metron pull request #700: METRON-1077: Use column meta data end point in ale...

2017-09-05 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/700#discussion_r137118292 --- Diff: metron-interface/metron-alerts/src/app/service/cluster-metadata.service.ts --- @@ -16,14 +16,20 @@ * limitations under the License

<    1   2   3   4   5   6   >