[GitHub] metron pull request #644: METRON-1027: Errant Log Message When No GeoIP Hit ...

2017-07-10 Thread nickwallen
GitHub user nickwallen reopened a pull request: https://github.com/apache/metron/pull/644 METRON-1027: Errant Log Message When No GeoIP Hit on Valid, External IPv4 Address When a valid public IPv4 address does not match a record in the Maxmind GeoIP database, a log message

[GitHub] metron issue #644: METRON-1027: Errant Log Message When No GeoIP Hit on Vali...

2017-07-10 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/644 Thanks for the review guys. Just trying to understand why Travis is reporting a unit test failure. Its like it is not running the latest code. Bah. --- If your project is set up for it, you

[GitHub] metron pull request #644: METRON-1027: Errant Log Message When No GeoIP Hit ...

2017-07-10 Thread nickwallen
Github user nickwallen closed the pull request at: https://github.com/apache/metron/pull/644 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] metron pull request #644: METRON-1027: Errant Log Message When No GeoIP Hit ...

2017-07-10 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/644#discussion_r126510446 --- Diff: metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/adapters/geo/GeoAdapter.java --- @@ -46,7 +46,6 @@ public

[GitHub] metron issue #644: METRON-1027: Errant Log Message When No GeoIP Hit on Vali...

2017-07-10 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/644 @justinleet Another thing I noticed while in the code is that a lookup of a private IP address is expected to return an empty map. Since we're using an Optional, wouldn't it make more

[GitHub] metron pull request #644: METRON-1027: Errant Log Message When No GeoIP Hit ...

2017-07-10 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/644 METRON-1027: Errant Log Message When No GeoIP Hit on Valid, External … When a valid public IPv4 address does not match a record in the Maxmind GeoIP database, a log message indicates that an

[GitHub] metron issue #608: METRON-986 Enhance Fastcapa to Support Intel X520

2017-07-07 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/608 > That sounds good; can you create a follow-on JIRA to investigate how to make the properties specified at run-time rather than as macros in code? FYI - Created https://issues.apache.

[GitHub] metron issue #613: METRON-990: Clean up and organize flux properties

2017-06-22 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/613 +1 I was able to alter settings for the Enrichment topology, successfully restart all services, and see the new configuration changes take effect. Splitting out all of the settings

[GitHub] metron pull request #622: METRON-1005 Create Decodable Row Key for Profiler

2017-06-22 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/622 METRON-1005 Create Decodable Row Key for Profiler To be able to answer the types of questions that I outlined in [METRON-450](https://issues.apache.org/jira/browse/METRON-450), we need a row

[GitHub] metron issue #613: METRON-990: Clean up and organize flux properties

2017-06-22 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/613 Your updates look good @merrimanr. Just running it up again for a round of testing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] metron pull request #613: METRON-990: Clean up and organize flux properties

2017-06-21 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123374090 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69

[GitHub] metron pull request #613: METRON-990: Clean up and organize flux properties

2017-06-21 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123373290 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69

[GitHub] metron pull request #613: METRON-990: Clean up and organize flux properties

2017-06-21 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123372371 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69

[GitHub] metron issue #608: METRON-986 Enhance Fastcapa to Support Intel X520

2017-06-21 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/608 Did I answer your question @cestella ? Short answer is no and unfortunately I don't quite know how to get there. --- If your project is set up for it, you can reply to this email and have

[GitHub] metron pull request #613: METRON-990: Clean up and organize flux properties

2017-06-21 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123290700 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69

[GitHub] metron pull request #613: METRON-990: Clean up and organize flux properties

2017-06-21 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123287744 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69

[GitHub] metron pull request #613: METRON-990: Clean up and organize flux properties

2017-06-21 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123263841 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69

[GitHub] metron pull request #613: METRON-990: Clean up and organize flux properties

2017-06-21 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123265664 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69

[GitHub] metron pull request #613: METRON-990: Clean up and organize flux properties

2017-06-21 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123267781 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/templates/enrichment.properties.j2

[GitHub] metron pull request #586: METRON-508 Expand Elasticsearch templates to suppo...

2017-06-20 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/586#discussion_r123058316 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/files/bro_index.template

[GitHub] metron pull request #586: METRON-508 Expand Elasticsearch templates to suppo...

2017-06-20 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/586#discussion_r123051416 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/files/bro_index.template

[GitHub] metron pull request #586: METRON-508 Expand Elasticsearch templates to suppo...

2017-06-20 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/586#discussion_r123014905 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/files/bro_index.template

[GitHub] metron pull request #586: METRON-508 Expand Elasticsearch templates to suppo...

2017-06-20 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/586#discussion_r123012618 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/files/bro_index.template

[GitHub] metron pull request #586: METRON-508 Expand Elasticsearch templates to suppo...

2017-06-20 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/586#discussion_r123014881 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/files/bro_index.template

[GitHub] metron issue #608: METRON-986 Enhance Fastcapa to Support Intel X520

2017-06-19 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/608 What we have **should** work out-of-the-box for most NICs. Of course, I have only been able to test on the x520 and Cisco VNICs, so that is all I can really be sure of. If changes would

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-06-12 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r121393102 --- Diff: metron-extensions/metron-parser-extensions/metron-parser-bro-extension/metron-parser-bro/src/main/config/zookeeper/enrichments/bro.json

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-06-09 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r121216912 --- Diff: metron-extensions/metron-parser-extensions/metron-parser-bro-extension/metron-parser-bro/src/main/config/zookeeper/enrichments/bro.json

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-06-09 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r121211536 --- Diff: metron-extensions/metron-parser-extensions/metron-parser-bro-extension/metron-parser-bro/src/main/config/zookeeper/enrichments/bro.json

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-06-07 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r120747477 --- Diff: metron-extensions/README.md --- @@ -0,0 +1,51 @@ +# Metron Extensions --- End diff -- Your new extension mechanism seems like a

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-06-07 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r120743215 --- Diff: bundles-maven-plugin/README.md --- @@ -0,0 +1,89 @@ + +# Apache Metron Bundle Maven Plugin --- End diff -- The new top

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-06-07 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r120747187 --- Diff: bundles-maven-plugin/pom.xml --- @@ -0,0 +1,328 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-06-07 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r120740755 --- Diff: bundles-lib/src/test/java/org/apache/metron/bundles/integration/components/MRComponent.java --- @@ -0,0 +1,68 @@ +/** + * Licensed to

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-06-07 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r120738935 --- Diff: bundles-lib/pom.xml --- @@ -0,0 +1,179 @@ + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-06-07 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r120742937 --- Diff: bundles-maven-plugin/README.md --- @@ -0,0 +1,89 @@ + +# Apache Metron Bundle Maven Plugin --- End diff -- The new top

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-06-07 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r120745677 --- Diff: bundles-lib/pom.xml --- @@ -0,0 +1,179 @@ + +

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-06-07 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r120744702 --- Diff: metron-extensions/metron-parser-extensions/metron-parser-bro-extension/metron-parser-bro/README.md --- @@ -0,0 +1,3 @@ +# bro Parser

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-06-07 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r120746288 --- Diff: bundles-lib/src/test/java/org/apache/metron/bundles/integration/components/MRComponent.java --- @@ -0,0 +1,68 @@ +/** + * Licensed to

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-06-07 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r120741471 --- Diff: metron-extensions/metron-parser-extensions/metron-parser-bro-extension/metron-parser-bro/src/main/config/zookeeper/enrichments/bro.json

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-06-07 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/530 @ottobackwards I'm good with that, Otto. The benefit doesn't outweigh the cost at this point. Thanks for clarifying. --- If your project is set up for it, you can reply to this emai

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-06-07 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/530 Maybe I am misunderstanding the functionality here, but I see a split looking like this. Of course, you know the work better than me, so maybe there is a slightly different way we need to tackle

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-06-07 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/530 > @nickwallen: Or did you submit this to get buy-in as a proof-of-concept, that we can then break down into multiple, smaller PRs, get reviewed and then merged into master? I feel l

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-06-07 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/530 > No. I did not write that all out. Do you feel that is required for this? There is no such guide presently. Can that be a follow on? Sorry, but I disagree. I really think you need

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-06-06 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/530 Shouldn't I be able to build the new parser bundles and then deploy them somehow? Even if it is laborious to do with this PR, that would be the test. There has to be something net new tha

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-06-06 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/530 Can you outline a set of specific steps for testing this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-06-06 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/530 @ottobackwards What is your goal for this PR? 1. Do you want this merged as-is into master after review? 2. Or did you submit this to get buy-in as a proof-of-concept, that we can then

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-06-06 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/530 @ottobackwards Where are the "User Guide"-type docs? I want to start using your extension system as a user would and then work into the implementation from there. --- If your proj

[GitHub] metron pull request #608: METRON-986 Enhance Fastcapa to Support Intel X520

2017-06-05 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/608 METRON-986 Enhance Fastcapa to Support Intel X520 ### Changes The following changes have been made to Fastcapa to improve interoperability with the Intel X520 NIC, address bugs

[GitHub] metron issue #547: METRON-858 bro-plugin-kafka is throwing segfaults

2017-06-01 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/547 +1 Works like a charm. Tested basic functioning on a multi-node cluster against 1 gbps of canned traffic. Thanks for the contribution @JonZeolla ! --- If your project is set up for it, you

[GitHub] metron issue #570: METRON-937 Pycapa Consume Messages from Begin, End, or St...

2017-06-01 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/570 Please take a look-see. I'd like to get this fix in. Travis CI has passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] metron issue #570: METRON-937 Pycapa Consume Messages from Begin, End, or St...

2017-06-01 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/570 Travis is my friend --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] metron pull request #570: METRON-937 Pycapa Consume Messages from Begin, End...

2017-06-01 Thread nickwallen
Github user nickwallen closed the pull request at: https://github.com/apache/metron/pull/570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] metron pull request #570: METRON-937 Pycapa Consume Messages from Begin, End...

2017-06-01 Thread nickwallen
GitHub user nickwallen reopened a pull request: https://github.com/apache/metron/pull/570 METRON-937 Pycapa Consume Messages from Begin, End, or Stored Offsets ## Changes * I have altered Pycapa so that it can consume messages from either the beginning, end or the

[GitHub] metron issue #507: METRON-819: Document kafka console producer parameter for...

2017-05-31 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/507 +1 look great. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] metron pull request #598: METRON-974 Document How to Run Stellar REPL From S...

2017-05-30 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/598 METRON-974 Document How to Run Stellar REPL From Source Code ## Contributor Comments Document in the README how a user can run the Stellar REPL directly from the Metron source code

[GitHub] metron pull request #581: METRON-844: Install Metron Management UI with Amba...

2017-05-25 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/581#discussion_r118480283 --- Diff: metron-interface/metron-config/scripts/package.json --- @@ -9,7 +9,8 @@ "http-proxy-middleware": "0.17.4",

[GitHub] metron pull request #570: METRON-937 Pycapa Consume Messages from Begin, End...

2017-05-17 Thread nickwallen
GitHub user nickwallen reopened a pull request: https://github.com/apache/metron/pull/570 METRON-937 Pycapa Consume Messages from Begin, End, or Stored Offsets ## Changes * I have altered Pycapa so that it can consume messages from either the beginning, end or the

[GitHub] metron pull request #570: METRON-937 Pycapa Consume Messages from Begin, End...

2017-05-17 Thread nickwallen
Github user nickwallen closed the pull request at: https://github.com/apache/metron/pull/570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] metron issue #531: METRON-854 create dhcp dump parser

2017-05-16 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/531 > If i'm correctly informed by the docs, bro will give you the IP and MAC relation, which differs from DHCPDump which captures IP and Hostname relations. Giving context to an IP by ad

[GitHub] metron issue #531: METRON-854 create dhcp dump parser

2017-05-16 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/531 > So I would still like to discuss the opportunities of getting the original DHCPDump log format into Metron via NiFi. Sure, I think that sounds like another reasonable approach. ---

[GitHub] metron issue #584: METRON-950: Migrate storm-kafka-client to 1.1

2017-05-15 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/584 Does `pcap_inspector` only print out for TCP packets? The first 5 of those are all UDP based (NTP & DNS). --- If your project is set up for it, you can reply to this email and have your r

[GitHub] metron pull request #587: METRON-952 Travis CI Link in README Pointing to Ol...

2017-05-15 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/587 METRON-952 Travis CI Link in README Pointing to Old Repo The Travis CI status link in the README is pointing to the old apache/incubator-metron repository. I updated this point to apache/metron

[GitHub] metron pull request #570: METRON-937 Pycapa Consume Messages from Begin, End...

2017-05-14 Thread nickwallen
Github user nickwallen closed the pull request at: https://github.com/apache/metron/pull/570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] metron pull request #570: METRON-937 Pycapa Consume Messages from Begin, End...

2017-05-14 Thread nickwallen
GitHub user nickwallen reopened a pull request: https://github.com/apache/metron/pull/570 METRON-937 Pycapa Consume Messages from Begin, End, or Stored Offsets ## Changes * I have altered Pycapa so that it can consume messages from either the beginning, end or the

[GitHub] metron issue #570: METRON-937 Pycapa Consume Messages from Begin, End, or St...

2017-05-14 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/570 Travis ``` Running org.apache.metron.pcap.integration.PcapTopologyIntegrationTest ... ERROR ReadClusterState:345 - Error trying to shutdown workers in Thread[SLOT_1024,5,main

[GitHub] metron issue #586: METRON-508 Expand Elasticsearch templates to support the ...

2017-05-13 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/586 Actually, I meant the integration tests. The stuff under `metron-platform/metron-integration-test/src/main/sample/data/bro`. --- If your project is set up for it, you can reply to this email

[GitHub] metron issue #531: METRON-854 create dhcp dump parser

2017-05-13 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/531 I am a -1 on merging this PR. It relies on a forked version of the original sensor which limits its general usefulness. I have concerns about maintaining and supporting that fork long-term

[GitHub] metron issue #586: METRON-508 Expand Elasticsearch templates to support the ...

2017-05-13 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/586 Still need to review, but this is a great addition Jon. What pairs nicely with this is to expand the unit tests for the Bro parser to test the other log types that you include in this

[GitHub] incubator-metron issue #560: METRON-912: Metron vagrant setup steps no longe...

2017-05-10 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/560 +1 Looks good, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron pull request #570: METRON-937 Pycapa Consume Messages from ...

2017-05-09 Thread nickwallen
Github user nickwallen closed the pull request at: https://github.com/apache/incubator-metron/pull/570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-metron issue #570: METRON-937 Pycapa Consume Messages from Begin, ...

2017-05-09 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/570 travis! ``` --- T E S T S --- Running

[GitHub] incubator-metron pull request #570: METRON-937 Pycapa Consume Messages from ...

2017-05-09 Thread nickwallen
GitHub user nickwallen reopened a pull request: https://github.com/apache/incubator-metron/pull/570 METRON-937 Pycapa Consume Messages from Begin, End, or Stored Offsets ## Changes * I have altered Pycapa so that it can consume messages from either the beginning, end or

[GitHub] incubator-metron issue #560: METRON-912: Metron vagrant setup steps no longe...

2017-05-09 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/560 > I have not been able to find anybody who got Metron working on vagrant after only installing docker via `brew cask install docker`. Installing Docker with `brew cask inst

[GitHub] incubator-metron issue #520: METRON-833: Update MaaS documentation to explai...

2017-05-09 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/520 @cestella Reminder to resolve the conflicts here so we can get this merged in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-metron issue #565: METRON-931: Stellar REDUCE incorrectly returns ...

2017-05-09 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/565 +1 Good catch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-metron pull request #564: Metron-905 Fix square-bracket behavior a...

2017-05-09 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/564#discussion_r115499529 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/ELASTICSEARCH/2.3.3/configuration/elastic-site.xml

[GitHub] incubator-metron pull request #570: METRON-937 Pycapa Consume Messages from ...

2017-05-09 Thread nickwallen
Github user nickwallen closed the pull request at: https://github.com/apache/incubator-metron/pull/570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-metron issue #570: METRON-937 Pycapa Consume Messages from Begin, ...

2017-05-09 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/570 travis! ``` Running org.apache.metron.parsers.integration.YafIntegrationTest Running Sample Data Validation on sensorType yaf 2017-05-09 13:31:23 ERROR

[GitHub] incubator-metron pull request #570: METRON-937 Pycapa Consume Messages from ...

2017-05-09 Thread nickwallen
GitHub user nickwallen reopened a pull request: https://github.com/apache/incubator-metron/pull/570 METRON-937 Pycapa Consume Messages from Begin, End, or Stored Offsets ## Changes * I have altered Pycapa so that it can consume messages from either the beginning, end or

[GitHub] incubator-metron issue #555: METRON-902 ES improperly indexes Bro logs

2017-05-09 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/555 +1 by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-metron pull request #570: METRON-937 Pycapa Consume Messages from ...

2017-05-09 Thread nickwallen
GitHub user nickwallen reopened a pull request: https://github.com/apache/incubator-metron/pull/570 METRON-937 Pycapa Consume Messages from Begin, End, or Stored Offsets ## Changes * I have altered Pycapa so that it can consume messages from either the beginning, end or

[GitHub] incubator-metron issue #570: METRON-937 Pycapa Consume Messages from Begin, ...

2017-05-09 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/570 kick travis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-metron pull request #570: METRON-937 Pycapa Consume Messages from ...

2017-05-09 Thread nickwallen
Github user nickwallen closed the pull request at: https://github.com/apache/incubator-metron/pull/570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-metron pull request #570: METRON-937 Pycapa Consume Messages from ...

2017-05-08 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/incubator-metron/pull/570 METRON-937 Pycapa Consume Messages from Begin, End, or Stored Offsets ## Changes * I have altered Pycapa so that it can consume messages from either the beginning, end or the

[GitHub] incubator-metron issue #563: METRON-840: All "ambari_*" hosts need to have a...

2017-05-08 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/563 I deployed this to EC2 along with the code for #568 and #564. The deployment was successful and telemetry was flowing through end-to-end. Yay! +1 --- If your project is set

[GitHub] incubator-metron issue #568: METRON-935: EC2 Deployment Failure - Could Not ...

2017-05-08 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/568 I deployed this to EC2 along with the code for #563 and #564. The deployment was successful, Elasticsearch started and was green/happy, and telemetry was flowing through end-to-end

[GitHub] incubator-metron pull request #564: Metron-905 Fix square-bracket behavior a...

2017-05-08 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/564#discussion_r115272704 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/ELASTICSEARCH/2.3.3/configuration/elastic-site.xml

[GitHub] incubator-metron issue #560: METRON-912: Metron vagrant setup steps no longe...

2017-05-08 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/560 I tend to 'pin' my versions in Brew. I am more risk averse than you. ;) But your argument sounds reasonable. You convinced me. If we start to get negative reports

[GitHub] incubator-metron issue #560: METRON-912: Metron vagrant setup steps no longe...

2017-05-08 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/560 What versions of Vagrant or Virtualbox have you tested on? I would be hesitant to throw on a blanket "+" unless we have specifically tested on newer versions. --- If your

[GitHub] incubator-metron issue #563: METRON-840: All "ambari_*" hosts need to have a...

2017-05-06 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/563 I created METRON-935 to track the issue. Is this a quick fix that we can turn around or should we just revert the original commit? --- If your project is set up for it, you can reply

[GitHub] incubator-metron issue #553: METRON-896: Document Having Kerberos Issue Rene...

2017-05-06 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/553 +1 Looks good. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-metron issue #563: METRON-840: All "ambari_*" hosts need to have a...

2017-05-05 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/563 When spinning this up on EC2, I ran into this problem. Ever seen this before? Maybe unrelated to your PR. ``` TASK [ambari_config : Deploy cluster with Ambari; http://ec2

[GitHub] incubator-metron issue #564: Metron-905 Fix square-bracket behavior and defa...

2017-05-05 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/564 @mattf-horton I will test this on EC2. I am going to also test #563 at the same time. Thanks so much for fixing this! --- If your project is set up for it, you can reply to

[GitHub] incubator-metron issue #507: METRON-819: Document kafka console producer par...

2017-05-03 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/507 > can you elaborate on this fix/config a bit? I think we should definitely add this detail to the doc. It looks like you've created a yaf user and prin In the text that

[GitHub] incubator-metron issue #507: METRON-819: Document kafka console producer par...

2017-05-03 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/507 > I'm also curious about the difference in setup that required the jaas file here versus the original setup that allowed you to use the console consumer successfully per the

[GitHub] incubator-metron issue #562: METRON-915 add node and npm to platform_info.sh

2017-05-03 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/562 +1 Thanks, Otto! Tested on OSX and CentOS. Worked as expected. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-metron issue #547: METRON-858 bro-plugin-kafka is throwing segfaul...

2017-05-02 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/547 @JonZeolla Let me know when you have your "Outstanding Items" complete. Once you're happy, I'll run it through some testing. It is looking real good and seems r

[GitHub] incubator-metron issue #219: METRON-196 Fix support of ansible 2.1 in metron...

2017-04-28 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/219 @2xyo Did #499 take care of your concerns here (as @JonZeolla mentioned)? If so, please close this PR when you get a chance. Otherwise, please describe why this PR might still be

[GitHub] incubator-metron issue #555: METRON-902 ES improperly indexes Bro logs

2017-04-28 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/555 How should we test this @JonZeolla ? Can you layout some steps for us? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-metron issue #524: METRON-836 Use Pycapa with Kerberos

2017-04-28 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/524 > One last minor documentation issue: this PR description includes steps to install Python 2.7 but nowhere is that mentioned in the README. The latest README now mentions Pyt

[GitHub] incubator-metron issue #524: METRON-836 Use Pycapa with Kerberos

2017-04-28 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/524 Yes, good feedback. I had updated the README to mention Py 2.7, but I now just realized that I never pushed that out. Will get that pushed out and updated. --- If your project is

<    3   4   5   6   7   8   9   >