[GitHub] metron pull request #856: METRON-1339 Stellar Shell functionality to verify ...

2017-11-30 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/856#discussion_r154118407 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java --- @@ -0,0 +1,166 @@

[GitHub] metron pull request #856: METRON-1339 Stellar Shell functionality to verify ...

2017-11-30 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/856#discussion_r154114714 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java --- @@ -0,0 +1,166 @@

[GitHub] metron pull request #856: METRON-1339 Stellar Shell functionality to verify ...

2017-11-30 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/856#discussion_r15404 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java --- @@ -0,0 +1,166 @@

[GitHub] metron pull request #856: METRON-1339 Stellar Shell functionality to verify ...

2017-11-30 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/856#discussion_r154110765 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java --- @@ -0,0 +1,166 @@

[GitHub] metron pull request #856: METRON-1339 Stellar Shell functionality to verify ...

2017-11-30 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/856#discussion_r154110355 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java --- @@ -0,0 +1,166 @@

[GitHub] metron pull request #856: METRON-1339 Stellar Shell functionality to verify ...

2017-11-30 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/856#discussion_r154109552 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java --- @@ -0,0 +1,166 @@

[GitHub] metron pull request #856: METRON-1339 Stellar Shell functionality to verify ...

2017-11-30 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/856#discussion_r154105765 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java --- @@ -0,0 +1,166 @@

[GitHub] metron pull request #856: METRON-1339 Stellar Shell functionality to verify ...

2017-11-30 Thread ottobackwards
GitHub user ottobackwards opened a pull request: https://github.com/apache/metron/pull/856 METRON-1339 Stellar Shell functionality to verify stored stellar statements This will allow users to check their deployed statements, say after upgrade, when they are at rest ( and would

[GitHub] metron pull request #823: METRON-1286 Add MIN & MAX Stellar functions

2017-11-30 Thread jasper-k
Github user jasper-k closed the pull request at: https://github.com/apache/metron/pull/823 ---

[GitHub] metron pull request #823: METRON-1286 Add MIN & MAX Stellar functions

2017-11-30 Thread jasper-k
GitHub user jasper-k reopened a pull request: https://github.com/apache/metron/pull/823 METRON-1286 Add MIN & MAX Stellar functions ## Contributor Comments Currently Stellar lacks straightforward MAX & MIN functions that take just a list of values as input. The functions

[GitHub] metron pull request #823: METRON-1286 Add MIN & MAX Stellar functions

2017-11-29 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/823#discussion_r153968584 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/OrdinalFunctions.java --- @@ -18,76 +18,91 @@

[GitHub] metron pull request #823: METRON-1286 Add MIN & MAX Stellar functions

2017-11-29 Thread jasper-k
Github user jasper-k commented on a diff in the pull request: https://github.com/apache/metron/pull/823#discussion_r153942197 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/OrdinalFunctions.java --- @@ -18,76 +18,91 @@

[GitHub] metron pull request #823: METRON-1286 Add MIN & MAX Stellar functions

2017-11-29 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/823#discussion_r153926767 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/OrdinalFunctions.java --- @@ -18,76 +18,91 @@

[GitHub] metron pull request #823: METRON-1286 Add MIN & MAX Stellar functions

2017-11-29 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/823#discussion_r153927131 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/OrdinalFunctions.java --- @@ -18,76 +18,91 @@

[GitHub] metron pull request #823: METRON-1286 Add MIN & MAX Stellar functions

2017-11-29 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/823#discussion_r153919356 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/OrdinalFunctions.java --- @@ -0,0 +1,93 @@ +/** +

[GitHub] metron pull request #823: METRON-1286 Add MIN & MAX Stellar functions

2017-11-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/823#discussion_r153913510 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/OrdinalFunctions.java --- @@ -0,0 +1,93 @@ +/** + *

[GitHub] metron pull request #823: METRON-1286 Add MIN & MAX Stellar functions

2017-11-29 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/823#discussion_r153899916 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/OrdinalFunctions.java --- @@ -0,0 +1,93 @@ +/** +

[GitHub] metron pull request #823: METRON-1286 Add MIN & MAX Stellar functions

2017-11-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/823#discussion_r153898086 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/OrdinalFunctions.java --- @@ -0,0 +1,93 @@ +/** + *

[GitHub] metron pull request #855: METRON-1338 Excluding retry files from RAT check

2017-11-29 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/855 METRON-1338 Excluding retry files from RAT check When Vagrant fails, it generates a *.retry file. These files are ignored by Git, but will unnecessarily fail a build because of the Rat check.

[GitHub] metron pull request #854: Experimental Improvements - Feedback Only - Do Not...

2017-11-29 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/854 Experimental Improvements - Feedback Only - Do Not Merge This is a PR to get feedback on some minor improvements that I was experimenting with. If the community finds any of this useful, I will

[GitHub] metron pull request #853: METRON-1337: List of facets should not be hardcode...

2017-11-28 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/853 METRON-1337: List of facets should not be hardcoded ## Contributor Comments This PR makes the list of facet fields in the Alerts UI configurable. There is now a "search.facet.fields" setting

[GitHub] metron pull request #852: METRON-1239 Drop extra dev environments

2017-11-28 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/852 METRON-1239 Drop extra dev environments Per the previous discussion referenced in JIRA, this PR drops support for the Quick Dev and Code Lab environments. These have been effectively dead for

[GitHub] metron pull request #846: METRON-1328: Enhance platform-info.sh script to ch...

2017-11-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/846 ---

[GitHub] metron pull request #851: METRON-1336 Patching Can Result in Bad Configurati...

2017-11-28 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/851 METRON-1336 Patching Can Result in Bad Configuration The following problems are addressed in this PR. * A patch can be constructed that when applied creates an invalid configuration.

[GitHub] metron pull request #848: METRON-1333 Ensure that ansible-docker can be used...

2017-11-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/848 ---

[GitHub] metron pull request #850: METRON-1335: Install metron-maas-service RPM as a ...

2017-11-27 Thread anandsubbu
GitHub user anandsubbu opened a pull request: https://github.com/apache/metron/pull/850 METRON-1335: Install metron-maas-service RPM as a part of the full-dev deployment ## Contributor Comments Modified mpack metainfo.xml to install metron-maas-service RPM as well.

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

2017-11-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/803 ---

[GitHub] metron pull request #849: METRON-1334 Add C++11 Compliance Check to 'platfor...

2017-11-27 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/849#discussion_r153336117 --- Diff: metron-deployment/scripts/platform-info.sh --- @@ -73,6 +73,30 @@ echo "--" echo "npm" npm --version +# C++ compiler

[GitHub] metron pull request #849: METRON-1334 Add C++11 Compliance Check to 'platfor...

2017-11-27 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/849#discussion_r153334325 --- Diff: metron-deployment/scripts/platform-info.sh --- @@ -73,6 +73,30 @@ echo "--" echo "npm" npm --version +# C++ compiler

[GitHub] metron pull request #848: METRON-1333 Ensure that ansible-docker can be used...

2017-11-27 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/848#discussion_r15358 --- Diff: metron-deployment/packaging/docker/ansible-docker/README.md --- @@ -1,17 +1,34 @@ # Overview -The Metron ansible-docker container is

[GitHub] metron pull request #848: METRON-1333 Ensure that ansible-docker can be used...

2017-11-27 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/848#discussion_r153332780 --- Diff: metron-deployment/packaging/docker/ansible-docker/Dockerfile --- @@ -14,13 +14,18 @@ # See the License for the specific language

[GitHub] metron pull request #849: METRON-1334 Add C++11 Compliance Check to 'platfor...

2017-11-27 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/849#discussion_r153328847 --- Diff: metron-deployment/scripts/platform-info.sh --- @@ -73,6 +73,30 @@ echo "--" echo "npm" npm --version +# C++ compiler

[GitHub] metron pull request #848: METRON-1333 Ensure that ansible-docker can be used...

2017-11-27 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/848#discussion_r153327669 --- Diff: metron-deployment/packaging/docker/ansible-docker/README.md --- @@ -1,17 +1,34 @@ # Overview -The Metron ansible-docker container is

[GitHub] metron pull request #848: METRON-1333 Ensure that ansible-docker can be used...

2017-11-27 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/848#discussion_r153326885 --- Diff: metron-deployment/packaging/docker/ansible-docker/Dockerfile --- @@ -14,13 +14,18 @@ # See the License for the specific language governing

[GitHub] metron pull request #848: METRON-1333 Ensure that ansible-docker can be used...

2017-11-27 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/848#discussion_r153326917 --- Diff: metron-deployment/packaging/docker/ansible-docker/Dockerfile --- @@ -33,18 +38,28 @@ RUN tar xvf setuptools-11.3.tar.gz WORKDIR

[GitHub] metron pull request #849: METRON-1334 Add C++11 Compliance Check to 'platfor...

2017-11-27 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/849#discussion_r153325047 --- Diff: metron-deployment/scripts/platform-info.sh --- @@ -73,6 +73,30 @@ echo "--" echo "npm" npm --version +# C++ compiler

[GitHub] metron pull request #849: METRON-1334 Add C++11 Compliance Check to 'platfor...

2017-11-27 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/849#discussion_r153324714 --- Diff: metron-deployment/scripts/platform-info.sh --- @@ -73,6 +73,30 @@ echo "--" echo "npm" npm --version +# C++ compiler

[GitHub] metron pull request #849: METRON-1334 Add C++11 Compliance Check to 'platfor...

2017-11-27 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/849#discussion_r153322856 --- Diff: metron-deployment/scripts/platform-info.sh --- @@ -73,6 +73,30 @@ echo "--" echo "npm" npm --version +# C++ compiler

[GitHub] metron pull request #849: METRON-1334 Add C++11 Compliance Check to 'platfor...

2017-11-27 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/849#discussion_r153322627 --- Diff: metron-deployment/scripts/platform-info.sh --- @@ -73,6 +73,30 @@ echo "--" echo "npm" npm --version +# C++ compiler

[GitHub] metron pull request #849: METRON-1320 Add C++11 Compliance Check to platform...

2017-11-27 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/849 METRON-1320 Add C++11 Compliance Check to platform-info Some of the module dependencies for the Management and Alerts UI must be built natively on the host. This requires a C/C++ compiler. In

[GitHub] metron pull request #848: METRON-1333 Ensure that ansible-docker can be used...

2017-11-27 Thread ottobackwards
GitHub user ottobackwards opened a pull request: https://github.com/apache/metron/pull/848 METRON-1333 Ensure that ansible-docker can be used to build metron ( including rpms ) The ansible-docker container could be used to build metron ( even the rpms ) and run the ansible

[GitHub] metron pull request #840: METRON-939: Upgrade ElasticSearch and Kibana

2017-11-27 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/840#discussion_r153289006 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/files/snort_index.template --- @@

[GitHub] metron pull request #841: METRON-1316 Fastcapa Fails to Compile in Test Envi...

2017-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/841 ---

[GitHub] metron pull request #847: METRON-1313: Update metron-deployment to use bro-p...

2017-11-22 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/847#discussion_r152715716 --- Diff: metron-deployment/roles/bro/tasks/metron-bro-plugin-kafka.yml --- @@ -15,36 +15,34 @@ # limitations under the License. # ---

[GitHub] metron pull request #844: METRON-1088: Upgrade bro to 2.5.2

2017-11-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/844 ---

[GitHub] metron pull request #847: METRON-1313: Update metron-deployment to use bro-p...

2017-11-22 Thread JonZeolla
GitHub user JonZeolla opened a pull request: https://github.com/apache/metron/pull/847 METRON-1313: Update metron-deployment to use bro-pkg to install the kafka plugin ## Contributor Comments This PR requires #844. For testing, this PR currently references my fork of

[GitHub] metron pull request #846: METRON-1328: Enhance platform-info.sh script to ch...

2017-11-22 Thread anandsubbu
GitHub user anandsubbu opened a pull request: https://github.com/apache/metron/pull/846 METRON-1328: Enhance platform-info.sh script to check if docker daemon is running ## Contributor Comments Run the `docker info` command along with checking the version. **Case A -

[GitHub] metron pull request #814: METRON-1277 Add match statement to Stellar languag...

2017-11-21 Thread jjmeyer0
Github user jjmeyer0 commented on a diff in the pull request: https://github.com/apache/metron/pull/814#discussion_r152456690 --- Diff: metron-stellar/stellar-common/src/main/antlr4/org/apache/metron/stellar/common/generated/Stellar.g4 --- @@ -254,6 +259,7 @@ identifier_operand :

[GitHub] metron pull request #843: METRON-1319: Column Metadata REST service should u...

2017-11-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/843 ---

[GitHub] metron pull request #843: METRON-1319: Column Metadata REST service should u...

2017-11-21 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/843#discussion_r152347240 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/SearchServiceImpl.java --- @@ -96,6 +96,11 @@ public

[GitHub] metron pull request #843: METRON-1319: Column Metadata REST service should u...

2017-11-21 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/843#discussion_r152347150 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/SearchControllerIntegrationTest.java --- @@ -132,6 +132,30 @@

[GitHub] metron pull request #843: METRON-1319: Column Metadata REST service should u...

2017-11-21 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/843#discussion_r152347116 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/SearchServiceImpl.java --- @@ -96,6 +96,11 @@ public

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

2017-11-21 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r152311299 --- Diff: metron-interface/metron-alerts/e2e/alerts-list/meta-alerts/meta-alert.po.ts --- @@ -0,0 +1,43 @@ +/** + * Licensed to the Apache

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

2017-11-21 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r152310478 --- Diff: metron-interface/metron-alerts/e2e/alerts-list/meta-alerts/meta-alert.po.ts --- @@ -0,0 +1,43 @@ +/** + * Licensed to the Apache

[GitHub] metron pull request #845: METRON-1321 Metaalert Threat Score Type Does Not M...

2017-11-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/845 ---

[GitHub] metron pull request #845: METRON-1321 Metaalert Threat Score Type Does Not M...

2017-11-20 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/845#discussion_r152083195 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java --- @@ -614,8 +625,15 @@

[GitHub] metron pull request #845: METRON-1321 Metaalert Threat Score Type Does Not M...

2017-11-20 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/845#discussion_r152081656 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java --- @@ -614,8 +625,15

[GitHub] metron pull request #845: METRON-1321 Metaalert Threat Score Type Does Not M...

2017-11-20 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/845#discussion_r152077236 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java --- @@ -614,8 +625,15 @@

[GitHub] metron pull request #845: METRON-1321 Metaalert Threat Score Type Does Not M...

2017-11-20 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/845#discussion_r152075990 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java --- @@ -614,8 +625,15 @@

[GitHub] metron pull request #845: METRON-1321 Metaalert Threat Score Type Does Not M...

2017-11-20 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/845#discussion_r152069979 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java --- @@ -614,8 +625,15

[GitHub] metron pull request #845: METRON-1321 Metaalert Threat Score Type Does Not M...

2017-11-20 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/845 METRON-1321 Metaalert Threat Score Type Does Not Match Sensor Indices After creating Metaalerts in the Alerts UI, I am unable to sort by threat triage score. The exception that is logged is

[GitHub] metron pull request #844: METRON-1088: Upgrade bro to 2.5.2

2017-11-20 Thread JonZeolla
Github user JonZeolla commented on a diff in the pull request: https://github.com/apache/metron/pull/844#discussion_r152067166 --- Diff: metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/bro/BasicBroParserTest.java --- @@ -1133,6 +1133,233 @@ public void

[GitHub] metron pull request #844: METRON-1088: Upgrade bro to 2.5.2

2017-11-20 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/844#discussion_r152052808 --- Diff: metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/bro/BasicBroParserTest.java --- @@ -1133,6 +1133,233 @@ public void

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

2017-11-20 Thread iraghumitra
Github user iraghumitra commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r151964471 --- Diff: metron-interface/metron-alerts/src/app/alerts/alert-details/alert-details.component.scss --- @@ -143,3 +167,12 @@ textarea {

[GitHub] metron pull request #844: METRON-1088: Upgrade bro to 2.5.2

2017-11-19 Thread JonZeolla
GitHub user JonZeolla opened a pull request: https://github.com/apache/metron/pull/844 METRON-1088: Upgrade bro to 2.5.2 ## Contributor Comments This upgrades bro to 2.5.2, and natively provides support for many of the fields from a default bro 2.5.2 install. Specifically,

[GitHub] metron pull request #843: METRON-1319: Column Metadata REST service should u...

2017-11-17 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/843#discussion_r151801296 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/SearchControllerIntegrationTest.java --- @@ -132,6 +132,30 @@

[GitHub] metron pull request #843: METRON-1319: Column Metadata REST service should u...

2017-11-17 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/843#discussion_r151799957 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/SearchControllerIntegrationTest.java --- @@ -132,6 +132,30 @@

[GitHub] metron pull request #843: METRON-1319: Column Metadata REST service should u...

2017-11-17 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/843#discussion_r151798907 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/SearchServiceImpl.java --- @@ -96,6 +96,11 @@ public

[GitHub] metron pull request #843: METRON-1319: Column Metadata REST service should u...

2017-11-17 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/843#discussion_r151799462 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/SearchServiceImpl.java --- @@ -96,6 +96,11 @@ public

[GitHub] metron pull request #843: METRON-1319: Column Metadata REST service should u...

2017-11-17 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/843 METRON-1319: Column Metadata REST service should use default indices on empty input ## Contributor Comments This PR adjusts the Column Metadata REST service to use a list of default indices

[GitHub] metron pull request #832: METRON-1301 Sorting on Triage Score Unexpectedly F...

2017-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/832 ---

[GitHub] metron pull request #827: METRON-1294: IP addresses are not formatted correc...

2017-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/827 ---

[GitHub] metron pull request #826: METRON-1291: Kafka produce REST endpoint does not ...

2017-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/826 ---

[GitHub] metron pull request #842: METRON-1290: Only first 10 alerts are update when ...

2017-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/842 ---

[GitHub] metron pull request #825: METRON-1290: Only first 10 alerts are update when ...

2017-11-16 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/825 ---

[GitHub] metron pull request #826: METRON-1291: Kafka produce REST endpoint does not ...

2017-11-16 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/826#discussion_r151450858 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/config/KafkaConfig.java --- @@ -108,6 +108,9 @@ public ZkUtils zkUtils() {

[GitHub] metron pull request #842: METRON-1290: Only first 10 alerts are update when ...

2017-11-16 Thread justinleet
GitHub user justinleet opened a pull request: https://github.com/apache/metron/pull/842 METRON-1290: Only first 10 alerts are update when a MetaAlert status is changed to inactive ## Contributor Comments This PR supercedes https://github.com/apache/metron/pull/825. The fix was

[GitHub] metron pull request #839: METRON-1311 Service Check Should Check Elasticsear...

2017-11-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/839 ---

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/824 ---

[GitHub] metron pull request #841: METRON-1316 Fastcapa Fails to Compile in Test Envi...

2017-11-15 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/841 METRON-1316 Fastcapa Fails to Compile in Test Environment DPDK 16.11.1 will no longer compile against newer Linux kernels due to an interface change in the kernel. This can be

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-15 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r151203066 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/MetaAlertController.java --- @@ -60,5 +63,37 @@ ) throws

[GitHub] metron pull request #774: METRON-1212 The bundle system and maven plugin

2017-11-15 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/774#discussion_r151198323 --- Diff: bundles-maven-plugin/README.md --- @@ -0,0 +1,230 @@ + +# Apache Metron Bundle Maven Plugin + +Apache Metron Bundles Maven

[GitHub] metron pull request #774: METRON-1212 The bundle system and maven plugin

2017-11-15 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/774#discussion_r151196532 --- Diff: bundles-maven-plugin/README.md --- @@ -0,0 +1,230 @@ + +# Apache Metron Bundle Maven Plugin + +Apache Metron Bundles Maven

[GitHub] metron pull request #831: METRON-1302: Split up Indexing Topology into batch...

2017-11-15 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/831#discussion_r151190365 --- Diff: metron-platform/metron-indexing/src/main/scripts/start_hdfs_topology.sh --- @@ -0,0 +1,22 @@ +#!/bin/bash +# +# Licensed to the

[GitHub] metron pull request #831: METRON-1302: Split up Indexing Topology into batch...

2017-11-15 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/831#discussion_r151190210 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_commands.py --- @@

[GitHub] metron pull request #831: METRON-1302: Split up Indexing Topology into batch...

2017-11-15 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/831#discussion_r151189633 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-indexing-env.xml --- @@

[GitHub] metron pull request #831: METRON-1302: Split up Indexing Topology into batch...

2017-11-15 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/831#discussion_r151189543 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-indexing-env.xml --- @@

[GitHub] metron pull request #826: METRON-1291: Kafka produce REST endpoint does not ...

2017-11-15 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/826#discussion_r151149320 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/config/KafkaConfig.java --- @@ -108,6 +108,9 @@ public ZkUtils zkUtils() {

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-14 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150998084 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -138,9 +142,17 @@ private Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-14 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150995571 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -138,9 +142,17 @@ private Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-14 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150994812 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -138,9 +142,17 @@ private Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-14 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150892216 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -135,8 +138,9 @@ private Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-14 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150889867 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -135,8 +138,9 @@ private Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-14 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150887809 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -135,8 +138,9 @@ private Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-14 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150874132 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -135,8 +138,9 @@ private Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-14 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150872247 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -135,8 +138,9 @@ private Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-14 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150868283 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -135,8 +138,9 @@ private Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-14 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150867558 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -135,8 +138,9 @@ private Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-14 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150866003 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -135,8 +138,9 @@ private Document

[GitHub] metron pull request #824: METRON-1289: Alert fields are lost when a MetaAler...

2017-11-14 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/824#discussion_r150854643 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/HBaseDao.java --- @@ -135,8 +138,9 @@ private Document

<    3   4   5   6   7   8   9   10   11   12   >