[GitHub] metron issue #817: METRON-1283: Install Elasticsearch template as a part of ...

2017-10-30 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/817 +1, thanks! ---

[GitHub] metron issue #817: METRON-1283: Install Elasticsearch template as a part of ...

2017-10-29 Thread anandsubbu
Github user anandsubbu commented on the issue: https://github.com/apache/metron/pull/817 I have added this to the Elasticsearch README in my recent commit. Please see here: https://github.com/apache/metron/pull/817/files#diff-325aea0d364d12c8637eef347ebcfca6 The

[GitHub] metron issue #817: METRON-1283: Install Elasticsearch template as a part of ...

2017-10-29 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/817 I think we need to document this somewhere. I am not sure where though. ---

[GitHub] metron issue #817: METRON-1283: Install Elasticsearch template as a part of ...

2017-10-29 Thread anandsubbu
Github user anandsubbu commented on the issue: https://github.com/apache/metron/pull/817 Hi @ottobackwards , let me know what you think. ---

[GitHub] metron issue #817: METRON-1283: Install Elasticsearch template as a part of ...

2017-10-29 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/817 +1 Thanks for fixing this @anandsubbu! This takes out a manual step that if missed can cause some ugly, unexpected problems. This is contingent on getting @ottobackwards buy-in before

[GitHub] metron issue #817: METRON-1283: Install Elasticsearch template as a part of ...

2017-10-29 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/817 How are we going to document all this? ---

[GitHub] metron issue #817: METRON-1283: Install Elasticsearch template as a part of ...

2017-10-29 Thread anandsubbu
Github user anandsubbu commented on the issue: https://github.com/apache/metron/pull/817 If the install fails the first time due to ES being down, then we WARN and move on. If ES service comes up later, the admin needs to install the templates subsequently by using 'Ambari -> Metron

[GitHub] metron issue #817: METRON-1283: Install Elasticsearch template as a part of ...

2017-10-28 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/817 If the indexing start doesn't install the templates because ES is down or something, will they be installed if restarted and ES is available, or is it one shot, pass or fail. ---

[GitHub] metron issue #817: METRON-1283: Install Elasticsearch template as a part of ...

2017-10-28 Thread anandsubbu
Github user anandsubbu commented on the issue: https://github.com/apache/metron/pull/817 You're right @nickwallen , it wouldn't work. I reworked on the patch and here are the latest changes: - moved the ES template installation back to the Indexing "start" method - use a flag

[GitHub] metron issue #817: METRON-1283: Install Elasticsearch template as a part of ...

2017-10-27 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/817 > Hi @nickwallen - sure, what you are saying makes sense to me. To address point 1, I have moved the ES template installation step into the Indexing "Install" method, Did this work for

[GitHub] metron issue #817: METRON-1283: Install Elasticsearch template as a part of ...

2017-10-27 Thread anandsubbu
Github user anandsubbu commented on the issue: https://github.com/apache/metron/pull/817 Restarting travis ---

[GitHub] metron issue #817: METRON-1283: Install Elasticsearch template as a part of ...

2017-10-27 Thread anandsubbu
Github user anandsubbu commented on the issue: https://github.com/apache/metron/pull/817 Hi @ottobackwards , made the change to remove the ES template installation from 'load_web_template' role for vagrant deployments. Fired up full-dev with the change and it comes up fine. Was able

[GitHub] metron issue #817: METRON-1283: Install Elasticsearch template as a part of ...

2017-10-26 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/817 Hi @anandsubbu - Just a few issues that came to mind. These may or may not be problems, so I just wanted to open them for discussion. 1. This will reinstall the same templates each time

[GitHub] metron issue #817: METRON-1283: Install Elasticsearch template as a part of ...

2017-10-26 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/817 The templates are installed from ansible right now for the vagrant builds. Wouldn't we need to remove that step? Have you tested full_dev ? ---