Done.
--
Aaron Radzinski
On Tue, Jun 9, 2020 at 1:08 AM Paul King wrote:
> Probably also worth removing the 0.5.0 top level directory as well.
>
> Cheers, Paul.
>
>
> On Tue, Jun 2, 2020 at 6:18 AM wrote:
>
> > Author: aradzinski
> > Date: Mon Jun 1 20:18:20 2020
> > New Revision: 39877
> >
Okay, if you believe it is a platform specific thing, I will change my vote
to +1.
The tests ran fine for me under Ubuntu natively and under WSL2 on the
Windows machine.
I'd recommend a small note in your ANNOUNCE email (or README) suggesting
Windows users use WSL2 if they run into any problems.
C
+1 (see note below)
Checked:
- DISCLAIMER, LICENSE, NOTICE files
- PGP sigs
- compiles & tests pass
- Apache RAT ok
NOTE: I unearthed a Windows laptop and run 'mvn clean verify' under
Windows. All tests passed. However, I do believe we may have a problem when
the same Ignite installation is re-us
Hi,
+1 from me.
I checked:
- Incubating in name
- DISCLAIMER exists
- LICENSE and NOTICE are fine
- No unexpected binary files
- Checked PGP signatures
- Checked Checksums
- Code compiles and tests successfully run
- Apache rat checks are OK
PS 1: VOTE mail body says GitHub v0.6.0 tag but it is
+1
Tested (Linux)
- verify
- files
Gleb.
Sent with ProtonMail Secure Email.
‐‐‐ Original Message ‐‐‐
On Tuesday, June 9, 2020 10:22 AM, Sergey Kamov wrote:
> +1
>
> tested under win (JDK8) and mac (JDK8)
>
> -`maven clean verify`
>
> - examples tests
>
> - files
>
> Remark pom.xm
+1
tested under win (JDK8) and mac (JDK8)
-`maven clean verify`
- examples tests
- files
Remark pom.xml scm tag 0.6.0 is incorrect. It should be
`v0.6.1` - please don't miss it next time.
Paul. I have created additional ticket,
https://issues.apache.org/jira/browse/NLPCRAFT-77, so we
Sergey Kamov created NLPCRAFT-77:
Summary: Ignite cache should be cleared before suite started
Key: NLPCRAFT-77
URL: https://issues.apache.org/jira/browse/NLPCRAFT-77
Project: NLPCraft
Issue
[
https://issues.apache.org/jira/browse/NLPCRAFT-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129311#comment-17129311
]
Paul King commented on NLPCRAFT-76:
---
I added in all three failures.
> Test failure on
[
https://issues.apache.org/jira/browse/NLPCRAFT-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul King updated NLPCRAFT-76:
--
Description:
{noformat}
1. Test failed: Result failed [text=tomorrow, error=Processing failed due to a
[
https://issues.apache.org/jira/browse/NLPCRAFT-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul King updated NLPCRAFT-76:
--
Description:
{noformat}
1. Test failed: Result failed [text=tomorrow, error=Processing failed due to a
[
https://issues.apache.org/jira/browse/NLPCRAFT-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul King updated NLPCRAFT-76:
--
Description:
{noformat}
1. Test failed: Result failed [text=tomorrow, error=Processing failed due to a
[
https://issues.apache.org/jira/browse/NLPCRAFT-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul King updated NLPCRAFT-76:
--
Description:
{noformat}
1. Test failed: Result failed [text=tomorrow, error=Processing failed due to a
[
https://issues.apache.org/jira/browse/NLPCRAFT-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul King updated NLPCRAFT-76:
--
Description:
{noformat}
1. Test failed: Result failed [text=tomorrow, error=Processing failed due to a
I added the log for the first failing test to:
https://issues.apache.org/jira/browse/NLPCRAFT-76
The other tests look similar but let me know if you want them also.
Cheers, Paul.
On Tue, Jun 9, 2020 at 9:44 PM Sergey Kamov wrote:
> Hi Paul
> Thank you for your remarks.
>
> There are 3 kinds
Paul King created NLPCRAFT-76:
-
Summary: Test failure on Windows
Key: NLPCRAFT-76
URL: https://issues.apache.org/jira/browse/NLPCRAFT-76
Project: NLPCraft
Issue Type: Bug
Affects Versions: 0.
Hi Paul
Thank you for your remarks.
There are 3 kinds of problem
1) Some deserialization warnings
>> Failed to unmarshal object with optimized marshaller
..
I have created ticket - https://issues.apache.org/jira/browse/NLPCRAFT-75
These warnings are not critical for our release I guess, but we h
Sergey Kamov created NLPCRAFT-75:
Summary: Fix warings
Key: NLPCRAFT-75
URL: https://issues.apache.org/jira/browse/NLPCRAFT-75
Project: NLPCraft
Issue Type: Improvement
Components:
Sergey Kamov created NLPCRAFT-74:
Summary: Weather example
Key: NLPCRAFT-74
URL: https://issues.apache.org/jira/browse/NLPCRAFT-74
Project: NLPCraft
Issue Type: Improvement
Componen
[
https://issues.apache.org/jira/browse/NLPCRAFT-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Kamov updated NLPCRAFT-12:
-
Fix Version/s: 0.7.0
> Introduce 'not' function.
> -
>
>
I am +0 (on the basis that you aren't expecting the failures under Windows)
but I'm happy to change to +1 if I am doing something wrong or if you
believe it is something in my environment. I had no problems under Linux.
I checked:
- "incubating" in name
- DISCLAIMER exists
- LICENSE and NOTICE lo
Ignore my last email. I just saw the result vote. It wasn't threaded in my
email client and the order was not what I was expecting.
Cheers, Paul.
On Tue, Jun 9, 2020 at 5:36 PM Paul King wrote:
> +1
>
> Also, it is good practice to close off the vote so that the result is
> clear in the email h
Probably also worth removing the 0.5.0 top level directory as well.
Cheers, Paul.
On Tue, Jun 2, 2020 at 6:18 AM wrote:
> Author: aradzinski
> Date: Mon Jun 1 20:18:20 2020
> New Revision: 39877
>
> Log:
> Removed 0.5.0 from dev area.
>
> Removed:
>
> dev/incubator/nlpcraft/nlpcraft/0.5.0/apa
+1
Also, it is good practice to close off the vote so that the result is clear
in the email history.
cheers, Paul.
On Fri, May 29, 2020 at 6:31 PM Sergey Kamov wrote:
> NLPCrafters,
>
> based on [1] discussion lets start a vote on branching policy:
> - all logical tasks should be split into
23 matches
Mail list logo
