Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

esday, March 17, 2020 12:10 PM > *To:* David Sidrane > *Cc:* dev@nuttx.apache.org > *Subject:* Re: Nuttx Code Formatter Progress [Was RE: Should we relax > precheck a little bit?] > > > > David, > > > > Yes, I agree that it would be great if we can upstream the ch

Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

Re: # indenting. I am not sure I understand your comments about this. Are the NuttX Style Guide sections on indenting correct? If so, we can probably add clang-format options to support this style. If not, can we

RE: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

Hi Adam, See inline… *From:* Adam Feuer [mailto:a...@starcat.io] *Sent:* Tuesday, March 17, 2020 12:10 PM *To:* David Sidrane *Cc:* dev@nuttx.apache.org *Subject:* Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?] David, Yes, I agree that it would

Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

> David > > > > > > > > *From:* Adam Feuer [mailto:a...@starcat.io] > *Sent:* Monday, March 16, 2020 3:35 PM > *To:* David Sidrane; dev@nuttx.apache.org > *Subject:* Re: Nuttx Code Formatter Progress [Was RE: Should we relax > precheck a little bit?] > &

RE: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

uch greater. David *From:* Adam Feuer [mailto:a...@starcat.io] *Sent:* Monday, March 16, 2020 3:35 PM *To:* David Sidrane; dev@nuttx.apache.org *Subject:* Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?] Here's a Github compare with .clang-format f

Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

Yes, it may be horrible. Please don't look at the results right now then... this is a work in progress. Okay.  Thanks for clarifying that.  nxstyle is still your friend.

Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

 ...  It is simply not following the NuttX coding standard. Perhaps what you should do is also run the modified files through nxstyle.  nxstyle, like most tools, is imperfect but it is the yardstick we use to evaluating conformance to the coding standard now.  Certainly a first step would

Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

Hi Greg, Yes, it may be horrible. Please don't look at the results right now then... this is a work in progress. I'm just trying to do the development and coordination in the open, as the Apache folks have asked— no off-list communication, right? I just posted these so David and others could

Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

I mentioned in the previous email that the tools was screwing up vertifcal alignment is places where it is recommend and in places where is it required.  Here is an example of the later: * sched/irq/irq.h

Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

Here's a Github compare with .clang-format file and the results when clang-format-9 is run on all the files under sched/: https://github.com/apache/incubator-nuttx/compare/master...starcat-io:explore/clang-format-sched If anyone has comments or observations I would love to know them. That

Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

;> >> >> >> *From:* Adam Feuer [mailto:a...@starcat.io] >> *Sent:* Saturday, March 14, 2020 1:59 PM >> *To:* dev@nuttx.apache.org; david.sidr...@nscdg.com; w8j...@gmail.com >> *Subject:* Re: Nuttx Code Formatter Progress [Was RE: Should we relax >> prec

Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

> SpacesInAngles: false > SpacesInContainerLiterals: true > SpacesInCStyleCastParentheses: false > SpacesInParentheses: false > SpacesInSquareBrackets: false > Standard:Cpp03 > StatementMacros: > - Q_UNUSED > - QT_REQUIRE_VERSION > TabWidth:8

Re: Should we relax precheck a little bit?

etreff: Re: Should we relax precheck a little bit? > Yeah I thought about the too > > But think of the can of worm on the commit history: Every PR touches the cfg > file. I don't see that.  Modifications to the white list file, whatever it is called, would be very rare.  Only wh

RE: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

d *From:* Adam Feuer [mailto:a...@starcat.io] *Sent:* Saturday, March 14, 2020 1:59 PM *To:* dev@nuttx.apache.org; david.sidr...@nscdg.com; w8j...@gmail.com *Subject:* Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?] I looked at the clang-format source code. It h

Re: Should we relax precheck a little bit?

Yeah I thought about the too But think of the can of worm on the commit history: Every PR touches the cfg file. I don't see that.  Modifications to the white list file, whatever it is called, would be very rare.  Only when a new non-compliant name is added which should be never. We

Re: Should we relax precheck a little bit?

How about we put this special treatment to another file(e.g. nxstyle.cfg)? So we don't pollute the source code. +1 I like it.  I just suggested basically the same think in the PR.  I suggested the name .nxignore. If a .nxignore file exists in the same directory as the file under test,

RE: Should we relax precheck a little bit?

@nuttx.apache.org Subject: Re: Should we relax precheck a little bit? How about we put this special treatment to another file(e.g. nxstyle.cfg)? So we don't pollute the source code. On Sun, Mar 15, 2020 at 7:47 PM Schock, Johannes - NIVUS GmbH wrote: > > Hello, > I filed a pull request that i

Re: Should we relax precheck a little bit?

How about we put this special treatment to another file(e.g. nxstyle.cfg)? So we don't pollute the source code. On Sun, Mar 15, 2020 at 7:47 PM Schock, Johannes - NIVUS GmbH wrote: > > Hello, > I filed a pull request that introduces an idea of controlling the behaviour > of nxstyle from inside

Re: Should we relax precheck a little bit?

I am oppose to modyfing source files to support the tool.  I don't think we should go that direction.Sent from Samsung tablet. Original message From: "Schock, Johannes - NIVUS GmbH" Date: 3/15/20 5:47 AM (GMT-06:00) To: dev@nuttx.apache.org Subject: Re: Shoul

Re: Should we relax precheck a little bit?

Hello, I filed a pull request that introduces an idea of controlling the behaviour of nxstyle from inside the file under test. https://github.com/apache/incubator-nuttx/pull/569 This would allow to address some special requirements that are needed in cornercases (e.g. whitelisting), and, by

Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

UNUSED > - QT_REQUIRE_VERSION > TabWidth:8 > UseTab: Never > ... > > > > > On Sat, Mar 14, 2020 at 1:29 AM David Sidrane > wrote: > >> Hi Adam and Maciej, >> >> Thank you for spending you time on this. It will be a huge win for >

Re: Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

e "last > mile" > looks like. > > David > > -Original Message- > From: Adam Feuer [mailto:a...@starcat.io] > Sent: Friday, March 13, 2020 7:08 PM > To: dev@nuttx.apache.org > Subject: Re: Should we relax precheck a little bit? > > Maciej, > >

Nuttx Code Formatter Progress [Was RE: Should we relax precheck a little bit?]

t fix the malformations. So once you feel have something that is close, let's evaluate it and see what the "last mile" looks like. David -Original Message- From: Adam Feuer [mailto:a...@starcat.io] Sent: Friday, March 13, 2020 7:08 PM To: dev@nuttx.apache.org Subject: Re: Should we relax pr

Re: Should we relax precheck a little bit?

Maciej, Thank you! I didn't know about the IndentPPDirectives option! I will try it! :) -adam On Fri, Mar 13, 2020 at 5:16 PM Maciej Wójcik wrote: > Are you sure that clang-format cannot indent macros? What about > > IndentPPDirectives: PPDIS_AfterHash > > It also treats the outmost macro

Re: Should we relax precheck a little bit?

Are you sure that clang-format cannot indent macros? What about IndentPPDirectives: PPDIS_AfterHash It also treats the outmost macro in headers in a special way. On Sat, 14 Mar 2020, 01:03 Adam Feuer, wrote: > David, > > Re: whatstyle, I ran it overnight on the c files in sched/ and came up

Re: Should we relax precheck a little bit?

David, Re: whatstyle, I ran it overnight on the c files in sched/ and came up with a clang-format that does somewhat ok. Thanks for pointing that program out. By looking at the output of the diff, I learned a lot about how hard it is to manually format programs. :) Anyway, the biggest problem

RE: Should we relax precheck a little bit?

See inline -Original Message- From: Xiang Xiao [mailto:xiaoxiang781...@gmail.com] Sent: Wednesday, March 11, 2020 8:11 AM To: dev@nuttx.apache.org Subject: Re: Should we relax precheck a little bit? It isn't good to change the licenses in one patch because: 1.We need review all licenses

Re: Should we relax precheck a little bit?

It isn't good to change the licenses in one patch because: 1.We need review all licenses change more carefully, mixing style change make all reviewer lose the focus. 2.People outside the team may need recheck the licenses change to enuse no any IP pollution. 3.We need find a way to revert the

Re: Should we relax precheck a little bit?

On Wed, Mar 11, 2020 at 5:43 PM 张铎(Duo Zhang) wrote: > > A possible rule is to not make new nxstyle issues. > You can run nxstyle twice, before the patch and after the patch, and check > the difference to see if there are new violations. > > It may not be accurate but basiclly works, and

Re: Should we relax precheck a little bit?

On Wed, Mar 11, 2020 at 8:13 AM David Sidrane wrote: > First, I have to say that I value the NuttX coding standard - it make for > the most readable code I have EVERY worked on. I want it preserved. > > But in light of the below discussion: I am changing my position that the > "rule" CI is to

RE: Should we relax precheck a little bit?

x the tool _THEN_ fix the code with it. David -Original Message- From: Xiang Xiao [mailto:xiaoxiang781...@gmail.com] Sent: Wednesday, March 11, 2020 12:42 AM To: dev@nuttx.apache.org Subject: Re: Should we relax precheck a little bit? On Wed, Mar 11, 2020 at 2:49 PM Takashi Yamamoto wro

Re: Should we relax precheck a little bit?

A possible rule is to not make new nxstyle issues. You can run nxstyle twice, before the patch and after the patch, and check the difference to see if there are new violations. It may not be accurate but basiclly works, and committers do not need to check it manually to find out whether the patch

Re: Should we relax precheck a little bit?

On Wed, Mar 11, 2020 at 2:49 PM Takashi Yamamoto wrote: > > we basically prevent changes on files unless you can fix all nxstyle > issues in them. > i don't think it's a good idea. > > i believe that there can be changes more important than style fixes. > in addition to -r option you suggested, >

Re: Should we relax precheck a little bit?

we basically prevent changes on files unless you can fix all nxstyle issues in them. i don't think it's a good idea. i believe that there can be changes more important than style fixes. in addition to -r option you suggested, i'd suggest to make precheck separate from other (IMO more important)

Re: Should we relax precheck a little bit?

On Tue, Mar 10, 2020 at 3:43 PM Xiang Xiao wrote: > > On Tue, Mar 10, 2020 at 1:17 AM Gregory Nutt wrote: > > > > > > > - Fixing the entire file we touch helps makes things better overall > > > even > > > though its painful in the short run. > > > - Having a tool that produces

Re: Re: Should we relax precheck a little bit?

On Mon, Mar 9, 2020 at 6:09 AM Peter Van Der Perk wrote: > > Hi Adam, > > I've been trying to make a clang-format for NuttX however I did run in some > nasty bugs with clang-format. > Mostly the inconsistent spacing caused by preprocessor directives (#ifdef) > etc. > I've filed a bug on the

Re: Should we relax precheck a little bit?

On Tue, Mar 10, 2020 at 1:17 AM Gregory Nutt wrote: > > > > - Fixing the entire file we touch helps makes things better overall even > > though its painful in the short run. > > - Having a tool that produces accurate style recommendations is very > > important— it's hard to know

Re: Should we relax precheck a little bit?

Having gone through a cycle of fixing a medium-sized PR recently, here are my thoughts: - Fixing the entire file we touch helps makes things better overall even though its painful in the short run. - Having a tool that produces accurate style recommendations is very important— it's

Re: Should we relax precheck a little bit?

Yes, that is why I send this email to get the community feedback. To avoid the topic extend to the unrelated field, let's just focus on one thing I suggest: The github action just check the coding style for the modified lines in the patch, not the whole source lines. I am in favor of keeping

Re: Should we relax precheck a little bit?

How much time should we wait before starting a vote? When you know the vote will be in favour of your position is the time to call a vote. Actually in favour is probably too strong a position to take, it’s more that no-one would be against this course of action even if they may 100% agree

RE: Should we relax precheck a little bit?

I agree with Alin. -1 -Original Message- From: Alin Jerpelea [mailto:jerpe...@gmail.com] Sent: Monday, March 09, 2020 5:36 AM To: dev@nuttx.apache.org Subject: Re: Should we relax precheck a little bit? -1 I thin that as a long term goal we should aim to have it enabled and leave each

Re: Should we relax precheck a little bit?

-1 I thin that as a long term goal we should aim to have it enabled and leave each contributor to fix the styles as commits come in This way we will gradually have all violations fixed Alin On Mon, Mar 9, 2020 at 1:22 PM Justin Mclean wrote: > Hi, > > Sorry late here - what I should have said

Re: Should we relax precheck a little bit?

Hi, Sorry late here - what I should have said is “may NOT 100% agree with it.”. Justin

Re: Should we relax precheck a little bit?

Hi, > How much time should we wait before starting a vote? When you know the vote will be in favour of your position is the time to call a vote. Actually in favour is probably too strong a position to take, it’s more that no-one would be against this course of action even if they may 100%

Re: Should we relax precheck a little bit?

On Sun, Mar 8, 2020 at 9:30 AM Gregory Nutt wrote: > > > > Since there's no current maintainer for nxstyle... What would people think > > about trying Clang-Format ? > > > > It's a well-used tool (LLVM, Google, Chromium, Mozilla, Webkit, and > >

Re: Should we relax precheck a little bit?

On Mon, Mar 9, 2020 at 12:52 PM Justin Mclean wrote: > > Hi, > > > I basically agree with most of the things you say here, but in an Apache > > project, you cannot set rules unilaterally. No one person has that > > authority over the project. We all all equals. Decisions can only be made >

Re: Should we relax precheck a little bit?

Hi, > I basically agree with most of the things you say here, but in an Apache > project, you cannot set rules unilaterally. No one person has that authority > over the project. We all all equals. Decisions can only be made with > concurrence from other team members and we can only get

Re: Should we relax precheck a little bit?

Pre- or post- processor I meant, depending on what would work best. -adam On Sun, Mar 8, 2020 at 2:29 PM Adam Feuer wrote: > Thanks Greg. I haven't tried indent, I will try it with the config you > suggest, if it can get close I'll try a pre-processor script with it too. > > -adam > > On Sun,

Re: Should we relax precheck a little bit?

Thanks Greg. I haven't tried indent, I will try it with the config you suggest, if it can get close I'll try a pre-processor script with it too. -adam On Sun, Mar 8, 2020 at 2:21 PM Gregory Nutt wrote: > The best pretty printer for NuttX that I am aware of is still > tools/indent.sh. It

Re: Re: Should we relax precheck a little bit?

Thanks Peter! I will try out your config. If it can get close, I will see if I can create a post-processor like David said. cheers adam On Sun, Mar 8, 2020 at 2:09 PM Peter Van Der Perk wrote: > Hi Adam, > > I've been trying to make a clang-format for NuttX however I did run in > some nasty

Re: Should we relax precheck a little bit?

The best pretty printer for NuttX that I am aware of is still tools/indent.sh.  It consistently screws up a few things (as listed in tools/README.txt).  But the screw-ups are relatively easy and probably could be postprocesses.  The astyle and uncrustify stuff in tools/ is pretty must useles.

RE: Re: Should we relax precheck a little bit?

Hi Adam, I've been trying to make a clang-format for NuttX however I did run in some nasty bugs with clang-format. Mostly the inconsistent spacing caused by preprocessor directives (#ifdef) etc. I've filed a bug on the LLVM bugtracker (https://bugs.llvm.org/show_bug.cgi?id=44843) unfortunely I

Re: FW: Should we relax precheck a little bit?

-Original Message- > From: Adam Feuer [mailto:a...@starcat.io] > Sent: Sunday, March 08, 2020 9:11 AM > To: dev@nuttx.apache.org > Subject: Re: Should we relax precheck a little bit? > > Thanks David. I'll try your approach. If there are some things that don't > qui

FW: Should we relax precheck a little bit?

:11 AM To: dev@nuttx.apache.org Subject: Re: Should we relax precheck a little bit? Thanks David. I'll try your approach. If there are some things that don't quite work with Clang-Format (I already found a few) I'll see about adding a fixup script pass at the end, or contributing some rules b

Re: Should we relax precheck a little bit?

on the set so it would get all the > constructs at once. > > David > > -Original Message- > From: Adam Feuer [mailto:a...@starcat.io] > Sent: Saturday, March 07, 2020 4:01 PM > To: dev@nuttx.apache.org > Subject: Re: Should we relax precheck a little bit? > > Since there

Re: Should we relax precheck a little bit?

Hi, Xiang, I basically agree with most of the things you say here, but in an Apache project, you cannot set rules unilaterally.  No one person has that authority over the project.  We all all equals.  Decisions can only be made with concurrence from other team members and we can only get

Re: Should we relax precheck a little bit?

Hi, > But how we measure the release become better and better? Very simply you succeeded if you attract more users and committers. Being welcoming to new committers and having a simple process which that are able to take part helps that. I think you are looking though this from a technical

RE: Should we relax precheck a little bit?

and run it on the set so it would get all the constructs at once. David -Original Message- From: Adam Feuer [mailto:a...@starcat.io] Sent: Saturday, March 07, 2020 4:01 PM To: dev@nuttx.apache.org Subject: Re: Should we relax precheck a little bit? Since there's no current maintainer

Re: Should we relax precheck a little bit?

> > From: Xiang Xiao [mailto:xiaoxiang781...@gmail.com] > > Sent: Saturday, March 07, 2020 10:11 AM > > To: dev@nuttx.apache.org > > Subject: Should we relax precheck a little bit? > > > > Hi all, > > The precheck ensure the whole file content comform to the

Re: Should we relax precheck a little bit?

On Sun, Mar 8, 2020 at 4:52 PM Justin Mclean wrote: > > Hi, > > > Yes, this is the key point why I am asking this question: we need > > stable the mainline and make the first apache release. > > Apache doesn’t actually care if your release works or not [*], it not an ASF > requirement that a

Re: Should we relax precheck a little bit?

Hi, > Yes, this is the key point why I am asking this question: we need > stable the mainline and make the first apache release. Apache doesn’t actually care if your release works or not [*], it not an ASF requirement that a build must pass all tests. What matters is that the next build is

Re: Should we relax precheck a little bit?

On Sun, Mar 8, 2020 at 2:50 AM Alan Carvalho de Assis wrote: > > Hi Xiang, > > Normally Greg, Abdelatif, I and others are fixing these nxstyles > issues when someone submit a patch. It is described in the legacy > process of merging PR: >

Re: Should we relax precheck a little bit?

o Expediency is not a justification for violating the coding standard. > > -Original Message- > From: Xiang Xiao [mailto:xiaoxiang781...@gmail.com] > Sent: Saturday, March 07, 2020 10:11 AM > To: dev@nuttx.apache.org > Subject: Should we relax precheck a little bit? > > Hi

Re: Should we relax precheck a little bit?

On Sat, Mar 7, 2020 at 4:30 PM Gregory Nutt wrote: > The acceptance test is this: > > You run the program against all .c and .h files under sched and the > output is 100% compatible with the input you win. One byte different > you lose. Hundreds hours have gone into this challenge and all have

Re: Should we relax precheck a little bit?

Since there's no current maintainer for nxstyle... What would people think about trying Clang-Format ? It's a well-used tool (LLVM, Google, Chromium, Mozilla, Webkit, and Microsoft ), and can

Re: Should we relax precheck a little bit?

Since there's no current maintainer for nxstyle... What would people think about trying Clang-Format ? It's a well-used tool (LLVM, Google, Chromium, Mozilla, Webkit, and Microsoft ), and can be

Re: Should we relax precheck a little bit?

+1 for fixing nxstyle (or configuring another tool like Clang Format ) That would make it a lot easier to submit PRs that are in the right format, at least :) There is no one dedicated to maintaining nxstyle right now.  I wrote the original*,

Re: Should we relax precheck a little bit?

+1 for fixing nxstyle (or configuring another tool like Clang Format ) That would make it a lot easier to submit PRs that are in the right format, at least :) -adam On Sat, Mar 7, 2020 at 11:44 AM Gregory Nutt wrote: > But, on the other hand, in

Re: Should we relax precheck a little bit?

But, on the other hand, in the future, wei will want the full checks enabled.  So it seems to me the options are: - Disable full checking temporarily and focus on eliminating the problems, or - Let things continue as they are.. accept a little pain and get things in shape. To me, there are

Re: Should we relax precheck a little bit?

Hi Xiang, Normally Greg, Abdelatif, I and others are fixing these nxstyles issues when someone submit a patch. It is described in the legacy process of merging PR: https://acassis.wordpress.com/2020/01/02/the-old-way-nuttx-workflow/ I don't know if it is fair or unfair to share/transfer this

RE: Should we relax precheck a little bit?

: Should we relax precheck a little bit? Hi all, The precheck ensure the whole file content comform to the coding style, this strategy has several problems: 1.Many source file in mainline already violate the coding style 2.nxstyle frequently generate the false alarm in the current stage How about

Should we relax precheck a little bit?

Hi all, The precheck ensure the whole file content comform to the coding style, this strategy has several problems: 1.Many source file in mainline already violate the coding style 2.nxstyle frequently generate the false alarm in the current stage How about we let precheck just ensure the modified