Re: Payment solutions & process

2015-11-23 Thread Adrian Crum
. It takes time to dig through the code, but once you figure it out, it is easy to set up. Adrian Crum Sandglass Software www.sandglass-software.com On 11/23/2015 1:27 AM, Pierre Smits wrote: Hi all, While working on the omultisafepay component ( http://oem.ofbizci.net/oci-2/products/p_omultisafepay) I

[jira] [Closed] (OFBIZ-6737) block sites

2015-11-19 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-6737. -- Resolution: Invalid Fix Version/s: (was: 14.12.01) > block si

[jira] [Commented] (OFBIZ-6726) Update commons collections 3.2.1 because of known possible exploit

2015-11-18 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011392#comment-15011392 ] Adrian Crum commented on OFBIZ-6726: It would be nice if we had more information about the exploit

[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-11-16 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007123#comment-15007123 ] Adrian Crum commented on OFBIZ-5608: Please review this code: MacroFormRenderer.java, line 549

[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-11-16 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006941#comment-15006941 ] Adrian Crum commented on OFBIZ-5608: Look at ModelFormField.java, line 339 and 345. The short format

[jira] [Comment Edited] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-11-16 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007431#comment-15007431 ] Adrian Crum edited comment on OFBIZ-5608 at 11/16/15 10:02 PM: --- The attached

[jira] [Updated] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-11-16 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-5608: --- Attachment: DateField_2.jpg DateField_1.jpg The attached screenshots sow the problem

Re: svn commit: r1714691 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java

2015-11-16 Thread Adrian Crum
various framework things work), but it is not a best practice for Java in general. Adrian Crum Sandglass Software www.sandglass-software.com On 11/16/2015 2:00 PM, jler...@apache.org wrote: Author: jleroux Date: Mon Nov 16 22:00:52 2015 New Revision: 1714691 URL: http://svn.apache.org/viewvc?rev

[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-11-16 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007485#comment-15007485 ] Adrian Crum commented on OFBIZ-5608: Exactly! I have gone down that road many times trying to fix

Re: svn commit: r1714652 - in /ofbiz/trunk: applications/content/src/org/ofbiz/content/content/ applications/content/src/org/ofbiz/content/data/ applications/order/src/org/ofbiz/order/thirdparty/taxwa

2015-11-16 Thread Adrian Crum
java:231) [java] Java Result: 1 Adrian Crum Sandglass Software www.sandglass-software.com On 11/16/2015 11:02 AM, jler...@apache.org wrote: Author: jleroux Date: Mon Nov 16 19:02:25 2015 New Revision: 1714652 URL: http://svn.apache.org/viewvc?rev=1714652=rev Log: No functional change, complete

Re: svn commit: r1711019 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/invoice/In voiceServices.xml

2015-11-08 Thread Adrian Crum
minilang.properties: # Enable mini-language auto-correction. If set to true, mini-language will attempt # to correct common syntax errors. The corrections are saved in the original # source file. autocorrect=false Adrian Crum Sandglass Software www.sandglass-software.com On 11/8/2015 5:26

Re: Security Permission being Viewable

2015-11-06 Thread Adrian Crum
There was a security redesign that was discussed a few years ago, but interest in it dropped off: https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Security+Redesign Adrian Crum Sandglass Software www.sandglass-software.com On 11/6/2015 1:04 AM, simon maskell wrote: Hi We are looking

[jira] [Commented] (OFBIZ-6210) Replace EntityUtilProperties with EntityClassLoader

2015-11-06 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993902#comment-14993902 ] Adrian Crum commented on OFBIZ-6210: Thank you for taking the time to review the code. I won't be able

[jira] [Commented] (OFBIZ-6712) Increase the number of EntityUtilProperties methods which really use getSystemPropertyValue()

2015-11-05 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992205#comment-14992205 ] Adrian Crum commented on OFBIZ-6712: Yes, I see what you are trying to do. What YOU are not seeing

[jira] [Commented] (OFBIZ-6712) Increase the number of EntityUtilProperties methods which really use getSystemPropertyValue()

2015-11-05 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992381#comment-14992381 ] Adrian Crum commented on OFBIZ-6712: Have you tested the performance impact of the current

[jira] [Commented] (OFBIZ-6712) Increase the number of EntityUtilProperties methods which really use getSystemPropertyValue()

2015-11-05 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992144#comment-14992144 ] Adrian Crum commented on OFBIZ-6712: You are contradicting yourself. You describe an alternative

[jira] [Commented] (OFBIZ-6712) Increase the number of EntityUtilProperties methods which really use getSystemPropertyValue()

2015-11-05 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14991860#comment-14991860 ] Adrian Crum commented on OFBIZ-6712: NO NO NO!!! You cannot replace UtilProperties

Re: Widget-Style

2015-11-01 Thread Adrian Crum
s style should style all of the elements it contains." and here: https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+maincss.css+HTML+Element+Collection+Styles Don't assume the widget code is correct. It may be in need of an update. Adrian Crum Sandglass Software www.sandglass-software.co

Re: Practices involving source-code repositories

2015-11-01 Thread Adrian Crum
We follow a best practice of limiting a commit to fixing only one thing. That approach provides the ability to revert the commit should something go wrong. Reverting a single fix is easier than reverting a small portion of a larger commit. Adrian Crum Sandglass Software www.sandglass

Re: svn commit: r1711019 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/invoice/In voiceServices.xml

2015-10-31 Thread Adrian Crum
Keep in mind that Mini-language has a setting where it automatically updates source files to the latest grammar and formats them. Adrian Crum Sandglass Software www.sandglass-software.com On 10/31/2015 2:45 AM, Jacques Le Roux wrote: To have an idea I tried this https://stackoverflow.com

Re: [FRAMEWORK] Notes from Skype Meeting - 23rd Oct 2015

2015-10-31 Thread Adrian Crum
Thanks Sharan! The link you provided doesn't work. I think this is the page you were referring to: https://cwiki.apache.org/confluence/display/OFBIZ/Potential+Framework+Project+for+the+Foundation+Sub+Component Adrian Crum Sandglass Software www.sandglass-software.com On 10/31/2015 2:36 AM

[jira] [Commented] (OFBIZ-6704) Creating & Closing Custom Time Periods

2015-10-29 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980325#comment-14980325 ] Adrian Crum commented on OFBIZ-6704: https://ci.apache.org/projects/ofbiz/site/javadocs/org/ofbiz/base

Re: svn commit: r1709272 - in /ofbiz/trunk/applications/humanres: entitydef/entitymodel.xml entitydef/entitymodel_old.xml ofbiz-component.xml script/org/ofbiz/humanres/UpgradeServices.xml servicedef/s

2015-10-29 Thread Adrian Crum
KEY (PAY_GRADE_ID) REFERENCES OFBIZ.PAY_GRADE (PAY_GRADE_ID) Error was: java.sql.SQLException: Constraint 'SLRY_STP_PGRD' already exists in Schema 'OFBIZ'. Adrian Crum Sandglass Software www.sandglass-software.com On 10/18/2015 5:29 AM, jler...@apache.org wrote: Author: jleroux Date: Sun Oct 18 12:29:37 2

Re: A rant I could not hold (read: wanted to share)

2015-10-27 Thread Adrian Crum
Building out the documentation in the XSDs would be a huge step in the right direction. Adrian Crum Sandglass Software www.sandglass-software.com On 10/27/2015 1:12 AM, Jacques Le Roux wrote: Hi All, Don't take this too seriously, it's only a thought that crossed my mind while reading

Re: svn commit: r1710527 - in /ofbiz/trunk/framework/widget: src/org/ofbiz/widget/renderer/ src/org/ofbiz/widget/renderer/macro/ templates/

2015-10-26 Thread Adrian Crum
A reminder for all committers: Before committing, run - ant clean-all load-demo run-tests Adrian Crum Sandglass Software www.sandglass-software.com On 10/26/2015 11:51 AM, Jacques Le Roux wrote: Thanks Deepak, Indeed, I did not clean before building so it passed. I revert... Jacques Le 26

Re: Removing Javolution and resolving sax implementation - OFBIZ-5169

2015-10-23 Thread Adrian Crum
https://docs.oracle.com/javase/tutorial/jaxp/sax/parsing.html https://issues.apache.org/jira/browse/OFBIZ-2390 Adrian Crum Sandglass Software www.sandglass-software.com On 10/23/2015 7:20 AM, Taher Alkhateeb wrote: Hi Adrian, I believe xerces also already exists in the project. Which one

Re: Removing Javolution and resolving sax implementation - OFBIZ-5169

2015-10-23 Thread Adrian Crum
Xerces would be fine, but we already have a pull parser in the project (an XStream dependency): http://www.extreme.indiana.edu/xgws/xsoap/xpp/ Adrian Crum Sandglass Software www.sandglass-software.com On 10/23/2015 1:10 AM, Taher Alkhateeb wrote: Hi everyone, I need some help and guidance

[jira] [Commented] (OFBIZ-4090) Add Support For Compound Screen Widget XML Files

2015-10-21 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966824#comment-14966824 ] Adrian Crum commented on OFBIZ-4090: The implementation basically worked, but the Eclipse editor

[jira] [Commented] (OFBIZ-6691) Remove tooltip="${uiLabelMap.CommonRequired}" from fields

2015-10-21 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967701#comment-14967701 ] Adrian Crum commented on OFBIZ-6691: Originally, OFBiz marked required fields with an asterisk

Re: [jira] [Resolved] (OFBIZ-1993) LoginWorker.makeLoginUrl doesn't include path info URL parameters

2015-10-20 Thread Adrian Crum
Taher, If the issue was fixed (it was), then close it as Fixed - with a reference to the revision that fixed it. Adrian Crum Sandglass Software www.sandglass-software.com On 10/20/2015 1:57 PM, Taher Alkhateeb (JIRA) wrote: [ https://issues.apache.org/jira/browse/OFBIZ-1993?page

Re: Why A Framework Rewrite Is Necessary

2015-10-19 Thread Adrian Crum
Sharan, Please move the child pages also. The structure I had was: Vision | |_ Implementation Overview | |___ Implementation Details A | |___ Implementation Details B | . . . Adrian Crum Sandglass

Re: Why A Framework Rewrite Is Necessary

2015-10-18 Thread Adrian Crum
it to a less restrictive area. Adrian Crum Sandglass Software www.sandglass-software.com On 10/18/2015 2:21 PM, Taher Alkhateeb wrote: Hello Everyone, Like Ron I also find the suggestion from David logical and sensible. We can perhaps start with a design for interfaces and XSDs as a first step

Re: svn commit: r1709213 - in /ofbiz/trunk/applications: commonext/widget/CommonScreens.xml content/src/org/ofbiz/content/data/DataEvents.java product/config/ProductUiLabels.xml

2015-10-17 Thread Adrian Crum
ƒ³ โปรแกรมจัดการรูปภาพ Ứng dụng quản lý hình ảnh Maybe you meant xml:lang="fr" ? Adrian Crum Sandglass Software www.sandglass-software.com

[jira] [Commented] (OFBIZ-5534) Dirty reads from entity cache

2015-10-17 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14961924#comment-14961924 ] Adrian Crum commented on OFBIZ-5534: FYI - my pk cache fix worked, but there were a number of bug

Re: Why A Framework Rewrite Is Necessary

2015-10-17 Thread Adrian Crum
Thanks David! I agree with most of it, but... (inline) Adrian Crum Sandglass Software www.sandglass-software.com On 10/17/2015 11:07 AM, David E. Jones wrote: This message has a lot of the right questions to ask about a new framework. A big part of why the OFBiz framework suffers is because

Re: Why A Framework Rewrite Is Necessary

2015-10-16 Thread Adrian Crum
That discussion occurred in April, and a vote was taken: http://ofbiz.135035.n4.nabble.com/VOTE-Begin-Replacing-OFBiz-Framework-With-Moqui-td4667500.html Adrian Crum Sandglass Software www.sandglass-software.com On 10/16/2015 8:51 AM, Ron Wheeler wrote: Is there any enthusiasm

[jira] [Assigned] (OFBIZ-6405) Grid widget requires cache clear before modifications are rendered

2015-10-16 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-6405: -- Assignee: Adrian Crum > Grid widget requires cache clear before modifications are rende

[jira] [Closed] (OFBIZ-6405) Grid widget requires cache clear before modifications are rendered

2015-10-16 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-6405. -- Resolution: Fixed Fix Version/s: Upcoming Branch Fixed in rev 1709. Thanks! > Grid wid

Re: Why A Framework Rewrite Is Necessary

2015-10-16 Thread Adrian Crum
Ron, Please stop referring to Foundation. I only referenced that library to make a point about how much easier it is come up with better designs when you start with a clean slate. Otherwise, it has no bearing on this discussion. Adrian Crum Sandglass Software www.sandglass-software.com

Re: Why A Framework Rewrite Is Necessary

2015-10-15 Thread Adrian Crum
responsibility to fix them, not ours. If we created a sub-project, then we would have the opportunity to review committer permissions and perhaps restrict access to the new code. Adrian Crum Sandglass Software www.sandglass-software.com On 10/15/2015 6:34 AM, Al Byers wrote: I was waiting for someone

Why A Framework Rewrite Is Necessary

2015-10-14 Thread Adrian Crum
to a simplified API Easier framework code maintenance Better reliability Conclusion -- Like I said at the start, this is all I will say about the subject. I'm done trying to convince everyone. I hope someone agrees with me and they are able to build support for the idea. --

Re: Why A Framework Rewrite Is Necessary

2015-10-14 Thread Adrian Crum
together. Ron On 14/10/2015 3:21 PM, Adrian Crum wrote: I understand that Sharan brought up the framework rewrite subject at ApacheCon, and some attendees felt that the framework is fine and no action needs to be taken. In this message, I will try to give a detailed explanation of why a framework

Re: Why A Framework Rewrite Is Necessary

2015-10-14 Thread Adrian Crum
ly amazing code in OFBiz came from collaboration within the community, and my hope was our skilled developers would all pitch in and help with the design. But that never happened. Maybe Sharan will have better luck. Adrian Crum Sandglass Software www.sandglass-software.com On 10/14/2015 5:

Re: Why A Framework Rewrite Is Necessary

2015-10-14 Thread Adrian Crum
I agree that a sub-project would be nice to have. Once the new framework is up and running, applications could be pulled down and adapted to it. Adrian Crum Sandglass Software www.sandglass-software.com On 10/14/2015 5:53 PM, Ron Wheeler wrote: This seems to be very good advice. A completely

[jira] [Commented] (OFBIZ-6654) Display of a recurrent workeffort in workeffort calendar do not respect estimatedStart/CompletionDate

2015-09-25 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14908712#comment-14908712 ] Adrian Crum commented on OFBIZ-6654: The good news is the expression recognized September 7

[jira] [Commented] (OFBIZ-6654) Display of a recurrent workeffort in workeffort calendar do not respect estimatedStart/CompletionDate

2015-09-25 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14908788#comment-14908788 ] Adrian Crum commented on OFBIZ-6654: Using the actual date-time fields does not make sense

Re: svn commit: r1705136 - /ofbiz/trunk/specialpurpose/scrum/script/org/ofbiz/scrum/ScrumEvents.xml

2015-09-24 Thread Adrian Crum
Actually, the element is unnecessary. Mini-language will create a new Map automatically. Adrian Crum Sandglass Software www.sandglass-software.com On 9/24/2015 1:28 PM, jler...@apache.org wrote: Author: jleroux Date: Thu Sep 24 20:28:21 2015 New Revision: 1705136 URL: http://svn.apache.org

[jira] [Commented] (OFBIZ-6637) Work Effort Month Calendar View Is Broken

2015-09-22 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903650#comment-14903650 ] Adrian Crum commented on OFBIZ-6637: Thank you for working on this! > Work Effort Month Calendar V

[jira] [Commented] (OFBIZ-6647) Refactoring to consolidate different Calendar implementations

2015-09-21 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14900893#comment-14900893 ] Adrian Crum commented on OFBIZ-6647: ICU4J was chosen for 2 reasons: 1. Better calendar selection

[jira] [Commented] (OFBIZ-6642) Non-breaking space incorrectly encoded in forms

2015-09-20 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14900079#comment-14900079 ] Adrian Crum commented on OFBIZ-6642: It would be best to get rid of the HTML markup. Just use plain

[jira] [Created] (OFBIZ-6637) Work Effort Month Calendar View Is Broken

2015-09-19 Thread Adrian Crum (JIRA)
Adrian Crum created OFBIZ-6637: -- Summary: Work Effort Month Calendar View Is Broken Key: OFBIZ-6637 URL: https://issues.apache.org/jira/browse/OFBIZ-6637 Project: OFBiz Issue Type: Bug

[jira] [Commented] (OFBIZ-6637) Work Effort Month Calendar View Is Broken

2015-09-19 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14877196#comment-14877196 ] Adrian Crum commented on OFBIZ-6637: It might be caused by having a recurring work effort that uses

[jira] [Commented] (OFBIZ-6637) Work Effort Month Calendar View Is Broken

2015-09-19 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14877195#comment-14877195 ] Adrian Crum commented on OFBIZ-6637: The problem exists on my local unmodified copy, and it also

[jira] [Commented] (OFBIZ-6621) MapContext.entrySet() slows down when ByteBuffer objects are in the context

2015-09-16 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14781586#comment-14781586 ] Adrian Crum commented on OFBIZ-6621: Since ListSet.java is a special purpose class meant to be used

[jira] [Commented] (OFBIZ-6614) Error when using org.ofbiz.base.util.UtilDateTime.toTimestamp("12/30/1899 00:00:00")

2015-09-11 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740968#comment-14740968 ] Adrian Crum commented on OFBIZ-6614: Most likely there is a flaw in your code. Try using the methods

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-23 Thread Adrian Crum
Project-Properties-Java Build Path-Libraries tab. Adrian Crum Sandglass Software www.sandglass-software.com On 8/23/2015 3:09 AM, Jacques Le Roux wrote: Is there a classpath editor in Eclipse? Jacques Le 23/08/2015 11:35, Scott Gray a écrit : I've always assumed everybody manually edits

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-23 Thread Adrian Crum
I agree that it's not a big deal. There have been a few times when I was about to commit a change and I spotted the tabs, so I changed it back to spaces before committing. It's like that ftrue setting that we used to have somewhere. It kept confusing people so we changed it. Adrian Crum

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-22 Thread Adrian Crum
Thank you for fixing this Jacques! Adrian Crum Sandglass Software www.sandglass-software.com On 8/21/2015 2:11 PM, Jacques Le Roux wrote: OK I think I see your point now https://www.genuitec.com/forums/topic/eclipse-adding-to-classpath-file-uses-tabs/ Right? Jacques Le 21/08/2015 23:09

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-21 Thread Adrian Crum
Your preference is irrelevant. The format of the file is controlled by Eclipse, not by Jacques. We will continue to have this problem until the file format is corrected in the repo. Adrian Crum Sandglass Software www.sandglass-software.com On 8/21/2015 8:14 AM, Jacques Le Roux wrote: The pb

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-21 Thread Adrian Crum
Tabs instead of spaces. Adrian Crum Sandglass Software www.sandglass-software.com On 8/21/2015 1:06 PM, Jacques Le Roux wrote: Le 21/08/2015 17:44, Adrian Crum a écrit : Your preference is irrelevant. The format of the file is controlled by Eclipse, not by Jacques. We will continue to have

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-21 Thread Adrian Crum
Correct. The format in our repo is wrong, and every new committer who changes a library in the project will have this same problem. If the file in the repo was in the correct format, then you would have seen what you wanted - only the file changes, not the whole file. Adrian Crum Sandglass

Re: Should we revert 1530237?

2015-08-21 Thread Adrian Crum
I had a problem with a deployment using the new Postgres field types. Once an application is built using those field types, you can't switch it to another database. I recommend we remove the file completely and go back to the original Postgres field types file. Adrian Crum Sandglass

Re: svn commit: r1696950 - /ofbiz/trunk/.classpath

2015-08-21 Thread Adrian Crum
This should be reverted. Eclipse will turn the spaces back to tabs when it reads the file - so this change has no effect. Adrian Crum Sandglass Software www.sandglass-software.com On 8/21/2015 5:03 AM, jler...@apache.org wrote: Author: jleroux Date: Fri Aug 21 12:03:00 2015 New Revision

Re: svn commit: r1695126 [1/22] - in /ofbiz/trunk: applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/ applications/accounting/src/org/ofbiz/accounting/thirdparty/securepay/ a

2015-08-10 Thread Adrian Crum
I'm confused. We have always used the OFBiz-recommended Subversion settings: https://ofbiz.apache.org/svn/config Has that changed? Adrian Crum Sandglass Software www.sandglass-software.com On 8/10/2015 9:15 AM, jler...@apache.org wrote: Author: jleroux Date: Mon Aug 10 16:15:37 2015 New

Re: svn commit: r1693579 - /ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/actions/entity/Enti tySQLProcessor.groovy

2015-08-01 Thread Adrian Crum
Nonsense. All you have to do is put (see OFBIZ-6567) in the commit log instead of in the code. This is what we have done for years and I don't understand why you are changing it. Adrian Crum Sandglass Software www.sandglass-software.com On 8/1/2015 3:29 AM, Jacques Le Roux wrote: Because

Re: svn commit: r1693579 - /ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/actions/entity/EntitySQLProcessor.groovy

2015-07-31 Thread Adrian Crum
Why are we putting Jira issue numbers in code comments? It was my understanding that this type of meta-data belongs in the commit message. Adrian Crum Sandglass Software www.sandglass-software.com On 7/31/2015 4:56 AM, jler...@apache.org wrote: Author: jleroux Date: Fri Jul 31 11:56:58 2015

Re: svn commit: r1693258 - /ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl

2015-07-29 Thread Adrian Crum
Wouldn't it be simpler to use #escape x as x?html ? Adrian Crum Sandglass Software www.sandglass-software.com On 7/29/2015 6:33 AM, jler...@apache.org wrote: Author: jleroux Date: Wed Jul 29 13:33:12 2015 New Revision: 1693258 URL: http://svn.apache.org/r1693258 Log: Fixes an issue crossed

[jira] [Commented] (OFBIZ-6561) GenericDelegator.store fails to clear userLogin cache on password update from ecommerce profile

2015-07-27 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14642917#comment-14642917 ] Adrian Crum commented on OFBIZ-6561: Reverting rev 1668267 will probably fix

Re: Deprecate find-by-primary-key in Minilang?

2015-06-29 Thread Adrian Crum
If these changes are made, then please update the Mini-lang auto-correcting code so that it produces the new grammar. Adrian Crum Sandglass Software www.sandglass-software.com On 6/29/2015 8:53 AM, Jacques Le Roux wrote: Hi, We have deprecated findByPrimaryKey() in favour of findOne

[jira] [Commented] (OFBIZ-6537) Unable to change users timezone for session

2015-06-26 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14603079#comment-14603079 ] Adrian Crum commented on OFBIZ-6537: I can confirm this is a bug in the trunk

[jira] [Closed] (OFBIZ-6538) How I can place an order for sale, according to a sales agreement already made?

2015-06-26 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-6538. -- Resolution: Invalid Please ask your questions on the user mailing list. How I can place an order

[jira] [Commented] (OFBIZ-6537) Unable to change users timezone for session

2015-06-26 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14603693#comment-14603693 ] Adrian Crum commented on OFBIZ-6537: The problem is caused by rev 1668267. I will try

[jira] [Assigned] (OFBIZ-6537) Unable to change users timezone for session

2015-06-26 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-6537: -- Assignee: Adrian Crum Unable to change users timezone for session

[jira] [Commented] (OFBIZ-6531) Support transaction-timout for simple-method

2015-06-25 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14601245#comment-14601245 ] Adrian Crum commented on OFBIZ-6531: What is the patch supposed to do? Support

[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-06-25 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14601397#comment-14601397 ] Adrian Crum commented on OFBIZ-5608: I need to know if the patch solves your problem

[jira] [Commented] (OFBIZ-6531) Support transaction-timout for simple-method

2015-06-25 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14601352#comment-14601352 ] Adrian Crum commented on OFBIZ-6531: The patch does not do what you describe

[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-06-24 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600234#comment-14600234 ] Adrian Crum commented on OFBIZ-5608: Thank you Gareth! I think we need an option

[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-06-24 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600253#comment-14600253 ] Adrian Crum commented on OFBIZ-5608: The Derby driver will round the time component

[jira] [Updated] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2015-06-24 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-5608: --- Attachment: IgnoreTimeZone.patch Gareth - try out the attached file: IgnoreTimeZone.patch. I added

Re: [DISCUSSION] Bootstrap Themes - is it trunk ready?

2015-06-23 Thread Adrian Crum
be nice to drop one or two existing themes. Adrian Crum Sandglass Software www.sandglass-software.com On 6/23/2015 2:08 AM, Pierre Smits wrote: Hi all, Recently we have seen that great strides have been made with respect to widget refactoring, theme functions disentanglement from framework ( OFBIZ

Re: [DISCUSSION] Bootstrap Themes - is it trunk ready?

2015-06-23 Thread Adrian Crum
I evaluated the bootstrap branch as it currently exists. If there are patches waiting to be applied to the branch, then I am not aware of them. Adrian Crum Sandglass Software www.sandglass-software.com On 6/23/2015 12:43 PM, Pierre Smits wrote: Hi Adrian, Thanks for the feedback

Re: svn commit: r1686651 - /ofbiz/trunk/applications/order/entitydef/entitymodel_view.xml

2015-06-20 Thread Adrian Crum
This commit generates this error: 2015-06-20 09:42:56,054 |delegator-startup-1 |ModelViewEntity |E| [OrderItemQuantityReportGroupByProduct]: [ModelViewEntity.populateFields] ERROR: could not find ModelField for entity name: ItemIssuanceQuantitySum and field: issuedDateTime Adrian

[jira] [Closed] (OFBIZ-6362) Move js css references from CommonDecorator(s) to themes

2015-06-20 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-6362. -- Resolution: Fixed Fix Version/s: Upcoming Branch Fixed in rev 1686655. I did not add the new

[jira] [Commented] (OFBIZ-6334) Widget Refactoring: Have 'request-confirmation' and 'confirmation-message' available for screens and menus

2015-06-20 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14594718#comment-14594718 ] Adrian Crum commented on OFBIZ-6334: The 'request-confirmation' and 'confirmation

[jira] [Assigned] (OFBIZ-6334) Widget Refactoring: Have 'request-confirmation' and 'confirmation-message' available for screens and menus

2015-06-20 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-6334: -- Assignee: Adrian Crum Widget Refactoring: Have 'request-confirmation' and 'confirmation

[jira] [Commented] (OFBIZ-6334) Widget Refactoring: Have 'request-confirmation' and 'confirmation-message' available for screens and menus

2015-06-20 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14594756#comment-14594756 ] Adrian Crum commented on OFBIZ-6334: Widget models and schemas updated in rev 168

Re: svn commit: r1686667 - in /ofbiz/trunk/applications: order/servicedef/ party/config/ party/servicedef/ party/src/org/ofbiz/party/party/ party/webapp/partymgr/WEB-INF/actions/party/ party/widget/pa

2015-06-20 Thread Adrian Crum
Please do not hard-code the widget default view size. Get the value from the widget.form.defaultViewSize property in widgets.properties. Adrian Crum Sandglass Software www.sandglass-software.com On 6/20/2015 12:43 PM, nma...@apache.org wrote: Author: nmalin Date: Sat Jun 20 19:43:49 2015 New

[jira] [Updated] (OFBIZ-6334) Widget Refactoring: Have 'request-confirmation' and 'confirmation-message' available for screens and menus

2015-06-20 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-6334: --- Priority: Minor (was: Major) Affects Version/s: Upcoming Branch

[jira] [Commented] (OFBIZ-6516) Facilitate the use of Icons in Ofbiz by adding descriptive style to the widget-style attribute in forms

2015-06-19 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14593624#comment-14593624 ] Adrian Crum commented on OFBIZ-6516: That needs to go away. Buttons are styled

[jira] [Commented] (OFBIZ-6516) Facilitate the use of Icons in Ofbiz by adding descriptive style to the widget-style attribute in forms

2015-06-18 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14592187#comment-14592187 ] Adrian Crum commented on OFBIZ-6516: I don't think buttontext is a valid CSS class

Re: Widget Overhaul

2015-06-14 Thread Adrian Crum
Keep in mind that menu items are rendered as forms for a reason - to fight XSS attacks. So, whatever solution you have in mind should not change that behavior. Adrian Crum Sandglass Software www.sandglass-software.com On 6/14/2015 10:05 AM, Christian Carlow wrote: Thanks Adrian and sorry

Re: Shouldn't PORTALPAGE_ADMIN be part of SUPER group permissions?

2015-06-14 Thread Adrian Crum
, it depends on the community's perception of the committer and what that committer feels they can get away with. Adrian Crum Sandglass Software www.sandglass-software.com On 6/14/2015 1:29 AM, Jacques Le Roux wrote: Pierre, Christian, I think Christian asked because I recently told him in a Jira

Re: Widget Overhaul

2015-06-14 Thread Adrian Crum
the screen widget - with sections that can be controlled by conditional elements. Adrian Crum Sandglass Software www.sandglass-software.com On 6/14/2015 3:03 AM, Christian Carlow wrote: Thanks for the feedback Adrian. I check commit logs and see the grid widget additions back in January that you

[jira] [Commented] (OFBIZ-6404) Allow form/grid widget hyperlinks to be grouped into a single column

2015-06-14 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14585212#comment-14585212 ] Adrian Crum commented on OFBIZ-6404: The widget model changes look okay to me. I don't

Re: Widget Overhaul

2015-06-12 Thread Adrian Crum
The grid widget is implemented. Please check the commit logs. The column widget is not intended to implement a grid. It is intended to be used for multi-column layout of screens (like newspaper columns). Adrian Crum Sandglass Software www.sandglass-software.com On 6/11/2015 2:57 PM

Re: Widget Overhaul

2015-06-11 Thread Adrian Crum
The column widget is intended to be used for multi-column layout. It is not a replacement for a grid widget. Adrian Crum Sandglass Software www.sandglass-software.com On 6/11/2015 1:21 PM, Christian Carlow wrote: column-container and column screen widgets seem to have been implemented based

Re: svn commit: r1684042 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/StringUtil.java

2015-06-08 Thread Adrian Crum
Redesign the method. Adrian Crum Sandglass Software www.sandglass-software.com On 6/8/2015 8:15 AM, Taher Alkhateeb wrote: Hi Adrian, The bug is that the pattern @gteq and @gt yield different results depending on which one gets executed first. If you execute the @gt matcher on @gteq you get

Re: svn commit: r1684133 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/condition/EntityFieldMap.java

2015-06-08 Thread Adrian Crum
Please revert this. Removing specific types is NOT an acceptable way to fix compiler errors! Taher - please stop trying to fix compiler warnings/errors by hiding them. Take some time to understand how Java Generics work before you change anything else. Adrian Crum Sandglass Software

Re: svn commit: r1684042 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/StringUtil.java

2015-06-08 Thread Adrian Crum
This commit does not make sense and it is unnecessary. Please revert it. Adrian Crum Sandglass Software www.sandglass-software.com On 6/7/2015 9:03 AM, jler...@apache.org wrote: Author: jleroux Date: Sun Jun 7 16:03:04 2015 New Revision: 1684042 URL: http://svn.apache.org/r1684042 Log

Re: svn commit: r1684042 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/StringUtil.java

2015-06-08 Thread Adrian Crum
By replacing HashMap with LinkedHashMap, you are hiding the real problem. The algorithm should not depend on insertion order, so there is a bug that needs to be fixed. Adrian Crum Sandglass Software www.sandglass-software.com On 6/8/2015 7:58 AM, Taher Alkhateeb wrote: Hi Adrian, In JDK 8

  1   2   3   4   5   6   7   8   9   10   >